Repository navigation
[Fix] Cloud administrators cannot disable anonymous analytics - #3608
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed all 15 changed files and related consent, authorization, browser tracking, setup, and delivery paths. Current-head lint, typecheck, Knip, CodeQL, and docs checks passed; tests and the app Docker build were still running at review completion. Repository validation suites were left to CI. Reviewed ca38a38 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 27, 2026 08:12
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Cloud administrators can use the existing Settings > Deployment > Privacy > Anonymous analytics switch. Their choice persists, setup honors an explicit opt-out, and the shared browser/server decision no longer overrides it in Cloud mode.
Anonymous event delivery rechecks consent before sending a queued batch. The current browser authorization context refreshes after the choice changes. Public privacy/configuration guidance and a patch changeset are included.
Why this change was made
Issue #992 remains reproducible: current develop hides the Cloud control, and submitting
falsereturns and storestrue. A real-database/HTTP regression also showed an already queued anonymous event being delivered after opt-out; delivery now drops that batch.Impact
The existing deployment-wide choice applies to both self-hosted and Cloud deployments. Unset remains enabled. Admin authorization, unrelated metadata, Cloud Memory defaults, diagnostics, completion webhooks and version checks retain their existing behavior. Separate consent-gated PostHog/Intercom behavior is outside this change.
There is no schema, new tracking system, dependency or provider change. The implementation removes the Cloud override and reuses the existing setting/control and telemetry pipeline.
How it was tested
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally — recommended fast gates passed, with all typecheck tasks force-runRelated PRs
Screenshots
Actual local development with the Cloud feature flag enabled; the diagnostics environment remains development. No generated UI/store responses or source simulation. The final source and committed head match.