Repository navigation
[Fix] Source control setup is unusable after a failed status read - #3602
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed both changed files and the surrounding query defaults, provider rendering, and real form state handling. Initial failure, repeated retries, and cached-data draft preservation are covered by the added regressions. CI lint, typecheck, and Knip passed; tests, app build, backup restore, and JavaScript/TypeScript analysis were still running when checked. Repository validation was left to CI. Reviewed 3bef645 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 27, 2026 05:18
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Source Control settings now show a compact, actionable read error when provider configuration status cannot load, rather than presenting the providers as unconfigured. Retry reloads the status in place; the action stays busy during a retry and remains available after another failure.
Provider setup waits for status to load. A failed background read keeps existing provider forms mounted, preserving unsaved edits. Pull request delivery controls and provider connection/sync behavior retain their existing paths.
Why this change was made
On current develop (
eb9dc4b4), aborting the actual configuration-status request and exhausting automatic retries presents “Not configured.” Selecting GitLab setup then exposes guidance without configuration fields, and removing the network failure provides no recovery action. This change makes that unknown state explicit and recoverable without leaving the page.Impact
Users can resume source-control setup after a transient read failure. The change adds one local retry-presentation flag and reuses existing buttons, skeletons and queries; there are no new APIs or dependencies. Provider-specific repository-read failures are outside this change.
How it was tested
pnpm lint:fast,pnpm check-types:fast,pnpm knip, and pre-push gates passed. Hosted tests, build, CodeQL, upgrade/restore and latest Judgement all passed at3bef6458; exact-head automated review found no issues. Successful hosted evaluation resolved the optional local Judgement evidence-collection gap.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally — repository-recommended fast gates passed; full formatting-inclusive commands were not runpnpm changeset— no changeset addedRelated PRs
Screenshots
Actual local application with an induced HTTP-read failure. Error frames show the final readable foreground treatment; recovered frames show actual Retry followed by setup and an unsaved synthetic Application ID. No fabricated successful responses or store state. Earlier red-text error frames are superseded.
Desktop failed read:
Mobile failed read:
Desktop recovered setup:
Mobile recovered setup: