Repository navigation
[Fix] Model search fields have no accessible name - #3605
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed 16918b2 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 27, 2026 05:40
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The searchable model picker now names its focused search input using the picker's existing context, such as “Environment setup model” or “Environment edit model.” The fallback remains “Model.”
Why this change was made
On current develop (
eb9dc4b4), opening the real model popover focuses an unnamed combobox. Its generated label is empty even though the closed trigger has a name. The placeholder does not provide that context in the accessibility tree.Impact
Assistive navigation can identify which model field is being searched. One existing label prop supplies the name; there are no visible UI, state, dependency, search-scoring or handler changes. The small-catalog Select path retains its existing behavior.
How it was tested
16918b25.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally — repository-recommended fast gates passedpnpm changeset— no changeset addedRelated PRs