Skip to content

[Fix] Environment setup actions are clipped on mobile - #3604

Open
roomote-roomote[bot] wants to merge 2 commits into
developfrom
fix/environment-create-mobile-actions-1k5z9hnl597nc
Open

roomote-roomote[bot] wants to merge 2 commits into
developfrom
fix/environment-create-mobile-actions-1k5z9hnl597nc

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

The agent-mode controls on both Create environment and Edit environment now wrap onto additional rows when needed. Desktop keeps each page's existing single-row order and spacing.

Why this change was made

On current develop (eb9dc4b4) at a 390px viewport, Create's model picker extended to 429.8px and Start Agent sat entirely offscreen at 445.8–575.25px. Edit's model picker likewise occupied 370.6–565.8px. The pages could not scroll horizontally, so these setup controls were clipped; focusing Edit's model also displaced the surrounding page.

Impact

The controls remain visible on narrow screens, using one additional layout class per action row and no new state, handlers or dependencies. The controls can share rows when their labels fit, and retain their original order.

How it was tested

  • Measured both actual current-develop pages at 390×844, then repeated with the final two-page fix: all action bounds fit inside the viewport. Desktop 1440×1000 preserves each single aligned row. Four newly inspected frames supersede the earlier Create-only set.
  • Actual mobile interaction on both pages: search/select GPT-6.1 Terra, enter the YAML editor, return to agent setup, and confirm the selected model persists. Edit uses the real seeded environment and repository choices, with enabled Start left untouched. No environment was saved or agent launched.
  • 33 existing CreateEnvironmentPage, EditEnvironmentPage and ModelSelect tests passed; one existing test emitted an act warning. No test asserting CSS classes was added. Pre-push static gates passed for the two-class diff. The optional local Judgement evaluator could not collect evidence; hosted evaluation is tracked on this PR.
  • Create's local repository query reports that GitHub App credentials are not configured. Its retained frames intentionally show that existing prerequisite error and disabled Start Agent. The frames prove layout and the exercised model/YAML paths, not successful provider access or environment creation. Mobile guidance placeholders retain their existing textarea scrolling behavior.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally — repository-recommended fast gates are used
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset — no changeset added

Related PRs

Screenshots

Actual local application and API, without source/store/response simulation. All four final frames were opened and visually inspected. Create's repository prerequisite error is disclosed above; the layout fix does not change that query. Screenshots show stable layouts; interaction observations support the model/YAML transition claims.

Mobile Edit actions with the default model:

Edit environment actions fit on mobile

Desktop Edit after actual model selection and YAML/back:

Edit environment actions retain desktop layout

Mobile Create actions with the default model:

Create environment actions fit on mobile

Desktop Create arrangement:

Create environment actions retain desktop layout

@roomote-community

roomote-community Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

No new code issues found. Reviewed the Edit environment action-row flex-wrap change in context, including button and model-picker sizing; it preserves control order and allows wrapping without changing handlers or state. CI lint, type checks, and Knip passed; tests and the app image build were still running when checked. See session

Reviewed dfd3ec6

@roomote-roomote roomote-roomote Bot changed the title [Fix] Create environment actions are clipped on mobile [Fix] Environment setup actions are clipped on mobile Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant