Skip to content

[Chore] Align runtime configuration tests with shipped Kimi routes - #3603

Merged
mrubens merged 2 commits into
developfrom
fix/kimi-worker-config-expectation-1pn0qy1hk5krr
Oct 27, 2026
Merged

mrubens merged 2 commits into
developfrom
fix/kimi-worker-config-expectation-1pn0qy1hk5krr

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of Daniel Riccio. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

Update the worker and control-plane helper runtime's exhaustive Kimi model expectations to include the shipped k3.1-pro and k3.1-pro-highspeed routes from #3596. This restores both configuration test contracts against the existing production catalog without relaxing the assertions or changing model registration.

How it was tested

  • On untouched develop eb9dc4b4, both actual configuration tests fail: expected four routes, received six. The received additions match the merged provider definitions. A cold-cache serial baseline exposed the helper assertion that cached checks had missed.
  • At exact head f4a71b90, all117 worker agent-home and46 helper opencode-runtime cases pass. Both affected package suites also pass through an actual forced, serial Turbo run (zero cache hits;52.82s), retaining direct/gateway SDK, credential and adjacent provider contracts. Affected types, formatting and normal full pre-push lint/types/Knip gates pass.
  • Test-only, four inserted expectations; no runtime behavior, dependency or new test scaffolding. Browser proof is not applicable. Live provider inference is outside this test-contract claim.
  • At f4a71b90, hosted CI Test, both Docker builds, lint/types/Knip, CodeQL and Judgement pass; exact-head automated review is clean with zero findings/threads. Both affected suites were independently forced fresh locally. An unrelated existing web performance fixture timed out under full cold load and passed unchanged in isolation; it is not modified here. Local advisory Judgement was incomplete; hosted results are clean.
  • An additional serial, forced full-repository attempt reached21/27 completed tasks before the sandbox's10-minute command limit. A pinned-launch compute-default fixture failed under that broader ordering and passed unchanged alone; existing #3467 owns provider-default fixture isolation. This is a retained full-suite limitation, not an unrelated test edit or a full-suite success claim.

Related PRs

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally (normal broad lint:fast and check-types:fast gates passed)
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset (test-only correction)

@roomote-community

roomote-community Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

No new code issues found. See session

Reviewed the helper runtime test update since dce303f. Both added model IDs match the shared Kimi provider registration, and the exhaustive sorted equality assertion and existing SDK/endpoint checks remain intact. Current-head CI Test, Lint, Type Check, and Knip passed; both Docker builds and JavaScript/TypeScript analysis were still running when checked.

Reviewed f4a71b9

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review October 27, 2026 05:22
@roomote-roomote
roomote-roomote Bot marked this pull request as draft October 27, 2026 05:46
@roomote-roomote roomote-roomote Bot changed the title [Chore] Align worker configuration tests with shipped Kimi routes [Chore] Align runtime configuration tests with shipped Kimi routes Oct 27, 2026
@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review October 27, 2026 05:56
@mrubens
mrubens merged commit 71ee50c into develop Oct 27, 2026
38 of 41 checks passed
@mrubens
mrubens deleted the fix/kimi-worker-config-expectation-1pn0qy1hk5krr branch October 27, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants