Skip to content

R4: Prepare Android build verification; stop USDT setup, sends and trading - #7035

Draft
antuz123 wants to merge 22 commits into
release/2.6.3from
codex/android-reproducibility
Draft

antuz123 wants to merge 22 commits into
release/2.6.3from
codex/android-reproducibility

Conversation

@antuz123

@antuz123 antuz123 commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

R4 source CI continuation — 12 October 2026

Current source head: c3b9b37ece19e18ea3198e3bf6aaaf20b05660ab.

The former standalone test failure at 7784bd032 depended on refused connections to a public Electrum server. This follow-up imports only the four deterministic Electrum test/fixture files from contributor #7030 and preserves the standalone client's legacy index-reset API and explicit reconnect coverage. Runtime app code, Android build inputs and the USDT pause/history behavior are unchanged. The source now also imports the exact existing #7045 wrong-key AES test correction: incorrect-key decryption may return a non-plaintext string or throw Malformed UTF-8 data; both outcomes reject the original plaintext. It uses its own fresh ciphertext rather than another test's shared value.

Cloud checks on the new source:

  • Full standalone Jest: 24/24 suites, 307/307 tests passed; focused Electrum client/wallet/vault: 3/3 suites, 54/54 tests passed.
  • Original workflow USDT pause/backup and retired-input Node checks: 34/34 passed after adding an isolated Ruby runtime; the first attempt was blocked by the Cloud environment lacking ruby.
  • Python Android comparison/input-tool unit tests: 10/10 passed. Diff check passed. The standalone legacy version:check command still rejects stale authenticated store baselines; R4: bring the shipped 2.6.3 baseline into sprint #7031 supplies the separation between source consistency and release freshness, and the existing R4: Prepare Android build verification; stop USDT setup, sends and trading #7035 workflow does not run that command. Jest reused the candidate's installed dependencies; runtime dependency maps match, while development lint versions differ. Hosted CI independently installs this source's own declared dependencies.
  • Exact-final-head hosted test 38212998725 passed all steps on c3b9b37ece. Final-head Android diagnostic 38213001757 is still running; no artifact result is claimed until completion.

Independent developer approval remains missing. The PR stays draft on release/2.6.3; after an explicitly authorized #7031 baseline merge, refresh/retarget against sprint and verify the narrowed diff/final checks. This test-only correction removes the fixture dependency on the #7030 merge but does not replace #7030's own approval/contributor acceptance, source approval, native existing-wallet acceptance or release-artifact gates. The combined candidate must retain its #7042 Electrum API/public-failover test reconciliation when integrating this source head.

No PR was merged, artifact published, release signed or production data changed. Reproducibility #7043 and Bitkey Wallet remain separate.

Codex local handoff

State: NEEDS_LOCAL
PR: #7035
Base: release/2.6.3 (retarget to sprint after authorized baseline merge)
Head branch: codex/android-reproducibility
Head commit: c3b9b37
Goal and acceptance criteria: Independently review the USDT pause/existing-wallet behavior and its Android release inputs; source native evidence must match the actual head.
Changes made: Deterministic Electrum and wrong-key AES fixture follow-ups only; existing substantive USDT/Android source remains preserved.
Cloud checks: Full Jest 307/307, focused Electrum 54/54, original Node workflow checks 34/34 and Python Android tools 10/10 passed locally; exact-final-head hosted Tests passed, diagnostic build pending. No native test performed here.
Required local checks: IOS, ANDROID
Local checks requested: After source dependencies/retargeting settle, follow the actual Local gate on the final source SHA. Validate existing USDT wallet read/history/export and paused new setup/transactions with disposable data, and native build inputs. Full coordinated R4 flow/hardware acceptance belongs to #7045's separate exact-head handoff; it does not automatically satisfy this source PR's SHA gate.
Risks / known gaps: Source review, baseline retarget, actual current-head native checks and release artifact readiness remain open. Test-only corrections do not authorize release or reuse native results from another commit. No #7043/Bitkey integration.

Final hosted status

Final-head hosted Tests 38212998725 passed. Android diagnostic 38213001757 passed every step on this source head; it remains a placeholder-config, public-debug-key buildability check, not native flow/production/reproducibility acceptance. Its configuration/signing remain diagnostic only.

Combined candidate #7045 is now a3b87774573fd8d54a05528290c84f12494493bb, with these final source heads integrated and the combined Electrum API/public-peer test reconciliation retained. Its exact Local IOS/ANDROID/HARDWARE handoff is posted; source approvals and native/release delivery remain distinct.

Historical scope and evidence

Scope

  • R4 / 2.6.4 candidate: prepare Android build verification and stop new USDT wallet setup, sending, buy/sell/swap while preserving existing wallets.
  • Add an APK payload comparator, measured v2.6.3 GitHub/Play evidence, a pinned Gradle distribution checksum, and a provisional seven-name future release input checker. Stop App Center from logging generated environment values.
  • Pause new USDT wallet creation/import and USDT buy, sell, and swap. Keep existing wallets, saved Receive addresses, balance/history, backups, and visible Send/Receive. Send explains that it is paused; Receive warns before another deposit.
  • Remove the GasFree and unused swap clients from future mobile builds. Reject retired credential fields in App Center, Android, Fastlane, and early iOS configuration handling. Preserve historical transaction records and label trace-only GasFree requests as status unavailable.
  • Remove the stale SonarCloud workflow inherited from the historical release branch; it was already removed from sprint in Replace SonarCloud with CodeQL and CI linting #7032.

Historical verification

  • Local integration merge 0747e4d includes both original draft heads. The only manual conflict was in appcenter-pre-build.sh; the resolution retains credential checks and avoids printing environment values. A separate R4 preview at e77dabad combines pending baseline R4: bring the shipped 2.6.3 baseline into sprint #7031 with this draft and passes focused recovery, USDT, reproducibility and release checks; it has not been pushed.
  • 31 focused USDT/backup/config tests and 10 reproducibility-tool tests pass. The final head 7afb05f passed GitHub Run Tests and the Android diagnostic build. The latter built and verified a production-flavor APK and AAB with placeholder service values and debug signing; APK SHA-256 c2fa6006181e75801816a4766fde57afe8f4e15a9c9d4892f387e067102b9c34, AAB SHA-256 111e30282bfa69f053beaa67356c8152baabb3b2531398151ae5289aaeec62f9. This is buildability evidence, not a source-to-distributed-binary match. The runner selected JDK 17.0.20 while the provisional input manifest specifies 17.0.19.
  • The 306-test Jest suite passes across 24 suites. This local run used an existing dependency tree for testing; the combined head's GitHub Run Tests workflow subsequently passed after its own dependency install. A clean independent Android build is still pending.
  • bash -n appcenter-pre-build.sh and git diff --check pass. The new diagnostic CI job uses dummy service endpoints and IDs with a public debug key; it does not publish artifacts or claim a reproducibility verdict. Production configuration checks now require ENVIRONMENT=PRODUCTION.
  • Earlier audit: the public v2.6.3 tag built with placeholder config, producing 1,424 matching payload entries and 192 differences against the published GitHub APK. GitHub and official Play code payloads match across channels. Neither result proves a public-source rebuild match.

Product decision and limit

The owner chose to proceed on the assumption of no current USDT users and investigate any legacy case if reported. A funded GasFree contract address cannot send through Keeper in this draft; a working later exit is not yet verified. Existing wallet data and its saved address are retained. No GasFree Relay migration is included solely for reproducibility.

Remaining reproducibility work

This draft is a combined build candidate, not a WalletScrutiny verdict. The seven tracked configuration names and four candidate omissions need release review; exact noncredential production values are not yet committed. A digest-pinned clean Linux build recipe, verified dependency inputs, APK/AAB build, and source-to-published APK/Play-split comparisons are still needed. The historical v2.6.3 binary cannot be changed by this future work. Signing Server route authorization remains separate backend work. The narrow old-migration verifier redaction is open in Signing Server PR #5, not deployed.

The owner selected this combined draft for R4 / 2.6.4. It still targets release/2.6.3 for review against the measured release pipeline. The R4 baseline is pending in #7031; integrate into the actual R4 branch and rerun combined checks before merge. Related: #6097.

@antuz123 antuz123 mentioned this pull request Oct 7, 2026
Keep existing USDT wallets, Send, Receive, history, and backup routes. Remove new wallet creation and import entry points, plus buy, sell, and swap entry points. Leave the legacy GasFree Send implementation intact until a working replacement is verified.
Keep saved USDT wallets, receive addresses, chain reads, history, and backup recovery. Make Send show a pause message and warn before new deposits. Reject retired GasFree and swap credentials in release inputs and direct Android builds.
@antuz123 antuz123 changed the title Add Android APK payload comparison and reproducibility evidence Prepare Android reproducibility build with USDT pause Oct 8, 2026
@antuz123 antuz123 changed the title Prepare Android reproducibility build with USDT pause R4: Prepare Android build verification; stop USDT setup, sends and trading Oct 8, 2026
@antuz123
antuz123 requested a review from Parsh October 9, 2026 13:25

Copy link
Copy Markdown
Collaborator Author

R4 source CI continuation — 12 October 2026

Current source head: 3592ede8832a3b2986fee01339edee717c11c4cd.

The former standalone test failure at 7784bd032 depended on refused connections to a public Electrum server. This follow-up imports only the four deterministic Electrum test/fixture files from contributor #7030 and preserves the standalone client's legacy index-reset API and explicit reconnect coverage. Runtime app code, Android build inputs and the USDT pause/history behavior are unchanged.

Cloud checks on the new source:

  • Full standalone Jest: 24/24 suites, 307/307 tests passed; focused Electrum client/wallet/vault: 3/3 suites, 54/54 tests passed.
  • Original workflow USDT pause/backup and retired-input Node checks: 34/34 passed after adding an isolated Ruby runtime; the first attempt was blocked by the Cloud environment lacking ruby.
  • Python Android comparison/input-tool unit tests: 10/10 passed. Diff check passed. Jest reused the candidate's installed dependencies; runtime dependency maps match, while development lint versions differ. Hosted CI independently installs this source's own declared dependencies.
  • Exact-head hosted test 38211788966 has passed. Exact-head build 38211788972 remains running; no native artifact result is claimed until completed.

Independent developer approval remains missing. The PR stays draft on release/2.6.3; after an explicitly authorized #7031 baseline merge, refresh/retarget against sprint and verify the narrowed diff/final checks. This test-only correction removes the fixture dependency on the #7030 merge but does not replace #7030's own approval/contributor acceptance, source approval, native existing-wallet acceptance or release-artifact gates. The combined candidate must retain its #7042 Electrum API/public-failover test reconciliation when integrating this source head.

No PR was merged, artifact published, release signed or production data changed. Reproducibility #7043 and Bitkey Wallet remain separate.

Copy link
Copy Markdown
Collaborator Author

R4 source CI continuation — 12 October 2026

Current source head: c3b9b37ece19e18ea3198e3bf6aaaf20b05660ab.

The former standalone test failure at 7784bd032 depended on refused connections to a public Electrum server. This follow-up imports only the four deterministic Electrum test/fixture files from contributor #7030 and preserves the standalone client's legacy index-reset API and explicit reconnect coverage. Runtime app code, Android build inputs and the USDT pause/history behavior are unchanged. The source now also imports the exact existing #7045 wrong-key AES test correction: incorrect-key decryption may return a non-plaintext string or throw Malformed UTF-8 data; both outcomes reject the original plaintext. It uses its own fresh ciphertext rather than another test's shared value.

Cloud checks on the new source:

  • Full standalone Jest: 24/24 suites, 307/307 tests passed; focused Electrum client/wallet/vault: 3/3 suites, 54/54 tests passed.
  • Original workflow USDT pause/backup and retired-input Node checks: 34/34 passed after adding an isolated Ruby runtime; the first attempt was blocked by the Cloud environment lacking ruby.
  • Python Android comparison/input-tool unit tests: 10/10 passed. Diff check passed. The standalone legacy version:check command still rejects stale authenticated store baselines; R4: bring the shipped 2.6.3 baseline into sprint #7031 supplies the separation between source consistency and release freshness, and the existing R4: Prepare Android build verification; stop USDT setup, sends and trading #7035 workflow does not run that command. Jest reused the candidate's installed dependencies; runtime dependency maps match, while development lint versions differ. Hosted CI independently installs this source's own declared dependencies.
  • Exact-final-head hosted test 38212998725 passed all steps on c3b9b37ece. Final-head Android diagnostic 38213001757 is still running; no artifact result is claimed until completion.

Independent developer approval remains missing. The PR stays draft on release/2.6.3; after an explicitly authorized #7031 baseline merge, refresh/retarget against sprint and verify the narrowed diff/final checks. This test-only correction removes the fixture dependency on the #7030 merge but does not replace #7030's own approval/contributor acceptance, source approval, native existing-wallet acceptance or release-artifact gates. The combined candidate must retain its #7042 Electrum API/public-failover test reconciliation when integrating this source head.

No PR was merged, artifact published, release signed or production data changed. Reproducibility #7043 and Bitkey Wallet remain separate.

Codex local handoff

State: NEEDS_LOCAL
PR: #7035
Base: release/2.6.3 (retarget to sprint after authorized baseline merge)
Head branch: codex/android-reproducibility
Head commit: c3b9b37
Goal and acceptance criteria: Independently review the USDT pause/existing-wallet behavior and its Android release inputs; source native evidence must match the actual head.
Changes made: Deterministic Electrum and wrong-key AES fixture follow-ups only; existing substantive USDT/Android source remains preserved.
Cloud checks: Full Jest 307/307, focused Electrum 54/54, original Node workflow checks 34/34 and Python Android tools 10/10 passed locally; exact-final-head hosted Tests passed, diagnostic build pending. No native test performed here.
Required local checks: IOS, ANDROID
Local checks requested: After source dependencies/retargeting settle, follow the actual Local gate on the final source SHA. Validate existing USDT wallet read/history/export and paused new setup/transactions with disposable data, and native build inputs. Full coordinated R4 flow/hardware acceptance belongs to #7045's separate exact-head handoff; it does not automatically satisfy this source PR's SHA gate.
Risks / known gaps: Source review, baseline retarget, actual current-head native checks and release artifact readiness remain open. Test-only corrections do not authorize release or reuse native results from another commit. No #7043/Bitkey integration.

Final hosted status

Final-head hosted Tests 38212998725 passed. Android diagnostic 38213001757 is still building; no final native artifact result is claimed. Its configuration/signing remain diagnostic only.

Combined candidate #7045 is now a3b87774573fd8d54a05528290c84f12494493bb, with these final source heads integrated and the combined Electrum API/public-peer test reconciliation retained. Its exact Local IOS/ANDROID/HARDWARE handoff is posted; source approvals and native/release delivery remain distinct.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants