Repository navigation
Conversation
Keep existing USDT wallets, Send, Receive, history, and backup routes. Remove new wallet creation and import entry points, plus buy, sell, and swap entry points. Leave the legacy GasFree Send implementation intact until a working replacement is verified.
Keep saved USDT wallets, receive addresses, chain reads, history, and backup recovery. Make Send show a pause message and warn before new deposits. Reject retired GasFree and swap credentials in release inputs and direct Android builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by draft #7035. The USDT/GasFree commits from this branch are merged into the combined Android reproducibility preparation head at
0747e4d. Review the combined candidate there. This PR was closed without merging separately.Scope
release/2.6.3, consistent with Replace SonarCloud with CodeQL and CI linting #7032 onsprint.Product decision and risk
The owner chose to proceed on the assumption that there are no current USDT users and to investigate legacy wallet access if a user reports it. A funded GasFree contract wallet cannot send USDT through Keeper in this change. The Receive screen warns about this. The direct owner-paid contract exit route is unverified; no new transfer path is claimed.
Verification
bash -n, andgit diff --checkpass.CI status
The previous head's Run Tests workflow passed, including the focused USDT/backup/build-input step. The current head removes the stale SonarCloud workflow; its test run is pending. SonarCloud's earlier PR-lookup failure was not a source-analysis result and is not used as a review gate.
WalletScrutiny status
This removes two credential-bearing inputs from a future app build. It does not make the historical v2.6.3 APK reproducible. The other production fields still need review, followed by a pinned clean build and APK/AAB payload comparison. Treat the two
HEXA_ID_*values as public app identifiers; the separate Signing Server route authorization issue is being checked independently.Supersedes closed, unmerged #7023's proposed USDT creation entry in Settings.