Skip to content

Pause new USDT activity and retire GasFree mobile credentials - #7037

Closed
antuz123 wants to merge 6 commits into
release/2.6.3from
codex/usdt-pause
Closed

antuz123 wants to merge 6 commits into
release/2.6.3from
codex/usdt-pause

Conversation

@antuz123

@antuz123 antuz123 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Superseded by draft #7035. The USDT/GasFree commits from this branch are merged into the combined Android reproducibility preparation head at 0747e4d. Review the combined candidate there. This PR was closed without merging separately.

Scope

  • Pause new USDT wallet creation/import and USDT buy, sell, and swap entry points. Keep existing USDT wallets visible with balance, history, settings, backup/export, and their saved Receive address.
  • Keep the Send action visible but show a clear paused message. Receive displays a warning before users copy or scan the saved address. No transfer is attempted.
  • Remove the GasFree API/HMAC client and unused swap client. Reject GasFree and swap API keys from AppCenter, Fastlane release input, direct Android Gradle builds, and the react-native-config iOS codegen phase. Preserve historical transaction records and chain-based balance/history reads.
  • Label older trace-only GasFree requests as status unavailable. Keep their original records and any on-chain transfer separate; the saved fields do not safely establish that they are the same transfer.
  • Remove the stale SonarCloud workflow and project config inherited from release/2.6.3, consistent with Replace SonarCloud with CodeQL and CI linting #7032 on sprint.

Product decision and risk

The owner chose to proceed on the assumption that there are no current USDT users and to investigate legacy wallet access if a user reports it. A funded GasFree contract wallet cannot send USDT through Keeper in this change. The Receive screen warns about this. The direct owner-paid contract exit route is unverified; no new transfer path is claimed.

Verification

  • 28 focused USDT, encrypted backup/restore, Android release-environment, and iOS config-guard tests pass locally.
  • Direct Gradle configuration check accepts a clean synthetic environment and rejects synthetic GasFree and swap credential keys.
  • The iOS guard was tested against react-native-config 1.4.6's dotenv reader and its placement in the pod codegen phase was checked. No Xcode archive was run for this patch.
  • Prettier check on changed TypeScript/TSX, localization JSON parse, Ruby syntax, bash -n, and git diff --check pass.
  • Repository-wide TypeScript checking remains red with existing project errors. The existing Python release-artifact fixture tests also fail independently of these changes.

CI status

The previous head's Run Tests workflow passed, including the focused USDT/backup/build-input step. The current head removes the stale SonarCloud workflow; its test run is pending. SonarCloud's earlier PR-lookup failure was not a source-analysis result and is not used as a review gate.

WalletScrutiny status

This removes two credential-bearing inputs from a future app build. It does not make the historical v2.6.3 APK reproducible. The other production fields still need review, followed by a pinned clean build and APK/AAB payload comparison. Treat the two HEXA_ID_* values as public app identifiers; the separate Signing Server route authorization issue is being checked independently.

Supersedes closed, unmerged #7023's proposed USDT creation entry in Settings.

Keep existing USDT wallets, Send, Receive, history, and backup routes. Remove new wallet creation and import entry points, plus buy, sell, and swap entry points. Leave the legacy GasFree Send implementation intact until a working replacement is verified.
Keep saved USDT wallets, receive addresses, chain reads, history, and backup recovery. Make Send show a pause message and warn before new deposits. Reject retired GasFree and swap credentials in release inputs and direct Android builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant