Skip to content

ci: cover the 2.6.4 release branch - #7039

Draft
antuz123 wants to merge 4 commits into
codex/r3-release-baseline-to-sprintfrom
codex/r4-release-264-ci-triggers
Draft

antuz123 wants to merge 4 commits into
codex/r3-release-baseline-to-sprintfrom
codex/r4-release-264-ci-triggers

Conversation

@antuz123

@antuz123 antuz123 commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

R4 source CI continuation — 12 October 2026

Current source head: f8ca5a843838079cf2d653b036dd8617107aa388.

Added the actual stacked base codex/r3-release-baseline-to-sprint to the pull_request filters in CI and CodeQL. This resolves the missing own-head checks while preserving existing release/2.6.4 push/PR triggers. Both YAML files parse, trigger assertions pass and git diff --check is clean.

This source also imports exactly the four deterministic Electrum test/fixture files already verified in #7035. The relevant standalone Electrum client, wallet operations/factories and Jest setup match #7035; no runtime app code is imported. The preceding hosted Tests check exposed the same pre-existing random wrong-key AES assertion already corrected in #7045; this source imports that exact test-only delta, accepting only Malformed UTF-8 data or a decrypted string different from the original plaintext. Client/wallet/vault tests now exercise real application behavior with fixed protocol/chain replies and explicit failover/reconnect coverage instead of relying on a public Electrum node.

Cloud checks on the current source: full Jest 24/24 suites, 307/307 tests passed; focused Electrum 3/3 suites, 54/54 tests passed; recovery 204/204 passed; release tests 12 Node + 7 Python passed; exact-head version:check passed at 2.6.3 / Android 626 / iOS 619, correctly reflecting this source baseline rather than the combined 2.6.4 candidate. Diff check passed. Jest reused the candidate dependency install with matching runtime dependency maps. Preceding head 0ac33a839 CI failed 1/307 tests on the wrong-key UTF-8 exception. Exact-final-head CI 38212979019 passed Tests (the Lint job is successful under continue-on-error while its command reports 4,529 errors/914 warnings), and CodeQL 38212978792 passed on final f8ca5a843. Hosted CI installed this source's own dependencies independently.

Utkarsh's existing approval is on prior head a8d1270d3277224a7adb6e6eea35fc6bed79544a; renewed review of the workflow/fixture corrections remains required even if GitHub retains APPROVED. Copilot rereview remains unavailable under the existing quota; no new request or spending change was made. Keep this draft until #7031 lands under explicit authorization, then retarget to sprint and recheck.

The runtime-preserving workflow/test update does not require an additional native run by itself. This source PR is no longer solely .github/ files, however, so after retargeting to sprint follow the actual local-validation workflow's requirements and report its state honestly. This does not validate signed 2.6.4 artifacts or authorize merge/release. Reproducibility #7043 and Bitkey Wallet remain separate.

Codex local handoff

State: NEEDS_LOCAL
PR: #7039
Base: codex/r3-release-baseline-to-sprint (retarget to sprint after authorized #7031 merge)
Head branch: codex/r4-release-264-ci-triggers
Head commit: f8ca5a8
Goal and acceptance criteria: Review/verify release and stacked-base CI triggers plus runtime-preserving deterministic fixtures on this source head.
Changes made: Workflow filters, deterministic Electrum fixtures and the existing wrong-key AES fixture correction; no runtime app change.
Cloud checks: Full Jest 307/307, focused Electrum 54/54, recovery 204/204, release 12 Node + 7 Python and version consistency passed locally; exact-final-head hosted CI/CodeQL passed. No native run performed here.
Required local checks: IOS, ANDROID
Local checks requested: No additional native behavior is introduced by this update, but tests/*.ts changes do not qualify for the documentation/.github-only exemption. After retargeting, validate/report the actual final-head gate requirements; leave BLOCKED/NEEDS_LOCAL if native tools or source dependencies are unavailable. The coordinated #7045 native result cannot be reused for a different source SHA.
Risks / known gaps: Renewed independent source approval, baseline merge/retarget and final hosted/local status remain open. This source keeps baseline 2.6.3/626/619; it is not a signed 2.6.4 artifact. No merge, publication, #7043 or Bitkey changes.

Final hosted status

Final-head hosted CI 38212979019 and CodeQL 38212978792 passed. Tests passed; Lint job remains informational because its command exits 1 (4529 errors / 914 warnings).

Combined candidate #7045 is now a3b87774573fd8d54a05528290c84f12494493bb, with these final source heads integrated and the combined Electrum API/public-peer test reconciliation retained. Its exact Local IOS/ANDROID/HARDWARE handoff is posted; source approvals and native/release delivery remain distinct.

Release branch scope

Enable release/2.6.4 CI/CodeQL after baseline #7031; retarget only after its authorized merge and recheck narrowed source/CI/local requirements. This branch retains source baseline 2.6.3/626/619, not the combined candidate release counters.

Copy link
Copy Markdown
Collaborator Author

R4 source CI continuation — 12 October 2026

Current source head: 0ac33a839846fb0bf62b5c053c267bba69ddbaf3.

Added the actual stacked base codex/r3-release-baseline-to-sprint to the pull_request filters in CI and CodeQL. This resolves the missing own-head checks while preserving existing release/2.6.4 push/PR triggers. Both YAML files parse, trigger assertions pass and git diff --check is clean.

This source also imports exactly the four deterministic Electrum test/fixture files already verified in #7035. The relevant standalone Electrum client, wallet operations/factories and Jest setup match #7035; no runtime app code is imported. Client/wallet/vault tests now exercise real application behavior with fixed protocol/chain replies and explicit failover/reconnect coverage instead of relying on a public Electrum node.

Cloud checks on the current source: full Jest 24/24 suites, 307/307 tests passed; focused Electrum 3/3 suites, 54/54 tests passed; recovery 204/204 passed; release tests 12 Node + 7 Python passed; exact-head version:check passed at 2.6.3 / Android 626 / iOS 619, correctly reflecting this source baseline rather than the combined 2.6.4 candidate. Diff check passed. Jest reused the candidate dependency install with matching runtime dependency maps. Current-head CI 38212212222 and CodeQL 38212212267 are running. Hosted CI independently installs this source's own dependencies and must pass on this final head; preceding-head checks do not substitute.

Utkarsh's existing approval is on prior head a8d1270d3277224a7adb6e6eea35fc6bed79544a; renewed review of the workflow/fixture corrections remains required even if GitHub retains APPROVED. Copilot rereview remains unavailable under the existing quota; no new request or spending change was made. Keep this draft until #7031 lands under explicit authorization, then retarget to sprint and recheck.

The runtime-preserving workflow/test update does not require an additional native run by itself. This source PR is no longer solely .github/ files, however, so after retargeting to sprint follow the actual local-validation workflow's requirements and report its state honestly. This does not validate signed 2.6.4 artifacts or authorize merge/release. Reproducibility #7043 and Bitkey Wallet remain separate.

Copy link
Copy Markdown
Collaborator Author

R4 source CI continuation — 12 October 2026

Current source head: f8ca5a843838079cf2d653b036dd8617107aa388.

Added the actual stacked base codex/r3-release-baseline-to-sprint to the pull_request filters in CI and CodeQL. This resolves the missing own-head checks while preserving existing release/2.6.4 push/PR triggers. Both YAML files parse, trigger assertions pass and git diff --check is clean.

This source also imports exactly the four deterministic Electrum test/fixture files already verified in #7035. The relevant standalone Electrum client, wallet operations/factories and Jest setup match #7035; no runtime app code is imported. The preceding hosted Tests check exposed the same pre-existing random wrong-key AES assertion already corrected in #7045; this source imports that exact test-only delta, accepting only Malformed UTF-8 data or a decrypted string different from the original plaintext. Client/wallet/vault tests now exercise real application behavior with fixed protocol/chain replies and explicit failover/reconnect coverage instead of relying on a public Electrum node.

Cloud checks on the current source: full Jest 24/24 suites, 307/307 tests passed; focused Electrum 3/3 suites, 54/54 tests passed; recovery 204/204 passed; release tests 12 Node + 7 Python passed; exact-head version:check passed at 2.6.3 / Android 626 / iOS 619, correctly reflecting this source baseline rather than the combined 2.6.4 candidate. Diff check passed. Jest reused the candidate dependency install with matching runtime dependency maps. Preceding head 0ac33a839 CI failed 1/307 tests on the wrong-key UTF-8 exception. Exact-final-head CI 38212979019 passed Tests (the Lint job is successful under continue-on-error while its command reports 4,529 errors/914 warnings), and CodeQL 38212978792 passed on final f8ca5a843. Hosted CI installed this source's own dependencies independently.

Utkarsh's existing approval is on prior head a8d1270d3277224a7adb6e6eea35fc6bed79544a; renewed review of the workflow/fixture corrections remains required even if GitHub retains APPROVED. Copilot rereview remains unavailable under the existing quota; no new request or spending change was made. Keep this draft until #7031 lands under explicit authorization, then retarget to sprint and recheck.

The runtime-preserving workflow/test update does not require an additional native run by itself. This source PR is no longer solely .github/ files, however, so after retargeting to sprint follow the actual local-validation workflow's requirements and report its state honestly. This does not validate signed 2.6.4 artifacts or authorize merge/release. Reproducibility #7043 and Bitkey Wallet remain separate.

Codex local handoff

State: NEEDS_LOCAL
PR: #7039
Base: codex/r3-release-baseline-to-sprint (retarget to sprint after authorized #7031 merge)
Head branch: codex/r4-release-264-ci-triggers
Head commit: f8ca5a8
Goal and acceptance criteria: Review/verify release and stacked-base CI triggers plus runtime-preserving deterministic fixtures on this source head.
Changes made: Workflow filters, deterministic Electrum fixtures and the existing wrong-key AES fixture correction; no runtime app change.
Cloud checks: Full Jest 307/307, focused Electrum 54/54, recovery 204/204, release 12 Node + 7 Python and version consistency passed locally; exact-final-head hosted CI/CodeQL passed. No native run performed here.
Required local checks: IOS, ANDROID
Local checks requested: No additional native behavior is introduced by this update, but tests/*.ts changes do not qualify for the documentation/.github-only exemption. After retargeting, validate/report the actual final-head gate requirements; leave BLOCKED/NEEDS_LOCAL if native tools or source dependencies are unavailable. The coordinated #7045 native result cannot be reused for a different source SHA.
Risks / known gaps: Renewed independent source approval, baseline merge/retarget and final hosted/local status remain open. This source keeps baseline 2.6.3/626/619; it is not a signed 2.6.4 artifact. No merge, publication, #7043 or Bitkey changes.

Final hosted status

Final-head hosted CI 38212979019 and CodeQL 38212978792 passed. Tests passed; Lint job remains informational because its command exits 1 (4529 errors / 914 warnings).

Combined candidate #7045 is now a3b87774573fd8d54a05528290c84f12494493bb, with these final source heads integrated and the combined Electrum API/public-peer test reconciliation retained. Its exact Local IOS/ANDROID/HARDWARE handoff is posted; source approvals and native/release delivery remain distinct.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants