Repository navigation
Conversation
R4 combined-source correction and acceptance boundarySource head remains Exact combined local/hosted verification passes 380 Jest and 308 recovery tests, including fresh setup -> one faucet -> persisted visible balance, failed persistence/retry preservation, same-ID Wallet/Vault/hidden archive account races, and real component hide/reset/cancellation scenarios. Source #7042 still lacks its own CI due its stacked-base workflow filters. Do not infer own-head CI or approve a standalone rollout from the combined result; reconcile/port the required corrections deliberately during authorized baseline/source integration and recheck the final source. Fresh-install tutorial -> Testnet -> Receive Test Sats -> visible balance without restart, 1/10/50-wallet native profiling, native modal timing, nodes/Tor/deep links/Ask Keeper, and retained archive behavior remain NEEDS_LOCAL under the newest #7045 exact-head IOS/ANDROID/HARDWARE handoff. Website #19 live association paths remain 404. No merge, deployment or release occurred. |
Scope
Implements the coordinated mobile R4 slice for Backlog rows 193, 240, 232, and 241, stacked on #7031.
Verification
git diff --checkpasses. Full repository typecheck still reports broad existing component/dependency errors; ESLint cannot initialize because the repository'sjest/globalsenvironment key is unknown. Neither is claimed as a passing gate.Review and release gates
Acceptance follow-up at
d280c3b7cOwn-head CI source follow-up — 13 October 2026
Current source head:
163cccb831f824b3daacc05199421683abdaf1ad, retaining the original runtime atd280c3b7ce879503998a9625a18d9be0ccd6d7da. The PR remains draft with the same basecodex/r3-release-baseline-to-sprint.Trigger commit
74df55446d8645ebfac05405fce81fa43446acd9adds this actual stacked base to the existing CI and CodeQL pull-request branch filters: exactly two inserted workflow lines. Workflow jobs, permissions, push filters and existing check behavior are unchanged.Test commit
28c7ab0c6makes the Electrum client protocol fixture deterministic while retaining actual predefined public-peer identities and real facade failover/reconnect behavior. Wallet/Vault suites use the existing deterministic test-only network fixture; production wallet/key derivation, descriptors, address scanning, transaction parsing, coin selection and signing stay under test. Their existing assertions are retained.Four manual-coin refresh VM cases now load the actual source
WALLET_SYNC_SCOPE_CHANGEDdeclaration and bind the missing fixture store and checked connection-generation/network inputs. They require a successful refresh and exactly one sync/persistence, in addition to the existing manual-choice assertions.The full diff from d280 contains only two workflow files and six test files. Git object identities for
src, Android/iOS projects,package.jsonandyarn.lockare unchanged. No runtime, release version, dependencies, UI or cryptography implementation was changed; no test was removed and no skip or failure suppression was introduced.Test commit
163cccb83corrects the inherited wrong-key AES assertion using the existing ci: cover the 2.6.4 release branch #7039 approach: actual malformed-UTF8 rejection is accepted only for that specific error, while a wrong key recovering the plaintext still fails. Actual production AES encryption/decryption remains unchanged and unmocked.Historical failures exposed by enabling own-head CI
At
74df55446, CI 38347397038 failed Jest: 34/35 suites passed; 333/340 tests passed, 7 failed intests/services/client.test.tswith Electrum-client-unavailable / node-not-reachable errors. Recovery, version and release/artifact steps were skipped afterward. The separate CodeQL security check 115132119008 and Analyze workflow succeeded at that previous head; they do not establish checks at a newer SHA.The first local full recovery run also exposed four missing VM scope bindings (206/210 passed); the first local full Jest run after fixing the client fixture exposed public Electrum/mempool dependency timeouts in Wallet/Vault setup (33/35 suites and 310/341 tests passed). These failures are retained as evidence; the test-only fixture changes above address their setup causes without bypassing assertions or changing production behavior.
At
28c7ab0c6, CI 38348686580 then passed 340/341 Jest tests and 34/35 suites, but failed the singleDecryption::Incorrect keycase when actual CryptoJS threwMalformed UTF-8 data; later recovery/version/release steps were again skipped. The specific test-only correction above addresses that error without changing encryption behavior.The actual ESLint command at both previous heads exited 1 with 5,443 problems (4,529 errors / 914 warnings). Their Lint jobs were marked success only because the workflow already had
continue-on-error: true; this continuation preserved the existing job and did not introduce or expand that setting. Lint is not claimed as passing.Current verification
git diff --checkpassed.163cccb831f824b3daacc05199421683abdaf1ad, is completed/success. Its fresh-install Tests job passed 35 suites / 341 Jest tests, 210 recovery tests (zero skips), 12 JavaScript + 7 Python release/artifact tests, and source version consistency 2.6.3 / Android 626 / iOS 619. As normal for a pull-request run, Actions checked out the generated merge context30ead64c0d54dce9cb2235e80b864280cb9e5222; the local checks above used the standalone source checkout.continue-on-errorsetting. Neither workflow success nor the test-only fix is claimed as lint/type cleanliness.These deterministic unit fixtures do not validate public providers, a fresh Testnet faucet transaction, native app launch, hardware signing or customer recovery. Later combined #7045 runtime corrections remain on the combined candidate and were not ported onto this standalone source. Website #19's source-only development-package correction is at
cfe7b15631cd71c827cd1c78096fe30295e75acd; live www associations and valid dummy links still return HTTP 404. Source reconciliation, independent developer approval, production/Play certificates, approved hosting and installed-app acceptance remain open.Codex local handoff
State: NEEDS_LOCAL
PR: #7042
Base: codex/r3-release-baseline-to-sprint
Head branch: codex/r4-sync-ask-keeper
Head commit: 163cccb
Goal and acceptance criteria: Own-head CI/CodeQL execute reliably on the existing stacked base, while retained R4 sync/faucet/archive/Ask Keeper/remote-link behavior meets native acceptance.
Changes made: Two workflow trigger entries and six test-only fixture/assertion files; runtime/native/dependencies remain identical to d280c3b.
Cloud checks: Local and hosted Jest 341/341, recovery 210/210, release 12 JS + 7 Python and source version 2.6.3/626/619 passed; diff check passed. CI workflow and both CodeQL checks completed successfully. Actual ESLint command still failed (4,529 errors / 914 warnings), despite inherited green Lint job. Initial failed runs and hosted merge-context identity are recorded above.
Required local checks: IOS, ANDROID
Local checks requested: Use a separate exact-source checkout and disposable accounts. Read the latest combined #7045 handoff and source-correction boundaries before choosing a native source; this standalone source lacks later candidate corrections. Record actual tested source/artifact identities. Exercise fresh Testnet tutorial -> one faucet request -> persisted visible balance without restart; account/network switches during requests; hidden/zero-balance archive monitoring; public/private node reconnect/failover; Ask Keeper scroll/retry/discard; and 1/10/50-wallet profiling. Pair website #19 only after a separately approved hosting deployment, confirming actual package/entitlements/certificates and cold/warm/malformed link opening plus generic browser fallback without exposing keys.
Risks / known gaps: ESLint retains existing failures; source reconciliation, human approval, native/provider acceptance, live website 404s and final certificate/hosting gates remain open. Deterministic unit results and successful CI are not authorization to merge, retarget, deploy, sign, distribute or publish.