feat(trace): cover live call-create HTTP - #303
Draft
OnlineChef (ChefGroep) wants to merge 2 commits into
Draft
OnlineChef (ChefGroep) wants to merge 2 commits into
OnlineChef (ChefGroep) wants to merge 2 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MisterWanted
added a commit
that referenced
this pull request
Oct 4, 2026
…-live-call (resolve cli.md trace-coverage docs)
This was referenced Oct 4, 2026
OnlineChef (ChefGroep)
changed the base branch from
feat/trace-store
to
feat/trace-responses-websocket
October 4, 2026 23:04
This was referenced Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opt-in trace-store coverage for live/realtime call-create HTTP:
POST /v1/livePOST /v1/realtime/callsThis PR is intentionally stacked on
feat/trace-store/ #298 and remains separate from long-lived live/realtime sideband WebSocket tracing.Design
Live call-create is a bounded request/response lifecycle, so it can reuse the ordinary trace contract safely:
handleLiveinside the per-request trace contextThe live implementation already enforces
LIVE_REQUEST_MAX_BYTESandLIVE_RESPONSE_MAX_BYTES, so tracing does not introduce an unbounded body path.Verification
Exact head
737afa047b2c5a6ced9142618f9fb2292df700a4:bun x tsc --noEmit✅bun run privacy:scan✅git diff --check✅A clean-tree full repository suite is the final local gate.
Boundary
Long-lived live/realtime sideband WebSockets remain out of scope here. They require a session-oriented trace model with bounded per-direction frame aggregates, binary-frame handling, and close/error finalization rather than ordinary request-body accumulation.
Dependency
Stacked on #298. Merge/rebase only after the trace-store parent lands.
PR-stack (mergen van onder naar boven; elke PR bouwt op de vorige):
Base van deze PR = de branch van de PR erboven in de lijst (#296 =
main).