feat: expand providers and make native model discovery account-aware - #297
Draft
OnlineChef (ChefGroep) wants to merge 22 commits into
Draft
OnlineChef (ChefGroep) wants to merge 22 commits into
OnlineChef (ChefGroep) wants to merge 22 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.codex/auth.json.GET /v1/models?client_version=...Codex client route, preserving authoritative context/reasoning metadata for newly rolled-out models.Root cause
activeCodexAccountIdcontrols OpenCodex pool routing, but the physical Codex main credential remains~/.codex/auth.json. Native catalog refresh could therefore stay pinned to a stale Desktop login even while another pool account was healthy.Current Codex model discovery only needs the account Bearer token plus
ChatGPT-Account-IDforGET /backend-api/codex/models?client_version=.... This PR uses that request contract directly instead of copying pool credentials into Codex's native auth store.Safety boundaries
~/.codex/auth.json.codexAccountPools: falseremains a hard standalone boundary: pool credentials are not consulted.Coverage
Regression coverage includes selected-pool preference, dead-main fallback, one shared fallback deadline, safe degradation on response-body failure, account-pool opt-out, authoritative new native slugs, live metadata preservation in the catalog builder, registry/free-tier parity, and a hermetic end-to-end server test that proves
/v1/models?client_version=9.9.9forwards the exact client version and account headers while returning the live native row.Non-goals
This PR does not swap Codex Desktop/app-server login state, rewrite the native auth file, or fold the larger Codex/app-server lifecycle decoupling into the provider/catalog change.
The proxy already runs independently as its own service. Remaining Codex coupling is primarily lifecycle/integration: config/catalog injection and stale long-lived
codex app-serverconsumers after disk catalog changes. Remote CLI endpoint/profile orchestration should be a separate PR built on the existing sharedruntimeRequest(baseUrl)management client.