feat(trace): cover Responses WebSocket turns - #302
Draft
OnlineChef (ChefGroep) wants to merge 2 commits into
Draft
OnlineChef (ChefGroep) wants to merge 2 commits into
OnlineChef (ChefGroep) wants to merge 2 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
CodeRabbit (@coderabbitai) review |
Contributor
|
MisterWanted
added a commit
that referenced
this pull request
Oct 4, 2026
…ace-websocket (resolve cli.md trace-coverage docs)
This was referenced Oct 4, 2026
MisterWanted
pushed a commit
that referenced
this pull request
Oct 4, 2026
OnlineChef (ChefGroep)
changed the base branch from
feat/trace-store
to
feat/trace-compact-cache
October 4, 2026 23:04
This was referenced Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds opt-in trace-store coverage for Responses WebSocket turns on
/v1/responses.This PR is intentionally stacked on
feat/trace-store/ #298 and is a sibling of the local trace reader (#300) and compact/cache-hit tracing (#301).It does not trace voice/realtime live-sideband WebSockets. Those are long-lived bidirectional sessions with different lifecycle and resource-bound semantics.
Design
Every
response.createturn already has its own request id, request-log context, cancellation scope, provider routing, and terminal finalizer. This change reuses that existing logical-request boundary:response.createframe as the inbound tracehandleResponsesturn viarunWithTraceaddFinalRequestLogpathThe inbound trace intentionally hashes the client WS frame rather than the internally reconstructed HTTP request. This keeps client-shape drift distinct from adapter/provider-wire drift.
generate:falsewarmup frames remain local and are not turned into synthetic request-log rows.Verification
Exact head
491758501a4258b0dd1a0fad837645796a9034b3:bun x tsc --noEmit✅bun run privacy:scan✅git diff --check✅A clean-tree full repository suite is the final local gate.
Boundary
Live/realtime sideband WebSockets remain deliberately out of scope. Their trace model needs bounded per-session/per-frame accounting, binary-frame handling, disconnect finalization, and explicit prevention of unbounded long-lived accumulation.
Dependency
Stacked on #298. Merge/rebase only after the trace-store parent lands.
PR-stack (mergen van onder naar boven; elke PR bouwt op de vorige):
Base van deze PR = de branch van de PR erboven in de lijst (#296 =
main).