Repository navigation
[backport cloud/1.58] fix(cloud): retry startup remote config instead of falling back to dev Firebase - #22338
Conversation
…v Firebase (#21981) IR-153: production users were intermittently signed in against the **dev** Firebase project (`dreamboothy-dev`) and production then rejected every request (`expected dreamboothy but got dreamboothy-dev`), showing a logout / "Couldn't load your workspace" until a reload. RUM, last 30 days on `cloud.comfy.org`: 119 sessions loaded the dev auth iframe (vs 17,850 on prod), with 41 Google and 19 password sign-in sessions sent to dev, mostly on slow connections. The dev project's sign-in allowlist rejects non-staff, so customers saw a failed sign-in rather than dev data. Once the page has the right config, product use and billing are unaffected. - `getFirebaseConfig()` uses the server's `firebase_config`, else `BUILD_TIME_CONFIG` (`src/config/firebase.ts`). - Cloud bundles (including the prod variant in `Comfy-Org/cloud` `frontend-asset-predeploy.yml`) are built without `USE_PROD_CONFIG`, so `BUILD_TIME_CONFIG` is the dev project. - At startup the anonymous `/features` read has a 5s timeout; on failure `remoteConfigState` becomes `'error'` and `firebaseIdentity` (which only guards `'unloaded'`) initializes from that dev default. - Firebase initializes once, so the later authenticated refresh / 10‑minute poll cannot repair the page. On cloud, startup now retries the anonymous `/features` read with capped backoff (1s → 10s) behind the existing splash until the server names the Firebase project (`loadRemoteConfigUntilReady`). A successful read is not enough on its own: `firebase_config` is optional in the response contract, so a 200 that omits it would otherwise end bootstrap with no server config and let `getFirebaseConfig()` fall through to the build-time default — the same `dreamboothy-dev` outcome. The loop therefore also requires `hasServerFirebaseConfig()`, which counts an explicit `firebase_env: 'dev'` as server-named, since that is a server instruction rather than a build-time guess. `isCloud` is the bundle flavour, not "served by the Cloud API": a cloud bundle can be served by a local ComfyUI, whose `/features` answers 200 and never carries `firebase_config`. Waiting indefinitely there never starts the app — every cloud Playwright shard timed out that way at `59e93a79` — so the two cases are split on `isLoopbackHost(window.location.hostname)`. A deployed host keeps waiting rather than start Firebase on the bundled project; a loopback harness, whose server has no project to send, stops after one further read. A read that *fails* still retries in both, which is the shape the incident had. The first project-less read reports `startup_remote_config_without_firebase_project` (tagged `localCloud`), so a deployed Cloud omitting the field is visible while it waits rather than silent. Firebase therefore only ever starts from the server's `firebase_config`; there is no build-time fallback on cloud. A long outage shows up as a `timed_out` bootstrap report with `startup/remote-config` pending. Local and desktop keep the single read and their build-time defaults, since their server does not send `firebase_config`. Alternative considered: building the prod bundle with `USE_PROD_CONFIG=true`. That prevents the wrong project on prod but still boots on a guessed config when the server does not answer, and staging bundles keep the dev guess. AS IS (`origin/main`, `pnpm dev:cloud` → testcloud, `/api/features` aborted): one request, never retried, never answered; the login page renders anyway and Firebase is initialized from the build-time default `dreamboothy-dev`. <img width="640" alt="AS IS" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/asis-final.png" /> TO BE (PR branch, same setup, `/api/features` aborted twice then let through): the splash holds during retries #1 and #2 (1s, 2s backoff), request #3 answers 200, then the login page loads with Firebase on the server's `firebase_config`. testcloud's own `firebase_config` is `dreamboothy-dev`, so the project name matches AS IS here; the difference is that it now comes from the server rather than the build default. On prod the server returns `dreamboothy`. <img width="640" alt="TO BE splash during retries" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/tobe-splash.png" /> <img width="640" alt="TO BE loaded" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/tobe-final.png" /> `refreshRemoteConfig.test.ts`: - abort → 503 → success resolves with the server config after three reads. Fails when the loop returns after the first read. - a 200 without `firebase_config` keeps retrying and resolves on the next read that carries one. Fails with `expected "vi.fn()" to be called 2 times, but got 1 times` when the `hasServerFirebaseConfig()` gate is removed. - a 200 carrying only `firebase_env: 'dev'` resolves on the first read, pinning that branch against an accidental narrowing. - on a deployed host (`cloud.comfy.org`), repeated 200s without a project never resolve the bootstrap promise, so Firebase initialization is unreachable. Fails when the loopback guard is dropped. - on a loopback host, the same responses stop after one further read, which is what keeps the cloud e2e harness booting. (cherry picked from commit 9c78428)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T01:55:59.366Z",
"gitSha": "3ca45bea9b1aaea446719ca94cf6ac91b56927b8",
"branch": "backport-21981-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.31,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.23,
"layouts": 10,
"layoutDurationMs": 2.04,
"taskDurationMs": 337.888,
"heapDeltaBytes": -23295960,
"heapUsedBytes": 79124036,
"domNodes": -200,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 5.441999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.1570000000024,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.164,
"layouts": 10,
"layoutDurationMs": 1.925,
"taskDurationMs": 334.18,
"heapDeltaBytes": -1683704,
"heapUsedBytes": 86602600,
"domNodes": -200,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 5.3809999999999985,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.3809999999976,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.564,
"layouts": 10,
"layoutDurationMs": 2.1940000000000004,
"taskDurationMs": 535.4150000000001,
"heapDeltaBytes": -5187948,
"heapUsedBytes": 83996968,
"domNodes": -200,
"jsHeapTotalBytes": 1806336,
"scriptDurationMs": 89.227,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.762000000012,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.025,
"layouts": 9,
"layoutDurationMs": 1.7299999999999998,
"taskDurationMs": 597.4039999999999,
"heapDeltaBytes": -22787952,
"heapUsedBytes": 79693316,
"domNodes": -200,
"jsHeapTotalBytes": -2170880,
"scriptDurationMs": 96.27199999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.1380000000195,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.699,
"layouts": 12,
"layoutDurationMs": 2.238,
"taskDurationMs": 168.95700000000002,
"heapDeltaBytes": 21544464,
"heapUsedBytes": 109814468,
"domNodes": 47,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 6.456000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.3119999999976,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.8630000000000004,
"layouts": 12,
"layoutDurationMs": 2.3120000000000003,
"taskDurationMs": 216.831,
"heapDeltaBytes": 21587584,
"heapUsedBytes": 110151824,
"domNodes": 47,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 7.339999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 397.83299999999144,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.944,
"layouts": 11,
"layoutDurationMs": 2.687,
"taskDurationMs": 276.324,
"heapDeltaBytes": -236644,
"heapUsedBytes": 87657868,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 104.608,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000005,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 381.69300000004114,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.2399999999999998,
"layouts": 10,
"layoutDurationMs": 2.565,
"taskDurationMs": 268.566,
"heapDeltaBytes": 223096,
"heapUsedBytes": 88139348,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 101.61999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 879.8170000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.209,
"heapDeltaBytes": -13857256,
"heapUsedBytes": 102764276,
"domNodes": -230,
"jsHeapTotalBytes": 15802368,
"scriptDurationMs": 33.818999999999996,
"eventListeners": -168,
"totalBlockingTimeMs": 242,
"frameDurationMs": 25.237142857142864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 896.8710000000328,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.957,
"heapDeltaBytes": -13569192,
"heapUsedBytes": 102540804,
"domNodes": -210,
"jsHeapTotalBytes": 15015936,
"scriptDurationMs": 35.931999999999995,
"eventListeners": -168,
"totalBlockingTimeMs": 252,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 686.142000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.50000000000017,
"heapDeltaBytes": -3804652,
"heapUsedBytes": 96801692,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 86.072,
"eventListeners": 0,
"totalBlockingTimeMs": 81,
"frameDurationMs": 20.70606060606061,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 670.5250000000547,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 243.47200000000012,
"heapDeltaBytes": -4055624,
"heapUsedBytes": 97309804,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.677,
"eventListeners": 0,
"totalBlockingTimeMs": 79,
"frameDurationMs": 20.097058823529416,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5635.530000000017,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9250000000000005,
"layouts": 3,
"layoutDurationMs": 0.7599999999999998,
"taskDurationMs": 4584.436000000001,
"heapDeltaBytes": 22133660,
"heapUsedBytes": 123450816,
"domNodes": -276,
"jsHeapTotalBytes": 19202048,
"scriptDurationMs": 3589.273,
"eventListeners": -130,
"totalBlockingTimeMs": 11,
"frameDurationMs": 18.469180327868855,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5786.896999999954,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8010000000000005,
"layouts": 3,
"layoutDurationMs": 0.7179999999999999,
"taskDurationMs": 4843.932,
"heapDeltaBytes": 6401128,
"heapUsedBytes": 133309960,
"domNodes": -296,
"jsHeapTotalBytes": 35270656,
"scriptDurationMs": 3655.7400000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.848765432098766,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5667.220999999983,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0739999999999994,
"layouts": 4,
"layoutDurationMs": 0.9750000000000002,
"taskDurationMs": 4791.269,
"heapDeltaBytes": 13381324,
"heapUsedBytes": 121132448,
"domNodes": -296,
"jsHeapTotalBytes": 22114304,
"scriptDurationMs": 3665.796,
"eventListeners": -130,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.59782608695652,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5855.5920000000015,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8070000000000004,
"layouts": 3,
"layoutDurationMs": 0.879,
"taskDurationMs": 4915.72,
"heapDeltaBytes": -14405196,
"heapUsedBytes": 104303884,
"domNodes": -276,
"jsHeapTotalBytes": 1142784,
"scriptDurationMs": 3847.407,
"eventListeners": -130,
"totalBlockingTimeMs": 39,
"frameDurationMs": 18.223987538940808,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 149.78200000001607,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.057999999999998,
"layouts": 13,
"layoutDurationMs": 3.106,
"taskDurationMs": 105.75000000000001,
"heapDeltaBytes": 13276808,
"heapUsedBytes": 117210204,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.313,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 136.17599999997765,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.399999999999999,
"layouts": 12,
"layoutDurationMs": 2.9520000000000004,
"taskDurationMs": 97.596,
"heapDeltaBytes": 13222976,
"heapUsedBytes": 118136100,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.674,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2010.4289999999878,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8799999999999997,
"layouts": 9,
"layoutDurationMs": 1.7759999999999998,
"taskDurationMs": 379.812,
"heapDeltaBytes": 846620,
"heapUsedBytes": 106999380,
"domNodes": -297,
"jsHeapTotalBytes": -983040,
"scriptDurationMs": 18.412,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.662999999989,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9700000000000004,
"layouts": 9,
"layoutDurationMs": 1.736,
"taskDurationMs": 281.11400000000003,
"heapDeltaBytes": 857700,
"heapUsedBytes": 106644380,
"domNodes": -297,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 19.831,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2117.968000000019,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.198,
"layouts": 10,
"layoutDurationMs": 2.111,
"taskDurationMs": 1052.705,
"heapDeltaBytes": -32689896,
"heapUsedBytes": 87872844,
"domNodes": -297,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 521.944,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000002,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2131.705000000011,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.629999999999999,
"layouts": 10,
"layoutDurationMs": 2.0730000000000004,
"taskDurationMs": 1016.5020000000001,
"heapDeltaBytes": -4153476,
"heapUsedBytes": 99011908,
"domNodes": -296,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 503.73400000000004,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283464,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3122.354000000001,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.273000000000001,
"layouts": 67,
"layoutDurationMs": 11.402000000000001,
"taskDurationMs": 1073.077,
"heapDeltaBytes": 6528372,
"heapUsedBytes": 114849292,
"domNodes": 24,
"jsHeapTotalBytes": 5509120,
"scriptDurationMs": 488.448,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66542553191489,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3138.7960000000135,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.481999999999998,
"layouts": 67,
"layoutDurationMs": 11.139,
"taskDurationMs": 1079.7310000000002,
"heapDeltaBytes": 5913684,
"heapUsedBytes": 110780052,
"domNodes": 24,
"jsHeapTotalBytes": 4984832,
"scriptDurationMs": 489.89200000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665608465608464,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "legacy-node-drag",
"durationMs": 2232.866999999999,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.143,
"layouts": 8,
"layoutDurationMs": 1.7990000000000002,
"taskDurationMs": 1207.1680000000001,
"heapDeltaBytes": 15623408,
"heapUsedBytes": 122208788,
"domNodes": 0,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 596.82,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66641791044776,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "legacy-node-drag",
"durationMs": 2220.094999999958,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.042,
"layouts": 8,
"layoutDurationMs": 1.83,
"taskDurationMs": 1154.709,
"heapDeltaBytes": 16314840,
"heapUsedBytes": 126324404,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 581.729,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533832,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.2299999999555,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6439999999999997,
"layouts": 8,
"layoutDurationMs": 1.45,
"taskDurationMs": 285.526,
"heapDeltaBytes": 1505740,
"heapUsedBytes": 104053752,
"domNodes": -296,
"jsHeapTotalBytes": -6225920,
"scriptDurationMs": 18.259,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.4859999999817,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9850000000000008,
"layouts": 9,
"layoutDurationMs": 1.712,
"taskDurationMs": 380.60600000000005,
"heapDeltaBytes": 605696,
"heapUsedBytes": 111170984,
"domNodes": -296,
"jsHeapTotalBytes": -2973696,
"scriptDurationMs": 20.564000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 398.35899999999924,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.578,
"layouts": 10,
"layoutDurationMs": 2.3759999999999994,
"taskDurationMs": 267.547,
"heapDeltaBytes": -3079844,
"heapUsedBytes": 102725468,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 90.572,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 414.22099999999773,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.876,
"layouts": 10,
"layoutDurationMs": 2.289,
"taskDurationMs": 272.73800000000006,
"heapDeltaBytes": 2060312,
"heapUsedBytes": 101528144,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 90.533,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2010.202000000021,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.282,
"layouts": 10,
"layoutDurationMs": 2.068,
"taskDurationMs": 358.38499999999993,
"heapDeltaBytes": -4085132,
"heapUsedBytes": 86306072,
"domNodes": -218,
"jsHeapTotalBytes": -3080192,
"scriptDurationMs": 5.7459999999999996,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.9609999999993,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.294,
"layouts": 10,
"layoutDurationMs": 2.0020000000000002,
"taskDurationMs": 278.092,
"heapDeltaBytes": -927796,
"heapUsedBytes": 90751076,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 4.543,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.3100000000015,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.923,
"layouts": 10,
"layoutDurationMs": 2.1850000000000005,
"taskDurationMs": 544.091,
"heapDeltaBytes": -3859668,
"heapUsedBytes": 86527176,
"domNodes": -210,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 76.75299999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.6780000000203,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.163,
"layouts": 10,
"layoutDurationMs": 3.2559999999999993,
"taskDurationMs": 552.812,
"heapDeltaBytes": -3958688,
"heapUsedBytes": 86311788,
"domNodes": -210,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 73.943,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.3969999999713,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.003000000000002,
"layouts": 5,
"layoutDurationMs": 9.167,
"taskDurationMs": 587.014,
"heapDeltaBytes": 11595488,
"heapUsedBytes": 132385348,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 18.437,
"eventListeners": 3244,
"totalBlockingTimeMs": 62,
"frameDurationMs": 18.990697674418602,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8221.81900000001,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.069,
"layouts": 8,
"layoutDurationMs": 1.7429999999999999,
"taskDurationMs": 3265.469,
"heapDeltaBytes": 2671672,
"heapUsedBytes": 108712372,
"domNodes": -297,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 1763.5729999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69979674796748,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8288.32399999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.009,
"layouts": 9,
"layoutDurationMs": 1.863,
"taskDurationMs": 3727.0800000000004,
"heapDeltaBytes": -6042260,
"heapUsedBytes": 99639060,
"domNodes": -296,
"jsHeapTotalBytes": -942080,
"scriptDurationMs": 1778.507,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665995975855132,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13502.454999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12646.387,
"heapDeltaBytes": -27786816,
"heapUsedBytes": 296538920,
"domNodes": -3344,
"jsHeapTotalBytes": 21745664,
"scriptDurationMs": 146.82700000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.350165562913908,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 10501.369000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9501.908,
"heapDeltaBytes": -30101996,
"heapUsedBytes": 304197032,
"domNodes": -307,
"jsHeapTotalBytes": 32755712,
"scriptDurationMs": 121.528,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.886882453151618,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 17209.622000000025,
"styleRecalcs": 135,
"styleRecalcDurationMs": 13.588000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16701.303,
"heapDeltaBytes": -44186424,
"heapUsedBytes": 281289024,
"domNodes": -3344,
"jsHeapTotalBytes": 8114176,
"scriptDurationMs": 601.1930000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.15815217391304,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 12856.54999999997,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.815999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12379.283999999998,
"heapDeltaBytes": 4858768,
"heapUsedBytes": 324921340,
"domNodes": -3344,
"jsHeapTotalBytes": 37928960,
"scriptDurationMs": 506.3639999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.56182136602452,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 5391.694999999971,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.41199999999999,
"layouts": 20,
"layoutDurationMs": 20.793999999999993,
"taskDurationMs": 5276.184,
"heapDeltaBytes": -36327896,
"heapUsedBytes": 288623456,
"domNodes": -3344,
"jsHeapTotalBytes": 28561408,
"scriptDurationMs": 73.67699999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.62545454545455,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5253.994000000034,
"styleRecalcs": 20,
"styleRecalcDurationMs": 39.483999999999995,
"layouts": 20,
"layoutDurationMs": 17.11,
"taskDurationMs": 5065.873999999999,
"heapDeltaBytes": -23149556,
"heapUsedBytes": 302415236,
"domNodes": -307,
"jsHeapTotalBytes": 23318528,
"scriptDurationMs": 71.217,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.625301204819284,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6770.732000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6298.655,
"heapDeltaBytes": -6241720,
"heapUsedBytes": 284356532,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 73.094,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.68595317725753,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6834.2749999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6395.391999999999,
"heapDeltaBytes": 54428,
"heapUsedBytes": 304033300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 74.482,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.42269736842105,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 456.0430000000224,
"styleRecalcs": 20,
"styleRecalcDurationMs": 9.555,
"layouts": 12,
"layoutDurationMs": 3.7459999999999996,
"taskDurationMs": 97.82499999999999,
"heapDeltaBytes": 7460936,
"heapUsedBytes": 107934996,
"domNodes": 128,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 12.480000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 440.91500000001815,
"styleRecalcs": 19,
"styleRecalcDurationMs": 9.433,
"layouts": 13,
"layoutDurationMs": 3.8120000000000003,
"taskDurationMs": 86.86500000000001,
"heapDeltaBytes": 7083956,
"heapUsedBytes": 97264996,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.878,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 186.57299999995303,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.569,
"layouts": 76,
"layoutDurationMs": 9.007,
"taskDurationMs": 147.804,
"heapDeltaBytes": 9273900,
"heapUsedBytes": 96173104,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 60.271,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 205.01400000000558,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.618,
"layouts": 76,
"layoutDurationMs": 10.415000000000001,
"taskDurationMs": 163.92600000000002,
"heapDeltaBytes": 9469088,
"heapUsedBytes": 96543376,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 70.43900000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 215.66899999993439,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.153,
"layouts": 76,
"layoutDurationMs": 8.6,
"taskDurationMs": 177.743,
"heapDeltaBytes": -2244680,
"heapUsedBytes": 114637396,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 58.524,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 246.63299999997434,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.432,
"layouts": 76,
"layoutDurationMs": 9.843,
"taskDurationMs": 210.852,
"heapDeltaBytes": -2181704,
"heapUsedBytes": 114717936,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 66.908,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge. Fix the failing shards and re-run coverage before using these totals for comparison. Line coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2988 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 34ca0df24653f46d563bd89d14e36ef914e8ac78
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (140)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #22338 +/- ##
=============================================
Coverage ? 84.22%
=============================================
Files ? 3172
Lines ? 165389
Branches ? 41510
=============================================
Hits ? 139305
Misses ? 25693
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
This comment will be updated automatically if new data arrives. 🔗 Commit SHA: c19b93e | Docs | View more details | Give us feedback! |
…of falling back to dev Firebase (#22339) Backport of #21981 (IR-153) to `core/1.58`. Manual: the auto-backport hit a conflict in `src/main.ts`. ## How - Applied cleanly after #22333 merged. - `src/config/firebase.ts` and `src/platform/remoteConfig/refreshRemoteConfig.{ts,test.ts}` apply unchanged. ## Why on 1.58 Keeps `core/1.58` in step with `cloud/1.58` (#22338). The retry loop only runs on the cloud bundle; local and desktop keep the single read. ## Checks - `refreshRemoteConfig.test.ts`: 29/29 passed - `pnpm typecheck` passed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Dante <bunggl@naver.com>
… of falling back to dev Firebase (#22342) Backport of #21981 (IR-153) to `cloud/1.59`. Clean cherry-pick. #21981 was merged after the 1.59 cut and never carried 1.59 labels, so the bot didn't try it. 1.58 backports: #22338 (cloud), #22339 (core). ## Why on 1.59 `cloud/1.59` is on testcloud and promotes to prod next. Without this, prod regresses to the IR-153 behavior on promote. ## Checks - `refreshRemoteConfig.test.ts`: 30/30 passed - `pnpm typecheck` passed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Dante <bunggl@naver.com>
…of falling back to dev Firebase (#22343) Backport of #21981 (IR-153) to `core/1.59`. Clean cherry-pick. #21981 was merged after the 1.59 cut and never carried 1.59 labels, so the bot didn't try it. 1.58 backports: #22338 (cloud), #22339 (core). ## Why on 1.59 Keeps `core/1.59` in step with `cloud/1.59`. The retry loop only runs on the cloud bundle; local and desktop keep the single read. ## Checks - `refreshRemoteConfig.test.ts`: 30/30 passed - `pnpm typecheck` passed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Dante <bunggl@naver.com>
Backport of #21981 (IR-153) to
cloud/1.58. Manual: the auto-backport hit a conflict insrc/main.ts.How
src/main.ts:cloud/1.58runs the remote-config read inline at top level rather than inloadRemoteConfigBeforeFirebase(), so only the fix(cloud): retry startup remote config instead of falling back to dev Firebase #21981 change was applied there: on cloud,loadRemoteConfigUntilReady(); otherwise the singlerefreshRemoteConfig({ useAuth: false }).src/config/firebase.tsandsrc/platform/remoteConfig/refreshRemoteConfig.{ts,test.ts}apply unchanged.Why on 1.58
cloud/1.58is what cloud.comfy.org serves now, and it still falls back to the dev Firebase project when the startup/featuresread fails.Checks
refreshRemoteConfig.test.ts: 29/29 passedpnpm typecheckpassed🤖 Generated with Claude Code