Repository navigation
[backport core/1.58] fix(cloud): retry startup remote config instead of falling back to dev Firebase - #22339
Conversation
…v Firebase (#21981) ## Why IR-153: production users were intermittently signed in against the **dev** Firebase project (`dreamboothy-dev`) and production then rejected every request (`expected dreamboothy but got dreamboothy-dev`), showing a logout / "Couldn't load your workspace" until a reload. RUM, last 30 days on `cloud.comfy.org`: 119 sessions loaded the dev auth iframe (vs 17,850 on prod), with 41 Google and 19 password sign-in sessions sent to dev, mostly on slow connections. The dev project's sign-in allowlist rejects non-staff, so customers saw a failed sign-in rather than dev data. Once the page has the right config, product use and billing are unaffected. ## Root cause - `getFirebaseConfig()` uses the server's `firebase_config`, else `BUILD_TIME_CONFIG` (`src/config/firebase.ts`). - Cloud bundles (including the prod variant in `Comfy-Org/cloud` `frontend-asset-predeploy.yml`) are built without `USE_PROD_CONFIG`, so `BUILD_TIME_CONFIG` is the dev project. - At startup the anonymous `/features` read has a 5s timeout; on failure `remoteConfigState` becomes `'error'` and `firebaseIdentity` (which only guards `'unloaded'`) initializes from that dev default. - Firebase initializes once, so the later authenticated refresh / 10‑minute poll cannot repair the page. ## How On cloud, startup now retries the anonymous `/features` read with capped backoff (1s → 10s) behind the existing splash until the server names the Firebase project (`loadRemoteConfigUntilReady`). A successful read is not enough on its own: `firebase_config` is optional in the response contract, so a 200 that omits it would otherwise end bootstrap with no server config and let `getFirebaseConfig()` fall through to the build-time default — the same `dreamboothy-dev` outcome. The loop therefore also requires `hasServerFirebaseConfig()`, which counts an explicit `firebase_env: 'dev'` as server-named, since that is a server instruction rather than a build-time guess. `isCloud` is the bundle flavour, not "served by the Cloud API": a cloud bundle can be served by a local ComfyUI, whose `/features` answers 200 and never carries `firebase_config`. Waiting indefinitely there never starts the app — every cloud Playwright shard timed out that way at `59e93a79` — so the two cases are split on `isLoopbackHost(window.location.hostname)`. A deployed host keeps waiting rather than start Firebase on the bundled project; a loopback harness, whose server has no project to send, stops after one further read. A read that *fails* still retries in both, which is the shape the incident had. The first project-less read reports `startup_remote_config_without_firebase_project` (tagged `localCloud`), so a deployed Cloud omitting the field is visible while it waits rather than silent. Firebase therefore only ever starts from the server's `firebase_config`; there is no build-time fallback on cloud. A long outage shows up as a `timed_out` bootstrap report with `startup/remote-config` pending. Local and desktop keep the single read and their build-time defaults, since their server does not send `firebase_config`. Alternative considered: building the prod bundle with `USE_PROD_CONFIG=true`. That prevents the wrong project on prod but still boots on a guessed config when the server does not answer, and staging bundles keep the dev guess. ## AS IS / TO BE AS IS (`origin/main`, `pnpm dev:cloud` → testcloud, `/api/features` aborted): one request, never retried, never answered; the login page renders anyway and Firebase is initialized from the build-time default `dreamboothy-dev`. <img width="640" alt="AS IS" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/asis-final.png" /> TO BE (PR branch, same setup, `/api/features` aborted twice then let through): the splash holds during retries #1 and #2 (1s, 2s backoff), request #3 answers 200, then the login page loads with Firebase on the server's `firebase_config`. testcloud's own `firebase_config` is `dreamboothy-dev`, so the project name matches AS IS here; the difference is that it now comes from the server rather than the build default. On prod the server returns `dreamboothy`. <img width="640" alt="TO BE splash during retries" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/tobe-splash.png" /> <img width="640" alt="TO BE loaded" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/tobe-final.png" /> ## Tests `refreshRemoteConfig.test.ts`: - abort → 503 → success resolves with the server config after three reads. Fails when the loop returns after the first read. - a 200 without `firebase_config` keeps retrying and resolves on the next read that carries one. Fails with `expected "vi.fn()" to be called 2 times, but got 1 times` when the `hasServerFirebaseConfig()` gate is removed. - a 200 carrying only `firebase_env: 'dev'` resolves on the first read, pinning that branch against an accidental narrowing. - on a deployed host (`cloud.comfy.org`), repeated 200s without a project never resolve the bootstrap promise, so Firebase initialization is unreachable. Fails when the loopback guard is dropped. - on a loopback host, the same responses stop after one further read, which is what keeps the cloud e2e harness booting. (cherry picked from commit 9c78428)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T01:55:57.129Z",
"gitSha": "e658a2af360ebacafc1f51b1b4747a75a2bd078d",
"branch": "backport-21981-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.7240000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.306,
"layouts": 10,
"layoutDurationMs": 2.1029999999999998,
"taskDurationMs": 323.61899999999997,
"heapDeltaBytes": -17359020,
"heapUsedBytes": 82241572,
"domNodes": -201,
"jsHeapTotalBytes": 6385664,
"scriptDurationMs": 5.518000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.350000000003,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9109999999999996,
"layouts": 11,
"layoutDurationMs": 2.73,
"taskDurationMs": 373.928,
"heapDeltaBytes": -2556016,
"heapUsedBytes": 87808924,
"domNodes": -200,
"jsHeapTotalBytes": 1282048,
"scriptDurationMs": 8.587,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.0580000000132,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.755,
"layouts": 9,
"layoutDurationMs": 1.863,
"taskDurationMs": 536.6229999999999,
"heapDeltaBytes": -1886276,
"heapUsedBytes": 88481108,
"domNodes": -201,
"jsHeapTotalBytes": -196608,
"scriptDurationMs": 89.59,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1961.8580000000065,
"styleRecalcs": 82,
"styleRecalcDurationMs": 11.196,
"layouts": 10,
"layoutDurationMs": 1.9449999999999998,
"taskDurationMs": 719.554,
"heapDeltaBytes": -371012,
"heapUsedBytes": 107609980,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 93.819,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.6760000000254,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.5939999999999994,
"layouts": 12,
"layoutDurationMs": 2.218,
"taskDurationMs": 218.37599999999998,
"heapDeltaBytes": -1359900,
"heapUsedBytes": 88937364,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 6.352,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.9980000000373,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.65,
"layouts": 12,
"layoutDurationMs": 2.1580000000000004,
"taskDurationMs": 221.049,
"heapDeltaBytes": 1732188,
"heapUsedBytes": 106599968,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 6.792000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 401.83999999999287,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.792,
"layouts": 10,
"layoutDurationMs": 2.225,
"taskDurationMs": 267.60699999999997,
"heapDeltaBytes": 3313300,
"heapUsedBytes": 94046808,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 102.005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999984,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 400.20599999996875,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.868,
"layouts": 11,
"layoutDurationMs": 2.608,
"taskDurationMs": 273.56100000000004,
"heapDeltaBytes": 3326852,
"heapUsedBytes": 93665468,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 105.736,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 862.0919999999899,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.10600000000005,
"heapDeltaBytes": -17006236,
"heapUsedBytes": 102230204,
"domNodes": -230,
"jsHeapTotalBytes": 15015936,
"scriptDurationMs": 34.21399999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 236,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 889.7820000000252,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.845,
"heapDeltaBytes": -8504104,
"heapUsedBytes": 102935788,
"domNodes": -210,
"jsHeapTotalBytes": 8278016,
"scriptDurationMs": 31.454000000000004,
"eventListeners": -168,
"totalBlockingTimeMs": 253,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.0209999999872,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 248.81900000000013,
"heapDeltaBytes": -4678368,
"heapUsedBytes": 97415692,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 78.30599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 78,
"frameDurationMs": 20.097058823529416,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 670.6120000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 258.80899999999986,
"heapDeltaBytes": -4188596,
"heapUsedBytes": 97512412,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 81.898,
"eventListeners": 0,
"totalBlockingTimeMs": 79,
"frameDurationMs": 20.70606060606061,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5963.415999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4879.775000000001,
"heapDeltaBytes": 29218828,
"heapUsedBytes": 138360456,
"domNodes": -296,
"jsHeapTotalBytes": 34406400,
"scriptDurationMs": 3863.321,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.255016181229774,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5455.712999999946,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1590000000000003,
"layouts": 4,
"layoutDurationMs": 1.025,
"taskDurationMs": 4582.707,
"heapDeltaBytes": 25477720,
"heapUsedBytes": 133917328,
"domNodes": -276,
"jsHeapTotalBytes": 31522816,
"scriptDurationMs": 3630.903,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.697394136807816,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6423.540000000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8149999999999997,
"layouts": 3,
"layoutDurationMs": 0.649,
"taskDurationMs": 5431.728,
"heapDeltaBytes": 25739684,
"heapUsedBytes": 135050132,
"domNodes": -296,
"jsHeapTotalBytes": 34668544,
"scriptDurationMs": 4211.1359999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 241,
"frameDurationMs": 19.79384615384615,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5553.498000000047,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7210000000000003,
"layouts": 3,
"layoutDurationMs": 0.6329999999999999,
"taskDurationMs": 4678.507,
"heapDeltaBytes": 33771004,
"heapUsedBytes": 142671076,
"domNodes": -296,
"jsHeapTotalBytes": 19464192,
"scriptDurationMs": 3576.4189999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.618412698412698,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-combo-open",
"durationMs": 132.8579999999988,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.655000000000001,
"layouts": 12,
"layoutDurationMs": 2.5010000000000003,
"taskDurationMs": 87.335,
"heapDeltaBytes": 15398676,
"heapUsedBytes": 120417496,
"domNodes": 917,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 5.295999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.028571428571468,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 125.9560000000306,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.743,
"layouts": 12,
"layoutDurationMs": 2.6629999999999994,
"taskDurationMs": 87.53599999999999,
"heapDeltaBytes": 13231412,
"heapUsedBytes": 120344628,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.164999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.042857142857105,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2026.3740000000325,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.042,
"layouts": 11,
"layoutDurationMs": 1.833,
"taskDurationMs": 362.644,
"heapDeltaBytes": -22211028,
"heapUsedBytes": 98038408,
"domNodes": -296,
"jsHeapTotalBytes": -2703360,
"scriptDurationMs": 19.741,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.8710000000324,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.83,
"layouts": 9,
"layoutDurationMs": 1.604,
"taskDurationMs": 361.691,
"heapDeltaBytes": -3721028,
"heapUsedBytes": 99790220,
"domNodes": -296,
"jsHeapTotalBytes": -3391488,
"scriptDurationMs": 19.249,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2114.531999999997,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.427999999999999,
"layouts": 8,
"layoutDurationMs": 1.649,
"taskDurationMs": 1030.8619999999999,
"heapDeltaBytes": 808908,
"heapUsedBytes": 104826152,
"domNodes": -296,
"jsHeapTotalBytes": -1253376,
"scriptDurationMs": 526.02,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283467,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2098.852000000022,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.549999999999999,
"layouts": 9,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 918.61,
"heapDeltaBytes": -2131500,
"heapUsedBytes": 108963976,
"domNodes": -276,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 508.91300000000007,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3140.325999999959,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.981,
"layouts": 68,
"layoutDurationMs": 10.343,
"taskDurationMs": 991.1370000000001,
"heapDeltaBytes": -21335472,
"heapUsedBytes": 91457172,
"domNodes": -272,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 469.064,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137568,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3122.6720000000228,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.427,
"layouts": 67,
"layoutDurationMs": 10.508999999999999,
"taskDurationMs": 1040.781,
"heapDeltaBytes": 6725552,
"heapUsedBytes": 119426188,
"domNodes": 24,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 480.23299999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2219.942000000003,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.516,
"layouts": 6,
"layoutDurationMs": 1.3339999999999999,
"taskDurationMs": 1177.079,
"heapDeltaBytes": -9718556,
"heapUsedBytes": 103472440,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 587.062,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.792424242424243,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2251.2229999999818,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.3759999999999994,
"layouts": 7,
"layoutDurationMs": 1.4519999999999997,
"taskDurationMs": 1160.0710000000001,
"heapDeltaBytes": 17082908,
"heapUsedBytes": 123890884,
"domNodes": 0,
"jsHeapTotalBytes": 5664768,
"scriptDurationMs": 582.272,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.4869999999792,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.01,
"layouts": 10,
"layoutDurationMs": 1.7550000000000001,
"taskDurationMs": 365.33000000000004,
"heapDeltaBytes": -129364,
"heapUsedBytes": 103120484,
"domNodes": -276,
"jsHeapTotalBytes": -2002944,
"scriptDurationMs": 18.566999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2022.2190000000069,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.817,
"layouts": 10,
"layoutDurationMs": 1.6620000000000001,
"taskDurationMs": 376.039,
"heapDeltaBytes": -5305944,
"heapUsedBytes": 113218132,
"domNodes": -297,
"jsHeapTotalBytes": -1732608,
"scriptDurationMs": 17.663,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 398.1709999999907,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.325000000000001,
"layouts": 11,
"layoutDurationMs": 2.431,
"taskDurationMs": 255.44,
"heapDeltaBytes": -1335496,
"heapUsedBytes": 89895688,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 87.22,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.22399999999425,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.512,
"layouts": 10,
"layoutDurationMs": 2.149,
"taskDurationMs": 266.118,
"heapDeltaBytes": 2670092,
"heapUsedBytes": 109055384,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 90.461,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000005,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2027.0890000000463,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.9490000000000003,
"layouts": 10,
"layoutDurationMs": 1.727,
"taskDurationMs": 243.392,
"heapDeltaBytes": 6206844,
"heapUsedBytes": 97186564,
"domNodes": -218,
"jsHeapTotalBytes": 1638400,
"scriptDurationMs": 4.945999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.9320000000066,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0709999999999997,
"layouts": 10,
"layoutDurationMs": 1.8449999999999998,
"taskDurationMs": 314.92299999999994,
"heapDeltaBytes": -2274356,
"heapUsedBytes": 87734576,
"domNodes": -219,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 5.039999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1978.0349999999771,
"styleRecalcs": 88,
"styleRecalcDurationMs": 12.049,
"layouts": 10,
"layoutDurationMs": 1.932,
"taskDurationMs": 756.2449999999999,
"heapDeltaBytes": -28262048,
"heapUsedBytes": 78622916,
"domNodes": -210,
"jsHeapTotalBytes": 2191360,
"scriptDurationMs": 70.217,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487396,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.9520000000339,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.377,
"layouts": 12,
"layoutDurationMs": 2.483,
"taskDurationMs": 510.59600000000006,
"heapDeltaBytes": -3812012,
"heapUsedBytes": 88691328,
"domNodes": -211,
"jsHeapTotalBytes": -28672,
"scriptDurationMs": 69.299,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 800.5679999999984,
"styleRecalcs": 19,
"styleRecalcDurationMs": 14.886,
"layouts": 5,
"layoutDurationMs": 9.209999999999999,
"taskDurationMs": 583.5910000000001,
"heapDeltaBytes": 16316108,
"heapUsedBytes": 137552408,
"domNodes": 16030,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 17.226000000000003,
"eventListeners": 3244,
"totalBlockingTimeMs": 60,
"frameDurationMs": 19.51219512195122,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8169.268999999986,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.634999999999998,
"layouts": 10,
"layoutDurationMs": 2.0700000000000003,
"taskDurationMs": 3556.536,
"heapDeltaBytes": -12906452,
"heapUsedBytes": 109380672,
"domNodes": -297,
"jsHeapTotalBytes": -380928,
"scriptDurationMs": 1745.639,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591836734694,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8104.332999999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.815,
"layouts": 10,
"layoutDurationMs": 2.13,
"taskDurationMs": 3022.443,
"heapDeltaBytes": -23096600,
"heapUsedBytes": 88045712,
"domNodes": -296,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 1632.415,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665843621399176,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13328.755999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12510.778999999999,
"heapDeltaBytes": -32229292,
"heapUsedBytes": 292908448,
"domNodes": -3344,
"jsHeapTotalBytes": 36163584,
"scriptDurationMs": 169.703,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.829836065573772,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 13236.653999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12520.717999999999,
"heapDeltaBytes": -32391128,
"heapUsedBytes": 278739176,
"domNodes": -3344,
"jsHeapTotalBytes": 27774976,
"scriptDurationMs": 143.245,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.193467336683415,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 16415.256,
"styleRecalcs": 117,
"styleRecalcDurationMs": 13.297000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15881.239000000001,
"heapDeltaBytes": -39192032,
"heapUsedBytes": 286024148,
"domNodes": -3344,
"jsHeapTotalBytes": 22007808,
"scriptDurationMs": 533.9569999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 29.76297640653358,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 16322.380000000067,
"styleRecalcs": 119,
"styleRecalcDurationMs": 12.051000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15805.397,
"heapDeltaBytes": -15879584,
"heapUsedBytes": 295187652,
"domNodes": -3344,
"jsHeapTotalBytes": 23842816,
"scriptDurationMs": 523.908,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.85850091407678,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-node-resize-workload",
"durationMs": 4895.448999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 36.84899999999999,
"layouts": 20,
"layoutDurationMs": 15.704999999999997,
"taskDurationMs": 4802.927000000001,
"heapDeltaBytes": -19560216,
"heapUsedBytes": 301058936,
"domNodes": -3344,
"jsHeapTotalBytes": 26726400,
"scriptDurationMs": 61.089999999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.724705882352946,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "vue-node-resize-workload",
"durationMs": 4875.833000000057,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.04599999999999,
"layouts": 20,
"layoutDurationMs": 22.381999999999998,
"taskDurationMs": 4733.478,
"heapDeltaBytes": -18193488,
"heapUsedBytes": 311056600,
"domNodes": -3344,
"jsHeapTotalBytes": 27869184,
"scriptDurationMs": 61.644000000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.39011627906977,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6626.778999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6247.116999999999,
"heapDeltaBytes": 8926104,
"heapUsedBytes": 284124980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 68.193,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.748196721311476,
"p95FrameDurationMs": 33.5
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6732.324999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6311.769,
"heapDeltaBytes": -4202260,
"heapUsedBytes": 298242168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 72.14500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.295033112582775,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 69.69600000002174,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.554,
"layouts": 4,
"layoutDurationMs": 1.1219999999999999,
"taskDurationMs": 46.333,
"heapDeltaBytes": 4797960,
"heapUsedBytes": 103215248,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.2669999999999995,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 73.26399999999467,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.298999999999999,
"layouts": 5,
"layoutDurationMs": 1.572,
"taskDurationMs": 45.275000000000006,
"heapDeltaBytes": 4559668,
"heapUsedBytes": 107054600,
"domNodes": 116,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.0829999999999997,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 174.3139999999812,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.696,
"layouts": 76,
"layoutDurationMs": 9.158,
"taskDurationMs": 140.077,
"heapDeltaBytes": 9177048,
"heapUsedBytes": 96058888,
"domNodes": 4,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 59.435,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 172.3819999999705,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5860000000000001,
"layouts": 76,
"layoutDurationMs": 9.008000000000001,
"taskDurationMs": 137.15000000000003,
"heapDeltaBytes": 9093000,
"heapUsedBytes": 95039240,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 57.084999999999994,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 214.3270000000257,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1139999999999999,
"layouts": 76,
"layoutDurationMs": 8.424,
"taskDurationMs": 176.678,
"heapDeltaBytes": -7134624,
"heapUsedBytes": 105225516,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 56.859,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 207.2920000000522,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.156,
"layouts": 76,
"layoutDurationMs": 8.789,
"taskDurationMs": 180.12,
"heapDeltaBytes": -2252912,
"heapUsedBytes": 118172228,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 59.955999999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 59.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2988 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 22c2e559db9d4d47827563052eee280ac65a40cd
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (136)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.58 #22339 +/- ##
==========================================
Coverage 84.03% 84.03%
==========================================
Files 3175 3175
Lines 166009 166033 +24
Branches 41796 41806 +10
==========================================
+ Hits 139500 139526 +26
+ Misses 26117 26115 -2
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
… of falling back to dev Firebase (#22342) Backport of #21981 (IR-153) to `cloud/1.59`. Clean cherry-pick. #21981 was merged after the 1.59 cut and never carried 1.59 labels, so the bot didn't try it. 1.58 backports: #22338 (cloud), #22339 (core). ## Why on 1.59 `cloud/1.59` is on testcloud and promotes to prod next. Without this, prod regresses to the IR-153 behavior on promote. ## Checks - `refreshRemoteConfig.test.ts`: 30/30 passed - `pnpm typecheck` passed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Dante <bunggl@naver.com>
…of falling back to dev Firebase (#22343) Backport of #21981 (IR-153) to `core/1.59`. Clean cherry-pick. #21981 was merged after the 1.59 cut and never carried 1.59 labels, so the bot didn't try it. 1.58 backports: #22338 (cloud), #22339 (core). ## Why on 1.59 Keeps `core/1.59` in step with `cloud/1.59`. The retry loop only runs on the cloud bundle; local and desktop keep the single read. ## Checks - `refreshRemoteConfig.test.ts`: 30/30 passed - `pnpm typecheck` passed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Dante <bunggl@naver.com>
Backport of #21981 (IR-153) to
core/1.58. Manual: the auto-backport hit a conflict insrc/main.ts.How
src/config/firebase.tsandsrc/platform/remoteConfig/refreshRemoteConfig.{ts,test.ts}apply unchanged.Why on 1.58
Keeps
core/1.58in step withcloud/1.58(#22338). The retry loop only runs on the cloud bundle; local and desktop keep the single read.Checks
refreshRemoteConfig.test.ts: 29/29 passedpnpm typecheckpassed🤖 Generated with Claude Code