Repository navigation
[backport cloud/1.59] fix(cloud): retry startup remote config instead of falling back to dev Firebase - #22342
Conversation
…v Firebase (#21981) ## Why IR-153: production users were intermittently signed in against the **dev** Firebase project (`dreamboothy-dev`) and production then rejected every request (`expected dreamboothy but got dreamboothy-dev`), showing a logout / "Couldn't load your workspace" until a reload. RUM, last 30 days on `cloud.comfy.org`: 119 sessions loaded the dev auth iframe (vs 17,850 on prod), with 41 Google and 19 password sign-in sessions sent to dev, mostly on slow connections. The dev project's sign-in allowlist rejects non-staff, so customers saw a failed sign-in rather than dev data. Once the page has the right config, product use and billing are unaffected. ## Root cause - `getFirebaseConfig()` uses the server's `firebase_config`, else `BUILD_TIME_CONFIG` (`src/config/firebase.ts`). - Cloud bundles (including the prod variant in `Comfy-Org/cloud` `frontend-asset-predeploy.yml`) are built without `USE_PROD_CONFIG`, so `BUILD_TIME_CONFIG` is the dev project. - At startup the anonymous `/features` read has a 5s timeout; on failure `remoteConfigState` becomes `'error'` and `firebaseIdentity` (which only guards `'unloaded'`) initializes from that dev default. - Firebase initializes once, so the later authenticated refresh / 10‑minute poll cannot repair the page. ## How On cloud, startup now retries the anonymous `/features` read with capped backoff (1s → 10s) behind the existing splash until the server names the Firebase project (`loadRemoteConfigUntilReady`). A successful read is not enough on its own: `firebase_config` is optional in the response contract, so a 200 that omits it would otherwise end bootstrap with no server config and let `getFirebaseConfig()` fall through to the build-time default — the same `dreamboothy-dev` outcome. The loop therefore also requires `hasServerFirebaseConfig()`, which counts an explicit `firebase_env: 'dev'` as server-named, since that is a server instruction rather than a build-time guess. `isCloud` is the bundle flavour, not "served by the Cloud API": a cloud bundle can be served by a local ComfyUI, whose `/features` answers 200 and never carries `firebase_config`. Waiting indefinitely there never starts the app — every cloud Playwright shard timed out that way at `59e93a79` — so the two cases are split on `isLoopbackHost(window.location.hostname)`. A deployed host keeps waiting rather than start Firebase on the bundled project; a loopback harness, whose server has no project to send, stops after one further read. A read that *fails* still retries in both, which is the shape the incident had. The first project-less read reports `startup_remote_config_without_firebase_project` (tagged `localCloud`), so a deployed Cloud omitting the field is visible while it waits rather than silent. Firebase therefore only ever starts from the server's `firebase_config`; there is no build-time fallback on cloud. A long outage shows up as a `timed_out` bootstrap report with `startup/remote-config` pending. Local and desktop keep the single read and their build-time defaults, since their server does not send `firebase_config`. Alternative considered: building the prod bundle with `USE_PROD_CONFIG=true`. That prevents the wrong project on prod but still boots on a guessed config when the server does not answer, and staging bundles keep the dev guess. ## AS IS / TO BE AS IS (`origin/main`, `pnpm dev:cloud` → testcloud, `/api/features` aborted): one request, never retried, never answered; the login page renders anyway and Firebase is initialized from the build-time default `dreamboothy-dev`. <img width="640" alt="AS IS" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/asis-final.png" /> TO BE (PR branch, same setup, `/api/features` aborted twice then let through): the splash holds during retries #1 and #2 (1s, 2s backoff), request #3 answers 200, then the login page loads with Firebase on the server's `firebase_config`. testcloud's own `firebase_config` is `dreamboothy-dev`, so the project name matches AS IS here; the difference is that it now comes from the server rather than the build default. On prod the server returns `dreamboothy`. <img width="640" alt="TO BE splash during retries" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/tobe-splash.png" /> <img width="640" alt="TO BE loaded" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/tobe-final.png" /> ## Tests `refreshRemoteConfig.test.ts`: - abort → 503 → success resolves with the server config after three reads. Fails when the loop returns after the first read. - a 200 without `firebase_config` keeps retrying and resolves on the next read that carries one. Fails with `expected "vi.fn()" to be called 2 times, but got 1 times` when the `hasServerFirebaseConfig()` gate is removed. - a 200 carrying only `firebase_env: 'dev'` resolves on the first read, pinning that branch against an accidental narrowing. - on a deployed host (`cloud.comfy.org`), repeated 200s without a project never resolve the bootstrap promise, so Firebase initialization is unreachable. Fails when the loopback guard is dropped. - on a loopback host, the same responses stop after one further read, which is what keeps the cloud e2e harness booting. (cherry picked from commit 9c78428)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T02:35:08.496Z",
"gitSha": "e08fc931aa7db3adc2ce771e868012cc681ab1cb",
"branch": "backport-21981-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.0429999999917,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8460000000000005,
"layouts": 8,
"layoutDurationMs": 2.825,
"taskDurationMs": 581.588,
"heapDeltaBytes": 1501820,
"heapUsedBytes": 61908032,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 11.549000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2023.2169999999314,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8719999999999994,
"layouts": 9,
"layoutDurationMs": 2.6620000000000004,
"taskDurationMs": 573.6479999999999,
"heapDeltaBytes": 1815228,
"heapUsedBytes": 63220944,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.145000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.0419999999679,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.745999999999999,
"layouts": 9,
"layoutDurationMs": 2.7039999999999997,
"taskDurationMs": 950.4670000000001,
"heapDeltaBytes": 23348968,
"heapUsedBytes": 84259552,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 171.464,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.543000000076,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.834000000000003,
"layouts": 9,
"layoutDurationMs": 2.677,
"taskDurationMs": 944.346,
"heapDeltaBytes": -2265364,
"heapUsedBytes": 68201596,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 173.398,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.4959999999728,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.039999999999999,
"layouts": 9,
"layoutDurationMs": 2.6879999999999997,
"taskDurationMs": 459.703,
"heapDeltaBytes": -1841960,
"heapUsedBytes": 59564520,
"domNodes": 56,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 14.078999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.4890000000332,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.2330000000000005,
"layouts": 9,
"layoutDurationMs": 2.645,
"taskDurationMs": 431.23699999999997,
"heapDeltaBytes": 24277604,
"heapUsedBytes": 85968284,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.474000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 760.1760000000013,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3080000000000003,
"layouts": 10,
"layoutDurationMs": 3.2529999999999997,
"taskDurationMs": 536.371,
"heapDeltaBytes": 3877440,
"heapUsedBytes": 65036964,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 179.807,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 701.9189999999753,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8200000000000003,
"layouts": 9,
"layoutDurationMs": 2.9029999999999996,
"taskDurationMs": 502.138,
"heapDeltaBytes": 6846808,
"heapUsedBytes": 77014012,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 172.33200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1236.8800000000135,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 966.367,
"heapDeltaBytes": -12358828,
"heapUsedBytes": 75364504,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 73.88300000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 548,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1421.54000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1153.0310000000002,
"heapDeltaBytes": -11874284,
"heapUsedBytes": 75757268,
"domNodes": -191,
"jsHeapTotalBytes": 24125440,
"scriptDurationMs": 87.754,
"eventListeners": -106,
"totalBlockingTimeMs": 734,
"frameDurationMs": 38.286486486486496,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 927.3019999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.8689999999999,
"heapDeltaBytes": -28073044,
"heapUsedBytes": 65768396,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 180.94699999999997,
"eventListeners": -106,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 907.1450000000141,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.0480000000005,
"heapDeltaBytes": -28878064,
"heapUsedBytes": 65286760,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 174.367,
"eventListeners": -106,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11527.84200000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.29500000000000015,
"layouts": 1,
"layoutDurationMs": 0.4140000000000003,
"taskDurationMs": 10607.722,
"heapDeltaBytes": 79592364,
"heapUsedBytes": 154408532,
"domNodes": -257,
"jsHeapTotalBytes": 74051584,
"scriptDurationMs": 8520.029,
"eventListeners": -68,
"totalBlockingTimeMs": 1395,
"frameDurationMs": 32.168156424581,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10765.109999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9955.685,
"heapDeltaBytes": -23472828,
"heapUsedBytes": 65282744,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 8076.936999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 986,
"frameDurationMs": 31.480409356725144,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10560.001999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9828.782,
"heapDeltaBytes": 89090812,
"heapUsedBytes": 163448536,
"domNodes": -257,
"jsHeapTotalBytes": 73527296,
"scriptDurationMs": 7874.531999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 950,
"frameDurationMs": 31.68018018018018,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10479.77800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9659.774000000001,
"heapDeltaBytes": 58948064,
"heapUsedBytes": 132281744,
"domNodes": -257,
"jsHeapTotalBytes": 66187264,
"scriptDurationMs": 7711.588,
"eventListeners": -68,
"totalBlockingTimeMs": 978,
"frameDurationMs": 31.056973293768547,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 284.66000000000236,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.155999999999995,
"layouts": 11,
"layoutDurationMs": 3.721,
"taskDurationMs": 251.37599999999998,
"heapDeltaBytes": -1239668,
"heapUsedBytes": 68132392,
"domNodes": -2315,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 10.228,
"eventListeners": -573,
"totalBlockingTimeMs": 9,
"frameDurationMs": 24.24545454545453,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 285.2020000000266,
"styleRecalcs": 23,
"styleRecalcDurationMs": 20.575999999999997,
"layouts": 11,
"layoutDurationMs": 3.294,
"taskDurationMs": 234.05200000000002,
"heapDeltaBytes": -6384320,
"heapUsedBytes": 68688556,
"domNodes": 750,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 13.722000000000001,
"eventListeners": 64,
"totalBlockingTimeMs": 45,
"frameDurationMs": 31.4777777777778,
"p95FrameDurationMs": 150.0999999999999
},
{
"name": "large-graph-idle",
"durationMs": 2056.939,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.740000000000001,
"layouts": 8,
"layoutDurationMs": 2.508,
"taskDurationMs": 724.732,
"heapDeltaBytes": -379648,
"heapUsedBytes": 79248112,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 36.818,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.8879999999817,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.718,
"layouts": 9,
"layoutDurationMs": 2.637,
"taskDurationMs": 686.831,
"heapDeltaBytes": -10517124,
"heapUsedBytes": 64294608,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 39.059999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2687.3939999999834,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.619,
"layouts": 7,
"layoutDurationMs": 1.8969999999999998,
"taskDurationMs": 1757.2329999999997,
"heapDeltaBytes": 6217628,
"heapUsedBytes": 81567192,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 845.616,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665432098765432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2722.364999999968,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.138,
"layouts": 7,
"layoutDurationMs": 1.9389999999999998,
"taskDurationMs": 1813.864,
"heapDeltaBytes": 529308,
"heapUsedBytes": 76411348,
"domNodes": -257,
"jsHeapTotalBytes": 5857280,
"scriptDurationMs": 871.5540000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666257668711655,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3588.9510000000087,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.406000000000002,
"layouts": 64,
"layoutDurationMs": 11.360999999999999,
"taskDurationMs": 1704.9899999999998,
"heapDeltaBytes": -29919172,
"heapUsedBytes": 64092848,
"domNodes": -233,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 811.8380000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3886.5529999999353,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.950000000000001,
"layouts": 63,
"layoutDurationMs": 10.57,
"taskDurationMs": 1886.241,
"heapDeltaBytes": 3486816,
"heapUsedBytes": 83594484,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 813.581,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66609442060086,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3265.02099999999,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.48,
"layouts": 5,
"layoutDurationMs": 1.5940000000000003,
"taskDurationMs": 2156.9179999999997,
"heapDeltaBytes": 10248452,
"heapUsedBytes": 82568328,
"domNodes": -257,
"jsHeapTotalBytes": 2379776,
"scriptDurationMs": 1048.583,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.837628865979383,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3100.1750000000357,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.929,
"layouts": 5,
"layoutDurationMs": 1.5639999999999998,
"taskDurationMs": 1988.181,
"heapDeltaBytes": 19455348,
"heapUsedBytes": 98735292,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 960.898,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75597826086956,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3074.3109999999942,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7160000000000004,
"layouts": 6,
"layoutDurationMs": 1.4459999999999997,
"taskDurationMs": 799.9979999999999,
"heapDeltaBytes": 9896688,
"heapUsedBytes": 87070668,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 379.00300000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3143.3229999999526,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.059,
"layouts": 7,
"layoutDurationMs": 1.9679999999999997,
"taskDurationMs": 824.566,
"heapDeltaBytes": 4752328,
"heapUsedBytes": 84396748,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 387.644,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.253000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3619999999999997,
"layouts": 7,
"layoutDurationMs": 2.2220000000000004,
"taskDurationMs": 686.5409999999999,
"heapDeltaBytes": -9162572,
"heapUsedBytes": 68271504,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 33.402,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.392999999919,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0040000000000004,
"layouts": 7,
"layoutDurationMs": 1.8509999999999998,
"taskDurationMs": 653.9710000000001,
"heapDeltaBytes": -2399972,
"heapUsedBytes": 76868744,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 35.333999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2901.6809999999964,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.926,
"layouts": 7,
"layoutDurationMs": 2.139,
"taskDurationMs": 721.215,
"heapDeltaBytes": -9590140,
"heapUsedBytes": 83660684,
"domNodes": -251,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 233.79800000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666091954022985,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2887.8480000000195,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.611999999999998,
"layouts": 6,
"layoutDurationMs": 1.8909999999999998,
"taskDurationMs": 624.927,
"heapDeltaBytes": -1888336,
"heapUsedBytes": 75699288,
"domNodes": -253,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 198.882,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665895953757225,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3313.449999999989,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1530000000000005,
"layouts": 7,
"layoutDurationMs": 2.0999999999999996,
"taskDurationMs": 996.8000000000002,
"heapDeltaBytes": 1784248,
"heapUsedBytes": 78908624,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 390.638,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665656565656565,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3375.646999999958,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8570000000000002,
"layouts": 6,
"layoutDurationMs": 1.823,
"taskDurationMs": 1014.6809999999999,
"heapDeltaBytes": -7700352,
"heapUsedBytes": 85646060,
"domNodes": -257,
"jsHeapTotalBytes": 7503872,
"scriptDurationMs": 403.935,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.1850000000027,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.363,
"layouts": 9,
"layoutDurationMs": 2.691,
"taskDurationMs": 464.729,
"heapDeltaBytes": 614956,
"heapUsedBytes": 62538556,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 154.00900000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.8009999999949,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.082000000000001,
"layouts": 9,
"layoutDurationMs": 2.7489999999999997,
"taskDurationMs": 458.19100000000003,
"heapDeltaBytes": -689200,
"heapUsedBytes": 61152720,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 152.507,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2038.1679999999847,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.914999999999999,
"layouts": 9,
"layoutDurationMs": 2.6850000000000005,
"taskDurationMs": 572.4780000000001,
"heapDeltaBytes": 6019528,
"heapUsedBytes": 77851032,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 11.080000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.591000000034,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.927,
"layouts": 8,
"layoutDurationMs": 2.6550000000000002,
"taskDurationMs": 545.264,
"heapDeltaBytes": 2174808,
"heapUsedBytes": 64523904,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.887,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.7790000000218,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.784,
"layouts": 9,
"layoutDurationMs": 2.293,
"taskDurationMs": 866.6640000000001,
"heapDeltaBytes": -5846860,
"heapUsedBytes": 65572684,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 114.706,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.3889999999874,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.359999999999998,
"layouts": 9,
"layoutDurationMs": 2.5269999999999997,
"taskDurationMs": 870.231,
"heapDeltaBytes": 19876852,
"heapUsedBytes": 81198432,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 113.17099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.3190000000218,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.121999999999996,
"layouts": 5,
"layoutDurationMs": 14.119,
"taskDurationMs": 1130.5510000000002,
"heapDeltaBytes": 9694868,
"heapUsedBytes": 87555116,
"domNodes": 16030,
"jsHeapTotalBytes": 14815232,
"scriptDurationMs": 33.501999999999995,
"eventListeners": 3246,
"totalBlockingTimeMs": 174,
"frameDurationMs": 20.090410958904116,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10466.60700000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.993000000000002,
"layouts": 7,
"layoutDurationMs": 2.0509999999999997,
"taskDurationMs": 6340.196000000001,
"heapDeltaBytes": -15410912,
"heapUsedBytes": 61833764,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 2832.809,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665764331210188,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10176.545000000033,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.790000000000003,
"layouts": 8,
"layoutDurationMs": 2.2110000000000003,
"taskDurationMs": 6111.951,
"heapDeltaBytes": -19479172,
"heapUsedBytes": 71332376,
"domNodes": -257,
"jsHeapTotalBytes": 6385664,
"scriptDurationMs": 2799.4100000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69343185550082,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23150.80599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22708.195,
"heapDeltaBytes": -28034780,
"heapUsedBytes": 255169764,
"domNodes": -3343,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 323.169,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.48584229390681,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 23431.52699999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23048.358,
"heapDeltaBytes": 2571740,
"heapUsedBytes": 286234408,
"domNodes": -3343,
"jsHeapTotalBytes": 12050432,
"scriptDurationMs": 326.373,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.45,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28481.761000000006,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.803000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28071.788999999997,
"heapDeltaBytes": -16736156,
"heapUsedBytes": 260164340,
"domNodes": -3343,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 947.871,
"eventListeners": -651,
"totalBlockingTimeMs": 47,
"frameDurationMs": 53.33726591760299,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 27975.180000000022,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.52799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27645.884000000002,
"heapDeltaBytes": -24213900,
"heapUsedBytes": 253644176,
"domNodes": -3343,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 905.113,
"eventListeners": -651,
"totalBlockingTimeMs": 9,
"frameDurationMs": 52.042565055762076,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8372.615999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.78999999999999,
"layouts": 20,
"layoutDurationMs": 23.119000000000014,
"taskDurationMs": 8271.309000000001,
"heapDeltaBytes": -34290512,
"heapUsedBytes": 266720428,
"domNodes": -3343,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 123.008,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.63068181818183,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8338.096000000063,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.72299999999998,
"layouts": 20,
"layoutDurationMs": 28.029,
"taskDurationMs": 8209.484,
"heapDeltaBytes": -25016736,
"heapUsedBytes": 266549616,
"domNodes": -3343,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 126.90899999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.078531073446314,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11742.768000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11433.249,
"heapDeltaBytes": 9997528,
"heapUsedBytes": 273694492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.173,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.23835616438357,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11458.635000000071,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11283.027,
"heapDeltaBytes": -4375536,
"heapUsedBytes": 268674504,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.821,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.745551601423486,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 133.97000000003345,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.503000000000002,
"layouts": 8,
"layoutDurationMs": 4.011000000000001,
"taskDurationMs": 107.926,
"heapDeltaBytes": -12858588,
"heapUsedBytes": 62490424,
"domNodes": 128,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 11.745,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67777777777782,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 120.35600000001523,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.799999999999999,
"layouts": 8,
"layoutDurationMs": 3.7869999999999995,
"taskDurationMs": 89.95400000000001,
"heapDeltaBytes": 4594832,
"heapUsedBytes": 64036728,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.354999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 451.49099999991904,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.666,
"layouts": 76,
"layoutDurationMs": 15.355,
"taskDurationMs": 406.74399999999997,
"heapDeltaBytes": -4737468,
"heapUsedBytes": 40418904,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 189.856,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370385,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 471.39500000002954,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.671,
"layouts": 76,
"layoutDurationMs": 16.028000000000002,
"taskDurationMs": 420.405,
"heapDeltaBytes": -4762008,
"heapUsedBytes": 39519944,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 195.002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 648.4959999999091,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.397,
"layouts": 76,
"layoutDurationMs": 17.297,
"taskDurationMs": 608.513,
"heapDeltaBytes": 2057548,
"heapUsedBytes": 103476396,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 251.19199999999998,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 603.9519999999357,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.752,
"layouts": 76,
"layoutDurationMs": 16.621,
"taskDurationMs": 568.636,
"heapDeltaBytes": 1947292,
"heapUsedBytes": 95360800,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 227.78799999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11621621621622,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3127 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 37016afbf5d75b4a847d7edac15d255b0431a516
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (224)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22342 +/- ##
=============================================
Coverage ? 87.11%
=============================================
Files ? 3027
Lines ? 158524
Branches ? 42453
=============================================
Hits ? 138106
Misses ? 19742
Partials ? 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21981 (IR-153) to
cloud/1.59. Clean cherry-pick. #21981 was merged after the 1.59 cut and never carried 1.59 labels, so the bot didn't try it. 1.58 backports: #22338 (cloud), #22339 (core).Why on 1.59
cloud/1.59is on testcloud and promotes to prod next. Without this, prod regresses to the IR-153 behavior on promote.Checks
refreshRemoteConfig.test.ts: 30/30 passedpnpm typecheckpassed🤖 Generated with Claude Code