Repository navigation
[backport core/1.59] fix(cloud): retry startup remote config instead of falling back to dev Firebase - #22343
Conversation
…v Firebase (#21981) ## Why IR-153: production users were intermittently signed in against the **dev** Firebase project (`dreamboothy-dev`) and production then rejected every request (`expected dreamboothy but got dreamboothy-dev`), showing a logout / "Couldn't load your workspace" until a reload. RUM, last 30 days on `cloud.comfy.org`: 119 sessions loaded the dev auth iframe (vs 17,850 on prod), with 41 Google and 19 password sign-in sessions sent to dev, mostly on slow connections. The dev project's sign-in allowlist rejects non-staff, so customers saw a failed sign-in rather than dev data. Once the page has the right config, product use and billing are unaffected. ## Root cause - `getFirebaseConfig()` uses the server's `firebase_config`, else `BUILD_TIME_CONFIG` (`src/config/firebase.ts`). - Cloud bundles (including the prod variant in `Comfy-Org/cloud` `frontend-asset-predeploy.yml`) are built without `USE_PROD_CONFIG`, so `BUILD_TIME_CONFIG` is the dev project. - At startup the anonymous `/features` read has a 5s timeout; on failure `remoteConfigState` becomes `'error'` and `firebaseIdentity` (which only guards `'unloaded'`) initializes from that dev default. - Firebase initializes once, so the later authenticated refresh / 10‑minute poll cannot repair the page. ## How On cloud, startup now retries the anonymous `/features` read with capped backoff (1s → 10s) behind the existing splash until the server names the Firebase project (`loadRemoteConfigUntilReady`). A successful read is not enough on its own: `firebase_config` is optional in the response contract, so a 200 that omits it would otherwise end bootstrap with no server config and let `getFirebaseConfig()` fall through to the build-time default — the same `dreamboothy-dev` outcome. The loop therefore also requires `hasServerFirebaseConfig()`, which counts an explicit `firebase_env: 'dev'` as server-named, since that is a server instruction rather than a build-time guess. `isCloud` is the bundle flavour, not "served by the Cloud API": a cloud bundle can be served by a local ComfyUI, whose `/features` answers 200 and never carries `firebase_config`. Waiting indefinitely there never starts the app — every cloud Playwright shard timed out that way at `59e93a79` — so the two cases are split on `isLoopbackHost(window.location.hostname)`. A deployed host keeps waiting rather than start Firebase on the bundled project; a loopback harness, whose server has no project to send, stops after one further read. A read that *fails* still retries in both, which is the shape the incident had. The first project-less read reports `startup_remote_config_without_firebase_project` (tagged `localCloud`), so a deployed Cloud omitting the field is visible while it waits rather than silent. Firebase therefore only ever starts from the server's `firebase_config`; there is no build-time fallback on cloud. A long outage shows up as a `timed_out` bootstrap report with `startup/remote-config` pending. Local and desktop keep the single read and their build-time defaults, since their server does not send `firebase_config`. Alternative considered: building the prod bundle with `USE_PROD_CONFIG=true`. That prevents the wrong project on prod but still boots on a guessed config when the server does not answer, and staging bundles keep the dev guess. ## AS IS / TO BE AS IS (`origin/main`, `pnpm dev:cloud` → testcloud, `/api/features` aborted): one request, never retried, never answered; the login page renders anyway and Firebase is initialized from the build-time default `dreamboothy-dev`. <img width="640" alt="AS IS" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/asis-final.png" /> TO BE (PR branch, same setup, `/api/features` aborted twice then let through): the splash holds during retries #1 and #2 (1s, 2s backoff), request #3 answers 200, then the login page loads with Firebase on the server's `firebase_config`. testcloud's own `firebase_config` is `dreamboothy-dev`, so the project name matches AS IS here; the difference is that it now comes from the server rather than the build default. On prod the server returns `dreamboothy`. <img width="640" alt="TO BE splash during retries" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/tobe-splash.png" /> <img width="640" alt="TO BE loaded" src="https://gist.githubusercontent.com/dante01yoon/1765936a04597e0ef15ebfa4e54fd4db/raw/da2eddeca02d8d0c58e8469e68ee67dcf6503f03/tobe-final.png" /> ## Tests `refreshRemoteConfig.test.ts`: - abort → 503 → success resolves with the server config after three reads. Fails when the loop returns after the first read. - a 200 without `firebase_config` keeps retrying and resolves on the next read that carries one. Fails with `expected "vi.fn()" to be called 2 times, but got 1 times` when the `hasServerFirebaseConfig()` gate is removed. - a 200 carrying only `firebase_env: 'dev'` resolves on the first read, pinning that branch against an accidental narrowing. - on a deployed host (`cloud.comfy.org`), repeated 200s without a project never resolve the bootstrap promise, so Firebase initialization is unreachable. Fails when the loopback guard is dropped. - on a loopback host, the same responses stop after one further read, which is what keeps the cloud e2e harness booting. (cherry picked from commit 9c78428)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T02:35:11.107Z",
"gitSha": "190b2e84c1a794939680adc63ac37fc9911c64fe",
"branch": "backport-21981-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.0810000000379,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.252,
"layouts": 9,
"layoutDurationMs": 2.934,
"taskDurationMs": 596.154,
"heapDeltaBytes": 5847372,
"heapUsedBytes": 76658856,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 12.321000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.6589999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.091,
"layouts": 9,
"layoutDurationMs": 3.33,
"taskDurationMs": 589.7090000000001,
"heapDeltaBytes": 3902064,
"heapUsedBytes": 65189480,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 12.6,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1794.2840000000047,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.664,
"layouts": 10,
"layoutDurationMs": 3.03,
"taskDurationMs": 920.0300000000001,
"heapDeltaBytes": -1927168,
"heapUsedBytes": 67898980,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 152.99699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1876.2439999999287,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.931,
"layouts": 10,
"layoutDurationMs": 2.823,
"taskDurationMs": 954.855,
"heapDeltaBytes": 21503296,
"heapUsedBytes": 82699244,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 162.957,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571424,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.582000000055,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.360000000000001,
"layouts": 10,
"layoutDurationMs": 3.329,
"taskDurationMs": 414.106,
"heapDeltaBytes": 24110416,
"heapUsedBytes": 84527768,
"domNodes": 56,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 11.910999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1697.2820000000866,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.644999999999999,
"layouts": 9,
"layoutDurationMs": 2.955,
"taskDurationMs": 434.74999999999994,
"heapDeltaBytes": -1004856,
"heapUsedBytes": 60447044,
"domNodes": 56,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 13.514999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 740.6480000000215,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9839999999999995,
"layouts": 10,
"layoutDurationMs": 2.7669999999999995,
"taskDurationMs": 526.698,
"heapDeltaBytes": 6648456,
"heapUsedBytes": 77337496,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 174.113,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 760.1339999999936,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.025000000000001,
"layouts": 9,
"layoutDurationMs": 2.838,
"taskDurationMs": 539.9209999999999,
"heapDeltaBytes": 3706152,
"heapUsedBytes": 65095436,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 178.755,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444445,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.0000000000127,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 929.142,
"heapDeltaBytes": -12290208,
"heapUsedBytes": 75201600,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 62.985,
"eventListeners": -106,
"totalBlockingTimeMs": 531,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1246.539000000098,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 957.2429999999999,
"heapDeltaBytes": -13917464,
"heapUsedBytes": 74511384,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 71.555,
"eventListeners": -106,
"totalBlockingTimeMs": 556,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.6040000000194,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.5509999999997,
"heapDeltaBytes": -28107536,
"heapUsedBytes": 66491164,
"domNodes": -191,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 151.05399999999997,
"eventListeners": -106,
"totalBlockingTimeMs": 202,
"frameDurationMs": 23.870270270270264,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.5900000000256,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.0619999999994,
"heapDeltaBytes": -27257228,
"heapUsedBytes": 65185904,
"domNodes": -191,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 153.93699999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 194,
"frameDurationMs": 24.07222222222221,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9982.430000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9062.671999999999,
"heapDeltaBytes": 76625896,
"heapUsedBytes": 149996468,
"domNodes": -257,
"jsHeapTotalBytes": 70643712,
"scriptDurationMs": 6933.947000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 518,
"frameDurationMs": 30.529051987767584,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10377.533999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9518.714,
"heapDeltaBytes": 67138920,
"heapUsedBytes": 141379488,
"domNodes": -257,
"jsHeapTotalBytes": 75100160,
"scriptDurationMs": 7421.091,
"eventListeners": -68,
"totalBlockingTimeMs": 581,
"frameDurationMs": 31.223493975903615,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9412.649999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8559.273,
"heapDeltaBytes": 52371224,
"heapUsedBytes": 126910396,
"domNodes": -257,
"jsHeapTotalBytes": 60682240,
"scriptDurationMs": 6550.9890000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 280,
"frameDurationMs": 29.745569620253164,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9790.87400000003,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.053000000000000096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8903.011999999999,
"heapDeltaBytes": 62756320,
"heapUsedBytes": 136020636,
"domNodes": -257,
"jsHeapTotalBytes": 64352256,
"scriptDurationMs": 6855.632,
"eventListeners": -68,
"totalBlockingTimeMs": 306,
"frameDurationMs": 30.571875000000006,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 248.06300000000192,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.109999999999998,
"layouts": 11,
"layoutDurationMs": 3.332,
"taskDurationMs": 196.41899999999998,
"heapDeltaBytes": 14450596,
"heapUsedBytes": 84618944,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 8.681,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.766666666666676,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 280.11099999991984,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.075999999999999,
"layouts": 11,
"layoutDurationMs": 3.9240000000000004,
"taskDurationMs": 239.96900000000002,
"heapDeltaBytes": -592484,
"heapUsedBytes": 68809064,
"domNodes": -2315,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 11.242,
"eventListeners": -573,
"totalBlockingTimeMs": 2,
"frameDurationMs": 22.225000000000023,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2056.4359999999624,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.603,
"layouts": 8,
"layoutDurationMs": 2.3880000000000003,
"taskDurationMs": 672.027,
"heapDeltaBytes": -6336,
"heapUsedBytes": 75739132,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 37.835,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2055.501999999933,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.705,
"layouts": 8,
"layoutDurationMs": 2.6790000000000003,
"taskDurationMs": 703.268,
"heapDeltaBytes": -17153460,
"heapUsedBytes": 61020216,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 37.568,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2562.564000000009,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.430000000000001,
"layouts": 7,
"layoutDurationMs": 2.058,
"taskDurationMs": 1785.8619999999999,
"heapDeltaBytes": 10568552,
"heapUsedBytes": 85510124,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 854.1270000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774509803921568,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2970.292000000086,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.611,
"layouts": 7,
"layoutDurationMs": 1.925,
"taskDurationMs": 1920.858,
"heapDeltaBytes": -15305336,
"heapUsedBytes": 63636628,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 919.077,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760451977401132,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3664.0560000000164,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.832,
"layouts": 64,
"layoutDurationMs": 11.575999999999999,
"taskDurationMs": 1889.443,
"heapDeltaBytes": -28864360,
"heapUsedBytes": 65351360,
"domNodes": -233,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 789.9470000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662100456621,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3836.827000000085,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.649000000000001,
"layouts": 64,
"layoutDurationMs": 11.187000000000001,
"taskDurationMs": 1920.1699999999996,
"heapDeltaBytes": 1936740,
"heapUsedBytes": 78849264,
"domNodes": -233,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 800.713,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666233766233766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3168.1560000000104,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.01,
"layouts": 4,
"layoutDurationMs": 1.005,
"taskDurationMs": 2060.7029999999995,
"heapDeltaBytes": -8051444,
"heapUsedBytes": 70956980,
"domNodes": 0,
"jsHeapTotalBytes": 6381568,
"scriptDurationMs": 1007.123,
"eventListeners": 182,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.11176470588235,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3186.1840000000257,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.670999999999999,
"layouts": 5,
"layoutDurationMs": 1.374,
"taskDurationMs": 2099.698,
"heapDeltaBytes": -12051292,
"heapUsedBytes": 69711292,
"domNodes": 0,
"jsHeapTotalBytes": 6905856,
"scriptDurationMs": 1037.321,
"eventListeners": 182,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.020744680851063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3102.391999999952,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.515,
"layouts": 5,
"layoutDurationMs": 1.6460000000000004,
"taskDurationMs": 850.9570000000001,
"heapDeltaBytes": -7437096,
"heapUsedBytes": 71277472,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 374.629,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3117.9630000000316,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.738,
"layouts": 6,
"layoutDurationMs": 1.395,
"taskDurationMs": 883.271,
"heapDeltaBytes": -6438864,
"heapUsedBytes": 71795984,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 391.123,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.028000000002,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.272,
"layouts": 7,
"layoutDurationMs": 2.0849999999999995,
"taskDurationMs": 660.2040000000002,
"heapDeltaBytes": -15386784,
"heapUsedBytes": 61457212,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.394999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.7649999999603,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.098,
"layouts": 7,
"layoutDurationMs": 2.096,
"taskDurationMs": 692.326,
"heapDeltaBytes": -26526724,
"heapUsedBytes": 66481924,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 37.598,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2853.616000000045,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.562,
"layouts": 6,
"layoutDurationMs": 1.516,
"taskDurationMs": 675.649,
"heapDeltaBytes": 315168,
"heapUsedBytes": 76749412,
"domNodes": -252,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 204.282,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666081871345032,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2835.7870000000958,
"styleRecalcs": 24,
"styleRecalcDurationMs": 11.272,
"layouts": 5,
"layoutDurationMs": 1.6640000000000001,
"taskDurationMs": 676.3080000000001,
"heapDeltaBytes": -1264312,
"heapUsedBytes": 75439792,
"domNodes": -253,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 197.805,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3385.764999999992,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7670000000000003,
"layouts": 6,
"layoutDurationMs": 1.673,
"taskDurationMs": 1071.481,
"heapDeltaBytes": 8667104,
"heapUsedBytes": 85848812,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 416.587,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3418.33900000006,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3769999999999998,
"layouts": 5,
"layoutDurationMs": 1.42,
"taskDurationMs": 1060.3780000000002,
"heapDeltaBytes": 1964652,
"heapUsedBytes": 78295204,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 420.45200000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.830049261083747,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.697000000022,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.517,
"layouts": 9,
"layoutDurationMs": 2.6759999999999997,
"taskDurationMs": 452.932,
"heapDeltaBytes": -897304,
"heapUsedBytes": 60270480,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 147.385,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 680.7199999999511,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.646,
"layouts": 8,
"layoutDurationMs": 2.529,
"taskDurationMs": 463.5130000000001,
"heapDeltaBytes": 953044,
"heapUsedBytes": 62865596,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 153.029,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2047.3719999999958,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2129999999999996,
"layouts": 9,
"layoutDurationMs": 2.862,
"taskDurationMs": 606.063,
"heapDeltaBytes": -11278608,
"heapUsedBytes": 50544228,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 11.309999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.1289999999399,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.640000000000001,
"layouts": 8,
"layoutDurationMs": 2.994,
"taskDurationMs": 577.665,
"heapDeltaBytes": 2062448,
"heapUsedBytes": 64182840,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.296000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.366999999986,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.944999999999999,
"layouts": 10,
"layoutDurationMs": 2.837,
"taskDurationMs": 875.469,
"heapDeltaBytes": 19365804,
"heapUsedBytes": 80792564,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 109.79399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1754.2489999999589,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.44,
"layouts": 9,
"layoutDurationMs": 2.6589999999999994,
"taskDurationMs": 927.283,
"heapDeltaBytes": -5734664,
"heapUsedBytes": 65766896,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 114.33600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.782000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.923000000000005,
"layouts": 5,
"layoutDurationMs": 14.115999999999996,
"taskDurationMs": 1091.0140000000001,
"heapDeltaBytes": 11633824,
"heapUsedBytes": 104727572,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 34.59,
"eventListeners": 3246,
"totalBlockingTimeMs": 152,
"frameDurationMs": 19.26233766233766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8708.530999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.580000000000002,
"layouts": 8,
"layoutDurationMs": 2.199,
"taskDurationMs": 6334.481000000001,
"heapDeltaBytes": -1519800,
"heapUsedBytes": 72696456,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2851.7549999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698080614203455,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9213.644999999928,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.667,
"layouts": 8,
"layoutDurationMs": 2.49,
"taskDurationMs": 6481.214000000001,
"heapDeltaBytes": -3440056,
"heapUsedBytes": 75415256,
"domNodes": -257,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 2910.0200000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696370235934666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 21017.992999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20651.101000000002,
"heapDeltaBytes": -18912160,
"heapUsedBytes": 263627492,
"domNodes": -3343,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 324.56199999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.24990892531876,
"p95FrameDurationMs": 83.20000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 21064.832000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20749.743000000002,
"heapDeltaBytes": -32994188,
"heapUsedBytes": 249052500,
"domNodes": -3343,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 319.805,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.74698113207547,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 26015.511999999944,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.434999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25782.198,
"heapDeltaBytes": -13225560,
"heapUsedBytes": 277543376,
"domNodes": -3343,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 935.7650000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 48.718352059925095,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 26118.72900000003,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.960000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25907.808,
"heapDeltaBytes": -22967852,
"heapUsedBytes": 253539596,
"domNodes": -3343,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 926.577,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 50.546228239845256,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7578.323999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.88999999999999,
"layouts": 20,
"layoutDurationMs": 25.502999999999997,
"taskDurationMs": 7529.3859999999995,
"heapDeltaBytes": -276596,
"heapUsedBytes": 276842956,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 118.552,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.236,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7858.167999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.893,
"layouts": 20,
"layoutDurationMs": 32.275999999999996,
"taskDurationMs": 7781.616000000001,
"heapDeltaBytes": -15485540,
"heapUsedBytes": 281004592,
"domNodes": -3343,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 123.096,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.35185185185186,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10693.850999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10477.305,
"heapDeltaBytes": -20417488,
"heapUsedBytes": 248993052,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.648,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.86015625,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10434.97100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10312.24,
"heapDeltaBytes": -149540,
"heapUsedBytes": 276946164,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.75,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.621033210332115,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "workflow-execution",
"durationMs": 475.43099999995775,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.566999999999998,
"layouts": 12,
"layoutDurationMs": 4.568,
"taskDurationMs": 135.54,
"heapDeltaBytes": 6986680,
"heapUsedBytes": 66245348,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.594,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66206896551725,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 134.60700000007364,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.073000000000002,
"layouts": 9,
"layoutDurationMs": 3.5820000000000003,
"taskDurationMs": 95.104,
"heapDeltaBytes": -12762964,
"heapUsedBytes": 63493744,
"domNodes": 125,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.566999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 528.4659999999803,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.674,
"layouts": 76,
"layoutDurationMs": 16.349,
"taskDurationMs": 488.112,
"heapDeltaBytes": -4297632,
"heapUsedBytes": 40432016,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 224.18099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 500.0039999999899,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6859999999999999,
"layouts": 76,
"layoutDurationMs": 18.061,
"taskDurationMs": 452.411,
"heapDeltaBytes": -4927992,
"heapUsedBytes": 39300500,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 199.14100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 736.3800000000538,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.246,
"layouts": 76,
"layoutDurationMs": 19.122,
"taskDurationMs": 691.033,
"heapDeltaBytes": 1487364,
"heapUsedBytes": 92391852,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 280.87899999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 732.7779999999393,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.2790000000000004,
"layouts": 76,
"layoutDurationMs": 19.375,
"taskDurationMs": 687.2819999999999,
"heapDeltaBytes": 2998260,
"heapUsedBytes": 96708864,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 278.639,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3123 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9e7a98b24e59acb65bb25392d7240bc611da0c7d
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (224)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.59 #22343 +/- ##
============================================
Coverage 87.12% 87.13%
============================================
Files 3027 3027
Lines 158688 158712 +24
Branches 40177 42343 +2166
============================================
+ Hits 138257 138290 +33
+ Misses 19755 19746 -9
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #21981 (IR-153) to
core/1.59. Clean cherry-pick. #21981 was merged after the 1.59 cut and never carried 1.59 labels, so the bot didn't try it. 1.58 backports: #22338 (cloud), #22339 (core).Why on 1.59
Keeps
core/1.59in step withcloud/1.59. The retry loop only runs on the cloud bundle; local and desktop keep the single read.Checks
refreshRemoteConfig.test.ts: 30/30 passedpnpm typecheckpassed🤖 Generated with Claude Code