Repository navigation
fix(agent): carry the canvas on a continuing turn from a still-unbound tab (PM-1410) - #22310
Conversation
A continuing turn on a selected tab that never adopted the session's bound workflow posted neither its canvas nor current_tab_unbound, so the server fell back to the thread's remembered workflow and the agent answered from a stale graph: a link the user severed was still reported as connected. Re-assert current_tab_unbound, with the tab's draft, whenever the selected tab has no cloud id and the bound workflow is not bound to that tab. The server then mints a workflow seeded from the tab's canvas, which adoption binds. Without a draft the flag is not re-asserted, so no empty mint. Flips the PM-1410 expected-failure pins (unit h12, black-box agentUnboundTabLinkSeverance) to plain passing tests and removes them from the expected-failure baseline.
Review follow-up. Re-asserting current_tab_unbound whenever the bound workflow was not bound to the selected tab also fired after a rename of a bound unsaved tab (the binding keeps the old path) and on a resumed thread whose workflow is open nowhere, minting needlessly in both. Narrow the rule to the PM-1410 shape: the selected tab has no cloud id and the session's bound workflow is open in another tab (it appears in the turn's open_tabs). Adds coverage for the mint -> adopt -> named cycle, the no-draft guard, and the bound-workflow-open-nowhere fallback, and removes the comments the repo rules forbid.
📦 Bundle: 12 MB gzip 🔴 +78 BDetailsSummary
Category Glance App Entry Points — 6.68 kB (baseline 6.68 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.59 MB (baseline 2.59 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 873 kB (baseline 873 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 33 unchanged User & Accounts — 159 kB (baseline 159 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 18 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 17 unchanged UI Components — 359 kB (baseline 359 kB) • ⚪ 0 BReusable component library chunks Status: 31 unchanged Data & Services — 1.91 MB (baseline 1.91 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 41 unchanged Utilities & Hooks — 2.43 MB (baseline 2.43 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 84 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • 🔴 +261 BBundles that do not match a named category
Status: 2 added / 2 removed / 745 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T23:42:09.677Z",
"gitSha": "4c0136301eefd0168aa7c5d47bbd6139b0126bc3",
"branch": "pm-1410-unbound-tab-continuing-turn",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.7850000000458,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.272,
"layouts": 10,
"layoutDurationMs": 2.1729999999999996,
"taskDurationMs": 414.53399999999993,
"heapDeltaBytes": 1505804,
"heapUsedBytes": 62871704,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7.6309999999999985,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2027.4509999999282,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7249999999999996,
"layouts": 7,
"layoutDurationMs": 1.468,
"taskDurationMs": 414.067,
"heapDeltaBytes": 1640360,
"heapUsedBytes": 64323944,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.9860000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.243999999997,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.544999999999998,
"layouts": 9,
"layoutDurationMs": 1.882,
"taskDurationMs": 686.8160000000001,
"heapDeltaBytes": -2015348,
"heapUsedBytes": 60207252,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 113.88999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.7550000000783,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.340999999999998,
"layouts": 9,
"layoutDurationMs": 3.6590000000000003,
"taskDurationMs": 750.493,
"heapDeltaBytes": 21847148,
"heapUsedBytes": 82937528,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 123.107,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.8990000000267,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.965,
"layouts": 11,
"layoutDurationMs": 2.2430000000000003,
"taskDurationMs": 312.81899999999996,
"heapDeltaBytes": 24565532,
"heapUsedBytes": 85549088,
"domNodes": 57,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.084999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.7349999999806,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.678000000000001,
"layouts": 12,
"layoutDurationMs": 2.8569999999999993,
"taskDurationMs": 338.578,
"heapDeltaBytes": -1275708,
"heapUsedBytes": 67982044,
"domNodes": 57,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 10.725,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 583.992999999964,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.361,
"layouts": 9,
"layoutDurationMs": 2.155,
"taskDurationMs": 402.416,
"heapDeltaBytes": 3384732,
"heapUsedBytes": 64939564,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 135.409,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 559.8939999999857,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.3669999999999995,
"layouts": 9,
"layoutDurationMs": 2.053,
"taskDurationMs": 391.787,
"heapDeltaBytes": 5734440,
"heapUsedBytes": 66595260,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 135.209,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1070.775000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.2680000000001,
"heapDeltaBytes": -12945596,
"heapUsedBytes": 75899584,
"domNodes": -203,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 50.175,
"eventListeners": -106,
"totalBlockingTimeMs": 390,
"frameDurationMs": 29.627777777777776,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1037.4469999999292,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.7650000000001,
"heapDeltaBytes": -13781348,
"heapUsedBytes": 75658704,
"domNodes": -203,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 46.504000000000005,
"eventListeners": -106,
"totalBlockingTimeMs": 357,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 832.5760000000173,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.0739999999997,
"heapDeltaBytes": -3346976,
"heapUsedBytes": 70805908,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.03299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 187,
"frameDurationMs": 23.808571428571433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 799.056999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.5140000000001,
"heapDeltaBytes": -5069380,
"heapUsedBytes": 70216548,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.396,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 23.526470588235284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7541.643000000022,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6769999999999996,
"layouts": 3,
"layoutDurationMs": 0.556,
"taskDurationMs": 6750.101,
"heapDeltaBytes": 55219584,
"heapUsedBytes": 134766404,
"domNodes": -269,
"jsHeapTotalBytes": 56225792,
"scriptDurationMs": 5185.632,
"eventListeners": -68,
"totalBlockingTimeMs": 46,
"frameDurationMs": 23.914603174603172,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8219.456999999977,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2180000000000003,
"layouts": 1,
"layoutDurationMs": 0.1820000000000003,
"taskDurationMs": 7425.871999999999,
"heapDeltaBytes": 61274600,
"heapUsedBytes": 141268700,
"domNodes": -269,
"jsHeapTotalBytes": 73003008,
"scriptDurationMs": 5932.878000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 135,
"frameDurationMs": 24.897878787878785,
"p95FrameDurationMs": 49.900000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7498.222999999996,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5009999999999997,
"layouts": 2,
"layoutDurationMs": 0.4239999999999999,
"taskDurationMs": 6690.788,
"heapDeltaBytes": 44146144,
"heapUsedBytes": 137875752,
"domNodes": -269,
"jsHeapTotalBytes": 60944384,
"scriptDurationMs": 5162.96,
"eventListeners": -68,
"totalBlockingTimeMs": 55,
"frameDurationMs": 24.270873786407762,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7910.863000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7969999999999999,
"layouts": 3,
"layoutDurationMs": 0.6820000000000003,
"taskDurationMs": 7071.592,
"heapDeltaBytes": 68102780,
"heapUsedBytes": 147115348,
"domNodes": -269,
"jsHeapTotalBytes": 61206528,
"scriptDurationMs": 5489.606,
"eventListeners": -68,
"totalBlockingTimeMs": 53,
"frameDurationMs": 24.158103975535166,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 164.87200000000257,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.409999999999998,
"layouts": 10,
"layoutDurationMs": 2.189,
"taskDurationMs": 125.55000000000003,
"heapDeltaBytes": 14701176,
"heapUsedBytes": 74508044,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.015000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.799999999999986,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-combo-open",
"durationMs": 221.2069999999926,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.377,
"layouts": 11,
"layoutDurationMs": 2.6470000000000002,
"taskDurationMs": 171.213,
"heapDeltaBytes": -8052244,
"heapUsedBytes": 75140992,
"domNodes": 936,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.382,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-graph-idle",
"durationMs": 2041.3279999999645,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2820000000000003,
"layouts": 5,
"layoutDurationMs": 1.1149999999999998,
"taskDurationMs": 469.4830000000001,
"heapDeltaBytes": 10936676,
"heapUsedBytes": 71496312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.385999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2013.4980000000269,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3379999999999999,
"layouts": 5,
"layoutDurationMs": 1.264,
"taskDurationMs": 464.612,
"heapDeltaBytes": 10939464,
"heapUsedBytes": 71115192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.892999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2282.5579999999945,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.67,
"layouts": 8,
"layoutDurationMs": 1.5649999999999997,
"taskDurationMs": 1354.643,
"heapDeltaBytes": -25640952,
"heapUsedBytes": 61361372,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 668.7379999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665693430656933,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2288.9719999999443,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.818,
"layouts": 8,
"layoutDurationMs": 1.891,
"taskDurationMs": 1416.841,
"heapDeltaBytes": -13299984,
"heapUsedBytes": 77623856,
"domNodes": -269,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 665.3030000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666423357664236,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3240.3039999999805,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.28,
"layouts": 66,
"layoutDurationMs": 9.694,
"taskDurationMs": 1462.653,
"heapDeltaBytes": -20743700,
"heapUsedBytes": 69290644,
"domNodes": -245,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 641.82,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665463917525773,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3452.953000000093,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.099,
"layouts": 65,
"layoutDurationMs": 10.482,
"taskDurationMs": 1498.926,
"heapDeltaBytes": -20360844,
"heapUsedBytes": 73638404,
"domNodes": 24,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 672.57,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665700483091786,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2268.556999999987,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.031,
"layouts": 7,
"layoutDurationMs": 1.4130000000000003,
"taskDurationMs": 1571.2869999999998,
"heapDeltaBytes": -17555376,
"heapUsedBytes": 74113936,
"domNodes": 0,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 791.779,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.789629629629633,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2489.422000000104,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.346,
"layouts": 7,
"layoutDurationMs": 1.624,
"taskDurationMs": 1630.291,
"heapDeltaBytes": 7299724,
"heapUsedBytes": 80594100,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 813.797,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779054054054054,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2923.8900000000285,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.541,
"layouts": 7,
"layoutDurationMs": 1.3070000000000002,
"taskDurationMs": 637.071,
"heapDeltaBytes": -16283064,
"heapUsedBytes": 59174364,
"domNodes": -269,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 291.67299999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2905.3989999999885,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.914,
"layouts": 8,
"layoutDurationMs": 1.6319999999999997,
"taskDurationMs": 633.6809999999999,
"heapDeltaBytes": -9994632,
"heapUsedBytes": 79299624,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 288.36699999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2017.915999999957,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5199999999999996,
"layouts": 7,
"layoutDurationMs": 1.436,
"taskDurationMs": 494.80199999999996,
"heapDeltaBytes": -13356396,
"heapUsedBytes": 62074132,
"domNodes": -269,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 27.604999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.6050000000087,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9329999999999998,
"layouts": 9,
"layoutDurationMs": 1.868,
"taskDurationMs": 505.02000000000004,
"heapDeltaBytes": -3590420,
"heapUsedBytes": 85210508,
"domNodes": -269,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 27.253,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6672131147541,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2758.57400000001,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.662,
"layouts": 8,
"layoutDurationMs": 1.543,
"taskDurationMs": 500.4240000000001,
"heapDeltaBytes": -7276912,
"heapUsedBytes": 84928256,
"domNodes": -262,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 165.456,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240963,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2690.4269999999997,
"styleRecalcs": 27,
"styleRecalcDurationMs": 9.968000000000002,
"layouts": 7,
"layoutDurationMs": 1.3490000000000002,
"taskDurationMs": 506.46800000000013,
"heapDeltaBytes": -11047376,
"heapUsedBytes": 66208900,
"domNodes": -254,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 151.96300000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.769565217391303,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3101.3869999999883,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9969999999999997,
"layouts": 8,
"layoutDurationMs": 1.752,
"taskDurationMs": 806.644,
"heapDeltaBytes": -23042228,
"heapUsedBytes": 66562184,
"domNodes": -269,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 294.976,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665591397849465,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3055.1550000000134,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.804,
"layouts": 8,
"layoutDurationMs": 1.5980000000000003,
"taskDurationMs": 772.0369999999999,
"heapDeltaBytes": -15626920,
"heapUsedBytes": 73979884,
"domNodes": -269,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 295.443,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.8679999999786,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.302,
"layouts": 10,
"layoutDurationMs": 2.062,
"taskDurationMs": 345.50000000000006,
"heapDeltaBytes": 2429784,
"heapUsedBytes": 72687436,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 116.45,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66774193548388,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.5300000000561,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.653,
"layouts": 9,
"layoutDurationMs": 2.1510000000000002,
"taskDurationMs": 359.69399999999996,
"heapDeltaBytes": 232368,
"heapUsedBytes": 62451052,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 117.925,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.020000000021,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.516,
"layouts": 11,
"layoutDurationMs": 2.3030000000000004,
"taskDurationMs": 455.426,
"heapDeltaBytes": -1320864,
"heapUsedBytes": 70700308,
"domNodes": -195,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 7.594,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2027.0759999999655,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.109,
"layouts": 11,
"layoutDurationMs": 2.196,
"taskDurationMs": 466.06499999999994,
"heapDeltaBytes": 4488412,
"heapUsedBytes": 75555284,
"domNodes": -195,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 7.265999999999998,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.2509999999888,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.142,
"layouts": 10,
"layoutDurationMs": 2.2880000000000003,
"taskDurationMs": 658.722,
"heapDeltaBytes": 17570416,
"heapUsedBytes": 79666080,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 84.83399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.8410000000813,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.909,
"layouts": 9,
"layoutDurationMs": 1.731,
"taskDurationMs": 673.311,
"heapDeltaBytes": 18026948,
"heapUsedBytes": 80488936,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 84.934,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1319.9920000000134,
"styleRecalcs": 18,
"styleRecalcDurationMs": 16.46,
"layouts": 5,
"layoutDurationMs": 10.339999999999998,
"taskDurationMs": 889.4719999999999,
"heapDeltaBytes": 14060256,
"heapUsedBytes": 117474052,
"domNodes": 16029,
"jsHeapTotalBytes": 10358784,
"scriptDurationMs": 24.645,
"eventListeners": 3246,
"totalBlockingTimeMs": 99,
"frameDurationMs": 19.04714285714286,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8795.880000000012,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.424,
"layouts": 9,
"layoutDurationMs": 1.9209999999999998,
"taskDurationMs": 5075.227,
"heapDeltaBytes": -5541632,
"heapUsedBytes": 88161024,
"domNodes": -269,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 2419.3819999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909093,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8526.466000000028,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.645,
"layouts": 9,
"layoutDurationMs": 2.0020000000000002,
"taskDurationMs": 4732.847,
"heapDeltaBytes": -15967772,
"heapUsedBytes": 73150616,
"domNodes": -269,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 2200.643,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6658203125,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19656.474000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19032.227999999996,
"heapDeltaBytes": -19737260,
"heapUsedBytes": 263313804,
"domNodes": -3343,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 250.272,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.80939716312056,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20012.13199999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19479.443,
"heapDeltaBytes": -20581920,
"heapUsedBytes": 253135548,
"domNodes": -3347,
"jsHeapTotalBytes": 11526144,
"scriptDurationMs": 264.255,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.56160877513712,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 23945.785,
"styleRecalcs": 179,
"styleRecalcDurationMs": 19.537,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23623.262,
"heapDeltaBytes": -13446016,
"heapUsedBytes": 278723272,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 771.4839999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 46.535339805825245,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 23767.763000000057,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.41000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23518.453999999998,
"heapDeltaBytes": -22806428,
"heapUsedBytes": 279611920,
"domNodes": -3343,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 731.206,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.7237721021611,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7096.674000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.80400000000002,
"layouts": 20,
"layoutDurationMs": 27.196000000000012,
"taskDurationMs": 6997.304000000001,
"heapDeltaBytes": -20871328,
"heapUsedBytes": 276212988,
"domNodes": -307,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 162.452,
"eventListeners": -7,
"totalBlockingTimeMs": 85,
"frameDurationMs": 42.769277108433734,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7145.171000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.00199999999999,
"layouts": 20,
"layoutDurationMs": 21.069000000000003,
"taskDurationMs": 7060.204000000001,
"heapDeltaBytes": -24042064,
"heapUsedBytes": 259088680,
"domNodes": -3343,
"jsHeapTotalBytes": 19128320,
"scriptDurationMs": 104.21799999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.713173652694614,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9882.716000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9515.745,
"heapDeltaBytes": 4742832,
"heapUsedBytes": 283221388,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.44800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.67870036101083,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9961.843999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9568.58,
"heapDeltaBytes": -24993764,
"heapUsedBytes": 256287528,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.341134751773055,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 91.45300000000134,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.667999999999999,
"layouts": 6,
"layoutDurationMs": 1.5510000000000002,
"taskDurationMs": 66.21300000000001,
"heapDeltaBytes": 4751864,
"heapUsedBytes": 66676600,
"domNodes": 101,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.3420000000000005,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 96.66599999991377,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.765,
"layouts": 6,
"layoutDurationMs": 2.4000000000000004,
"taskDurationMs": 71.65700000000001,
"heapDeltaBytes": -13161108,
"heapUsedBytes": 63388448,
"domNodes": 125,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 4.417000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 289.9330000000191,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5599999999999999,
"layouts": 76,
"layoutDurationMs": 11.658,
"taskDurationMs": 252.377,
"heapDeltaBytes": 10519020,
"heapUsedBytes": 48788812,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 120.736,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 311.54400000002624,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.592,
"layouts": 76,
"layoutDurationMs": 11.709999999999999,
"taskDurationMs": 273.91200000000003,
"heapDeltaBytes": 10748516,
"heapUsedBytes": 51416764,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 123.988,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 324.1170000000011,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.804,
"layouts": 76,
"layoutDurationMs": 11.635,
"taskDurationMs": 293.30899999999997,
"heapDeltaBytes": -1994408,
"heapUsedBytes": 88928980,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 99.18299999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 326.29099999996924,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.467,
"layouts": 76,
"layoutDurationMs": 11.145,
"taskDurationMs": 284.39300000000003,
"heapDeltaBytes": -1823332,
"heapUsedBytes": 92114880,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 102.74,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736862,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageLine coverage: 60.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3168 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since dd86baf75d6031ef8806aa018e36d712de0af073
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (289)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
Panel: 6/6 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22310 +/- ##
==========================================
- Coverage 87.51% 87.42% -0.10%
==========================================
Files 2938 2832 -106
Lines 159350 156165 -3185
Branches 41706 40627 -1079
==========================================
- Hits 139455 136520 -2935
+ Misses 18973 18889 -84
+ Partials 922 756 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 141 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Merging at approved head. Green, 6 behind main, no file overlap. Full context for agent readersExact head Gate: this head is 6 commits behind |
|
@christian-byrne Successfully backported to #22318 |
|
@christian-byrne Successfully backported to #22319 |
|
|
…omfy-Org#22320) "Backport did not run" warning never posts. Fixed token. - Warn job got HTTP 403 with the default token - Now uses the same token as the backport job - Test pins it <details><summary>Full context for agent readers</summary> `warn-missing-needs-backport` (added in Comfy-Org#21357) posts with `github.token`. On this repo that call is refused: `gh: Resource not accessible by integration (HTTP 403)`, then `::warning::Could not comment on PR`. The step only warns, so the job is green and the author never learns the release labels started nothing. Seen on Comfy-Org#22310 (run 40976467378). Repo-wide, the marker comment exists on only two PRs. The `backport` job in the same workflow already documents the same limitation of the auto-provided token and uses `secrets.PR_GH_TOKEN || secrets.GH_TOKEN`. This switches the warn step to that token. New test in `scripts/cicd/backport-missing-trigger.test.ts` asserts the warn step's `GH_TOKEN` equals the backport job's (red before, green after; 13/13). </details>
…n from a still-unbound tab (PM-1410) (#22321) Backport of #22310 to `core/1.58`. Manual: auto-backport conflicted. <details><summary>Full context for agent readers</summary> `core/1.58` lacks the PM-1410 pins from #21931 (`browser_tests/tests/agent/agentUnboundTabLinkSeverance.spec.ts`, its `tools/expected-failures/baseline.json` entries, and unit `(h11)`/`(h12)`), so those parts are dropped. The source change in `useAgentSession.ts` and the new unit cases `(h10)`-`(h10d)` and `(h11)` apply as on main. `useAgentSession.test.ts`: 271/271 locally on this branch. </details>
…rn from a still-unbound tab (PM-1410) (#22322) Backport of #22310 to `cloud/1.58`. Manual: auto-backport conflicted. <details><summary>Full context for agent readers</summary> `cloud/1.58` lacks the PM-1410 pins from #21931 (`browser_tests/tests/agent/agentUnboundTabLinkSeverance.spec.ts`, its `tools/expected-failures/baseline.json` entries, and unit `(h11)`/`(h12)`), so those parts are dropped. The source change in `useAgentSession.ts` and the new unit cases `(h10)`-`(h10d)` and `(h11)` apply as on main. `useAgentSession.test.ts`: 271/271 locally on this branch. </details>
…#22454) ## Summary Ratchet ceiling drifted on `main` (`9f2fcad1`). 11 live defects, ceiling 13. Ceiling 13 → 11. <details><summary>Full context for agent readers</summary> `pnpm test:expected-failure-ratchet` on `main` reports `Live-defect count 11 must equal LIVE_DEFECT_CEILING (13)`. The step is informational, so CI stays green, but the log shows drift. - Comfy-Org#22310 (PM-1410) fixed the two unbound-tab pins and dropped both baseline entries, but left `LIVE_DEFECT_CEILING` at 14. - Comfy-Org#22125 then fixed the gesture pin and lowered the ceiling 14 → 13. - Net: 14 − 2 − 1 = 11. Baseline entries are already correct; only the ceiling and the inventory count fixtures change. Part of Comfy-Org#19707. ## Verification - `pnpm test:expected-failure-ratchet` on this branch: `Expected-failure baseline matches: 11 live defects, 8 infrastructure assertions.` - `tools/expected-failures/src/inventory.test.ts`: 16/16 pass. - Pre-commit oxfmt, oxlint, `typecheck:tools`; pre-push fallow: pass. </details>
…and stop it warning twice (Comfy-Org#22476) Merged PRs fail `PR Backport` when the shared bot token runs out of quota, even when no warning is needed. Fixed, along with a duplicate-warning bug. - Reads use the job token, so the shared token's limit can't fail a merge - Only the comment uses the shared token (the job token gets HTTP 403 on POST here, see Comfy-Org#22320) - The "already warned" check now accepts comfy-pr-bot, which has posted the comment since Comfy-Org#22320 - Tests model both tokens: red before (4 failed), green after (17/17) Fixes https://linear.app/comfyorg/issue/FRONT-3753 <details><summary>Full context for agent readers</summary> Since Comfy-Org#22377 merged, 11 of the 16 failed `PR Backport` runs failed in this job with `API rate limit exceeded for user ID 172744619` (comfy-pr-bot), for example https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/41181000307. No warning was lost: every affected PR had no release label, or already had needs-backport. Dedupe: the test fake posted as `github-actions[bot]`, which hid the mismatch. It now posts as `comfy-pr-bot`, with tokens resolved from the workflow env. The job-token reads are the same ones that ran before Comfy-Org#22320 (they reached the POST on Comfy-Org#22310 before it was refused). The job's `permissions:` already cover them. No backport: the workflow runs from main. </details> --------- Co-authored-by: GitHub Action <action@github.com>
…orkflow is not its own (PM-2401) (#22518) The agent could still read an old graph on an unsaved tab in three rarer cases. Fixed. - Chat's workflow tab closed: the canvas is now sent, not the old workflow - No canvas available: the send is held and the message stays in the composer - Reply with no adoptable workflow: the tab no longer mints a new one each turn - Blank tab after the chat's tab closed: stays on the chat's workflow Linear: https://linear.app/comfyorg/issue/PM-2401 <details><summary>Full context for agent readers</summary> ## Summary Follow-up to #22310, which re-sent the canvas only when the session's bound workflow was still open in another tab. These are the three edges cursor-review raised on that PR. ## Changes - **What**: `isUnboundTarget` no longer needs the bound workflow to appear in `open_tabs` when the tab has content. A selected tab with no cloud id has no workflow of its own, so with a draft holding nodes or groups the turn carries `current_tab_unbound` and the draft. A blank tab whose bound workflow is open nowhere keeps today's thread fallback: minting would replace a built thread workflow with an empty one. A blank tab whose bound workflow is open elsewhere still re-flags, as #22310 does. - **Mint memo**: `unadoptedMintBinding` records, per tab path, the binding at the reply to a mint the tab did not adopt. Such a tab does not re-flag while the binding is unchanged, so there is no one-workflow-per-turn loop. An id with a tab binding is not recorded: an adopted mint shows in the binding, and temp-tab paths are reused after close. Cleared with the binding by `newChat`, `loadThread` and a deleted thread. The memo lives with the session: after a panel remount an unadopted mint can re-mint once. - **Hold**: a continuing turn from such a tab with no canvas is refused with the existing `agent.targetNavigationUnavailable` failure instead of silently retargeting. `current_tab_unbound` without a draft would mint an empty workflow, so sending is not an option. `performSend` returns false, so the composer keeps the text. - `postTurn` now takes the built input so `performSend` can read whether the turn was flagged. - **Tests**: red on `main`, green here: `(h10b)` hold, `(h10e)` closed tab re-flags, `(h10f)` reply without an id does not re-flag. Added after adversarial review, red before the second commit: `(h10e2)` blank tab keeps the thread workflow, `(h10e3)` reused path of a closed adopted tab mints for itself. Guards: `(h10d)` unadopted mint not re-minted, `(h10g)` new chat clears the memo. ## Review Focus - Accepted cost, per the ticket: renaming a bound unsaved tab loses its binding, so the next turn mints a copy of that tab's canvas and leaves the old draft workflow orphaned. - Held sends apply only when the host provides a canvas reader. They reuse the existing "target no longer available" text to keep this PR inside the agent paths. `draft` is undefined only when the tab has no `activeState`. - Not changed: a flagged first turn (nothing bound) with no draft can still mint empty. Same as `main`. - After a reply with no id, later turns on that tab send neither flag nor draft. The server (`agent_handler.go`) always returns `workflow_id`, so this is a loop guard only. </details>
Agent reported a removed link as still connected. Fixed for the unsaved-tab case.
Linear: https://linear.app/comfyorg/issue/PM-1410
Full context for agent readers
Summary
On a continuing chat, a selected unsaved tab (no cloud id) whose session is bound to a workflow that another open tab holds sent neither its canvas (
draft) norcurrent_tab_unbound. The server fell back to the thread's remembered workflow, so the agent answered from a stale graph — the PM-1410 report: a link the user severed is still reported as connected.This is the live residual arm pinned by #21931 (unit
(h12), black-boxagentUnboundTabLinkSeverance.spec.ts).Changes
isUnboundTargetnow also returns true on a continuing turn when the selected tab has no cloud id, a draft is in hand, and the session's bound workflow is open in another tab (it appears in the turn'sopen_tabs). The turn then carriescurrent_tab_unboundplus the draft; the server mints a workflow seeded from this tab's canvas (agent_handler.go: the flag skips only the thread-workflow fallback;TestPostMessageUnboundCurrentTabMintsInsteadOfReusingTheThreadWorkflow), and adoption binds the mint to the tab, so the following turn names it.canSendDraftis not relaxed, so a canvas is never posted against a workflow id it does not belong to (risk register steer: do not always post an unidentified canvas; do not reopen document-wins).main, green here —(h10)re-flag with draft,(h10c)mint → adopt → next turn names the mint (no mint loop),(h11)the severed link reaches the agent. Guards green on both:(h10b)no draft → no flag,(h10d)bound workflow open nowhere → no flag. Black-box spec'stest.failmarker removed and it now assertscurrent_tab_unbound; both entries dropped fromtools/expected-failures/baseline.json.Review Focus
(g6)and(g18)in the same test file fail onmainlocally too; CI is green onmain.Verification:
vitest useAgentSession.test.ts(all PM-1410 cases),AgentPanelRoot.test.ts,pnpm typecheck,pnpm typecheck:browser,tools/expected-failurestests, oxlint/oxfmt. Black-box spec relies on CI.