Repository navigation
[backport cloud/1.58] fix(agent): carry the canvas on a continuing turn from a still-unbound tab (PM-1410) - #22322
Conversation
…d tab (PM-1410) (#22310) Agent reported a removed link as still connected. Fixed for the unsaved-tab case. - Unsaved tab + continuing chat: canvas now reaches the agent - Server already supports it; frontend-only - Two expected-failure pins flip to passing Linear: https://linear.app/comfyorg/issue/PM-1410 <details><summary>Full context for agent readers</summary> On a continuing chat, a selected unsaved tab (no cloud id) whose session is bound to a workflow that another open tab holds sent neither its canvas (`draft`) nor `current_tab_unbound`. The server fell back to the thread's remembered workflow, so the agent answered from a stale graph — the PM-1410 report: a link the user severed is still reported as connected. This is the live residual arm pinned by #21931 (unit `(h12)`, black-box `agentUnboundTabLinkSeverance.spec.ts`). - **What**: `isUnboundTarget` now also returns true on a continuing turn when the selected tab has no cloud id, a draft is in hand, and the session's bound workflow is open in another tab (it appears in the turn's `open_tabs`). The turn then carries `current_tab_unbound` plus the draft; the server mints a workflow seeded from this tab's canvas (`agent_handler.go`: the flag skips only the thread-workflow fallback; `TestPostMessageUnboundCurrentTabMintsInsteadOfReusingTheThreadWorkflow`), and adoption binds the mint to the tab, so the following turn names it. - **Unchanged on purpose**: no re-flag without a draft (would mint an empty workflow); no re-flag when the bound workflow is open in no tab (resumed thread, or a bound unsaved tab renamed, whose binding keeps the old path) — those keep today's thread fallback. `canSendDraft` is not relaxed, so a canvas is never posted against a workflow id it does not belong to (risk register steer: do not always post an unidentified canvas; do not reopen document-wins). - **Tests**: red on `main`, green here — `(h10)` re-flag with draft, `(h10c)` mint → adopt → next turn names the mint (no mint loop), `(h11)` the severed link reaches the agent. Guards green on both: `(h10b)` no draft → no flag, `(h10d)` bound workflow open nowhere → no flag. Black-box spec's `test.fail` marker removed and it now asserts `current_tab_unbound`; both entries dropped from `tools/expected-failures/baseline.json`. - Product call (made under the takeover's delegated authority): when a selected unsaved tab is the panel's target, the agent works on that tab, not on another tab's workflow the thread remembers. Accepted consequence: picking a blank unsaved tab as target on a continuing chat mints a fresh workflow for it (same as a first turn does today). - Pre-existing, unrelated local timing flakes seen under host load: `(g6)` and `(g18)` in the same test file fail on `main` locally too; CI is green on `main`. - Adversarial review (fresh Claude reviewer; cross-model reviewer unavailable on this host): findings on rename and resumed-thread over-minting, missing mint-loop test, and comment rules were all addressed in the second commit. Verification: `vitest useAgentSession.test.ts` (all PM-1410 cases), `AgentPanelRoot.test.ts`, `pnpm typecheck`, `pnpm typecheck:browser`, `tools/expected-failures` tests, oxlint/oxfmt. Black-box spec relies on CI. </details> (cherry picked from commit 4a737bd)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T00:39:03.936Z",
"gitSha": "0cd1b75fb361294ea07a8fe2c1d7c2929aabe4a5",
"branch": "backport-22310-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.885999999985,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.582,
"layouts": 9,
"layoutDurationMs": 2.5799999999999996,
"taskDurationMs": 516.9110000000001,
"heapDeltaBytes": -843660,
"heapUsedBytes": 89738460,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 8.438999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.818000000053,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.109000000000001,
"layouts": 10,
"layoutDurationMs": 3.079,
"taskDurationMs": 540.566,
"heapDeltaBytes": -850100,
"heapUsedBytes": 89792804,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 10.391000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.6159999999886,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.715,
"layouts": 10,
"layoutDurationMs": 2.722,
"taskDurationMs": 776.16,
"heapDeltaBytes": 2074484,
"heapUsedBytes": 89978264,
"domNodes": -200,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 161.73900000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1976.7120000000205,
"styleRecalcs": 82,
"styleRecalcDurationMs": 15.476999999999999,
"layouts": 9,
"layoutDurationMs": 2.953,
"taskDurationMs": 957.466,
"heapDeltaBytes": 18827796,
"heapUsedBytes": 110191372,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 165.84099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66638655462185,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.1279999999747,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.1080000000000005,
"layouts": 11,
"layoutDurationMs": 2.7,
"taskDurationMs": 394.62999999999994,
"heapDeltaBytes": 21517808,
"heapUsedBytes": 109349360,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.966999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1787.4779999999646,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.390000000000001,
"layouts": 11,
"layoutDurationMs": 3.0709999999999997,
"taskDurationMs": 468.18699999999995,
"heapDeltaBytes": 21570872,
"heapUsedBytes": 111917620,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 12.759,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66542056074767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 690.3009999999767,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.5789999999999997,
"layouts": 7,
"layoutDurationMs": 2.0220000000000002,
"taskDurationMs": 496.655,
"heapDeltaBytes": 251472,
"heapUsedBytes": 88021500,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 166.89000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.082500000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 697.6169999999229,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.0750000000000006,
"layouts": 7,
"layoutDurationMs": 1.8130000000000002,
"taskDurationMs": 508.393,
"heapDeltaBytes": 256032,
"heapUsedBytes": 89762428,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 172.655,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.520512820512824,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.349000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 922.686,
"heapDeltaBytes": -5126984,
"heapUsedBytes": 102827048,
"domNodes": -231,
"jsHeapTotalBytes": 9850880,
"scriptDurationMs": 71.955,
"eventListeners": -168,
"totalBlockingTimeMs": 524,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1216.3580000000138,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 872.1269999999998,
"heapDeltaBytes": -16485732,
"heapUsedBytes": 102155572,
"domNodes": -230,
"jsHeapTotalBytes": 14045184,
"scriptDurationMs": 77.03399999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 531,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.6549999999843,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.3449999999997,
"heapDeltaBytes": 24044572,
"heapUsedBytes": 115156772,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.949,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.0109999999522,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.9270000000004,
"heapDeltaBytes": -3337464,
"heapUsedBytes": 94741460,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.044,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11583.562,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10679.974000000002,
"heapDeltaBytes": 49238080,
"heapUsedBytes": 170428468,
"domNodes": -276,
"jsHeapTotalBytes": 50135040,
"scriptDurationMs": 9031.117,
"eventListeners": -130,
"totalBlockingTimeMs": 1830,
"frameDurationMs": 33.819298245614036,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10234.499000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9405.66,
"heapDeltaBytes": 28306800,
"heapUsedBytes": 149655236,
"domNodes": -296,
"jsHeapTotalBytes": 39649280,
"scriptDurationMs": 7867.664,
"eventListeners": -130,
"totalBlockingTimeMs": 1208,
"frameDurationMs": 31.978125,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9269.59500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8414.481,
"heapDeltaBytes": 3054772,
"heapUsedBytes": 123568616,
"domNodes": -277,
"jsHeapTotalBytes": 27328512,
"scriptDurationMs": 6961.379,
"eventListeners": -130,
"totalBlockingTimeMs": 754,
"frameDurationMs": 32.063321799307964,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9648.793000000012,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.23100000000000032,
"layouts": 1,
"layoutDurationMs": 0.2069999999999997,
"taskDurationMs": 8875.978,
"heapDeltaBytes": 27809792,
"heapUsedBytes": 130456828,
"domNodes": -296,
"jsHeapTotalBytes": 30998528,
"scriptDurationMs": 7379.314,
"eventListeners": -130,
"totalBlockingTimeMs": 792,
"frameDurationMs": 32.27324414715719,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 259.39900000000193,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.184,
"layouts": 11,
"layoutDurationMs": 3.168,
"taskDurationMs": 212.99800000000002,
"heapDeltaBytes": 15456600,
"heapUsedBytes": 117971396,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 8.769,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 22.216666666666697,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 237.1779999999717,
"styleRecalcs": 26,
"styleRecalcDurationMs": 14.048,
"layouts": 12,
"layoutDurationMs": 3.266,
"taskDurationMs": 178.058,
"heapDeltaBytes": 15474324,
"heapUsedBytes": 118288396,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 8.398000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2025.588999999968,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3379999999999996,
"layouts": 8,
"layoutDurationMs": 2.3679999999999994,
"taskDurationMs": 482.3819999999999,
"heapDeltaBytes": 711620,
"heapUsedBytes": 102266840,
"domNodes": -296,
"jsHeapTotalBytes": -5177344,
"scriptDurationMs": 30.31500000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.4529999999568,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.242,
"layouts": 9,
"layoutDurationMs": 2.408,
"taskDurationMs": 668.508,
"heapDeltaBytes": 305584,
"heapUsedBytes": 107125632,
"domNodes": -297,
"jsHeapTotalBytes": -458752,
"scriptDurationMs": 34.62200000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2475.398000000041,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.302,
"layouts": 7,
"layoutDurationMs": 1.8659999999999999,
"taskDurationMs": 1679.4040000000002,
"heapDeltaBytes": 1859432,
"heapUsedBytes": 104373348,
"domNodes": -296,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 801.511,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665100671140937,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2210.144000000014,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.855,
"layouts": 6,
"layoutDurationMs": 1.5899999999999999,
"taskDurationMs": 1494.7719999999997,
"heapDeltaBytes": 1496456,
"heapUsedBytes": 108792216,
"domNodes": -296,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 810.402,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665151515151518,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3702.354000000014,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.017000000000001,
"layouts": 64,
"layoutDurationMs": 10.006999999999998,
"taskDurationMs": 1777.0479999999998,
"heapDeltaBytes": -11149344,
"heapUsedBytes": 97078900,
"domNodes": -272,
"jsHeapTotalBytes": -1298432,
"scriptDurationMs": 771.767,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66621621621622,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3669.948999999974,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.788,
"layouts": 64,
"layoutDurationMs": 9.921999999999999,
"taskDurationMs": 1767.8029999999999,
"heapDeltaBytes": -12520800,
"heapUsedBytes": 96722864,
"domNodes": -286,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 762.864,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2729.1870000000245,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.247000000000001,
"layouts": 5,
"layoutDurationMs": 1.1060000000000003,
"taskDurationMs": 1736.261,
"heapDeltaBytes": 14405164,
"heapUsedBytes": 125263600,
"domNodes": 0,
"jsHeapTotalBytes": 8286208,
"scriptDurationMs": 944.813,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.768098159509208,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2664.965999999936,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.262,
"layouts": 6,
"layoutDurationMs": 1.5239999999999998,
"taskDurationMs": 1730.108,
"heapDeltaBytes": -9095436,
"heapUsedBytes": 101579352,
"domNodes": 0,
"jsHeapTotalBytes": 6033408,
"scriptDurationMs": 952.576,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77151898734177,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2052.2419999999784,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6510000000000005,
"layouts": 6,
"layoutDurationMs": 1.6030000000000002,
"taskDurationMs": 669.6580000000001,
"heapDeltaBytes": 115176,
"heapUsedBytes": 102882740,
"domNodes": -296,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 31.632,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.29399999998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9380000000000004,
"layouts": 6,
"layoutDurationMs": 1.911,
"taskDurationMs": 716.6620000000001,
"heapDeltaBytes": -3558028,
"heapUsedBytes": 104531980,
"domNodes": -296,
"jsHeapTotalBytes": -1691648,
"scriptDurationMs": 33.632999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 656.44199999997,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.069000000000001,
"layouts": 10,
"layoutDurationMs": 2.3780000000000006,
"taskDurationMs": 467.60799999999995,
"heapDeltaBytes": 22503316,
"heapUsedBytes": 112520876,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 142.646,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.1839999999274,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.462,
"layouts": 9,
"layoutDurationMs": 2.0900000000000007,
"taskDurationMs": 425.196,
"heapDeltaBytes": 22474540,
"heapUsedBytes": 112392584,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 140.949,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2041.5270000000305,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4519999999999995,
"layouts": 10,
"layoutDurationMs": 3.3229999999999995,
"taskDurationMs": 467.6,
"heapDeltaBytes": 1092568,
"heapUsedBytes": 91121644,
"domNodes": -218,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 10.169,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2055.9559999999237,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.863,
"layouts": 10,
"layoutDurationMs": 2.8310000000000004,
"taskDurationMs": 586.256,
"heapDeltaBytes": -24212264,
"heapUsedBytes": 80328420,
"domNodes": -218,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 7.994999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1994.9869999999805,
"styleRecalcs": 86,
"styleRecalcDurationMs": 15.927999999999997,
"layouts": 10,
"layoutDurationMs": 2.5740000000000003,
"taskDurationMs": 955.309,
"heapDeltaBytes": -1385464,
"heapUsedBytes": 88455000,
"domNodes": -210,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 113.57999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.0049999999392,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.251000000000001,
"layouts": 8,
"layoutDurationMs": 2.4180000000000006,
"taskDurationMs": 722.79,
"heapDeltaBytes": -2251420,
"heapUsedBytes": 87275912,
"domNodes": -211,
"jsHeapTotalBytes": 327680,
"scriptDurationMs": 109.112,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.5659999999943,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.679,
"layouts": 5,
"layoutDurationMs": 16.025000000000002,
"taskDurationMs": 1039.6270000000002,
"heapDeltaBytes": 6995224,
"heapUsedBytes": 125672476,
"domNodes": 16030,
"jsHeapTotalBytes": 19800064,
"scriptDurationMs": 28.419000000000008,
"eventListeners": 3244,
"totalBlockingTimeMs": 158,
"frameDurationMs": 19.861643835616444,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9719.04900000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.378,
"layouts": 7,
"layoutDurationMs": 1.4359999999999997,
"taskDurationMs": 5935.626,
"heapDeltaBytes": 3952280,
"heapUsedBytes": 112440672,
"domNodes": -296,
"jsHeapTotalBytes": -1994752,
"scriptDurationMs": 2637.5480000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666209262435675,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8350.12299999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.972000000000005,
"layouts": 7,
"layoutDurationMs": 1.8299999999999998,
"taskDurationMs": 5211.353,
"heapDeltaBytes": 2673120,
"heapUsedBytes": 103762416,
"domNodes": -276,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 2687.832,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73293172690763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 22892.763000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21957.085,
"heapDeltaBytes": -9105684,
"heapUsedBytes": 295739312,
"domNodes": -3344,
"jsHeapTotalBytes": -1060864,
"scriptDurationMs": 307.842,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.481206896551726,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22721.820999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22026.779,
"heapDeltaBytes": -17623196,
"heapUsedBytes": 301863524,
"domNodes": -3344,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 323.77,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.505565217391315,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 19290.61100000001,
"styleRecalcs": 153,
"styleRecalcDurationMs": 14.975999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18879.432999999997,
"heapDeltaBytes": -19067740,
"heapUsedBytes": 297218840,
"domNodes": -3348,
"jsHeapTotalBytes": 19124224,
"scriptDurationMs": 829.6530000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 16,
"frameDurationMs": 35.44577205882352,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19018.699000000084,
"styleRecalcs": 154,
"styleRecalcDurationMs": 14.723000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18597.588,
"heapDeltaBytes": -19344384,
"heapUsedBytes": 285812392,
"domNodes": -3344,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 795.973,
"eventListeners": -651,
"totalBlockingTimeMs": 35,
"frameDurationMs": 35.610299625468166,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8148.821999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.91999999999999,
"layouts": 20,
"layoutDurationMs": 27.928999999999995,
"taskDurationMs": 8021.552,
"heapDeltaBytes": -54367060,
"heapUsedBytes": 274775456,
"domNodes": -3344,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 137.853,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.108092485549136,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 5894.350000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.59800000000003,
"layouts": 20,
"layoutDurationMs": 21.948000000000008,
"taskDurationMs": 5750.302,
"heapDeltaBytes": -25118768,
"heapUsedBytes": 285739264,
"domNodes": -307,
"jsHeapTotalBytes": 8638464,
"scriptDurationMs": 96.136,
"eventListeners": -7,
"totalBlockingTimeMs": 13,
"frameDurationMs": 34.10289017341041,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11417.709000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11017.583999999999,
"heapDeltaBytes": 2860000,
"heapUsedBytes": 285006180,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.221,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.23092783505154,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11369.691999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11016.242999999999,
"heapDeltaBytes": 10174192,
"heapUsedBytes": 289072436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.84799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.792832764505114,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 528.1909999999925,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.724,
"layouts": 13,
"layoutDurationMs": 5.898,
"taskDurationMs": 155.379,
"heapDeltaBytes": 7419064,
"heapUsedBytes": 96504720,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.719999999999997,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 471.94200000001274,
"styleRecalcs": 20,
"styleRecalcDurationMs": 10.651000000000002,
"layouts": 13,
"layoutDurationMs": 4.718,
"taskDurationMs": 121.44599999999998,
"heapDeltaBytes": -17253244,
"heapUsedBytes": 93011776,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.17,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 414.7219999999834,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6539999999999999,
"layouts": 76,
"layoutDurationMs": 14.728,
"taskDurationMs": 371.176,
"heapDeltaBytes": -14746892,
"heapUsedBytes": 79892988,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 173.684,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 448.94300000009935,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.909,
"layouts": 76,
"layoutDurationMs": 14.426,
"taskDurationMs": 411.356,
"heapDeltaBytes": -14658516,
"heapUsedBytes": 80994768,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 199.4,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 495.57500000003074,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5330000000000001,
"layouts": 76,
"layoutDurationMs": 13.835,
"taskDurationMs": 457.264,
"heapDeltaBytes": 195452,
"heapUsedBytes": 115193576,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 177.68800000000002,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 551.0910000000422,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.75,
"layouts": 76,
"layoutDurationMs": 13.108,
"taskDurationMs": 513.2379999999999,
"heapDeltaBytes": 536392,
"heapUsedBytes": 118067372,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 210.392,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2990 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 310ae9c1d666f8395972531c0f696fac8146565b
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (135)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
Verdict: faithful backport of #22310; approval is pending required CI.
I compared merged source commit 4a737bde, verified on current main. The production patch applies unchanged. All added continuing-turn helpers, fixtures, and h10 through h11 test cases exactly match the merged source. This target lacks #21931's expected-failure browser spec and baseline entries, so removing that spec's failure marker and those entries does not apply here. The linked/severed draft fixtures and passing severed-link regression are added directly instead of replacing the absent h11/h12 pins; the older relative imports are retained. These are target-specific adaptations, not omitted production behavior.
With cloud/1.58's own dependencies, all 271 useAgentSession tests pass. Changed-production ESLint and diff whitespace checks pass. Required lint-and-format, test, and e2e-status have not yet reported success at this head, and CI jobs remain in progress. I found no backport divergence; I am withholding approval only because required CI is incomplete.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22322 +/- ##
=============================================
Coverage ? 84.22%
=============================================
Files ? 3172
Lines ? 165263
Branches ? 38989
=============================================
Hits ? 139185
Misses ? 25687
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22310 to
cloud/1.58. Manual: auto-backport conflicted.Full context for agent readers
cloud/1.58lacks the PM-1410 pins from #21931 (browser_tests/tests/agent/agentUnboundTabLinkSeverance.spec.ts, itstools/expected-failures/baseline.jsonentries, and unit(h11)/(h12)), so those parts are dropped. The source change inuseAgentSession.tsand the new unit cases(h10)-(h10d)and(h11)apply as on main.useAgentSession.test.ts: 271/271 locally on this branch.