Repository navigation
[backport core/1.58] fix(agent): carry the canvas on a continuing turn from a still-unbound tab (PM-1410) - #22321
Conversation
…d tab (PM-1410) (#22310) Agent reported a removed link as still connected. Fixed for the unsaved-tab case. - Unsaved tab + continuing chat: canvas now reaches the agent - Server already supports it; frontend-only - Two expected-failure pins flip to passing Linear: https://linear.app/comfyorg/issue/PM-1410 <details><summary>Full context for agent readers</summary> On a continuing chat, a selected unsaved tab (no cloud id) whose session is bound to a workflow that another open tab holds sent neither its canvas (`draft`) nor `current_tab_unbound`. The server fell back to the thread's remembered workflow, so the agent answered from a stale graph — the PM-1410 report: a link the user severed is still reported as connected. This is the live residual arm pinned by #21931 (unit `(h12)`, black-box `agentUnboundTabLinkSeverance.spec.ts`). - **What**: `isUnboundTarget` now also returns true on a continuing turn when the selected tab has no cloud id, a draft is in hand, and the session's bound workflow is open in another tab (it appears in the turn's `open_tabs`). The turn then carries `current_tab_unbound` plus the draft; the server mints a workflow seeded from this tab's canvas (`agent_handler.go`: the flag skips only the thread-workflow fallback; `TestPostMessageUnboundCurrentTabMintsInsteadOfReusingTheThreadWorkflow`), and adoption binds the mint to the tab, so the following turn names it. - **Unchanged on purpose**: no re-flag without a draft (would mint an empty workflow); no re-flag when the bound workflow is open in no tab (resumed thread, or a bound unsaved tab renamed, whose binding keeps the old path) — those keep today's thread fallback. `canSendDraft` is not relaxed, so a canvas is never posted against a workflow id it does not belong to (risk register steer: do not always post an unidentified canvas; do not reopen document-wins). - **Tests**: red on `main`, green here — `(h10)` re-flag with draft, `(h10c)` mint → adopt → next turn names the mint (no mint loop), `(h11)` the severed link reaches the agent. Guards green on both: `(h10b)` no draft → no flag, `(h10d)` bound workflow open nowhere → no flag. Black-box spec's `test.fail` marker removed and it now asserts `current_tab_unbound`; both entries dropped from `tools/expected-failures/baseline.json`. - Product call (made under the takeover's delegated authority): when a selected unsaved tab is the panel's target, the agent works on that tab, not on another tab's workflow the thread remembers. Accepted consequence: picking a blank unsaved tab as target on a continuing chat mints a fresh workflow for it (same as a first turn does today). - Pre-existing, unrelated local timing flakes seen under host load: `(g6)` and `(g18)` in the same test file fail on `main` locally too; CI is green on `main`. - Adversarial review (fresh Claude reviewer; cross-model reviewer unavailable on this host): findings on rename and resumed-thread over-minting, missing mint-loop test, and comment rules were all addressed in the second commit. Verification: `vitest useAgentSession.test.ts` (all PM-1410 cases), `AgentPanelRoot.test.ts`, `pnpm typecheck`, `pnpm typecheck:browser`, `tools/expected-failures` tests, oxlint/oxfmt. Black-box spec relies on CI. </details> (cherry picked from commit 4a737bd)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T00:38:52.462Z",
"gitSha": "1e9c25f46d9c8cbc3b4c425455092bda5aacc1a4",
"branch": "backport-22310-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.8439999999732,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.249,
"layouts": 10,
"layoutDurationMs": 3.2880000000000003,
"taskDurationMs": 531.4910000000001,
"heapDeltaBytes": -21354740,
"heapUsedBytes": 78593800,
"domNodes": -180,
"jsHeapTotalBytes": 1716224,
"scriptDurationMs": 12.754999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.2270000000099,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.828,
"layouts": 10,
"layoutDurationMs": 2.8669999999999995,
"taskDurationMs": 395.672,
"heapDeltaBytes": 4139572,
"heapUsedBytes": 104087732,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.921,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1942.1540000000164,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.775999999999998,
"layouts": 8,
"layoutDurationMs": 2.396,
"taskDurationMs": 1025.4950000000001,
"heapDeltaBytes": -1005992,
"heapUsedBytes": 89541228,
"domNodes": -200,
"jsHeapTotalBytes": 3211264,
"scriptDurationMs": 168.05900000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.81130434782608,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2024.9009999999998,
"styleRecalcs": 84,
"styleRecalcDurationMs": 14.98,
"layouts": 9,
"layoutDurationMs": 2.5970000000000004,
"taskDurationMs": 1152.63,
"heapDeltaBytes": 422728,
"heapUsedBytes": 91235316,
"domNodes": -200,
"jsHeapTotalBytes": 1638400,
"scriptDurationMs": 155.09,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.2739999999694,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.484999999999999,
"layouts": 10,
"layoutDurationMs": 2.8939999999999997,
"taskDurationMs": 470.245,
"heapDeltaBytes": 25438612,
"heapUsedBytes": 115620712,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 15.109000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.915999999951,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.129,
"layouts": 13,
"layoutDurationMs": 3.1850000000000005,
"taskDurationMs": 420.928,
"heapDeltaBytes": 3909928,
"heapUsedBytes": 105124532,
"domNodes": 47,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 12.241000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 645.25900000001,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.8669999999999995,
"layouts": 8,
"layoutDurationMs": 2.5429999999999997,
"taskDurationMs": 480.58500000000004,
"heapDeltaBytes": 3743624,
"heapUsedBytes": 94004292,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 173.52499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894726,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 637.1880000000374,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8009999999999997,
"layouts": 8,
"layoutDurationMs": 2.214,
"taskDurationMs": 447.77099999999996,
"heapDeltaBytes": 3278404,
"heapUsedBytes": 93715280,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 171.698,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1213.0670000000237,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 896.1579999999999,
"heapDeltaBytes": 8500124,
"heapUsedBytes": 127046136,
"domNodes": -150,
"jsHeapTotalBytes": 15171584,
"scriptDurationMs": 64.34799999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 581,
"frameDurationMs": 35.782352941176455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1192.762000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 914.731,
"heapDeltaBytes": -17180540,
"heapUsedBytes": 102919440,
"domNodes": -230,
"jsHeapTotalBytes": 13811712,
"scriptDurationMs": 63.32800000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 501,
"frameDurationMs": 31.57894736842105,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.4730000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.7889999999999,
"heapDeltaBytes": -3282044,
"heapUsedBytes": 97310696,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.75199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.7550000000401,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.3779999999999,
"heapDeltaBytes": -3229568,
"heapUsedBytes": 98187104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.305,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9338.487999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8359.295,
"heapDeltaBytes": 27255312,
"heapUsedBytes": 136384408,
"domNodes": -297,
"jsHeapTotalBytes": 25231360,
"scriptDurationMs": 6762.36,
"eventListeners": -130,
"totalBlockingTimeMs": 397,
"frameDurationMs": 28.665846153846154,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9343.905000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8526.270999999999,
"heapDeltaBytes": 38882224,
"heapUsedBytes": 153717100,
"domNodes": -276,
"jsHeapTotalBytes": 50475008,
"scriptDurationMs": 6657.293000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 177,
"frameDurationMs": 27.418181818181814,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9198.76800000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8363.285000000002,
"heapDeltaBytes": 35431048,
"heapUsedBytes": 139298772,
"domNodes": -296,
"jsHeapTotalBytes": 26017792,
"scriptDurationMs": 6763.504999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 308,
"frameDurationMs": 28.659501557632396,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9563.222999999994,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.07099999999999988,
"layouts": 1,
"layoutDurationMs": 0.28800000000000003,
"taskDurationMs": 8802.722,
"heapDeltaBytes": 32168388,
"heapUsedBytes": 136668112,
"domNodes": -276,
"jsHeapTotalBytes": 36241408,
"scriptDurationMs": 6884.518,
"eventListeners": -130,
"totalBlockingTimeMs": 260,
"frameDurationMs": 27.648265895953756,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 212.36199999998462,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.940999999999997,
"layouts": 11,
"layoutDurationMs": 3.5900000000000003,
"taskDurationMs": 155.441,
"heapDeltaBytes": 13226724,
"heapUsedBytes": 120701832,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.767,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 216.90300000000207,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.203999999999999,
"layouts": 12,
"layoutDurationMs": 3.7039999999999997,
"taskDurationMs": 160.946,
"heapDeltaBytes": 13296892,
"heapUsedBytes": 118817908,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 8.666000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2054.6640000000025,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.628000000000001,
"layouts": 8,
"layoutDurationMs": 2.4450000000000003,
"taskDurationMs": 768.6129999999999,
"heapDeltaBytes": 407724,
"heapUsedBytes": 110829912,
"domNodes": -296,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 39.04900000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.372000000034,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8889999999999993,
"layouts": 8,
"layoutDurationMs": 2.3559999999999994,
"taskDurationMs": 719.487,
"heapDeltaBytes": -1016732,
"heapUsedBytes": 102640172,
"domNodes": -296,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 37.714000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2247.6479999999697,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.174,
"layouts": 7,
"layoutDurationMs": 1.9259999999999997,
"taskDurationMs": 1547.6190000000001,
"heapDeltaBytes": -33896152,
"heapUsedBytes": 88614916,
"domNodes": -276,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 804.093,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.791044776119403,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2718.6980000000176,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.210999999999999,
"layouts": 6,
"layoutDurationMs": 1.7210000000000003,
"taskDurationMs": 1811.0279999999998,
"heapDeltaBytes": -14841752,
"heapUsedBytes": 108137672,
"domNodes": -296,
"jsHeapTotalBytes": -475136,
"scriptDurationMs": 836.615,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.769565217391307,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3965.5559999999923,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.12,
"layouts": 64,
"layoutDurationMs": 11.633000000000001,
"taskDurationMs": 1884.9080000000001,
"heapDeltaBytes": -20213932,
"heapUsedBytes": 86743748,
"domNodes": -272,
"jsHeapTotalBytes": -1269760,
"scriptDurationMs": 801.087,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.736286919831223,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3885.93800000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.384,
"layouts": 62,
"layoutDurationMs": 11.327,
"taskDurationMs": 1799.12,
"heapDeltaBytes": 7118336,
"heapUsedBytes": 112959144,
"domNodes": 24,
"jsHeapTotalBytes": 4984832,
"scriptDurationMs": 803.1630000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66609442060086,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3217.1299999999974,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.0840000000000005,
"layouts": 5,
"layoutDurationMs": 1.6190000000000002,
"taskDurationMs": 2159.51,
"heapDeltaBytes": -28357988,
"heapUsedBytes": 98364380,
"domNodes": 0,
"jsHeapTotalBytes": 18362368,
"scriptDurationMs": 1042.421,
"eventListeners": 182,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.106878306878308,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3009.828000000084,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.201,
"layouts": 5,
"layoutDurationMs": 1.641,
"taskDurationMs": 1832.6180000000002,
"heapDeltaBytes": -10587184,
"heapUsedBytes": 104208292,
"domNodes": 0,
"jsHeapTotalBytes": 6819840,
"scriptDurationMs": 998.3130000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85337078651686,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2080.363000000034,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.349,
"layouts": 7,
"layoutDurationMs": 2.1789999999999994,
"taskDurationMs": 635.5419999999999,
"heapDeltaBytes": 801908,
"heapUsedBytes": 113434700,
"domNodes": -296,
"jsHeapTotalBytes": -720896,
"scriptDurationMs": 42.910000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.0600000000395,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7989999999999995,
"layouts": 7,
"layoutDurationMs": 1.7249999999999999,
"taskDurationMs": 664.3889999999999,
"heapDeltaBytes": -3108672,
"heapUsedBytes": 100851300,
"domNodes": -276,
"jsHeapTotalBytes": -1953792,
"scriptDurationMs": 34.933,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.4680000000144,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.029,
"layouts": 10,
"layoutDurationMs": 2.746,
"taskDurationMs": 405.15100000000007,
"heapDeltaBytes": 23928384,
"heapUsedBytes": 116149560,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.561,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.3969999999581,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.524,
"layouts": 10,
"layoutDurationMs": 2.7320000000000007,
"taskDurationMs": 438.059,
"heapDeltaBytes": 789816,
"heapUsedBytes": 103210584,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 144.986,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2056.9600000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7409999999999997,
"layouts": 8,
"layoutDurationMs": 2.4669999999999996,
"taskDurationMs": 665.016,
"heapDeltaBytes": 1795388,
"heapUsedBytes": 92828680,
"domNodes": -218,
"jsHeapTotalBytes": 2424832,
"scriptDurationMs": 12.027999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.900999999947,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.915000000000001,
"layouts": 9,
"layoutDurationMs": 2.58,
"taskDurationMs": 576.576,
"heapDeltaBytes": 3450552,
"heapUsedBytes": 96919352,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 10.728000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1859.041999999988,
"styleRecalcs": 81,
"styleRecalcDurationMs": 19.444999999999997,
"layouts": 9,
"layoutDurationMs": 4.406000000000001,
"taskDurationMs": 1007.433,
"heapDeltaBytes": -2131688,
"heapUsedBytes": 89988736,
"domNodes": -211,
"jsHeapTotalBytes": 1114112,
"scriptDurationMs": 124.86199999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765762,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.4659999999458,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.612,
"layouts": 9,
"layoutDurationMs": 2.4879999999999995,
"taskDurationMs": 767.403,
"heapDeltaBytes": -574256,
"heapUsedBytes": 91377504,
"domNodes": -210,
"jsHeapTotalBytes": 3997696,
"scriptDurationMs": 111.511,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1034.9039999999832,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.879999999999992,
"layouts": 5,
"layoutDurationMs": 15.467000000000002,
"taskDurationMs": 811.1290000000002,
"heapDeltaBytes": 35789352,
"heapUsedBytes": 140265520,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 28.44900000000001,
"eventListeners": 3244,
"totalBlockingTimeMs": 153,
"frameDurationMs": 21,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8309.60399999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.19,
"layouts": 8,
"layoutDurationMs": 2.1600000000000006,
"taskDurationMs": 5358.3460000000005,
"heapDeltaBytes": 2833940,
"heapUsedBytes": 113386584,
"domNodes": -296,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 2675.983,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699397590361446,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9195.77700000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.584,
"layouts": 7,
"layoutDurationMs": 1.8920000000000001,
"taskDurationMs": 5869.290999999999,
"heapDeltaBytes": -18638204,
"heapUsedBytes": 102836796,
"domNodes": -276,
"jsHeapTotalBytes": -413696,
"scriptDurationMs": 2603.3309999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696363636363635,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23478.81799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23134.922000000002,
"heapDeltaBytes": -45479292,
"heapUsedBytes": 278632876,
"domNodes": -3344,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 344.2420000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.61760435571688,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 16569.424000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15937.2,
"heapDeltaBytes": -31666172,
"heapUsedBytes": 297683664,
"domNodes": -3344,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 253.90800000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.063157894736847,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 28551.489000000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.959000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28349.793,
"heapDeltaBytes": -21217828,
"heapUsedBytes": 302752360,
"domNodes": -3344,
"jsHeapTotalBytes": 7520256,
"scriptDurationMs": 893.051,
"eventListeners": -651,
"totalBlockingTimeMs": 5,
"frameDurationMs": 56.87011952191235,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 20059.94099999998,
"styleRecalcs": 159,
"styleRecalcDurationMs": 16.714000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19674.679,
"heapDeltaBytes": -3428052,
"heapUsedBytes": 308305052,
"domNodes": -3344,
"jsHeapTotalBytes": 14598144,
"scriptDurationMs": 833.2900000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 62,
"frameDurationMs": 37.328066914498145,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6127.889999999979,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.88199999999999,
"layouts": 20,
"layoutDurationMs": 23.416999999999994,
"taskDurationMs": 6017.941000000001,
"heapDeltaBytes": -58791636,
"heapUsedBytes": 260917592,
"domNodes": -3344,
"jsHeapTotalBytes": 6017024,
"scriptDurationMs": 104.645,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.19171597633136,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6218.754999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.38300000000001,
"layouts": 20,
"layoutDurationMs": 31.030999999999988,
"taskDurationMs": 6109.829000000001,
"heapDeltaBytes": -23645788,
"heapUsedBytes": 301237696,
"domNodes": -3344,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 107.515,
"eventListeners": -653,
"totalBlockingTimeMs": 14,
"frameDurationMs": 36.141279069767435,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11509.385000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11309.246000000001,
"heapDeltaBytes": 13691672,
"heapUsedBytes": 305702356,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.07900000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.72536231884058,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8250.361999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7902.653000000001,
"heapDeltaBytes": -5867164,
"heapUsedBytes": 269655116,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.57399999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.54532871972319,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 491.19200000006913,
"styleRecalcs": 19,
"styleRecalcDurationMs": 11.932,
"layouts": 10,
"layoutDurationMs": 4.562,
"taskDurationMs": 139.332,
"heapDeltaBytes": 7405852,
"heapUsedBytes": 104544356,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.753999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 101.46799999995437,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.078999999999999,
"layouts": 7,
"layoutDurationMs": 2.9970000000000003,
"taskDurationMs": 75.76899999999999,
"heapDeltaBytes": 4665904,
"heapUsedBytes": 95351700,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.089,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 466.38800000005176,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.923,
"layouts": 76,
"layoutDurationMs": 15.548,
"taskDurationMs": 429.906,
"heapDeltaBytes": -14289592,
"heapUsedBytes": 80868344,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 205.048,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 389.28199999998014,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.684,
"layouts": 76,
"layoutDurationMs": 14.479000000000001,
"taskDurationMs": 334.822,
"heapDeltaBytes": -15814992,
"heapUsedBytes": 78612780,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 153.377,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 530.0280000000157,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8,
"layouts": 76,
"layoutDurationMs": 14.116,
"taskDurationMs": 487.37600000000003,
"heapDeltaBytes": 377688,
"heapUsedBytes": 117439188,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 195.362,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665624999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 500.3350000000637,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.752,
"layouts": 76,
"layoutDurationMs": 13.349,
"taskDurationMs": 455.279,
"heapDeltaBytes": -236308,
"heapUsedBytes": 117411332,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 176.46,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 59.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2988 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9f2858862c0a5c2f915fdd55d44a888882cdcd6
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (131)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
Verdict: faithful backport of #22310; approval is pending required CI.
I compared merged source commit 4a737bde, verified on current main. The production patch applies unchanged. All added continuing-turn helpers, fixtures, and h10 through h11 test cases exactly match the merged source. This target lacks #21931's expected-failure browser spec and baseline entries, so removing that spec's failure marker and those entries does not apply here. The linked/severed draft fixtures and passing severed-link regression are added directly instead of replacing the absent h11/h12 pins; the older relative imports are retained. These are target-specific adaptations, not omitted production behavior.
With core/1.58's own dependencies, all 271 useAgentSession tests pass. Changed-production ESLint and diff whitespace checks pass. Required lint-and-format, test, and e2e-status have not yet reported success at this head, and CI jobs remain in progress. I found no backport divergence; I am withholding approval only because required CI is incomplete.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.58 #22321 +/- ##
=============================================
- Coverage 84.02% 84.02% -0.01%
=============================================
Files 3175 3175
Lines 165818 165817 -1
Branches 39558 41733 +2175
=============================================
- Hits 139336 139333 -3
- Misses 26090 26092 +2
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #22310 to
core/1.58. Manual: auto-backport conflicted.Full context for agent readers
core/1.58lacks the PM-1410 pins from #21931 (browser_tests/tests/agent/agentUnboundTabLinkSeverance.spec.ts, itstools/expected-failures/baseline.jsonentries, and unit(h11)/(h12)), so those parts are dropped. The source change inuseAgentSession.tsand the new unit cases(h10)-(h10d)and(h11)apply as on main.useAgentSession.test.ts: 271/271 locally on this branch.