Repository navigation
[backport cloud/1.59] fix(agent): carry the canvas on a continuing turn from a still-unbound tab (PM-1410) - #22319
Conversation
…d tab (PM-1410) (#22310) Agent reported a removed link as still connected. Fixed for the unsaved-tab case. - Unsaved tab + continuing chat: canvas now reaches the agent - Server already supports it; frontend-only - Two expected-failure pins flip to passing Linear: https://linear.app/comfyorg/issue/PM-1410 <details><summary>Full context for agent readers</summary> ## Summary On a continuing chat, a selected unsaved tab (no cloud id) whose session is bound to a workflow that another open tab holds sent neither its canvas (`draft`) nor `current_tab_unbound`. The server fell back to the thread's remembered workflow, so the agent answered from a stale graph — the PM-1410 report: a link the user severed is still reported as connected. This is the live residual arm pinned by #21931 (unit `(h12)`, black-box `agentUnboundTabLinkSeverance.spec.ts`). ## Changes - **What**: `isUnboundTarget` now also returns true on a continuing turn when the selected tab has no cloud id, a draft is in hand, and the session's bound workflow is open in another tab (it appears in the turn's `open_tabs`). The turn then carries `current_tab_unbound` plus the draft; the server mints a workflow seeded from this tab's canvas (`agent_handler.go`: the flag skips only the thread-workflow fallback; `TestPostMessageUnboundCurrentTabMintsInsteadOfReusingTheThreadWorkflow`), and adoption binds the mint to the tab, so the following turn names it. - **Unchanged on purpose**: no re-flag without a draft (would mint an empty workflow); no re-flag when the bound workflow is open in no tab (resumed thread, or a bound unsaved tab renamed, whose binding keeps the old path) — those keep today's thread fallback. `canSendDraft` is not relaxed, so a canvas is never posted against a workflow id it does not belong to (risk register steer: do not always post an unidentified canvas; do not reopen document-wins). - **Tests**: red on `main`, green here — `(h10)` re-flag with draft, `(h10c)` mint → adopt → next turn names the mint (no mint loop), `(h11)` the severed link reaches the agent. Guards green on both: `(h10b)` no draft → no flag, `(h10d)` bound workflow open nowhere → no flag. Black-box spec's `test.fail` marker removed and it now asserts `current_tab_unbound`; both entries dropped from `tools/expected-failures/baseline.json`. ## Review Focus - Product call (made under the takeover's delegated authority): when a selected unsaved tab is the panel's target, the agent works on that tab, not on another tab's workflow the thread remembers. Accepted consequence: picking a blank unsaved tab as target on a continuing chat mints a fresh workflow for it (same as a first turn does today). - Pre-existing, unrelated local timing flakes seen under host load: `(g6)` and `(g18)` in the same test file fail on `main` locally too; CI is green on `main`. - Adversarial review (fresh Claude reviewer; cross-model reviewer unavailable on this host): findings on rename and resumed-thread over-minting, missing mint-loop test, and comment rules were all addressed in the second commit. Verification: `vitest useAgentSession.test.ts` (all PM-1410 cases), `AgentPanelRoot.test.ts`, `pnpm typecheck`, `pnpm typecheck:browser`, `tools/expected-failures` tests, oxlint/oxfmt. Black-box spec relies on CI. </details>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T00:17:00.682Z",
"gitSha": "25f00650867c0473b6a1095888eca6d537e58101",
"branch": "backport-22310-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.205999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.789,
"layouts": 9,
"layoutDurationMs": 2.5610000000000004,
"taskDurationMs": 506.8710000000001,
"heapDeltaBytes": 5233456,
"heapUsedBytes": 75633020,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8.472999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.7100000000373,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.64,
"layouts": 9,
"layoutDurationMs": 2.3040000000000003,
"taskDurationMs": 511.4030000000001,
"heapDeltaBytes": 5477800,
"heapUsedBytes": 75299300,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 8.077999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.4339999999859,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.260000000000002,
"layouts": 8,
"layoutDurationMs": 2.1510000000000002,
"taskDurationMs": 873.8759999999999,
"heapDeltaBytes": 22294524,
"heapUsedBytes": 83645320,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 163.492,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.8160000000616,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.349000000000002,
"layouts": 8,
"layoutDurationMs": 1.9779999999999998,
"taskDurationMs": 837.339,
"heapDeltaBytes": 21664996,
"heapUsedBytes": 83043404,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 158.67800000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.5479999999939,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.760000000000001,
"layouts": 11,
"layoutDurationMs": 2.9450000000000007,
"taskDurationMs": 389.965,
"heapDeltaBytes": 305860,
"heapUsedBytes": 70175916,
"domNodes": 56,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 9.437000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.3989999999194,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.368,
"layouts": 10,
"layoutDurationMs": 2.686,
"taskDurationMs": 382.7170000000001,
"heapDeltaBytes": 24609588,
"heapUsedBytes": 86544452,
"domNodes": 56,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.662,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 676.0749999999973,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.503,
"layouts": 8,
"layoutDurationMs": 2.3080000000000003,
"taskDurationMs": 478.378,
"heapDeltaBytes": 5217936,
"heapUsedBytes": 66529116,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 170.641,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 691.7010000000801,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4070000000000005,
"layouts": 9,
"layoutDurationMs": 2.32,
"taskDurationMs": 486.35900000000004,
"heapDeltaBytes": 5926204,
"heapUsedBytes": 66992180,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 169.417,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1196.8249999999898,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 885.7290000000002,
"heapDeltaBytes": -2224060,
"heapUsedBytes": 74946480,
"domNodes": -191,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 68.72800000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 510,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.63799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 906.82,
"heapDeltaBytes": -12431112,
"heapUsedBytes": 74833204,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 70.04899999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 532,
"frameDurationMs": 32.88108108108108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 894.8839999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.8169999999999,
"heapDeltaBytes": -15190308,
"heapUsedBytes": 65517160,
"domNodes": -191,
"jsHeapTotalBytes": 1441792,
"scriptDurationMs": 164.279,
"eventListeners": -106,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.321621621621613,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.9590000000326,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.4730000000003,
"heapDeltaBytes": -14663152,
"heapUsedBytes": 66088280,
"domNodes": -191,
"jsHeapTotalBytes": 1179648,
"scriptDurationMs": 162.97500000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.533333333333328,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11333.227999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10355.301,
"heapDeltaBytes": -5537268,
"heapUsedBytes": 83086652,
"domNodes": -257,
"jsHeapTotalBytes": 9826304,
"scriptDurationMs": 8805.42,
"eventListeners": -68,
"totalBlockingTimeMs": 1752,
"frameDurationMs": 33.82955223880597,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10637.734000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9883.372000000001,
"heapDeltaBytes": 56047840,
"heapUsedBytes": 139368164,
"domNodes": -257,
"jsHeapTotalBytes": 75362304,
"scriptDurationMs": 8044.188,
"eventListeners": -68,
"totalBlockingTimeMs": 1154,
"frameDurationMs": 31.78985074626866,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9172.135999999995,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3470000000000001,
"layouts": 1,
"layoutDurationMs": 0.32400000000000007,
"taskDurationMs": 8442.601999999999,
"heapDeltaBytes": -22030280,
"heapUsedBytes": 66367784,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 7070.788,
"eventListeners": -68,
"totalBlockingTimeMs": 721,
"frameDurationMs": 32.620640569395015,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9974.259999999958,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4410000000000004,
"layouts": 1,
"layoutDurationMs": 0.2590000000000001,
"taskDurationMs": 9176.297,
"heapDeltaBytes": 69270376,
"heapUsedBytes": 142296912,
"domNodes": -257,
"jsHeapTotalBytes": 64090112,
"scriptDurationMs": 7330.573,
"eventListeners": -68,
"totalBlockingTimeMs": 742,
"frameDurationMs": 31.538924050632907,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 237.24200000000906,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.577,
"layouts": 11,
"layoutDurationMs": 3.2639999999999993,
"taskDurationMs": 184.655,
"heapDeltaBytes": -9118532,
"heapUsedBytes": 74159328,
"domNodes": 936,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.206999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.99000000000001,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 269.1609999999969,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.593000000000002,
"layouts": 12,
"layoutDurationMs": 3.4200000000000004,
"taskDurationMs": 215.70799999999997,
"heapDeltaBytes": 14443428,
"heapUsedBytes": 90003792,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 8.485000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.236363636363627,
"p95FrameDurationMs": 100.09999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2055.7959999999866,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1020000000000008,
"layouts": 7,
"layoutDurationMs": 1.858,
"taskDurationMs": 619.2940000000001,
"heapDeltaBytes": -31312688,
"heapUsedBytes": 60305684,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 29.584000000000007,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2041.1139999999932,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.294,
"layouts": 8,
"layoutDurationMs": 2.043,
"taskDurationMs": 697.942,
"heapDeltaBytes": -5917308,
"heapUsedBytes": 85418800,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 31.654,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2395.0290000000223,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.075000000000001,
"layouts": 7,
"layoutDurationMs": 1.6769999999999996,
"taskDurationMs": 1632.043,
"heapDeltaBytes": -29905624,
"heapUsedBytes": 61820412,
"domNodes": -257,
"jsHeapTotalBytes": 6717440,
"scriptDurationMs": 795.1980000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2434.1630000000123,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.868,
"layouts": 7,
"layoutDurationMs": 1.682,
"taskDurationMs": 1689.308,
"heapDeltaBytes": -11015432,
"heapUsedBytes": 81611396,
"domNodes": -257,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 841.6909999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78194444444444,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3723.534000000029,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.052999999999999,
"layouts": 64,
"layoutDurationMs": 10.241999999999999,
"taskDurationMs": 1812.5580000000002,
"heapDeltaBytes": -6768300,
"heapUsedBytes": 70409368,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 784.96,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74054054054054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3546.615999999972,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.857000000000001,
"layouts": 64,
"layoutDurationMs": 9.988,
"taskDurationMs": 1677.889,
"heapDeltaBytes": 7627620,
"heapUsedBytes": 86304896,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 753.0319999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665727699530517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2895.344000000023,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.877,
"layouts": 5,
"layoutDurationMs": 1.14,
"taskDurationMs": 1908.0059999999999,
"heapDeltaBytes": 15992952,
"heapUsedBytes": 94887320,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 951.5129999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76300578034682,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2881.552000000056,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.091,
"layouts": 6,
"layoutDurationMs": 1.6079999999999997,
"taskDurationMs": 1913.1960000000001,
"heapDeltaBytes": 9349440,
"heapUsedBytes": 81835624,
"domNodes": 0,
"jsHeapTotalBytes": 3371008,
"scriptDurationMs": 953.459,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86235294117647,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3057.3100000000013,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.698,
"layouts": 7,
"layoutDurationMs": 1.6980000000000004,
"taskDurationMs": 766.0550000000001,
"heapDeltaBytes": -20484864,
"heapUsedBytes": 59940312,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 356.39400000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3030.930000000012,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5929999999999997,
"layouts": 6,
"layoutDurationMs": 1.677,
"taskDurationMs": 773.142,
"heapDeltaBytes": -17381732,
"heapUsedBytes": 58771444,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 352.929,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2063.828000000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2569999999999997,
"layouts": 8,
"layoutDurationMs": 2.462,
"taskDurationMs": 624.334,
"heapDeltaBytes": -6486732,
"heapUsedBytes": 74878112,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 31.849999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.4779999999555,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.712,
"layouts": 7,
"layoutDurationMs": 1.823,
"taskDurationMs": 627.249,
"heapDeltaBytes": -9773472,
"heapUsedBytes": 67832648,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 33.427,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2823.8369999999977,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.004000000000001,
"layouts": 8,
"layoutDurationMs": 2.1130000000000004,
"taskDurationMs": 599.887,
"heapDeltaBytes": 386936,
"heapUsedBytes": 79923896,
"domNodes": -245,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 187.032,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66627218934911,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2983.554999999967,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.814000000000002,
"layouts": 7,
"layoutDurationMs": 1.6780000000000002,
"taskDurationMs": 649.375,
"heapDeltaBytes": -21198516,
"heapUsedBytes": 71615288,
"domNodes": -254,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 200.652,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3254.5570000000052,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.92,
"layouts": 8,
"layoutDurationMs": 2.2580000000000005,
"taskDurationMs": 913.5830000000001,
"heapDeltaBytes": -14246572,
"heapUsedBytes": 64594500,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 387.757,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.838860103626946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3271.7649999999594,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8469999999999998,
"layouts": 7,
"layoutDurationMs": 1.706,
"taskDurationMs": 930.4850000000001,
"heapDeltaBytes": -8728636,
"heapUsedBytes": 84529476,
"domNodes": -257,
"jsHeapTotalBytes": 7241728,
"scriptDurationMs": 381.243,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 692.1899999999823,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.569,
"layouts": 8,
"layoutDurationMs": 2.35,
"taskDurationMs": 473.36,
"heapDeltaBytes": -1845904,
"heapUsedBytes": 60680212,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 155.804,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926833,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.7659999999787,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.581999999999999,
"layouts": 9,
"layoutDurationMs": 2.328,
"taskDurationMs": 441.569,
"heapDeltaBytes": -1331668,
"heapUsedBytes": 60801060,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 151.01600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.3970000000022,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5329999999999995,
"layouts": 10,
"layoutDurationMs": 2.3990000000000005,
"taskDurationMs": 508.3279999999999,
"heapDeltaBytes": 5059660,
"heapUsedBytes": 76784440,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 7.3340000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.5299999999606,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8980000000000006,
"layouts": 10,
"layoutDurationMs": 2.6220000000000003,
"taskDurationMs": 512.93,
"heapDeltaBytes": 5157692,
"heapUsedBytes": 77742748,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 7.752,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.7839999999896,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.827000000000002,
"layouts": 8,
"layoutDurationMs": 2.216,
"taskDurationMs": 817.484,
"heapDeltaBytes": 17282020,
"heapUsedBytes": 79954008,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 107.223,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.2050000000636,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.481999999999998,
"layouts": 9,
"layoutDurationMs": 2.2630000000000003,
"taskDurationMs": 810.37,
"heapDeltaBytes": 19542488,
"heapUsedBytes": 81502860,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 106.50800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.3340000000117,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.354000000000006,
"layouts": 5,
"layoutDurationMs": 15.365,
"taskDurationMs": 1037.2640000000001,
"heapDeltaBytes": 11663676,
"heapUsedBytes": 113368832,
"domNodes": 16030,
"jsHeapTotalBytes": 16125952,
"scriptDurationMs": 30.47099999999999,
"eventListeners": 3246,
"totalBlockingTimeMs": 151,
"frameDurationMs": 19.333333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8906.319999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.811,
"layouts": 8,
"layoutDurationMs": 1.905,
"taskDurationMs": 5855.955,
"heapDeltaBytes": 1908360,
"heapUsedBytes": 75646280,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2670.715,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666168224299064,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8939.73500000004,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.521,
"layouts": 9,
"layoutDurationMs": 2.319,
"taskDurationMs": 5797.731000000001,
"heapDeltaBytes": -3345156,
"heapUsedBytes": 71285820,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2651.719,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665858208955225,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23144.405000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22302.438,
"heapDeltaBytes": 634116,
"heapUsedBytes": 282873488,
"domNodes": -3343,
"jsHeapTotalBytes": 10739712,
"scriptDurationMs": 324.26,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.912241379310345,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22689.023999999903,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21869.004,
"heapDeltaBytes": -3920996,
"heapUsedBytes": 277976576,
"domNodes": -3343,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 298.838,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.0336860670194,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 27619.79200000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.91099999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27125.584000000003,
"heapDeltaBytes": -25091756,
"heapUsedBytes": 251181532,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 877.67,
"eventListeners": -651,
"totalBlockingTimeMs": 43,
"frameDurationMs": 50.640183486238534,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27618.190000000028,
"styleRecalcs": 180,
"styleRecalcDurationMs": 17.601000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27246.01,
"heapDeltaBytes": -12855240,
"heapUsedBytes": 269499404,
"domNodes": -3343,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 853.028,
"eventListeners": -651,
"totalBlockingTimeMs": 41,
"frameDurationMs": 51.61794392523365,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8177.665999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.53800000000001,
"layouts": 20,
"layoutDurationMs": 21.071000000000005,
"taskDurationMs": 8014.191000000001,
"heapDeltaBytes": -13779832,
"heapUsedBytes": 268059688,
"domNodes": -3343,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 131.874,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.21049723756905,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8047.396000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.572,
"layouts": 20,
"layoutDurationMs": 27.663000000000007,
"taskDurationMs": 7923.216000000001,
"heapDeltaBytes": -30539776,
"heapUsedBytes": 260881496,
"domNodes": -3343,
"jsHeapTotalBytes": 21749760,
"scriptDurationMs": 119.43100000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.26264367816093,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11479.112999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11098.297,
"heapDeltaBytes": -16004168,
"heapUsedBytes": 266102816,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.22100000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.15698924731184,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11374.085000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10890.357999999998,
"heapDeltaBytes": -15663268,
"heapUsedBytes": 251929732,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.88599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.604081632653056,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 125.06500000000642,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.996999999999998,
"layouts": 9,
"layoutDurationMs": 4.256,
"taskDurationMs": 109.26599999999999,
"heapDeltaBytes": -12827372,
"heapUsedBytes": 64103448,
"domNodes": 132,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.179,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 126.9360000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.134,
"layouts": 9,
"layoutDurationMs": 3.5570000000000004,
"taskDurationMs": 87.033,
"heapDeltaBytes": 4573724,
"heapUsedBytes": 65105972,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.092000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 445.32199999991917,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.63,
"layouts": 76,
"layoutDurationMs": 14.809,
"taskDurationMs": 395.344,
"heapDeltaBytes": -4874668,
"heapUsedBytes": 40257116,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 188.096,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 386.1249999999927,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.565,
"layouts": 76,
"layoutDurationMs": 13.520000000000001,
"taskDurationMs": 344.18399999999997,
"heapDeltaBytes": 11015096,
"heapUsedBytes": 50414852,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 163.95000000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 521.1870000000545,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.613,
"layouts": 76,
"layoutDurationMs": 13.915000000000001,
"taskDurationMs": 484.916,
"heapDeltaBytes": 817864,
"heapUsedBytes": 93925988,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 193.279,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.203225806451588,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 533.1869999999981,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.552,
"layouts": 76,
"layoutDurationMs": 14.895,
"taskDurationMs": 499.226,
"heapDeltaBytes": 379884,
"heapUsedBytes": 94028684,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 203.727,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.1875,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3123 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ad13efd5c8bee8d20093a0392888eb6bfa070d23
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (219)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22319 +/- ##
=============================================
Coverage ? 87.11%
=============================================
Files ? 3027
Lines ? 158396
Branches ? 40178
=============================================
Hits ? 137981
Misses ? 19739
Partials ? 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #22310 to cloud/1.59.
I compared this head with merged source commit 4a737bd, which is on current main. The production, unit-test and browser-test patches apply unchanged and reproduce the backport's complete tree. The only adaptation is omitting the removal of two expected-failure baseline entries that cloud/1.59 already lacks. No test changes were dropped.
With the target's own dependencies, all 278 useAgentSession tests pass, targeted production ESLint passes, and the diff has no whitespace errors. Playwright discovers the severed-link regression test. The required lint-and-format, test and e2e-status checks all passed at this head.
Backport of #22310 to
cloud/1.59Automatically created by backport workflow.