Repository navigation
FE-3099 feat(auth): finish local web SSO in a popup through a Cloud callback page - #22179
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough
Merge Risk:
|
📦 Bundle: 12 MB gzip 🔴 +1.61 kBDetailsSummary
Category Glance App Entry Points — 6.71 kB (baseline 6.68 kB) • 🔴 +25 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.58 MB (baseline 2.58 MB) • 🔴 +143 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 148 kB (baseline 149 kB) • 🟢 -8 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 873 kB (baseline 873 kB) • 🔴 +25 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 159 kB (baseline 159 kB) • 🔴 +29 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 7 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • 🟢 -133 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 359 kB (baseline 359 kB) • ⚪ 0 BReusable component library chunks
Status: 10 added / 10 removed / 21 unchanged Data & Services — 1.91 MB (baseline 1.91 MB) • 🟢 -1.18 kBStores, services, APIs, and repositories
Status: 36 added / 36 removed / 6 unchanged Utilities & Hooks — 2.43 MB (baseline 2.43 MB) • 🔴 +569 BHelpers, composables, and utility bundles
Status: 49 added / 49 removed / 35 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • 🔴 +4.63 kBBundles that do not match a named category
Status: 120 added / 118 removed / 629 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T22:57:01.362Z",
"gitSha": "bd6b42d94fe16c3b239debc0a26dcea34649076c",
"branch": "feat/local-web-sso-popup-callback",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.6509999999867,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9770000000000003,
"layouts": 9,
"layoutDurationMs": 2.669,
"taskDurationMs": 554.153,
"heapDeltaBytes": 1856176,
"heapUsedBytes": 63596488,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 10.494999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2007.5070000000323,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9510000000000005,
"layouts": 10,
"layoutDurationMs": 2.8340000000000005,
"taskDurationMs": 523.767,
"heapDeltaBytes": 1724368,
"heapUsedBytes": 63268996,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8.876999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.2779999999575,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.581000000000001,
"layouts": 9,
"layoutDurationMs": 2.405,
"taskDurationMs": 861.644,
"heapDeltaBytes": 21854848,
"heapUsedBytes": 83399412,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 147.93800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.3380000000097,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.015000000000002,
"layouts": 8,
"layoutDurationMs": 2.324,
"taskDurationMs": 869.923,
"heapDeltaBytes": 21661128,
"heapUsedBytes": 83046700,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 148.42,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.443000000007,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.439000000000001,
"layouts": 10,
"layoutDurationMs": 3.0719999999999996,
"taskDurationMs": 444.885,
"heapDeltaBytes": -1849048,
"heapUsedBytes": 59914652,
"domNodes": 57,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 13.426999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.478999999974,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.423,
"layouts": 12,
"layoutDurationMs": 3.2030000000000003,
"taskDurationMs": 419.99299999999994,
"heapDeltaBytes": 1158892,
"heapUsedBytes": 71535712,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 11.921999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 708.740999999975,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1650000000000005,
"layouts": 9,
"layoutDurationMs": 2.69,
"taskDurationMs": 497.784,
"heapDeltaBytes": 3941120,
"heapUsedBytes": 65286456,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 163.56400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 699.2800000000443,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.7489999999999997,
"layouts": 11,
"layoutDurationMs": 3.1590000000000003,
"taskDurationMs": 496.723,
"heapDeltaBytes": 7801856,
"heapUsedBytes": 77679960,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 162.655,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414635,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.9840000000122,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 814.8340000000001,
"heapDeltaBytes": 17775400,
"heapUsedBytes": 87937124,
"domNodes": 0,
"jsHeapTotalBytes": 12222464,
"scriptDurationMs": 57.74200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 510,
"frameDurationMs": 34.34545454545455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1194.5510000000468,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 893.651,
"heapDeltaBytes": -12644892,
"heapUsedBytes": 75608124,
"domNodes": -203,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 61.855999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 510,
"frameDurationMs": 32.43243243243242,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 897.4650000000111,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.2780000000002,
"heapDeltaBytes": -28527780,
"heapUsedBytes": 67286768,
"domNodes": -203,
"jsHeapTotalBytes": 2752512,
"scriptDurationMs": 140.996,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.321621621621638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 962.3020000000224,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 658.0529999999998,
"heapDeltaBytes": -26802020,
"heapUsedBytes": 66992352,
"domNodes": -203,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 157.713,
"eventListeners": -106,
"totalBlockingTimeMs": 239,
"frameDurationMs": 24.16500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9782.069999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8892.866999999998,
"heapDeltaBytes": -16242044,
"heapUsedBytes": 76922028,
"domNodes": -269,
"jsHeapTotalBytes": 9039872,
"scriptDurationMs": 6912.206,
"eventListeners": -68,
"totalBlockingTimeMs": 439,
"frameDurationMs": 30.29722222222222,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9199.883,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05099999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8401.32,
"heapDeltaBytes": 59554816,
"heapUsedBytes": 141559960,
"domNodes": -269,
"jsHeapTotalBytes": 63565824,
"scriptDurationMs": 6580.732,
"eventListeners": -68,
"totalBlockingTimeMs": 172,
"frameDurationMs": 27.493712574850303,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9151.62399999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8349.858,
"heapDeltaBytes": 66397644,
"heapUsedBytes": 149990896,
"domNodes": -269,
"jsHeapTotalBytes": 62517248,
"scriptDurationMs": 6560.364999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 223,
"frameDurationMs": 28.415217391304346,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9213.877000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8360.177,
"heapDeltaBytes": -12905408,
"heapUsedBytes": 66172120,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6637.689,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 27.928484848484853,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 315.36999999997306,
"styleRecalcs": 27,
"styleRecalcDurationMs": 15.154,
"layouts": 11,
"layoutDurationMs": 3.5460000000000003,
"taskDurationMs": 264.466,
"heapDeltaBytes": -19936172,
"heapUsedBytes": 62612196,
"domNodes": 936,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 14.168,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.61428571428574,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 213.22199999997338,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.891,
"layouts": 7,
"layoutDurationMs": 2.5780000000000003,
"taskDurationMs": 154.43800000000002,
"heapDeltaBytes": 14659252,
"heapUsedBytes": 70919360,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.106,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2054.341999999963,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.674000000000001,
"layouts": 9,
"layoutDurationMs": 2.375,
"taskDurationMs": 660.5909999999999,
"heapDeltaBytes": -25761652,
"heapUsedBytes": 61347640,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 35.422000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2056.6460000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.954,
"layouts": 9,
"layoutDurationMs": 2.7579999999999996,
"taskDurationMs": 667.5630000000001,
"heapDeltaBytes": -3630640,
"heapUsedBytes": 85079196,
"domNodes": -269,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 36.677,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2469.368999999972,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.426,
"layouts": 7,
"layoutDurationMs": 1.7550000000000001,
"taskDurationMs": 1686.1810000000003,
"heapDeltaBytes": -11908564,
"heapUsedBytes": 76657248,
"domNodes": -269,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 801.477,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666216216216213,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2271.3919999999916,
"styleRecalcs": 65,
"styleRecalcDurationMs": 7.989,
"layouts": 3,
"layoutDurationMs": 0.5790000000000001,
"taskDurationMs": 1570.156,
"heapDeltaBytes": 16582704,
"heapUsedBytes": 76598728,
"domNodes": -179,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 768.52,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3718.357000000026,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.81,
"layouts": 64,
"layoutDurationMs": 11.165,
"taskDurationMs": 1822.43,
"heapDeltaBytes": -20270172,
"heapUsedBytes": 74383008,
"domNodes": -245,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 797.314,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666367713004487,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3753.914000000009,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.453000000000001,
"layouts": 64,
"layoutDurationMs": 11.594,
"taskDurationMs": 1765.774,
"heapDeltaBytes": 6755512,
"heapUsedBytes": 82590120,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 798.905,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637168141593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3083.506,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.453,
"layouts": 4,
"layoutDurationMs": 1.156,
"taskDurationMs": 2003.285,
"heapDeltaBytes": 22820864,
"heapUsedBytes": 100468056,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 979.848,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.938043478260873,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3149.907999999982,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.506,
"layouts": 5,
"layoutDurationMs": 1.3030000000000004,
"taskDurationMs": 2022.6950000000002,
"heapDeltaBytes": -1647172,
"heapUsedBytes": 90983272,
"domNodes": 0,
"jsHeapTotalBytes": 5959680,
"scriptDurationMs": 999.3679999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84232804232804,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3069.590000000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8519999999999994,
"layouts": 7,
"layoutDurationMs": 1.6150000000000002,
"taskDurationMs": 762.663,
"heapDeltaBytes": -18345928,
"heapUsedBytes": 73027860,
"domNodes": -269,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 343.22200000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3062.8410000000486,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8710000000000002,
"layouts": 7,
"layoutDurationMs": 1.716,
"taskDurationMs": 783.7019999999999,
"heapDeltaBytes": -23675304,
"heapUsedBytes": 66923196,
"domNodes": -269,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 350.58900000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757692307692306,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.2610000000295,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2129999999999987,
"layouts": 7,
"layoutDurationMs": 2.078,
"taskDurationMs": 712.4880000000002,
"heapDeltaBytes": -7768912,
"heapUsedBytes": 67157364,
"domNodes": -269,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 37.461999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2057.5990000000957,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2830000000000004,
"layouts": 7,
"layoutDurationMs": 2.165,
"taskDurationMs": 643.223,
"heapDeltaBytes": -30828256,
"heapUsedBytes": 60031284,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 34.553,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2703.0340000000024,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.635,
"layouts": 8,
"layoutDurationMs": 1.9189999999999996,
"taskDurationMs": 586.137,
"heapDeltaBytes": 9057796,
"heapUsedBytes": 80965472,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 187.374,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3079.462000000035,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.653999999999998,
"layouts": 8,
"layoutDurationMs": 2.1460000000000004,
"taskDurationMs": 620.173,
"heapDeltaBytes": -20669196,
"heapUsedBytes": 69438972,
"domNodes": -266,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 187.23800000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3255.119000000036,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.954000000000001,
"layouts": 7,
"layoutDurationMs": 1.842,
"taskDurationMs": 958.1090000000002,
"heapDeltaBytes": -13921140,
"heapUsedBytes": 80771964,
"domNodes": -269,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 372.79499999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666153846153847,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3314.119000000005,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9899999999999995,
"layouts": 7,
"layoutDurationMs": 1.8680000000000003,
"taskDurationMs": 949.7679999999999,
"heapDeltaBytes": -19948608,
"heapUsedBytes": 70920536,
"domNodes": -269,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 389.33,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750761421319798,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.8320000000208,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.966,
"layouts": 8,
"layoutDurationMs": 2.271,
"taskDurationMs": 438.893,
"heapDeltaBytes": 235660,
"heapUsedBytes": 62362024,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 148.69400000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.2659999999105,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.978,
"layouts": 9,
"layoutDurationMs": 2.3109999999999995,
"taskDurationMs": 438.642,
"heapDeltaBytes": 892156,
"heapUsedBytes": 62853100,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 148.76099999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.2229999999731,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8919999999999995,
"layouts": 9,
"layoutDurationMs": 2.5740000000000003,
"taskDurationMs": 528.9350000000001,
"heapDeltaBytes": 3973476,
"heapUsedBytes": 65574956,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 9.136000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.153000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2079999999999997,
"layouts": 8,
"layoutDurationMs": 2.1409999999999996,
"taskDurationMs": 542.421,
"heapDeltaBytes": 1989036,
"heapUsedBytes": 63287164,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.243999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.9110000000119,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.608999999999998,
"layouts": 8,
"layoutDurationMs": 1.981,
"taskDurationMs": 875.662,
"heapDeltaBytes": -6344800,
"heapUsedBytes": 57449388,
"domNodes": -187,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 107.758,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.4940000000024,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.921,
"layouts": 8,
"layoutDurationMs": 2.4090000000000003,
"taskDurationMs": 812.3159999999999,
"heapDeltaBytes": 18500104,
"heapUsedBytes": 81282768,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 105.239,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.7459999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.953,
"layouts": 5,
"layoutDurationMs": 12.69,
"taskDurationMs": 1026.5940000000003,
"heapDeltaBytes": 38283520,
"heapUsedBytes": 112914232,
"domNodes": 16029,
"jsHeapTotalBytes": 12980224,
"scriptDurationMs": 28.275999999999996,
"eventListeners": 3246,
"totalBlockingTimeMs": 154,
"frameDurationMs": 19.333333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9072.348000000035,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.63,
"layouts": 8,
"layoutDurationMs": 1.9220000000000002,
"taskDurationMs": 5907.188,
"heapDeltaBytes": -13980200,
"heapUsedBytes": 73563472,
"domNodes": -269,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 2699.4660000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66617647058823,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8946.953000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.583,
"layouts": 8,
"layoutDurationMs": 2.3649999999999998,
"taskDurationMs": 5859.652000000001,
"heapDeltaBytes": -16974272,
"heapUsedBytes": 72056004,
"domNodes": -269,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 2651.186,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666044776119403,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23603.308000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23102.806,
"heapDeltaBytes": -7203276,
"heapUsedBytes": 289022404,
"domNodes": -3343,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 373.511,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.84219858156028,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23728.184000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23219.767,
"heapDeltaBytes": -23668984,
"heapUsedBytes": 264340764,
"domNodes": -3343,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 343.535,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.53362521891419,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28762.038000000073,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.705000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28529.451,
"heapDeltaBytes": -30483664,
"heapUsedBytes": 261870984,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 954.269,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 56.15,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28677.233,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.699999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28356.277,
"heapDeltaBytes": -14914624,
"heapUsedBytes": 263259676,
"domNodes": -3343,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 887.775,
"eventListeners": -651,
"totalBlockingTimeMs": 41,
"frameDurationMs": 54.42542694497155,
"p95FrameDurationMs": 116.60000000000582
},
{
"name": "vue-node-resize-workload",
"durationMs": 8494.897999999921,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.83899999999998,
"layouts": 20,
"layoutDurationMs": 29.782000000000018,
"taskDurationMs": 8372.958,
"heapDeltaBytes": -21438648,
"heapUsedBytes": 261978880,
"domNodes": -3343,
"jsHeapTotalBytes": 22274048,
"scriptDurationMs": 135.019,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.7528735632184,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8447.615000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.837,
"layouts": 20,
"layoutDurationMs": 23.20399999999999,
"taskDurationMs": 8319.707999999999,
"heapDeltaBytes": -36371036,
"heapUsedBytes": 255817772,
"domNodes": -3343,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 138.407,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.111731843575406,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12031.987999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11616.127000000002,
"heapDeltaBytes": 3727068,
"heapUsedBytes": 261296692,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.31800000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.51872791519435,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11650.148999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11452.815,
"heapDeltaBytes": 28753496,
"heapUsedBytes": 282483396,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.01800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.59094076655052,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 130.78500000005988,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.676000000000002,
"layouts": 10,
"layoutDurationMs": 3.7630000000000003,
"taskDurationMs": 96.77599999999998,
"heapDeltaBytes": 4787212,
"heapUsedBytes": 72499288,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.469,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 499.43199999995613,
"styleRecalcs": 15,
"styleRecalcDurationMs": 10.229,
"layouts": 12,
"layoutDurationMs": 4.3839999999999995,
"taskDurationMs": 131.679,
"heapDeltaBytes": -10482844,
"heapUsedBytes": 59392860,
"domNodes": 129,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 10.805000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 447.6290000000063,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6819999999999999,
"layouts": 76,
"layoutDurationMs": 15.051,
"taskDurationMs": 398.474,
"heapDeltaBytes": -4894596,
"heapUsedBytes": 40057452,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 186.813,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962983,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 506.7470000000185,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.644,
"layouts": 76,
"layoutDurationMs": 14.796,
"taskDurationMs": 456.293,
"heapDeltaBytes": -3968492,
"heapUsedBytes": 40686296,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 217.68,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 576.7839999999751,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.787,
"layouts": 76,
"layoutDurationMs": 16.514,
"taskDurationMs": 544.182,
"heapDeltaBytes": 2063592,
"heapUsedBytes": 99533144,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 224.345,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 565.1770000000624,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.782,
"layouts": 76,
"layoutDurationMs": 15.673,
"taskDurationMs": 530.907,
"heapDeltaBytes": 1588532,
"heapUsedBytes": 103370552,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 216.194,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15588235294118,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3168 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1290b984f2080c06804749f1c68f10dd6c406cbd
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (281)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #22179 +/- ##
==========================================
- Coverage 87.50% 87.40% -0.10%
==========================================
Files 2932 2830 -102
Lines 159203 156054 -3149
Branches 43652 41133 -2519
==========================================
- Hits 139306 136403 -2903
+ Misses 18975 18895 -80
+ Partials 922 756 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 147 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…-out and storage failures - Count sign-outs and drop a sign-in fallback whose sign-out count moved before or after PKCE creation, so a queued sign-out cannot be followed by a stale authorize navigation. - A pinned tab whose workspace tokens are gone stays signed out on that workspace instead of adopting the shared tokens; sign-out unpins this tab. - pinTab reports failure; adoption keeps the workspace tokens and pin before writing the shared tokens, restores the previous pin if the shared write fails, and a switch whose pin fails stays put instead of going to consent.
…opup-callback # Conflicts: # src/platform/auth/localWeb/localWebAuthBridge.ts
…d, and tell other tabs - forgetWorkspace takes the stale tokens and deletes the workspace only while its stored refresh token is still the refused one, so a refresh that returns invalid_grant after a popup sign-in rewrote the workspace no longer deletes the newer tokens. - The storage token store now notifies subscribers for Comfy.LocalWebSignIn.WorkspaceTokens as well, so a tab pinned to a workspace another tab forgot re-reads its state and signs out instead of showing removed tokens.
|
Verified end to end at 119baef: everything works as intended. Setup: Chromium with the popup blocker on, ComfyUI on :8188, this branch's dev server with
Not covered: Safari's stricter popup-gesture rules, and stagingcloud itself (the callback page ships with this PR). |
christian-byrne
left a comment
There was a problem hiding this comment.
- The cross-tab token guards are fixed at this head, and tab-local workspace selection remains intact.
- Non-blocking: please consider
_blankor a per-attempt popup target. The fixedcomfy-local-web-sign-inname can let a concurrent sign-in from another tab retarget the same popup. - Please cover that edge with two independent bridge instances so concurrent attempts cannot steal each other's popup or callback state.
Full context for agent readers
The guarded workspace removal now deletes only the same refused refresh token, workspace-token storage changes wake pinned sibling tabs, all 14 review threads are resolved, and all 111 checks are settled without a failure.
|
@coderabbitai approve Every finding from your 21:27 review is fixed (3749701) and resolved, the human reviewer has approved, and the end-to-end verification is posted above. Your standing CHANGES_REQUESTED is the only remaining block. |
|
@dante01yoon Thanks for confirming the fixes in
✅ Action performed
|
|
|
|
@christian-byrne the popup-target note is addressed in #22335: |
…pup through a Cloud callback page (#22332) ## Why Manual backport of #22179 (merge commit c606071) to `core/1.59`; the bot cherry-pick hit a conflict. ## How Conflict in `src/platform/auth/localWeb/localWebAuthBridge.test.ts`: one test title differed on `core/1.59`. Resolved by taking the #22179 side; the local web bridge, its tests and `local-callback.html` now match `main` at the merge commit. Verified: `vitest run src/platform/auth/localWeb`, 75/75 pass on this branch. ## AS IS / TO BE Same as #22179. Co-authored-by: GitHub Action <action@github.com>
…pup through a Cloud callback page (#22333) ## Why Manual backport of #22179 (merge commit c606071) to `core/1.58`; the bot cherry-pick hit conflicts. ## How - `src/main.ts`: `core/1.58` has no `bootstrapTracer.settle('startup/local-auth')` span, so kept its structure and only applied the #22179 change: `startLocalWebSession({ onPopupBlocked })` showing `auth.desktopHost.popupBlocked`. - `src/platform/auth/localWeb/localWebAuthBridge.test.ts`: one test title differed; took the #22179 side. The local web bridge, its tests and `local-callback.html` match `main` at the merge commit (only the existing `reportError` import path differs). `vitest run src/platform/auth/localWeb`: 75/75 pass. ## AS IS / TO BE Same as #22179. Co-authored-by: GitHub Action <action@github.com>
…lback page on Cloud (#22336) ## Why Local web SSO (#22179, on `core/1.58` and `core/1.59`) finishes sign-in in a popup that returns through `/oauth/local-callback.html` on Cloud; cloud#16930 registers that page as the `comfy-local-web` redirect URI. The page ships in the frontend build, and `cloud/1.58` is the release branch (stagingcloud and cloud) per cloud's `frontend-version.json`. It doesn't have the page, so `stagingcloud.comfy.org/oauth/local-callback.html` returns 404 and local sign-in can't finish. ## Root cause #22179 was backported only to the core branches; the Cloud-served half (`public/oauth/local-callback.html`) never reached a `cloud/*` branch. ## How Adds only `public/oauth/local-callback.html`, identical to `main` at #22179's merge commit. It is a static page with no app code: it posts the callback query to `window.opener` and closes. Nothing else in the Cloud app changes. ## AS IS / TO BE AS IS: `/oauth/local-callback.html` on stagingcloud → 404. TO BE: page served; local popup sign-in completes (verified against a stand-in issuer in #22179 / #22335).
…lback page on Cloud (#22337) ## Why Local web SSO (#22179, on `core/1.58` and `core/1.59`) finishes sign-in in a popup that returns through `/oauth/local-callback.html` on Cloud; cloud#16930 registers that page as the `comfy-local-web` redirect URI. The page ships in the frontend build, and `cloud/1.59` is the testcloud branch per cloud's `frontend-version.json`. It doesn't have the page, so `stagingcloud.comfy.org/oauth/local-callback.html` returns 404 and local sign-in can't finish. ## Root cause #22179 was backported only to the core branches; the Cloud-served half (`public/oauth/local-callback.html`) never reached a `cloud/*` branch. ## How Adds only `public/oauth/local-callback.html`, identical to `main` at #22179's merge commit. It is a static page with no app code: it posts the callback query to `window.opener` and closes. Nothing else in the Cloud app changes. ## AS IS / TO BE AS IS: `/oauth/local-callback.html` on stagingcloud → 404. TO BE: page served; local popup sign-in completes (verified against a stand-in issuer in #22179 / #22335).
Comfy-Org#22335) ## Why Follow-up to Christian's non-blocking note on Comfy-Org#22179: the local web sign-in popup used the fixed target name `comfy-local-web-sign-in`, so a concurrent sign-in from another tab could take over the same popup. ## Root cause `window.open(url, name)` reuses an existing window with that name from the same browsing context group. A ComfyUI tab opened from another ComfyUI tab (link, `window.open`) is in the same group, so its sign-in found the first tab's popup and navigated it to its own authorize URL. Only one popup and one code exchange happened; the first tab's attempt was overwritten. Tabs the user opens independently are in separate groups and were not affected. ## How - `openPopup` uses `_blank`, so every attempt gets its own window. `window.opener` is kept (no `noopener`), so `local-callback.html` still posts back to the tab that started the attempt. - New unit test: two bridges sign in at once on a shared token store, each hearing both callbacks; each finishes only from its own popup with its own code, and neither reports a failure. Removing the popup-source check turns it red. ## AS IS / TO BE Real Chromium, this branch's dev server, ComfyUI on :8188, a stand-in Cloud issuer serving `oauth/local-callback.html`. Tab B opened from tab A; Continue with SSO clicked in A, then in B; consent in each popup. | | AS IS (fixed name) | TO BE (`_blank`) | |---|---|---| | Popups opened | 1 (B retargeted A's popup) | 2 (opener A, opener B) | | Code exchanges | 1 (`ws-personal`) | 2 (`ws-personal`, `ws-team-a`) | | Tab B workspace | `ws-personal` (not what B chose) | `ws-team-a` | | Failure toasts | none | none | Two independently opened tabs behave the same before and after (2 popups, 2 exchanges). All 9 popup scenarios from Comfy-Org#22179's verification (success, refused exchange, popup closed, switch to unkept/kept workspace, refused kept refresh, sign-out during popup, cross-tab forget, late refused refresh) give the same results on this branch.
Summary
Why
Local web SSO cannot finish on stock ComfyUI: Cloud redirects the page to
http://127.0.0.1:8188/?code=…and core answers 403, becausecreate_origin_only_middlewarerefuses every cross-site request (ComfyUI #13261). The core exemption (Comfy-Org/ComfyUI#17410) was rejected by comfyanonymous: core should not open that guard at all.Root cause
The sign-in returned by redirecting the page itself into core, which is a cross-site navigation core refuses.
How
No request crosses into core any more.
requestSignInopens/oauth/authorizein a popup withredirect_uri=/oauth/local-callback.htmlon the Cloud origin, andstate= PKCE state +~+ this page's origin. The callback page (public/oauth/local-callback.html, a static file served by the Cloud build, no app boot) posts the callback query towindow.openeronly when the origin instateishttp:on127.0.0.1orlocalhost, then closes. The page accepts the message only from the Cloud origin and from the popup it opened, then exchanges the code with its PKCE verifier and the callback redirect URI. The code exchange is shared with the boot-time completion, which stays for builds that still redirect the page. A blocked popup shows "Allow pop-ups for this page to sign in."; a failed exchange shows "Sign-in didn't finish. Try again."; closing the popup leaves the page signed out, and the sign-in dialog shows the same "Sign-in didn't finish. Try again." toast, as it does for Desktop sign-in. Switching to a workspace with no kept tokens now goes through consent in the popup too, so the page no longer reloads. The rejected approach and this design are recorded in the TDD (Sign-in return path).Needs Comfy-Org/cloud#16930 (registers the callback redirect) deployed to the target Cloud. Stacked on #22153.
AS IS / TO BE
Captured in Chromium against stock ComfyUI master and this build, with a stand-in OAuth server for the Cloud origin (stagingcloud screenshots follow once Comfy-Org/cloud#16930 is deployed).
Verification
state, signs in from the posted callback, ignores messages from another origin or window, stays signed out when the popup closes, reports a blocked popup and a refused code.src/platform/auth+src/composables/auth: 674 passing.postMessage, it was exchanged with the callback redirect URI, and the page was signed in with a clean address bar and its tab workspace set. The popup closed itself. The stagingcloud run follows the cloud deploy.