Repository navigation
[backport core/1.59] FE-3099 feat(auth): finish local web SSO in a popup through a Cloud callback page - #22332
Conversation
…allback page (#22179) Local web SSO cannot finish on stock ComfyUI: Cloud redirects the page to `http://127.0.0.1:8188/?code=…` and core answers 403, because `create_origin_only_middleware` refuses every cross-site request (ComfyUI #13261). The core exemption (Comfy-Org/ComfyUI#17410) was rejected by comfyanonymous: core should not open that guard at all. The sign-in returned by redirecting the page itself into core, which is a cross-site navigation core refuses. No request crosses into core any more. `requestSignIn` opens `/oauth/authorize` in a popup with `redirect_uri` = `/oauth/local-callback.html` on the Cloud origin, and `state` = PKCE state + `~` + this page's origin. The callback page (`public/oauth/local-callback.html`, a static file served by the Cloud build, no app boot) posts the callback query to `window.opener` only when the origin in `state` is `http:` on `127.0.0.1` or `localhost`, then closes. The page accepts the message only from the Cloud origin and from the popup it opened, then exchanges the code with its PKCE verifier and the callback redirect URI. The code exchange is shared with the boot-time completion, which stays for builds that still redirect the page. A blocked popup shows "Allow pop-ups for this page to sign in."; a failed exchange shows "Sign-in didn't finish. Try again."; closing the popup leaves the page signed out, and the sign-in dialog shows the same "Sign-in didn't finish. Try again." toast, as it does for Desktop sign-in. Switching to a workspace with no kept tokens now goes through consent in the popup too, so the page no longer reloads. The rejected approach and this design are recorded in the TDD (Sign-in return path). Needs Comfy-Org/cloud#16930 (registers the callback redirect) deployed to the target Cloud. Stacked on #22153. Captured in Chromium against **stock ComfyUI master** and this build, with a stand-in OAuth server for the Cloud origin (stagingcloud screenshots follow once Comfy-Org/cloud#16930 is deployed). | | | | --- | --- | | AS IS: the return to the local page is refused by core | <img src="https://gist.githubusercontent.com/dante01yoon/6598ab8648cae43e56f249a89c5deec9/raw/cf688b4ef96b3a051b44673c0c1bb8ab4f9ad203/as-is-403.png" width="560"> | | TO BE: the popup lands on the Cloud callback page, which hands the code back and closes itself | <img src="https://gist.githubusercontent.com/dante01yoon/6598ab8648cae43e56f249a89c5deec9/raw/095dc00baf69eac675a220a96c78c828bb6ef216/to-be-callback-popup-v2.png" width="320"> | | TO BE: the local page is signed in, address bar clean, no request into core | <img src="https://gist.githubusercontent.com/dante01yoon/6598ab8648cae43e56f249a89c5deec9/raw/542678e4199f78d3d4121371c22db54d0c9b27ff/to-be-signed-in.png" width="560"> | | TO BE: a popup sign-in whose code exchange is refused shows the failure toast | <img src="https://gist.githubusercontent.com/dante01yoon/6598ab8648cae43e56f249a89c5deec9/raw/57604ff6a45002d2ae48de345c2c25b4f81bfcf4/to-be-signin-failed-toast.png" width="560"> | - Unit: the popup flow opens authorize with the Cloud callback and the page origin in `state`, signs in from the posted callback, ignores messages from another origin or window, stays signed out when the popup closes, reports a blocked popup and a refused code. `src/platform/auth` + `src/composables/auth`: 674 passing. - End to end in Chromium: **stock ComfyUI master**, which still 403s cross-site navigations, plus this build and a stand-in OAuth server for the Cloud origin. Sign-in opened the popup, authorize redirected to the callback page, the code came back via `postMessage`, it was exchanged with the callback redirect URI, and the page was signed in with a clean address bar and its tab workspace set. The popup closed itself. The stagingcloud run follows the cloud deploy. --------- Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit c606071)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T01:25:36.548Z",
"gitSha": "206ee66f8dd51f01c18d8c52a5ee95f3c04aed34",
"branch": "backport-22179-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.0360000000142,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.196,
"layouts": 9,
"layoutDurationMs": 2.195,
"taskDurationMs": 458.90799999999996,
"heapDeltaBytes": -589932,
"heapUsedBytes": 60372472,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.218,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.1239999999525,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.282,
"layouts": 9,
"layoutDurationMs": 2.232,
"taskDurationMs": 497.5999999999999,
"heapDeltaBytes": 1466104,
"heapUsedBytes": 62652988,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 9.592,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1704.2200000000207,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.633000000000001,
"layouts": 9,
"layoutDurationMs": 2.217,
"taskDurationMs": 786.212,
"heapDeltaBytes": -1957548,
"heapUsedBytes": 68479036,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 131.898,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.840000000001,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.491000000000001,
"layouts": 9,
"layoutDurationMs": 2.519,
"taskDurationMs": 797.785,
"heapDeltaBytes": -2792032,
"heapUsedBytes": 68177044,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 138.648,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.3939999999848,
"styleRecalcs": 20,
"styleRecalcDurationMs": 4.5249999999999995,
"layouts": 10,
"layoutDurationMs": 2.565,
"taskDurationMs": 373.382,
"heapDeltaBytes": 24421876,
"heapUsedBytes": 85673144,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.886000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.3849999999838,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.4110000000000005,
"layouts": 10,
"layoutDurationMs": 2.838,
"taskDurationMs": 377.74699999999996,
"heapDeltaBytes": -1300372,
"heapUsedBytes": 60009928,
"domNodes": 56,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.677,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 594.0400000000068,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.214,
"layouts": 9,
"layoutDurationMs": 2.1270000000000002,
"taskDurationMs": 426.539,
"heapDeltaBytes": 5228596,
"heapUsedBytes": 77002668,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 143.87900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 629.4219999999768,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4270000000000005,
"layouts": 9,
"layoutDurationMs": 2.2680000000000002,
"taskDurationMs": 461.886,
"heapDeltaBytes": 5674420,
"heapUsedBytes": 66835868,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 158.241,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1114.9799999999743,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 810.7499999999999,
"heapDeltaBytes": -13821332,
"heapUsedBytes": 75066448,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 53.727,
"eventListeners": -106,
"totalBlockingTimeMs": 446,
"frameDurationMs": 31.016666666666676,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1148.2829999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 849.123,
"heapDeltaBytes": -6593468,
"heapUsedBytes": 75423128,
"domNodes": -191,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 56.553999999999995,
"eventListeners": -106,
"totalBlockingTimeMs": 474,
"frameDurationMs": 31.078378378378382,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 809.6589999999821,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.5870000000002,
"heapDeltaBytes": -27918140,
"heapUsedBytes": 66726564,
"domNodes": -211,
"jsHeapTotalBytes": 4063232,
"scriptDurationMs": 120.677,
"eventListeners": -106,
"totalBlockingTimeMs": 151,
"frameDurationMs": 22.683333333333344,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 827.8159999999843,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.2009999999999,
"heapDeltaBytes": -13875772,
"heapUsedBytes": 65921780,
"domNodes": -191,
"jsHeapTotalBytes": 2228224,
"scriptDurationMs": 132.228,
"eventListeners": -106,
"totalBlockingTimeMs": 173,
"frameDurationMs": 23.147222222222226,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9565.266000000009,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.21199999999999952,
"layouts": 1,
"layoutDurationMs": 0.24600000000000014,
"taskDurationMs": 8590.398000000001,
"heapDeltaBytes": 87047792,
"heapUsedBytes": 159371376,
"domNodes": -257,
"jsHeapTotalBytes": 69332992,
"scriptDurationMs": 6629.7880000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 238,
"frameDurationMs": 27.441666666666663,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9078.503999999954,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0480000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8083.067,
"heapDeltaBytes": 75239992,
"heapUsedBytes": 148218452,
"domNodes": -257,
"jsHeapTotalBytes": 69595136,
"scriptDurationMs": 6170.581,
"eventListeners": -68,
"totalBlockingTimeMs": 145,
"frameDurationMs": 26.55818713450293,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8879.255999999998,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3059999999999998,
"layouts": 2,
"layoutDurationMs": 0.46699999999999997,
"taskDurationMs": 7910.574,
"heapDeltaBytes": -21326712,
"heapUsedBytes": 67073960,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 6100.1759999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 235,
"frameDurationMs": 25.747826086956522,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9857.981000000053,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5780000000000004,
"layouts": 2,
"layoutDurationMs": 0.5499999999999997,
"taskDurationMs": 8926.79,
"heapDeltaBytes": 91284436,
"heapUsedBytes": 165452984,
"domNodes": -257,
"jsHeapTotalBytes": 80343040,
"scriptDurationMs": 7015.232,
"eventListeners": -68,
"totalBlockingTimeMs": 173,
"frameDurationMs": 28.189142857142855,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 233.47599999999602,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.019,
"layouts": 11,
"layoutDurationMs": 3.1630000000000003,
"taskDurationMs": 187.48700000000002,
"heapDeltaBytes": 14438200,
"heapUsedBytes": 90227880,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.225999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.736363636363627,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 249.2419999999811,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.578,
"layouts": 11,
"layoutDurationMs": 3.604,
"taskDurationMs": 213.70999999999998,
"heapDeltaBytes": -982664,
"heapUsedBytes": 68479592,
"domNodes": -2315,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 10.322000000000001,
"eventListeners": -573,
"totalBlockingTimeMs": 1,
"frameDurationMs": 23.329999999999973,
"p95FrameDurationMs": 83.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2024.7999999999706,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7669999999999995,
"layouts": 8,
"layoutDurationMs": 2.02,
"taskDurationMs": 578.472,
"heapDeltaBytes": -10860088,
"heapUsedBytes": 63235212,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 31.20200000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2056.3060000000632,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8400000000000005,
"layouts": 8,
"layoutDurationMs": 1.9180000000000001,
"taskDurationMs": 592.4380000000001,
"heapDeltaBytes": -9245380,
"heapUsedBytes": 65311924,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 34.857,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2263.0419999999845,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.077000000000002,
"layouts": 7,
"layoutDurationMs": 1.3709999999999998,
"taskDurationMs": 1579.269,
"heapDeltaBytes": 6426204,
"heapUsedBytes": 81684012,
"domNodes": -257,
"jsHeapTotalBytes": 6119424,
"scriptDurationMs": 754.006,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.789629629629626,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2192.724999999996,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.614,
"layouts": 8,
"layoutDurationMs": 2.008,
"taskDurationMs": 1570.97,
"heapDeltaBytes": 6109028,
"heapUsedBytes": 86248216,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 741.692,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665648854961834,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3558.6660000000165,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.149,
"layouts": 64,
"layoutDurationMs": 11.606,
"taskDurationMs": 1679.5739999999998,
"heapDeltaBytes": 5411068,
"heapUsedBytes": 82569864,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 740.5970000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3609.768000000031,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.190999999999999,
"layouts": 64,
"layoutDurationMs": 12.177999999999999,
"taskDurationMs": 1753.1919999999998,
"heapDeltaBytes": -10035460,
"heapUsedBytes": 65543648,
"domNodes": -233,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 737.989,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2753.4789999999703,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.21,
"layouts": 5,
"layoutDurationMs": 1.1139999999999999,
"taskDurationMs": 1755.763,
"heapDeltaBytes": 15525344,
"heapUsedBytes": 94134256,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 849.217,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.767682926829266,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2867.342000000008,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.801,
"layouts": 5,
"layoutDurationMs": 1.3880000000000003,
"taskDurationMs": 1818.8580000000002,
"heapDeltaBytes": 16330300,
"heapUsedBytes": 95079232,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 884.1750000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.763157894736842,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3070.7149999999783,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5469999999999997,
"layouts": 7,
"layoutDurationMs": 1.5930000000000002,
"taskDurationMs": 748.3,
"heapDeltaBytes": 13772,
"heapUsedBytes": 80265692,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 334.989,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826085,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3039.0649999999937,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7159999999999997,
"layouts": 7,
"layoutDurationMs": 1.6029999999999998,
"taskDurationMs": 774.911,
"heapDeltaBytes": 9684076,
"heapUsedBytes": 85702400,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 339.586,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.6859999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9310000000000005,
"layouts": 8,
"layoutDurationMs": 1.9120000000000001,
"taskDurationMs": 596.328,
"heapDeltaBytes": -9704224,
"heapUsedBytes": 66438944,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 32.914,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.990000000008,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8250000000000002,
"layouts": 7,
"layoutDurationMs": 1.742,
"taskDurationMs": 580.009,
"heapDeltaBytes": -13801708,
"heapUsedBytes": 62510620,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 33.12200000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2852.868000000001,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.103,
"layouts": 7,
"layoutDurationMs": 1.4829999999999999,
"taskDurationMs": 617.1139999999999,
"heapDeltaBytes": -19230648,
"heapUsedBytes": 73786164,
"domNodes": -253,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 194.643,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665497076023392,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2790.1970000000347,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.161999999999999,
"layouts": 7,
"layoutDurationMs": 1.5420000000000003,
"taskDurationMs": 592.931,
"heapDeltaBytes": 495248,
"heapUsedBytes": 76696760,
"domNodes": -252,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 179.865,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66646706586826,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3214.3370000000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6739999999999993,
"layouts": 7,
"layoutDurationMs": 1.7179999999999997,
"taskDurationMs": 887.4830000000001,
"heapDeltaBytes": -950620,
"heapUsedBytes": 75448768,
"domNodes": -277,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 332.392,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666145833333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3217.9610000000025,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.568,
"layouts": 6,
"layoutDurationMs": 1.47,
"taskDurationMs": 911.545,
"heapDeltaBytes": -4694216,
"heapUsedBytes": 73741280,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 340.43999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666321243523317,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 602.4850000000015,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.119,
"layouts": 9,
"layoutDurationMs": 2.115,
"taskDurationMs": 397.95399999999995,
"heapDeltaBytes": 3191636,
"heapUsedBytes": 75399072,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 129.46699999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.2059999999565,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.548,
"layouts": 10,
"layoutDurationMs": 2.336,
"taskDurationMs": 404.46299999999997,
"heapDeltaBytes": 324768,
"heapUsedBytes": 62368660,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 130.35,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2021.9749999999976,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4139999999999997,
"layouts": 10,
"layoutDurationMs": 2.36,
"taskDurationMs": 478.34900000000005,
"heapDeltaBytes": 3945244,
"heapUsedBytes": 66078972,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 9.413,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.5010000000475,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.351,
"layouts": 10,
"layoutDurationMs": 2.26,
"taskDurationMs": 472.59799999999996,
"heapDeltaBytes": 5050144,
"heapUsedBytes": 77799912,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 9.225999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.7689999999943,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.456999999999999,
"layouts": 9,
"layoutDurationMs": 2.057,
"taskDurationMs": 737.791,
"heapDeltaBytes": 17386528,
"heapUsedBytes": 79920208,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 93.14699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.5670000000773,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.469000000000001,
"layouts": 10,
"layoutDurationMs": 2.516,
"taskDurationMs": 757.197,
"heapDeltaBytes": 17336020,
"heapUsedBytes": 78657624,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 94.932,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.251999999954,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.693,
"layouts": 5,
"layoutDurationMs": 12.411999999999999,
"taskDurationMs": 986.213,
"heapDeltaBytes": 5090848,
"heapUsedBytes": 91312252,
"domNodes": 16030,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 30.797000000000004,
"eventListeners": 3246,
"totalBlockingTimeMs": 178,
"frameDurationMs": 20.0904109589041,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8271.389,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.684000000000005,
"layouts": 8,
"layoutDurationMs": 1.9919999999999998,
"taskDurationMs": 5323.557,
"heapDeltaBytes": -13819716,
"heapUsedBytes": 62167328,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 2357.4449999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592741935484,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8299.728000000072,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.569,
"layouts": 8,
"layoutDurationMs": 1.8060000000000003,
"taskDurationMs": 5435.059,
"heapDeltaBytes": -14966572,
"heapUsedBytes": 76472236,
"domNodes": -257,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 2422.2210000000005,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665794768611672,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18880.379000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18259.182000000004,
"heapDeltaBytes": -40217300,
"heapUsedBytes": 260818400,
"domNodes": -3343,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 273.004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.069176882662,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-idle",
"durationMs": 19161.114999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18768.583,
"heapDeltaBytes": -19907772,
"heapUsedBytes": 259747120,
"domNodes": -3347,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 276.91700000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.448342059336824,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 23950.122999999963,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.77299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23575.924,
"heapDeltaBytes": -26696720,
"heapUsedBytes": 270631660,
"domNodes": -3343,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 868.676,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.848314606741575,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23694.183000000066,
"styleRecalcs": 178,
"styleRecalcDurationMs": 23.995999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23356.4,
"heapDeltaBytes": -18501256,
"heapUsedBytes": 262823400,
"domNodes": -3343,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 870.4739999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 36,
"frameDurationMs": 44.46360225140713,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7086.245000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.27899999999998,
"layouts": 20,
"layoutDurationMs": 30.017000000000003,
"taskDurationMs": 6966.172,
"heapDeltaBytes": -16374236,
"heapUsedBytes": 280756068,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 133.116,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.706896551724135,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 7051.81499999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.93399999999998,
"layouts": 20,
"layoutDurationMs": 24.29400000000001,
"taskDurationMs": 6950.679,
"heapDeltaBytes": -34182952,
"heapUsedBytes": 257176928,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 132.447,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.07222222222222,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9849.319999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9617.879,
"heapDeltaBytes": -10653768,
"heapUsedBytes": 259458248,
"domNodes": 0,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 149.55799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.906551724137934,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6908.6679999999205,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6519.771000000001,
"heapDeltaBytes": 10939552,
"heapUsedBytes": 265345488,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.97699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.32759856630825,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 127.5630000000092,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.055,
"layouts": 9,
"layoutDurationMs": 4.223,
"taskDurationMs": 100.94300000000001,
"heapDeltaBytes": 4800620,
"heapUsedBytes": 64361356,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.721,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 106.35800000000017,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.853000000000001,
"layouts": 8,
"layoutDurationMs": 2.872,
"taskDurationMs": 71.63799999999999,
"heapDeltaBytes": 4546752,
"heapUsedBytes": 64418160,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.0539999999999985,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 403.9619999999786,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7240000000000001,
"layouts": 76,
"layoutDurationMs": 14.441,
"taskDurationMs": 350.008,
"heapDeltaBytes": -5052164,
"heapUsedBytes": 37186644,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 158.583,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 472.87500000004457,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.713,
"layouts": 76,
"layoutDurationMs": 14.665,
"taskDurationMs": 420.134,
"heapDeltaBytes": -4248408,
"heapUsedBytes": 38428504,
"domNodes": 4,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 200.326,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 463.2689999999684,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7409999999999999,
"layouts": 76,
"layoutDurationMs": 14.722000000000001,
"taskDurationMs": 419.976,
"heapDeltaBytes": -4080192,
"heapUsedBytes": 81018796,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 157.065,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 444.19200000004366,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.678,
"layouts": 76,
"layoutDurationMs": 14.008,
"taskDurationMs": 402.54499999999996,
"heapDeltaBytes": 508732,
"heapUsedBytes": 94241572,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 152.818,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3125 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 117b1d282765c468177699d302a70f141fd0e7c6
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (224)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.59 #22332 +/- ##
=============================================
- Coverage 87.12% 87.12% -0.01%
=============================================
Files 3027 3027
Lines 158597 158688 +91
Branches 40162 40177 +15
=============================================
+ Hits 138177 138249 +72
- Misses 19744 19763 +19
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Why
Manual backport of #22179 (merge commit c606071) to
core/1.59; the bot cherry-pick hit a conflict.How
Conflict in
src/platform/auth/localWeb/localWebAuthBridge.test.ts: one test title differed oncore/1.59. Resolved by taking the #22179 side; the local web bridge, its tests andlocal-callback.htmlnow matchmainat the merge commit.Verified:
vitest run src/platform/auth/localWeb, 75/75 pass on this branch.AS IS / TO BE
Same as #22179.