Repository navigation
[backport cloud/1.59] FE-3099 feat(auth): serve the local web SSO callback page on Cloud - #22337
Conversation
Ships public/oauth/local-callback.html from #22179 on cloud/1.59 so stagingcloud and cloud serve it. cloud#16930 registers this page as the comfy-local-web redirect URI, and the local popup sign-in in core/1.58 and core/1.59 returns through it.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T01:52:24.137Z",
"gitSha": "88cfa750c8d4e77ee8dc6c5c28e220c14d09766f",
"branch": "backport-22179-callback-page-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.1189999999747,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7450000000000006,
"layouts": 9,
"layoutDurationMs": 1.9909999999999997,
"taskDurationMs": 460.765,
"heapDeltaBytes": 2845644,
"heapUsedBytes": 64049344,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8.793,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2008.7650000000394,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8070000000000004,
"layouts": 9,
"layoutDurationMs": 1.8509999999999998,
"taskDurationMs": 470.51300000000003,
"heapDeltaBytes": 1887740,
"heapUsedBytes": 63068160,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.798000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.347000000013,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.382000000000001,
"layouts": 9,
"layoutDurationMs": 1.8449999999999998,
"taskDurationMs": 727.6729999999999,
"heapDeltaBytes": -2092052,
"heapUsedBytes": 67919624,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 124.973,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1723.2520000000022,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.246,
"layouts": 9,
"layoutDurationMs": 1.7329999999999999,
"taskDurationMs": 718.5950000000001,
"heapDeltaBytes": 21688284,
"heapUsedBytes": 83015456,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 120.47000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.0309999999777,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.873,
"layouts": 10,
"layoutDurationMs": 2.444,
"taskDurationMs": 348.77599999999995,
"heapDeltaBytes": 19670212,
"heapUsedBytes": 80968260,
"domNodes": 56,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.555,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0739999999496,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.995,
"layouts": 10,
"layoutDurationMs": 2.141,
"taskDurationMs": 348.42699999999996,
"heapDeltaBytes": 19664216,
"heapUsedBytes": 80592012,
"domNodes": 56,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.404,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 576.0549999999967,
"styleRecalcs": 13,
"styleRecalcDurationMs": 1.934,
"layouts": 9,
"layoutDurationMs": 1.8370000000000002,
"taskDurationMs": 426.98400000000004,
"heapDeltaBytes": 6543776,
"heapUsedBytes": 77032548,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 144.892,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 576.7210000000205,
"styleRecalcs": 14,
"styleRecalcDurationMs": 1.8999999999999997,
"layouts": 10,
"layoutDurationMs": 1.975,
"taskDurationMs": 414.45799999999997,
"heapDeltaBytes": 3302684,
"heapUsedBytes": 64778320,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 137.004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.2619999999552,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 828.2199999999999,
"heapDeltaBytes": -12287708,
"heapUsedBytes": 75087544,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 55.37700000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 470,
"frameDurationMs": 31.08108108108107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1148.9100000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.9440000000001,
"heapDeltaBytes": -12438724,
"heapUsedBytes": 74998120,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 53.714,
"eventListeners": -106,
"totalBlockingTimeMs": 471,
"frameDurationMs": 31.08108108108108,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 811.0520000000179,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.58299999999997,
"heapDeltaBytes": -26366332,
"heapUsedBytes": 65749588,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 123.897,
"eventListeners": -106,
"totalBlockingTimeMs": 144,
"frameDurationMs": 22.68611111111113,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 796.7380000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.1069999999999,
"heapDeltaBytes": -26523516,
"heapUsedBytes": 65256112,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 117.872,
"eventListeners": -106,
"totalBlockingTimeMs": 141,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8472.173999999995,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.40800000000000036,
"layouts": 2,
"layoutDurationMs": 0.5500000000000002,
"taskDurationMs": 7644.478999999999,
"heapDeltaBytes": 58777988,
"heapUsedBytes": 131312128,
"domNodes": -257,
"jsHeapTotalBytes": 63303680,
"scriptDurationMs": 6215.125,
"eventListeners": -68,
"totalBlockingTimeMs": 172,
"frameDurationMs": 28.6993220338983,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8414.131999999994,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5599999999999997,
"layouts": 3,
"layoutDurationMs": 0.5739999999999998,
"taskDurationMs": 7534.971,
"heapDeltaBytes": 65070760,
"heapUsedBytes": 138374572,
"domNodes": -257,
"jsHeapTotalBytes": 72740864,
"scriptDurationMs": 5910.177,
"eventListeners": -68,
"totalBlockingTimeMs": 70,
"frameDurationMs": 25.073432835820892,
"p95FrameDurationMs": 49.900000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8128.608000000014,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.18400000000000014,
"layouts": 1,
"layoutDurationMs": 0.25699999999999984,
"taskDurationMs": 7301.756,
"heapDeltaBytes": 65082320,
"heapUsedBytes": 137357268,
"domNodes": -257,
"jsHeapTotalBytes": 57798656,
"scriptDurationMs": 5628.925,
"eventListeners": -68,
"totalBlockingTimeMs": 132,
"frameDurationMs": 25.257763975155278,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8060.411999999986,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.4000000000000002,
"layouts": 2,
"layoutDurationMs": 0.42000000000000026,
"taskDurationMs": 7274.081,
"heapDeltaBytes": 68150476,
"heapUsedBytes": 140486404,
"domNodes": -257,
"jsHeapTotalBytes": 62779392,
"scriptDurationMs": 5676.64,
"eventListeners": -68,
"totalBlockingTimeMs": 76,
"frameDurationMs": 24.921362229102165,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 217.2220000000209,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.042000000000002,
"layouts": 11,
"layoutDurationMs": 2.738000000000001,
"taskDurationMs": 161.24200000000002,
"heapDeltaBytes": -6197576,
"heapUsedBytes": 69939864,
"domNodes": -2315,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 8.023000000000001,
"eventListeners": -573,
"totalBlockingTimeMs": 1,
"frameDurationMs": 22.211111111111123,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 210.31899999996995,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.593,
"layouts": 10,
"layoutDurationMs": 2.5970000000000004,
"taskDurationMs": 174.54399999999998,
"heapDeltaBytes": 14419384,
"heapUsedBytes": 90666436,
"domNodes": 936,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 7.333999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-graph-idle",
"durationMs": 2025.6799999999657,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.7530000000000001,
"layouts": 10,
"layoutDurationMs": 2.18,
"taskDurationMs": 570.445,
"heapDeltaBytes": -21863920,
"heapUsedBytes": 69132988,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 27.342000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.241,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.576,
"layouts": 8,
"layoutDurationMs": 1.785,
"taskDurationMs": 568.7259999999999,
"heapDeltaBytes": -194860,
"heapUsedBytes": 76381336,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 26.851000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2207.95099999998,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.327,
"layouts": 7,
"layoutDurationMs": 1.372,
"taskDurationMs": 1432.1229999999998,
"heapDeltaBytes": -19393012,
"heapUsedBytes": 60888472,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 672.753,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2253.9339999999584,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.731,
"layouts": 8,
"layoutDurationMs": 1.5190000000000001,
"taskDurationMs": 1439.7640000000001,
"heapDeltaBytes": -16892104,
"heapUsedBytes": 75149756,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 658.8810000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925926,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3388.8279999999895,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.549,
"layouts": 64,
"layoutDurationMs": 10.134,
"taskDurationMs": 1570.031,
"heapDeltaBytes": 5199188,
"heapUsedBytes": 82302488,
"domNodes": -233,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 659.908,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666502463054186,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3206.242999999972,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.728999999999999,
"layouts": 64,
"layoutDurationMs": 9.566,
"taskDurationMs": 1428.5489999999998,
"heapDeltaBytes": 5096844,
"heapUsedBytes": 81958764,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 601.604,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666145833333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2377.2579999999834,
"styleRecalcs": 46,
"styleRecalcDurationMs": 3.7480000000000007,
"layouts": 6,
"layoutDurationMs": 1.1850000000000003,
"taskDurationMs": 1625.0950000000003,
"heapDeltaBytes": 11367548,
"heapUsedBytes": 93292928,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 753.7620000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2291.007000000036,
"styleRecalcs": 45,
"styleRecalcDurationMs": 3.3050000000000006,
"layouts": 6,
"layoutDurationMs": 1.2219999999999998,
"taskDurationMs": 1551.57,
"heapDeltaBytes": 12348124,
"heapUsedBytes": 94246268,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 729.529,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78897058823529,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3037.8880000000095,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.3889999999999996,
"layouts": 7,
"layoutDurationMs": 1.4809999999999999,
"taskDurationMs": 732.0029999999999,
"heapDeltaBytes": -11302996,
"heapUsedBytes": 64970960,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 330.381,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75769230769231,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2980.060999999978,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.4800000000000004,
"layouts": 8,
"layoutDurationMs": 1.571,
"taskDurationMs": 675.646,
"heapDeltaBytes": -20190188,
"heapUsedBytes": 60746940,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 295.50100000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665363128491624,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2030.9389999999894,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.419,
"layouts": 7,
"layoutDurationMs": 1.5570000000000002,
"taskDurationMs": 569.161,
"heapDeltaBytes": -15829316,
"heapUsedBytes": 64958004,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.997000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2033.7469999999485,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.4280000000000004,
"layouts": 7,
"layoutDurationMs": 1.3719999999999999,
"taskDurationMs": 578.526,
"heapDeltaBytes": -19392304,
"heapUsedBytes": 73115448,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 36.484,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2758.2760000000235,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.033999999999999,
"layouts": 8,
"layoutDurationMs": 1.596,
"taskDurationMs": 561.6239999999999,
"heapDeltaBytes": -4986592,
"heapUsedBytes": 73150820,
"domNodes": -253,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 159.864,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2693.6379999999644,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.084,
"layouts": 9,
"layoutDurationMs": 1.796,
"taskDurationMs": 534.6999999999999,
"heapDeltaBytes": -701684,
"heapUsedBytes": 80135280,
"domNodes": -245,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 149.76299999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3194.5519999999874,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.0569999999999997,
"layouts": 6,
"layoutDurationMs": 1.0610000000000002,
"taskDurationMs": 865.6460000000001,
"heapDeltaBytes": -15464864,
"heapUsedBytes": 64002392,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 334.117,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753403141361254,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3166.1060000000134,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5310000000000001,
"layouts": 8,
"layoutDurationMs": 1.5790000000000002,
"taskDurationMs": 828.811,
"heapDeltaBytes": 2313716,
"heapUsedBytes": 79063052,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 326.064,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666315789473682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.2419999999929,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.19,
"layouts": 10,
"layoutDurationMs": 2.117,
"taskDurationMs": 385.19699999999995,
"heapDeltaBytes": 929244,
"heapUsedBytes": 73346944,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 124.53599999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.5809999999992,
"styleRecalcs": 48,
"styleRecalcDurationMs": 3.9860000000000007,
"layouts": 10,
"layoutDurationMs": 2.197,
"taskDurationMs": 387.58500000000004,
"heapDeltaBytes": 763700,
"heapUsedBytes": 62684436,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 120.80799999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.2770000000305,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.9069999999999998,
"layouts": 10,
"layoutDurationMs": 1.9880000000000002,
"taskDurationMs": 458.008,
"heapDeltaBytes": 24287492,
"heapUsedBytes": 86192776,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7.626999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2011.3589999999704,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.6630000000000005,
"layouts": 9,
"layoutDurationMs": 1.7830000000000004,
"taskDurationMs": 456.7390000000001,
"heapDeltaBytes": 2894988,
"heapUsedBytes": 64411832,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 6.711,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.816000000008,
"styleRecalcs": 76,
"styleRecalcDurationMs": 9.898,
"layouts": 8,
"layoutDurationMs": 1.743,
"taskDurationMs": 679.326,
"heapDeltaBytes": 18320500,
"heapUsedBytes": 80669228,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 80.844,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.1799999999603,
"styleRecalcs": 76,
"styleRecalcDurationMs": 10.383,
"layouts": 9,
"layoutDurationMs": 1.888,
"taskDurationMs": 687.143,
"heapDeltaBytes": 18325756,
"heapUsedBytes": 80225388,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 80.471,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1403.1539999999723,
"styleRecalcs": 18,
"styleRecalcDurationMs": 18.122,
"layouts": 5,
"layoutDurationMs": 10.770999999999999,
"taskDurationMs": 904.037,
"heapDeltaBytes": 14121268,
"heapUsedBytes": 116213536,
"domNodes": 16030,
"jsHeapTotalBytes": 15863808,
"scriptDurationMs": 25.067999999999994,
"eventListeners": 3246,
"totalBlockingTimeMs": 139,
"frameDurationMs": 19.675000000000004,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8230.576999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.259,
"layouts": 8,
"layoutDurationMs": 1.543,
"taskDurationMs": 4897.070000000001,
"heapDeltaBytes": 2203928,
"heapUsedBytes": 75811436,
"domNodes": -257,
"jsHeapTotalBytes": 3497984,
"scriptDurationMs": 2132.333,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666194331983803,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8202.192999999967,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.479000000000003,
"layouts": 8,
"layoutDurationMs": 1.4929999999999999,
"taskDurationMs": 4962.130999999999,
"heapDeltaBytes": -4194332,
"heapUsedBytes": 70880364,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2139.5489999999995,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17055.361000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16409.04,
"heapDeltaBytes": -11634712,
"heapUsedBytes": 273269676,
"domNodes": -3343,
"jsHeapTotalBytes": 14409728,
"scriptDurationMs": 238.48200000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.395517241379306,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18337.090999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17428.513000000003,
"heapDeltaBytes": -2724640,
"heapUsedBytes": 274132360,
"domNodes": -3343,
"jsHeapTotalBytes": 8904704,
"scriptDurationMs": 274.272,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.284300341296927,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22289.47199999999,
"styleRecalcs": 176,
"styleRecalcDurationMs": 18.91899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21866.289,
"heapDeltaBytes": -8349944,
"heapUsedBytes": 267991368,
"domNodes": -3343,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 803.5709999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 40.91577981651376,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 22169.765000000098,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.748999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21790.496,
"heapDeltaBytes": -20091936,
"heapUsedBytes": 262434752,
"domNodes": -3343,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 822.949,
"eventListeners": -651,
"totalBlockingTimeMs": 5,
"frameDurationMs": 40.89630996309963,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6091.964999999959,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.73999999999998,
"layouts": 20,
"layoutDurationMs": 19.369999999999997,
"taskDurationMs": 5945.744,
"heapDeltaBytes": -42322180,
"heapUsedBytes": 249306196,
"domNodes": -3343,
"jsHeapTotalBytes": 19128320,
"scriptDurationMs": 86.03499999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.57309941520468,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6181.9869999999355,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.001999999999995,
"layouts": 20,
"layoutDurationMs": 20.873999999999988,
"taskDurationMs": 6040.570000000001,
"heapDeltaBytes": 3947300,
"heapUsedBytes": 280492704,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 139.733,
"eventListeners": -653,
"totalBlockingTimeMs": 9,
"frameDurationMs": 34.16022099447514,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8293.182,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7905.975000000001,
"heapDeltaBytes": -4341992,
"heapUsedBytes": 265617800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.49400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.88922558922559,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8408.79300000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8073.859000000002,
"heapDeltaBytes": 4425464,
"heapUsedBytes": 275037392,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.83400000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.165625000000002,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 446.77999999998974,
"styleRecalcs": 15,
"styleRecalcDurationMs": 7.76,
"layouts": 13,
"layoutDurationMs": 3.649,
"taskDurationMs": 112.93199999999999,
"heapDeltaBytes": 7009524,
"heapUsedBytes": 74536576,
"domNodes": 106,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.198,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 102.16700000000856,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.172000000000001,
"layouts": 8,
"layoutDurationMs": 2.4619999999999997,
"taskDurationMs": 71.084,
"heapDeltaBytes": 4595340,
"heapUsedBytes": 64116068,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.088,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 343.13299999996616,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.603,
"layouts": 76,
"layoutDurationMs": 13.119,
"taskDurationMs": 303.009,
"heapDeltaBytes": 11230068,
"heapUsedBytes": 48064272,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 142.375,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 299.1499999999405,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.506,
"layouts": 76,
"layoutDurationMs": 13.11,
"taskDurationMs": 257.17699999999996,
"heapDeltaBytes": -6068968,
"heapUsedBytes": 35819916,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 115.006,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 367.8250000000389,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.5839999999999999,
"layouts": 76,
"layoutDurationMs": 13.347,
"taskDurationMs": 335.65599999999995,
"heapDeltaBytes": -441436,
"heapUsedBytes": 92475968,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 127.90799999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 358.8120000000572,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.471,
"layouts": 76,
"layoutDurationMs": 13.288,
"taskDurationMs": 320.52400000000006,
"heapDeltaBytes": -804192,
"heapUsedBytes": 89149088,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 115.68900000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3125 passed, 0 failed · 2 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 37016afbf5d75b4a847d7edac15d255b0431a516
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (224)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22337 +/- ##
=============================================
Coverage ? 87.10%
=============================================
Files ? 3027
Lines ? 158500
Branches ? 42443
=============================================
Hits ? 138069
Misses ? 19755
Partials ? 676
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at 6865dc295c7c87acd613b030deeea557a2ac339e. The sole added callback-page blob is byte-identical to PR 22179's merged source, no package metadata changes, all 115 checks are terminal without failure, and there are no review threads.
Why
Local web SSO (#22179, on
core/1.58andcore/1.59) finishes sign-in in a popup that returns through/oauth/local-callback.htmlon Cloud; cloud#16930 registers that page as thecomfy-local-webredirect URI. The page ships in the frontend build, andcloud/1.59is the testcloud branch per cloud'sfrontend-version.json. It doesn't have the page, sostagingcloud.comfy.org/oauth/local-callback.htmlreturns 404 and local sign-in can't finish.Root cause
#22179 was backported only to the core branches; the Cloud-served half (
public/oauth/local-callback.html) never reached acloud/*branch.How
Adds only
public/oauth/local-callback.html, identical tomainat #22179's merge commit. It is a static page with no app code: it posts the callback query towindow.openerand closes. Nothing else in the Cloud app changes.AS IS / TO BE
AS IS:
/oauth/local-callback.htmlon stagingcloud → 404. TO BE: page served; local popup sign-in completes (verified against a stand-in issuer in #22179 / #22335).