Repository navigation
[backport cloud/1.58] FE-3099 feat(auth): serve the local web SSO callback page on Cloud - #22336
Conversation
Ships public/oauth/local-callback.html from #22179 on cloud/1.58 so stagingcloud and cloud serve it. cloud#16930 registers this page as the comfy-local-web redirect URI, and the local popup sign-in in core/1.58 and core/1.59 returns through it.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T01:54:17.331Z",
"gitSha": "d045d8602fffc9cbe1d08c05e888619ef018cf7b",
"branch": "backport-22179-callback-page-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.3349999999855,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.728,
"layouts": 9,
"layoutDurationMs": 2.5709999999999993,
"taskDurationMs": 569.0670000000001,
"heapDeltaBytes": -3650396,
"heapUsedBytes": 84255656,
"domNodes": -200,
"jsHeapTotalBytes": -2912256,
"scriptDurationMs": 8.448,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2033.7339999999813,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0260000000000002,
"layouts": 9,
"layoutDurationMs": 3.005,
"taskDurationMs": 438.30099999999993,
"heapDeltaBytes": -614728,
"heapUsedBytes": 86531024,
"domNodes": -201,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 11.090000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1833.1890000000044,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.248,
"layouts": 9,
"layoutDurationMs": 3.3859999999999997,
"taskDurationMs": 947.4560000000001,
"heapDeltaBytes": -2583276,
"heapUsedBytes": 85333944,
"domNodes": -200,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 164.898,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454548,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.0370000000462,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.733999999999998,
"layouts": 9,
"layoutDurationMs": 2.3209999999999997,
"taskDurationMs": 914.4700000000001,
"heapDeltaBytes": -24516956,
"heapUsedBytes": 78380284,
"domNodes": -200,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 160.135,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8214953271028,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.9060000000422,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.393,
"layouts": 12,
"layoutDurationMs": 3.661,
"taskDurationMs": 378.175,
"heapDeltaBytes": 24094672,
"heapUsedBytes": 115446624,
"domNodes": 47,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.208,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6673076923077,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.4069999999701,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.193,
"layouts": 10,
"layoutDurationMs": 3.432,
"taskDurationMs": 517.516,
"heapDeltaBytes": 21479020,
"heapUsedBytes": 112380080,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 17.929,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 664.7379999999998,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7359999999999998,
"layouts": 9,
"layoutDurationMs": 2.2970000000000006,
"taskDurationMs": 452.299,
"heapDeltaBytes": 299876,
"heapUsedBytes": 88123552,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 171.64499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 610.5380000000196,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0359999999999996,
"layouts": 9,
"layoutDurationMs": 2.757,
"taskDurationMs": 443.498,
"heapDeltaBytes": 539024,
"heapUsedBytes": 88241932,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 173.086,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.9089999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 915.6,
"heapDeltaBytes": -16246520,
"heapUsedBytes": 102593476,
"domNodes": -230,
"jsHeapTotalBytes": 15618048,
"scriptDurationMs": 69.908,
"eventListeners": -168,
"totalBlockingTimeMs": 520,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1299.855999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 942.921,
"heapDeltaBytes": -14120960,
"heapUsedBytes": 102520488,
"domNodes": -230,
"jsHeapTotalBytes": 16326656,
"scriptDurationMs": 79.581,
"eventListeners": -168,
"totalBlockingTimeMs": 583,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.962999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.9350000000002,
"heapDeltaBytes": 24185524,
"heapUsedBytes": 116967516,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.82199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 25.976470588235316,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.096999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.9179999999999,
"heapDeltaBytes": -3422064,
"heapUsedBytes": 97090172,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.541,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11578.20799999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10682.351,
"heapDeltaBytes": 48020072,
"heapUsedBytes": 174013880,
"domNodes": -296,
"jsHeapTotalBytes": 62533632,
"scriptDurationMs": 8588.62,
"eventListeners": -130,
"totalBlockingTimeMs": 1345,
"frameDurationMs": 31.51553133514986,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10910.009000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10153.093,
"heapDeltaBytes": 30583884,
"heapUsedBytes": 151534908,
"domNodes": -296,
"jsHeapTotalBytes": 35717120,
"scriptDurationMs": 8098.979,
"eventListeners": -130,
"totalBlockingTimeMs": 1376,
"frameDurationMs": 31.189428571428575,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10961.027000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10217.685,
"heapDeltaBytes": 29314228,
"heapUsedBytes": 132815408,
"domNodes": -296,
"jsHeapTotalBytes": 33959936,
"scriptDurationMs": 8163.380999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1173,
"frameDurationMs": 31.645953757225428,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10340.82699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9627.369,
"heapDeltaBytes": 46781508,
"heapUsedBytes": 160980360,
"domNodes": -276,
"jsHeapTotalBytes": 48115712,
"scriptDurationMs": 7666.526999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 944,
"frameDurationMs": 31.502743902439022,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 243.6749999999961,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.153,
"layouts": 11,
"layoutDurationMs": 3.1519999999999997,
"taskDurationMs": 189.36499999999998,
"heapDeltaBytes": 15482140,
"heapUsedBytes": 116679240,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.846,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 236.92199999999275,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.515,
"layouts": 11,
"layoutDurationMs": 3.4589999999999996,
"taskDurationMs": 194.89299999999997,
"heapDeltaBytes": 13189664,
"heapUsedBytes": 116887016,
"domNodes": 917,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.830999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2049.0589999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.496,
"layouts": 7,
"layoutDurationMs": 2.1589999999999994,
"taskDurationMs": 815.759,
"heapDeltaBytes": -16805144,
"heapUsedBytes": 102932744,
"domNodes": -276,
"jsHeapTotalBytes": -2490368,
"scriptDurationMs": 43.885000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2057.5589999999693,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.184,
"layouts": 7,
"layoutDurationMs": 2.097,
"taskDurationMs": 716.0849999999999,
"heapDeltaBytes": 120088,
"heapUsedBytes": 101977628,
"domNodes": -296,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 34.87699999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2918.746999999996,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.467999999999998,
"layouts": 5,
"layoutDurationMs": 1.3000000000000003,
"taskDurationMs": 1917.5530000000003,
"heapDeltaBytes": 2299040,
"heapUsedBytes": 104551908,
"domNodes": -296,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 906.439,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2325.2570000000787,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.552999999999997,
"layouts": 4,
"layoutDurationMs": 1.0679999999999998,
"taskDurationMs": 1664.489,
"heapDeltaBytes": -2154888,
"heapUsedBytes": 103722108,
"domNodes": -296,
"jsHeapTotalBytes": -417792,
"scriptDurationMs": 858.8169999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.030656934306567,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3571.527000000003,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.242999999999999,
"layouts": 64,
"layoutDurationMs": 10.920000000000002,
"taskDurationMs": 1733.645,
"heapDeltaBytes": -18018200,
"heapUsedBytes": 90949380,
"domNodes": -272,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 808.328,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3741.8720000000576,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.865,
"layouts": 64,
"layoutDurationMs": 11.146,
"taskDurationMs": 1843.9579999999999,
"heapDeltaBytes": -6915820,
"heapUsedBytes": 97197088,
"domNodes": -252,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 863.348,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.740624999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3240.011999999979,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.795,
"layouts": 4,
"layoutDurationMs": 1.4500000000000004,
"taskDurationMs": 2038.832,
"heapDeltaBytes": -7223768,
"heapUsedBytes": 98772120,
"domNodes": 0,
"jsHeapTotalBytes": 1732608,
"scriptDurationMs": 1101.375,
"eventListeners": 182,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.104736842105265,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3571.6549999999643,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.531000000000001,
"layouts": 3,
"layoutDurationMs": 0.8309999999999997,
"taskDurationMs": 2361.797,
"heapDeltaBytes": -12532752,
"heapUsedBytes": 97656296,
"domNodes": -296,
"jsHeapTotalBytes": 15966208,
"scriptDurationMs": 1114.339,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.98333333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.1199999999876,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1279999999999997,
"layouts": 7,
"layoutDurationMs": 2.0149999999999992,
"taskDurationMs": 707.6179999999998,
"heapDeltaBytes": -146320,
"heapUsedBytes": 110180888,
"domNodes": -296,
"jsHeapTotalBytes": -1662976,
"scriptDurationMs": 36.244,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.3490000000347,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.575999999999999,
"layouts": 7,
"layoutDurationMs": 2.1529999999999996,
"taskDurationMs": 657.3459999999999,
"heapDeltaBytes": 6697808,
"heapUsedBytes": 108842984,
"domNodes": -276,
"jsHeapTotalBytes": -6488064,
"scriptDurationMs": 42.44899999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 662.8770000000372,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.218,
"layouts": 9,
"layoutDurationMs": 2.6069999999999998,
"taskDurationMs": 466.3539999999999,
"heapDeltaBytes": 22411992,
"heapUsedBytes": 114447156,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 144.235,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.1100000000633,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.922999999999999,
"layouts": 9,
"layoutDurationMs": 2.8190000000000004,
"taskDurationMs": 435.247,
"heapDeltaBytes": 25513008,
"heapUsedBytes": 115151684,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 155.381,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2056.128000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.132,
"layouts": 9,
"layoutDurationMs": 2.766,
"taskDurationMs": 619.008,
"heapDeltaBytes": -1909568,
"heapUsedBytes": 90278032,
"domNodes": -198,
"jsHeapTotalBytes": 3289088,
"scriptDurationMs": 9.626999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2041.3650000000416,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.404,
"layouts": 10,
"layoutDurationMs": 3.104,
"taskDurationMs": 459.68299999999994,
"heapDeltaBytes": 11499000,
"heapUsedBytes": 100952012,
"domNodes": -198,
"jsHeapTotalBytes": -3342336,
"scriptDurationMs": 9.613,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2009.588000000008,
"styleRecalcs": 87,
"styleRecalcDurationMs": 17.159,
"layouts": 9,
"layoutDurationMs": 2.6989999999999994,
"taskDurationMs": 1083.333,
"heapDeltaBytes": -1971980,
"heapUsedBytes": 87972768,
"domNodes": -210,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 128.87199999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.4239999999909,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.997000000000002,
"layouts": 9,
"layoutDurationMs": 2.2900000000000005,
"taskDurationMs": 789.525,
"heapDeltaBytes": 9312672,
"heapUsedBytes": 101914004,
"domNodes": -218,
"jsHeapTotalBytes": 7221248,
"scriptDurationMs": 112.70200000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666981132075474,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1467.691000000002,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.399000000000008,
"layouts": 5,
"layoutDurationMs": 18.107000000000006,
"taskDurationMs": 986.14,
"heapDeltaBytes": 35864080,
"heapUsedBytes": 140003240,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 36.026999999999994,
"eventListeners": 3244,
"totalBlockingTimeMs": 202,
"frameDurationMs": 20.599999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8605.056999999988,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.352999999999998,
"layouts": 7,
"layoutDurationMs": 2.2500000000000004,
"taskDurationMs": 5794.28,
"heapDeltaBytes": 7329228,
"heapUsedBytes": 113510404,
"domNodes": -296,
"jsHeapTotalBytes": -974848,
"scriptDurationMs": 2960.332,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.730994152046783,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8446.010999999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.763,
"layouts": 7,
"layoutDurationMs": 1.8970000000000002,
"taskDurationMs": 5831.134000000001,
"heapDeltaBytes": 241044,
"heapUsedBytes": 103880228,
"domNodes": -296,
"jsHeapTotalBytes": -712704,
"scriptDurationMs": 2889.2599999999998,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.765208747514908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23037.39999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22570.290999999997,
"heapDeltaBytes": -29733112,
"heapUsedBytes": 299493476,
"domNodes": -3348,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 320.13,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.05652173913043,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 25039.806999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24366.425999999996,
"heapDeltaBytes": 259487428,
"heapUsedBytes": 611323596,
"domNodes": -3344,
"jsHeapTotalBytes": 265277440,
"scriptDurationMs": 393.32,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.657242582897034,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 20212.66800000001,
"styleRecalcs": 154,
"styleRecalcDurationMs": 17.15899999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19817.84,
"heapDeltaBytes": 3564876,
"heapUsedBytes": 304019136,
"domNodes": -3344,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 878.937,
"eventListeners": -651,
"totalBlockingTimeMs": 29,
"frameDurationMs": 37.336783733826245,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 29046.982999999957,
"styleRecalcs": 181,
"styleRecalcDurationMs": 25.59700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28780.786999999997,
"heapDeltaBytes": -40918860,
"heapUsedBytes": 288287340,
"domNodes": -3344,
"jsHeapTotalBytes": 8638464,
"scriptDurationMs": 944.982,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 54.98522727272727,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8196.208000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.275,
"layouts": 20,
"layoutDurationMs": 21.590999999999998,
"taskDurationMs": 8069.580999999999,
"heapDeltaBytes": -9140048,
"heapUsedBytes": 296845516,
"domNodes": -3344,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 126.43599999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.58920454545455,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6421.850000000063,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.88900000000001,
"layouts": 20,
"layoutDurationMs": 29.822000000000017,
"taskDurationMs": 6365.246999999999,
"heapDeltaBytes": -9031600,
"heapUsedBytes": 302011668,
"domNodes": -3344,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 121.78999999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.25084745762711,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12045.304999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11703.253,
"heapDeltaBytes": 14549136,
"heapUsedBytes": 287179060,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.67899999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.81636363636365,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11901.91900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11637.211000000001,
"heapDeltaBytes": -4378108,
"heapUsedBytes": 281024556,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.01200000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.958483754512635,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 142.12700000001632,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.838,
"layouts": 9,
"layoutDurationMs": 4.33,
"taskDurationMs": 107.024,
"heapDeltaBytes": 4994352,
"heapUsedBytes": 106006476,
"domNodes": 124,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 12.439,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.057142857142935,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "workflow-execution",
"durationMs": 447.4390000000312,
"styleRecalcs": 14,
"styleRecalcDurationMs": 12.959,
"layouts": 12,
"layoutDurationMs": 4.402,
"taskDurationMs": 112.405,
"heapDeltaBytes": -17950200,
"heapUsedBytes": 94037360,
"domNodes": 95,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.916000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 585.7929999999669,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.754,
"layouts": 76,
"layoutDurationMs": 18.183999999999997,
"taskDurationMs": 541.018,
"heapDeltaBytes": 13093380,
"heapUsedBytes": 84221932,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 258.46799999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669444444444455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 544.856999999979,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1019999999999999,
"layouts": 76,
"layoutDurationMs": 18.401,
"taskDurationMs": 498.50700000000006,
"heapDeltaBytes": 12462924,
"heapUsedBytes": 83160904,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 232.79500000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 689.5849999999655,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.467,
"layouts": 76,
"layoutDurationMs": 17.778,
"taskDurationMs": 646.895,
"heapDeltaBytes": 2215972,
"heapUsedBytes": 121215660,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 268.287,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.070731707317066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 679.033000000004,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.4859999999999998,
"layouts": 76,
"layoutDurationMs": 16.912,
"taskDurationMs": 644.8549999999999,
"heapDeltaBytes": 1547340,
"heapUsedBytes": 119019540,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 262.11999999999995,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2986 passed, 0 failed · 3 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 34ca0df24653f46d563bd89d14e36ef914e8ac78
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (140)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22336 +/- ##
=============================================
Coverage ? 84.22%
=============================================
Files ? 3172
Lines ? 165365
Branches ? 41500
=============================================
Hits ? 139281
Misses ? 25693
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at 206075c2b64580d553fc7bea147df73951e9050f. The sole added callback-page blob is byte-identical to PR 22179's merged source, no package metadata changes, all 130 checks are terminal without failure, and there are no review threads.
Why
Local web SSO (#22179, on
core/1.58andcore/1.59) finishes sign-in in a popup that returns through/oauth/local-callback.htmlon Cloud; cloud#16930 registers that page as thecomfy-local-webredirect URI. The page ships in the frontend build, andcloud/1.58is the release branch (stagingcloud and cloud) per cloud'sfrontend-version.json. It doesn't have the page, sostagingcloud.comfy.org/oauth/local-callback.htmlreturns 404 and local sign-in can't finish.Root cause
#22179 was backported only to the core branches; the Cloud-served half (
public/oauth/local-callback.html) never reached acloud/*branch.How
Adds only
public/oauth/local-callback.html, identical tomainat #22179's merge commit. It is a static page with no app code: it posts the callback query towindow.openerand closes. Nothing else in the Cloud app changes.AS IS / TO BE
AS IS:
/oauth/local-callback.htmlon stagingcloud → 404. TO BE: page served; local popup sign-in completes (verified against a stand-in issuer in #22179 / #22335).