Skip to content

[backport cloud/1.58] fix(agent): refresh node definitions when ComfyUI reconnects after an agent restart (#21644) - #22050

Merged
comfy-pr-bot merged 3 commits into
cloud/1.58from
backport-21644-to-cloud-1.58
Oct 27, 2026
Merged

comfy-pr-bot merged 3 commits into
cloud/1.58from
backport-21644-to-cloud-1.58

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #21644 to cloud/1.58.

Full context for agent readers

Auto-backport was not used: the cherry-pick conflicts on browser_tests/tests/agent/agentRestartNodeRefresh.spec.ts, which #21044 added on main after the 1.58 cut. Resolved by taking main's version of the spec plus browser_tests/assets/agent/restart_node_refresh.json (from #21044). All its imports exist on this branch.

The four src/workbench/extensions/agent files applied cleanly.

Verification on this branch (Node 26.8.2):

  • agentNodeDefinitionRefreshStore.test.ts: 6 tests red with the branch's old store, green with the fix (16/16)
  • AgentPanelRoot.test.ts + store test: 477/477
  • pnpm typecheck clean, eslint/oxfmt clean on touched files

Not included: #21841 (catalog-refresh model warnings), a separate fix.

Refs https://linear.app/comfyorg/issue/PM-2119, https://linear.app/comfyorg/issue/BE-21866

… agent restart (#21644)

Nodes the local agent installs show as missing after it restarts
ComfyUI. Since comfy-agent 0.1.0-rc2
([cloud#14617](Comfy-Org/cloud#14617)) a
successful `restart_comfyui` only schedules the restart: the agent
reports `success` while the old ComfyUI is still serving and restarts it
after the turn ends. The refresh store from #20903 fetched
`/object_info` on that frame, read the old catalog, cleared its stale
flag, and ignored the reconnect that followed.

The store now marks definitions stale on the `success` frame and
refreshes on the next `/ws` `reconnected`. A failed refresh still
retries on the following reconnect. Restarts the panel never sees (panel
closed, user or Desktop restarts) stay out of scope, as in FE-3483.

Refs BE-21866 (the regression is recorded in its 2026-10-22 comment).

- **Reproduced on the shipping stack, 2 of 2 runs:** published
`comfy-agent[go-nonfree]==0.1.0rc2` on Linux x86_64, ComfyUI master
`46aad33e` with `--enable-agent --enable-manager`, frontend `v1.59.0`.
Each time the agent wrote and installed a one-node pack, I picked
Restart ComfyUI on the card, and the agent then placed the node. The
page fetched `/object_info` about 1 s after the card answer, before the
restart (no new class in it). It fetched nothing after `reconnected`.
The placed node rendered as a red missing type with no widgets. Refresh
Node Definitions registered the class, but the placed node stayed broken
until a page reload.
- **Same flow on this branch** (production build of this head, served
with `--front-end-root`): nothing is fetched at the card answer.
`/object_info` is fetched about 1 s after `reconnected` and contains the
new class. The agent-placed node renders with its widget and no error.
- **Browser test:** `agentRestartNodeRefresh.spec.ts` now delivers the
restart while the old definitions are served, then drops and reopens
`/ws` with the new node defined. On the parent it fails: `hasErrors:
true, hasStepsWidget: false`. With this change it passes.
- **Unit:** the store tests now reconnect after a restart. The first
case, which checks that nothing refreshes until ComfyUI reconnects,
fails on the parent.
- typecheck, typecheck:browser, oxlint, oxfmt, plus the pre-commit and
pre-push hooks pass.

(cherry picked from commit 3821a0a)
@christian-byrne
christian-byrne requested a review from a team as a code owner October 27, 2026 04:34
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 27, 2026
@christian-byrne
christian-byrne requested review from a team as code owners October 27, 2026 04:34
@christian-byrne christian-byrne self-assigned this Oct 27, 2026
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.8 MB heap
dom-widget-order-dense-n200-w200-i120: · 36.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 326ms TBT · 97.4 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 47.3 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 100ms TBT · 91.1 MB heap
extension-clean-combined-draw: · 46.8 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 69ms TBT · 121.3 MB heap
extension-rgthree-prototype-draw: · 45.7 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 58ms TBT · 115.2 MB heap
large-combo-open: · 46.7 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 113.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 108.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.1 MB heap
legacy-node-drag: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 111.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 100.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.7 MB heap
subgraph-transition-enter: · 49.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 109ms TBT · 134.1 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 107.7 MB heap
vue-large-graph-idle: · 40.7 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 262.4 MB heap
vue-large-graph-pan: · 36.4 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 38ms TBT · 277.4 MB heap
vue-node-resize-workload: · 38.4 avg FPS · 17.2 P5 FPS ❌ (target: ≥52) · 0ms TBT · 281.5 MB heap
vue-zoom-out-idle: · 39.9 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 379.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.0 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.1 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 111.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 11
canvas-idle: style recalc count 11
canvas-idle: task duration 413ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 86.6 MB
canvas-idle: DOM nodes -180
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 10ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 772ms
canvas-mouse-sweep: script duration 105ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 81.8 MB
canvas-mouse-sweep: DOM nodes -200
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 4ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 278ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 97.2 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 2ms
dom-widget-clipping: layout count 11
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 331ms
dom-widget-clipping: script duration 105ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 97.8 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 27ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 620ms
dom-widget-order-dense-n200-w200-i120: script duration 41ms
dom-widget-order-dense-n200-w200-i120: TBT 326ms
dom-widget-order-dense-n200-w200-i120: heap used 97.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -221
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 292ms
dom-widget-order-sparse-n1000-w20-i120: script duration 94ms
dom-widget-order-sparse-n1000-w20-i120: TBT 100ms
dom-widget-order-sparse-n1000-w20-i120: heap used 91.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 21ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 4
extension-clean-combined-draw: style recalc count 4
extension-clean-combined-draw: task duration 5416ms
extension-clean-combined-draw: script duration 4110ms
extension-clean-combined-draw: TBT 69ms
extension-clean-combined-draw: heap used 121.3 MB
extension-clean-combined-draw: DOM nodes -289
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 22ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 1ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 4
extension-rgthree-prototype-draw: style recalc count 4
extension-rgthree-prototype-draw: task duration 5376ms
extension-rgthree-prototype-draw: script duration 4099ms
extension-rgthree-prototype-draw: TBT 58ms
extension-rgthree-prototype-draw: heap used 115.2 MB
extension-rgthree-prototype-draw: DOM nodes -296
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 50ms
large-combo-open: layout duration 2ms
large-combo-open: style recalc duration 11ms
large-combo-open: layout count 12
large-combo-open: style recalc count 21
large-combo-open: task duration 107ms
large-combo-open: script duration 6ms
large-combo-open: TBT 0ms
large-combo-open: heap used 113.0 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 9
large-graph-idle: style recalc count 10
large-graph-idle: task duration 430ms
large-graph-idle: script duration 27ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 103.2 MB
large-graph-idle: DOM nodes -296
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 3ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 9
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1098ms
large-graph-pan: script duration 519ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 108.0 MB
large-graph-pan: DOM nodes -287
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 67
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1192ms
large-graph-zoom: script duration 527ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 87.1 MB
large-graph-zoom: DOM nodes -265
large-graph-zoom: event listeners -130
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 8
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1340ms
legacy-node-drag: script duration 618ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 111.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 9
minimap-idle: style recalc count 10
minimap-idle: task duration 422ms
minimap-idle: script duration 27ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.4 MB
minimap-idle: DOM nodes -286
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 4ms
subgraph-dom-widget-clipping: layout count 11
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 318ms
subgraph-dom-widget-clipping: script duration 100ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 101.3 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 11
subgraph-idle: task duration 335ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 100.4 MB
subgraph-idle: DOM nodes -99
subgraph-idle: event listeners -88
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 9ms
subgraph-mouse-sweep: layout count 11
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 540ms
subgraph-mouse-sweep: script duration 66ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 88.7 MB
subgraph-mouse-sweep: DOM nodes -105
subgraph-mouse-sweep: event listeners -84
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 17ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 563ms
subgraph-transition-enter: script duration 20ms
subgraph-transition-enter: TBT 109ms
subgraph-transition-enter: heap used 134.1 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 26ms
viewport-pan-sweep: layout count 10
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 3785ms
viewport-pan-sweep: script duration 1762ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 107.7 MB
viewport-pan-sweep: DOM nodes -296
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 25ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13540ms
vue-large-graph-idle: script duration 173ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 262.4 MB
vue-large-graph-idle: DOM nodes -3344
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 28ms
vue-large-graph-pan: p95 frame time 58ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 105
vue-large-graph-pan: task duration 15063ms
vue-large-graph-pan: script duration 714ms
vue-large-graph-pan: TBT 38ms
vue-large-graph-pan: heap used 277.4 MB
vue-large-graph-pan: DOM nodes -3344
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 26ms
vue-node-resize-workload: p95 frame time 58ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 43ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4487ms
vue-node-resize-workload: script duration 90ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 281.5 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 25ms
vue-zoom-out-idle: p95 frame time 50ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7055ms
vue-zoom-out-idle: script duration 88ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 379.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 8ms
workflow-execution: layout count 10
workflow-execution: style recalc count 15
workflow-execution: task duration 104ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 95.0 MB
workflow-execution: DOM nodes 110
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 11ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 203ms
agent-composer-empty-conversation-typing: script duration 89ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 92.1 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 11ms
agent-composer-long-conversation-typing: style recalc duration 1ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 252ms
agent-composer-long-conversation-typing: script duration 90ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 111.6 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-27T14:49:22.306Z",
  "gitSha": "327dc12dd144e379213a7b0e5d8b68e60ac2b7c6",
  "branch": "backport-21644-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2028.2550000000015,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.234,
      "layouts": 10,
      "layoutDurationMs": 2.209,
      "taskDurationMs": 401.357,
      "heapDeltaBytes": 7399792,
      "heapUsedBytes": 97597532,
      "domNodes": -180,
      "jsHeapTotalBytes": 1892352,
      "scriptDurationMs": 7.962999999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2027.0510000000286,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 1.925,
      "layouts": 11,
      "layoutDurationMs": 1.9240000000000002,
      "taskDurationMs": 424.59900000000005,
      "heapDeltaBytes": -20329648,
      "heapUsedBytes": 84098688,
      "domNodes": -180,
      "jsHeapTotalBytes": 1118208,
      "scriptDurationMs": 8.199,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1976.2830000000235,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 10.837000000000002,
      "layouts": 9,
      "layoutDurationMs": 1.6350000000000002,
      "taskDurationMs": 883.214,
      "heapDeltaBytes": -2060900,
      "heapUsedBytes": 88226332,
      "domNodes": -200,
      "jsHeapTotalBytes": 1368064,
      "scriptDurationMs": 108.47800000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665546218487393,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1717.691000000002,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 9.364,
      "layouts": 9,
      "layoutDurationMs": 1.6780000000000002,
      "taskDurationMs": 660.4559999999999,
      "heapDeltaBytes": -6037868,
      "heapUsedBytes": 83341500,
      "domNodes": -200,
      "jsHeapTotalBytes": -2289664,
      "scriptDurationMs": 102.458,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66504854368932,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.4580000000074,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 3.618,
      "layouts": 12,
      "layoutDurationMs": 2.119,
      "taskDurationMs": 274.154,
      "heapDeltaBytes": 25422940,
      "heapUsedBytes": 115189448,
      "domNodes": 47,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 9.379999999999999,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1710.0160000000528,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 3.9839999999999995,
      "layouts": 12,
      "layoutDurationMs": 2.309,
      "taskDurationMs": 282.49399999999997,
      "heapDeltaBytes": -1772712,
      "heapUsedBytes": 88559640,
      "domNodes": 47,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 10.077,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 433.66200000002664,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 1.9989999999999994,
      "layouts": 11,
      "layoutDurationMs": 1.939,
      "taskDurationMs": 287.31600000000003,
      "heapDeltaBytes": 3236064,
      "heapUsedBytes": 93965808,
      "domNodes": 0,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 103.1,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669230769230772,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 557.5560000000337,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 1.8510000000000002,
      "layouts": 10,
      "layoutDurationMs": 1.6189999999999998,
      "taskDurationMs": 374.324,
      "heapDeltaBytes": 6449936,
      "heapUsedBytes": 111187688,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 107.874,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66470588235295,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 986.3630000000114,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 632.9509999999999,
      "heapDeltaBytes": -16270480,
      "heapUsedBytes": 102543536,
      "domNodes": -230,
      "jsHeapTotalBytes": 15007744,
      "scriptDurationMs": 40.22599999999999,
      "eventListeners": -168,
      "totalBlockingTimeMs": 326,
      "frameDurationMs": 27.313888888888894,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 957.9059999999799,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 607.723,
      "heapDeltaBytes": -15344524,
      "heapUsedBytes": 101739132,
      "domNodes": -211,
      "jsHeapTotalBytes": 16318464,
      "scriptDurationMs": 42.589999999999996,
      "eventListeners": -168,
      "totalBlockingTimeMs": 325,
      "frameDurationMs": 27.61714285714284,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 715.9489999999948,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 315.2379999999999,
      "heapDeltaBytes": -1814084,
      "heapUsedBytes": 94297508,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 101.517,
      "eventListeners": 0,
      "totalBlockingTimeMs": 105,
      "frameDurationMs": 21.076470588235278,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 701.6089999999622,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 268.2739999999999,
      "heapDeltaBytes": -3529312,
      "heapUsedBytes": 96751636,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 86.40999999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 95,
      "frameDurationMs": 21.21212121212121,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6495.6320000000005,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.5989999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.588,
      "taskDurationMs": 5555.818,
      "heapDeltaBytes": 15483228,
      "heapUsedBytes": 119487908,
      "domNodes": -302,
      "jsHeapTotalBytes": 19456000,
      "scriptDurationMs": 4109.61,
      "eventListeners": -130,
      "totalBlockingTimeMs": 71,
      "frameDurationMs": 21.295098039215684,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6151.547999999992,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.7790000000000001,
      "layouts": 4,
      "layoutDurationMs": 0.8089999999999998,
      "taskDurationMs": 5276.929,
      "heapDeltaBytes": 25064060,
      "heapUsedBytes": 134926140,
      "domNodes": -276,
      "jsHeapTotalBytes": 21815296,
      "scriptDurationMs": 4110.351,
      "eventListeners": -130,
      "totalBlockingTimeMs": 66,
      "frameDurationMs": 21.444055944055947,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6091.953999999987,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.6039999999999995,
      "layouts": 3,
      "layoutDurationMs": 0.575,
      "taskDurationMs": 5247.691000000001,
      "heapDeltaBytes": 4593468,
      "heapUsedBytes": 116422440,
      "domNodes": -296,
      "jsHeapTotalBytes": 16666624,
      "scriptDurationMs": 4091.4190000000003,
      "eventListeners": -130,
      "totalBlockingTimeMs": 82,
      "frameDurationMs": 22.592222222222226,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6457.290000000001,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.7660000000000002,
      "layouts": 4,
      "layoutDurationMs": 0.7160000000000003,
      "taskDurationMs": 5503.4259999999995,
      "heapDeltaBytes": 15612848,
      "heapUsedBytes": 125149412,
      "domNodes": -296,
      "jsHeapTotalBytes": 24174592,
      "scriptDurationMs": 4106.924,
      "eventListeners": -130,
      "totalBlockingTimeMs": 34,
      "frameDurationMs": 21.146885245901636,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "large-combo-open",
      "durationMs": 148.63399999998705,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 10.997,
      "layouts": 12,
      "layoutDurationMs": 2.3489999999999998,
      "taskDurationMs": 107.723,
      "heapDeltaBytes": 13409748,
      "heapUsedBytes": 118339940,
      "domNodes": 917,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 6.193999999999999,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.428571428571427,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 154.11499999999023,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 10.408000000000001,
      "layouts": 11,
      "layoutDurationMs": 2.215,
      "taskDurationMs": 106.30099999999997,
      "heapDeltaBytes": 13237004,
      "heapUsedBytes": 118737788,
      "domNodes": 917,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 6.6049999999999995,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.428571428571427,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.1380000000227,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.8529999999999995,
      "layouts": 9,
      "layoutDurationMs": 1.952,
      "taskDurationMs": 497.62100000000004,
      "heapDeltaBytes": -16115884,
      "heapUsedBytes": 106716832,
      "domNodes": -296,
      "jsHeapTotalBytes": 974848,
      "scriptDurationMs": 31.828000000000003,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.4819999999636,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.5380000000000003,
      "layouts": 9,
      "layoutDurationMs": 1.4729999999999999,
      "taskDurationMs": 361.501,
      "heapDeltaBytes": -155204,
      "heapUsedBytes": 109807016,
      "domNodes": -296,
      "jsHeapTotalBytes": -1253376,
      "scriptDurationMs": 22.700000000000006,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2134.213999999986,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.021999999999998,
      "layouts": 9,
      "layoutDurationMs": 2.1,
      "taskDurationMs": 1088.253,
      "heapDeltaBytes": 1593304,
      "heapUsedBytes": 113232084,
      "domNodes": -297,
      "jsHeapTotalBytes": -765952,
      "scriptDurationMs": 542.269,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666141732283467,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2133.1129999999803,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 6.314000000000001,
      "layouts": 9,
      "layoutDurationMs": 4.614,
      "taskDurationMs": 1107.507,
      "heapDeltaBytes": 1594480,
      "heapUsedBytes": 113216888,
      "domNodes": -276,
      "jsHeapTotalBytes": 20480,
      "scriptDurationMs": 496.623,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666141732283464,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3173.673000000008,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 9.627,
      "layouts": 67,
      "layoutDurationMs": 10.505,
      "taskDurationMs": 1174.174,
      "heapDeltaBytes": -22277896,
      "heapUsedBytes": 91260456,
      "domNodes": -272,
      "jsHeapTotalBytes": 188416,
      "scriptDurationMs": 520.83,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684207,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3160.105000000044,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 9.463000000000001,
      "layouts": 67,
      "layoutDurationMs": 10.097,
      "taskDurationMs": 1209.305,
      "heapDeltaBytes": -21175672,
      "heapUsedBytes": 91500384,
      "domNodes": -258,
      "jsHeapTotalBytes": -335872,
      "scriptDurationMs": 532.399,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66578947368421,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2219.585000000052,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.952000000000001,
      "layouts": 7,
      "layoutDurationMs": 1.219,
      "taskDurationMs": 1391.546,
      "heapDeltaBytes": 6887360,
      "heapUsedBytes": 110050084,
      "domNodes": 0,
      "jsHeapTotalBytes": 3411968,
      "scriptDurationMs": 641.2529999999999,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.793893129770993,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2193.4759999999756,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.289,
      "layouts": 8,
      "layoutDurationMs": 1.282,
      "taskDurationMs": 1287.971,
      "heapDeltaBytes": 17405992,
      "heapUsedBytes": 124284588,
      "domNodes": 0,
      "jsHeapTotalBytes": 5402624,
      "scriptDurationMs": 594.1769999999999,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665648854961834,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.6799999999803,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.7039999999999997,
      "layouts": 9,
      "layoutDurationMs": 1.6039999999999999,
      "taskDurationMs": 453.76,
      "heapDeltaBytes": -34450324,
      "heapUsedBytes": 89932900,
      "domNodes": -296,
      "jsHeapTotalBytes": -1110016,
      "scriptDurationMs": 26.566999999999997,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2053.7630000000036,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.8409999999999997,
      "layouts": 9,
      "layoutDurationMs": 1.911,
      "taskDurationMs": 389.85999999999996,
      "heapDeltaBytes": -26053940,
      "heapUsedBytes": 86964384,
      "domNodes": -276,
      "jsHeapTotalBytes": -2301952,
      "scriptDurationMs": 28.109999999999996,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 516.0209999999665,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 4.035,
      "layouts": 10,
      "layoutDurationMs": 1.8079999999999996,
      "taskDurationMs": 314.03000000000003,
      "heapDeltaBytes": 802420,
      "heapUsedBytes": 102606864,
      "domNodes": 0,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 99.01800000000001,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664516129032254,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 497.9250000000093,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 4.579,
      "layouts": 11,
      "layoutDurationMs": 1.99,
      "taskDurationMs": 322.184,
      "heapDeltaBytes": 3148656,
      "heapUsedBytes": 109862568,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 101.28300000000002,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2026.994000000002,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 1.7350000000000003,
      "layouts": 10,
      "layoutDurationMs": 1.943,
      "taskDurationMs": 319.222,
      "heapDeltaBytes": 12152536,
      "heapUsedBytes": 103007448,
      "domNodes": -198,
      "jsHeapTotalBytes": 1105920,
      "scriptDurationMs": 7.3130000000000015,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664754098360653,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2011.132000000032,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.692,
      "layouts": 10,
      "layoutDurationMs": 1.6959999999999997,
      "taskDurationMs": 350.95099999999996,
      "heapDeltaBytes": 6172976,
      "heapUsedBytes": 107616180,
      "domNodes": 0,
      "jsHeapTotalBytes": 9175040,
      "scriptDurationMs": 6.055,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1695.543999999984,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 9.634,
      "layouts": 10,
      "layoutDurationMs": 1.525,
      "taskDurationMs": 516.6469999999999,
      "heapDeltaBytes": -921568,
      "heapUsedBytes": 90436036,
      "domNodes": -210,
      "jsHeapTotalBytes": 2154496,
      "scriptDurationMs": 66.761,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665686274509806,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1676.8780000000447,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 8.982000000000001,
      "layouts": 11,
      "layoutDurationMs": 1.719,
      "taskDurationMs": 563.2870000000001,
      "heapDeltaBytes": -6837132,
      "heapUsedBytes": 95488608,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 65.599,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667326732673267,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 815.9330000000296,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 16.883000000000003,
      "layouts": 5,
      "layoutDurationMs": 9.443999999999999,
      "taskDurationMs": 563.404,
      "heapDeltaBytes": 35818984,
      "heapUsedBytes": 140650972,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16654336,
      "scriptDurationMs": 20.230000000000004,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 109,
      "frameDurationMs": 20.41500000000001,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8141.017999999975,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 26.163,
      "layouts": 9,
      "layoutDurationMs": 1.6340000000000001,
      "taskDurationMs": 3590.469,
      "heapDeltaBytes": 2172668,
      "heapUsedBytes": 113114996,
      "domNodes": -296,
      "jsHeapTotalBytes": -241664,
      "scriptDurationMs": 1785.9150000000002,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.700205338809035,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8203.737999999987,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 25.218999999999998,
      "layouts": 10,
      "layoutDurationMs": 1.477,
      "taskDurationMs": 3979.671,
      "heapDeltaBytes": 1287456,
      "heapUsedBytes": 112701580,
      "domNodes": -296,
      "jsHeapTotalBytes": 544768,
      "scriptDurationMs": 1737.293,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.700000000000003,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14637.298999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13801.348,
      "heapDeltaBytes": -56972348,
      "heapUsedBytes": 272112872,
      "domNodes": -3344,
      "jsHeapTotalBytes": 20697088,
      "scriptDurationMs": 176.047,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.67571669477234,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14179.164000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13278.554,
      "heapDeltaBytes": -32901632,
      "heapUsedBytes": 278228672,
      "domNodes": -3344,
      "jsHeapTotalBytes": 27250688,
      "scriptDurationMs": 170.246,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.411015490533565,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13441.931000000011,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.63900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12892.385,
      "heapDeltaBytes": -42051864,
      "heapUsedBytes": 288623592,
      "domNodes": -3344,
      "jsHeapTotalBytes": 28037120,
      "scriptDurationMs": 748.578,
      "eventListeners": -651,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 23.309358752166382,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17744.21599999994,
      "styleRecalcs": 142,
      "styleRecalcDurationMs": 16.77300000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17233.762,
      "heapDeltaBytes": -37228216,
      "heapUsedBytes": 293140808,
      "domNodes": -3344,
      "jsHeapTotalBytes": 15454208,
      "scriptDurationMs": 679.932,
      "eventListeners": -651,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 31.695,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5208.803999999986,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 43.26100000000001,
      "layouts": 20,
      "layoutDurationMs": 21.201999999999998,
      "taskDurationMs": 5077.951000000001,
      "heapDeltaBytes": -18507160,
      "heapUsedBytes": 287082688,
      "domNodes": -3344,
      "jsHeapTotalBytes": 26726400,
      "scriptDurationMs": 86.97200000000001,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.544886363636362,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4062.7940000000535,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 42.13599999999998,
      "layouts": 20,
      "layoutDurationMs": 20.839999999999996,
      "taskDurationMs": 3895.1110000000003,
      "heapDeltaBytes": -9118424,
      "heapUsedBytes": 303324056,
      "domNodes": -3344,
      "jsHeapTotalBytes": 29872128,
      "scriptDurationMs": 93.631,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.498888888888885,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7434.361000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7086.057000000001,
      "heapDeltaBytes": -21496148,
      "heapUsedBytes": 496202652,
      "domNodes": 0,
      "jsHeapTotalBytes": -35651584,
      "scriptDurationMs": 92.94799999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.027272727272724,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7480.25599999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7023.263000000002,
      "heapDeltaBytes": -4177188,
      "heapUsedBytes": 299117680,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 83.239,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.055033557046972,
      "p95FrameDurationMs": 50
    },
    {
      "name": "workflow-execution",
      "durationMs": 482.47700000001714,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 8.989,
      "layouts": 12,
      "layoutDurationMs": 3.522,
      "taskDurationMs": 146.18200000000002,
      "heapDeltaBytes": -9238860,
      "heapUsedBytes": 92352080,
      "domNodes": 126,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 12.265,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668965517241368,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 92.50599999995757,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.52,
      "layouts": 8,
      "layoutDurationMs": 2.304,
      "taskDurationMs": 62.137000000000015,
      "heapDeltaBytes": 4648852,
      "heapUsedBytes": 106787876,
      "domNodes": 94,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.777,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.649999999999938,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 236.88100000003942,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.653,
      "layouts": 76,
      "layoutDurationMs": 11.187000000000001,
      "taskDurationMs": 193.20200000000003,
      "heapDeltaBytes": 9670844,
      "heapUsedBytes": 96267312,
      "domNodes": 4,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 83.805,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428573,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 265.4740000000402,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.5950000000000001,
      "layouts": 76,
      "layoutDurationMs": 11.615,
      "taskDurationMs": 212.522,
      "heapDeltaBytes": 9975428,
      "heapUsedBytes": 96935632,
      "domNodes": 4,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 93.347,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662499999999994,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 317.4470000000156,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.421,
      "layouts": 76,
      "layoutDurationMs": 11.280999999999999,
      "taskDurationMs": 264.563,
      "heapDeltaBytes": -1538568,
      "heapUsedBytes": 118659884,
      "domNodes": 4,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 95.93700000000001,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66842105263157,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 279.87000000007356,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.471,
      "layouts": 76,
      "layoutDurationMs": 10.654,
      "taskDurationMs": 240.26199999999997,
      "heapDeltaBytes": -1980368,
      "heapUsedBytes": 115408800,
      "domNodes": 4,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 83.94800000000001,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66470588235295,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Line coverage: 63.7%

Coverage totals
Metric Covered Total Pct
Lines 57307 89927 63.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.5% 1168
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.6% 312
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 1.0% 307
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 46.8% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2987 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2287 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 671 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/27/2026, 02:41:35 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 4dbc8f0d1246126c32b5c7048a26a704055710f0

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (124)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentStatusIcon.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 74 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@github-actions
github-actions Bot requested a review from thedatalife October 27, 2026 04:35
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 27, 2026
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.58   #22050   +/-   ##
=============================================
  Coverage              ?   84.53%           
=============================================
  Files                 ?     3091           
  Lines                 ?   162754           
  Branches              ?    39129           
=============================================
  Hits                  ?   137592           
  Misses                ?    24771           
  Partials              ?      391           
Flag Coverage Δ
e2e 64.15% <ø> (?)
unit 85.94% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nt/stores/agent/agentNodeDefinitionRefreshStore.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 96 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 27, 2026 10:54
@christian-byrne

Copy link
Copy Markdown
Contributor Author

@DrJKL ready for your review; the automated reviewer has been down since this morning.

Full context for agent readers
  • Merged cloud/1.58 in (e791814,62370e37b0,61104dc481). Only shared file: src/workbench/extensions/agent/AgentPanelRoot.test.ts, auto-merged cleanly; AgentPanelRoot + agentNodeDefinitionRefreshStore tests pass locally, typecheck clean.
  • The upload-e2e-coverage failure from the first run is gone now that the coverage-packaging fix is on cloud/1.58.
  • Exact-head merge gate passes except for the missing approval.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Base merged in, CI green at d0cb4e89ea. Ready for review.

Full context for agent readers

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Why cloud/1.58 gets this but cloud/1.57 does not:

Full context for agent readers

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: faithful backport of #21644 to cloud/1.58.

I compared this head with merged source commit 3821a0a, verified on current main. All four src files carry the same hunks, including the tests and documentation. The target lacks the browser spec and fixture introduced by #21044, so the backport takes the complete spec from #21644's merged tree and the identical fixture from #21044's merged commit 9725d28. Applying those additions and the source hunks to the target merge base produces exactly this head's tree. No other adaptations or extra changes.

With cloud/1.58's own dependencies, AgentPanelRoot and agentNodeDefinitionRefreshStore pass all 488 tests. Playwright discovers both restart-report/reconnect ordering cases. Changed-source ESLint reports no errors; its configuration excludes the test files. All required CI checks pass at this head, including test, lint-and-format, and e2e-status.

@DrJKL DrJKL assigned christian-byrne and unassigned DrJKL Oct 27, 2026
@comfy-pr-bot
comfy-pr-bot merged commit 94d85d6 into cloud/1.58 Oct 27, 2026
119 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21644-to-cloud-1.58 branch October 27, 2026 18:41
comfy-pr-bot pushed a commit that referenced this pull request Oct 27, 2026
…ent restart (#20903, #21644) (#22051)

Backport of #20903 + #21644 to `core/1.57`.

- Nodes the local agent installs stop showing as missing after it
restarts ComfyUI
- ComfyUI v0.43.0 (2026-10-27) pins frontend 1.57.4, which has neither
fix
- Carries #20903's dev-config guard too; only its boundary-doc records
are left out (deleted on this branch)

<details><summary>Full context for agent readers</summary>

Why: default local installs follow ComfyUI's `requirements.txt` pin
(`comfyui-frontend-package==1.57.4` at tag v0.43.0). The fix is in
v1.60.0; 1.58 gets it via #22049/#22050. Without this, a default local
user on comfy-agent 0.1.0-rc2+ still sees new nodes as missing after an
agent restart (PM-2119 case 2).

Risk: #20903 is `risk:xhigh` and touches
`workflowService.reloadCurrentWorkflow` (forced reload keeps the active
tab and unsaved agent edits). Open question: 1.57's agent events ride
ComfyUI `/ws`, not `/api/agent/events`; the store's 10-minute reconnect
window handles either order, but no live check on a 1.57 + comfy-agent
rc4 stack has been done.

Commits:
1. #20903 source-only: `agentNodeDefinitionRefreshStore` (+test),
`AgentPanelRoot.vue` (+test), `useAgentSession` (+test),
`workflowService` (+test), README. Left out:
`docs/architecture/domains/**` (records deleted on this branch).
2. #21644 source + browser spec from main with its fixture from #21044.

Verification on this branch (Node 26.8.2):
store/session/workflowService/AgentPanelRoot unit tests 835/835; store
test 6 red with commit 1's store, green with commit 2; `typecheck` and
`typecheck:browser`, knip, oxfmt clean; eslint 0 errors.

Commit 3: the browser spec used main's `getAgentSocket` fixture, absent
on 1.57 (agent events ride `/ws` here), which failed `typecheck-aux` and
left the Playwright plan empty. It now uses `getWebSocket`.

Adversarial review: a fresh Claude reviewer (same model; the cross-model
CLI is unavailable), Skeptic + Minimalist. It found the fixture blocker
above (fixed). It confirmed by reading code that on 1.57 the store still
gets the `restart_comfyui` success frame (listeners sit on `api`, so
they survive the socket swap), that `src` uses no main-only API, and
that the `reloadCurrentWorkflow` change is low risk for non-agent users.
Still unverified: a live run on a 1.57 + comfy-agent rc4 stack.

Commit 4 (review fix): #20903's `build/devAgentConfig.ts`
standalone/cloud guard, the `vite.config.mts` distribution pass-through
and both `scripts/vite-config-dev-agent.test.ts` cases. The subprocess
refusal test was red before the source hunks and green after (22/22).
typecheck app/build/scripts clean.

Not included: #21841 (catalog-refresh model warnings). `cloud/1.57` not
prepared: the restart path is local-only.

Refs https://linear.app/comfyorg/issue/PM-2119,
https://linear.app/comfyorg/issue/BE-21866
</details>

---------

Co-authored-by: skishore23 <shimikeri.kishore@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants