Repository navigation
feat: retry idempotent requests on 429/502/503/504 in the shared fetch layer - #21322
Conversation
…h layer Add one retry policy (Retry-After as seconds or HTTP-date, capped; bounded attempts; exponential backoff with jitter) and apply it to fetch (fetchWithUnifiedRemint), the billing SDK transport, and the workspace axios client. Only GET/HEAD/OPTIONS are retried unless a caller opts in. Retries run beneath the 401 re-mint, so each keeps its own budget. Keep the HTTP status and code on the AuthStoreError thrown by fetchBalance. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
📦 Bundle: 11.9 MB gzip 🔴 +2.6 kBDetailsSummary
Category Glance App Entry Points — 6.61 kB (baseline 6.61 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.57 MB (baseline 2.57 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 874 kB (baseline 874 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 154 kB (baseline 154 kB) • 🔴 +31 BAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 8 unchanged Editors & Dialogs — 500 kB (baseline 500 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 340 kB (baseline 340 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 22 unchanged Data & Services — 1.88 MB (baseline 1.87 MB) • 🔴 +4.76 kBStores, services, APIs, and repositories
Status: 34 added / 34 removed / 8 unchanged Utilities & Hooks — 2.42 MB (baseline 2.42 MB) • 🔴 +51 BHelpers, composables, and utility bundles
Status: 42 added / 42 removed / 41 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.7 MB (baseline 34.7 MB) • 🔴 +3.08 kBBundles that do not match a named category
Status: 100 added / 100 removed / 641 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-27T13:29:50.083Z",
"gitSha": "23a0b0818bdb70b6eb583771723dbe948ca65d6c",
"branch": "feat/shared-retry-retryable-responses",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.3369999999884,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.137,
"layouts": 9,
"layoutDurationMs": 2.8040000000000007,
"taskDurationMs": 585.018,
"heapDeltaBytes": 1491904,
"heapUsedBytes": 62200936,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 11.029,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2007.284000000027,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7359999999999998,
"layouts": 9,
"layoutDurationMs": 2.7439999999999993,
"taskDurationMs": 519.39,
"heapDeltaBytes": 1217996,
"heapUsedBytes": 62443376,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8.869000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.901000000016,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.212,
"layouts": 9,
"layoutDurationMs": 2.919,
"taskDurationMs": 919.2909999999998,
"heapDeltaBytes": -2298536,
"heapUsedBytes": 67549880,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 172.204,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064217,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.0539999999528,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.057000000000002,
"layouts": 10,
"layoutDurationMs": 2.6830000000000003,
"taskDurationMs": 865.453,
"heapDeltaBytes": -2354556,
"heapUsedBytes": 68274064,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 156.632,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.1129999999926,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.186,
"layouts": 10,
"layoutDurationMs": 2.9859999999999998,
"taskDurationMs": 405.524,
"heapDeltaBytes": 23950556,
"heapUsedBytes": 84549164,
"domNodes": 57,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.42,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.3879999999945,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.537999999999999,
"layouts": 10,
"layoutDurationMs": 3.32,
"taskDurationMs": 424.26399999999995,
"heapDeltaBytes": -327944,
"heapUsedBytes": 60204708,
"domNodes": 57,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 12.562,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 757.7129999999954,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.764,
"layouts": 8,
"layoutDurationMs": 2.2700000000000005,
"taskDurationMs": 522.408,
"heapDeltaBytes": 3654244,
"heapUsedBytes": 64974060,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 175.59900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444445,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 710.4809999999588,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8920000000000003,
"layouts": 9,
"layoutDurationMs": 2.491,
"taskDurationMs": 507.3970000000001,
"heapDeltaBytes": 5826348,
"heapUsedBytes": 66909644,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 173.276,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1242.2200000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 942.243,
"heapDeltaBytes": -12538384,
"heapUsedBytes": 75068928,
"domNodes": -191,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 70.257,
"eventListeners": -106,
"totalBlockingTimeMs": 537,
"frameDurationMs": 32.45526315789472,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.154999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 918.707,
"heapDeltaBytes": -1789372,
"heapUsedBytes": 75063764,
"domNodes": -191,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 68.11899999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 535,
"frameDurationMs": 32.88108108108108,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 921.0410000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.686,
"heapDeltaBytes": -14409068,
"heapUsedBytes": 66557232,
"domNodes": -191,
"jsHeapTotalBytes": 917504,
"scriptDurationMs": 182.18799999999996,
"eventListeners": -106,
"totalBlockingTimeMs": 238,
"frameDurationMs": 24.77567567567567,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 918.3589999998958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.331,
"heapDeltaBytes": -17987912,
"heapUsedBytes": 77382252,
"domNodes": -191,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 167.219,
"eventListeners": -106,
"totalBlockingTimeMs": 256,
"frameDurationMs": 25.461111111111094,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11075.067999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10287.091,
"heapDeltaBytes": 68919128,
"heapUsedBytes": 151143732,
"domNodes": -257,
"jsHeapTotalBytes": 75100160,
"scriptDurationMs": 8193.600999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1307,
"frameDurationMs": 31.485511363636363,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10460.25800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9647.106000000002,
"heapDeltaBytes": 41993676,
"heapUsedBytes": 136408484,
"domNodes": -257,
"jsHeapTotalBytes": 73265152,
"scriptDurationMs": 7722.209999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 893,
"frameDurationMs": 31.380180180180183,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11198.408999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10382.122000000001,
"heapDeltaBytes": 72783564,
"heapUsedBytes": 151600408,
"domNodes": -257,
"jsHeapTotalBytes": 71168000,
"scriptDurationMs": 8274.028,
"eventListeners": -68,
"totalBlockingTimeMs": 1309,
"frameDurationMs": 31.371148459383754,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10127.953999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9403.919,
"heapDeltaBytes": 47072680,
"heapUsedBytes": 140760932,
"domNodes": -257,
"jsHeapTotalBytes": 65925120,
"scriptDurationMs": 7534.612,
"eventListeners": -68,
"totalBlockingTimeMs": 892,
"frameDurationMs": 31.27469135802469,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 228.72100000000728,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.046,
"layouts": 11,
"layoutDurationMs": 3.477,
"taskDurationMs": 188.61299999999997,
"heapDeltaBytes": 14636528,
"heapUsedBytes": 70527500,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.842000000000002,
"eventListeners": -573,
"totalBlockingTimeMs": 6,
"frameDurationMs": 23.340000000000053,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 220.96499999997832,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.488999999999999,
"layouts": 11,
"layoutDurationMs": 3.084,
"taskDurationMs": 175.49699999999999,
"heapDeltaBytes": -7267880,
"heapUsedBytes": 75001060,
"domNodes": 936,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.142999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 25.922222222222192,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2054.9650000000383,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4280000000000004,
"layouts": 9,
"layoutDurationMs": 2.5779999999999994,
"taskDurationMs": 668.843,
"heapDeltaBytes": -27087360,
"heapUsedBytes": 60758192,
"domNodes": -257,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 35.873999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.2689999999293,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.405,
"layouts": 8,
"layoutDurationMs": 2.46,
"taskDurationMs": 651.0129999999999,
"heapDeltaBytes": 9688640,
"heapUsedBytes": 83542732,
"domNodes": -267,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 38.168,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2512.4849999999697,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.618,
"layouts": 7,
"layoutDurationMs": 1.9539999999999995,
"taskDurationMs": 1719.2440000000001,
"heapDeltaBytes": 11626112,
"heapUsedBytes": 86160344,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 840.6980000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777852348993285,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2501.350000000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.295,
"layouts": 8,
"layoutDurationMs": 2.2580000000000005,
"taskDurationMs": 1743.4570000000003,
"heapDeltaBytes": -11354844,
"heapUsedBytes": 76890056,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 849.134,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.776666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3753.7399999999934,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.510000000000002,
"layouts": 64,
"layoutDurationMs": 10.196,
"taskDurationMs": 1817.2469999999998,
"heapDeltaBytes": -15682620,
"heapUsedBytes": 75060228,
"domNodes": -233,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 803.449,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665777777777777,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3871.4049999999816,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.004,
"layouts": 63,
"layoutDurationMs": 10.914,
"taskDurationMs": 1824.18,
"heapDeltaBytes": 6263948,
"heapUsedBytes": 83205156,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 814.77,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665948275862068,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3195.576000000017,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.798,
"layouts": 4,
"layoutDurationMs": 1.3809999999999998,
"taskDurationMs": 2029.7079999999999,
"heapDeltaBytes": -20601280,
"heapUsedBytes": 71179528,
"domNodes": 0,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 1013.0619999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.01851851851852,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3158.3689999999933,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.268,
"layouts": 5,
"layoutDurationMs": 1.274,
"taskDurationMs": 2036.3320000000003,
"heapDeltaBytes": -21045096,
"heapUsedBytes": 70794160,
"domNodes": 0,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 1028.965,
"eventListeners": 182,
"totalBlockingTimeMs": 35,
"frameDurationMs": 17.022459893048133,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3186.385000000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.784,
"layouts": 6,
"layoutDurationMs": 1.581,
"taskDurationMs": 891.2769999999999,
"heapDeltaBytes": -7995760,
"heapUsedBytes": 81780260,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 444.84999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753684210526316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3068.753000000015,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.607,
"layouts": 6,
"layoutDurationMs": 1.5169999999999997,
"taskDurationMs": 803.376,
"heapDeltaBytes": -8923628,
"heapUsedBytes": 80734120,
"domNodes": -257,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 381.873,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.3269999999861,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.187,
"layouts": 7,
"layoutDurationMs": 1.8199999999999998,
"taskDurationMs": 662.746,
"heapDeltaBytes": -25573756,
"heapUsedBytes": 63876624,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 34.644,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.1929999999738,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1980000000000004,
"layouts": 7,
"layoutDurationMs": 1.9680000000000002,
"taskDurationMs": 694.8240000000001,
"heapDeltaBytes": -15301996,
"heapUsedBytes": 60440072,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 37.29899999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2841.1470000000063,
"styleRecalcs": 25,
"styleRecalcDurationMs": 13.159,
"layouts": 6,
"layoutDurationMs": 1.7309999999999999,
"taskDurationMs": 650.882,
"heapDeltaBytes": 9657352,
"heapUsedBytes": 84704348,
"domNodes": -250,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 208.154,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.764497041420118,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2733.39500000003,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.499,
"layouts": 6,
"layoutDurationMs": 1.3760000000000006,
"taskDurationMs": 621.0539999999999,
"heapDeltaBytes": -13888576,
"heapUsedBytes": 75729012,
"domNodes": -253,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 194.848,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3369.129999999984,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8810000000000007,
"layouts": 6,
"layoutDurationMs": 1.542,
"taskDurationMs": 1013.9139999999998,
"heapDeltaBytes": -19123124,
"heapUsedBytes": 69948504,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 413.53100000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.748756218905474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3296.094000000039,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.06,
"layouts": 7,
"layoutDurationMs": 2.063,
"taskDurationMs": 991.136,
"heapDeltaBytes": -10610316,
"heapUsedBytes": 65337816,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 391.606,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666497461928934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 673.0820000000222,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.39,
"layouts": 8,
"layoutDurationMs": 2.132,
"taskDurationMs": 458.27099999999996,
"heapDeltaBytes": 849228,
"heapUsedBytes": 62522620,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 153.35299999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.0199999999022,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.013999999999999,
"layouts": 9,
"layoutDurationMs": 2.492,
"taskDurationMs": 449.578,
"heapDeltaBytes": -596860,
"heapUsedBytes": 61454692,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 147.077,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.1949999999674,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8059999999999996,
"layouts": 9,
"layoutDurationMs": 2.5720000000000005,
"taskDurationMs": 518.369,
"heapDeltaBytes": 1734332,
"heapUsedBytes": 63165176,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8.629,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.299000000089,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.426,
"layouts": 8,
"layoutDurationMs": 2.4709999999999996,
"taskDurationMs": 534.0409999999999,
"heapDeltaBytes": 2095360,
"heapUsedBytes": 64321652,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 9.544999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.105999999963,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.458,
"layouts": 9,
"layoutDurationMs": 2.5679999999999996,
"taskDurationMs": 868.1320000000001,
"heapDeltaBytes": -6369056,
"heapUsedBytes": 65734548,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 114.83100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.232999999942,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.342999999999998,
"layouts": 8,
"layoutDurationMs": 2.29,
"taskDurationMs": 871.122,
"heapDeltaBytes": 19157716,
"heapUsedBytes": 81274512,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 119.855,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.4559999999797,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.689,
"layouts": 5,
"layoutDurationMs": 14.212000000000003,
"taskDurationMs": 1090.4889999999998,
"heapDeltaBytes": 11633124,
"heapUsedBytes": 113270544,
"domNodes": 16030,
"jsHeapTotalBytes": 16125952,
"scriptDurationMs": 31.921000000000006,
"eventListeners": 3246,
"totalBlockingTimeMs": 156,
"frameDurationMs": 19.777333333333335,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 9874.751000000004,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.031999999999996,
"layouts": 9,
"layoutDurationMs": 2.284,
"taskDurationMs": 6264.275000000001,
"heapDeltaBytes": -161852,
"heapUsedBytes": 87402696,
"domNodes": -257,
"jsHeapTotalBytes": 4550656,
"scriptDurationMs": 2912.179,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.694247038917087,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9977.646999999934,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.604,
"layouts": 8,
"layoutDurationMs": 2.109,
"taskDurationMs": 6274.5419999999995,
"heapDeltaBytes": 4707048,
"heapUsedBytes": 78518824,
"domNodes": -257,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2911.4739999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69396984924623,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23248.82100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22809.516,
"heapDeltaBytes": -25339260,
"heapUsedBytes": 257490200,
"domNodes": -3343,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 343.04599999999994,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.26412478336221,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 23380.494,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22917.736999999997,
"heapDeltaBytes": -17804124,
"heapUsedBytes": 283478376,
"domNodes": -3347,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 338.66400000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.77766143106458,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 28728.692000000025,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.319000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28417.738,
"heapDeltaBytes": -17391056,
"heapUsedBytes": 285229292,
"domNodes": -3343,
"jsHeapTotalBytes": 13811712,
"scriptDurationMs": 883.507,
"eventListeners": -651,
"totalBlockingTimeMs": 9,
"frameDurationMs": 55.4996138996139,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 28655.975000000013,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.405000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28276.278000000002,
"heapDeltaBytes": -6990396,
"heapUsedBytes": 270258936,
"domNodes": -3343,
"jsHeapTotalBytes": 13361152,
"scriptDurationMs": 902.862,
"eventListeners": -651,
"totalBlockingTimeMs": 5,
"frameDurationMs": 53.250557620817844,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8415.569000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.727,
"layouts": 20,
"layoutDurationMs": 21.83199999999999,
"taskDurationMs": 8258.240000000002,
"heapDeltaBytes": -30120604,
"heapUsedBytes": 269956844,
"domNodes": -3343,
"jsHeapTotalBytes": 20172800,
"scriptDurationMs": 132.53500000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.665000000000006,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8543.637999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.15500000000004,
"layouts": 20,
"layoutDurationMs": 30.066999999999982,
"taskDurationMs": 8425.567000000001,
"heapDeltaBytes": -14076352,
"heapUsedBytes": 268685144,
"domNodes": -2276,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 151.436,
"eventListeners": -423,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.208474576271186,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11579.791999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11365.707,
"heapDeltaBytes": -10938768,
"heapUsedBytes": 256024168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.84600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.72640845070422,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11543.747000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11314.840999999999,
"heapDeltaBytes": 4526032,
"heapUsedBytes": 272912552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.24800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.32482517482518,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 126.11799999996265,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.777999999999999,
"layouts": 8,
"layoutDurationMs": 4.3309999999999995,
"taskDurationMs": 92.83,
"heapDeltaBytes": 4680508,
"heapUsedBytes": 65403316,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.953,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 149.0959999999859,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.861,
"layouts": 10,
"layoutDurationMs": 3.536,
"taskDurationMs": 105.447,
"heapDeltaBytes": 4709436,
"heapUsedBytes": 72236792,
"domNodes": 103,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.382000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 558.3260000000791,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.696,
"layouts": 76,
"layoutDurationMs": 16.834,
"taskDurationMs": 518.9979999999999,
"heapDeltaBytes": -3154068,
"heapUsedBytes": 41307576,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 255.172,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 514.6050000000741,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.666,
"layouts": 76,
"layoutDurationMs": 15.344,
"taskDurationMs": 469.77200000000005,
"heapDeltaBytes": -4122404,
"heapUsedBytes": 40631136,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 228.902,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 545.7750000000487,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.57,
"layouts": 76,
"layoutDurationMs": 14.299,
"taskDurationMs": 508.539,
"heapDeltaBytes": 481496,
"heapUsedBytes": 91120372,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 207.37499999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 589.1530000000103,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.313,
"layouts": 76,
"layoutDurationMs": 15.249,
"taskDurationMs": 548.6,
"heapDeltaBytes": 768572,
"heapUsedBytes": 94641072,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 222.672,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.140000000000015,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3138 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 10f8b084ded04435ff05fba589a1512068a1c2f8
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (235)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21322 +/- ##
==========================================
- Coverage 87.23% 87.12% -0.11%
==========================================
Files 2946 2841 -105
Lines 158776 155543 -3233
Branches 43136 39993 -3143
==========================================
- Hits 138506 135524 -2982
+ Misses 19400 19315 -85
+ Partials 870 704 -166
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 123 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed d767c7a and the complete linked Slack request/forwarded alert. Requesting changes for the two independently reproduced transport gaps inline: web-session requests bypass the installed default-adapter retry, and axios backoff exceeds configured request timeouts.
Own exact-head evidence in an isolated checkout with its own frozen dependency install:
- PASS: 353 tests across six retry/remint/workspace/auth suites, app typecheck, cloud production build, touched-file type-aware Oxlint/ESLint/formatting, knip and scoped Fallow.
- Additional public-workspace-API regression: default-adapter control PASS (503 then 200, two sends); web-session row FAIL (503 after one send). This uses the real workspace API, axios and web-session adapter with only the sender controlled.
- Actual HTTP timeout probes: Node adapter 1,012 ms and real Chromium transport 1,075 ms despite timeout:100, with Retry-After:1 and two requests. The browser run uses the normal local Vite API proxy; the initial cross-origin harness produced Network Error and was corrected before drawing the timeout conclusion.
- Safety-net mutations: permitting writes makes 5/47 policy cases fail; removing the Retry-After cap makes 1/47 fail. Restoring source passes all 75 retry utility cases.
The controlled 503s prove these code paths, not a current production outage. No live billing session or payment was created; live authenticated Cloud acceptance remains NOT_RUN. Temporary regression files and mutations were removed/restored.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
…uest timeout The axios retry wrapped only the client's default adapter, so a request that selects its own adapter (the web-session workspace path) surfaced the first 503. Wrap whichever adapter each request selects, once. The request timeout restarted on every attempt and did not bound the backoff wait. Treat timeout as one budget: each attempt gets the time remaining, and a wait that would not fit stops retrying and surfaces the last response. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed bbad486. Both transport blockers from my previous review are resolved: the retry interceptor wraps the adapter selected for each request, covering the web-session override, and retries share the configured timeout budget instead of restarting it after backoff. The wrapper guard also preserves the existing 401 re-mint composition without nesting another wrapper.
Own exact-head checks in an isolated checkout with its own frozen install: 365 tests across seven retry/remint/workspace/auth suites PASS; app typecheck, Cloud production build, scoped type-aware oxlint/formatting (14 files), source ESLint (7 files), knip and changed-file Fallow PASS. The public workspace API/session-sender regression now recovers from 503 with two sends, while its write control is not replayed.
Independent real HTTP probes in Node and Chromium (browser through the normal local Vite API proxy): timeout:100 with Retry-After:1 now returns the last 503 after one send, in 6 ms / 5 ms respectively. With timeout:5000, both honor the one-second wait and recover with two sends in about 1004 ms / 1008 ms. Replacing only the adapter wrapper with the previously reviewed implementation makes the 100 ms cases incorrectly succeed after about 1009 ms / 1017 ms and two sends. The same control makes four regression assertions FAIL while 49 controls PASS; its failed web-session request also produces an unhandled rejection in that red run. Restoring the head returns all 53 affected adapter/remint/workspace cases and all four HTTP probes to PASS.
These are controlled transient responses, not a claim about a current production outage. Live authenticated Cloud/billing acceptance is NOT_RUN. The linked Slack request and all current PR discussions were refreshed; no new blocking finding. All private mutations are restored, the checkout is clean, and the owned probe server/browser/Vite process is stopped.
christian-byrne
left a comment
There was a problem hiding this comment.
Two blocking retry gaps remain: first-party web-session reads bypass the policy, and body-bearing Request retries are not replay-safe. The billing composition also lacks a change-detector; two non-blocking repository-rule findings are inline.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
…lling wiring Apply the retry policy at the web-session send used by the Cloud API and global-settings reads; the workspace axios web-session adapter keeps its own wrapper so no request is retried twice. fetchWithRetry now clones a body-bearing Request per attempt and does not retry a stream body it cannot replay. Add a test through the billing store wiring, drop an avoidable double assertion, and shorten the retry JSDoc. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph
|
|
|
|
|
|
|
|
…504 in the shared fetch layer (#21322) (#22066) Manual backport of #21322 (`58233176b0`) to `cloud/1.58`. The auto-backport failed on conflicts. ## Why `fetchBalance` throws `AuthStoreError: Balance temporarily unavailable` on the first 503 in prod (Sentry CLOUD-FRONTEND-PROD-2V0). ## Root cause The shared fetch paths (plain fetch, billing SDK, workspace axios client) never retried a retryable status. A transient 503 with `Retry-After` surfaced as an error on the first attempt. ## How Same change as #21322: one shared retry for idempotent requests on 429/502/503/504, honoring a capped `Retry-After`, with one timeout budget across attempts. Reads that already retry on their own opt out. Conflicts resolved for 1.58: - `workspaceApi.ts`: 1.58 builds URLs with `workspaceApiUrl`, not `ingestApiUrl`. - `billingSdkStore.ts`: on 1.58 the file is under `platform/workspace/billing/sdk`. Kept `resolveUrl: workspaceApiUrl` and added `fetchImpl: fetchWithRetry`. - `billingSdkStore.retry.test.ts` and `workspaceApi.webSessionRetry.test.ts`: mock paths point at the 1.58 modules. ## AS IS / TO BE No UI change. AS IS: a 503 on a balance or workspace read fails on the first attempt. TO BE: it retries up to 3 attempts before failing. Covered by the unit tests below rather than screenshots. ## Verified The 12 touched test files pass on the 1.58 base (611 tests). Pre-commit lint, format and typecheck pass, and so does pre-push knip/depcruise.
…04 in the shared fetch layer (#21322) (#22065) Manual backport of #21322 (`58233176b0`) to `core/1.58`. The auto-backport failed on conflicts. ## Why `fetchBalance` throws `AuthStoreError: Balance temporarily unavailable` on the first 503 in prod (Sentry CLOUD-FRONTEND-PROD-2V0). ## Root cause The shared fetch paths (plain fetch, billing SDK, workspace axios client) never retried a retryable status. A transient 503 with `Retry-After` surfaced as an error on the first attempt. ## How Same change as #21322: one shared retry for idempotent requests on 429/502/503/504, honoring a capped `Retry-After`, with one timeout budget across attempts. Reads that already retry on their own opt out. Conflicts resolved for 1.58: - `workspaceApi.ts`: 1.58 builds URLs with `workspaceApiUrl`, not `ingestApiUrl`. - `billingSdkStore.ts`: on 1.58 the file is under `platform/workspace/billing/sdk`. Kept `resolveUrl: workspaceApiUrl` and added `fetchImpl: fetchWithRetry`. - `billingSdkStore.retry.test.ts` and `workspaceApi.webSessionRetry.test.ts`: mock paths point at the 1.58 modules. ## AS IS / TO BE No UI change. AS IS: a 503 on a balance or workspace read fails on the first attempt. TO BE: it retries up to 3 attempts before failing. Covered by the unit tests below rather than screenshots. ## Verified The 12 touched test files pass on the 1.58 base (611 tests). Pre-commit lint, format and typecheck pass, and so does pre-push knip/depcruise. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…04 in the shared fetch layer (#21322) (#22086) Manual backport of #21322 (`58233176b0`) to `core/1.59`. The auto-backport failed on conflicts. ## Why `fetchBalance` throws `AuthStoreError: Balance temporarily unavailable` on the first 503 in prod (Sentry CLOUD-FRONTEND-PROD-2V0). ## Root cause The shared fetch paths (plain fetch, billing SDK, workspace axios client) never retried a retryable status. A transient 503 with `Retry-After` surfaced as an error on the first attempt. ## How Same change as #21322: one shared retry for idempotent requests on 429/502/503/504, honoring a capped `Retry-After`, with one timeout budget across attempts. Reads that already retry on their own opt out. Conflicts resolved for 1.59, which still uses the 1.58 workspace client layout: - `workspaceApi.ts`: 1.59 sends workspace requests through the axios client with `workspaceApiUrl`; the read options match the 1.58 backport (#22065 / #22066). - `billingSdkStore.ts`: kept `resolveUrl: workspaceApiUrl` and added `fetchImpl: fetchWithRetry`. - `workspaceApi.webSessionRetry.test.ts`: mock path points at `workspaceApiUrl`. ## AS IS / TO BE No UI change. AS IS: a 503 on a balance or workspace read fails on the first attempt. TO BE: it retries up to 3 attempts before failing. Covered by the unit tests below rather than screenshots. ## Verified The touched test files pass on the core/1.59 base (40 files, 931 tests). Pre-commit lint, format and typecheck pass.
…504 in the shared fetch layer (#21322) (#22087) Manual backport of #21322 (`58233176b0`) to `cloud/1.59`. The auto-backport failed on conflicts. ## Why `fetchBalance` throws `AuthStoreError: Balance temporarily unavailable` on the first 503 in prod (Sentry CLOUD-FRONTEND-PROD-2V0). ## Root cause The shared fetch paths (plain fetch, billing SDK, workspace axios client) never retried a retryable status. A transient 503 with `Retry-After` surfaced as an error on the first attempt. ## How Same change as #21322: one shared retry for idempotent requests on 429/502/503/504, honoring a capped `Retry-After`, with one timeout budget across attempts. Reads that already retry on their own opt out. Conflicts resolved for 1.59, which still uses the 1.58 workspace client layout: - `workspaceApi.ts`: 1.59 sends workspace requests through the axios client with `workspaceApiUrl`; the read options match the 1.58 backport (#22065 / #22066). - `billingSdkStore.ts`: kept `resolveUrl: workspaceApiUrl` and added `fetchImpl: fetchWithRetry`. - `workspaceApi.webSessionRetry.test.ts`: mock path points at `workspaceApiUrl`. ## AS IS / TO BE No UI change. AS IS: a 503 on a balance or workspace read fails on the first attempt. TO BE: it retries up to 3 attempts before failing. Covered by the unit tests below rather than screenshots. ## Verified The touched test files pass on the core/1.59 base (40 files, 931 tests). Pre-commit lint, format and typecheck pass.
…ead of leaving it unhandled (Comfy-Org#22201) ## Summary Opening the account menu (legacy or workspace) or the Credits settings section starts a balance read that nothing awaits. When it fails, the rejection is unhandled, so Sentry files it as a new high-priority error. Now: - the failure is reported as a `billing` warning (`error_refreshing_balance`), at most once every five minutes, so reopening the menu during an outage does not repeat it; - a workspace balance read that a newer read has replaced settles quietly instead of rejecting, matching the rail path's `SUPERSEDED` handling, so the warning only covers failures the billing state actually kept; - the same applies across a workspace switch. A balance read for the previous workspace could still land after the switch replaced the billing adapter, writing that workspace's balance into the discarded adapter or reporting a warning for a failure the billing state never kept. `fetchStatus` already captured and rechecked the workspace id, so `fetchBalance` now shares that guard rather than carrying a second copy. What the user sees is unchanged. Note that the two popovers still show 0 credits when the read fails; that display bug is tracked separately in https://linear.app/comfyorg/issue/FRONT-3164. Evidence: both events of Sentry `CLOUD-FRONTEND-PROD-2V0` ("AuthStoreError: Failed to fetch balance: Balance temporarily unavailable") are `onunhandledrejection` from `useLegacyBilling.fetchBalance`, right after a 503 from `/customers/balance`. Comfy-Org#21322 now retries that 503; this covers the failure left after the retries run out. Linear: https://linear.app/comfyorg/issue/FRONT-3684 ## Verification - Red before the fix, green after: one test per call site (`CurrentUserPopoverLegacy`, `CurrentUserPopoverWorkspace`, `SettingDialog` Credits section), the helper's five-minute report budget, `useWorkspaceBilling` settling a superseded failed read, and `useWorkspaceBilling` dropping a balance read on both paths once the workspace changed. - `pnpm typecheck`, oxlint, oxfmt and the pre-push fallow audit pass. - After release: `CLOUD-FRONTEND-PROD-2V0` gets no new unhandled events; a persistent balance outage shows up as `error_refreshing_balance` warnings instead.
…etried and how they ended (Comfy-Org#22204) ## Summary Comfy-Org#21322 retries 429/502/503/504 in the shared fetch and axios layers, but nothing records that a retry happened, so a backend that fails often but recovers on retry looks healthy. This records one `app:fetch_status_retry` event per request that hit a retryable status: a Datadog RUM action and a Sentry breadcrumb with transport, method, host, route group, attempts, last status and outcome (`recovered`, `exhausted`, `retry_after_too_long`, `timeout_budget`, `failed`). Retry behaviour is unchanged. Design calls worth a look: - One pure classifier (`classifyStatusRetry`) decides the outcome from how each transport's loop ended. A retry that ends on a 500/404 or with no response is `failed`, not `recovered`. The request timeout (`TimeoutError` abort on fetch, `ECONNABORTED`/`ETIMEDOUT` on axios) is told apart from a caller cancel, which records nothing. - Routes reuse the allowlisted route groups of `app:fetch_timeout` (`getFetchRouteTemplate`, moved from `api.ts` to `src/utils/fetchRouteTemplate.ts`, now also `billing`, `customers`, `workspaces`), so user-chosen names never leave the client and the two events join on `route`. Side effect: `app:fetch_timeout` for those three groups now reports the group instead of `/other`. - At most 20 events per host/route/outcome per minute, so an outage cannot flood RUM while a long-lived tab keeps reporting. Hosts outside `comfy.org` and the page's own host report as `other`. - Recording can never throw into a request. - `retryDelayMs` is replaced by `nextRetry`, which also says why it stopped. Linear: https://linear.app/comfyorg/issue/FRONT-3683 ## Verification - New cases red against the first cut of this change, green now: per-outcome tables for both transports, timeout vs cancel, route redaction, the per-key cap, telemetry throwing, opt-out reads; plus a classifier table and provider tests (Datadog action, Sentry breadcrumb level). - 2,200+ tests in `src/utils`, `src/scripts`, auth, workspace API, settings and telemetry providers pass. `pnpm typecheck`, knip, oxlint, oxfmt and the pre-push fallow audit pass. - An independent adversarial review (Skeptic, Architect, Minimalist; fresh Claude reviewers, since the cross-model CLI is unavailable on this host) ran on the first cut; its findings (mislabelled `recovered`, timeout classification, duplicated mapping, weak route scrubbing, unbounded volume, telemetry inside the request `try`) are fixed here. Panel, CodeRabbit and review findings on 0531273 are fixed in 37b5a87 and the per-minute cap commit. - After release: in Datadog RUM, `@action.name:app:fetch_status_retry` grouped by `@context.route` and `@context.outcome`.
…rg#22516) **TL;DR:** On cloud, a write (POST, PUT, PATCH, DELETE) that the sign-in check refuses with a 503 "try again" is sent once more after its `Retry-After`. Every other request is sent exactly as before. **Why** You press Queue while cloud's sign-in check cannot reach its database. The check answers 503 with `Retry-After: 5` and the message `authentication service unavailable`. The shared status retry (Comfy-Org#21322) retries only GET, HEAD and OPTIONS, so the POST comes back as an error. That check used to answer 401 here, and the 401 re-mint path sent the POST again without the user noticing. The check refuses before any handler runs, so the server did nothing with the request, and sending it again cannot queue a job twice. **Before / After** - Before: Queue during a few seconds of sign-in database trouble shows an error. - After: the request waits the `Retry-After` (capped as today) and is sent once more. A second refusal reaches the caller. So does a first 503 whose wait is past the cap or would spend the caller's timeout, or whose body does not finish within 1 second. **How** - `isSignInCheckRefusal` (`packages/api-client/src/retryPolicy.ts`) matches only a 503 with a `Retry-After` that parses and a JSON body whose `message` is exactly `authentication service unavailable`. A body that does not parse, or does not finish within 1 second, is not a match. At 1 second the read of the copy is cancelled, and the caller's response stays readable. The message match is temporary: BE-24676 has ingest send a machine-readable marker, declared in its OpenAPI spec, and this match moves to it. Until then, a future 503 with the same text and a `Retry-After` from a handler that already wrote something would be sent twice; today only the sign-in check sends that text with a 503 (read from cloud main). - A new `RetryPolicy` field, `retrySignInRefusal`, is `false` by default. `cloudRetryPolicy()` turns it on only on cloud, at two call sites: `fetchWithUnifiedRemint` and the workspace API axios client. The billing SDK, the web-session (cookie) paths and every core/local build keep the default. At `fetchWithUnifiedRemint` the field is on whatever `unified_cloud_auth` says, so with that flag off a refused write on cloud is now sent once more instead of the single fetch that path used to promise. Turning the flag off does not turn this off. - With the field off, a write takes the same early return as on main. With it on, the first send uses the caller's own input and init. A `Request` with a body is cloned up front, the same as the 401 path. A copy of the body is read only on a 503 with a parsable `Retry-After` within the cap and a send left, so a stalled body cannot hold up a refusal the headers already rule out. Telemetry fires only when the write was sent twice. A stream passed as `init.body` is never sent again. A `Request` built around a stream would be cloned and sent again, as on the 401 path; every caller with this policy on passes a URL string, and no non-test code builds a `Request`. - On axios, the timeout is checked again right after the wait. If it is spent, the caller gets the first 503 and nothing more is sent. On fetch, a caller's abort signal that fires during the wait rejects with the abort error, as the existing GET loop does, and nothing more is sent. On both paths, a timeout during the wait records a retry event with one send and the first 503; a caller's own cancel records nothing, as on the read loops. - GET, HEAD and OPTIONS keep the current policy, and the 401 re-mint path is unchanged. **Seen in production by:** not seen; a 10-day search of the cloud ingest logs for the message found nothing. The case is read from the server code that sends this 503. Ran on the head commit: vitest on `packages/api-client`, `src/utils`, `src/platform/auth`, `src/platform/workspace` (3153 passed, 0 failed). One of three full runs failed under machine load: five auth and workspace files hit hook timeouts, and the websocket backoff test in `webSessionFlagOn.test.ts` saw 3 sockets instead of 2. Those six files then passed three times in a row alone. The new abort and body-cancel tests failed before their fixes and pass after. `pnpm typecheck` and the pre-commit and pre-push hooks (oxfmt, oxlint, eslint, `typecheck:app`, knip) ran on the commit. Ran earlier on 09e82ee: vitest on those paths plus `src/platform/{billing,settings}`, `src/scripts`, `src/stores/authStore` (7537 passed, 0 failed), and the four clock-based tests in 10 separate runs (all pass). `src/platform/auth/webSessionFlagOn.test.ts` failed once in a run before d1d291f and passed on every rerun; it does not touch the retry code. Not run: against a live backend. On staging, the plan is to fake the refusal once on a Queue press and check the job is queued once. **Rule bent:** none. Ref FRONT-3536
…Org#22512) ## Why 1.59 QA has two HIGH request-retry cases (C-117, C-118) with no Playwright coverage. The shared status retry from Comfy-Org#21322 (retry idempotent reads on 429/502/503/504, up to 3 attempts) and its telemetry from Comfy-Org#22204 only had unit tests, so QA had to run them by hand. ## How New `@cloud` spec `browser_tests/tests/infrastructure/cloudStatusRetry.spec.ts`, with the route helpers in `browser_tests/fixtures/helpers/StatusRetryRouteHelper.ts`. The retry lives on the cloud transports, so it runs in the `cloud` project on `cloudAppFixture` and `CloudWorkspaceMockHelper`: - **Read recovers:** the first `GET /api/billing/capabilities` answers 503 (`Retry-After: 0`). The read is retried, and Plan & Credits renders Add credits from the recovered answer. - **Read stays unavailable:** every capabilities read answers 503. The reads are retried, and Plan & Credits keeps credits locked (no Add credits), the same state as before the retry change. - **Attempt limit:** a GET through `api.fetchApi` that stays 503 returns 503 after exactly three requests. - **Write is not resent:** a POST through `api.fetchApi` answered 503 is sent once, and the caller gets the 503. - **App read on the cloud transport:** a GET through `api.fetchApi` answered 503 once, then 200, returns 200 after two requests. The telemetry half of Comfy-Org#22204 is not asserted here. Datadog/Sentry events aren't observable in E2E, and they are covered by `statusRetryTelemetry.test.ts`. ## Verification Ran locally on the `cloud` project: cloud-mode dev server against a local ComfyUI backend. - On `origin/main`: 5 passed, and 15 passed with `--repeat-each=3`. - Mutation check with `maxAttempts: 1` in `retryPolicy.ts`: the four retry cases fail, and the write case still passes (correct, since it guards against retrying). Reverted. No UI change, so there are no screenshots. ## Plan position | Item | PR | Status | |---|---|---| | Shared status retry | Comfy-Org#21322 | Merged | | Retry telemetry | Comfy-Org#22204 | Merged | | **E2E for C-117 / C-118** | **this PR** | **Open** | ```mermaid graph LR retry["PR 21322 status retry"] --> telemetry["PR 22204 retry telemetry"] retry --> e2e["This PR: cloud E2E"] style e2e fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:3px ```
|
Backport did not run. This PR has release labels with no backport ( To backport, add the |
Requested by Christian Byrne · Slack thread
Before: a read that the backend answered with a transient 503 (for example the balance endpoint's "Balance temporarily unavailable, please retry") surfaced straight to the caller as an error, even though the server was telling us to try again.
Retry-Afterwas never read, and the thrownAuthStoreErrorcarried no status, so nothing downstream could tell a transient failure from a real one.After: the shared fetch layer, the workspace axios client and the billing SDK transport quietly retry idempotent reads on 429/502/503/504 (up to 3 attempts, honoring
Retry-After), so call sites do not each implement retry. If the failure persists, the caller still gets the final response, andfetchBalancenow throws anAuthStoreErrorthat carriesstatusandcode.This adds one shared retry policy and wires it under the existing 401 re-mint on every cloud request path.
How:
src/utils/retryPolicy.tsis the policy:Retry-Afterparsed as delta-seconds or HTTP-date, exponential backoff with jitter (500 ms base, 10 s cap), 3 attempts total, injectable randomness/clock. ARetry-Afterlonger than the cap stops retrying rather than hammering the server early.retryNonIdempotent: true; nothing in this PR does.fetchWithRetry(fetch) is used byfetchWithUnifiedRemint(both the first request and the post-re-mint request) and passed asfetchImplto the billing SDK transport. The axios client gets the same policy by wrapping its adapter (attachRetryableStatusRetry, installed ininstallWorkspaceApiAuth).axios-retrywas evaluated and not used. v4.5.0's default condition retries network errors plus any 5xx/429 on GET/HEAD/OPTIONS/PUT/DELETE (so it would replay PUT/DELETE and retry 500/501),Retry-Afteris honored but uncapped, and its retry goes back through the whole interceptor chain, which makes the 401 re-mint budget interact with it. Overriding the condition and delay leaves little of it, it would not help the fetch paths, and it would add a dependency. The adapter wrapper is about 30 lines and shares the helper with fetch.Verification: new unit tests for the helper (header parsing, cap, jitter bounds, attempt limit, method/status tables), the fetch wrapper (503 then 200, persistent 503 returns the final response, POST not retried,
Retry-Afterheld back with fake timers, abort while waiting), the axios wrapper, and composition with the 401 re-mint on both fetch and axios;authStoretests cover status/code on the thrown error and a balance read that recovers after a 503. Ran the unit tests forsrc/utils,src/stores/authStore,src/platform/auth,src/platform/workspace,src/platform/settings,src/scripts,src/services(all pass), pluspnpm typecheck,pnpm knip,pnpm deps:auditand lint on the changed files. Not exercised against a live backend.Follow-ups (not in this PR):
void fetchBalance()call sites still discard the rejection; they now get a classifiable error but still need handling.fetchWithUnifiedRemintis also the cloudapi.fetchApitransport (cloudApiAuthProvider), so every cloud ComfyUI API GET (queue, history, object info and so on) now retries too, along with customer GETs, global settings, billing SDK reads and workspace API GETs. Time spent waiting on retries counts against the caller's request timeout.customerEventsServicehas its own axios client and is not wired yet.Retry-Afterabove the cap give up as it does here, or wait it out?🤖 Generated with Claude Code
https://claude.ai/code/session_01Q6WHcAWundnpSwdSQWCMph