Repository navigation
[backport core/1.58] fix(agent): refresh node definitions when ComfyUI reconnects after an agent restart (#21644) - #22049
Conversation
… agent restart (#21644) Nodes the local agent installs show as missing after it restarts ComfyUI. Since comfy-agent 0.1.0-rc2 ([cloud#14617](Comfy-Org/cloud#14617)) a successful `restart_comfyui` only schedules the restart: the agent reports `success` while the old ComfyUI is still serving and restarts it after the turn ends. The refresh store from #20903 fetched `/object_info` on that frame, read the old catalog, cleared its stale flag, and ignored the reconnect that followed. The store now marks definitions stale on the `success` frame and refreshes on the next `/ws` `reconnected`. A failed refresh still retries on the following reconnect. Restarts the panel never sees (panel closed, user or Desktop restarts) stay out of scope, as in FE-3483. Refs BE-21866 (the regression is recorded in its 2026-10-22 comment). - **Reproduced on the shipping stack, 2 of 2 runs:** published `comfy-agent[go-nonfree]==0.1.0rc2` on Linux x86_64, ComfyUI master `46aad33e` with `--enable-agent --enable-manager`, frontend `v1.59.0`. Each time the agent wrote and installed a one-node pack, I picked Restart ComfyUI on the card, and the agent then placed the node. The page fetched `/object_info` about 1 s after the card answer, before the restart (no new class in it). It fetched nothing after `reconnected`. The placed node rendered as a red missing type with no widgets. Refresh Node Definitions registered the class, but the placed node stayed broken until a page reload. - **Same flow on this branch** (production build of this head, served with `--front-end-root`): nothing is fetched at the card answer. `/object_info` is fetched about 1 s after `reconnected` and contains the new class. The agent-placed node renders with its widget and no error. - **Browser test:** `agentRestartNodeRefresh.spec.ts` now delivers the restart while the old definitions are served, then drops and reopens `/ws` with the new node defined. On the parent it fails: `hasErrors: true, hasStepsWidget: false`. With this change it passes. - **Unit:** the store tests now reconnect after a restart. The first case, which checks that nothing refreshes until ComfyUI reconnects, fails on the parent. - typecheck, typecheck:browser, oxlint, oxfmt, plus the pre-commit and pre-push hooks pass. (cherry picked from commit 3821a0a)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-27T14:49:11.998Z",
"gitSha": "5f21b96d22403257c2fb61a22b0b00908fee36c0",
"branch": "backport-21644-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.2830000000065,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6590000000000003,
"layouts": 10,
"layoutDurationMs": 2.809,
"taskDurationMs": 402.3,
"heapDeltaBytes": 4871672,
"heapUsedBytes": 95129092,
"domNodes": -200,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 7.8580000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2026.3289999999756,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6760000000000006,
"layouts": 10,
"layoutDurationMs": 2.923,
"taskDurationMs": 408.17099999999994,
"heapDeltaBytes": 2777616,
"heapUsedBytes": 93574396,
"domNodes": -200,
"jsHeapTotalBytes": 2678784,
"scriptDurationMs": 8.552000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.8369999999843,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.241,
"layouts": 9,
"layoutDurationMs": 2.3249999999999997,
"taskDurationMs": 731.2800000000001,
"heapDeltaBytes": 7014476,
"heapUsedBytes": 97204408,
"domNodes": -200,
"jsHeapTotalBytes": 1892352,
"scriptDurationMs": 149.734,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1769.235999999978,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.832,
"layouts": 9,
"layoutDurationMs": 2.371,
"taskDurationMs": 761.753,
"heapDeltaBytes": 5897340,
"heapUsedBytes": 95864576,
"domNodes": -180,
"jsHeapTotalBytes": 2416640,
"scriptDurationMs": 160.345,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.4650000000188,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.733,
"layouts": 11,
"layoutDurationMs": 2.4499999999999997,
"taskDurationMs": 286.881,
"heapDeltaBytes": -1306848,
"heapUsedBytes": 88942788,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.154,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.0840000000617,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.371999999999999,
"layouts": 12,
"layoutDurationMs": 2.7929999999999997,
"taskDurationMs": 389.788,
"heapDeltaBytes": -970520,
"heapUsedBytes": 99352140,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.494,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 619.4050000000004,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5829999999999997,
"layouts": 9,
"layoutDurationMs": 2.4819999999999998,
"taskDurationMs": 443.37999999999994,
"heapDeltaBytes": 3327496,
"heapUsedBytes": 93551428,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 173.702,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 600.5030000000033,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.5260000000000002,
"layouts": 8,
"layoutDurationMs": 2.163,
"taskDurationMs": 434.14899999999994,
"heapDeltaBytes": 4154568,
"heapUsedBytes": 94456940,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 169.124,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1202.2759999999835,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 841.6009999999999,
"heapDeltaBytes": -15064152,
"heapUsedBytes": 102201620,
"domNodes": -230,
"jsHeapTotalBytes": 15007744,
"scriptDurationMs": 67.252,
"eventListeners": -168,
"totalBlockingTimeMs": 522,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1230.7210000000168,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 929.1419999999999,
"heapDeltaBytes": -15050932,
"heapUsedBytes": 102273448,
"domNodes": -210,
"jsHeapTotalBytes": 16580608,
"scriptDurationMs": 76.16499999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 542,
"frameDurationMs": 33.32972972972975,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.8539999999887,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.0200000000003,
"heapDeltaBytes": -4473172,
"heapUsedBytes": 97194544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.856,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 824.577999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.98399999999987,
"heapDeltaBytes": -3717408,
"heapUsedBytes": 97857140,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.171,
"eventListeners": 0,
"totalBlockingTimeMs": 208,
"frameDurationMs": 24.508823529411742,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9502.205000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8727.764,
"heapDeltaBytes": 1674300,
"heapUsedBytes": 121566104,
"domNodes": -276,
"jsHeapTotalBytes": -2207744,
"scriptDurationMs": 7326.197999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 939,
"frameDurationMs": 33.099999999999994,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9724.803000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8955.051000000001,
"heapDeltaBytes": 57946704,
"heapUsedBytes": 172119664,
"domNodes": -296,
"jsHeapTotalBytes": 42881024,
"scriptDurationMs": 7088.448,
"eventListeners": -130,
"totalBlockingTimeMs": 604,
"frameDurationMs": 31.64918566775244,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10345.261999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9538.942000000001,
"heapDeltaBytes": 31804240,
"heapUsedBytes": 140889440,
"domNodes": -276,
"jsHeapTotalBytes": 41213952,
"scriptDurationMs": 7644.907,
"eventListeners": -130,
"totalBlockingTimeMs": 706,
"frameDurationMs": 31.312121212121212,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8721.832000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7971.249,
"heapDeltaBytes": 26495840,
"heapUsedBytes": 135590768,
"domNodes": -296,
"jsHeapTotalBytes": 17620992,
"scriptDurationMs": 6536.3589999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 441,
"frameDurationMs": 32.40223048327138,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 243.24200000000928,
"styleRecalcs": 26,
"styleRecalcDurationMs": 13.834000000000001,
"layouts": 12,
"layoutDurationMs": 3.7100000000000004,
"taskDurationMs": 186.06000000000003,
"heapDeltaBytes": 13268540,
"heapUsedBytes": 118515088,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.250000000000004,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.21818181818187,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 256.0110000000009,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.937000000000001,
"layouts": 11,
"layoutDurationMs": 2.885,
"taskDurationMs": 201.666,
"heapDeltaBytes": 13297976,
"heapUsedBytes": 118752516,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.268,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.507692307692334,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2040.8270000000073,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3049999999999997,
"layouts": 9,
"layoutDurationMs": 2.4070000000000005,
"taskDurationMs": 645.8739999999999,
"heapDeltaBytes": 1164,
"heapUsedBytes": 109828396,
"domNodes": -297,
"jsHeapTotalBytes": -991232,
"scriptDurationMs": 30.838000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2044.1939999999477,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2079999999999997,
"layouts": 9,
"layoutDurationMs": 2.3649999999999998,
"taskDurationMs": 476.519,
"heapDeltaBytes": 1007652,
"heapUsedBytes": 111199760,
"domNodes": -276,
"jsHeapTotalBytes": -1253376,
"scriptDurationMs": 28.759,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2269.3419999999946,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.9030000000000005,
"layouts": 7,
"layoutDurationMs": 1.651,
"taskDurationMs": 1496.1890000000003,
"heapDeltaBytes": 495040,
"heapUsedBytes": 112499048,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 808.1270000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78955223880597,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2255.1039999999603,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.093,
"layouts": 5,
"layoutDurationMs": 1.3,
"taskDurationMs": 1499.524,
"heapDeltaBytes": 1748356,
"heapUsedBytes": 113197812,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 812.782,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.916541353383455,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3723.901000000012,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.837000000000002,
"layouts": 64,
"layoutDurationMs": 9.926,
"taskDurationMs": 1781.8700000000001,
"heapDeltaBytes": -16223960,
"heapUsedBytes": 97069552,
"domNodes": -272,
"jsHeapTotalBytes": -1122304,
"scriptDurationMs": 764.583,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74144144144144,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3508.8690000000042,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.841,
"layouts": 65,
"layoutDurationMs": 10.059999999999999,
"taskDurationMs": 1525.1739999999998,
"heapDeltaBytes": -2313176,
"heapUsedBytes": 111022500,
"domNodes": -272,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 749.846,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.745454545454546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2931.61699999996,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.086,
"layouts": 5,
"layoutDurationMs": 1.3049999999999997,
"taskDurationMs": 1901.6409999999996,
"heapDeltaBytes": -11856560,
"heapUsedBytes": 105108604,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 921.988,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.956976744186047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2945.3809999999976,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.362,
"layouts": 5,
"layoutDurationMs": 1.4130000000000003,
"taskDurationMs": 1949.7509999999997,
"heapDeltaBytes": -11250500,
"heapUsedBytes": 105872860,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 948.8829999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.954335260115602,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.713999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6579999999999997,
"layouts": 8,
"layoutDurationMs": 2.024,
"taskDurationMs": 487.4309999999999,
"heapDeltaBytes": -317368,
"heapUsedBytes": 112414788,
"domNodes": -296,
"jsHeapTotalBytes": -1515520,
"scriptDurationMs": 30.756999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2051.4439999999468,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7109999999999999,
"layouts": 8,
"layoutDurationMs": 5.326,
"taskDurationMs": 488.787,
"heapDeltaBytes": -29679952,
"heapUsedBytes": 89464584,
"domNodes": -296,
"jsHeapTotalBytes": -1478656,
"scriptDurationMs": 26.819999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 549.0709999999694,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.78,
"layouts": 10,
"layoutDurationMs": 2.441,
"taskDurationMs": 389.821,
"heapDeltaBytes": 322448,
"heapUsedBytes": 91957020,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 150.029,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.7259999999551,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.48,
"layouts": 11,
"layoutDurationMs": 3.2279999999999998,
"taskDurationMs": 388.44,
"heapDeltaBytes": -374632,
"heapUsedBytes": 101064404,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 151.819,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2038.831000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5820000000000003,
"layouts": 10,
"layoutDurationMs": 2.8249999999999997,
"taskDurationMs": 584.188,
"heapDeltaBytes": 530480,
"heapUsedBytes": 92933784,
"domNodes": -219,
"jsHeapTotalBytes": 319488,
"scriptDurationMs": 6.898,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.9200000000037,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5900000000000003,
"layouts": 10,
"layoutDurationMs": 2.8320000000000003,
"taskDurationMs": 379.78899999999993,
"heapDeltaBytes": 5855616,
"heapUsedBytes": 107256244,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 7.2250000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.588999999994,
"styleRecalcs": 86,
"styleRecalcDurationMs": 12.911999999999999,
"layouts": 9,
"layoutDurationMs": 3.068,
"taskDurationMs": 865.904,
"heapDeltaBytes": -6817540,
"heapUsedBytes": 94982332,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 102.72,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2026.7489999999952,
"styleRecalcs": 88,
"styleRecalcDurationMs": 13.396,
"layouts": 10,
"layoutDurationMs": 3.195,
"taskDurationMs": 1108.0529999999999,
"heapDeltaBytes": 4806604,
"heapUsedBytes": 107042212,
"domNodes": -218,
"jsHeapTotalBytes": 11423744,
"scriptDurationMs": 107.687,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.5099999999807,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.647000000000002,
"layouts": 5,
"layoutDurationMs": 13.873999999999997,
"taskDurationMs": 1038.763,
"heapDeltaBytes": 36025848,
"heapUsedBytes": 138140716,
"domNodes": 16030,
"jsHeapTotalBytes": 10625024,
"scriptDurationMs": 43.839,
"eventListeners": 3244,
"totalBlockingTimeMs": 165,
"frameDurationMs": 19.777333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8438.66799999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 25.428,
"layouts": 7,
"layoutDurationMs": 1.9169999999999998,
"taskDurationMs": 5728.762,
"heapDeltaBytes": 2800576,
"heapUsedBytes": 112536988,
"domNodes": -276,
"jsHeapTotalBytes": -274432,
"scriptDurationMs": 2611.864,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73234126984127,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.285999999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.792,
"layouts": 7,
"layoutDurationMs": 1.923,
"taskDurationMs": 5088.851,
"heapDeltaBytes": 3148864,
"heapUsedBytes": 114289088,
"domNodes": -296,
"jsHeapTotalBytes": 20480,
"scriptDurationMs": 2711.097,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733671399594318,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 21522.07699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21011.208,
"heapDeltaBytes": -2745864,
"heapUsedBytes": 307779204,
"domNodes": -3344,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 316.672,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.858532423208196,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 21108.429,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20603.739999999998,
"heapDeltaBytes": -31433464,
"heapUsedBytes": 288329352,
"domNodes": -3344,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 268.91200000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.94395229982964,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18932.394999999986,
"styleRecalcs": 164,
"styleRecalcDurationMs": 14.389000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18484.385,
"heapDeltaBytes": -30698520,
"heapUsedBytes": 293115192,
"domNodes": -3344,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 849.918,
"eventListeners": -651,
"totalBlockingTimeMs": 35,
"frameDurationMs": 33.92939068100358,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27237.496999999963,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26837.334999999995,
"heapDeltaBytes": -15081488,
"heapUsedBytes": 290142932,
"domNodes": -3344,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 838.172,
"eventListeners": -651,
"totalBlockingTimeMs": 30,
"frameDurationMs": 50.15138121546961,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 7918.993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.33900000000003,
"layouts": 20,
"layoutDurationMs": 26.948,
"taskDurationMs": 7788.034000000001,
"heapDeltaBytes": -39455608,
"heapUsedBytes": 265612644,
"domNodes": -3344,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 138.68599999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.132402234636864,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 5495.88099999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.03599999999999,
"layouts": 20,
"layoutDurationMs": 21.902000000000005,
"taskDurationMs": 5358.252,
"heapDeltaBytes": -20297760,
"heapUsedBytes": 303658576,
"domNodes": -3344,
"jsHeapTotalBytes": 37212160,
"scriptDurationMs": 118.16199999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.252941176470586,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7333.872000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7162.922000000001,
"heapDeltaBytes": 4367280,
"heapUsedBytes": 279049220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.51699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.525418060200664,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7260.770999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6785.041000000001,
"heapDeltaBytes": 27571896,
"heapUsedBytes": 303760380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.59999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.46599326599327,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "workflow-execution",
"durationMs": 487.7480000000105,
"styleRecalcs": 19,
"styleRecalcDurationMs": 9.717,
"layouts": 12,
"layoutDurationMs": 4.584,
"taskDurationMs": 144.87900000000002,
"heapDeltaBytes": -8849340,
"heapUsedBytes": 92741200,
"domNodes": 124,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 11.273,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 467.536999999993,
"styleRecalcs": 19,
"styleRecalcDurationMs": 10.269,
"layouts": 10,
"layoutDurationMs": 3.524,
"taskDurationMs": 108.28099999999999,
"heapDeltaBytes": 7066836,
"heapUsedBytes": 97263300,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.936000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 774.4420000000218,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6579999999999999,
"layouts": 76,
"layoutDurationMs": 19.605,
"taskDurationMs": 689.5819999999999,
"heapDeltaBytes": -11732024,
"heapUsedBytes": 84263880,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 342.401,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.028260869565223,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 472.8470000000016,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.639,
"layouts": 76,
"layoutDurationMs": 13.911,
"taskDurationMs": 420.002,
"heapDeltaBytes": -14360704,
"heapUsedBytes": 80224620,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 204.187,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 490.73699999996734,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.528,
"layouts": 76,
"layoutDurationMs": 14.189,
"taskDurationMs": 459.588,
"heapDeltaBytes": 254688,
"heapUsedBytes": 112564016,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 189.317,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 519.0450000000055,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.528,
"layouts": 76,
"layoutDurationMs": 14.845,
"taskDurationMs": 477.38,
"heapDeltaBytes": 404476,
"heapUsedBytes": 112721940,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 197.187,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2984 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 92f093e2e7bbb9553056609ba53b0f2a77a1cc18
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (120)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #22049 +/- ##
==========================================
Coverage 84.53% 84.53%
==========================================
Files 3090 3090
Lines 162712 162718 +6
Branches 39388 39385 -3
==========================================
+ Hits 137544 137560 +16
+ Misses 24776 24766 -10
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 96 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
|
@DrJKL ready for your review; the automated reviewer has been down since this morning.
Full context for agent readers
|
|
Base merged in, CI green at Full context for agent readers
|
There was a problem hiding this comment.
Verdict: faithful backport of #21644 to core/1.58.
I compared this head with merged source commit 3821a0a, verified on current main. All four src files carry the same hunks, including the tests and documentation. The target lacks the browser spec and fixture introduced by #21044, so the backport takes the complete spec from #21644's merged tree and the identical fixture from #21044's merged commit 9725d28. Applying those additions and the source hunks to the target merge base produces exactly this head's tree. No other adaptations or extra changes.
With core/1.58's own dependencies, AgentPanelRoot and agentNodeDefinitionRefreshStore pass all 488 tests. Playwright discovers both restart-report/reconnect ordering cases. Changed-source ESLint reports no errors; its configuration excludes the test files. All required CI checks pass at this head, including test, lint-and-format, and e2e-status.
…ent restart (#20903, #21644) (#22051) Backport of #20903 + #21644 to `core/1.57`. - Nodes the local agent installs stop showing as missing after it restarts ComfyUI - ComfyUI v0.43.0 (2026-10-27) pins frontend 1.57.4, which has neither fix - Carries #20903's dev-config guard too; only its boundary-doc records are left out (deleted on this branch) <details><summary>Full context for agent readers</summary> Why: default local installs follow ComfyUI's `requirements.txt` pin (`comfyui-frontend-package==1.57.4` at tag v0.43.0). The fix is in v1.60.0; 1.58 gets it via #22049/#22050. Without this, a default local user on comfy-agent 0.1.0-rc2+ still sees new nodes as missing after an agent restart (PM-2119 case 2). Risk: #20903 is `risk:xhigh` and touches `workflowService.reloadCurrentWorkflow` (forced reload keeps the active tab and unsaved agent edits). Open question: 1.57's agent events ride ComfyUI `/ws`, not `/api/agent/events`; the store's 10-minute reconnect window handles either order, but no live check on a 1.57 + comfy-agent rc4 stack has been done. Commits: 1. #20903 source-only: `agentNodeDefinitionRefreshStore` (+test), `AgentPanelRoot.vue` (+test), `useAgentSession` (+test), `workflowService` (+test), README. Left out: `docs/architecture/domains/**` (records deleted on this branch). 2. #21644 source + browser spec from main with its fixture from #21044. Verification on this branch (Node 26.8.2): store/session/workflowService/AgentPanelRoot unit tests 835/835; store test 6 red with commit 1's store, green with commit 2; `typecheck` and `typecheck:browser`, knip, oxfmt clean; eslint 0 errors. Commit 3: the browser spec used main's `getAgentSocket` fixture, absent on 1.57 (agent events ride `/ws` here), which failed `typecheck-aux` and left the Playwright plan empty. It now uses `getWebSocket`. Adversarial review: a fresh Claude reviewer (same model; the cross-model CLI is unavailable), Skeptic + Minimalist. It found the fixture blocker above (fixed). It confirmed by reading code that on 1.57 the store still gets the `restart_comfyui` success frame (listeners sit on `api`, so they survive the socket swap), that `src` uses no main-only API, and that the `reloadCurrentWorkflow` change is low risk for non-agent users. Still unverified: a live run on a 1.57 + comfy-agent rc4 stack. Commit 4 (review fix): #20903's `build/devAgentConfig.ts` standalone/cloud guard, the `vite.config.mts` distribution pass-through and both `scripts/vite-config-dev-agent.test.ts` cases. The subprocess refusal test was red before the source hunks and green after (22/22). typecheck app/build/scripts clean. Not included: #21841 (catalog-refresh model warnings). `cloud/1.57` not prepared: the restart path is local-only. Refs https://linear.app/comfyorg/issue/PM-2119, https://linear.app/comfyorg/issue/BE-21866 </details> --------- Co-authored-by: skishore23 <shimikeri.kishore@gmail.com>
Backport of #21644 to
core/1.58.core/1.58already has feat(agent): refresh node definitions after an agent restart #20903, so it has the bug since comfy-agent 0.1.0-rc2; this brings the fixFull context for agent readers
Auto-backport was not used: the cherry-pick conflicts on
browser_tests/tests/agent/agentRestartNodeRefresh.spec.ts, which #21044 added on main after the 1.58 cut. Resolved by taking main's version of the spec plusbrowser_tests/assets/agent/restart_node_refresh.json(from #21044). All its imports exist on this branch.The four
src/workbench/extensions/agentfiles applied cleanly.Verification on this branch (Node 26.8.2):
agentNodeDefinitionRefreshStore.test.ts: 6 tests red with the branch's old store, green with the fix (16/16)AgentPanelRoot.test.ts+ store test: 477/477pnpm typecheckclean, eslint/oxfmt clean on touched filesNot included: #21841 (catalog-refresh model warnings), a separate fix.
Refs https://linear.app/comfyorg/issue/PM-2119, https://linear.app/comfyorg/issue/BE-21866