Repository navigation
[backport core/1.57] refactor(workflow): report user-initiated tab activations - #21920
christian-byrne wants to merge 1 commit into
Conversation
Extracted from #21512 so the shared workflow and topbar paths can be reviewed without the 6,400-line Agent feature attached. **Nothing user-visible changes in this PR.** Two related changes to the workflow service: 1. **An explicit `initiator: 'user'` option** on `openWorkflow`, `loadNextOpenedWorkflow`, `loadPreviousOpenedWorkflow` and the new `closeWorkflows`, plus a `workflowStore.onUserActivation` event hook that fires only for those calls. The nine call sites that are genuinely a user clicking a tab, a menu item or a keybinding now pass it. Programmatic activations — including the page-hash restore on first load, which is retargeted from `'route'` to a new `'restore'` intent source — deliberately do not. **Nothing subscribes to the hook yet**, so it is inert until #21512 lands on top. 2. **`workflowService.closeWorkflows()`**, which absorbs the close-many loop that `WorkflowTabs.vue` and `BaseWorkflowsSidebarTab.vue` each reimplemented (break on the first close that returns false). Doing it in the service is what makes the batch report *at most one* user activation: `closeWorkflow` reports the replacement tab it opened through a new `onReplacementOpened` callback, and `closeWorkflows` reports only the replacement still active once the whole batch settles. The `closeWorkflows` consolidation is not a drive-by tidy-up. A per-tab close loop in the caller cannot tell "the user closed four tabs and landed on tab five" from "the user activated five tabs in a row", because each intermediate `closeWorkflow` opens a replacement. Moving the loop into the service is the only place that sees the whole batch, so the activation semantics and the consolidation have to land together. - `workflowService.ts` — the `closeWorkflows` `try`/`finally`, specifically that the `initiator === 'user' && workflowStore.isActive(replacement)` guard is what suppresses the superseded intermediate replacements. - `subgraphNavigationStore.ts` — the `'route'` → `'restore'` split on the initial-load intent. This is the one behavioural judgement call here: a restored page hash opens a workflow, and that is not a user activation. Explanatory comments in `workflowService.ts` and `subgraphNavigationStore.ts` that #21512 dropped are preserved here. - **Unit tests:** 235 passing across the 5 changed suites, including a new `describe('user activations')` block in `workflowService.test.ts` (+177) covering: a user-initiated open reports; a failed load does not report; a batch close reports once; a tab something else activated mid-close does not report; a superseded replacement does not report; and an earlier close's tab is still reported when a later close throws. New `subgraphNavigationStore` case asserts a restored page hash opens the workflow *without* `initiator: 'user'`. - **No-regression sweep:** 1,291 further tests passing across the 24 other suites that exercise `openWorkflow`/`closeWorkflow`, including the Agent suites (`AgentPanelRoot.test.ts`, 647 tests) that mock the service. - **Commit gates:** app typecheck, scoped type-aware oxlint, eslint, stylelint, oxfmt, server-facts — all clean. Push gates: Fallow changed-line audit clean on all 15 files. - Base at verification: `479cecf9ac9c98ad65b6aca186775793a7d30bc6`. - **#21512 is the dependent.** It carries the Agent tab→chat follow feature (PM-1270, PM-1257) that consumes `onUserActivation`. These hunks will drop out of its diff when it rebases after this merges. - No new user-facing strings, no i18n change, no Agent paths touched. --------- Co-authored-by: christian-byrne <chrbyrne96@gmail.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-24T22:50:53.371Z",
"gitSha": "cddfe826f9d363f7b95b4477f415b19fc176fbc1",
"branch": "backport-21791-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.9270000000188,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.6710000000000007,
"layouts": 10,
"layoutDurationMs": 3.4450000000000003,
"taskDurationMs": 510.08199999999994,
"heapDeltaBytes": 3228384,
"heapUsedBytes": 78672868,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 8.696000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.392999999979,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6670000000000003,
"layouts": 9,
"layoutDurationMs": 2.452,
"taskDurationMs": 499.85200000000003,
"heapDeltaBytes": -907708,
"heapUsedBytes": 75047100,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8.703,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1959.6119999999928,
"styleRecalcs": 83,
"styleRecalcDurationMs": 15.948999999999998,
"layouts": 9,
"layoutDurationMs": 2.951,
"taskDurationMs": 911.664,
"heapDeltaBytes": 15652952,
"heapUsedBytes": 81934688,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 163.44799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1745.0279999999339,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.342,
"layouts": 10,
"layoutDurationMs": 2.588,
"taskDurationMs": 862.937,
"heapDeltaBytes": 15186644,
"heapUsedBytes": 81614068,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 162.981,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1697.6920000000177,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.452,
"layouts": 10,
"layoutDurationMs": 3.07,
"taskDurationMs": 387.80499999999995,
"heapDeltaBytes": 18765068,
"heapUsedBytes": 84211784,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.060999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.0820000000103,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.687,
"layouts": 12,
"layoutDurationMs": 3.575,
"taskDurationMs": 285.17499999999995,
"heapDeltaBytes": 18750928,
"heapUsedBytes": 85207580,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.712,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 594.2309999999793,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8509999999999995,
"layouts": 9,
"layoutDurationMs": 2.6819999999999995,
"taskDurationMs": 426.879,
"heapDeltaBytes": 25639436,
"heapUsedBytes": 91907896,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 168.402,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 676.8860000000814,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.0300000000000007,
"layouts": 9,
"layoutDurationMs": 2.563,
"taskDurationMs": 501.6130000000001,
"heapDeltaBytes": 6712848,
"heapUsedBytes": 81731060,
"domNodes": 0,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 167.22199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1334.3519999999671,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1044.8870000000002,
"heapDeltaBytes": 477788,
"heapUsedBytes": 81098996,
"domNodes": -212,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 95.433,
"eventListeners": -106,
"totalBlockingTimeMs": 622,
"frameDurationMs": 34.18717948717949,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.9400000000505,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 908.23,
"heapDeltaBytes": 1376572,
"heapUsedBytes": 81389016,
"domNodes": -192,
"jsHeapTotalBytes": 13115392,
"scriptDurationMs": 69.798,
"eventListeners": -106,
"totalBlockingTimeMs": 529,
"frameDurationMs": 32.883783783783805,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.6759999999831,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.7379999999999,
"heapDeltaBytes": -4560192,
"heapUsedBytes": 76486992,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 154.804,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.4470000000783,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.52099999999973,
"heapDeltaBytes": -4775808,
"heapUsedBytes": 76565028,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 156.77800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10231.56899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9358.336,
"heapDeltaBytes": -649428,
"heapUsedBytes": 95868172,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7529.875000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 949,
"frameDurationMs": 31.72732919254658,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9996.553999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9169.406,
"heapDeltaBytes": -27483300,
"heapUsedBytes": 71931864,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7387.170999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 761,
"frameDurationMs": 31.2484375,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9005.079000000023,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05400000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8238.884,
"heapDeltaBytes": -20671680,
"heapUsedBytes": 77995516,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 6941.109,
"eventListeners": -68,
"totalBlockingTimeMs": 698,
"frameDurationMs": 32.25663082437276,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10301.617999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9527.875,
"heapDeltaBytes": -24692328,
"heapUsedBytes": 70163804,
"domNodes": -278,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 7745.765,
"eventListeners": -68,
"totalBlockingTimeMs": 1044,
"frameDurationMs": 31.022891566265063,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 221.6359999999895,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.711000000000002,
"layouts": 11,
"layoutDurationMs": 2.985,
"taskDurationMs": 164.374,
"heapDeltaBytes": -8260720,
"heapUsedBytes": 79495888,
"domNodes": 917,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.381000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.680000000000017,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 233.1729999999652,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.866,
"layouts": 11,
"layoutDurationMs": 3.041,
"taskDurationMs": 172.966,
"heapDeltaBytes": -8099372,
"heapUsedBytes": 79280120,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.750999999999998,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090843,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2041.6799999999853,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.341,
"layouts": 8,
"layoutDurationMs": 1.9420000000000002,
"taskDurationMs": 453.9740000000001,
"heapDeltaBytes": -8279708,
"heapUsedBytes": 71001616,
"domNodes": -278,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 30.632999999999992,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.1479999999883,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0479999999999996,
"layouts": 7,
"layoutDurationMs": 1.8520000000000003,
"taskDurationMs": 630.9810000000001,
"heapDeltaBytes": -25401024,
"heapUsedBytes": 73257088,
"domNodes": -278,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 36.823,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2420.898999999963,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.764,
"layouts": 6,
"layoutDurationMs": 1.723,
"taskDurationMs": 1706.8819999999998,
"heapDeltaBytes": -11891424,
"heapUsedBytes": 68322404,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 823.164,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78125,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2395.59399999996,
"styleRecalcs": 65,
"styleRecalcDurationMs": 5.122000000000001,
"layouts": 4,
"layoutDurationMs": 1.029,
"taskDurationMs": 1681.2779999999998,
"heapDeltaBytes": -7217752,
"heapUsedBytes": 91485812,
"domNodes": -278,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 806.751,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78251748251748,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3669.3440000000237,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.075999999999999,
"layouts": 64,
"layoutDurationMs": 10.568999999999999,
"taskDurationMs": 1773.533,
"heapDeltaBytes": -5809116,
"heapUsedBytes": 76024640,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 769.546,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3787.021999999979,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.508000000000001,
"layouts": 64,
"layoutDurationMs": 10.166,
"taskDurationMs": 1823.4219999999998,
"heapDeltaBytes": -18828120,
"heapUsedBytes": 81127288,
"domNodes": -254,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 805.898,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.739380530973452,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3012.613999999985,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.534,
"layouts": 4,
"layoutDurationMs": 1.0719999999999996,
"taskDurationMs": 1894.724,
"heapDeltaBytes": 16108008,
"heapUsedBytes": 98789360,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 913.532,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75888888888889,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3082.9159999999547,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.628,
"layouts": 5,
"layoutDurationMs": 1.1440000000000001,
"taskDurationMs": 1964.6930000000002,
"heapDeltaBytes": 5739344,
"heapUsedBytes": 83794956,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 954.8510000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.938043478260866,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2053.5320000000183,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.551,
"layouts": 8,
"layoutDurationMs": 2.6249999999999996,
"taskDurationMs": 472.17900000000003,
"heapDeltaBytes": -2805304,
"heapUsedBytes": 77866684,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 36.731,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2041.247999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.214999999999999,
"layouts": 8,
"layoutDurationMs": 2.481,
"taskDurationMs": 459.649,
"heapDeltaBytes": -1821944,
"heapUsedBytes": 79692548,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 29.470000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.9139999999957,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.531999999999999,
"layouts": 9,
"layoutDurationMs": 2.7870000000000004,
"taskDurationMs": 371.317,
"heapDeltaBytes": 19872076,
"heapUsedBytes": 86889172,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 143.47500000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.0569999999734,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.07,
"layouts": 10,
"layoutDurationMs": 2.5920000000000005,
"taskDurationMs": 434.216,
"heapDeltaBytes": -1061436,
"heapUsedBytes": 76050648,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 145.31,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.594999999967,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.409,
"layouts": 8,
"layoutDurationMs": 2.215,
"taskDurationMs": 491.25900000000007,
"heapDeltaBytes": 22434496,
"heapUsedBytes": 89399832,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.76,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.2470000000449,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.531000000000001,
"layouts": 9,
"layoutDurationMs": 2.4830000000000005,
"taskDurationMs": 507.08500000000004,
"heapDeltaBytes": -238732,
"heapUsedBytes": 77022668,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7.952000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1940.0829999999587,
"styleRecalcs": 85,
"styleRecalcDurationMs": 16.085,
"layouts": 8,
"layoutDurationMs": 2.192,
"taskDurationMs": 896.6469999999999,
"heapDeltaBytes": 11621304,
"heapUsedBytes": 79037128,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 114.39899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.1929999999647,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.142999999999999,
"layouts": 9,
"layoutDurationMs": 2.198,
"taskDurationMs": 646.78,
"heapDeltaBytes": 10826340,
"heapUsedBytes": 78258192,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 109.54700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.9900000000193,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.412000000000006,
"layouts": 5,
"layoutDurationMs": 17.002,
"taskDurationMs": 1060.662,
"heapDeltaBytes": 7548176,
"heapUsedBytes": 99414620,
"domNodes": 15953,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 29.680999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 168,
"frameDurationMs": 19.517105263157884,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9272.643000000016,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.037999999999997,
"layouts": 7,
"layoutDurationMs": 2.084,
"taskDurationMs": 5880.910999999999,
"heapDeltaBytes": -10767048,
"heapUsedBytes": 68972488,
"domNodes": -278,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 2667.534,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666068222621185,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8305.111000000012,
"styleRecalcs": 248,
"styleRecalcDurationMs": 18.113,
"layouts": 6,
"layoutDurationMs": 1.578,
"taskDurationMs": 5024.428,
"heapDeltaBytes": -9622984,
"heapUsedBytes": 69445564,
"domNodes": -278,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 2612.9069999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733266129032256,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23018.410000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22489.736,
"heapDeltaBytes": -15208060,
"heapUsedBytes": 265128880,
"domNodes": -3330,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 304.526,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.88063943161634,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 23046.778000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22395.144,
"heapDeltaBytes": -22500456,
"heapUsedBytes": 278227908,
"domNodes": -2754,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 317.756,
"eventListeners": -535,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.50686106346484,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27855.701000000012,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.971000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27516.536000000004,
"heapDeltaBytes": -9172336,
"heapUsedBytes": 273103652,
"domNodes": -3330,
"jsHeapTotalBytes": 5754880,
"scriptDurationMs": 897.0279999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 76,
"frameDurationMs": 51.03571428571428,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27922.447999999917,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.085999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27571.62,
"heapDeltaBytes": -23110096,
"heapUsedBytes": 272011536,
"domNodes": -3330,
"jsHeapTotalBytes": 9428992,
"scriptDurationMs": 907.4720000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 54,
"frameDurationMs": 50.84808743169398,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8322.168999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.56299999999997,
"layouts": 20,
"layoutDurationMs": 27.142,
"taskDurationMs": 8196.688,
"heapDeltaBytes": -13918224,
"heapUsedBytes": 277375820,
"domNodes": -3330,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 119.23100000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.72078651685393,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8250.066999999945,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.52900000000001,
"layouts": 20,
"layoutDurationMs": 21.981,
"taskDurationMs": 8110.221,
"heapDeltaBytes": -39049528,
"heapUsedBytes": 257237652,
"domNodes": -3330,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 141.02100000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.60847457627119,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11412.025000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11104.988999999998,
"heapDeltaBytes": 3675584,
"heapUsedBytes": 260248244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.43699999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.56858108108108,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11500.601000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11154.332999999997,
"heapDeltaBytes": 4292704,
"heapUsedBytes": 272014020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.845,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.73321799307958,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 159.68399999997018,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.075999999999999,
"layouts": 9,
"layoutDurationMs": 3.671,
"taskDurationMs": 126.196,
"heapDeltaBytes": -15103572,
"heapUsedBytes": 68617100,
"domNodes": 97,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 11.064,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.41428571428573,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 479.61799999995947,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.476999999999999,
"layouts": 10,
"layoutDurationMs": 3.3939999999999997,
"taskDurationMs": 120.01799999999999,
"heapDeltaBytes": -8790248,
"heapUsedBytes": 70866932,
"domNodes": 95,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 11.036000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 526.1530000000221,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.289,
"layouts": 76,
"layoutDurationMs": 14.297,
"taskDurationMs": 479.506,
"heapDeltaBytes": -20745536,
"heapUsedBytes": 71496204,
"domNodes": 4,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 238.259,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 456.9410000000289,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3840000000000001,
"layouts": 76,
"layoutDurationMs": 14.467,
"taskDurationMs": 410.968,
"heapDeltaBytes": 11129708,
"heapUsedBytes": 94802548,
"domNodes": 4,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 201.34,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 682.0699999999533,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.359,
"layouts": 76,
"layoutDurationMs": 15.702,
"taskDurationMs": 640.36,
"heapDeltaBytes": 6337724,
"heapUsedBytes": 138526532,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 262.22999999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 502.4029999999584,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.804,
"layouts": 76,
"layoutDurationMs": 14.316,
"taskDurationMs": 456.189,
"heapDeltaBytes": -136724,
"heapUsedBytes": 126854344,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 186.623,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2282 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (21 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b59472cb23fa3e44c275d0d14d1ed8aeee724eea
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.57 #21920 +/- ##
=============================================
- Coverage 84.12% 84.12% -0.01%
=============================================
Files 2840 2840
Lines 158064 158100 +36
Branches 40601 40612 +11
=============================================
+ Hits 132970 133000 +30
- Misses 24705 24711 +6
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #21791 to
core/1.57.The automated cherry-pick conflicted only in
subgraphNavigationStore.ts. This repair preserves the release branch’s direct workflow-service access and applies #21791’s activation-source contract: route navigation reports user intent, initial restoration does not, and workflow opens receive the matching initiator.Validation: 250 focused tests pass across subgraph navigation, workflow service, workflow tabs, and workflow actions; formatting and app typecheck pass.