Repository navigation
[backport cloud/1.57] fix(agent): gate canvas-affecting claims on observed canvas state (PM-1343, PM-1996, PM-1586) - #21917
Conversation
Prerequisite for the #20741 backport: that PR's confirmed-write gate reads the terminal tool frame's `workflow_id` / `op_ids`, which do not exist on this branch without this change. Release resolutions, all forced by machinery that lives only on `main`: - `agentApiSchema.ts`: upstream derives `zAgentToolCallData` from the generated `zAgentToolCallData` in `@comfyorg/ingest-types`, which this branch does not export. The four correlation fields are written out with the generated shapes instead, each `.catch(undefined)` as upstream has it. - `useAgentCrdtFollower.ts`: `settleCollectedProjection` is not carried -- its other half drives the projection-staleness latch (`markProjectionStale` / `clearProjectionStaleness` / `projection.hasPendingFailure`), which does not exist here. Only the applied-frame notification is carried, with the clean-apply test inlined. `settleCatchUpProjection` and `clearSyncStaleness` likewise absent. `projectionAppliedCleanly` is added locally (same body as upstream). `AgentCrdtFollowerEvents` stays exported, as on this branch. - `AgentPanelRoot.vue`: `useAgentCrdtFollower` still takes positional `getGraph` and `events` arguments here, not upstream's options object. - `agentCanvasLagsToolCallCompletion.spec.ts`: the host frames go through this branch's local `send()` helper rather than `hostSocket.send()`. - `agentConversationStore.ts`: relative import paths, as on this branch. Verified: `pnpm typecheck:browser`, `pnpm typecheck:app`, and 235 tests across `agentApiSchema.test.ts`, `agentEventTransport.test.ts` and `useAgentCrdtFollower.test.ts`. (cherry picked from commit 454b1cd)
…-1343, PM-1996, PM-1586) (#20741) Backport of #20741 to cloud/1.57. PM-1343, PM-1996 and PM-1586 share one user-visible failure: the agent reports successful canvas work while the canvas is empty or unchanged. A successful canvas-mutating tool now reads as confirmed only when the operations it names are observed on that workflow through the follower path, and a completed turn that claims canvas content over a still-empty bound canvas says so explicitly. Carried on top of #21369 in the preceding commit, which this change reads `workflow_id` / `op_ids` from. Release resolutions: - The follower's typed `terminal` state (`null | 'refused' | 'schema_error'`) does not exist on this branch. `AgentPanelRoot.vue` latches the one signal that does -- `onSyncError`, which fires on exactly those two conditions -- and releases it when the follower resubscribes. The load-bearing distinction is preserved: not-yet-connected reads `'none'`, permanently refused reads `'unavailable'`. - `browser_tests/tests/agent/agentSchemaSkewTellsTheUser.spec.ts` does not exist on this branch, so upstream's one-assertion update to it is dropped rather than the whole spec being introduced. - `agentToolCallHistoryPersistence.spec.ts`: upstream's `TRACE` interleaves thinking rows this branch's trace does not carry (#21600). The row this fix changes is asserted the same way; the thinking rows are not added. - `AgentPanel.test.ts`: only the new empty-canvas-priority case is added. The two adjacent upstream cases were conflict context, not part of this change. - `AgentPanelRoot.test.ts`: `dispatchApiEvent` is defined locally, as it is upstream. - `oxlint-suppressions.json` keeps this branch's entries: the one suppression upstream removes is not present here. - Relative import paths and `GetFeaturesResponse`, as on this branch. Verified on this branch: `pnpm typecheck:browser`, `pnpm typecheck:app`, and the full agent unit suite -- 166 files, 3,590 tests pass, 1 expected fail. The black-box proof travels with the carrier as `browser_tests/tests/agent/agentCanvasClaimNeedsObservation.spec.ts`. (cherry picked from commit 08b4792) Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-25T17:35:30.007Z",
"gitSha": "97fe743a3c91c80f04e73edd216f231428819cae",
"branch": "backport-20741-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.2360000000208,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6319999999999997,
"layouts": 10,
"layoutDurationMs": 2.7880000000000003,
"taskDurationMs": 507.706,
"heapDeltaBytes": -918232,
"heapUsedBytes": 74576204,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.176,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2021.9620000000305,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1229999999999998,
"layouts": 9,
"layoutDurationMs": 2.9370000000000003,
"taskDurationMs": 573.2629999999999,
"heapDeltaBytes": -880192,
"heapUsedBytes": 74145888,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 13.342,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.3069999999802,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.194,
"layouts": 9,
"layoutDurationMs": 2.5719999999999996,
"taskDurationMs": 901.45,
"heapDeltaBytes": 15217360,
"heapUsedBytes": 81007032,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 173.03400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.9680000000562,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.226999999999997,
"layouts": 9,
"layoutDurationMs": 2.811,
"taskDurationMs": 769.586,
"heapDeltaBytes": 15640260,
"heapUsedBytes": 81499548,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 172.411,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.1390000000083,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.7330000000000005,
"layouts": 12,
"layoutDurationMs": 3.4419999999999997,
"taskDurationMs": 314.67300000000006,
"heapDeltaBytes": 18367828,
"heapUsedBytes": 84512232,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 13.305000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.72799999998,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.3389999999999995,
"layouts": 11,
"layoutDurationMs": 3.5769999999999995,
"taskDurationMs": 330.876,
"heapDeltaBytes": 18835804,
"heapUsedBytes": 84826916,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 14.746000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 691.8309999999792,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.633000000000001,
"layouts": 9,
"layoutDurationMs": 2.836,
"taskDurationMs": 485.938,
"heapDeltaBytes": 26082552,
"heapUsedBytes": 91919372,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 171.173,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 633.1640000000789,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0549999999999997,
"layouts": 9,
"layoutDurationMs": 2.8320000000000003,
"taskDurationMs": 451.8740000000001,
"heapDeltaBytes": 25284748,
"heapUsedBytes": 91146812,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 173.648,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1251.2439999999856,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 916.745,
"heapDeltaBytes": -11331152,
"heapUsedBytes": 81372480,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 71.00600000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 566,
"frameDurationMs": 33.7810810810811,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1369.3339999999807,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1030.013,
"heapDeltaBytes": -11306048,
"heapUsedBytes": 81403160,
"domNodes": -192,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 87.212,
"eventListeners": -105,
"totalBlockingTimeMs": 664,
"frameDurationMs": 35.96052631578947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.5310000000136,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.929,
"heapDeltaBytes": -4038664,
"heapUsedBytes": 75767332,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 167.08700000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 25.48823529411763,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.2469999999585,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.073,
"heapDeltaBytes": -5056836,
"heapUsedBytes": 75862668,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 164.121,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9729.22299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8779.073,
"heapDeltaBytes": -10606864,
"heapUsedBytes": 88712452,
"domNodes": -278,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 7355.296,
"eventListeners": -68,
"totalBlockingTimeMs": 1020,
"frameDurationMs": 31.911147540983606,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10588.121000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9788.064,
"heapDeltaBytes": -19773780,
"heapUsedBytes": 75243284,
"domNodes": -278,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 7922.264999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 957,
"frameDurationMs": 31.68532934131737,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9049.66300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8266.225999999999,
"heapDeltaBytes": -7460528,
"heapUsedBytes": 91497492,
"domNodes": -254,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 6977.361,
"eventListeners": -68,
"totalBlockingTimeMs": 796,
"frameDurationMs": 32.56120996441281,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9519.547999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8680.246000000001,
"heapDeltaBytes": -8831196,
"heapUsedBytes": 91456392,
"domNodes": -258,
"jsHeapTotalBytes": 9039872,
"scriptDurationMs": 7336.393,
"eventListeners": -68,
"totalBlockingTimeMs": 939,
"frameDurationMs": 31.51092715231788,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 218.25900000004594,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.04,
"layouts": 11,
"layoutDurationMs": 3.364,
"taskDurationMs": 160.183,
"heapDeltaBytes": -8078512,
"heapUsedBytes": 79641480,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.475,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.659999999999947,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 233.0819999999676,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.731,
"layouts": 11,
"layoutDurationMs": 3.3979999999999997,
"taskDurationMs": 175.58200000000002,
"heapDeltaBytes": -8190200,
"heapUsedBytes": 79189132,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.848,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.319999999999983,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2054.4330000000173,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.167,
"layouts": 8,
"layoutDurationMs": 2.0170000000000003,
"taskDurationMs": 616.773,
"heapDeltaBytes": -20995088,
"heapUsedBytes": 75830376,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 30.955999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2041.029999999978,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.574,
"layouts": 8,
"layoutDurationMs": 2.4870000000000005,
"taskDurationMs": 703.8579999999998,
"heapDeltaBytes": -25445420,
"heapUsedBytes": 72102768,
"domNodes": -278,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 36.269999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2410.228000000018,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.312999999999999,
"layouts": 7,
"layoutDurationMs": 1.8480000000000003,
"taskDurationMs": 1659.9149999999997,
"heapDeltaBytes": -9468380,
"heapUsedBytes": 71829140,
"domNodes": -278,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 945.95,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78125,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2324.7010000000046,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.662999999999999,
"layouts": 7,
"layoutDurationMs": 2.008,
"taskDurationMs": 1557.1309999999999,
"heapDeltaBytes": 5649044,
"heapUsedBytes": 86451740,
"domNodes": -278,
"jsHeapTotalBytes": 3497984,
"scriptDurationMs": 806.788,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.907971014492755,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3778.9300000000026,
"styleRecalcs": 71,
"styleRecalcDurationMs": 6.931,
"layouts": 64,
"layoutDurationMs": 9.75,
"taskDurationMs": 1789.6560000000002,
"heapDeltaBytes": -18624600,
"heapUsedBytes": 81241440,
"domNodes": -234,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 815.407,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3722.1989999999323,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.6610000000000005,
"layouts": 64,
"layoutDurationMs": 11,
"taskDurationMs": 1797.1879999999999,
"heapDeltaBytes": 684568,
"heapUsedBytes": 79964344,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 830.23,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591928251121,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2965.067000000033,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.697,
"layouts": 4,
"layoutDurationMs": 1.009,
"taskDurationMs": 1929.7560000000003,
"heapDeltaBytes": 604820,
"heapUsedBytes": 79704832,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 945.5720000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.953448275862073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2642.332999999894,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.735999999999999,
"layouts": 5,
"layoutDurationMs": 1.1969999999999996,
"taskDurationMs": 1696.4709999999998,
"heapDeltaBytes": 3490804,
"heapUsedBytes": 86551788,
"domNodes": 0,
"jsHeapTotalBytes": 5992448,
"scriptDurationMs": 922.668,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.879487179487178,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.079000000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.436,
"layouts": 7,
"layoutDurationMs": 2.2059999999999995,
"taskDurationMs": 702.172,
"heapDeltaBytes": -24939320,
"heapUsedBytes": 73915544,
"domNodes": -278,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 42.466,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.00000000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1470000000000007,
"layouts": 7,
"layoutDurationMs": 2.26,
"taskDurationMs": 684.1790000000001,
"heapDeltaBytes": -26435684,
"heapUsedBytes": 72414772,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 35.76100000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 666.2509999999884,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.85,
"layouts": 8,
"layoutDurationMs": 2.3899999999999997,
"taskDurationMs": 469.65200000000004,
"heapDeltaBytes": 21668872,
"heapUsedBytes": 88597356,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 145.81199999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.6619999999948,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.514999999999999,
"layouts": 8,
"layoutDurationMs": 2.194,
"taskDurationMs": 421.7,
"heapDeltaBytes": 20321800,
"heapUsedBytes": 87358488,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 144.196,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.2830000000154,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9190000000000005,
"layouts": 9,
"layoutDurationMs": 3.0760000000000005,
"taskDurationMs": 407.34899999999993,
"heapDeltaBytes": 22486060,
"heapUsedBytes": 89304920,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.203000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2024.3460000000368,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1990000000000003,
"layouts": 9,
"layoutDurationMs": 3.0839999999999996,
"taskDurationMs": 582.4090000000001,
"heapDeltaBytes": -226788,
"heapUsedBytes": 76423264,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.706999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.2850000000403,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.530000000000001,
"layouts": 10,
"layoutDurationMs": 2.5519999999999996,
"taskDurationMs": 659.5500000000001,
"heapDeltaBytes": 11193948,
"heapUsedBytes": 78729296,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 108.863,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.1710000000267,
"styleRecalcs": 88,
"styleRecalcDurationMs": 17.955,
"layouts": 9,
"layoutDurationMs": 2.4890000000000003,
"taskDurationMs": 1051.4709999999998,
"heapDeltaBytes": -11393912,
"heapUsedBytes": 66569476,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 114.49900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66525423728813,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.699999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.719,
"layouts": 5,
"layoutDurationMs": 16.631,
"taskDurationMs": 1068.4040000000002,
"heapDeltaBytes": 4867612,
"heapUsedBytes": 101230576,
"domNodes": 15953,
"jsHeapTotalBytes": 16912384,
"scriptDurationMs": 32.522,
"eventListeners": 3244,
"totalBlockingTimeMs": 162,
"frameDurationMs": 19.55466666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8313.936000000012,
"styleRecalcs": 248,
"styleRecalcDurationMs": 18.158,
"layouts": 6,
"layoutDurationMs": 1.7129999999999999,
"taskDurationMs": 5368.733000000001,
"heapDeltaBytes": 13803536,
"heapUsedBytes": 93266416,
"domNodes": -258,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 2908.5190000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80060606060606,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8319.283999999925,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.498,
"layouts": 7,
"layoutDurationMs": 2.357,
"taskDurationMs": 5034.891,
"heapDeltaBytes": -10815224,
"heapUsedBytes": 68935856,
"domNodes": -278,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 2637.484,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733064516129033,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16924.326999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16248.242999999999,
"heapDeltaBytes": -8153836,
"heapUsedBytes": 283064992,
"domNodes": -3330,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 267.09800000000007,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.093814432989696,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 23485.89400000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23060.657,
"heapDeltaBytes": -24625844,
"heapUsedBytes": 266659312,
"domNodes": -3330,
"jsHeapTotalBytes": 8638464,
"scriptDurationMs": 322.434,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.95235602094241,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 19471.303999999975,
"styleRecalcs": 154,
"styleRecalcDurationMs": 13.918000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18983.440000000002,
"heapDeltaBytes": -1419580,
"heapUsedBytes": 284897364,
"domNodes": -3330,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 832.584,
"eventListeners": -651,
"totalBlockingTimeMs": 20,
"frameDurationMs": 35.71724770642202,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 28012.26200000008,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.308999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27617.645000000004,
"heapDeltaBytes": -17175760,
"heapUsedBytes": 284018228,
"domNodes": -3330,
"jsHeapTotalBytes": 3850240,
"scriptDurationMs": 847.3980000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 52.17057728119181,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 6207.141999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.64699999999999,
"layouts": 20,
"layoutDurationMs": 25.740999999999985,
"taskDurationMs": 6082.543000000001,
"heapDeltaBytes": 1602668,
"heapUsedBytes": 273797824,
"domNodes": -3330,
"jsHeapTotalBytes": 23580672,
"scriptDurationMs": 104.393,
"eventListeners": -653,
"totalBlockingTimeMs": 20,
"frameDurationMs": 35.53563218390804,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8449.712999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.26599999999999,
"layouts": 20,
"layoutDurationMs": 22.853999999999985,
"taskDurationMs": 8326.71,
"heapDeltaBytes": -25953944,
"heapUsedBytes": 269415572,
"domNodes": -307,
"jsHeapTotalBytes": 24109056,
"scriptDurationMs": 134.39499999999998,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.67405405405405,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8196.84699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7566.9310000000005,
"heapDeltaBytes": 11698192,
"heapUsedBytes": 269087764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.73600000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.081164383561635,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11403.497000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11118.842,
"heapDeltaBytes": -20375412,
"heapUsedBytes": 253282888,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.27199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.90648464163822,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 131.9499999999607,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.847000000000001,
"layouts": 9,
"layoutDurationMs": 6.194,
"taskDurationMs": 108.712,
"heapDeltaBytes": -10351852,
"heapUsedBytes": 68912356,
"domNodes": 120,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 11.774,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 503.39899999994486,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.886000000000001,
"layouts": 10,
"layoutDurationMs": 4.097999999999999,
"taskDurationMs": 141.683,
"heapDeltaBytes": 6714180,
"heapUsedBytes": 79021044,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.317,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034481,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 485.51099999997405,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.287,
"layouts": 76,
"layoutDurationMs": 15.270999999999999,
"taskDurationMs": 438.285,
"heapDeltaBytes": 11760124,
"heapUsedBytes": 103331256,
"domNodes": 4,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 216.758,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 463.2409999999254,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3519999999999999,
"layouts": 76,
"layoutDurationMs": 15.937,
"taskDurationMs": 419.267,
"heapDeltaBytes": -14060816,
"heapUsedBytes": 81268632,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 199.939,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 501.29200000003493,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.971,
"layouts": 76,
"layoutDurationMs": 14.068000000000001,
"taskDurationMs": 466.9800000000001,
"heapDeltaBytes": -508584,
"heapUsedBytes": 118190128,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 182.052,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 645.8350000000337,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.022,
"layouts": 76,
"layoutDurationMs": 16.424999999999997,
"taskDurationMs": 598.755,
"heapDeltaBytes": 937296,
"heapUsedBytes": 132301112,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 256.05899999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2283 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7aebefb8863f5bb2f1fec9222979301a5269839b
Full docs: ADR-DEVEX-LINT-0015 |
…n for it The first pass at this backport replaced upstream's typed `terminal` status with a latch on `onSyncError` in `AgentPanelRoot.vue`, on the grounds that `onSyncError` fires on the same two conditions. It does not fire often enough: `handleSubscribeRefusal` suppresses the notification for `unsupported` and for a refusal that repeats on a workflow already notified, so a refused subscribe left the summary reading "Worked" instead of "Changes not confirmed on your canvas". CI caught it: `agentRefusedDocSubscribe` and `agentZeroNodesOnUnreadableSchema` both failed on exactly that assertion. Carried properly instead. `AgentCrdtDocLifecycle.refusalIsFinal()` is added with upstream's body, which is a pure derivation over `confirmedSinceLastSend` and `subscribeRetryTimer` -- both already present here, with identical semantics: the refusal and retry-ladder paths differ from `main` only in cosmetics. The follower gains the `terminal` ref and sets it at upstream's four sites, `AgentCrdtStatus` exposes it, and `AgentPanelRoot.vue` reads `status.terminal === null ? 'none' : 'unavailable'` as upstream does. `AgentCrdtTerminalState` is declared locally as `'refused' | 'schema_error' | null`: upstream types it in `agentCrdtStatus.ts` over `SubscribeGiveUpReason`, and neither that module nor that union exists on this branch, so the two values the follower actually sets are named directly. Four status fixtures gain `terminal: null`, as their upstream counterparts carry. Verified: `pnpm typecheck:app`, `pnpm typecheck:browser`, and 167 files / 3,594 unit tests pass.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.57 #21917 +/- ##
=============================================
Coverage ? 85.21%
=============================================
Files ? 2524
Lines ? 133096
Branches ? 38330
=============================================
Hits ? 113413
Misses ? 19267
Partials ? 416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Current-head review at 674b6fd. One blocking release-resolution omission is inline; no other finding from the reviewed delta.
…rved canvas state (PM-1343, PM-1996, PM-1586) (#21918) Backport of #20741 to `core/1.57`, with its prerequisite #21369. Pair of #21917, which carries the same two commits onto `cloud/1.57`. ### Why this branch The 1.57 pair is the live train. `cloud/1.57` is what Cloud users are running — the production overlay pins stable `ba2c2c2269` and canary `33357d4bed` at 10%, and both are on that branch and on no other release branch — and `core/1.57` is its counterpart, which every other backport in this repo goes out to alongside it. Both commits apply to `core/1.57` with no conflict once resolved for `cloud/1.57`, so this carrier is a clean pick of #21917's two commits. ### Why three commits #20741 reads the terminal tool frame's `workflow_id` and `op_ids`. Neither field exists on this branch, so #21369 — the change that introduced them — is carried first. Without it the confirmed-write gate has no data source at all. The third commit repairs a resolution I got wrong on the first push, described below. ### What it fixes PM-1343, PM-1996 and PM-1586 share one user-visible failure: the agent reports successful canvas work while the canvas is empty or unchanged. After this, a successful canvas-mutating tool reads as confirmed only when the operations it names are observed on that workflow through the follower path, and a completed turn claiming canvas content over a still-empty bound canvas says so explicitly. The server result and the browser observation stay separate — a tool can report success while its canvas effect is pending or unconfirmable. ### Why the auto-backport could not do this The bot attempted `core/1.56` and `cloud/1.56` on merge and failed both on conflicts in 15 files. It is not a stacking conflict that clears when open PRs land: `main` is 169 agent-area commits ahead of the 1.57 branch point, and three subsystems the change sits on exist only on `main`. Each is resolved explicitly rather than approximated. The resolutions below were authored against `cloud/1.57` and transfer here byte-identically. ### Release resolutions | Upstream machinery | Not on this branch | Resolution | | --- | --- | --- | | generated `zAgentToolCallData` in `@comfyorg/ingest-types` | not exported | the four PM-1637 correlation fields written out with the generated shapes, each `.catch(undefined)` as upstream has them | | follower's typed `terminal` state, and `AgentCrdtDocLifecycle.refusalIsFinal()` | absent | both carried as upstream has them. `refusalIsFinal()` is a pure derivation over `confirmedSinceLastSend` and `subscribeRetryTimer`, which are already here with identical semantics. `AgentCrdtTerminalState` is declared locally as `'refused' \| 'schema_error' \| null`, because upstream types it in an `agentCrdtStatus.ts` that does not exist here | | projection-staleness latch (`markProjectionStale`, `clearProjectionStaleness`, `hasPendingFailure`) | absent | only the applied-frame notification carried; clean-apply test inlined; `projectionAppliedCleanly` added locally with upstream's body | | thinking-inclusive activity trace (#21600) | absent | `agentToolCallHistoryPersistence.spec.ts` asserts the same changed row without the thinking rows | | `agentSchemaSkewTellsTheUser.spec.ts` | absent | upstream's one-assertion update dropped rather than introducing the whole spec | Smaller ones: `AgentPanel.test.ts` gains only the new empty-canvas-priority case (the two adjacent upstream cases were conflict context, not part of this change); `AgentPanelRoot.test.ts` defines `dispatchApiEvent` locally as upstream does; `oxlint-suppressions.json` keeps this branch's entries, since the one suppression upstream removes is not present here; `RunNoticeBanner.vue` does not gain upstream's pre-existing `genericNoticeReady` prop; relative import paths throughout. The `terminal` row is the one that mattered, and the first push got it wrong. I replaced the typed state with a latch on `onSyncError`, reasoning that it fires on the same two conditions. It does not fire often enough: the refusal handler suppresses the notification for `unsupported` and for a refusal that repeats on an already-notified workflow, so a refused subscribe still read "Worked". CI caught it, because `agentRefusedDocSubscribe` and `agentZeroNodesOnUnreadableSchema` both failed on that exact assertion, and the third commit carries the real thing instead. The distinction it preserves: a follower that is merely not connected yet must read `none`, meaning say nothing about the write, while one that has permanently given up must read `unavailable`, meaning say the write cannot be confirmed. Collapsing those two would deny every write in any environment where the follower never subscribes. ### Verification on this branch - `pnpm typecheck:app` and `pnpm typecheck:browser` both clean. - Full agent unit suite on this branch: **166 files, 3,598 tests pass**, 1 expected fail. - Pre-push gates (dependency-cruiser, knip, fallow) pass; commit hooks ran on the `cloud/1.57` carrier these commits were authored on. - The black-box proof travels with the carrier: `browser_tests/tests/agent/agentCanvasClaimNeedsObservation.spec.ts`. Playwright was not run here — this branch's hosted CI is the first full run of it. ### Scope No change to the semantic document protocol and no repair of a failed delivery path. This makes an unobserved canvas write honest in the UI; delivery remains a separate investigation. `src/locales/en/main.json` and three `browser_tests/fixtures/` files sit outside the Agent review globs. ### Review correction: fourth commit Review at `2eab8a9c47` found the third commit set `terminal` at four of upstream's seven sites. `738c5e0629` carries the other three: an ack-timeout give-up now records `terminal: 'timeout'` (before, the gate read `none` and a write read "Worked"), and a confirmed subscribe or a retarget clears `terminal` (before, a refusal outlived its episode and later writes read "not confirmed"). Upstream's terminal-state follower tests come with it; four of the seven fail on `2eab8a9c47`. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
…erved canvas state (PM-1343, PM-1996, PM-1586) (#21966) Backport of [#21369](#21369) and [#20741](#20741) to `cloud/1.58`, the declared Cloud release line (`frontend-version.json` `releaseBranch`). Same pair `cloud/1.57` already carries as [#21917](#21917) (merge `1f0d5e900a`). ## Why PM-2072: the panel can say **Worked** while the canvas stays empty. The fix is on `cloud/1.57` but not on `cloud/1.58`, so a canvas cut from the release line would ship without it. ## How it was built Cherry-picks of the `main` squash merges `454b1cd71e` and `08b4792346` (not the 1.57 carrier). That brings `main`'s full terminal follower state, including `timeout`, which #21917 and #21918 had to restore after review. Conflicts were import paths, plus three adaptations to this branch: - `RunNoticeBanner.vue`: added only the `emptyCanvas` context. This branch has no `genericNoticeReady`. - `AgentPanel.test.ts`: added only #20741's empty-canvas test. The other conflicting tests belong to a run-notice feature that is not on this branch. - `agentToolCallHistoryPersistence.spec.ts`: this branch's trace has no thinking rows, so `TRACE` is the two tool rows. Same adaptation as #21917. ## Verification - Agent unit suites plus `api.logs.test.ts`: 176 files, 4,021 passed, 1 expected fail. `typecheck:app` and `typecheck:browser` clean. - Black-box, `--project=cloud`, local backend: six changed Agent specs, **13/13 pass** at this head. - Red on `cloud/1.58` source, using this branch's specs and locale strings: **7 failed**. `agentRefusedDocSubscribe` "reports a canvas edit as unconfirmed" received **"Worked"**. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
…rved canvas state (PM-1343, PM-1996, PM-1586) (#22062) ## ELI5 Adds the "don't say Worked unless the canvas shows it" check to the core 1.58 line. Cloud 1.57, Cloud 1.58 and core 1.57 already have it; core 1.58 was missed. ## Summary Clean cherry-pick of the cloud/1.58 carrier #21966 (`f6994bfd0d`), itself a backport of #21369 and #20741. No conflicts; `core/1.58` and `cloud/1.58` share this code. - Ticket: PM-2072 (also PM-1343, PM-1996, PM-1586) - Siblings: #21917 (cloud/1.57), #21918 (core/1.57), #21966 (cloud/1.58) <details><summary>Full context for agent readers</summary> - `core/1.58` vs `main` merge `08b4792346` (#20741): diverged, not contained. Without this PR the next core 1.58 patch ships the panel without the observed-canvas gate. - Local at this head (Node 26.12.1): `pnpm typecheck` green; `vitest run src/workbench/extensions/agent` 175 files, 4019 passed, 1 expected fail. - Runnable proof travels with it: `browser_tests/tests/agent/agentCanvasClaimNeedsObservation.spec.ts` (CI E2E). </details> Co-authored-by: Alexander Brown <drjkl@comfy.org>
Backport of #20741 to
cloud/1.57, with its prerequisite #21369.Why this branch
cloud/1.57is what Cloud users are actually running: the live production overlay pins stableba2c2c2269and canary33357d4bedat 10%, and both commits are on this branch and on no other release branch.cloud/1.56is not served, and #20741's sibling fix went tocloud/1.57.Why three commits
#20741 reads the terminal tool frame's
workflow_idandop_ids. Neither field exists on this branch, so #21369 — the change that introduced them — is carried first. Without it the confirmed-write gate has no data source at all. The third commit repairs a resolution I got wrong on the first push, described below.What it fixes
PM-1343, PM-1996 and PM-1586 share one user-visible failure: the agent reports successful canvas work while the canvas is empty or unchanged. After this, a successful canvas-mutating tool reads as confirmed only when the operations it names are observed on that workflow through the follower path, and a completed turn claiming canvas content over a still-empty bound canvas says so explicitly. The server result and the browser observation stay separate — a tool can report success while its canvas effect is pending or unconfirmable.
Why the auto-backport could not do this
The bot attempted
core/1.56andcloud/1.56on merge and failed both on conflicts in 15 files. It is not a stacking conflict that clears when open PRs land:mainis 169 agent-area commits ahead of the 1.57 branch point, and three subsystems the change sits on exist only onmain. Each is resolved explicitly rather than approximated.Release resolutions
zAgentToolCallDatain@comfyorg/ingest-types.catch(undefined)as upstream has themterminalstate, andAgentCrdtDocLifecycle.refusalIsFinal()refusalIsFinal()is a pure derivation overconfirmedSinceLastSendandsubscribeRetryTimer, which are already here with identical semantics.AgentCrdtTerminalStateis declared locally as'refused' | 'schema_error' | null, because upstream types it in anagentCrdtStatus.tsthat does not exist heremarkProjectionStale,clearProjectionStaleness,hasPendingFailure)projectionAppliedCleanlyadded locally with upstream's bodyagentToolCallHistoryPersistence.spec.tsasserts the same changed row without the thinking rowsagentSchemaSkewTellsTheUser.spec.tsSmaller ones:
AgentPanel.test.tsgains only the new empty-canvas-priority case (the two adjacent upstream cases were conflict context, not part of this change);AgentPanelRoot.test.tsdefinesdispatchApiEventlocally as upstream does;oxlint-suppressions.jsonkeeps this branch's entries, since the one suppression upstream removes is not present here;RunNoticeBanner.vuedoes not gain upstream's pre-existinggenericNoticeReadyprop; relative import paths throughout.The
terminalrow is the one that mattered, and the first push got it wrong. I replaced the typed state with a latch ononSyncError, reasoning that it fires on the same two conditions. It does not fire often enough: the refusal handler suppresses the notification forunsupportedand for a refusal that repeats on an already-notified workflow, so a refused subscribe still read "Worked". CI caught it, becauseagentRefusedDocSubscribeandagentZeroNodesOnUnreadableSchemaboth failed on that exact assertion, and the third commit carries the real thing instead.The distinction it preserves: a follower that is merely not connected yet must read
none, meaning say nothing about the write, while one that has permanently given up must readunavailable, meaning say the write cannot be confirmed. Collapsing those two would deny every write in any environment where the follower never subscribes.Verification on this branch
pnpm typecheck:appandpnpm typecheck:browserboth clean.browser_tests/tests/agent/agentCanvasClaimNeedsObservation.spec.ts. Playwright was not run here — this branch's hosted CI is the first full run of it.Scope
No change to the semantic document protocol and no repair of a failed delivery path. This makes an unobserved canvas write honest in the UI; delivery remains a separate investigation.
src/locales/en/main.jsonand threebrowser_tests/fixtures/files sit outside the Agent review globs.