Repository navigation
[backport cloud/1.57] fix(agent): hold a promoted widget write during a re-subscribe instead of refusing it (PM-2003) (#21335) - #21834
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T09:14:17.742Z",
"gitSha": "97bb98fecd137e45e4808d4bfa4874fc07178c2c",
"branch": "backport-21335-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.8910000000105,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9,
"layouts": 8,
"layoutDurationMs": 2.867,
"taskDurationMs": 352.42,
"heapDeltaBytes": 22160920,
"heapUsedBytes": 87597252,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.534999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.673000000068,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8920000000000003,
"layouts": 9,
"layoutDurationMs": 2.6560000000000006,
"taskDurationMs": 415.306,
"heapDeltaBytes": 21667028,
"heapUsedBytes": 88094840,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 13.242,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.3100000000018,
"styleRecalcs": 79,
"styleRecalcDurationMs": 15.586000000000002,
"layouts": 10,
"layoutDurationMs": 2.946,
"taskDurationMs": 879.883,
"heapDeltaBytes": -3048844,
"heapUsedBytes": 71555200,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 167.581,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678898,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2006.5599999999222,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.51,
"layouts": 9,
"layoutDurationMs": 2.805,
"taskDurationMs": 1102.4379999999999,
"heapDeltaBytes": 15700972,
"heapUsedBytes": 81623388,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 172.63099999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.4590000000344,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.716,
"layouts": 12,
"layoutDurationMs": 3.4730000000000003,
"taskDurationMs": 391.297,
"heapDeltaBytes": -4515860,
"heapUsedBytes": 70853108,
"domNodes": 47,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 11.966000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2789999999868,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.549,
"layouts": 11,
"layoutDurationMs": 3.475,
"taskDurationMs": 441.42900000000003,
"heapDeltaBytes": -1264,
"heapUsedBytes": 75589576,
"domNodes": 47,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 14.803999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 695.4359999999724,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7990000000000004,
"layouts": 8,
"layoutDurationMs": 2.5789999999999997,
"taskDurationMs": 493.96700000000004,
"heapDeltaBytes": 25616180,
"heapUsedBytes": 91535936,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 173.477,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 696.0769999999457,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.116999999999999,
"layouts": 9,
"layoutDurationMs": 2.994,
"taskDurationMs": 474.381,
"heapDeltaBytes": -663004,
"heapUsedBytes": 66156740,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 184.417,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1224.2330000000265,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 919.144,
"heapDeltaBytes": 1603292,
"heapUsedBytes": 81701856,
"domNodes": -192,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 73.51799999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 524,
"frameDurationMs": 32.883783783783805,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1242.4879999999803,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 941.4250000000001,
"heapDeltaBytes": 1152100,
"heapUsedBytes": 81418256,
"domNodes": -192,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 70.503,
"eventListeners": -106,
"totalBlockingTimeMs": 537,
"frameDurationMs": 32.45526315789474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.1740000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.51000000000045,
"heapDeltaBytes": -4113280,
"heapUsedBytes": 76238988,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.83399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.6749999999383,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.9020000000002,
"heapDeltaBytes": -5206252,
"heapUsedBytes": 75581176,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 162.30700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11106.581999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10204.635,
"heapDeltaBytes": -4266308,
"heapUsedBytes": 84089448,
"domNodes": -278,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 8286.952000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1444,
"frameDurationMs": 32.31453488372093,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10876.535000000104,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10025.971,
"heapDeltaBytes": -16028168,
"heapUsedBytes": 83359336,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 8130.298999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1165,
"frameDurationMs": 30.917329545454546,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10271.001000000013,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2900000000000003,
"layouts": 1,
"layoutDurationMs": 0.3370000000000001,
"taskDurationMs": 9431.046,
"heapDeltaBytes": -21847528,
"heapUsedBytes": 77769804,
"domNodes": -258,
"jsHeapTotalBytes": 12972032,
"scriptDurationMs": 8012.879,
"eventListeners": -68,
"totalBlockingTimeMs": 1259,
"frameDurationMs": 31.98193146417446,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10954.410999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10135.103000000001,
"heapDeltaBytes": -12845772,
"heapUsedBytes": 75518484,
"domNodes": -278,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 8198.202,
"eventListeners": -68,
"totalBlockingTimeMs": 1161,
"frameDurationMs": 31.645953757225435,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 246.55100000001084,
"styleRecalcs": 26,
"styleRecalcDurationMs": 16.066999999999997,
"layouts": 12,
"layoutDurationMs": 3.582,
"taskDurationMs": 186.402,
"heapDeltaBytes": -8260876,
"heapUsedBytes": 79164344,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.778999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.21818181818187,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 221.2330000000975,
"styleRecalcs": 23,
"styleRecalcDurationMs": 17.375999999999998,
"layouts": 11,
"layoutDurationMs": 3.6729999999999996,
"taskDurationMs": 165.61499999999998,
"heapDeltaBytes": -8137384,
"heapUsedBytes": 79445796,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.367000000000003,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.319999999999983,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2057.07000000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.711,
"layouts": 8,
"layoutDurationMs": 2.691,
"taskDurationMs": 710.0110000000001,
"heapDeltaBytes": -4349796,
"heapUsedBytes": 74857124,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 41.89600000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.498000000057,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7269999999999994,
"layouts": 8,
"layoutDurationMs": 2.6870000000000003,
"taskDurationMs": 725.423,
"heapDeltaBytes": -2476708,
"heapUsedBytes": 76659740,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 38.542,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2573.9960000000224,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.419,
"layouts": 6,
"layoutDurationMs": 1.7109999999999999,
"taskDurationMs": 1772.7250000000001,
"heapDeltaBytes": -30327780,
"heapUsedBytes": 67529520,
"domNodes": -258,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 850.9049999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.885526315789477,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2794.4370000000163,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.579,
"layouts": 5,
"layoutDurationMs": 1.586,
"taskDurationMs": 1868.2050000000002,
"heapDeltaBytes": 20000932,
"heapUsedBytes": 100101140,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 882.019,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.765868263473056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3812.417000000039,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.507999999999999,
"layouts": 64,
"layoutDurationMs": 10.925,
"taskDurationMs": 1808.3430000000003,
"heapDeltaBytes": 5159212,
"heapUsedBytes": 84508804,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 810.6,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3618.9410000000635,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.661999999999999,
"layouts": 64,
"layoutDurationMs": 11.74,
"taskDurationMs": 1757.7399999999996,
"heapDeltaBytes": -9472928,
"heapUsedBytes": 71939784,
"domNodes": -234,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 833.0450000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2846.9180000000165,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.675,
"layouts": 4,
"layoutDurationMs": 1.3000000000000003,
"taskDurationMs": 1753.241,
"heapDeltaBytes": 2667456,
"heapUsedBytes": 86164452,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 949.796,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.963690476190475,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3231.6210000000183,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.013,
"layouts": 4,
"layoutDurationMs": 1.4260000000000002,
"taskDurationMs": 2122.344,
"heapDeltaBytes": 711220,
"heapUsedBytes": 84078576,
"domNodes": -278,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 1029.929,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.839583333333334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2054.99599999996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.07,
"layouts": 6,
"layoutDurationMs": 1.9949999999999999,
"taskDurationMs": 658.284,
"heapDeltaBytes": -3369284,
"heapUsedBytes": 75767128,
"domNodes": -278,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 35.757999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.2839999999478,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.0440000000000005,
"layouts": 6,
"layoutDurationMs": 1.9639999999999995,
"taskDurationMs": 572.9439999999998,
"heapDeltaBytes": -1562608,
"heapUsedBytes": 79706492,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 38.072,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.76799999998,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.13,
"layouts": 10,
"layoutDurationMs": 2.815,
"taskDurationMs": 470.76099999999997,
"heapDeltaBytes": -1111348,
"heapUsedBytes": 76052904,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 147.281,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.2389999999632,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.5200000000000005,
"layouts": 8,
"layoutDurationMs": 2.437,
"taskDurationMs": 387.741,
"heapDeltaBytes": 21548324,
"heapUsedBytes": 89490448,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 152.357,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.1730000000139,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.618,
"layouts": 8,
"layoutDurationMs": 2.9770000000000003,
"taskDurationMs": 433.41599999999994,
"heapDeltaBytes": 22281404,
"heapUsedBytes": 89781220,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.849,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.7409999999727,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.05,
"layouts": 10,
"layoutDurationMs": 3.195,
"taskDurationMs": 525.243,
"heapDeltaBytes": 22381204,
"heapUsedBytes": 90280400,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.837,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1958.956999999998,
"styleRecalcs": 88,
"styleRecalcDurationMs": 18.339000000000002,
"layouts": 10,
"layoutDurationMs": 3.0509999999999997,
"taskDurationMs": 1105.8870000000002,
"heapDeltaBytes": -11393904,
"heapUsedBytes": 66443892,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 121.015,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1975.5840000000262,
"styleRecalcs": 88,
"styleRecalcDurationMs": 18.102999999999998,
"layouts": 10,
"layoutDurationMs": 3.091,
"taskDurationMs": 1090.7910000000002,
"heapDeltaBytes": -11376752,
"heapUsedBytes": 66259324,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 118.79699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666949152542376,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.1619999999757,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.089000000000002,
"layouts": 5,
"layoutDurationMs": 14.764,
"taskDurationMs": 888.0180000000001,
"heapDeltaBytes": 7021516,
"heapUsedBytes": 114842884,
"domNodes": 15953,
"jsHeapTotalBytes": 17174528,
"scriptDurationMs": 30.188,
"eventListeners": 3244,
"totalBlockingTimeMs": 162,
"frameDurationMs": 19.676388888888887,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9826.731999999993,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.319999999999997,
"layouts": 8,
"layoutDurationMs": 2.2259999999999995,
"taskDurationMs": 6229.925,
"heapDeltaBytes": -16681392,
"heapUsedBytes": 81907704,
"domNodes": -278,
"jsHeapTotalBytes": 6647808,
"scriptDurationMs": 2930.999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69439728353141,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9976.340000000051,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.921,
"layouts": 8,
"layoutDurationMs": 2.221,
"taskDurationMs": 6247.384,
"heapDeltaBytes": -4423804,
"heapUsedBytes": 92173228,
"domNodes": -258,
"jsHeapTotalBytes": 4812800,
"scriptDurationMs": 2822.186,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750084033613447,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23205.313999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22702.981,
"heapDeltaBytes": -42990660,
"heapUsedBytes": 257490960,
"domNodes": -3330,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 352.508,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.86082474226804,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 23726.02600000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23195.457,
"heapDeltaBytes": -23328132,
"heapUsedBytes": 267981260,
"domNodes": -3330,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 358.17499999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.56287215411558,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 27906.54500000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.917000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27511.366999999995,
"heapDeltaBytes": -10886980,
"heapUsedBytes": 265164980,
"domNodes": -3330,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 888.239,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 52.05018656716419,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 20173.847000000023,
"styleRecalcs": 160,
"styleRecalcDurationMs": 15.144000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19741.368000000002,
"heapDeltaBytes": 7083444,
"heapUsedBytes": 297813904,
"domNodes": -3330,
"jsHeapTotalBytes": 20369408,
"scriptDurationMs": 904.021,
"eventListeners": -651,
"totalBlockingTimeMs": 65,
"frameDurationMs": 37.275231053604436,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6166.9850000000115,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.43900000000004,
"layouts": 20,
"layoutDurationMs": 23.448999999999998,
"taskDurationMs": 6008.511,
"heapDeltaBytes": -32242412,
"heapUsedBytes": 263484692,
"domNodes": -3330,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 126.26700000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 23,
"frameDurationMs": 33.88131868131868,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6150.216999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.08300000000001,
"layouts": 20,
"layoutDurationMs": 23.185,
"taskDurationMs": 5986.0740000000005,
"heapDeltaBytes": -29713568,
"heapUsedBytes": 261486748,
"domNodes": -3330,
"jsHeapTotalBytes": 25419776,
"scriptDurationMs": 110.32700000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.94204545454545,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11554.368000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11286.956,
"heapDeltaBytes": -4275360,
"heapUsedBytes": 261674928,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.524,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.82586206896552,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11883.77700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11566.884,
"heapDeltaBytes": -11501516,
"heapUsedBytes": 254989900,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.14300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.287544483985776,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 498.04699999992863,
"styleRecalcs": 15,
"styleRecalcDurationMs": 14.911000000000001,
"layouts": 12,
"layoutDurationMs": 4.658,
"taskDurationMs": 149.255,
"heapDeltaBytes": -13059276,
"heapUsedBytes": 70993828,
"domNodes": 98,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 15.348999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 174.2989999999054,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.036000000000001,
"layouts": 8,
"layoutDurationMs": 2.932,
"taskDurationMs": 126.383,
"heapDeltaBytes": -11069156,
"heapUsedBytes": 69031588,
"domNodes": 94,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 9.081000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 492.3869999998942,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0050000000000001,
"layouts": 76,
"layoutDurationMs": 15.702,
"taskDurationMs": 438.955,
"heapDeltaBytes": 11518480,
"heapUsedBytes": 90681972,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 213.719,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 483.4439999999631,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.987,
"layouts": 76,
"layoutDurationMs": 14.706,
"taskDurationMs": 435.288,
"heapDeltaBytes": -21277976,
"heapUsedBytes": 72707680,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 211.723,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 610.1390000000038,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.193,
"layouts": 76,
"layoutDurationMs": 14.867,
"taskDurationMs": 582.052,
"heapDeltaBytes": 1241588,
"heapUsedBytes": 119946184,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 242.763,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 700.7859999999937,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.885,
"layouts": 76,
"layoutDurationMs": 17.364,
"taskDurationMs": 666.754,
"heapDeltaBytes": 1769052,
"heapUsedBytes": 133535632,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 289.87100000000004,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.05952380952381,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2286 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2250e2304d4d82907ed1abfe3158bb3859751f7d
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.57 #21834 +/- ##
=============================================
Coverage ? 85.22%
=============================================
Files ? 2524
Lines ? 133212
Branches ? 40800
=============================================
Hits ? 113530
Misses ? 19266
Partials ? 416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Ready except one unrelated red check. Not merging yet.
- Required checks green at
91e72a10df. The PM-2003 browser spec ran in CI: 2 passed. - Independent review found one blocker in the spec: 1.57's host-socket constructor takes a socket id first. Fixed in
91e72a10df. upload-e2e-coverage / packagefails on every E2E run since today, main included (https://linear.app/comfyorg/issue/FE-3596). This program's merge gate needs all completed checks green, so the merge waits on that fix or a waiver.
Full context for agent readers
- Grant: agent backport review and merge on core/cloud 1.57 (program release-backport authority). Authored under this account, so this is a COMMENT review, not an approval.
- Second-model review: a fresh Claude reviewer (adversarial-review skill; Codex unavailable on this host). Findings: blocker, spec passed
'apply'as the socket id, so the mock host held every human op (fixed). Nit: an unresolvable-owner write is dropped with console.error only, which is 1.57's existing behaviour, kept. Minor: no unit test for a held write next to a 1.57-only pending dynamic-combo slot. The reviewer traced no shared state and no double-mint path. - Local: docOpMinter 134/134, agent crdt 1100 pass + 1 expected fail, typecheck app + browser pass; forcing immediate doc_not_synced refusal fails 15 new tests.
- Gate output:
NOT MERGE READY: completed checks are not green at 91e72a10df: upload-e2e-coverage / package=failure. A rerun failed the same way (lcov 2.4duplicate function 'inner_clicked').
91e72a1 to
27ae5d3
Compare
|
Rebased onto current cloud/1.57 (same two commits). Everything green except Full context for agent readers
|
27ae5d3 to
bec6e2d
Compare
|
Rebased onto current cloud/1.57. Still waiting on the coverage-job fix for this branch (#21877), then gate and greenlight. Full context for agent readers
|
… a re-subscribe instead of refusing it (PM-2003) (#21335) Manual backport of #21335 (0751857). The automatic cherry-pick conflicted because cloud/1.57 carries the dynamic-combo pending-value code and the no-argument onWidgetWriteRefused callback. Resolution: - docOpMinter.ts: keep 1.57's null route and pending widget values and add the held-write path. The refusal callback keeps 1.57's signature. reportUnresolvedOwner is dropped: 1.57 has no unresolved-owner route. - docOpMinter.test.ts: refusals stay a count on 1.57, and both fixture doc sets are destroyed in teardown. - agentFollowerHostSocket.ts: add answerSubscribesWith so the browser spec can withhold a re-subscribe answer. (cherry picked from commit 07518578e0e7c3fbeee9f6779c1c1bd3a0e51d5e)
…pec on 1.57 On 1.57 AgentFollowerHostSocket takes a socket id before humanOpsHost, so 'apply' landed in the socket id and the mock host held every human op. The seed could then never reach the shared document.
bec6e2d to
40a8b9e
Compare
There was a problem hiding this comment.
Verdict: Faithful backport of #21335 with required checks passing; coverage packaging is still red.
I compared this head with merged source commit 0751857 and confirmed it is on current main. The held-write behavior, all 18 new unit cases and both browser cases are preserved.
The adaptations preserve cloud/1.57's existing contracts: null routing and pending-widget-value tracking remain instead of main's unresolved-owner reporting; the refusal callback stays argument-free, so its test assertions count refusals; teardown cleans up both the target's dynamic-combo documents and the source's promoted documents. The deadline uses the exported lifecycle retry constant and remains 45 seconds. The browser fixture brings over main's existing subscribe-answer hook, and the spec supplies the socket ID required before the apply mode in 1.57's constructor. I found no unexplained added or dropped changes.
With the target's own dependencies, I ran the CRDT unit suite: 67 files passed, 1105 tests passed and one expected failure. Both PM-2003 browser cases passed on a Cloud build with retries disabled. Browser typechecking, type-aware lint on the changed files and diff whitespace checks passed. Required CI checks lint-and-format, test and e2e-status all passed on this exact head.
I also inspected the failed coverage-packaging job: lcov aborts on duplicate inner_clicked function records in unchanged LGraphCanvas.ts, not a failed browser test. That separate job remains red on this head, so this approval does not mean every completed check is green or waive the author's all-checks merge hold.
Backport of #21335 to
cloud/1.57. Manual: the automatic cherry-pick conflicted.Full context for agent readers
Resolution, per file:
docOpMinter.ts: kept 1.57'srouted === nullearly return andrememberPendingWidgetValue; added the held-write path (holdOrRefuseWidgetWrite, retry timer, deadline, detach cleanup).refuseWidgetWritecalls 1.57'sonWidgetWriteRefused()with no arguments.reportUnresolvedOwnerdropped: 1.57's router has no unresolved-owner result.PROMOTED_WRITE_CATCH_UP_DEADLINE_MStakes main'sSUBSCRIBE_ACK_MAX_TIMEOUTS * SUBSCRIBE_ACK_TIMEOUT_MS, the same 45 s as 1.57's3 * SUBSCRIBE_ACK_TIMEOUT_MS.docOpMinter.test.ts:refusalsstays a counter on 1.57, so array assertions becametoBe(0)/toBe(1). Teardown destroys both the dynamic-combo and seeded-promoted docs. The doc-not-synced row is removed from the immediate-refusal table, as on main.browser_tests/fixtures/agentFollowerHostSocket.ts: addedanswerSubscribesWith(from main) so the spec can withhold a re-subscribe answer.Local evidence on core/1.57 (cloud/1.57 files are identical):
docOpMinter.test.ts134/134; agent crdt suite 1100 pass + 1 expected fail.doc_not_syncedfails 15 of the new tests.typecheck:app,typecheck:browser, oxfmt, oxlint, eslint pass (pre-commit).Refs PM-2003.