Repository navigation
[backport core/1.58] fix(agent): gate canvas-affecting claims on observed canvas state (PM-1343, PM-1996, PM-1586) - #22062
Conversation
…rved canvas state (PM-1343, PM-1996, PM-1586) Backport of #21369 and #20741 to core/1.58, cherry-picked cleanly from the cloud/1.58 carrier #21966 (f6994bf). core/1.57 (#21918), cloud/1.57 (#21917) and cloud/1.58 (#21966) already carry it; core/1.58 did not, so the next core 1.58 patch would ship without the gate. (cherry picked from commit f6994bf) Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-27T12:02:16.084Z",
"gitSha": "2bdc2c073aa2fafda06faeff5d8e21e9d61f0074",
"branch": "backport-21966-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.3819999999887,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.1769999999999996,
"layouts": 10,
"layoutDurationMs": 2.52,
"taskDurationMs": 399.90099999999995,
"heapDeltaBytes": 8638288,
"heapUsedBytes": 98925372,
"domNodes": -180,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 8.249000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2027.684000000022,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8960000000000006,
"layouts": 10,
"layoutDurationMs": 2.15,
"taskDurationMs": 398.015,
"heapDeltaBytes": 6072428,
"heapUsedBytes": 96350728,
"domNodes": -180,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 8.253000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1994.008000000008,
"styleRecalcs": 83,
"styleRecalcDurationMs": 10.547,
"layouts": 9,
"layoutDurationMs": 1.9240000000000002,
"taskDurationMs": 862.355,
"heapDeltaBytes": 6599488,
"heapUsedBytes": 96445216,
"domNodes": -180,
"jsHeapTotalBytes": 2416640,
"scriptDurationMs": 123.80899999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1762.695000000008,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.026,
"layouts": 10,
"layoutDurationMs": 2.0029999999999997,
"taskDurationMs": 768.3800000000001,
"heapDeltaBytes": -276732,
"heapUsedBytes": 90958184,
"domNodes": -200,
"jsHeapTotalBytes": 4681728,
"scriptDurationMs": 117.85799999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.2210000000237,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.026,
"layouts": 11,
"layoutDurationMs": 2.065,
"taskDurationMs": 345.79499999999996,
"heapDeltaBytes": -548240,
"heapUsedBytes": 99794680,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.584,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.644000000012,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.175,
"layouts": 13,
"layoutDurationMs": 2.7169999999999996,
"taskDurationMs": 361.61699999999996,
"heapDeltaBytes": 3568080,
"heapUsedBytes": 105017324,
"domNodes": 47,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 9.45,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 566.0340000000019,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.5979999999999996,
"layouts": 7,
"layoutDurationMs": 1.3890000000000002,
"taskDurationMs": 416.583,
"heapDeltaBytes": 3231564,
"heapUsedBytes": 93907952,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.848,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696968,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 592.5280000000157,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.0460000000000003,
"layouts": 9,
"layoutDurationMs": 1.922,
"taskDurationMs": 432.965,
"heapDeltaBytes": 9905704,
"heapUsedBytes": 110744620,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 146.798,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1131.6149999999823,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.679,
"heapDeltaBytes": -15231980,
"heapUsedBytes": 102717740,
"domNodes": -230,
"jsHeapTotalBytes": 15794176,
"scriptDurationMs": 56.001,
"eventListeners": -168,
"totalBlockingTimeMs": 436,
"frameDurationMs": 29.82368421052632,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1116.2689999999884,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.1590000000001,
"heapDeltaBytes": -3581296,
"heapUsedBytes": 102676124,
"domNodes": -210,
"jsHeapTotalBytes": 8286208,
"scriptDurationMs": 47.85600000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 430,
"frameDurationMs": 30.178378378378362,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 778.1289999999785,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.698,
"heapDeltaBytes": -2068280,
"heapUsedBytes": 98375092,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.38900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 147,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 763.9159999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.64300000000003,
"heapDeltaBytes": -3260548,
"heapUsedBytes": 98312832,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.09300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 136,
"frameDurationMs": 22.547058823529422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7871.93099999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0449999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7027.842,
"heapDeltaBytes": 43317456,
"heapUsedBytes": 146924184,
"domNodes": -296,
"jsHeapTotalBytes": 32301056,
"scriptDurationMs": 5563.667,
"eventListeners": -130,
"totalBlockingTimeMs": 125,
"frameDurationMs": 25.706862745098043,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7657.791999999972,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2519999999999996,
"layouts": 1,
"layoutDurationMs": 0.27999999999999986,
"taskDurationMs": 6842.866,
"heapDeltaBytes": 50121228,
"heapUsedBytes": 154045200,
"domNodes": -300,
"jsHeapTotalBytes": 27582464,
"scriptDurationMs": 5212.643,
"eventListeners": -130,
"totalBlockingTimeMs": 66,
"frameDurationMs": 24.36178343949045,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7929.440999999997,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.044000000000000636,
"layouts": 1,
"layoutDurationMs": 0.2639999999999999,
"taskDurationMs": 7103.17,
"heapDeltaBytes": 39253208,
"heapUsedBytes": 149136712,
"domNodes": -276,
"jsHeapTotalBytes": 35184640,
"scriptDurationMs": 5748.392,
"eventListeners": -130,
"totalBlockingTimeMs": 183,
"frameDurationMs": 26.56510067114094,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7144.479999999987,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.21000000000000013,
"layouts": 1,
"layoutDurationMs": 0.2660000000000002,
"taskDurationMs": 6426.588000000001,
"heapDeltaBytes": 30809440,
"heapUsedBytes": 139965560,
"domNodes": -276,
"jsHeapTotalBytes": 26533888,
"scriptDurationMs": 5082.061000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 60,
"frameDurationMs": 24.853658536585368,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 214.50999999999,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.800999999999998,
"layouts": 11,
"layoutDurationMs": 3.4330000000000003,
"taskDurationMs": 163.87999999999997,
"heapDeltaBytes": 13244236,
"heapUsedBytes": 118779288,
"domNodes": 917,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 7.914000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 195.4600000000255,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.937,
"layouts": 11,
"layoutDurationMs": 2.8010000000000006,
"taskDurationMs": 150.16800000000003,
"heapDeltaBytes": 13297836,
"heapUsedBytes": 119324560,
"domNodes": 917,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 7.617000000000003,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.211111111111123,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2041.9159999999863,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5909999999999995,
"layouts": 8,
"layoutDurationMs": 1.573,
"taskDurationMs": 595.5169999999999,
"heapDeltaBytes": 988816,
"heapUsedBytes": 111503468,
"domNodes": -296,
"jsHeapTotalBytes": -1191936,
"scriptDurationMs": 30.201999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.7489999999816,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5230000000000001,
"layouts": 8,
"layoutDurationMs": 1.6720000000000002,
"taskDurationMs": 581.114,
"heapDeltaBytes": -669996,
"heapUsedBytes": 110306936,
"domNodes": -296,
"jsHeapTotalBytes": -1515520,
"scriptDurationMs": 25.659000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2204.0999999999826,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.526,
"layouts": 6,
"layoutDurationMs": 1.2590000000000001,
"taskDurationMs": 1323.617,
"heapDeltaBytes": -3588608,
"heapUsedBytes": 108301288,
"domNodes": -296,
"jsHeapTotalBytes": 20480,
"scriptDurationMs": 668.676,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793129770992365,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2203.8900000000012,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.398,
"layouts": 7,
"layoutDurationMs": 1.4820000000000002,
"taskDurationMs": 1415.721,
"heapDeltaBytes": -2766788,
"heapUsedBytes": 109560488,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 623.629,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79312977099237,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3251.778999999999,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.899,
"layouts": 65,
"layoutDurationMs": 9.503000000000002,
"taskDurationMs": 1495.7090000000003,
"heapDeltaBytes": -20001872,
"heapUsedBytes": 93059324,
"domNodes": -252,
"jsHeapTotalBytes": -73728,
"scriptDurationMs": 603.713,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3241.434999999967,
"styleRecalcs": 73,
"styleRecalcDurationMs": 7.942999999999999,
"layouts": 66,
"layoutDurationMs": 9.254999999999999,
"taskDurationMs": 1246.9929999999997,
"heapDeltaBytes": 7034328,
"heapUsedBytes": 120285388,
"domNodes": 24,
"jsHeapTotalBytes": 5509120,
"scriptDurationMs": 584.727,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2261.0579999999914,
"styleRecalcs": 45,
"styleRecalcDurationMs": 3.8269999999999995,
"layouts": 5,
"layoutDurationMs": 1.0270000000000001,
"taskDurationMs": 1583.9240000000002,
"heapDeltaBytes": 3331536,
"heapUsedBytes": 106977424,
"domNodes": 0,
"jsHeapTotalBytes": 4722688,
"scriptDurationMs": 742.8100000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79029850746269,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2572.174000000018,
"styleRecalcs": 44,
"styleRecalcDurationMs": 3.8070000000000004,
"layouts": 5,
"layoutDurationMs": 1.069,
"taskDurationMs": 1648.3770000000002,
"heapDeltaBytes": -11610000,
"heapUsedBytes": 103749036,
"domNodes": 0,
"jsHeapTotalBytes": 7081984,
"scriptDurationMs": 777.458,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.88552631578947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.932999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7340000000000002,
"layouts": 8,
"layoutDurationMs": 2.026,
"taskDurationMs": 463.42800000000005,
"heapDeltaBytes": -25911496,
"heapUsedBytes": 92933844,
"domNodes": -276,
"jsHeapTotalBytes": -1478656,
"scriptDurationMs": 31.549,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.193999999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.541,
"layouts": 7,
"layoutDurationMs": 1.668,
"taskDurationMs": 566.64,
"heapDeltaBytes": -13766264,
"heapUsedBytes": 91145440,
"domNodes": -297,
"jsHeapTotalBytes": -2719744,
"scriptDurationMs": 27.210000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.7460000000046,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.566999999999999,
"layouts": 9,
"layoutDurationMs": 1.939,
"taskDurationMs": 357.954,
"heapDeltaBytes": -1024052,
"heapUsedBytes": 89871456,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 121.534,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.7070000000595,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.959999999999999,
"layouts": 10,
"layoutDurationMs": 1.948,
"taskDurationMs": 371.62,
"heapDeltaBytes": 427604,
"heapUsedBytes": 103188580,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 112.12,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2055.649999999986,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.078,
"layouts": 10,
"layoutDurationMs": 2.04,
"taskDurationMs": 525.197,
"heapDeltaBytes": -15795964,
"heapUsedBytes": 78508568,
"domNodes": -198,
"jsHeapTotalBytes": 2510848,
"scriptDurationMs": 8.068000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.689000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0210000000000004,
"layouts": 10,
"layoutDurationMs": 2.1580000000000004,
"taskDurationMs": 473.04,
"heapDeltaBytes": 4812176,
"heapUsedBytes": 107177356,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.078999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.7869999999773,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.656,
"layouts": 9,
"layoutDurationMs": 1.9300000000000002,
"taskDurationMs": 615.948,
"heapDeltaBytes": 3129116,
"heapUsedBytes": 94099572,
"domNodes": -191,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 80.461,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.829411764705885,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.4820000000132,
"styleRecalcs": 85,
"styleRecalcDurationMs": 11.581999999999999,
"layouts": 9,
"layoutDurationMs": 1.8420000000000003,
"taskDurationMs": 849.406,
"heapDeltaBytes": -1405100,
"heapUsedBytes": 90105848,
"domNodes": -210,
"jsHeapTotalBytes": 2678784,
"scriptDurationMs": 87.985,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0270000000032,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.340999999999998,
"layouts": 5,
"layoutDurationMs": 11.939,
"taskDurationMs": 895.6920000000001,
"heapDeltaBytes": 35529500,
"heapUsedBytes": 135058628,
"domNodes": 16030,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 23.681999999999995,
"eventListeners": 3244,
"totalBlockingTimeMs": 142,
"frameDurationMs": 19.44305555555555,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8248.231000000033,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.087999999999997,
"layouts": 8,
"layoutDurationMs": 1.6079999999999999,
"taskDurationMs": 4353.821999999999,
"heapDeltaBytes": -8669636,
"heapUsedBytes": 113677588,
"domNodes": -296,
"jsHeapTotalBytes": -372736,
"scriptDurationMs": 2152.346,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6997975708502,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8230.715000000033,
"styleRecalcs": 251,
"styleRecalcDurationMs": 21.615000000000002,
"layouts": 9,
"layoutDurationMs": 1.7810000000000001,
"taskDurationMs": 4229.003,
"heapDeltaBytes": 3069876,
"heapUsedBytes": 113905124,
"domNodes": -297,
"jsHeapTotalBytes": -1028096,
"scriptDurationMs": 2069.5139999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16841.71700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16176.863999999998,
"heapDeltaBytes": -34761372,
"heapUsedBytes": 277607216,
"domNodes": -3344,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 212.993,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.675638841567288,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16925.00700000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16156.961000000003,
"heapDeltaBytes": -10662204,
"heapUsedBytes": 301324276,
"domNodes": -3344,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 207.98100000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.602533783783784,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 20262.35600000001,
"styleRecalcs": 165,
"styleRecalcDurationMs": 16.574999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19888.765,
"heapDeltaBytes": -21688092,
"heapUsedBytes": 302647980,
"domNodes": -3344,
"jsHeapTotalBytes": 7520256,
"scriptDurationMs": 761,
"eventListeners": -651,
"totalBlockingTimeMs": 9,
"frameDurationMs": 36.383842010771986,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20776.41099999994,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.772999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20313.403000000002,
"heapDeltaBytes": -34865408,
"heapUsedBytes": 284845404,
"domNodes": -3348,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 807.356,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 37.786181818181824,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4366.947000000038,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.83599999999999,
"layouts": 20,
"layoutDurationMs": 19.61800000000001,
"taskDurationMs": 4209.625999999999,
"heapDeltaBytes": -29992748,
"heapUsedBytes": 294048784,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 71.72,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.950857142857142,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4302.768000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.928000000000004,
"layouts": 20,
"layoutDurationMs": 19.580000000000002,
"taskDurationMs": 4124.6359999999995,
"heapDeltaBytes": -18767992,
"heapUsedBytes": 310906076,
"domNodes": -3344,
"jsHeapTotalBytes": 26202112,
"scriptDurationMs": 94.774,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.114525139664803,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8224.902999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7808.215999999999,
"heapDeltaBytes": 18862900,
"heapUsedBytes": 292543124,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.86099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.57147651006711,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8605.047000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8213.562000000002,
"heapDeltaBytes": -33936620,
"heapUsedBytes": 503834328,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 102.71300000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.761204013377935,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 465.4170000000022,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.568,
"layouts": 13,
"layoutDurationMs": 4.349,
"taskDurationMs": 133.83100000000002,
"heapDeltaBytes": 7456808,
"heapUsedBytes": 104926784,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.521999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 446.015999999986,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.717,
"layouts": 13,
"layoutDurationMs": 3.1009999999999995,
"taskDurationMs": 95.99700000000001,
"heapDeltaBytes": 6890452,
"heapUsedBytes": 97635572,
"domNodes": 95,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.654,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 371.1479999999483,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.662,
"layouts": 76,
"layoutDurationMs": 13.467,
"taskDurationMs": 324.20400000000006,
"heapDeltaBytes": -21546232,
"heapUsedBytes": 70144780,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 150.057,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304317,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 348.357999999962,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.616,
"layouts": 76,
"layoutDurationMs": 13.481,
"taskDurationMs": 302.75800000000004,
"heapDeltaBytes": -14324852,
"heapUsedBytes": 78566860,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 135.085,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 393.0729999999585,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.526,
"layouts": 76,
"layoutDurationMs": 12.607,
"taskDurationMs": 360.675,
"heapDeltaBytes": -303456,
"heapUsedBytes": 122405628,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.39000000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.058333333333355,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 433.9989999999716,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.488,
"layouts": 76,
"layoutDurationMs": 12.836,
"taskDurationMs": 399.25100000000003,
"heapDeltaBytes": 47964,
"heapUsedBytes": 116944076,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 158.20999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2976 passed, 0 failed · 5 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 251299ff2c5ae79aa09a2d4b9dbf7ab4c249a6e5
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (120)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.58 #22062 +/- ##
===========================================
Coverage 84.52% 84.52%
===========================================
Files 3088 3090 +2
Lines 162561 162708 +147
Branches 41529 41596 +67
===========================================
+ Hits 137401 137535 +134
- Misses 24768 24781 +13
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Release-backport gate (agent backports on current trains may merge after our own gates). Same patch-id as #21966 (5758515684); every touched file except src/locales/en/main.json is byte-identical to cloud/1.58. Exact head 3cdd1a230f: 146 checks green incl. E2E agentCanvasClaimNeedsObservation.spec.ts; local typecheck + 4019 agent unit tests green.
…Comfy-Org#22791) ## Summary After a reload or reopening a chat from history, every finished Agent turn read "Changes not confirmed on your canvas", although the same turn read "Worked" live and its edits are on the canvas. Restored turns now read "Worked" again, as on 1.59.0.dev2. Fixes [FRONT-3803](https://linear.app/comfyorg/issue/FRONT-3803). <details><summary>Full context for agent readers</summary> **Cause.** Comfy-Org#20741 (`08b4792346`, the only canvas-claim change between 1.59.0.dev2 `864bfc939e` and 1.60.0.dev1 `9b73bee0a5`) made `parseToolCallEntry` in `agentTranscript.ts` set `canvasConfirmed: false` on every successful canvas-mutating call read from a stored row. A stored row carries no browser observation, so after a reload nothing could ever confirm those calls. `preserveCanvasConfirmation` upgraded them back only for calls the same page session had confirmed live, which is why in-session turns kept "Worked" until the reload. Comfy-Org#20741 flipped `agentToolCallHistoryPersistence.spec.ts` to expect the unconfirmed label; this PR flips it back. **Fix.** - `agentTranscript.ts`: a stored row makes no canvas claim (no `canvasConfirmed`). - `agentConversationStore.ts`: when a turn settles in the session that ran it, the verdict its live calls reached carries onto the stored row, **true or false** (previously true only, because stored rows defaulted to false). Applied on both settle paths: the socket reconcile (`reconcileSettledTurn`) and the recovery read (`settleTurn`). Without the second one, a live denial settled by the recovery read would now drop to "Worked". This is the canvas half of [FRONT-3757](https://linear.app/comfyorg/issue/FRONT-3757); its tab-link half is unchanged. - A call still waiting for canvas catch-up when its turn settles is stored as not confirmed, which is the same verdict the transport's flush records. A verdict moves onto a stored tool only when the tool names match (review round 1). - Live behaviour from Comfy-Org#20741 is unchanged: unobserved, timed-out or unavailable-canvas writes still read "not confirmed" live and after settle in that session. Only a restored row, which never had an observation, stops claiming one. No reconcile pass, no new store writes; this is display state on the message parts only (KEEP-ALIVE Comfy-Org#14 untouched). **Backport.** Comfy-Org#20741 is on `core/1.60`, `cloud/1.60`, `core/1.59`, `cloud/1.59` natively and was backported to `core/1.58` (Comfy-Org#22062) and `cloud/1.58` (Comfy-Org#21966). The frontend pin decision needs `core/1.60`; labels are set for all six lines. </details> ## Verification - Black-box: `browser_tests/tests/agent/agentToolCallHistoryPersistence.spec.ts` (reload, then reopen from history) restored to expect "Worked" with no unconfirmed marker. **Red on parent `a8c2ace17f`** (summary reads "Changes not confirmed on your canvas"), **green on this branch** (rerun at `2d96033bfc`). - Related canvas-claim specs, `--project=cloud`, local backend: `agentCanvasClaimNeedsObservation`, `agentCanvasLagsToolCallCompletion`, `agentRefusedDocSubscribe`, `agentGraphOpLostOnDisconnect`, `agentSchemaSkewTellsTheUser`, `agentZeroNodesOnUnreadableSchema`, `agentToolCallHistoryPersistence`: 15/15 pass. - Unit: store cases cover the live verdict (confirmed, denied, still pending) through both settle paths, plus a name-mismatch guard; each fails without the change that it covers. Agent suites: 194 files, 4914 pass. `pnpm typecheck`, `typecheck:browser`, oxlint, eslint, oxfmt pass via hooks.
ELI5
Adds the "don't say Worked unless the canvas shows it" check to the core 1.58 line. Cloud 1.57, Cloud 1.58 and core 1.57 already have it; core 1.58 was missed.
Summary
Clean cherry-pick of the cloud/1.58 carrier #21966 (
f6994bfd0d), itself a backport of #21369 and #20741. No conflicts;core/1.58andcloud/1.58share this code.Full context for agent readers
core/1.58vsmainmerge08b4792346(fix(agent): gate canvas-affecting claims on observed canvas state (PM-1343, PM-1996, PM-1586) #20741): diverged, not contained. Without this PR the next core 1.58 patch ships the panel without the observed-canvas gate.pnpm typecheckgreen;vitest run src/workbench/extensions/agent175 files, 4019 passed, 1 expected fail.browser_tests/tests/agent/agentCanvasClaimNeedsObservation.spec.ts(CI E2E).