Repository navigation
[backport core/1.57] fix(agent): gate canvas-affecting claims on observed canvas state (PM-1343, PM-1996, PM-1586) - #21918
Conversation
Prerequisite for the #20741 backport: that PR's confirmed-write gate reads the terminal tool frame's `workflow_id` / `op_ids`, which do not exist on this branch without this change. Release resolutions, all forced by machinery that lives only on `main`: - `agentApiSchema.ts`: upstream derives `zAgentToolCallData` from the generated `zAgentToolCallData` in `@comfyorg/ingest-types`, which this branch does not export. The four correlation fields are written out with the generated shapes instead, each `.catch(undefined)` as upstream has it. - `useAgentCrdtFollower.ts`: `settleCollectedProjection` is not carried -- its other half drives the projection-staleness latch (`markProjectionStale` / `clearProjectionStaleness` / `projection.hasPendingFailure`), which does not exist here. Only the applied-frame notification is carried, with the clean-apply test inlined. `settleCatchUpProjection` and `clearSyncStaleness` likewise absent. `projectionAppliedCleanly` is added locally (same body as upstream). `AgentCrdtFollowerEvents` stays exported, as on this branch. - `AgentPanelRoot.vue`: `useAgentCrdtFollower` still takes positional `getGraph` and `events` arguments here, not upstream's options object. - `agentCanvasLagsToolCallCompletion.spec.ts`: the host frames go through this branch's local `send()` helper rather than `hostSocket.send()`. - `agentConversationStore.ts`: relative import paths, as on this branch. Verified: `pnpm typecheck:browser`, `pnpm typecheck:app`, and 235 tests across `agentApiSchema.test.ts`, `agentEventTransport.test.ts` and `useAgentCrdtFollower.test.ts`. (cherry picked from commit 454b1cd)
…-1343, PM-1996, PM-1586) (#20741) Backport of #20741 to cloud/1.57. PM-1343, PM-1996 and PM-1586 share one user-visible failure: the agent reports successful canvas work while the canvas is empty or unchanged. A successful canvas-mutating tool now reads as confirmed only when the operations it names are observed on that workflow through the follower path, and a completed turn that claims canvas content over a still-empty bound canvas says so explicitly. Carried on top of #21369 in the preceding commit, which this change reads `workflow_id` / `op_ids` from. Release resolutions: - The follower's typed `terminal` state (`null | 'refused' | 'schema_error'`) does not exist on this branch. `AgentPanelRoot.vue` latches the one signal that does -- `onSyncError`, which fires on exactly those two conditions -- and releases it when the follower resubscribes. The load-bearing distinction is preserved: not-yet-connected reads `'none'`, permanently refused reads `'unavailable'`. - `browser_tests/tests/agent/agentSchemaSkewTellsTheUser.spec.ts` does not exist on this branch, so upstream's one-assertion update to it is dropped rather than the whole spec being introduced. - `agentToolCallHistoryPersistence.spec.ts`: upstream's `TRACE` interleaves thinking rows this branch's trace does not carry (#21600). The row this fix changes is asserted the same way; the thinking rows are not added. - `AgentPanel.test.ts`: only the new empty-canvas-priority case is added. The two adjacent upstream cases were conflict context, not part of this change. - `AgentPanelRoot.test.ts`: `dispatchApiEvent` is defined locally, as it is upstream. - `oxlint-suppressions.json` keeps this branch's entries: the one suppression upstream removes is not present here. - Relative import paths and `GetFeaturesResponse`, as on this branch. Verified on this branch: `pnpm typecheck:browser`, `pnpm typecheck:app`, and the full agent unit suite -- 166 files, 3,590 tests pass, 1 expected fail. The black-box proof travels with the carrier as `browser_tests/tests/agent/agentCanvasClaimNeedsObservation.spec.ts`. (cherry picked from commit 08b4792) Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-25T17:37:01.365Z",
"gitSha": "8e07c903b48a1ae5b99163a80c827ed2154b2278",
"branch": "backport-20741-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.2370000000083,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.161999999999999,
"layouts": 9,
"layoutDurationMs": 3.2909999999999995,
"taskDurationMs": 374.50800000000004,
"heapDeltaBytes": 22187152,
"heapUsedBytes": 88459608,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.400999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2024.2690000000039,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.333999999999999,
"layouts": 9,
"layoutDurationMs": 3.176,
"taskDurationMs": 528.332,
"heapDeltaBytes": -1025640,
"heapUsedBytes": 73801132,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.378000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1729.1210000000206,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.208,
"layouts": 9,
"layoutDurationMs": 2.4520000000000004,
"taskDurationMs": 769.4060000000001,
"heapDeltaBytes": 15620388,
"heapUsedBytes": 81478684,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 179.37900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.492999999963,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.961999999999996,
"layouts": 9,
"layoutDurationMs": 2.8899999999999997,
"taskDurationMs": 909.05,
"heapDeltaBytes": -8265204,
"heapUsedBytes": 67235536,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 178.092,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571424,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.1449999999923,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.099000000000001,
"layouts": 11,
"layoutDurationMs": 2.9110000000000005,
"taskDurationMs": 403.78499999999997,
"heapDeltaBytes": -403356,
"heapUsedBytes": 74607888,
"domNodes": 47,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 12.302,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1788.7739999999894,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.263,
"layouts": 11,
"layoutDurationMs": 2.3669999999999995,
"taskDurationMs": 421.429,
"heapDeltaBytes": -4542796,
"heapUsedBytes": 70568192,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.028,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 748.800000000017,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.353999999999999,
"layouts": 8,
"layoutDurationMs": 2.766,
"taskDurationMs": 507.124,
"heapDeltaBytes": 26432200,
"heapUsedBytes": 91847356,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 191.34400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 650.8509999999887,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.763999999999999,
"layouts": 9,
"layoutDurationMs": 2.487,
"taskDurationMs": 451.966,
"heapDeltaBytes": 26077080,
"heapUsedBytes": 92401800,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 177.533,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1267.9109999999696,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 975.494,
"heapDeltaBytes": -11360172,
"heapUsedBytes": 81288156,
"domNodes": -192,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 74.6,
"eventListeners": -106,
"totalBlockingTimeMs": 575,
"frameDurationMs": 34.23243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1243.4190000000171,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 950.9329999999999,
"heapDeltaBytes": 1012104,
"heapUsedBytes": 81391672,
"domNodes": -212,
"jsHeapTotalBytes": 14688256,
"scriptDurationMs": 72.578,
"eventListeners": -106,
"totalBlockingTimeMs": 570,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.3090000000198,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.1219999999996,
"heapDeltaBytes": -5473932,
"heapUsedBytes": 75852492,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 166.57299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.762857142857165,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 871.4009999999917,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.71500000000015,
"heapDeltaBytes": -2832176,
"heapUsedBytes": 77013296,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 175.10199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12306.491999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11453.123,
"heapDeltaBytes": -12442140,
"heapUsedBytes": 87176200,
"domNodes": -258,
"jsHeapTotalBytes": 14544896,
"scriptDurationMs": 9466.152,
"eventListeners": -67,
"totalBlockingTimeMs": 2210,
"frameDurationMs": 34.94176136363637,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11209.267999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10394.215,
"heapDeltaBytes": -9448892,
"heapUsedBytes": 84765968,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 8561.201000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 1346,
"frameDurationMs": 31.907407407407412,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10239.410999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9393.941,
"heapDeltaBytes": -2770664,
"heapUsedBytes": 97481716,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 7955.8020000000015,
"eventListeners": -68,
"totalBlockingTimeMs": 1272,
"frameDurationMs": 32.79775641025641,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10590.057999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9807.703,
"heapDeltaBytes": -5351700,
"heapUsedBytes": 83120300,
"domNodes": -278,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 8000.784,
"eventListeners": -68,
"totalBlockingTimeMs": 1152,
"frameDurationMs": 31.126176470588234,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 235.83300000001373,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.506,
"layouts": 11,
"layoutDurationMs": 3.606,
"taskDurationMs": 182.35199999999998,
"heapDeltaBytes": -8379364,
"heapUsedBytes": 79219752,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.520999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.339999999999964,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 223.37599999991653,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.739000000000003,
"layouts": 11,
"layoutDurationMs": 3.5389999999999997,
"taskDurationMs": 172.643,
"heapDeltaBytes": -8145848,
"heapUsedBytes": 79348648,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.083,
"eventListeners": 195,
"totalBlockingTimeMs": 3,
"frameDurationMs": 21.21818181818187,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2055.8470000000284,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.865,
"layouts": 9,
"layoutDurationMs": 3.1859999999999995,
"taskDurationMs": 696.4839999999999,
"heapDeltaBytes": -23086284,
"heapUsedBytes": 73882188,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 41.967999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2051.672999999937,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9850000000000008,
"layouts": 5,
"layoutDurationMs": 1.9520000000000002,
"taskDurationMs": 691.216,
"heapDeltaBytes": -7322544,
"heapUsedBytes": 72244016,
"domNodes": -278,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 39.22299999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2519.0470000000005,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.846,
"layouts": 7,
"layoutDurationMs": 1.8240000000000005,
"taskDurationMs": 1663.622,
"heapDeltaBytes": -11759304,
"heapUsedBytes": 68351036,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 932.4480000000001,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.890604026845637,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2813.040000000001,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.389,
"layouts": 7,
"layoutDurationMs": 1.8890000000000005,
"taskDurationMs": 1918.14,
"heapDeltaBytes": -29031460,
"heapUsedBytes": 68638300,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 901.629,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.866867469879516,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3839.002999999991,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.36,
"layouts": 64,
"layoutDurationMs": 11.513,
"taskDurationMs": 1907.3729999999998,
"heapDeltaBytes": 4364996,
"heapUsedBytes": 81370840,
"domNodes": -234,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 844.3080000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.738427947598254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4018.652999999972,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.031,
"layouts": 63,
"layoutDurationMs": 11.527000000000001,
"taskDurationMs": 1965.8700000000001,
"heapDeltaBytes": 12854928,
"heapUsedBytes": 90612488,
"domNodes": -234,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 893.0219999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.735833333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3212.9510000000323,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.926000000000002,
"layouts": 4,
"layoutDurationMs": 1.4189999999999996,
"taskDurationMs": 2084.315,
"heapDeltaBytes": -5760408,
"heapUsedBytes": 78148964,
"domNodes": 0,
"jsHeapTotalBytes": 6119424,
"scriptDurationMs": 1027.972,
"eventListeners": 182,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.19787234042553,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3252.5590000000193,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.917,
"layouts": 3,
"layoutDurationMs": 1.025,
"taskDurationMs": 2103.5559999999996,
"heapDeltaBytes": 6313056,
"heapUsedBytes": 85351052,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 1070.71,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.099999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2050.362000000007,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6420000000000001,
"layouts": 6,
"layoutDurationMs": 1.6879999999999997,
"taskDurationMs": 475.259,
"heapDeltaBytes": -1978736,
"heapUsedBytes": 78297440,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.846000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.5489999999372,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0109999999999997,
"layouts": 7,
"layoutDurationMs": 1.914,
"taskDurationMs": 456.9409999999999,
"heapDeltaBytes": -2093504,
"heapUsedBytes": 79794640,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 30.178000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 676.9899999999893,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.753,
"layouts": 8,
"layoutDurationMs": 2.6820000000000004,
"taskDurationMs": 477.64799999999997,
"heapDeltaBytes": 21621360,
"heapUsedBytes": 88591548,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 151.499,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.0260000000044,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.837999999999999,
"layouts": 10,
"layoutDurationMs": 2.473,
"taskDurationMs": 431.83099999999996,
"heapDeltaBytes": -2407400,
"heapUsedBytes": 74712872,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 147.565,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.4470000000288,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9039999999999995,
"layouts": 9,
"layoutDurationMs": 2.5250000000000004,
"taskDurationMs": 544.9679999999998,
"heapDeltaBytes": -253616,
"heapUsedBytes": 77610240,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.576,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.3440000000046,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.326,
"layouts": 10,
"layoutDurationMs": 3.513,
"taskDurationMs": 549.0590000000001,
"heapDeltaBytes": -193716,
"heapUsedBytes": 77753064,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.691999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.9270000000265,
"styleRecalcs": 86,
"styleRecalcDurationMs": 18.893,
"layouts": 9,
"layoutDurationMs": 2.6080000000000005,
"taskDurationMs": 1067.407,
"heapDeltaBytes": 11708532,
"heapUsedBytes": 78650212,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 125.244,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1975.4779999999528,
"styleRecalcs": 87,
"styleRecalcDurationMs": 18.892,
"layouts": 10,
"layoutDurationMs": 2.9219999999999997,
"taskDurationMs": 1087.3600000000001,
"heapDeltaBytes": 15242208,
"heapUsedBytes": 92311616,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 123.72899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1485.8679999999822,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.87100000000001,
"layouts": 5,
"layoutDurationMs": 17.025,
"taskDurationMs": 1099.951,
"heapDeltaBytes": 9378256,
"heapUsedBytes": 107770060,
"domNodes": 15953,
"jsHeapTotalBytes": 16912384,
"scriptDurationMs": 30.681999999999995,
"eventListeners": 3244,
"totalBlockingTimeMs": 182,
"frameDurationMs": 20.27027027027028,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9479.313999999988,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.351,
"layouts": 8,
"layoutDurationMs": 2.573,
"taskDurationMs": 6262.178,
"heapDeltaBytes": -19934756,
"heapUsedBytes": 77522044,
"domNodes": -278,
"jsHeapTotalBytes": 4288512,
"scriptDurationMs": 2889.6440000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.724911660777384,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8487.572,
"styleRecalcs": 249,
"styleRecalcDurationMs": 22.181,
"layouts": 7,
"layoutDurationMs": 2.21,
"taskDurationMs": 5573.812,
"heapDeltaBytes": 8077636,
"heapUsedBytes": 87046452,
"domNodes": -258,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 2917.614,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.731952662721895,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23443.082000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22978.782000000003,
"heapDeltaBytes": -26151972,
"heapUsedBytes": 274786036,
"domNodes": -3330,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 333.87899999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.33115318416523,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 22985.183000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22105.882,
"heapDeltaBytes": -11565580,
"heapUsedBytes": 289263240,
"domNodes": -3330,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 320.19,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.459793814432985,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 28651.805999999964,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.88299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28224.543,
"heapDeltaBytes": 5409308,
"heapUsedBytes": 287175824,
"domNodes": -3330,
"jsHeapTotalBytes": 10665984,
"scriptDurationMs": 920.0740000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 52.760220994475134,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27709.069999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.173999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27338.058,
"heapDeltaBytes": -9102472,
"heapUsedBytes": 286380824,
"domNodes": -3330,
"jsHeapTotalBytes": 7782400,
"scriptDurationMs": 920.2389999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 43,
"frameDurationMs": 50.8543119266055,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8544.920999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.072,
"layouts": 20,
"layoutDurationMs": 23.70299999999999,
"taskDurationMs": 8427.866,
"heapDeltaBytes": -2500092,
"heapUsedBytes": 278761456,
"domNodes": -3330,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 137.00600000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.67039106145251,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8450.423,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.50400000000002,
"layouts": 20,
"layoutDurationMs": 22.179999999999993,
"taskDurationMs": 8324.212,
"heapDeltaBytes": -36485808,
"heapUsedBytes": 259584540,
"domNodes": -3334,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 148.79999999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.74566473988439,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11568.528000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11354.017,
"heapDeltaBytes": 28700196,
"heapUsedBytes": 273786432,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.74199999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.30821428571429,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8209.35200000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7667.173,
"heapDeltaBytes": 14486648,
"heapUsedBytes": 271164936,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.87599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.851864406779658,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 503.08499999994183,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.61,
"layouts": 10,
"layoutDurationMs": 4.377000000000001,
"taskDurationMs": 160.358,
"heapDeltaBytes": 7002536,
"heapUsedBytes": 80207040,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.565000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.237931034482745,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 478.28199999992194,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.04,
"layouts": 12,
"layoutDurationMs": 4.3629999999999995,
"taskDurationMs": 128.523,
"heapDeltaBytes": -13335692,
"heapUsedBytes": 70325120,
"domNodes": 95,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 10.816999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 577.9380000000174,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.382,
"layouts": 76,
"layoutDurationMs": 16.469,
"taskDurationMs": 531.8159999999999,
"heapDeltaBytes": -13642168,
"heapUsedBytes": 81581352,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 262.50800000000004,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 533.123000000046,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.279,
"layouts": 76,
"layoutDurationMs": 15.817000000000002,
"taskDurationMs": 486.177,
"heapDeltaBytes": -20794180,
"heapUsedBytes": 72207992,
"domNodes": 4,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 240.05300000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 573.5579999999345,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8190000000000002,
"layouts": 76,
"layoutDurationMs": 14.951,
"taskDurationMs": 532.3,
"heapDeltaBytes": 356592,
"heapUsedBytes": 131742508,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 223.175,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15588235294118,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 569.8579999999538,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.089,
"layouts": 76,
"layoutDurationMs": 15.157,
"taskDurationMs": 529.0740000000001,
"heapDeltaBytes": 913320,
"heapUsedBytes": 127389316,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 218.664,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15588235294118,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2280 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b59472cb23fa3e44c275d0d14d1ed8aeee724eea
Full docs: ADR-DEVEX-LINT-0015 |
…n for it The first pass at this backport replaced upstream's typed `terminal` status with a latch on `onSyncError` in `AgentPanelRoot.vue`, on the grounds that `onSyncError` fires on the same two conditions. It does not fire often enough: `handleSubscribeRefusal` suppresses the notification for `unsupported` and for a refusal that repeats on a workflow already notified, so a refused subscribe left the summary reading "Worked" instead of "Changes not confirmed on your canvas". CI caught it: `agentRefusedDocSubscribe` and `agentZeroNodesOnUnreadableSchema` both failed on exactly that assertion. Carried properly instead. `AgentCrdtDocLifecycle.refusalIsFinal()` is added with upstream's body, which is a pure derivation over `confirmedSinceLastSend` and `subscribeRetryTimer` -- both already present here, with identical semantics: the refusal and retry-ladder paths differ from `main` only in cosmetics. The follower gains the `terminal` ref and sets it at upstream's four sites, `AgentCrdtStatus` exposes it, and `AgentPanelRoot.vue` reads `status.terminal === null ? 'none' : 'unavailable'` as upstream does. `AgentCrdtTerminalState` is declared locally as `'refused' | 'schema_error' | null`: upstream types it in `agentCrdtStatus.ts` over `SubscribeGiveUpReason`, and neither that module nor that union exists on this branch, so the two values the follower actually sets are named directly. Four status fixtures gain `terminal: null`, as their upstream counterparts carry. Verified: `pnpm typecheck:app`, `pnpm typecheck:browser`, and 167 files / 3,594 unit tests pass.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.57 #21918 +/- ##
============================================
Coverage 84.12% 84.13%
============================================
Files 2840 2842 +2
Lines 158064 158220 +156
Branches 40601 38506 -2095
============================================
+ Hits 132970 133113 +143
- Misses 24705 24718 +13
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The previous commit carried upstream's `terminal` status but set it at four of upstream's seven sites. The three missing ones change what the canvas confirmation gate reports: - Ack-timeout give-up. Upstream's lifecycle passes a `SubscribeGiveUpReason` to `onGaveUp` and the follower records it as `terminal`. Here the callback took no reason, so a subscribe that went unanswered past the ack budget left `terminal` null, the gate read `none`, and a successful canvas write read "Worked" instead of "Changes not confirmed on your canvas". - A confirmed subscribe clears `terminal`. - A retarget clears `terminal`. Without the last two, a refusal on one workflow outlived the episode: after switching tabs, or after a later subscribe succeeded and then dropped, the gate read `unavailable` and denied writes upstream leaves unclaimed. `SubscribeGiveUpReason` is carried as upstream declares it, so `AgentCrdtTerminalState` now uses upstream's union. Upstream's "terminal follower state" tests are carried, minus the ones that assert `canvasMayBeStale` or reconnect re-refusal through `agentSocket`, which this branch does not have. Four of the seven fail on the previous commit. Verified: `pnpm typecheck:app`, `pnpm typecheck:browser`, and the agent unit suite, 166 files, 3,605 tests pass, 1 expected fail.
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review, exact head 738c5e0629. Merging under the Agent release-backport grant (core/1.57).
- Resolutions match upstream #21369 + #20741; same patches as #21917 apart from offsets.
- Fixed one gap: 3 missing follower
terminaltransitions (ack-timeout give-up read "Worked"). Commit738c5e0629, 4 of 7 carried tests red before it. - All checks green, including
lint-and-format,testande2e-status; the changed agent specs pass 13/13.
Full context for agent readers
- Authority:
program/active-authority.mdrow for the current Agent backport trains namescore/1.57. Author is the merging identity, so this is a COMMENT review, not an approval. - Sources: #21369 merged as
454b1cd71e, #20741 merged as08b47923463c. Base is the livecore/1.57tipb59472cb23. - Patch review:
git range-diffagainst both upstream commits. The hand-writtenzAgentToolCallDatacorrelation fields match the generated schema inpackages/ingest-types/src/zod.gen.tsat454b1cd71e.agentEventTransport.tsandcanvasConfirmationStateare identical to upstream. - Gap fixed in
738c5e0629: upstream setsterminalat seven sites and2eab8a9c47set four. Added: the lifecycle give-up reason (refused/timeout), clearing on a confirmed subscribe, and clearing on retarget. - Black-box: the changed-spec job ran 13 tests. At
f68d3c8dbe2 failed ("Worked" where "Changes not confirmed on your canvas" was expected); at2eab8a9c47and at738c5e0629all 13 passed. - Exact-head gate:
check-merge-ready.sh --target-branch core/1.57reports MERGE READY at738c5e0629, 127 completed checks with no failures. - Ruleset 7297873 requires
lint-and-format,testande2e-status, squash only, 1 approval, no named reviewers. - Local checks: agent unit suite 166 files, 3,605 pass, 1 expected fail.
typecheck:appandtypecheck:browserclean.
…erved canvas state (PM-1343, PM-1996, PM-1586) (#21966) Backport of [#21369](#21369) and [#20741](#20741) to `cloud/1.58`, the declared Cloud release line (`frontend-version.json` `releaseBranch`). Same pair `cloud/1.57` already carries as [#21917](#21917) (merge `1f0d5e900a`). ## Why PM-2072: the panel can say **Worked** while the canvas stays empty. The fix is on `cloud/1.57` but not on `cloud/1.58`, so a canvas cut from the release line would ship without it. ## How it was built Cherry-picks of the `main` squash merges `454b1cd71e` and `08b4792346` (not the 1.57 carrier). That brings `main`'s full terminal follower state, including `timeout`, which #21917 and #21918 had to restore after review. Conflicts were import paths, plus three adaptations to this branch: - `RunNoticeBanner.vue`: added only the `emptyCanvas` context. This branch has no `genericNoticeReady`. - `AgentPanel.test.ts`: added only #20741's empty-canvas test. The other conflicting tests belong to a run-notice feature that is not on this branch. - `agentToolCallHistoryPersistence.spec.ts`: this branch's trace has no thinking rows, so `TRACE` is the two tool rows. Same adaptation as #21917. ## Verification - Agent unit suites plus `api.logs.test.ts`: 176 files, 4,021 passed, 1 expected fail. `typecheck:app` and `typecheck:browser` clean. - Black-box, `--project=cloud`, local backend: six changed Agent specs, **13/13 pass** at this head. - Red on `cloud/1.58` source, using this branch's specs and locale strings: **7 failed**. `agentRefusedDocSubscribe` "reports a canvas edit as unconfirmed" received **"Worked"**. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
…rved canvas state (PM-1343, PM-1996, PM-1586) (#22062) ## ELI5 Adds the "don't say Worked unless the canvas shows it" check to the core 1.58 line. Cloud 1.57, Cloud 1.58 and core 1.57 already have it; core 1.58 was missed. ## Summary Clean cherry-pick of the cloud/1.58 carrier #21966 (`f6994bfd0d`), itself a backport of #21369 and #20741. No conflicts; `core/1.58` and `cloud/1.58` share this code. - Ticket: PM-2072 (also PM-1343, PM-1996, PM-1586) - Siblings: #21917 (cloud/1.57), #21918 (core/1.57), #21966 (cloud/1.58) <details><summary>Full context for agent readers</summary> - `core/1.58` vs `main` merge `08b4792346` (#20741): diverged, not contained. Without this PR the next core 1.58 patch ships the panel without the observed-canvas gate. - Local at this head (Node 26.12.1): `pnpm typecheck` green; `vitest run src/workbench/extensions/agent` 175 files, 4019 passed, 1 expected fail. - Runnable proof travels with it: `browser_tests/tests/agent/agentCanvasClaimNeedsObservation.spec.ts` (CI E2E). </details> Co-authored-by: Alexander Brown <drjkl@comfy.org>
Backport of #20741 to
core/1.57, with its prerequisite #21369. Pair of #21917, which carries the same two commits ontocloud/1.57.Why this branch
The 1.57 pair is the live train.
cloud/1.57is what Cloud users are running — the production overlay pins stableba2c2c2269and canary33357d4bedat 10%, and both are on that branch and on no other release branch — andcore/1.57is its counterpart, which every other backport in this repo goes out to alongside it. Both commits apply tocore/1.57with no conflict once resolved forcloud/1.57, so this carrier is a clean pick of #21917's two commits.Why three commits
#20741 reads the terminal tool frame's
workflow_idandop_ids. Neither field exists on this branch, so #21369 — the change that introduced them — is carried first. Without it the confirmed-write gate has no data source at all. The third commit repairs a resolution I got wrong on the first push, described below.What it fixes
PM-1343, PM-1996 and PM-1586 share one user-visible failure: the agent reports successful canvas work while the canvas is empty or unchanged. After this, a successful canvas-mutating tool reads as confirmed only when the operations it names are observed on that workflow through the follower path, and a completed turn claiming canvas content over a still-empty bound canvas says so explicitly. The server result and the browser observation stay separate — a tool can report success while its canvas effect is pending or unconfirmable.
Why the auto-backport could not do this
The bot attempted
core/1.56andcloud/1.56on merge and failed both on conflicts in 15 files. It is not a stacking conflict that clears when open PRs land:mainis 169 agent-area commits ahead of the 1.57 branch point, and three subsystems the change sits on exist only onmain. Each is resolved explicitly rather than approximated. The resolutions below were authored againstcloud/1.57and transfer here byte-identically.Release resolutions
zAgentToolCallDatain@comfyorg/ingest-types.catch(undefined)as upstream has themterminalstate, andAgentCrdtDocLifecycle.refusalIsFinal()refusalIsFinal()is a pure derivation overconfirmedSinceLastSendandsubscribeRetryTimer, which are already here with identical semantics.AgentCrdtTerminalStateis declared locally as'refused' | 'schema_error' | null, because upstream types it in anagentCrdtStatus.tsthat does not exist heremarkProjectionStale,clearProjectionStaleness,hasPendingFailure)projectionAppliedCleanlyadded locally with upstream's bodyagentToolCallHistoryPersistence.spec.tsasserts the same changed row without the thinking rowsagentSchemaSkewTellsTheUser.spec.tsSmaller ones:
AgentPanel.test.tsgains only the new empty-canvas-priority case (the two adjacent upstream cases were conflict context, not part of this change);AgentPanelRoot.test.tsdefinesdispatchApiEventlocally as upstream does;oxlint-suppressions.jsonkeeps this branch's entries, since the one suppression upstream removes is not present here;RunNoticeBanner.vuedoes not gain upstream's pre-existinggenericNoticeReadyprop; relative import paths throughout.The
terminalrow is the one that mattered, and the first push got it wrong. I replaced the typed state with a latch ononSyncError, reasoning that it fires on the same two conditions. It does not fire often enough: the refusal handler suppresses the notification forunsupportedand for a refusal that repeats on an already-notified workflow, so a refused subscribe still read "Worked". CI caught it, becauseagentRefusedDocSubscribeandagentZeroNodesOnUnreadableSchemaboth failed on that exact assertion, and the third commit carries the real thing instead.The distinction it preserves: a follower that is merely not connected yet must read
none, meaning say nothing about the write, while one that has permanently given up must readunavailable, meaning say the write cannot be confirmed. Collapsing those two would deny every write in any environment where the follower never subscribes.Verification on this branch
pnpm typecheck:appandpnpm typecheck:browserboth clean.cloud/1.57carrier these commits were authored on.browser_tests/tests/agent/agentCanvasClaimNeedsObservation.spec.ts. Playwright was not run here — this branch's hosted CI is the first full run of it.Scope
No change to the semantic document protocol and no repair of a failed delivery path. This makes an unobserved canvas write honest in the UI; delivery remains a separate investigation.
src/locales/en/main.jsonand threebrowser_tests/fixtures/files sit outside the Agent review globs.Review correction: fourth commit
Review at
2eab8a9c47found the third commit setterminalat four of upstream's seven sites.738c5e0629carries the other three: an ack-timeout give-up now recordsterminal: 'timeout'(before, the gate readnoneand a write read "Worked"), and a confirmed subscribe or a retarget clearsterminal(before, a refusal outlived its episode and later writes read "not confirmed"). Upstream's terminal-state follower tests come with it; four of the seven fail on2eab8a9c47.