Repository navigation
[backport core/1.57] fix(agent): report a free-text-only answer that won elsewhere - #21880
Conversation
## Summary Follow-up to #21320. That PR stopped a 409 with no selection from raising a false "answered somewhere else" notice, but its guard only looked at `selected`. The ask conflict schema also allows a committed free-text-only answer (`status: answered`, `selected` null or omitted, `other_text` set). In that case the 409 does name the winning answer, and the user got no superseded notice and no telemetry. ## Change - One predicate, `namesCommittedAnswer`: a body names the committed answer when it carries a `selected` array or non-empty `other_text`. - The check moved inside `reportSupersededAnswer`, so all three sources share it: the 202 receipt, the 409 conflict and the `agent_ask_resolved` frame. The frame path had no guard before, so an answered frame with a null selection also raised a false superseded report. - Removes the `//` comment #21320 added (AGENTS.md); the predicate name carries the reason. `selected: []` still counts as naming an answer, matching the existing `reports an empty committed answer that replaced this one` test and the schema ("empty when the answer was free text only"). ## Tests (written first) - `reports a 409 whose free text alone shows another answer won` (null and omitted `selected`): failed before, pass now. - `does not report an answered frame with a null selection as another answer winning`: failed before, passes now. - `reports / does not report a 202 that names only free text` and `... a free-text-only frame` (second commit, from review). Against main's source the 202 "reports" case fails; the others pin behavior that already held. - `useAgentSession.test.ts`: 261 pass. Agent suite: 4194 pass; the only failure is the known order-dependent `(g18)` test (FE-3485), which also fails on main. - typecheck, oxlint, eslint, format clean. ## Review A fresh Claude reviewer (adversarial-review, Skeptic + Minimalist; no cross-model CLI available on this host) found no blockers or majors. Its test-gap and duplicated-type notes are in the second commit. Not changed here: the superseded telemetry message (being rewritten in #21327), and an answered frame with `selected: null` still renders as an empty answer (out of contract per the schema; unchanged). ## Review threads on #21320 This addresses the Medium, the frame-path Low and the Nit. Replies on #21320 explain the other two Lows. ## Overlap #21327 edits the body of `reportSupersededAnswer` below the new guard. Whichever lands second needs a small rebase; no behavior conflict.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-24T02:57:35.378Z",
"gitSha": "489ec774fe18c8eff65777b1254d31bcc95fcc6e",
"branch": "backport-21829-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.8900000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7590000000000003,
"layouts": 9,
"layoutDurationMs": 2.514,
"taskDurationMs": 312.944,
"heapDeltaBytes": 22123816,
"heapUsedBytes": 88858244,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.941999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2008.7800000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9530000000000007,
"layouts": 10,
"layoutDurationMs": 2.7119999999999997,
"taskDurationMs": 335.55999999999995,
"heapDeltaBytes": -977080,
"heapUsedBytes": 73734960,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.155999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.8249999999891,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.531999999999998,
"layouts": 9,
"layoutDurationMs": 2.0930000000000004,
"taskDurationMs": 553.8949999999999,
"heapDeltaBytes": 15130060,
"heapUsedBytes": 81391364,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 107.115,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.0669999999986,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.494000000000002,
"layouts": 9,
"layoutDurationMs": 2.3440000000000007,
"taskDurationMs": 643.724,
"heapDeltaBytes": 15590300,
"heapUsedBytes": 81988884,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 123.08400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.1039999999916,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.132999999999999,
"layouts": 12,
"layoutDurationMs": 2.835,
"taskDurationMs": 241.819,
"heapDeltaBytes": -40956,
"heapUsedBytes": 75029224,
"domNodes": 47,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 9.156,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.4840000000318,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.159000000000001,
"layouts": 12,
"layoutDurationMs": 2.8520000000000003,
"taskDurationMs": 253.035,
"heapDeltaBytes": -385452,
"heapUsedBytes": 74631168,
"domNodes": 47,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 8.844999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 464.53800000000456,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8449999999999993,
"layouts": 6,
"layoutDurationMs": 1.5690000000000002,
"taskDurationMs": 300.68600000000004,
"heapDeltaBytes": 25525832,
"heapUsedBytes": 90990480,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 104.075,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 532.5729999999567,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.150000000000001,
"layouts": 9,
"layoutDurationMs": 2.778,
"taskDurationMs": 374.236,
"heapDeltaBytes": 25224852,
"heapUsedBytes": 92040188,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 122.54299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 928.2010000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.844,
"heapDeltaBytes": -11498364,
"heapUsedBytes": 81081028,
"domNodes": -192,
"jsHeapTotalBytes": 19144704,
"scriptDurationMs": 38.144999999999996,
"eventListeners": -106,
"totalBlockingTimeMs": 269,
"frameDurationMs": 25.924999999999994,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 941.6100000000256,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.7720000000002,
"heapDeltaBytes": 1202868,
"heapUsedBytes": 81739272,
"domNodes": -192,
"jsHeapTotalBytes": 13377536,
"scriptDurationMs": 41.208999999999996,
"eventListeners": -106,
"totalBlockingTimeMs": 293,
"frameDurationMs": 26.386111111111113,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 695.5140000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 281.82300000000015,
"heapDeltaBytes": 22509296,
"heapUsedBytes": 104581508,
"domNodes": 0,
"jsHeapTotalBytes": 3149824,
"scriptDurationMs": 94.90700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 719.8920000000157,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.17099999999965,
"heapDeltaBytes": -5310536,
"heapUsedBytes": 75903172,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 98.37900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 97,
"frameDurationMs": 21.079411764705902,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6260.410999999976,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.987,
"layouts": 4,
"layoutDurationMs": 3.133,
"taskDurationMs": 5130.083999999999,
"heapDeltaBytes": 7241480,
"heapUsedBytes": 84039708,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 3958.7780000000007,
"eventListeners": -68,
"totalBlockingTimeMs": 24,
"frameDurationMs": 19.392283950617283,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6598.853000000019,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9050000000000005,
"layouts": 3,
"layoutDurationMs": 0.8449999999999999,
"taskDurationMs": 5443.93,
"heapDeltaBytes": -22768128,
"heapUsedBytes": 71458024,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 4236.963000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 66,
"frameDurationMs": 20.560124610591902,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6038.860999999997,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2200000000000006,
"layouts": 4,
"layoutDurationMs": 1.0170000000000001,
"taskDurationMs": 4835.402999999999,
"heapDeltaBytes": -26317828,
"heapUsedBytes": 72757120,
"domNodes": -258,
"jsHeapTotalBytes": 12709888,
"scriptDurationMs": 3908.652,
"eventListeners": -68,
"totalBlockingTimeMs": 17,
"frameDurationMs": 19.91122112211221,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6473.486000000037,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8830000000000001,
"layouts": 3,
"layoutDurationMs": 0.7959999999999998,
"taskDurationMs": 5394.226000000001,
"heapDeltaBytes": 13454000,
"heapUsedBytes": 101004752,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 4193.638,
"eventListeners": -68,
"totalBlockingTimeMs": 23,
"frameDurationMs": 20.8459807073955,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 170.51100000000474,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.729,
"layouts": 13,
"layoutDurationMs": 3.685,
"taskDurationMs": 125.416,
"heapDeltaBytes": -8132684,
"heapUsedBytes": 78923436,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6.949000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837500000000034,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 168.6379999999872,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.647,
"layouts": 12,
"layoutDurationMs": 3.0700000000000003,
"taskDurationMs": 118.49700000000001,
"heapDeltaBytes": -8267820,
"heapUsedBytes": 79687900,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.460999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.825000000000045,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2026.6479999999945,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.798,
"layouts": 8,
"layoutDurationMs": 1.554,
"taskDurationMs": 379.802,
"heapDeltaBytes": -2205764,
"heapUsedBytes": 76563500,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 25.233999999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2042.8119999999694,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7989999999999995,
"layouts": 9,
"layoutDurationMs": 2.8000000000000003,
"taskDurationMs": 551.836,
"heapDeltaBytes": -1513588,
"heapUsedBytes": 77955348,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 36.23799999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2363.077999999973,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.298,
"layouts": 7,
"layoutDurationMs": 1.642,
"taskDurationMs": 1225.433,
"heapDeltaBytes": -31908252,
"heapUsedBytes": 67203816,
"domNodes": -258,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 591.194,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.785,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2799.549000000013,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.389,
"layouts": 8,
"layoutDurationMs": 2.231,
"taskDurationMs": 1293.482,
"heapDeltaBytes": 4208596,
"heapUsedBytes": 82202364,
"domNodes": -258,
"jsHeapTotalBytes": 2449408,
"scriptDurationMs": 618.18,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3537.56599999997,
"styleRecalcs": 73,
"styleRecalcDurationMs": 8.999,
"layouts": 66,
"layoutDurationMs": 11.766,
"taskDurationMs": 1275.912,
"heapDeltaBytes": -14048572,
"heapUsedBytes": 67862372,
"domNodes": -234,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 538.469,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3469.6860000000243,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.920000000000002,
"layouts": 67,
"layoutDurationMs": 13.146999999999998,
"taskDurationMs": 1328.56,
"heapDeltaBytes": 11733008,
"heapUsedBytes": 93285108,
"domNodes": -234,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 557.6419999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665700483091786,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2516.8580000000134,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.674,
"layouts": 6,
"layoutDurationMs": 1.575,
"taskDurationMs": 1396.3830000000003,
"heapDeltaBytes": 1143860,
"heapUsedBytes": 78839652,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 681.895,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66622516556291,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2673.5049999999774,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.778,
"layouts": 5,
"layoutDurationMs": 1.4420000000000002,
"taskDurationMs": 1421.502,
"heapDeltaBytes": 14673228,
"heapUsedBytes": 98633704,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 695.671,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2029.896000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.887,
"layouts": 9,
"layoutDurationMs": 2.426,
"taskDurationMs": 401.95500000000004,
"heapDeltaBytes": -3148528,
"heapUsedBytes": 73672520,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 26.471,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.4320000000093,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.059,
"layouts": 8,
"layoutDurationMs": 1.853,
"taskDurationMs": 399.50600000000003,
"heapDeltaBytes": -2459984,
"heapUsedBytes": 75002800,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 27.066999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 463.6859999999956,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.789000000000001,
"layouts": 11,
"layoutDurationMs": 2.728,
"taskDurationMs": 301.54800000000006,
"heapDeltaBytes": 3162036,
"heapUsedBytes": 80058544,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 98.797,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 463.1310000000326,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.258,
"layouts": 10,
"layoutDurationMs": 2.4339999999999997,
"taskDurationMs": 291.754,
"heapDeltaBytes": -1083724,
"heapUsedBytes": 76385160,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 98.90599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.3470000000195,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.346999999999999,
"layouts": 9,
"layoutDurationMs": 1.965,
"taskDurationMs": 305.427,
"heapDeltaBytes": 22466480,
"heapUsedBytes": 89353868,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.742000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.6099999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5370000000000013,
"layouts": 10,
"layoutDurationMs": 3.174,
"taskDurationMs": 447.27299999999997,
"heapDeltaBytes": -234476,
"heapUsedBytes": 76748324,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 12.735999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.760999999985,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.450000000000001,
"layouts": 9,
"layoutDurationMs": 1.955,
"taskDurationMs": 474.746,
"heapDeltaBytes": 10853360,
"heapUsedBytes": 77791716,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 84.445,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.6109999999799,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.289,
"layouts": 9,
"layoutDurationMs": 2.6750000000000003,
"taskDurationMs": 669.431,
"heapDeltaBytes": 11704088,
"heapUsedBytes": 78633440,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 101.001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 849.9400000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.169,
"layouts": 5,
"layoutDurationMs": 10.061000000000002,
"taskDurationMs": 671.7549999999999,
"heapDeltaBytes": 7368416,
"heapUsedBytes": 104808200,
"domNodes": 15953,
"jsHeapTotalBytes": 17965056,
"scriptDurationMs": 21.66,
"eventListeners": 3244,
"totalBlockingTimeMs": 89,
"frameDurationMs": 19.767441860465116,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8573.135999999977,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.692999999999998,
"layouts": 9,
"layoutDurationMs": 2.288,
"taskDurationMs": 4108.329000000001,
"heapDeltaBytes": 7819248,
"heapUsedBytes": 86619440,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 1918.967,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8684.788000000026,
"styleRecalcs": 251,
"styleRecalcDurationMs": 24.825,
"layouts": 10,
"layoutDurationMs": 2.7590000000000003,
"taskDurationMs": 4284.173,
"heapDeltaBytes": -10608600,
"heapUsedBytes": 68872200,
"domNodes": -278,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 1990.746,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66609195402299,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12487.374999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11523.652,
"heapDeltaBytes": 18210096,
"heapUsedBytes": 293821376,
"domNodes": -3330,
"jsHeapTotalBytes": 49012736,
"scriptDurationMs": 171.96800000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.085810810810806,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "vue-large-graph-idle",
"durationMs": 17422.947000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16880.913999999997,
"heapDeltaBytes": -17720220,
"heapUsedBytes": 278214424,
"domNodes": -3330,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 254.11299999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.160207612456745,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 18257.204999999998,
"styleRecalcs": 142,
"styleRecalcDurationMs": 13.201999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17844.103,
"heapDeltaBytes": -4032700,
"heapUsedBytes": 278181860,
"domNodes": -3330,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 631.24,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.700922509225094,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19441.445999999927,
"styleRecalcs": 146,
"styleRecalcDurationMs": 15.382000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19015.945000000003,
"heapDeltaBytes": -37173492,
"heapUsedBytes": 258505312,
"domNodes": -3330,
"jsHeapTotalBytes": 10477568,
"scriptDurationMs": 697.7090000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 76,
"frameDurationMs": 35.884317343173436,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5884.620999999981,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.819,
"layouts": 20,
"layoutDurationMs": 21.174000000000014,
"taskDurationMs": 5715.686999999999,
"heapDeltaBytes": -11937244,
"heapUsedBytes": 279131188,
"domNodes": -3330,
"jsHeapTotalBytes": 23060480,
"scriptDurationMs": 89.23800000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 6,
"frameDurationMs": 35.228143712574855,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6281.352999999967,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.263000000000005,
"layouts": 20,
"layoutDurationMs": 24.232000000000003,
"taskDurationMs": 6156.6179999999995,
"heapDeltaBytes": -11861088,
"heapUsedBytes": 260738728,
"domNodes": -3330,
"jsHeapTotalBytes": 19390464,
"scriptDurationMs": 100.94500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.71270718232044,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8289.194000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7807.257000000001,
"heapDeltaBytes": -22981500,
"heapUsedBytes": 252543484,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.802,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.32662116040956,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8556.084000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8334.817000000001,
"heapDeltaBytes": 15919664,
"heapUsedBytes": 274834932,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.48100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.525951557093425,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 455.379999999991,
"styleRecalcs": 19,
"styleRecalcDurationMs": 11.213000000000001,
"layouts": 12,
"layoutDurationMs": 3.5299999999999994,
"taskDurationMs": 104.935,
"heapDeltaBytes": 6958452,
"heapUsedBytes": 71378304,
"domNodes": 124,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.868,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370367,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 100.54000000002361,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.404,
"layouts": 8,
"layoutDurationMs": 2.9579999999999997,
"taskDurationMs": 68.22099999999999,
"heapDeltaBytes": 4440336,
"heapUsedBytes": 68861524,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.814,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 253.93499999995583,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.975,
"layouts": 76,
"layoutDurationMs": 13.612,
"taskDurationMs": 215.053,
"heapDeltaBytes": 9440916,
"heapUsedBytes": 86047116,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.337,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 290.3390000000172,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.325,
"layouts": 76,
"layoutDurationMs": 14.776,
"taskDurationMs": 245.99599999999998,
"heapDeltaBytes": 9754320,
"heapUsedBytes": 88926428,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.833,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 381.09000000008564,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.054,
"layouts": 76,
"layoutDurationMs": 16.649,
"taskDurationMs": 337.414,
"heapDeltaBytes": -903640,
"heapUsedBytes": 118489772,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.96,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 324.77400000004764,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.986,
"layouts": 76,
"layoutDurationMs": 13.247,
"taskDurationMs": 282.89400000000006,
"heapDeltaBytes": -1672536,
"heapUsedBytes": 120928188,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 100.33200000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2280 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 012f0a3d030d4fe3a73172f46e99bf4e59f2b61f
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21880 +/- ##
=============================================
- Coverage 84.12% 84.12% -0.01%
=============================================
Files 2840 2840
Lines 158060 158064 +4
Branches 40598 40601 +3
=============================================
+ Hits 132967 132969 +2
- Misses 24704 24706 +2
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…g#21994) ## ELI5 When a merged change is copied to an extra release branch later, the automation also tried again to copy it to branches that had already received it. Those retries failed and posted "please do it by hand" messages, which could lead people to make duplicate copies. Now branches that already got the change are skipped. ## Summary PR Backport's filter step only skipped a target with an **open** backport PR. Bot backport PRs are squash-merged and their branch is deleted, so once one merged, adding another target label put the finished target back into the pending list. It then conflicted and posted a misleading "Backport to <target> failed" comment (seen on Comfy-Org#21829: core/1.57 was already backported via Comfy-Org#21880). - The filter step now also skips a target when a **merged** PR exists with head `backport-<PR>-to-<safe target>` and base `<target>`. That target is recorded in the `already-exists` output as `<target> (merged PR #N)`, so no backport is attempted and no failure comment is posted. The match ignores PRs from forks (`isCrossRepository`), so a fork reusing the branch name cannot hide a missing backport. - When every requested target is skipped as already merged, the filter emits `all-merged=true` and `needs-backport` is removed, so the label does not keep re-triggering the job. A skip caused by an open backport PR still leaves the label on. - `force_rerun` still bypasses the check, so a forced retry still works. - `REQUESTED_TARGETS` moved from inline `${{ }}` interpolation into the step `env`, so the test can run the step script as-is. The all-skipped warning now reads "All backport targets already handled" because the skip is no longer only about existing branches. - The conflict-comment text and the later `git branch -r --contains` guard are unchanged. ## Verification - New `scripts/cicd/pr-backport-filter.test.ts` runs the real `filter-targets` script from the YAML against stub `gh`/`git` on PATH. The `gh` stub returns only the requested `--json` fields and applies the step's real `--jq` filter. Cases: merged A + new B -> only B pending, A listed as already handled, `all-merged=false`; merged A + open B -> `skip=true`, `all-merged=false`; all merged -> `skip=true`, `all-merged=true`; a merged PR into a different base -> not skipped; a merged fork PR with the same branch name -> not skipped; `force_rerun` -> retried; open PR -> still skipped, `all-merged=false`. - Red/green: against the old step logic, the merged-PR cases fail. Without the `isCrossRepository` filter, the fork case fails. Dropping `isCrossRepository` from the `--json` request fails the fork case, and treating any merged target as complete fails both mixed cases. With this change all 7 pass. `vitest run scripts/cicd/`: 31 files / 385 tests pass. oxfmt, oxlint and `typecheck:scripts` are clean (pre-commit hook). yamllint is not installed locally, so I did not run it; CI will. - Live read-only check of the new query on this repo for Comfy-Org#21829: `gh pr list --state merged --head backport-21829-to-<t> --base <t>` returns `21880` for core/1.57 and nothing for cloud/1.57, core/1.58 and cloud/1.58. That matches the intended skip/attempt split. - Doc-drift sweep: 22 references checked (the workflow-related hits in `docs/release-process.md` and `.claude/skills/backport-management/`, plus the identifiers it printed), 0 updated. No doc describes the open-PR-only skip rule. Most of the sweep's 2532 hits are test-helper names (`beforeEach`, `afterEach`, `workflowSchema`) and were not judged individually. ## Residual - I did not do the manual check the ticket asks for: re-running PR Backport on Comfy-Org#21829 via `workflow_dispatch` without `force_rerun` and confirming core/1.57 is reported as already backported. A dispatch on main runs the workflow from main, so it only proves something after this merges. It can also create backport PRs and post comments on Comfy-Org#21829 for the not-yet-done targets. Do it after merge. Expected result: the `filter-targets` log/output lists `core/1.57 (merged PR Comfy-Org#21880)`. - Not changed, per the ticket's scope: the `git branch -r --contains "${MERGE_COMMIT}"` guard in the backport step never fires for squash-merged bot backports. A manual (non-bot-branch) backport that merged is still not detected and would be retried. Detecting that would need matching on PR title or cherry-pick trailers. - Related but separate: duplicate conflict comments posted on each labeled event. ## Provenance - **Authored by:** agent-work loop - **Verified:** - `pr-backport-filter.test.ts`: 7/7 pass at head; red on the old logic, and red when the cross-repo field/filter is dropped or completion means "any target merged" - oxfmt, oxlint and `typecheck:scripts`: clean (pre-commit hook) - Live read-only query for Comfy-Org#21829 returns a merged PR only for core/1.57 - Not run locally: yamllint, actionlint, an actual workflow run - **Deviations:** - Moved `REQUESTED_TARGETS` into step `env` (not requested) so the test can run the step script unmodified, and reworded one `::warning::` line - Review follow-up: added the fork exclusion and label removal when all targets are already merged. Prefix-named manual backport branches are not matched; the reason is in the review thread. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Backport of #21829 to
core/1.57Automatically created by backport workflow.