Repository navigation
[backport core/1.57] fix(agent): hold a promoted widget write during a re-subscribe instead of refusing it (PM-2003) (#21335) - #21833
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-27T09:12:01.544Z",
"gitSha": "d94c8d159e01e97709b87b10f68e5531b6f76a48",
"branch": "backport-21335-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.1350000000052,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.705,
"layouts": 10,
"layoutDurationMs": 2.341,
"taskDurationMs": 389.765,
"heapDeltaBytes": 22186388,
"heapUsedBytes": 88060872,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.467999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.4879999999762,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4229999999999996,
"layouts": 10,
"layoutDurationMs": 2.279,
"taskDurationMs": 387.917,
"heapDeltaBytes": 22169436,
"heapUsedBytes": 88094752,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.571,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.5439999999548,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.283999999999999,
"layouts": 9,
"layoutDurationMs": 2.079,
"taskDurationMs": 669.2309999999999,
"heapDeltaBytes": 15196020,
"heapUsedBytes": 81568752,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 118.97099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1961.6600000000517,
"styleRecalcs": 82,
"styleRecalcDurationMs": 13.507000000000001,
"layouts": 10,
"layoutDurationMs": 2.3560000000000003,
"taskDurationMs": 886.367,
"heapDeltaBytes": 15197132,
"heapUsedBytes": 81947824,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 123.99600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.6510000000276,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.371999999999999,
"layouts": 13,
"layoutDurationMs": 2.745,
"taskDurationMs": 301.031,
"heapDeltaBytes": -4069200,
"heapUsedBytes": 71344824,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.719,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1807.4000000000296,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.78,
"layouts": 13,
"layoutDurationMs": 2.746,
"taskDurationMs": 369.186,
"heapDeltaBytes": -222980,
"heapUsedBytes": 74528168,
"domNodes": 47,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 10.133000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 533.8319999999612,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8710000000000004,
"layouts": 9,
"layoutDurationMs": 2.2450000000000006,
"taskDurationMs": 387.185,
"heapDeltaBytes": 25183104,
"heapUsedBytes": 91427016,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 132.41699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66250000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 576.1979999999767,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.766,
"layouts": 10,
"layoutDurationMs": 2.4879999999999995,
"taskDurationMs": 391.845,
"heapDeltaBytes": 25229660,
"heapUsedBytes": 91095328,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 134.393,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1038.027999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.7400000000001,
"heapDeltaBytes": 1167120,
"heapUsedBytes": 81671076,
"domNodes": -192,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 49.799,
"eventListeners": -106,
"totalBlockingTimeMs": 362,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1071.3930000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.5749999999999,
"heapDeltaBytes": -11730824,
"heapUsedBytes": 81006424,
"domNodes": -192,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 54.398,
"eventListeners": -106,
"totalBlockingTimeMs": 389,
"frameDurationMs": 28.829729729729724,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 783.5059999999885,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.73499999999973,
"heapDeltaBytes": -4081724,
"heapUsedBytes": 76330380,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 122.68499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.8789999999799,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.04000000000013,
"heapDeltaBytes": -4509112,
"heapUsedBytes": 75920076,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 115.41499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 23.041176470588226,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6811.050999999992,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.49099999999999927,
"layouts": 2,
"layoutDurationMs": 0.41600000000000015,
"taskDurationMs": 6112.528,
"heapDeltaBytes": 4277496,
"heapUsedBytes": 98791276,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 4806.988,
"eventListeners": -68,
"totalBlockingTimeMs": 26,
"frameDurationMs": 24.60794223826715,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7116.926000000035,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9859999999999999,
"layouts": 2,
"layoutDurationMs": 0.523,
"taskDurationMs": 6392.691,
"heapDeltaBytes": -27257412,
"heapUsedBytes": 72582776,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 5040.967000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 70,
"frameDurationMs": 24.428424657534247,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7172.052000000008,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.268,
"layouts": 1,
"layoutDurationMs": 0.2859999999999998,
"taskDurationMs": 6468.677,
"heapDeltaBytes": 454528,
"heapUsedBytes": 100863708,
"domNodes": -278,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 5062.777999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 101,
"frameDurationMs": 25.233802816901406,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7664.944999999989,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7730000000000002,
"layouts": 3,
"layoutDurationMs": 0.761,
"taskDurationMs": 6885.866,
"heapDeltaBytes": 3460532,
"heapUsedBytes": 98676788,
"domNodes": -258,
"jsHeapTotalBytes": 10612736,
"scriptDurationMs": 5505.625,
"eventListeners": -68,
"totalBlockingTimeMs": 75,
"frameDurationMs": 24.260759493670886,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 173.91100000000392,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.133,
"layouts": 11,
"layoutDurationMs": 2.9280000000000004,
"taskDurationMs": 135.21899999999997,
"heapDeltaBytes": -8076260,
"heapUsedBytes": 79237516,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.042999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.377777777777787,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-combo-open",
"durationMs": 177.92600000001357,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.999000000000002,
"layouts": 11,
"layoutDurationMs": 2.736,
"taskDurationMs": 135.30599999999998,
"heapDeltaBytes": -8122344,
"heapUsedBytes": 79127576,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7.351,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.366666666666635,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2026.555999999971,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.439,
"layouts": 9,
"layoutDurationMs": 2.247,
"taskDurationMs": 488.19300000000004,
"heapDeltaBytes": -4552248,
"heapUsedBytes": 74302112,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 26.901999999999994,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.184999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.059,
"layouts": 8,
"layoutDurationMs": 2.267,
"taskDurationMs": 388.4059999999999,
"heapDeltaBytes": -1762908,
"heapUsedBytes": 77029428,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 29.288,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2261.285999999984,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.124,
"layouts": 7,
"layoutDurationMs": 1.865,
"taskDurationMs": 1367.653,
"heapDeltaBytes": 7584296,
"heapUsedBytes": 88241840,
"domNodes": -278,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 647.2990000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2202.173000000016,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.7700000000000005,
"layouts": 7,
"layoutDurationMs": 1.419,
"taskDurationMs": 1323.693,
"heapDeltaBytes": -6883472,
"heapUsedBytes": 91774528,
"domNodes": -278,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 641.506,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3304.9440000000345,
"styleRecalcs": 73,
"styleRecalcDurationMs": 7.816,
"layouts": 66,
"layoutDurationMs": 10.522,
"taskDurationMs": 1452.967,
"heapDeltaBytes": -2673604,
"heapUsedBytes": 79651712,
"domNodes": -234,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 647.548,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750761421319794,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3305.629000000067,
"styleRecalcs": 73,
"styleRecalcDurationMs": 7.714,
"layouts": 67,
"layoutDurationMs": 10.311,
"taskDurationMs": 1451.1380000000001,
"heapDeltaBytes": -2536736,
"heapUsedBytes": 79657264,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 630.668,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7502538071066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2245.9850000000188,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.189,
"layouts": 7,
"layoutDurationMs": 1.592,
"taskDurationMs": 1388.0810000000001,
"heapDeltaBytes": 3550484,
"heapUsedBytes": 86946204,
"domNodes": 0,
"jsHeapTotalBytes": 5206016,
"scriptDurationMs": 753.313,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.916541353383458,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2389.1519999999673,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.503,
"layouts": 8,
"layoutDurationMs": 1.9089999999999998,
"taskDurationMs": 1574.649,
"heapDeltaBytes": 10538656,
"heapUsedBytes": 94170484,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 786.566,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2053.145000000029,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0029999999999997,
"layouts": 8,
"layoutDurationMs": 1.8809999999999998,
"taskDurationMs": 497.765,
"heapDeltaBytes": -2263676,
"heapUsedBytes": 79742036,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 28.53,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2029.629,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8079999999999996,
"layouts": 7,
"layoutDurationMs": 1.658,
"taskDurationMs": 497.23899999999986,
"heapDeltaBytes": -25366456,
"heapUsedBytes": 73151152,
"domNodes": -258,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 27.978,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.2290000000198,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.7780000000000005,
"layouts": 11,
"layoutDurationMs": 2.628,
"taskDurationMs": 351.53900000000004,
"heapDeltaBytes": -1085712,
"heapUsedBytes": 76251912,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 124.366,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.7930000000979,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.545,
"layouts": 10,
"layoutDurationMs": 2.372,
"taskDurationMs": 356.242,
"heapDeltaBytes": 3455884,
"heapUsedBytes": 80608004,
"domNodes": 0,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 120.01400000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2010.7209999999895,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6300000000000003,
"layouts": 11,
"layoutDurationMs": 2.682,
"taskDurationMs": 398.494,
"heapDeltaBytes": 21626176,
"heapUsedBytes": 89034624,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 6.858,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.613999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.521,
"layouts": 10,
"layoutDurationMs": 2.2720000000000002,
"taskDurationMs": 406.64,
"heapDeltaBytes": -224360,
"heapUsedBytes": 77307644,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.145000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1958.7290000000053,
"styleRecalcs": 86,
"styleRecalcDurationMs": 15.376999999999999,
"layouts": 10,
"layoutDurationMs": 2.156,
"taskDurationMs": 862.7020000000001,
"heapDeltaBytes": 11349344,
"heapUsedBytes": 77803296,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 88.396,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.7419999999902,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.925999999999997,
"layouts": 9,
"layoutDurationMs": 2.2220000000000004,
"taskDurationMs": 629.86,
"heapDeltaBytes": 11680596,
"heapUsedBytes": 78662832,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 88.33200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 867.1779999999671,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.583000000000006,
"layouts": 5,
"layoutDurationMs": 12.094000000000001,
"taskDurationMs": 623.2299999999999,
"heapDeltaBytes": 7340376,
"heapUsedBytes": 104744940,
"domNodes": 15953,
"jsHeapTotalBytes": 16912384,
"scriptDurationMs": 20.596000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 109,
"frameDurationMs": 20.15581395348837,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8541.607999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.881,
"layouts": 9,
"layoutDurationMs": 3.2449999999999997,
"taskDurationMs": 4687.261,
"heapDeltaBytes": 3563120,
"heapUsedBytes": 82745128,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2168.83,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666015625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8361.286000000064,
"styleRecalcs": 252,
"styleRecalcDurationMs": 19.305,
"layouts": 9,
"layoutDurationMs": 2.104,
"taskDurationMs": 4616.184,
"heapDeltaBytes": -17528656,
"heapUsedBytes": 80619496,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 2148.838,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593625498008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20123.598000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19278.267,
"heapDeltaBytes": -185068,
"heapUsedBytes": 281814136,
"domNodes": -3330,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 270.1209999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.382249560632694,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20353.927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19369.738,
"heapDeltaBytes": -26210644,
"heapUsedBytes": 264989452,
"domNodes": -3330,
"jsHeapTotalBytes": 13623296,
"scriptDurationMs": 294.157,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.79244288224956,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17419.632999999976,
"styleRecalcs": 138,
"styleRecalcDurationMs": 11.358000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16941.902000000002,
"heapDeltaBytes": 11502984,
"heapUsedBytes": 287783896,
"domNodes": -3330,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 696.801,
"eventListeners": -651,
"totalBlockingTimeMs": 4,
"frameDurationMs": 32.042909760589325,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-pan",
"durationMs": 23681.59800000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.435000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23349.309999999998,
"heapDeltaBytes": -14280576,
"heapUsedBytes": 276722584,
"domNodes": -3330,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 727.962,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.18339552238806,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7183.97299999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.111,
"layouts": 20,
"layoutDurationMs": 27.62099999999999,
"taskDurationMs": 7039.555000000001,
"heapDeltaBytes": -11381080,
"heapUsedBytes": 284915364,
"domNodes": -3330,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 102.96500000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.95142857142857,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7182.1879999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.009,
"layouts": 20,
"layoutDurationMs": 20.410999999999998,
"taskDurationMs": 7002.244999999999,
"heapDeltaBytes": 4303064,
"heapUsedBytes": 286992308,
"domNodes": -3330,
"jsHeapTotalBytes": 22274048,
"scriptDurationMs": 102.89000000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.12793296089386,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9484.594000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9353.341,
"heapDeltaBytes": 15336240,
"heapUsedBytes": 274732768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.60499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.86785714285714,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9650.70000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9372.473999999998,
"heapDeltaBytes": 3632568,
"heapUsedBytes": 262063768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.37699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.916491228070164,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 466.54399999999896,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.596,
"layouts": 14,
"layoutDurationMs": 4.236,
"taskDurationMs": 120.30399999999999,
"heapDeltaBytes": 6983044,
"heapUsedBytes": 79523608,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.9,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 96.9119999999748,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.1930000000000005,
"layouts": 8,
"layoutDurationMs": 2.0810000000000004,
"taskDurationMs": 62.622000000000014,
"heapDeltaBytes": 4434940,
"heapUsedBytes": 76679708,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.561000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 299.43500000001677,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.875,
"layouts": 76,
"layoutDurationMs": 11.649,
"taskDurationMs": 253.48,
"heapDeltaBytes": -14528004,
"heapUsedBytes": 78447444,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 116.938,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66111111111109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 290.16300000000683,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.163,
"layouts": 76,
"layoutDurationMs": 11.708,
"taskDurationMs": 245.865,
"heapDeltaBytes": 9542392,
"heapUsedBytes": 96942080,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 115.295,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 327.43300000004183,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.782,
"layouts": 76,
"layoutDurationMs": 11.707,
"taskDurationMs": 286.78,
"heapDeltaBytes": -1519560,
"heapUsedBytes": 125378100,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.489,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999964,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 312.5720000000456,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.745,
"layouts": 76,
"layoutDurationMs": 11.790999999999999,
"taskDurationMs": 276.982,
"heapDeltaBytes": -1719892,
"heapUsedBytes": 125162884,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 100.466,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2281 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since bae165191dfeb33b6380c188948569c62b93b0cb
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.57 #21833 +/- ##
=============================================
- Coverage 84.09% 84.09% -0.01%
=============================================
Files 2985 2989 +4
Lines 159124 159336 +212
Branches 40692 38543 -2149
=============================================
+ Hits 133816 133992 +176
- Misses 24918 24954 +36
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 23 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Ready except one unrelated red check. Not merging yet.
- Required checks green at
039dd9c38f. The PM-2003 browser spec ran in CI: 2 passed. - Independent review found one blocker in the spec: 1.57's host-socket constructor takes a socket id first. Fixed in
039dd9c38f. upload-e2e-coverage / packagefails on every E2E run since today, main included (https://linear.app/comfyorg/issue/FE-3596). This program's merge gate needs all completed checks green, so the merge waits on that fix or a waiver.
Full context for agent readers
- Grant: agent backport review and merge on core/cloud 1.57 (program release-backport authority). Authored under this account, so this is a COMMENT review, not an approval.
- Second-model review: a fresh Claude reviewer (adversarial-review skill; Codex unavailable on this host). Findings: blocker, spec passed
'apply'as the socket id, so the mock host held every human op (fixed). Nit: an unresolvable-owner write is dropped with console.error only, which is 1.57's existing behaviour, kept. Minor: no unit test for a held write next to a 1.57-only pending dynamic-combo slot. The reviewer traced no shared state and no double-mint path. - Local: docOpMinter 134/134, agent crdt 1100 pass + 1 expected fail, typecheck app + browser pass; forcing immediate doc_not_synced refusal fails 15 new tests.
- Gate output:
NOT MERGE READY: completed checks are not green at 039dd9c38f: upload-e2e-coverage / package=failure. A rerun failed the same way (lcov 2.4duplicate function 'inner_clicked').
|
Holding this until comfyanonymous tags Monday's ComfyUI stable on frontend 1.57.3. Please don't approve it before then: approved backports to |
039dd9c to
42c68b9
Compare
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
|
@thedatalife sorry, I missed your hold and added Full context for agent readers
|
42c68b9 to
bc6b742
Compare
|
@thedatalife 1.57.4 went out without this. Still draft, still holding for the ComfyUI stable tag. After that it ships in 1.57.5. Rebased today so it's ready. Full context for agent readers
|
bc6b742 to
3126ccf
Compare
|
@thedatalife 1.57.5 also went out without this. Still draft. Two questions:
Full context for agent readers
|
…a re-subscribe instead of refusing it (PM-2003) (#21335) Manual backport of #21335 (0751857). The automatic cherry-pick conflicted because core/1.57 carries the dynamic-combo pending-value code and the no-argument onWidgetWriteRefused callback. Resolution: - docOpMinter.ts: keep 1.57's null route and pending widget values and add the held-write path. The refusal callback keeps 1.57's signature. reportUnresolvedOwner is dropped: 1.57 has no unresolved-owner route. - docOpMinter.test.ts: refusals stay a count on 1.57, and both fixture doc sets are destroyed in teardown. - agentFollowerHostSocket.ts: add answerSubscribesWith so the browser spec can withhold a re-subscribe answer. (cherry picked from commit 07518578e0e7c3fbeee9f6779c1c1bd3a0e51d5e)
…pec on 1.57 On 1.57 AgentFollowerHostSocket takes a socket id before humanOpsHost, so 'apply' landed in the socket id and the mock host held every human op. The seed could then never reach the shared document.
3126ccf to
c838976
Compare
|
@thedatalife the hold condition is met: ComfyUI v0.43.0 is now the latest release and pins frontend 1.57.4. Marking this ready so it can go out in the next 1.57 patch. Correction to my last comment: v0.43.0 was already tagged when I wrote that v0.42.5 was the latest tag. Full context for agent readers
|
There was a problem hiding this comment.
Verdict: Faithful backport; I am withholding approval until required E2E CI completes.
I compared this head against merged #21335, source commit 0751857, and confirmed that commit is on current main. The held-write logic and all 18 new unit cases are preserved, along with both browser cases.
The adaptations account for core/1.57's existing contracts: the minter retains its null routing result and pending-widget-value tracking instead of main's unresolved-owner reporting; the refusal callback remains argument-free, with count assertions in the tests; teardown destroys both the target's dynamic-combo documents and the source's promoted documents. The retry deadline derives from the exported lifecycle constant and remains 45 seconds. The browser fixture gains main's existing subscribe-answer hook, and the spec supplies the socket ID required by 1.57's constructor before its apply mode. I found no unexplained added or dropped behavior.
With this target's own dependencies, I ran the CRDT unit suite: 67 files passed, 1111 tests passed and one expected failure. Both PM-2003 browser cases passed against a Cloud build with retries disabled. Browser typechecking, type-aware lint on the changed files, and diff whitespace checks passed.
I verified the release-hold condition directly: ComfyUI v0.43.0 is published and its requirements pin frontend 1.57.4. At my final CI check, lint-and-format and test passed, but browser shards were still running and required e2e-status had not completed. I have not approved this head or treated those pending checks as passing.
|
@DrJKL all checks green at Full context for agent readers
|
There was a problem hiding this comment.
Verdict: Faithful backport of #21335; the required E2E check that held my previous review has passed.
I rechecked this unchanged head against merged source commit 0751857, which is on current main. The held-write logic and all source tests are preserved.
The adaptations account for core/1.57's existing contracts: null routing and pending-widget-value tracking remain instead of main's unresolved-owner reporting; the refusal callback stays argument-free, with count assertions in the tests; teardown destroys both the target's dynamic-combo documents and the source's promoted documents. The deadline derives from the exported lifecycle constant and remains 45 seconds. The browser fixture brings over main's existing subscribe-answer hook, and the spec supplies the socket ID required before apply mode in 1.57's constructor. I found no unexplained added or dropped changes.
I reran the CRDT suite with this target's own dependencies: 67 files passed, 1111 tests passed and one expected failure. Browser typechecking, type-aware lint on the changed files and diff whitespace checks passed. Both PM-2003 browser cases passed in my previous local run on this same head with retries disabled. Required CI checks lint-and-format, test and e2e-status now all pass, and coverage packaging passes too. The two cancelled advisory PR-risk checks are not test failures.
I also verified that ComfyUI v0.43.0 is published and pins frontend 1.57.4, satisfying the release-hold condition.
Backport of #21335 to
core/1.57. Manual: the automatic cherry-pick conflicted.Full context for agent readers
Resolution, per file:
docOpMinter.ts: kept 1.57'srouted === nullearly return andrememberPendingWidgetValue; added the held-write path (holdOrRefuseWidgetWrite, retry timer, deadline, detach cleanup).refuseWidgetWritecalls 1.57'sonWidgetWriteRefused()with no arguments.reportUnresolvedOwnerdropped: 1.57's router has no unresolved-owner result.PROMOTED_WRITE_CATCH_UP_DEADLINE_MStakes main'sSUBSCRIBE_ACK_MAX_TIMEOUTS * SUBSCRIBE_ACK_TIMEOUT_MS, the same 45 s as 1.57's3 * SUBSCRIBE_ACK_TIMEOUT_MS.docOpMinter.test.ts:refusalsstays a counter on 1.57, so array assertions becametoBe(0)/toBe(1). Teardown destroys both the dynamic-combo and seeded-promoted docs. The doc-not-synced row is removed from the immediate-refusal table, as on main.browser_tests/fixtures/agentFollowerHostSocket.ts: addedanswerSubscribesWith(from main) so the spec can withhold a re-subscribe answer.Local evidence on core/1.57 (cloud/1.57 files are identical):
docOpMinter.test.ts134/134; agent crdt suite 1100 pass + 1 expected fail.doc_not_syncedfails 15 of the new tests.typecheck:app,typecheck:browser, oxfmt, oxlint, eslint pass (pre-commit).Refs PM-2003.