Repository navigation
[backport cloud/1.57] fix(agent): report a free-text-only answer that won elsewhere - #21988
Conversation
## Summary Follow-up to #21320. That PR stopped a 409 with no selection from raising a false "answered somewhere else" notice, but its guard only looked at `selected`. The ask conflict schema also allows a committed free-text-only answer (`status: answered`, `selected` null or omitted, `other_text` set). In that case the 409 does name the winning answer, and the user got no superseded notice and no telemetry. ## Change - One predicate, `namesCommittedAnswer`: a body names the committed answer when it carries a `selected` array or non-empty `other_text`. - The check moved inside `reportSupersededAnswer`, so all three sources share it: the 202 receipt, the 409 conflict and the `agent_ask_resolved` frame. The frame path had no guard before, so an answered frame with a null selection also raised a false superseded report. - Removes the `//` comment #21320 added (AGENTS.md); the predicate name carries the reason. `selected: []` still counts as naming an answer, matching the existing `reports an empty committed answer that replaced this one` test and the schema ("empty when the answer was free text only"). ## Tests (written first) - `reports a 409 whose free text alone shows another answer won` (null and omitted `selected`): failed before, pass now. - `does not report an answered frame with a null selection as another answer winning`: failed before, passes now. - `reports / does not report a 202 that names only free text` and `... a free-text-only frame` (second commit, from review). Against main's source the 202 "reports" case fails; the others pin behavior that already held. - `useAgentSession.test.ts`: 261 pass. Agent suite: 4194 pass; the only failure is the known order-dependent `(g18)` test (FE-3485), which also fails on main. - typecheck, oxlint, eslint, format clean. ## Review A fresh Claude reviewer (adversarial-review, Skeptic + Minimalist; no cross-model CLI available on this host) found no blockers or majors. Its test-gap and duplicated-type notes are in the second commit. Not changed here: the superseded telemetry message (being rewritten in #21327), and an answered frame with `selected: null` still renders as an empty answer (out of contract per the schema; unchanged). ## Review threads on #21320 This addresses the Medium, the frame-path Low and the Nit. Replies on #21320 explain the other two Lows. ## Overlap #21327 edits the body of `reportSupersededAnswer` below the new guard. Whichever lands second needs a small rebase; no behavior conflict.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T10:00:49.922Z",
"gitSha": "64d0840860131474d87793aa671be6b5d0876109",
"branch": "backport-21829-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.1019999999944,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6689999999999996,
"layouts": 8,
"layoutDurationMs": 2.3560000000000003,
"taskDurationMs": 492.035,
"heapDeltaBytes": 22153268,
"heapUsedBytes": 88033044,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.898,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2007.4449999999615,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4610000000000003,
"layouts": 8,
"layoutDurationMs": 2.3510000000000004,
"taskDurationMs": 488.246,
"heapDeltaBytes": 22031748,
"heapUsedBytes": 88458896,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.897000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2008.3940000000098,
"styleRecalcs": 85,
"styleRecalcDurationMs": 15.963999999999999,
"layouts": 10,
"layoutDurationMs": 2.7979999999999996,
"taskDurationMs": 1051.1050000000002,
"heapDeltaBytes": -7803952,
"heapUsedBytes": 67131920,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 166.962,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.139000000042,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.077000000000002,
"layouts": 9,
"layoutDurationMs": 2.348,
"taskDurationMs": 845.3029999999999,
"heapDeltaBytes": -2990780,
"heapUsedBytes": 72231896,
"domNodes": 0,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 159.964,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.2709999999875,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.1450000000000005,
"layouts": 12,
"layoutDurationMs": 3.1830000000000003,
"taskDurationMs": 383.368,
"heapDeltaBytes": -4572664,
"heapUsedBytes": 70495924,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.720999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.1730000000562,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.218999999999999,
"layouts": 12,
"layoutDurationMs": 2.995,
"taskDurationMs": 383.469,
"heapDeltaBytes": -4537120,
"heapUsedBytes": 70965836,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.435,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 632.0299999999861,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.673,
"layouts": 9,
"layoutDurationMs": 2.7710000000000004,
"taskDurationMs": 483.789,
"heapDeltaBytes": 3931656,
"heapUsedBytes": 79370512,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 168.642,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736848,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 666.2620000000743,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7090000000000005,
"layouts": 9,
"layoutDurationMs": 2.548,
"taskDurationMs": 486.041,
"heapDeltaBytes": 7100712,
"heapUsedBytes": 82181352,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 169.09000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.1240000000116,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 881.99,
"heapDeltaBytes": 554208,
"heapUsedBytes": 81360904,
"domNodes": -192,
"jsHeapTotalBytes": 13377536,
"scriptDurationMs": 71.485,
"eventListeners": -106,
"totalBlockingTimeMs": 511,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1203.4889999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.0079999999999,
"heapDeltaBytes": -12013480,
"heapUsedBytes": 81138032,
"domNodes": -212,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 66.754,
"eventListeners": -106,
"totalBlockingTimeMs": 511,
"frameDurationMs": 32.42972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.7409999999759,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.34599999999983,
"heapDeltaBytes": -5240216,
"heapUsedBytes": 75908424,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 162.50500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 24.759999999999984,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.8589999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.48999999999995,
"heapDeltaBytes": -5633120,
"heapUsedBytes": 75065832,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 155.90099999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9976.334000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9143.815,
"heapDeltaBytes": -25080960,
"heapUsedBytes": 74904432,
"domNodes": -278,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 7689.613,
"eventListeners": -68,
"totalBlockingTimeMs": 1288,
"frameDurationMs": 33.166112956810636,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8884.57299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8119.325,
"heapDeltaBytes": -23393120,
"heapUsedBytes": 75526868,
"domNodes": -278,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 6822.027,
"eventListeners": -68,
"totalBlockingTimeMs": 680,
"frameDurationMs": 32.420072992700725,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9413.882000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8661.396,
"heapDeltaBytes": -12571892,
"heapUsedBytes": 75034188,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 7019.56,
"eventListeners": -68,
"totalBlockingTimeMs": 559,
"frameDurationMs": 31.70471380471381,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10550.567000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9769.836000000001,
"heapDeltaBytes": -22243116,
"heapUsedBytes": 72447760,
"domNodes": -258,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 8063.207,
"eventListeners": -68,
"totalBlockingTimeMs": 1066,
"frameDurationMs": 31.871903323262842,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 233.90399999999545,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.590999999999998,
"layouts": 12,
"layoutDurationMs": 3.5929999999999995,
"taskDurationMs": 168.973,
"heapDeltaBytes": -8102116,
"heapUsedBytes": 79311872,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.312999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 239.83899999996083,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.412999999999997,
"layouts": 11,
"layoutDurationMs": 3.4659999999999997,
"taskDurationMs": 178.501,
"heapDeltaBytes": -8199508,
"heapUsedBytes": 79537716,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.819,
"eventListeners": 196,
"totalBlockingTimeMs": 5,
"frameDurationMs": 23.329999999999927,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2023.7170000000333,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9009999999999998,
"layouts": 7,
"layoutDurationMs": 2.1580000000000004,
"taskDurationMs": 447.1839999999999,
"heapDeltaBytes": -7437848,
"heapUsedBytes": 72201472,
"domNodes": -278,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.41499999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.5470000000605,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.411999999999999,
"layouts": 8,
"layoutDurationMs": 2.5179999999999993,
"taskDurationMs": 620.903,
"heapDeltaBytes": -20036808,
"heapUsedBytes": 76631512,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 33.27400000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2308.770000000038,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.579,
"layouts": 6,
"layoutDurationMs": 1.452,
"taskDurationMs": 1474.421,
"heapDeltaBytes": -12401960,
"heapUsedBytes": 68537140,
"domNodes": -278,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 817.6909999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.9110294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2397.4829999999656,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.720000000000001,
"layouts": 6,
"layoutDurationMs": 1.6189999999999998,
"taskDurationMs": 1674.2859999999998,
"heapDeltaBytes": -551896,
"heapUsedBytes": 79345708,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 819.4350000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78251748251748,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3552.4789999999484,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.446,
"layouts": 64,
"layoutDurationMs": 10.704,
"taskDurationMs": 1721.8110000000001,
"heapDeltaBytes": -13871204,
"heapUsedBytes": 67608604,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 758.9820000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665727699530517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3736.248000000046,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.4670000000000005,
"layouts": 64,
"layoutDurationMs": 10.911999999999999,
"taskDurationMs": 1748.634,
"heapDeltaBytes": 1950116,
"heapUsedBytes": 101818608,
"domNodes": 24,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 799.412,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74080717488789,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3092.141999999967,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.827999999999999,
"layouts": 4,
"layoutDurationMs": 1.1340000000000001,
"taskDurationMs": 1993.966,
"heapDeltaBytes": 5371664,
"heapUsedBytes": 84165376,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 990.453,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.847282608695654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2653.1820000000153,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.626999999999999,
"layouts": 5,
"layoutDurationMs": 1.4129999999999998,
"taskDurationMs": 1675.732,
"heapDeltaBytes": 10919872,
"heapUsedBytes": 94393080,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 915.893,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77151898734177,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2055.3539999999657,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5330000000000006,
"layouts": 6,
"layoutDurationMs": 1.8330000000000004,
"taskDurationMs": 612.3750000000001,
"heapDeltaBytes": -2498080,
"heapUsedBytes": 75778228,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 30.058999999999987,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.0089999999836,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9760000000000004,
"layouts": 7,
"layoutDurationMs": 1.9839999999999995,
"taskDurationMs": 622.348,
"heapDeltaBytes": -25276328,
"heapUsedBytes": 73635144,
"domNodes": -278,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 32.108,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.8709999999733,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.843999999999999,
"layouts": 10,
"layoutDurationMs": 2.647,
"taskDurationMs": 415.234,
"heapDeltaBytes": 21581900,
"heapUsedBytes": 89020676,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 144.57999999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.0259999999807,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.874,
"layouts": 9,
"layoutDurationMs": 2.6399999999999997,
"taskDurationMs": 432.088,
"heapDeltaBytes": -2444888,
"heapUsedBytes": 74355632,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 146.447,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2049.5319999999992,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7319999999999993,
"layouts": 10,
"layoutDurationMs": 2.7929999999999993,
"taskDurationMs": 524.3879999999999,
"heapDeltaBytes": 3595884,
"heapUsedBytes": 80371688,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 8.469999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.9839999999513,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.561,
"layouts": 9,
"layoutDurationMs": 2.581,
"taskDurationMs": 488.13900000000007,
"heapDeltaBytes": -153044,
"heapUsedBytes": 76501860,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.921999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.0910000000008,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.167,
"layouts": 9,
"layoutDurationMs": 2.043,
"taskDurationMs": 869.85,
"heapDeltaBytes": 11567672,
"heapUsedBytes": 79423376,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 110.08,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666949152542376,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1940.9010000000535,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.235,
"layouts": 8,
"layoutDurationMs": 2.3629999999999995,
"taskDurationMs": 867.1139999999999,
"heapDeltaBytes": 11687040,
"heapUsedBytes": 79615392,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 111.107,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581197,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.134000000001,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.089000000000002,
"layouts": 5,
"layoutDurationMs": 16.494,
"taskDurationMs": 1029.61,
"heapDeltaBytes": 5092440,
"heapUsedBytes": 98073052,
"domNodes": 15953,
"jsHeapTotalBytes": 18227200,
"scriptDurationMs": 28.658999999999995,
"eventListeners": 3244,
"totalBlockingTimeMs": 167,
"frameDurationMs": 19.555999999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8305.009999999982,
"styleRecalcs": 249,
"styleRecalcDurationMs": 17.028000000000002,
"layouts": 7,
"layoutDurationMs": 1.551,
"taskDurationMs": 5112.316,
"heapDeltaBytes": -7827788,
"heapUsedBytes": 71876300,
"domNodes": -278,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 2723.699,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733535353535352,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8304.807999999979,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.749000000000002,
"layouts": 8,
"layoutDurationMs": 2.394,
"taskDurationMs": 5109.5,
"heapDeltaBytes": -8215380,
"heapUsedBytes": 71825292,
"domNodes": -278,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 2714.4900000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73326612903226,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23002.381000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22159.176000000003,
"heapDeltaBytes": 7766980,
"heapUsedBytes": 289354444,
"domNodes": -3330,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 329.871,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.58537005163511,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 23188.84300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22474.226000000002,
"heapDeltaBytes": -20875868,
"heapUsedBytes": 255304076,
"domNodes": -3330,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 320.02200000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.030796460176994,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 27629.06899999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.635999999999981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27178.514999999996,
"heapDeltaBytes": 9874076,
"heapUsedBytes": 285986888,
"domNodes": -3330,
"jsHeapTotalBytes": 9355264,
"scriptDurationMs": 859.7009999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 32,
"frameDurationMs": 50.39324817518248,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 27762.42000000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.249999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27352.132999999998,
"heapDeltaBytes": -8726996,
"heapUsedBytes": 286938400,
"domNodes": -3330,
"jsHeapTotalBytes": 9617408,
"scriptDurationMs": 930.043,
"eventListeners": -651,
"totalBlockingTimeMs": 15,
"frameDurationMs": 51.13351749539595,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8240.068000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.15999999999998,
"layouts": 20,
"layoutDurationMs": 27.216000000000005,
"taskDurationMs": 8078.837,
"heapDeltaBytes": -22725620,
"heapUsedBytes": 259883056,
"domNodes": -3330,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 140.856,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.146198830409354,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 5788.898000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.412,
"layouts": 20,
"layoutDurationMs": 20.95000000000001,
"taskDurationMs": 5641.402,
"heapDeltaBytes": -42746532,
"heapUsedBytes": 256809012,
"domNodes": -3330,
"jsHeapTotalBytes": 25419776,
"scriptDurationMs": 113.742,
"eventListeners": -653,
"totalBlockingTimeMs": 17,
"frameDurationMs": 33.819298245614036,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11382.114000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10936.029,
"heapDeltaBytes": -8523680,
"heapUsedBytes": 269396012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.25099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.84948805460751,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8197.26199999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7627.737999999999,
"heapDeltaBytes": 183664,
"heapUsedBytes": 277735088,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.75599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.570383275261328,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 122.34000000000833,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.004,
"layouts": 8,
"layoutDurationMs": 3.4040000000000004,
"taskDurationMs": 96.532,
"heapDeltaBytes": 4747016,
"heapUsedBytes": 77795788,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.879,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 491.95499999996173,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.921000000000001,
"layouts": 11,
"layoutDurationMs": 4.521000000000001,
"taskDurationMs": 137.441,
"heapDeltaBytes": 6618996,
"heapUsedBytes": 79523848,
"domNodes": 95,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.274,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 496.5590000000475,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.278,
"layouts": 76,
"layoutDurationMs": 15.376000000000001,
"taskDurationMs": 449.14300000000003,
"heapDeltaBytes": 11868076,
"heapUsedBytes": 103405644,
"domNodes": 4,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 223.973,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 491.56600000003436,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.213,
"layouts": 76,
"layoutDurationMs": 14.561,
"taskDurationMs": 441.56,
"heapDeltaBytes": 11667732,
"heapUsedBytes": 103420892,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 215.914,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 553.7720000000945,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8519999999999999,
"layouts": 76,
"layoutDurationMs": 14.863,
"taskDurationMs": 513.227,
"heapDeltaBytes": 274952,
"heapUsedBytes": 131642448,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 214.842,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696982,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 526.1470000000372,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.818,
"layouts": 76,
"layoutDurationMs": 14.962,
"taskDurationMs": 487.74399999999997,
"heapDeltaBytes": -4947036,
"heapUsedBytes": 103771940,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 200.23499999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.18437499999999,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2286 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2452f43e677717fbbda66faeeacf1ceb374a0a64
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21988 +/- ##
=============================================
Coverage ? 84.14%
=============================================
Files ? 3006
Lines ? 160186
Branches ? 40803
=============================================
Hits ? 134789
Misses ? 25007
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21829 to
cloud/1.57Automatically created by backport workflow.