Repository navigation
[backport cloud/1.58] fix(agent): report a free-text-only answer that won elsewhere - #21990
Conversation
## Summary Follow-up to #21320. That PR stopped a 409 with no selection from raising a false "answered somewhere else" notice, but its guard only looked at `selected`. The ask conflict schema also allows a committed free-text-only answer (`status: answered`, `selected` null or omitted, `other_text` set). In that case the 409 does name the winning answer, and the user got no superseded notice and no telemetry. ## Change - One predicate, `namesCommittedAnswer`: a body names the committed answer when it carries a `selected` array or non-empty `other_text`. - The check moved inside `reportSupersededAnswer`, so all three sources share it: the 202 receipt, the 409 conflict and the `agent_ask_resolved` frame. The frame path had no guard before, so an answered frame with a null selection also raised a false superseded report. - Removes the `//` comment #21320 added (AGENTS.md); the predicate name carries the reason. `selected: []` still counts as naming an answer, matching the existing `reports an empty committed answer that replaced this one` test and the schema ("empty when the answer was free text only"). ## Tests (written first) - `reports a 409 whose free text alone shows another answer won` (null and omitted `selected`): failed before, pass now. - `does not report an answered frame with a null selection as another answer winning`: failed before, passes now. - `reports / does not report a 202 that names only free text` and `... a free-text-only frame` (second commit, from review). Against main's source the 202 "reports" case fails; the others pin behavior that already held. - `useAgentSession.test.ts`: 261 pass. Agent suite: 4194 pass; the only failure is the known order-dependent `(g18)` test (FE-3485), which also fails on main. - typecheck, oxlint, eslint, format clean. ## Review A fresh Claude reviewer (adversarial-review, Skeptic + Minimalist; no cross-model CLI available on this host) found no blockers or majors. Its test-gap and duplicated-type notes are in the second commit. Not changed here: the superseded telemetry message (being rewritten in #21327), and an answered frame with `selected: null` still renders as an empty answer (out of contract per the schema; unchanged). ## Review threads on #21320 This addresses the Medium, the frame-path Low and the Nit. Replies on #21320 explain the other two Lows. ## Overlap #21327 edits the body of `reportSupersededAnswer` below the new guard. Whichever lands second needs a small rebase; no behavior conflict.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T10:00:46.875Z",
"gitSha": "2ead6d4e949da33b11b0ccf0920a5a66cae3cbf1",
"branch": "backport-21829-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2041.1269999999604,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2580000000000005,
"layouts": 8,
"layoutDurationMs": 2.5649999999999995,
"taskDurationMs": 605.7119999999999,
"heapDeltaBytes": -3048340,
"heapUsedBytes": 87250268,
"domNodes": -201,
"jsHeapTotalBytes": 57344,
"scriptDurationMs": 11.302,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2051.2579999999616,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9700000000000006,
"layouts": 8,
"layoutDurationMs": 2.561,
"taskDurationMs": 646.92,
"heapDeltaBytes": 2353708,
"heapUsedBytes": 92595492,
"domNodes": -200,
"jsHeapTotalBytes": 1105920,
"scriptDurationMs": 12.777000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.8489999999606,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.22,
"layouts": 9,
"layoutDurationMs": 2.5220000000000002,
"taskDurationMs": 795.474,
"heapDeltaBytes": 4334236,
"heapUsedBytes": 94519892,
"domNodes": -201,
"jsHeapTotalBytes": 57344,
"scriptDurationMs": 162.781,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.0410000000047,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.597000000000001,
"layouts": 9,
"layoutDurationMs": 2.6039999999999996,
"taskDurationMs": 948.902,
"heapDeltaBytes": -370580,
"heapUsedBytes": 107158648,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 176.446,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.5500000000125,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.064000000000001,
"layouts": 10,
"layoutDurationMs": 2.964,
"taskDurationMs": 433.828,
"heapDeltaBytes": 25439228,
"heapUsedBytes": 115675600,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.026,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.9770000000435,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.103000000000001,
"layouts": 11,
"layoutDurationMs": 3.1850000000000005,
"taskDurationMs": 437.682,
"heapDeltaBytes": -1021480,
"heapUsedBytes": 98170864,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.212000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 742.0270000000073,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.404,
"layouts": 10,
"layoutDurationMs": 3.0260000000000002,
"taskDurationMs": 518.952,
"heapDeltaBytes": 3607072,
"heapUsedBytes": 103090020,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 174.10999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 754.9099999999953,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.5170000000000003,
"layouts": 7,
"layoutDurationMs": 1.818,
"taskDurationMs": 527.9549999999999,
"heapDeltaBytes": 4055848,
"heapUsedBytes": 103868072,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 174.28099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.045454545454547,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1219.1230000000246,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 924.96,
"heapDeltaBytes": -2822012,
"heapUsedBytes": 102432784,
"domNodes": -210,
"jsHeapTotalBytes": 10121216,
"scriptDurationMs": 69.51599999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 520,
"frameDurationMs": 32.018421052631574,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1233.6119999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 891.5210000000001,
"heapDeltaBytes": -14648140,
"heapUsedBytes": 102868392,
"domNodes": -230,
"jsHeapTotalBytes": 15007744,
"scriptDurationMs": 74.16,
"eventListeners": -168,
"totalBlockingTimeMs": 535,
"frameDurationMs": 32.45789473684209,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 866.0380000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.0780000000003,
"heapDeltaBytes": -2302196,
"heapUsedBytes": 98854156,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.807,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.7729999999656,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.185,
"heapDeltaBytes": -3742652,
"heapUsedBytes": 96671320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.75100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10292.48800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9411.659,
"heapDeltaBytes": 53024984,
"heapUsedBytes": 157324424,
"domNodes": -296,
"jsHeapTotalBytes": 29679616,
"scriptDurationMs": 7732.549,
"eventListeners": -130,
"totalBlockingTimeMs": 1103,
"frameDurationMs": 32.540822784810125,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10666.380000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9820.034,
"heapDeltaBytes": -17512576,
"heapUsedBytes": 102582512,
"domNodes": -296,
"jsHeapTotalBytes": -372736,
"scriptDurationMs": 8294.751,
"eventListeners": -130,
"totalBlockingTimeMs": 1385,
"frameDurationMs": 31.744940476190475,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11623.368000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10864.039,
"heapDeltaBytes": 56927792,
"heapUsedBytes": 161322832,
"domNodes": -296,
"jsHeapTotalBytes": 53010432,
"scriptDurationMs": 8806.507,
"eventListeners": -130,
"totalBlockingTimeMs": 1691,
"frameDurationMs": 31.91291208791209,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11067.231000000105,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10275.224,
"heapDeltaBytes": -1676176,
"heapUsedBytes": 120459772,
"domNodes": -273,
"jsHeapTotalBytes": -1159168,
"scriptDurationMs": 8361.48,
"eventListeners": -130,
"totalBlockingTimeMs": 1238,
"frameDurationMs": 31.617714285714282,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 290.8050000000344,
"styleRecalcs": 28,
"styleRecalcDurationMs": 14.697,
"layouts": 12,
"layoutDurationMs": 3.519,
"taskDurationMs": 235.88500000000002,
"heapDeltaBytes": 13423604,
"heapUsedBytes": 119246740,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 8.835999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 21.421428571428546,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "large-combo-open",
"durationMs": 216.20899999993526,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.558,
"layouts": 11,
"layoutDurationMs": 3.233,
"taskDurationMs": 162.879,
"heapDeltaBytes": 13206832,
"heapUsedBytes": 119979748,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.858999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.67999999999993,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2073.319999999967,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.691,
"layouts": 8,
"layoutDurationMs": 2.521,
"taskDurationMs": 738.276,
"heapDeltaBytes": -9001884,
"heapUsedBytes": 112923592,
"domNodes": -296,
"jsHeapTotalBytes": 3334144,
"scriptDurationMs": 35.01,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.712999999969,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.241999999999999,
"layouts": 9,
"layoutDurationMs": 2.9189999999999996,
"taskDurationMs": 540.9249999999998,
"heapDeltaBytes": -300264,
"heapUsedBytes": 109696820,
"domNodes": -296,
"jsHeapTotalBytes": -2039808,
"scriptDurationMs": 38.231,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2636.3699999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.285,
"layouts": 7,
"layoutDurationMs": 2.0290000000000004,
"taskDurationMs": 1754.3339999999996,
"heapDeltaBytes": -2217428,
"heapUsedBytes": 108274856,
"domNodes": -276,
"jsHeapTotalBytes": 282624,
"scriptDurationMs": 833.1670000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666242038216563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2330.7609999999386,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.759,
"layouts": 7,
"layoutDurationMs": 2.176,
"taskDurationMs": 1669.7510000000002,
"heapDeltaBytes": 1121408,
"heapUsedBytes": 112916292,
"domNodes": -296,
"jsHeapTotalBytes": 282624,
"scriptDurationMs": 868.975,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7863309352518,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3927.188000000001,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.679,
"layouts": 65,
"layoutDurationMs": 11.364,
"taskDurationMs": 1831.4060000000002,
"heapDeltaBytes": 6720468,
"heapUsedBytes": 119804160,
"domNodes": 24,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 800.9430000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.737021276595748,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3627.6550000000043,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.839999999999998,
"layouts": 66,
"layoutDurationMs": 11.013,
"taskDurationMs": 1679.0660000000003,
"heapDeltaBytes": -22368428,
"heapUsedBytes": 90979796,
"domNodes": -272,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 797.35,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.743055555555557,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3022.728000000029,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.318,
"layouts": 4,
"layoutDurationMs": 1.196,
"taskDurationMs": 1874.9100000000003,
"heapDeltaBytes": -10169412,
"heapUsedBytes": 104748912,
"domNodes": 0,
"jsHeapTotalBytes": 6295552,
"scriptDurationMs": 1009.717,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.037222222222223,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3198.264999999992,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.889,
"layouts": 5,
"layoutDurationMs": 1.344,
"taskDurationMs": 2119.898,
"heapDeltaBytes": -15907988,
"heapUsedBytes": 99155660,
"domNodes": 0,
"jsHeapTotalBytes": 1724416,
"scriptDurationMs": 1046.433,
"eventListeners": 182,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.019047619047615,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.3890000000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.595999999999999,
"layouts": 7,
"layoutDurationMs": 2.4239999999999995,
"taskDurationMs": 714.746,
"heapDeltaBytes": -5907212,
"heapUsedBytes": 112967972,
"domNodes": -297,
"jsHeapTotalBytes": -1740800,
"scriptDurationMs": 37.065000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.5850000000546,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.9909999999999997,
"layouts": 6,
"layoutDurationMs": 1.763,
"taskDurationMs": 633.923,
"heapDeltaBytes": 33131524,
"heapUsedBytes": 139792624,
"domNodes": -297,
"jsHeapTotalBytes": 23220224,
"scriptDurationMs": 35.76200000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.7440000000151,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.9079999999999995,
"layouts": 9,
"layoutDurationMs": 2.64,
"taskDurationMs": 421.46099999999996,
"heapDeltaBytes": -596580,
"heapUsedBytes": 90669248,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 155.836,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 657.8479999999445,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.723,
"layouts": 9,
"layoutDurationMs": 3.0419999999999994,
"taskDurationMs": 470.238,
"heapDeltaBytes": -556820,
"heapUsedBytes": 90296808,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 152.51600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.3599999999642,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8320000000000003,
"layouts": 11,
"layoutDurationMs": 3.7369999999999997,
"taskDurationMs": 629.294,
"heapDeltaBytes": -19399656,
"heapUsedBytes": 81642080,
"domNodes": -218,
"jsHeapTotalBytes": 1724416,
"scriptDurationMs": 10.162999999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2057.5759999999264,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.309,
"layouts": 9,
"layoutDurationMs": 2.9659999999999997,
"taskDurationMs": 632.6160000000001,
"heapDeltaBytes": 3270480,
"heapUsedBytes": 94555644,
"domNodes": -218,
"jsHeapTotalBytes": 1892352,
"scriptDurationMs": 12.066,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.0409999999679,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.438999999999998,
"layouts": 9,
"layoutDurationMs": 2.6630000000000003,
"taskDurationMs": 928.284,
"heapDeltaBytes": -14502116,
"heapUsedBytes": 86353748,
"domNodes": -191,
"jsHeapTotalBytes": 7933952,
"scriptDurationMs": 120.535,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1993.7939999999799,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.701,
"layouts": 9,
"layoutDurationMs": 2.553,
"taskDurationMs": 1025.862,
"heapDeltaBytes": -77020,
"heapUsedBytes": 90932492,
"domNodes": -210,
"jsHeapTotalBytes": 2416640,
"scriptDurationMs": 121.96700000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.3170000001019,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.171999999999993,
"layouts": 5,
"layoutDurationMs": 17.193000000000005,
"taskDurationMs": 945.246,
"heapDeltaBytes": 6870620,
"heapUsedBytes": 117048260,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 33.61899999999999,
"eventListeners": 3244,
"totalBlockingTimeMs": 180,
"frameDurationMs": 19.863013698630137,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10111.65699999998,
"styleRecalcs": 248,
"styleRecalcDurationMs": 30.171,
"layouts": 6,
"layoutDurationMs": 1.719,
"taskDurationMs": 6249.183999999999,
"heapDeltaBytes": 8658696,
"heapUsedBytes": 112474088,
"domNodes": -296,
"jsHeapTotalBytes": -2002944,
"scriptDurationMs": 2784.087,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.693399339933993,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10584.013000000028,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.775999999999996,
"layouts": 9,
"layoutDurationMs": 2.3479999999999994,
"taskDurationMs": 6314.354,
"heapDeltaBytes": 2981268,
"heapUsedBytes": 113615884,
"domNodes": -297,
"jsHeapTotalBytes": -274432,
"scriptDurationMs": 2764.038,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665826771653542,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22828.816000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22265.115,
"heapDeltaBytes": -27681032,
"heapUsedBytes": 296353144,
"domNodes": -307,
"jsHeapTotalBytes": 5754880,
"scriptDurationMs": 334.201,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.05684210526316,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22956.961999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22399.289,
"heapDeltaBytes": -53216436,
"heapUsedBytes": 270979356,
"domNodes": -3344,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 338.745,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.56741379310345,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19297.526000000005,
"styleRecalcs": 156,
"styleRecalcDurationMs": 14.239,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18857.755999999998,
"heapDeltaBytes": -6102212,
"heapUsedBytes": 304125568,
"domNodes": -3344,
"jsHeapTotalBytes": 19910656,
"scriptDurationMs": 794.169,
"eventListeners": -651,
"totalBlockingTimeMs": 19,
"frameDurationMs": 35.251371115173676,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19691.283,
"styleRecalcs": 159,
"styleRecalcDurationMs": 16.69799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19235.231,
"heapDeltaBytes": -18593992,
"heapUsedBytes": 300811032,
"domNodes": -3344,
"jsHeapTotalBytes": 22007808,
"scriptDurationMs": 820.359,
"eventListeners": -651,
"totalBlockingTimeMs": 20,
"frameDurationMs": 35.97773722627737,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8137.75800000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.193,
"layouts": 20,
"layoutDurationMs": 22.723999999999993,
"taskDurationMs": 8022.5109999999995,
"heapDeltaBytes": -8538708,
"heapUsedBytes": 297206472,
"domNodes": -3344,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 120.38400000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.10751445086704,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6109.305999999947,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.29500000000003,
"layouts": 20,
"layoutDurationMs": 24.003999999999998,
"taskDurationMs": 5972.924000000001,
"heapDeltaBytes": -16067528,
"heapUsedBytes": 289139524,
"domNodes": -3344,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 125.809,
"eventListeners": -653,
"totalBlockingTimeMs": 20,
"frameDurationMs": 34.95142857142857,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11499.682000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11249.363,
"heapDeltaBytes": 178032,
"heapUsedBytes": 287968888,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.105,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.38219178082193,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8242.604000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7736.587,
"heapDeltaBytes": 18813908,
"heapUsedBytes": 290218644,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.00900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.87060810810811,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 134.93099999993774,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.154,
"layouts": 9,
"layoutDurationMs": 4.255,
"taskDurationMs": 102.226,
"heapDeltaBytes": 4799940,
"heapUsedBytes": 94391524,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.422999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 491.9089999999642,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.911999999999999,
"layouts": 12,
"layoutDurationMs": 5.187,
"taskDurationMs": 139.094,
"heapDeltaBytes": -13178656,
"heapUsedBytes": 92164644,
"domNodes": 95,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.313,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 514.0790000000379,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.749,
"layouts": 76,
"layoutDurationMs": 15.575000000000001,
"taskDurationMs": 461.71399999999994,
"heapDeltaBytes": -14331932,
"heapUsedBytes": 81117388,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 215.499,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 576.9460000000208,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.709,
"layouts": 76,
"layoutDurationMs": 16.932,
"taskDurationMs": 527.1870000000001,
"heapDeltaBytes": 12890356,
"heapUsedBytes": 83350052,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 258.57099999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 642.6549999999907,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.038,
"layouts": 76,
"layoutDurationMs": 16.194,
"taskDurationMs": 590.424,
"heapDeltaBytes": 1429572,
"heapUsedBytes": 118792788,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 239.706,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 615.8609999999953,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.005,
"layouts": 76,
"layoutDurationMs": 16.080000000000002,
"taskDurationMs": 579.444,
"heapDeltaBytes": 1079004,
"heapUsedBytes": 119915908,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 236.14200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11621621621622,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2981 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 61104dc481ddfdd11291905635bd09531460eeb1
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (124)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #21990 +/- ##
=============================================
Coverage ? 84.54%
=============================================
Files ? 3091
Lines ? 162748
Branches ? 38876
=============================================
Hits ? 137589
Misses ? 24768
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21829 to
cloud/1.58Automatically created by backport workflow.