Repository navigation
[chore] Update Ingest API types from cloud@89174e97 - #21701
Conversation
📦 Bundle: 12 MB gzip 🔴 +1.28 kBDetailsSummary
Category Glance App Entry Points — 6.68 kB (baseline 6.68 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.57 MB (baseline 2.57 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 5 unchanged Panels & Settings — 873 kB (baseline 873 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 156 kB (baseline 156 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 8 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 345 kB (baseline 345 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed / 21 unchanged Data & Services — 1.9 MB (baseline 1.9 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 34 added / 34 removed / 8 unchanged Utilities & Hooks — 2.43 MB (baseline 2.43 MB) • 🔴 +1.15 kBHelpers, composables, and utility bundles
Status: 44 added / 44 removed / 40 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • 🔴 +6.14 kBBundles that do not match a named category
Status: 108 added / 108 removed / 639 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T05:24:21.492Z",
"gitSha": "c9a1bcf8507b62d6ea8b45fc935a195b4cfa3290",
"branch": "update-ingest-types",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.109,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.563,
"layouts": 10,
"layoutDurationMs": 2.264,
"taskDurationMs": 328.58299999999997,
"heapDeltaBytes": 1643420,
"heapUsedBytes": 63714056,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.061,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2008.5689999999659,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8520000000000003,
"layouts": 9,
"layoutDurationMs": 2.68,
"taskDurationMs": 353.42600000000004,
"heapDeltaBytes": 24412480,
"heapUsedBytes": 85184788,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.937000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.3659999999732,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.512,
"layouts": 9,
"layoutDurationMs": 2.184,
"taskDurationMs": 557.9920000000001,
"heapDeltaBytes": 21720280,
"heapUsedBytes": 82653956,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 104.02399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.5819999999158,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.872000000000002,
"layouts": 10,
"layoutDurationMs": 2.5849999999999995,
"taskDurationMs": 559.825,
"heapDeltaBytes": 17643460,
"heapUsedBytes": 79615212,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 106.79299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.473999999967,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.692,
"layouts": 11,
"layoutDurationMs": 2.7039999999999997,
"taskDurationMs": 285.642,
"heapDeltaBytes": 23935224,
"heapUsedBytes": 85709740,
"domNodes": 57,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.056000000000003,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.6380000000408,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.268999999999999,
"layouts": 12,
"layoutDurationMs": 3.0889999999999995,
"taskDurationMs": 313.384,
"heapDeltaBytes": 19650840,
"heapUsedBytes": 81241180,
"domNodes": 57,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 14.395000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 533.5289999999873,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1629999999999994,
"layouts": 10,
"layoutDurationMs": 2.6699999999999995,
"taskDurationMs": 355.71999999999997,
"heapDeltaBytes": 5017832,
"heapUsedBytes": 66867108,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 118.908,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 449.1040000000339,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.326,
"layouts": 11,
"layoutDurationMs": 2.722,
"taskDurationMs": 311.12600000000003,
"heapDeltaBytes": 482944,
"heapUsedBytes": 61157044,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 106.43900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962958,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 892.942000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.6540000000001,
"heapDeltaBytes": -12407700,
"heapUsedBytes": 74644448,
"domNodes": -203,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 35.29600000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 265,
"frameDurationMs": 25.714285714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 985.311999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.8410000000001,
"heapDeltaBytes": -11343692,
"heapUsedBytes": 75638012,
"domNodes": -203,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 44.574999999999996,
"eventListeners": -106,
"totalBlockingTimeMs": 311,
"frameDurationMs": 26.578378378378382,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 753.2740000000331,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.9420000000002,
"heapDeltaBytes": -22986932,
"heapUsedBytes": 67111572,
"domNodes": -203,
"jsHeapTotalBytes": 2490368,
"scriptDurationMs": 105.06299999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 94,
"frameDurationMs": 20.267567567567557,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 719.9500000000398,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.00099999999986,
"heapDeltaBytes": -23817280,
"heapUsedBytes": 66117644,
"domNodes": -203,
"jsHeapTotalBytes": 3014656,
"scriptDurationMs": 95.257,
"eventListeners": -106,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.4742857142857,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6618.2999999999765,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7090000000000004,
"layouts": 2,
"layoutDurationMs": 0.5760000000000001,
"taskDurationMs": 5520.899,
"heapDeltaBytes": 48186624,
"heapUsedBytes": 127230280,
"domNodes": -269,
"jsHeapTotalBytes": 61468672,
"scriptDurationMs": 4121.251,
"eventListeners": -68,
"totalBlockingTimeMs": 21,
"frameDurationMs": 20.18256880733945,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6463.598999999931,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9070000000000007,
"layouts": 3,
"layoutDurationMs": 0.7999999999999999,
"taskDurationMs": 5471.3460000000005,
"heapDeltaBytes": 59644660,
"heapUsedBytes": 142193864,
"domNodes": -269,
"jsHeapTotalBytes": 65138688,
"scriptDurationMs": 4151.243,
"eventListeners": -68,
"totalBlockingTimeMs": 10,
"frameDurationMs": 19.603951367781157,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6127.289000000019,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8679999999999999,
"layouts": 3,
"layoutDurationMs": 0.801,
"taskDurationMs": 5044.3949999999995,
"heapDeltaBytes": 40484772,
"heapUsedBytes": 122641272,
"domNodes": -269,
"jsHeapTotalBytes": 58060800,
"scriptDurationMs": 3983.8239999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 15,
"frameDurationMs": 19.47015873015873,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6153.3430000000635,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8809999999999998,
"layouts": 3,
"layoutDurationMs": 0.7279999999999999,
"taskDurationMs": 5025.245,
"heapDeltaBytes": 2585616,
"heapUsedBytes": 91673240,
"domNodes": -269,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 3829.7250000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 17,
"frameDurationMs": 19.827652733118974,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 147.96799999999166,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.041999999999998,
"layouts": 12,
"layoutDurationMs": 3.002,
"taskDurationMs": 109.11400000000002,
"heapDeltaBytes": -5598028,
"heapUsedBytes": 72600476,
"domNodes": 936,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.028,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.41428571428573,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 176.72400000003563,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.529,
"layouts": 11,
"layoutDurationMs": 3.042,
"taskDurationMs": 130.30700000000002,
"heapDeltaBytes": -6103420,
"heapUsedBytes": 72636716,
"domNodes": 936,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6.5520000000000005,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.377777777777787,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2008.8810000000308,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3370000000000006,
"layouts": 10,
"layoutDurationMs": 2.235,
"taskDurationMs": 310.313,
"heapDeltaBytes": -24740348,
"heapUsedBytes": 64448524,
"domNodes": -269,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 28.228999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2026.630999999952,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.733,
"layouts": 10,
"layoutDurationMs": 2.398,
"taskDurationMs": 421.65000000000003,
"heapDeltaBytes": -28648364,
"heapUsedBytes": 63049260,
"domNodes": -269,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 28.566999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2460.5040000000145,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.348999999999998,
"layouts": 7,
"layoutDurationMs": 1.829,
"taskDurationMs": 1224.378,
"heapDeltaBytes": -164728,
"heapUsedBytes": 86613768,
"domNodes": -269,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 586.7070000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598639455782,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2783.0020000000104,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.865,
"layouts": 8,
"layoutDurationMs": 2.145,
"taskDurationMs": 1254.386,
"heapDeltaBytes": -421476,
"heapUsedBytes": 86652948,
"domNodes": -269,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 585.248,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666467065868265,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3553.6160000000336,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.488000000000001,
"layouts": 66,
"layoutDurationMs": 11.866000000000001,
"taskDurationMs": 1364.685,
"heapDeltaBytes": -20827776,
"heapUsedBytes": 68906416,
"domNodes": -245,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 596.266,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66619718309859,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3807.3819999999614,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.928,
"layouts": 67,
"layoutDurationMs": 12.191,
"taskDurationMs": 1374.3419999999999,
"heapDeltaBytes": -9022268,
"heapUsedBytes": 79909004,
"domNodes": -245,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 569.8409999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666228070175436,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2490.163999999993,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.879,
"layouts": 7,
"layoutDurationMs": 1.5199999999999998,
"taskDurationMs": 1355.5259999999998,
"heapDeltaBytes": -13684700,
"heapUsedBytes": 77793920,
"domNodes": 0,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 679.9620000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666442953020134,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2814.8100000000795,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.83,
"layouts": 4,
"layoutDurationMs": 1.0790000000000002,
"taskDurationMs": 1454.775,
"heapDeltaBytes": -4166940,
"heapUsedBytes": 89679368,
"domNodes": 0,
"jsHeapTotalBytes": 6221824,
"scriptDurationMs": 720.035,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76547619047619,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2759.866000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.172,
"layouts": 10,
"layoutDurationMs": 2.0820000000000003,
"taskDurationMs": 439.78000000000003,
"heapDeltaBytes": -22606188,
"heapUsedBytes": 67685384,
"domNodes": -269,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 230.458,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060604,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2805.4499999999507,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3179999999999996,
"layouts": 8,
"layoutDurationMs": 2.018,
"taskDurationMs": 557.6909999999999,
"heapDeltaBytes": -3673684,
"heapUsedBytes": 85654760,
"domNodes": -269,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 251.34900000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.3519999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5120000000000005,
"layouts": 9,
"layoutDurationMs": 2.195,
"taskDurationMs": 423.336,
"heapDeltaBytes": -5442908,
"heapUsedBytes": 83319200,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 26.311,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2037.7619999999297,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.974,
"layouts": 9,
"layoutDurationMs": 2.4219999999999997,
"taskDurationMs": 521.81,
"heapDeltaBytes": -28024316,
"heapUsedBytes": 60727868,
"domNodes": -269,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 30.915999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2688.6410000000183,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.858,
"layouts": 8,
"layoutDurationMs": 1.9890000000000003,
"taskDurationMs": 397.6790000000001,
"heapDeltaBytes": -27041440,
"heapUsedBytes": 60881100,
"domNodes": -268,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 124.665,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583850931677,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2678.1929999999647,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.407,
"layouts": 8,
"layoutDurationMs": 2.134,
"taskDurationMs": 424.0330000000001,
"heapDeltaBytes": -11922180,
"heapUsedBytes": 79949912,
"domNodes": -264,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 137.231,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666459627329193,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3011.6239999999834,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4800000000000004,
"layouts": 8,
"layoutDurationMs": 2.0879999999999996,
"taskDurationMs": 727.05,
"heapDeltaBytes": -10454764,
"heapUsedBytes": 77792840,
"domNodes": -269,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 276.629,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665555555555557,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-topology-cadence",
"durationMs": 2907.7889999999798,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5650000000000004,
"layouts": 8,
"layoutDurationMs": 1.435,
"taskDurationMs": 629.9610000000001,
"heapDeltaBytes": -1544196,
"heapUsedBytes": 87827948,
"domNodes": -269,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 254.02800000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66609195402299,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 429.5839999999771,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.025,
"layouts": 10,
"layoutDurationMs": 3.042,
"taskDurationMs": 291.639,
"heapDeltaBytes": 22034068,
"heapUsedBytes": 84602704,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 99.029,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 524.1780000000063,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.756999999999999,
"layouts": 9,
"layoutDurationMs": 2.4499999999999993,
"taskDurationMs": 353.30000000000007,
"heapDeltaBytes": -1324856,
"heapUsedBytes": 60625724,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 110.75999999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2027.2830000000113,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1639999999999993,
"layouts": 10,
"layoutDurationMs": 2.5570000000000004,
"taskDurationMs": 345.327,
"heapDeltaBytes": 24769932,
"heapUsedBytes": 86942492,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.783999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.3530000000328,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6120000000000005,
"layouts": 9,
"layoutDurationMs": 2.2659999999999996,
"taskDurationMs": 321.726,
"heapDeltaBytes": 24617020,
"heapUsedBytes": 87241072,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7.687000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.192999999998,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.705999999999998,
"layouts": 10,
"layoutDurationMs": 2.1919999999999997,
"taskDurationMs": 518.2359999999999,
"heapDeltaBytes": 13334024,
"heapUsedBytes": 75202444,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 78.892,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653466,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.1470000000145,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.030999999999999,
"layouts": 10,
"layoutDurationMs": 2.491,
"taskDurationMs": 559.782,
"heapDeltaBytes": 18265388,
"heapUsedBytes": 80433976,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 85.706,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.9179999999333,
"styleRecalcs": 21,
"styleRecalcDurationMs": 15.033000000000001,
"layouts": 5,
"layoutDurationMs": 8.877000000000002,
"taskDurationMs": 663.8779999999999,
"heapDeltaBytes": 11901620,
"heapUsedBytes": 86496896,
"domNodes": 16029,
"jsHeapTotalBytes": 12718080,
"scriptDurationMs": 20.259000000000015,
"eventListeners": 3246,
"totalBlockingTimeMs": 83,
"frameDurationMs": 19.14680851063831,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8725.963999999976,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.771,
"layouts": 9,
"layoutDurationMs": 2.2590000000000003,
"taskDurationMs": 4169.435,
"heapDeltaBytes": -6252436,
"heapUsedBytes": 81207204,
"domNodes": -269,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 1953.538,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662213740458,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9392.389999999978,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.04,
"layouts": 9,
"layoutDurationMs": 2.3080000000000003,
"taskDurationMs": 4353.863,
"heapDeltaBytes": -4682384,
"heapUsedBytes": 82279360,
"domNodes": -269,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 2049.317,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15887.30800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15044.016,
"heapDeltaBytes": -44597704,
"heapUsedBytes": 253336428,
"domNodes": -3343,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 194.33,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.431260794473232,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 16376.759999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15691.330999999998,
"heapDeltaBytes": -12544652,
"heapUsedBytes": 283689700,
"domNodes": -3343,
"jsHeapTotalBytes": -2367488,
"scriptDurationMs": 214.018,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.0177304964539,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 18590.50500000001,
"styleRecalcs": 151,
"styleRecalcDurationMs": 15.281000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18296.104,
"heapDeltaBytes": -24154248,
"heapUsedBytes": 279017352,
"domNodes": -3343,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 621.911,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.32813688212928,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18653.09300000001,
"styleRecalcs": 138,
"styleRecalcDurationMs": 16.102000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18336.768000000004,
"heapDeltaBytes": 814744,
"heapUsedBytes": 285010028,
"domNodes": -3343,
"jsHeapTotalBytes": 13815808,
"scriptDurationMs": 651.087,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 34.82444029850747,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5590.921000000094,
"styleRecalcs": 20,
"styleRecalcDurationMs": 41.27199999999999,
"layouts": 20,
"layoutDurationMs": 18.624000000000002,
"taskDurationMs": 5475.676,
"heapDeltaBytes": 2478628,
"heapUsedBytes": 285015728,
"domNodes": -3343,
"jsHeapTotalBytes": 23060480,
"scriptDurationMs": 85.74199999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.145121951219515,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-node-resize-workload",
"durationMs": 5851.4900000000125,
"styleRecalcs": 20,
"styleRecalcDurationMs": 40.85899999999998,
"layouts": 20,
"layoutDurationMs": 20.263,
"taskDurationMs": 5735.0019999999995,
"heapDeltaBytes": -7173580,
"heapUsedBytes": 291313052,
"domNodes": -3343,
"jsHeapTotalBytes": 29609984,
"scriptDurationMs": 81.222,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.820238095238096,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8255.027999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7956.875,
"heapDeltaBytes": -4234980,
"heapUsedBytes": 257028224,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.77300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.946315789473687,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8137.589999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7801.542000000001,
"heapDeltaBytes": 281928,
"heapUsedBytes": 275804684,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.85100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.637676056338023,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 439.8480000000973,
"styleRecalcs": 16,
"styleRecalcDurationMs": 9.318,
"layouts": 12,
"layoutDurationMs": 3.494,
"taskDurationMs": 92.10799999999999,
"heapDeltaBytes": 7187712,
"heapUsedBytes": 67935572,
"domNodes": 136,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.870000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 458.44000000010965,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.886000000000003,
"layouts": 12,
"layoutDurationMs": 5.361999999999999,
"taskDurationMs": 102.789,
"heapDeltaBytes": 6914344,
"heapUsedBytes": 71932264,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.152000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 282.8319999999849,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.624,
"layouts": 76,
"layoutDurationMs": 14.969,
"taskDurationMs": 242.108,
"heapDeltaBytes": 10370660,
"heapUsedBytes": 50816084,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 107.084,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 254.3439999999464,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.616,
"layouts": 76,
"layoutDurationMs": 13.646,
"taskDurationMs": 213.511,
"heapDeltaBytes": 9930964,
"heapUsedBytes": 46849076,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 92.39999999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 365.18599999999424,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.274,
"layouts": 76,
"layoutDurationMs": 15.584999999999999,
"taskDurationMs": 324.74399999999997,
"heapDeltaBytes": -492256,
"heapUsedBytes": 92536376,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 114.82000000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 385.49399999999423,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5829999999999997,
"layouts": 76,
"layoutDurationMs": 17.139000000000003,
"taskDurationMs": 344.68899999999996,
"heapDeltaBytes": -647852,
"heapUsedBytes": 88249396,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.33000000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3158 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8f9574ac4ed33828cd9ddcb3900ff90279064bdb
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (268)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21701 +/- ##
==========================================
- Coverage 87.55% 87.46% -0.09%
==========================================
Files 2920 2925 +5
Lines 158769 158757 -12
Branches 43739 42407 -1332
==========================================
- Hits 139012 138859 -153
- Misses 18880 18977 +97
- Partials 877 921 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 231 files with indirect coverage changes 🚀 New features to boost your workflow:
|
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
f14fd9f to
e58c4cd
Compare
e58c4cd to
f9c4db1
Compare
f9c4db1 to
8b67819
Compare
8b67819 to
f6e732a
Compare
## Summary ### Why cloud#15376 (merged as Comfy-Org/cloud@99f52fc1) adds the required `period_charge_cents` to each Team credit stop price in `GET /api/billing/plans`. FE-3587 needs it, and the bot sync (Comfy-Org#21701) has not picked up that commit yet. Because the field is required, regenerating the types breaks the billing fixtures that build stop prices by hand, so this PR fixes that fallout too (the same thing the cloud PR description calls out). ### Root cause `period_charge_cents` is not in `@comfyorg/ingest-types` yet, so nothing on the frontend can read the charge the server bills. ### How - Regenerated `packages/ingest-types` from cloud@99f52fc1 with the same steps as the bot: `openapi-project -fe` → `pnpm generate` → `oxfmt`. - The billing SDK projection (`billingPlansView.ts`) reads `period_charge_cents` back from int64 like the other stop amounts, and refuses a stop whose charge does not fit a number. - Billing fixtures gain the field: monthly = `price_cents`, yearly = `price_cents × 12`, so no existing test expectation changes. `billingPlansView.test.ts` uses an uneven yearly charge to prove the projection carries the server value. - No UI change, but the plans schema now requires `period_charge_cents`: against a backend without cloud#15376 the billing SDK's plans read fails validation and the pricing dialog cannot load. **Merge only after every backend this build talks to serves the field** (see the hold comment). Nothing displays the field until FE-3587 (stacked on this PR). ## AS IS / TO BE No UI change in this PR; the visible fix and its screenshots are in the stacked FE-3587 PR. ## Verification - `pnpm typecheck`, `pnpm typecheck:billing-web`, `pnpm typecheck:browser`: 0 errors (11 files failed on the regenerated types before the fixture fix). - Vitest: the 9 touched app test files (301 tests) and billing-web `checkoutRequest` / `CheckoutView` (85 tests) pass. ## Where this sits in the plan | Step | Item | Ticket / PR | Status | | --- | --- | --- | --- | | 1 | Plans API returns each stop's period charge | cloud#15376 | Merged | | 2 | **Sync ingest types + billing fixtures (this PR)** | this PR | **This PR** | | 3 | Show the server's yearly charge in pricing and checkout | FE-3587 (stacked) | Open | | 4 | Backport to core/cloud 1.58 | needs-backport | After merge | ```mermaid graph LR be["cloud 15376 period_charge_cents (merged)"] --> sync["ingest types sync (this PR)"] sync --> fe["FE-3587 yearly charge in pricing"] fe --> bp["backport core/cloud 1.58"] style sync stroke-width:3px ```
f6e732a to
e4cb696
Compare
e4cb696 to
d44c39a
Compare
d44c39a to
5614c30
Compare
5614c30 to
97282d8
Compare
97282d8 to
2f2335f
Compare
2f2335f to
af52a89
Compare
| const result = await createPlansReader({ transport, scopeSource }).read() | ||
|
|
||
| expect(result.status).toBe('ok') | ||
| if (result.status !== 'ok') return |
There was a problem hiding this comment.
This is just for type narrowing?
There was a problem hiding this comment.
Addressed in 73f6a62. The test now uses an explicit asserting narrow (assert(result.status === "ok")) instead of an expectation followed by an early-return branch.
| function isRecord(value: unknown): value is Record<string, unknown> { | ||
| return typeof value === 'object' && value !== null && !Array.isArray(value) | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
Addressed in 73f6a62. The custom record predicate is gone; the compatibility boundary is now a named Zod schema.
| } | ||
|
|
||
| function filterUnreadableFeatureItems(plan: unknown): unknown { | ||
| if (!isRecord(plan) || !Array.isArray(plan.feature_items)) return plan |
There was a problem hiding this comment.
This and the other guard make me think there are real schemas that could have named guards instead of doing piecewise checks
There was a problem hiding this comment.
Or use of Zod transform in the schema to do the filtering? https://zod.dev/api#transforms
There was a problem hiding this comment.
Addressed in 73f6a62 using the transform alternative: CompatiblePlanSchema filters unreadable display items, and BillingPlansBodySchema pipes the transformed loose object into the generated response schema. The piecewise object/array guards were removed.
| @@ -39,16 +39,21 @@ vi.mock<unknown>(import('@/platform/workspace/utils/platformLink'), () => ({ | |||
| })) | |||
|
|
|||
There was a problem hiding this comment.
Can we combine all of the fake objects that had to be updated for tests in this PR?
There was a problem hiding this comment.
I kept these fakes local. The required fields span independent package, app, Vitest, and Playwright boundaries with different owners and scenario defaults; one cross-surface fake would couple unrelated suites and hide which public response each test exercises. Within each suite, existing shared builders/fakes remain the single local source.
df4f9a1 to
50f5a4f
Compare
50f5a4f to
57a8b9b
Compare
57a8b9b to
1ed7a4e
Compare
1ed7a4e to
3567d9a
Compare
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
dante01yoon
left a comment
There was a problem hiding this comment.
I checked the regen against the merge base (93accf6d):
- No export was removed from
types.gen.ts,zod.gen.tsorindex.ts.index.tsre-exports all 34 new types, and theReleaseUnsupportedPack*/CccWebsiteCardFacet*hunks only move and re-sort those types. - No src rename breaks. The new required response fields are
BillingStatusResponse.ended_at,BillingCapabilitiesResponse.auto_top_up_enabledand the auto-reload settings fields. Typecheck and unit/e2e CI are green on this head. - The hand-written code builds on generated exports (
billing-corePick/Omit,zPlanFeatureItem,zBillingCapabilitiesResponse.shape), so Gate 3 is fine.
I have one open question about deploy ordering for ended_at (inline). I could not rerun openapi-ts against cloud 89174e97 locally, so I checked that the regen is clean by the export and diff checks above, not by regenerating. DrJKL's open threads on plans.ts (isPlainObject, schema transform, shared fakes) still apply; I'm not repeating them.
| billing_status: zBillingStatus.optional(), | ||
| cancel_at: z.iso.datetime().optional(), | ||
| current_period_start: z.iso.datetime().optional(), | ||
| ended_at: z.iso.datetime().nullable(), |
There was a problem hiding this comment.
question: ended_at is now required on zBillingStatusResponse, and createBillingStatusReader (packages/account-core/src/core/billing/status.ts) parses /billing/status strictly in production. If this frontend reaches any environment whose billing-api does not send ended_at yet, every status read fails as malformed. Is ended_at already deployed on the billing-api in every environment this frontend ships to (staging, prod)? The PR treats auto_top_up_enabled as optional for older servers in capabilities.ts, and the three raw fixtures that had to gain ended_at: null suggest real bodies did not carry it until recently. If it isn't rolled out everywhere, could it get the same .optional() handling until it is?
There was a problem hiding this comment.
Addressed in a17a347. The consumer schema now accepts an omitted ended_at while preserving null/valid dates and rejecting malformed supplied dates, so merge no longer depends on every environment completing the billing rollout first. The focused account-core and authenticated billing-web compatibility tests pass on the current branch.
| function projectFeatureItem({ | ||
| params, | ||
| ...item | ||
| }: DecodedFeatureItem): FeatureItem | undefined { |
There was a problem hiding this comment.
nit-pick (non-blocking): projectFeatureItem never returns undefined, because an unsafe count falls back to item. So projectAll here never returns undefined, and the featureItems === undefined branch in projectPlan (line 68) can't run. Narrowing the return type to FeatureItem would let projectFeatureItems return Pick<Plan, 'feature_items'> and drop that branch.
There was a problem hiding this comment.
Addressed in 73f6a62. projectFeatureItem now returns FeatureItem, projectFeatureItems maps directly, and the unreachable undefined branch in projectPlan is gone.
There was a problem hiding this comment.
Verdict: awaiting billing-status rollout confirmation and responses to the existing feedback.
I checked Dante's two comments against the current head. I confirm the schema compatibility concern and the non-blocking dead-branch finding. I am leaving a COMMENT because the deployment question is unresolved, rather than claiming a production failure without deployment evidence.
Existing findings confirmed or still awaiting an answer
- Required
ended_at: confirmed conditional incompatibility.createBillingStatusReaderpasses the body tozBillingStatusResponse.safeParse, and the shared reader returnsMALFORMED_RESPONSEwhen parsing fails. A response omittingended_attherefore fails. I have not verified staging or production payloads. Please confirm that every supported environment sends the field before this frontend ships, or handle the older response contract at the consumer boundary. Updating fixtures alone does not establish deployment order. - P3, Nit: Unreachable display-feature failure paths: confirmed. Every branch of
projectFeatureItemreturns an item, including an unsafe count. The optional return type and the downstream undefined checks are unnecessary for feature items. Monetary projections still need their fail-closed handling. - Test narrowing question: still unanswered. The status assertion followed by the narrowing return remains. The assertion does fail for an error result, so I am not treating this as a test that silently passes.
- P3, Nit:
isPlainObjectrequest: still open. The customisRecordcheck remains. - P3, Nit: Named schema guards: still open. Both filtering functions retain their piecewise record and array checks.
- Zod transform alternative: still unanswered. The reader still filters the unknown body before calling the generated schema. This is an alternative to the preceding guard refactor, not a request to implement both approaches.
- P3, Nit: Shared billing fakes: still open. The tests retain the local billing payload fixtures that prompted the request.
Addressed findings and evaluation context
- Unknown feature keys rejecting the catalog: addressed by the display-feature tolerance fix, preserved at this head. Unreadable feature items are filtered before the generated catalog parser runs. The author already answered this thread.
- Unsafe display counts hiding all plans: addressed by the same fix, preserved at this head. The item survives without interpolation params. The author already answered this thread.
- Dante's review: its two open items are dispositioned individually above. I have not independently regenerated the package against the cloud source, so I do not infer reproducibility from the export comparison.
- Swarmhost evaluation pointer: the GitHub comment contains an internal Slack link, not review findings. I have not read the linked evaluation and cannot confirm or contest its contents.
Verification and scope
This round evaluates the new human feedback against the retained head and carries forward the unanswered review requests. It is not a fresh full-PR clearance. I traced the generated status schema, the production status reader, shared parse failure handling, and the display-feature projection. No local code changes or new test runs were needed for those code-level dispositions.
The head's paginated check-run results show typecheck, lint, format, package/unit tests, billing-web unit/E2E gates, and the E2E status gate succeeding. Other jobs were skipped; no check-run failures or pending runs appeared in that snapshot. Those results do not establish which billing API revision is deployed.
There was a problem hiding this comment.
Verdict: the billing-status compatibility concern is addressed; the earlier review requests remain open.
I checked the compatibility fix against the previously reviewed head. The reader now accepts an omitted ended_at without inventing a date, while retaining validation of supplied values. The generated contract is unchanged; the consumer schema and exported billing-core response type admit the older response.
I found no new production blocker. The two new inline P3 suggestions remove duplicate malformed-date integration cases while keeping the core rejection table and both hosts' older-response composition checks.
Addressed compatibility concern
- Dante's end-date question, confirmed in my previous review, is addressed at this head.
BillingStatusBodySchemamakes onlyended_atoptional. Malformed supplied dates and malformed required billing fields still fail parsing. The new core table distinguishes omission, null, and a recorded timestamp, and checks that invalid responses preserve the previous snapshot. I no longer need deployment-order confirmation to settle this concern.
Existing requests still open
- P3, Nit: Unreachable display-feature failure paths remain confirmed.
projectFeatureItemstill never returns undefined; this commit does not change that projection. - Test narrowing question remains unanswered. The status assertion and narrowing return are unchanged. The assertion fails on an error result, so this is not a silent-pass defect.
- P3, Nit: Use
isPlainObjectremains open; the custom record check is unchanged. - P3, Nit: Named schema guards remains open; the piecewise record and array checks are unchanged.
- The Zod transform alternative remains unanswered. It is an alternative to the guard refactor, not a request for both designs.
- P3, Nit: Shared billing fakes remains open. This delta does not consolidate those fixtures.
Verification and scope
I reviewed the five-file delta from the previous head, using correctness, maintainability, and tests review briefs. The current-head CI snapshot has successful typecheck, lint/format, package/unit tests, billing-web unit/E2E gates, and E2E status checks. Other jobs were skipped; none were failed or pending in that snapshot. I did not rerun suites locally or verify deployed backend payloads.
I also read the exact-head CI logs: the core status suite ran 10 tests, the hosted client suite 20, and the auth compatibility suite 28, all passing. No pre-fix red run or deletion experiment was performed.
The open-PR search also found the stacked billing rollout-fact repair. That PR describes preserving auto_top_up_enabled, a separate capability contract; it does not settle this end-date question.
This is a delta review, not a new full-PR clearance or approval. The previously addressed catalog findings retain their dispositions from the preceding review.
| it('rejects a malformed supplied end date through the authenticated billing web client', async () => { | ||
| vi.mocked(fetch).mockResolvedValue( | ||
| new Response(JSON.stringify({ ...STATUS_BODY, ended_at: 'not-a-date' }), { | ||
| status: 200 | ||
| }) | ||
| ) | ||
| const client = createBillingWebClient(authenticatedSession()) | ||
|
|
||
| const result = await client.status.read() | ||
|
|
||
| expect(result).toEqual({ | ||
| status: 'error', | ||
| code: 'MALFORMED_RESPONSE', | ||
| httpStatus: 200 | ||
| }) | ||
| expect(client.status.getSnapshot()).toBeUndefined() | ||
| disposeBillingClient(client) | ||
| }) |
There was a problem hiding this comment.
P3, Nit: Delete this duplicate parser-rejection case. The new core row rejects a malformed date without replacing valid status in status.test.ts already exercises the real reader, checks MALFORMED_RESPONSE, and verifies snapshot retention. composeBillingWebClient constructs that same reader without a date adapter. Keep the preceding older-response test as the hosted transport/composition regression and keep the core rejection table. This avoids maintaining the same malformed-date contract at two levels.
| it('rejects a malformed supplied end date through the authenticated billing web client', async () => { | |
| vi.mocked(fetch).mockResolvedValue( | |
| new Response(JSON.stringify({ ...STATUS_BODY, ended_at: 'not-a-date' }), { | |
| status: 200 | |
| }) | |
| ) | |
| const client = createBillingWebClient(authenticatedSession()) | |
| const result = await client.status.read() | |
| expect(result).toEqual({ | |
| status: 'error', | |
| code: 'MALFORMED_RESPONSE', | |
| httpStatus: 200 | |
| }) | |
| expect(client.status.getSnapshot()).toBeUndefined() | |
| disposeBillingClient(client) | |
| }) |
| }, | ||
| { | ||
| name: 'a malformed supplied end date', | ||
| body: { ...BILLING_STATUS, ended_at: 'not-a-date' }, | ||
| expected: { status: 'error', code: 'MALFORMED_RESPONSE', httpStatus: 200 } | ||
| } |
There was a problem hiding this comment.
P3, Nit: Delete this malformed-date row, which adds two auth-bootstrap cases through the enclosing flag table. The new core row rejects a malformed date without replacing valid status already proves this parser rejection and snapshot preservation. The SDK constructs the same reader and readStatus forwards its error unchanged. Keep the older-response row here to prove Firebase rail composition, and keep all core rejection rows; those separate transport wiring from the date-validation matrix.
| }, | |
| { | |
| name: 'a malformed supplied end date', | |
| body: { ...BILLING_STATUS, ended_at: 'not-a-date' }, | |
| expected: { status: 'error', code: 'MALFORMED_RESPONSE', httpStatus: 200 } | |
| } | |
| } |
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed at exact head 73f6a62.
- Replayed cloud 89174e97 FE projection and pinned openapi-ts 0.97.3 generation; generated outputs are byte-identical after the workflow formatter, and the internal/M2M endpoint guard is clean.
- Verified no Agent export was removed or renamed. Agent changes are additive optional graph-binding/correlation fields and error-description updates; existing consumers remain compatible.
- Confirmed older billing status bodies remain accepted without ended_at while malformed supplied dates still fail closed.
- Addressed the open plan-reader and projection findings in 73f6a62.
- Focused account-core, billing-web, billing-plan, and Agent compatibility suites pass; ingest-types typecheck/build and normal commit/pre-push hooks pass.
No blocking findings remain.
Automated Ingest API Type Update
This PR updates the Ingest API TypeScript types and Zod schemas from the latest cloud OpenAPI specification.
These types cover the FE-facing ingest API (workspaces, billing, secrets, assets, tasks, etc.).
Cloud's internal / machine-to-machine surface —
x-internaloperations and the/admin/,/api/internal/,/api/webhooks/rails — is stripped before generation(BE-2669), so it is not code-generated into this public package.
Validated replay-conflict follow-up
The regular merge from frontend main
93accf6dpreserves all four maintainer repair commits (c05eb3f908,bff527e1bd,1f8516cf5e,e0ce1c0a9a). Billing moved out ofworkspaceApion main, so the repaired auto-reload fixture fields now live in thebillingApimock. The later repair that keeps optional display items when their counts are unreadable remains intact.All three generated files now come from the FE projection of merged Cloud
89174e97, superseding the original003bac4dgeneration noted above, using pinned@hey-api/openapi-ts0.97.3 and normal repository formatting. Optional auto-top-up state stays unknown when older servers omit it; typed fixtures match the current generated contract.Validation: 788 account-core billing tests and 51 billing consumer tests passed; package build and complete normal commit/push hooks passed. Fallow found zero issues in the 74 changed files. The internal/M2M endpoint guard remains clean.
Maintainer action before Cloud publication can resume: squash-merge this PR and allow the repository's configured automatic deletion of
update-ingest-types. The publisher intentionally refuses to replay an outstanding maintainer merge. Local tests of the unchanged guard/replay scripts verify that the post-squash, deleted-branch case preserves the complete repaired source and allows a new generation-only branch with a normal push. No guard, exact-head lease, or maintainer-preservation check was weakened; no force push or PR merge was performed by this follow-up.Billing status fixture correction
CI exposed three raw HTTP status fixtures that omitted the generated contract's required nullable
ended_at. The follow-up addsended_at: nullandsatisfies BillingStatusResponsechecks; production decoding, timeouts, and every behavior assertion remain unchanged. The exact CI-mode billing coverage run now passes all 59 suites / 1,577 tests (94.98% statements, 92.46% branches), and the focused auth suite passes all 24 tests. Normal commit/push hooks also pass, with zero Fallow findings in the 77 changed files. The squash-merge and automatic branch-deletion dependency above is unchanged.Older billing response compatibility: the consumer accepts an omitted
ended_atas unknown, preserves null and valid dates, and still rejects malformed supplied dates and malformed or missing core fields. Generated files remain unchanged. Verified with 795 account-core billing tests, 1,579 billing-web tests with coverage, and 36 auth/SDK projection tests; package declarations and normal commit/pre-push hooks pass. Current declared staging/production API release sources include the field; actual running-pod rollout was not verified.The existing publication dependency remains: a maintainer must squash-merge this PR and allow automatic deletion of
update-ingest-typesbefore rerunning Cloud type publication. The replay guard is unchanged.