Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Capability contract and projection packages/ingest-types/src/zod.gen.ts, packages/ingest-types/src/index.ts, packages/account-core/src/core/billing/*, src/platform/billing/sdk/billingCapabilitiesView.*, billing fixtures and tests |
Billing capability data includes auto_top_up_enabled. The account-core reader and SDK projection preserve its boolean value. Capability fixtures and tests include the field. |
Plan feature parsing and projection packages/ingest-types/src/zod.gen.ts, packages/ingest-types/src/index.ts, packages/account-core/src/core/billing/plans.*, src/platform/billing/sdk/billingPlansView.* |
Plan schemas include structured feature items. The account-core reader filters invalid items. The SDK projection converts safe feature counts and omits an unsafe count while retaining other item fields. |
Auto-reload contract and fixtures packages/ingest-types/src/zod.gen.ts, packages/ingest-types/src/index.ts, src/platform/billing/components/billingTab/BillingAutoTopUpCard.test.ts, src/platform/billing/composables/useBillingAutoTopUpCard.test.ts, src/platform/workspace/api/__mocks__/workspaceApi.ts |
Auto-reload settings include card expiry, declined-payment details, reload limits, and budget fields. Test fixtures and workspace mocks provide these fields. |
CCC catalog API contracts
| Layer / File(s) | Summary |
|---|---|
CCC response shapes packages/ingest-types/src/zod.gen.ts, packages/ingest-types/src/index.ts |
Generated types define CCC website root presentations, model directories, legacy targets, and public cache authority responses. |
CCC endpoint bindings and exports packages/ingest-types/src/zod.gen.ts, packages/ingest-types/src/index.ts |
Generated endpoint schemas include CCC query parameters, authority headers, and responses. The export barrel exposes related response and endpoint types. |
Release, document, and deployment contracts
| Layer / File(s) | Summary |
|---|---|
Generated response and endpoint contracts packages/ingest-types/src/zod.gen.ts, packages/ingest-types/src/index.ts |
Generated schemas add document-operation IDs, unsupported Release-pack responses, and workspace-deployment results and bindings. |
Run-approval ask normalization
| Layer / File(s) | Summary |
|---|---|
Run-approval context and fixture handling packages/ingest-types/src/zod.gen.ts, browser_tests/fixtures/agentTurnLockFixture.ts |
The run-approval context schema adds optional document sequence and graph fields. The fixture converts a present context.doc_seq to a safe integer when recording run-approval asks. |
Priority:
Estimated code review effort: 3 (Moderate) | ~25 minutes
Change: Bug fix
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21946: Adds generated billing and run-approval fields that this PR carries into its readers, projections, and fixture handling.
- Comfy-Org/ComfyUI_frontend#22037: Refactors billing APIs and SDK modules that this PR updates with capability and plan handling.
Suggested reviewers: dante01yoon, christian-byrne
Merge Risk: 
Minimal · up to 0633d
-
No merge-blocking risk was identified in the billing projections or fixture changes.
Pre-merge checks: 
5 · 
1
-
Failed checks: 1 warning Passed checks: 5 passed-
Full details: Title check
-
Explanation
The title "fix: preserve billing rollout fact across ingest type sync" is conventional-commit formatted and describes the main change. The PR preserves the server-served auto_top_up_enabled boolean through the billing SDK snapshot and adapter, and updates fixtures to include the required field. The title is somewhat abstract: "billing rollout fact" does not name the field, and the browser turn-lock doc_seq serialization fix is not mentioned. These are minor gaps, not a mismatch, so the title is related to the main change and passes.
Full details: Description check
-
Explanation
The description follows the template's Summary and Verification sections. The Summary explains the problem (the ingest type sync requires auto_top_up_enabled, but the SDK drops it and fixtures omit it), the fix, and a known risk (stacked on
#21701, with prerequisites still open). The Verification section gives test counts, CI status, and local validation, and states what was not verified (browser E2E run locally, real Desktop/account/grant QA). It does not include a 'Fixes #' line, which the template marks as optional. The description is long and dense, but it covers the required content.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed-file list contains no files under
src/lib/litegraph/orsrc/ecs/, and no changed file is related to graph entities such as nodes, links, widgets, slots, reroutes, groups, or subgraphs. The ADR check is not applicable.
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The diff changes the frontend billing capability path: it preserves the server-provided
auto_top_up_enabledvalue in the SDK snapshot and adapter. A real user account can receive this billing capability response, and the missing value can affect billing capability behavior. The PR updates onlybrowser_testsfixtures, not a spec that exercises this path.Resolution
This is a suggestion, not a merge requirement. A billing capability response can include
auto_top_up_enabledfor a user account. Extend an existing spec underbrowser_tests/with: - Mock a billing capabilities response containingauto_top_up_enabled. - Load the billing surface for that account. - Expect the billing surface to preserve the capability state.
-
Finishing Touches: 💡 1
-
⚔️ Resolve merge conflicts: 💡
-
- Resolve merge conflict in branch
ryan-di/pm-2121-ingest-sync-compat
- Resolve merge conflict in branch
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T05:46:03.237Z",
"gitSha": "fd095cd51d29d9ba05bafe201c3f32db8b5c2cc4",
"branch": "ryan-di/pm-2121-ingest-sync-compat",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.766999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.8450000000000002,
"layouts": 10,
"layoutDurationMs": 1.855,
"taskDurationMs": 401.281,
"heapDeltaBytes": -153432,
"heapUsedBytes": 62507152,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 6.609000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2009.855000000016,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.8739999999999999,
"layouts": 11,
"layoutDurationMs": 2.113,
"taskDurationMs": 405.647,
"heapDeltaBytes": 1883188,
"heapUsedBytes": 63038172,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 6.730000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.3009999999763,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.143,
"layouts": 10,
"layoutDurationMs": 1.6559999999999997,
"taskDurationMs": 617.679,
"heapDeltaBytes": 22084084,
"heapUsedBytes": 84714116,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 101.847,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.5679999999707,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.629,
"layouts": 10,
"layoutDurationMs": 1.668,
"taskDurationMs": 610.994,
"heapDeltaBytes": -2352468,
"heapUsedBytes": 68702144,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 99.826,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.7180000000385,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.5060000000000002,
"layouts": 11,
"layoutDurationMs": 2.145,
"taskDurationMs": 300.63700000000006,
"heapDeltaBytes": -746724,
"heapUsedBytes": 67460568,
"domNodes": 57,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 8.042000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.5609999999842,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.459,
"layouts": 10,
"layoutDurationMs": 1.974,
"taskDurationMs": 305.582,
"heapDeltaBytes": -1057728,
"heapUsedBytes": 60195788,
"domNodes": 57,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 7.993000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 532.4629999999786,
"styleRecalcs": 13,
"styleRecalcDurationMs": 1.647,
"layouts": 9,
"layoutDurationMs": 1.6159999999999999,
"taskDurationMs": 346.263,
"heapDeltaBytes": 3469020,
"heapUsedBytes": 64892348,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 113.57199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 550.264000000027,
"styleRecalcs": 15,
"styleRecalcDurationMs": 1.8499999999999996,
"layouts": 10,
"layoutDurationMs": 1.9349999999999998,
"taskDurationMs": 352.207,
"heapDeltaBytes": 5256608,
"heapUsedBytes": 66457488,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 118.97599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1037.7739999999847,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.757,
"heapDeltaBytes": -14906820,
"heapUsedBytes": 74924012,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 43.38700000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 369,
"frameDurationMs": 28.700000000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1054.8160000000166,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 697.9950000000001,
"heapDeltaBytes": -11411540,
"heapUsedBytes": 75401084,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 38.436,
"eventListeners": -106,
"totalBlockingTimeMs": 386,
"frameDurationMs": 29.16388888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 748.0370000000107,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.12299999999965,
"heapDeltaBytes": -24167488,
"heapUsedBytes": 66438912,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 99.84499999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 113,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 764.14299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.84799999999996,
"heapDeltaBytes": -24302800,
"heapUsedBytes": 66151748,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 98.97399999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 116,
"frameDurationMs": 21.294444444444455,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6943.196,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.47900000000000026,
"layouts": 3,
"layoutDurationMs": 0.5600000000000002,
"taskDurationMs": 6138.662,
"heapDeltaBytes": 46478224,
"heapUsedBytes": 127823116,
"domNodes": -257,
"jsHeapTotalBytes": 49672192,
"scriptDurationMs": 4592.133,
"eventListeners": -68,
"totalBlockingTimeMs": 13,
"frameDurationMs": 24.047750865051903,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6829.615999999987,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.4710000000000001,
"layouts": 3,
"layoutDurationMs": 0.49799999999999994,
"taskDurationMs": 6041.6810000000005,
"heapDeltaBytes": 52731040,
"heapUsedBytes": 134611048,
"domNodes": -257,
"jsHeapTotalBytes": 55439360,
"scriptDurationMs": 4685.065,
"eventListeners": -68,
"totalBlockingTimeMs": 70,
"frameDurationMs": 25.02967032967033,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6404.331000000013,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.6780000000000006,
"layouts": 4,
"layoutDurationMs": 0.7089999999999997,
"taskDurationMs": 5630.626,
"heapDeltaBytes": 61122968,
"heapUsedBytes": 140744144,
"domNodes": -257,
"jsHeapTotalBytes": 48361472,
"scriptDurationMs": 4281.544999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 57,
"frameDurationMs": 24.70965250965251,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6415.291000000025,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.46100000000000046,
"layouts": 3,
"layoutDurationMs": 0.5510000000000003,
"taskDurationMs": 5732.467000000001,
"heapDeltaBytes": 33839688,
"heapUsedBytes": 113627044,
"domNodes": -257,
"jsHeapTotalBytes": 48361472,
"scriptDurationMs": 4347.065,
"eventListeners": -68,
"totalBlockingTimeMs": 54,
"frameDurationMs": 24.966536964980545,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 151.68800000000715,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.674,
"layouts": 11,
"layoutDurationMs": 2.2960000000000003,
"taskDurationMs": 111.162,
"heapDeltaBytes": 14380188,
"heapUsedBytes": 89242684,
"domNodes": 936,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.692000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.41428571428573,
"p95FrameDurationMs": 50.09999999999991
},
{
"name": "large-combo-open",
"durationMs": 163.4999999999991,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.806999999999997,
"layouts": 11,
"layoutDurationMs": 2.803,
"taskDurationMs": 119.71800000000002,
"heapDeltaBytes": 14329984,
"heapUsedBytes": 89879100,
"domNodes": 936,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.561999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2025.4959999999755,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.3280000000000003,
"layouts": 8,
"layoutDurationMs": 1.5910000000000002,
"taskDurationMs": 498.75,
"heapDeltaBytes": -27355344,
"heapUsedBytes": 60284712,
"domNodes": -257,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 19.215999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2023.2629999999858,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.576,
"layouts": 9,
"layoutDurationMs": 1.573,
"taskDurationMs": 490.262,
"heapDeltaBytes": 8932368,
"heapUsedBytes": 82594356,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 20.921999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2149.084000000016,
"styleRecalcs": 69,
"styleRecalcDurationMs": 4.867,
"layouts": 8,
"layoutDurationMs": 1.354,
"taskDurationMs": 1205.11,
"heapDeltaBytes": -11495036,
"heapUsedBytes": 77195972,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 554.581,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2117.247999999961,
"styleRecalcs": 69,
"styleRecalcDurationMs": 4.953000000000001,
"layouts": 8,
"layoutDurationMs": 1.442,
"taskDurationMs": 1063.787,
"heapDeltaBytes": -12850488,
"heapUsedBytes": 76599988,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 560.3489999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3172.0559999999978,
"styleRecalcs": 74,
"styleRecalcDurationMs": 6.321000000000001,
"layouts": 67,
"layoutDurationMs": 7.792,
"taskDurationMs": 1268.3029999999999,
"heapDeltaBytes": -28157132,
"heapUsedBytes": 63970292,
"domNodes": -233,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 519.123,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3111.04499999999,
"styleRecalcs": 74,
"styleRecalcDurationMs": 6.1770000000000005,
"layouts": 67,
"layoutDurationMs": 7.683000000000001,
"taskDurationMs": 1239.141,
"heapDeltaBytes": 2546240,
"heapUsedBytes": 91957732,
"domNodes": 24,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 509.7579999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66559139784946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2310.6319999999982,
"styleRecalcs": 48,
"styleRecalcDurationMs": 3.21,
"layouts": 9,
"layoutDurationMs": 1.724,
"taskDurationMs": 1349.253,
"heapDeltaBytes": -18340112,
"heapUsedBytes": 74210704,
"domNodes": 0,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 639.494,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786956521739132,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2344.5140000000038,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.0930000000000004,
"layouts": 7,
"layoutDurationMs": 1.22,
"taskDurationMs": 1342.06,
"heapDeltaBytes": -15018364,
"heapUsedBytes": 78526636,
"domNodes": 0,
"jsHeapTotalBytes": 6590464,
"scriptDurationMs": 623.712,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.784999999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2906.628999999981,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5299999999999991,
"layouts": 9,
"layoutDurationMs": 1.8259999999999998,
"taskDurationMs": 576.8839999999999,
"heapDeltaBytes": -8396936,
"heapUsedBytes": 80553976,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 255.376,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2903.4340000000043,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.197,
"layouts": 8,
"layoutDurationMs": 1.2679999999999998,
"taskDurationMs": 562.915,
"heapDeltaBytes": -30537096,
"heapUsedBytes": 62768448,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 261.434,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666091954022985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.4239999999872,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.5539999999999998,
"layouts": 9,
"layoutDurationMs": 1.718,
"taskDurationMs": 497.6529999999999,
"heapDeltaBytes": -26904108,
"heapUsedBytes": 63443132,
"domNodes": -257,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 22.212,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2032.4709999999868,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.3360000000000003,
"layouts": 8,
"layoutDurationMs": 1.4649999999999999,
"taskDurationMs": 491.216,
"heapDeltaBytes": -19474640,
"heapUsedBytes": 72355652,
"domNodes": -257,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 19.753,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2680.027999999993,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.303,
"layouts": 9,
"layoutDurationMs": 1.369,
"taskDurationMs": 391.178,
"heapDeltaBytes": -17918484,
"heapUsedBytes": 71581528,
"domNodes": -254,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 116.068,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666459627329193,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2690.4860000000212,
"styleRecalcs": 27,
"styleRecalcDurationMs": 8.014000000000001,
"layouts": 8,
"layoutDurationMs": 1.2989999999999997,
"taskDurationMs": 448.349,
"heapDeltaBytes": -19974552,
"heapUsedBytes": 68387716,
"domNodes": -255,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 119.516,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604938271605,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 2982.972999999987,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.3739999999999999,
"layouts": 9,
"layoutDurationMs": 1.682,
"taskDurationMs": 679.7020000000001,
"heapDeltaBytes": -6291652,
"heapUsedBytes": 69902944,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 256.29400000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2937.800999999979,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.4169999999999998,
"layouts": 8,
"layoutDurationMs": 1.5270000000000001,
"taskDurationMs": 662.513,
"heapDeltaBytes": -403540,
"heapUsedBytes": 75467828,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 251.403,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 498.72699999997394,
"styleRecalcs": 48,
"styleRecalcDurationMs": 3.2360000000000007,
"layouts": 10,
"layoutDurationMs": 1.639,
"taskDurationMs": 300.30899999999997,
"heapDeltaBytes": -1286824,
"heapUsedBytes": 60419584,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 94.14599999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 480.8150000000069,
"styleRecalcs": 48,
"styleRecalcDurationMs": 3.2680000000000007,
"layouts": 10,
"layoutDurationMs": 1.5410000000000001,
"taskDurationMs": 307.11,
"heapDeltaBytes": -1159940,
"heapUsedBytes": 61467720,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 95.083,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.0089999999918,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.744,
"layouts": 10,
"layoutDurationMs": 1.804,
"taskDurationMs": 394.65799999999996,
"heapDeltaBytes": 1006488,
"heapUsedBytes": 63248448,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 6.201999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.6250000000477,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8150000000000002,
"layouts": 10,
"layoutDurationMs": 1.81,
"taskDurationMs": 441.965,
"heapDeltaBytes": -7608628,
"heapUsedBytes": 53964552,
"domNodes": -183,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 5.927000000000001,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.4980000000148,
"styleRecalcs": 76,
"styleRecalcDurationMs": 9.082999999999998,
"layouts": 10,
"layoutDurationMs": 1.9279999999999997,
"taskDurationMs": 582.586,
"heapDeltaBytes": 17468912,
"heapUsedBytes": 79895796,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 69.727,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.7770000000155,
"styleRecalcs": 75,
"styleRecalcDurationMs": 8.761,
"layouts": 11,
"layoutDurationMs": 2.007,
"taskDurationMs": 602.778,
"heapDeltaBytes": 17686396,
"heapUsedBytes": 80291664,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 67.04899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1068.7130000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 15.624000000000002,
"layouts": 5,
"layoutDurationMs": 9.386000000000001,
"taskDurationMs": 784.591,
"heapDeltaBytes": 9419352,
"heapUsedBytes": 110945988,
"domNodes": 16030,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 20.738,
"eventListeners": 3246,
"totalBlockingTimeMs": 118,
"frameDurationMs": 19.698181818181812,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8189.079000000021,
"styleRecalcs": 250,
"styleRecalcDurationMs": 15.279,
"layouts": 9,
"layoutDurationMs": 1.5730000000000002,
"taskDurationMs": 4142.656,
"heapDeltaBytes": -6168968,
"heapUsedBytes": 80917620,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 1824.8460000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598778004073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8174.114000000031,
"styleRecalcs": 249,
"styleRecalcDurationMs": 14.922999999999998,
"layouts": 8,
"layoutDurationMs": 1.3259999999999996,
"taskDurationMs": 4184.36,
"heapDeltaBytes": -1961208,
"heapUsedBytes": 72533880,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 1846.306,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591836734694,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14869.124999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13808.333999999999,
"heapDeltaBytes": -46595908,
"heapUsedBytes": 254980948,
"domNodes": -3343,
"jsHeapTotalBytes": 12050432,
"scriptDurationMs": 147.68300000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.901340033500833,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 14643.249999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13632.169999999998,
"heapDeltaBytes": -20307608,
"heapUsedBytes": 262078840,
"domNodes": -3343,
"jsHeapTotalBytes": 13623296,
"scriptDurationMs": 153.307,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.74577702702703,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 16894.322999999986,
"styleRecalcs": 113,
"styleRecalcDurationMs": 10.095000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16401.647,
"heapDeltaBytes": -6136636,
"heapUsedBytes": 270814316,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 597.1410000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 30.33985637342909,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 17207.54100000005,
"styleRecalcs": 134,
"styleRecalcDurationMs": 11.952000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16621.837000000003,
"heapDeltaBytes": -22624332,
"heapUsedBytes": 274657764,
"domNodes": -3343,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 615.313,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.797853309481216,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 5156.888000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.20100000000001,
"layouts": 20,
"layoutDurationMs": 16.062999999999995,
"taskDurationMs": 4990.988,
"heapDeltaBytes": -32970316,
"heapUsedBytes": 258988068,
"domNodes": -3343,
"jsHeapTotalBytes": 26730496,
"scriptDurationMs": 60.032,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.21090909090909,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 5107.328000000052,
"styleRecalcs": 20,
"styleRecalcDurationMs": 43.819999999999986,
"layouts": 20,
"layoutDurationMs": 16.289000000000012,
"taskDurationMs": 4987.034,
"heapDeltaBytes": -6201092,
"heapUsedBytes": 271126892,
"domNodes": -3343,
"jsHeapTotalBytes": 22536192,
"scriptDurationMs": 62.25299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.822289156626507,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7112.687999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6544.004999999998,
"heapDeltaBytes": 4345184,
"heapUsedBytes": 256057692,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 62.30200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.880536912751683,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7127.314999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6660.838,
"heapDeltaBytes": 18797812,
"heapUsedBytes": 281969264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 66.61,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.098310810810805,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 81.25000000001137,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.5089999999999995,
"layouts": 5,
"layoutDurationMs": 1.5799999999999998,
"taskDurationMs": 55.561000000000014,
"heapDeltaBytes": 4660616,
"heapUsedBytes": 64623684,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.268999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 108.12700000008135,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.978000000000001,
"layouts": 8,
"layoutDurationMs": 2.167,
"taskDurationMs": 58.475999999999985,
"heapDeltaBytes": 4583236,
"heapUsedBytes": 64672772,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.9880000000000004,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 271.3370000000168,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.482,
"layouts": 76,
"layoutDurationMs": 13.499,
"taskDurationMs": 235.242,
"heapDeltaBytes": 10273156,
"heapUsedBytes": 51291380,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 104.912,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65882352941178,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 274.04699999999593,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.47800000000000004,
"layouts": 76,
"layoutDurationMs": 12.555,
"taskDurationMs": 221.692,
"heapDeltaBytes": 10159876,
"heapUsedBytes": 51644652,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 100.027,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 333.32800000005136,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3719999999999999,
"layouts": 76,
"layoutDurationMs": 13.382,
"taskDurationMs": 292.419,
"heapDeltaBytes": -825904,
"heapUsedBytes": 92135552,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 106.697,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 326.91799999997784,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.303,
"layouts": 76,
"layoutDurationMs": 12.929,
"taskDurationMs": 285.009,
"heapDeltaBytes": -5333444,
"heapUsedBytes": 79665608,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 105.92,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3134 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e0ce1c0a9a2002b1c406fc9e431b6eecf4bc347d
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (207)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## update-ingest-types #22039 +/- ##
=======================================================
- Coverage 87.28% 87.25% -0.04%
=======================================================
Files 2931 2937 +6
Lines 158734 158965 +231
Branches 41120 41128 +8
=======================================================
+ Hits 138558 138703 +145
- Misses 19306 19391 +85
- Partials 870 871 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
3567d9a to
e0ce1c0
Compare
|
@ryan-di answering your ownership question from Slack: nobody else is integrating #21701 with the billing-core refactor (#22037). It's yours, as you offered. No second writer.
Full context for agent readers
|
|
@ryan-di overlap check against
Suggest closing, unless you want the field required on the client. If so, a small PR on Full context for agent readers
|
Summary
The ingest type sync in #21701 requires
auto_top_up_enabled, but the billing SDK drops that server fact and fixtures omit it. Preserve the served boolean through the SDK snapshot and adapter, and make fixtures contract-complete without activating auto top-up or changing UI behavior.The browser turn-lock fixture also serializes validator-produced
run_approval.doc_seqbigint as a safe wire integer. Generated files and Christian's display-feature repairs are preserved.Stacked on #21701 (
update-ingest-types) to unblock #21545. Latest synce0ce1c0ais normally merged into this branch; the diff is compatibility-only (21 files, +61/-2), and generated files exactly match that base. This does not yet supply #21545'sagent_gratis_local_arm; Cloud #16595 and the normal generated sync remain prerequisites.Verification
0633db5ffebabe8e9cdb3b5f640fc3d18df77787: 113 checks completed (93 success, 20 conditional skips, no failure/pending); all 15 PR workflows succeeded, including full package runtime tests, types and CI browser E2E. Final report publisher succeeded and matches this SHA, PR fix: preserve billing rollout fact across ingest type sync #22039 and E2E source run40456242449. Skipped jobs, including CodeRabbit on this Draft, are not test/review passes.