Skip to content

[backport cloud/1.59] add deployment Start API contracts and typed status - #22542

Closed
benceruleanlu wants to merge 2 commits into
bl/cloud-1.59-compatible-deployment-switchfrom
bl/cloud-1.59-deployment-start-contract
Closed

benceruleanlu wants to merge 2 commits into
bl/cloud-1.59-compatible-deployment-switchfrom
bl/cloud-1.59-deployment-start-contract

Conversation

@benceruleanlu

Copy link
Copy Markdown
Member

Summary

Part 8 of 10 in the Homestead Cloud backport stack. Supplies the contracts needed by the Start/Retry menu: can_start, the deployment-status enum, the started_deployment_id listing query, and the start endpoint response and schemas.

This is a scoped backport of the deployment portions of #21701 and #22216, with the status-fixture preparation from #22211. It keeps the existing 1.59 billing/API content; it does not import the unrelated billing changes in those type updates. Existing deployment fixtures gain the required server field.

Verification

  • Four focused compatibility/model/status suites pass: 108 tests. Normal commit and push checks pass.
  • The expanded stack passes 1,982 tests across 79 files. Remote CI and browser QA on the expanded release-branch build remain pending.

Bring only the deployment contracts from #21701 and #22216 to cloud/1.59, with the status fixture preparation from #22211. Preserve unrelated release-branch API and billing behavior. This supplies the server-owned can_start fact, typed statuses, started-deployment listing query and start response for the #21839 backport.
@benceruleanlu
benceruleanlu requested review from a team and dante01yoon as code owners October 31, 2026 22:39
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T22:40:09.339119Z 470339a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

⚡ Performance: ⚠️ Performance tests failed — check the CI workflow logs

🔬 E2E Coverage: ⚠️ Coverage collection failed — check the CI workflow logs

🎨 Storybook: ❌ Failed

❌ Storybook failed. Open the workflow run and fix the build before merging.

Details

⏰ Completed at: 11/02/2026, 10:32:24 PM UTC

Links

🌾 Fallow: 🟡 Withheld — could not measure

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

Fallow produced no results file — the audit step failed before it could write one.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since b291b23e2b57797e0a45568b8cd7b2c1d608cfcb

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (270)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/syncPromotedComboHostOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchPointerGuards.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/ContextMenu.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 220 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                              Coverage Diff                              @@
##             bl/cloud-1.59-compatible-deployment-switch   #22542   +/-   ##
=============================================================================
  Coverage                                              ?   86.67%           
=============================================================================
  Files                                                 ?     2776           
  Lines                                                 ?   141894           
  Branches                                              ?    43613           
=============================================================================
  Hits                                                  ?   122982           
  Misses                                                ?    17925           
  Partials                                              ?      987           
Flag Coverage Δ
billing-web-unit 92.14% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

datadog-official Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 25 Pipeline jobs failed

CI: Billing Web E2E | billing-web-e2e

View in Datadog · View in GitHub Actions

CI: Billing Web E2E | billing-web-e2e-gate

View in Datadog · View in GitHub Actions

CI: Billing Web Unit | billing-web-unit

View in Datadog · View in GitHub Actions

View all 25 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 799d0b4 | Docs | View more details | Give us feedback!

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 31, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport approval: LGTM.

…59.3 bump

`lint-pr / lint` fails on this carrier with

    'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
    message resources  @intlify/vue-i18n/no-missing-keys

in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.

The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.

Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.

(cherry picked from commit a358582)
@benceruleanlu
benceruleanlu removed this pull request from stack #22540 November 2, 2026 23:54
@benceruleanlu

Copy link
Copy Markdown
Member Author

Closing: this layer has nothing left to carry. #22027 landed the same Start API contract and fixture updates on cloud/1.59, and the fixtures earlier layers added now carry can_start in those layers. #22543 now sits directly on #22539.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants