Repository navigation
[backport cloud/1.59] add deployment Start API contracts and typed status - #22542
benceruleanlu wants to merge 2 commits into
Conversation
Bring only the deployment contracts from #21701 and #22216 to cloud/1.59, with the status fixture preparation from #22211. Preserve unrelated release-branch API and billing behavior. This supplies the server-owned can_start fact, typed statuses, started-deployment listing query and start response for the #21839 backport.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## bl/cloud-1.59-compatible-deployment-switch #22542 +/- ##
=============================================================================
Coverage ? 86.67%
=============================================================================
Files ? 2776
Lines ? 141894
Branches ? 43613
=============================================================================
Hits ? 122982
Misses ? 17925
Partials ? 987
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 25 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 799d0b4 | Docs | View more details | Give us feedback! |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport approval: LGTM.
…59.3 bump
`lint-pr / lint` fails on this carrier with
'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization
message resources @intlify/vue-i18n/no-missing-keys
in `src/components/graph/selectionToolbox/Load3DViewerButton.vue`, which
fails `preflight` and so reports `lint-and-format`, `test` and `e2e-status`
as failures without any of them running.
The failure is inherited, not introduced here: the component, the catalog and
the ESLint config are byte-identical to `cloud/1.59`, and the sibling carrier
#22538 fails on the same two lines. The key was restored on `cloud/1.59` by
#22130 and the 1.59.3 version bump (#22137) regenerated the locale JSON and
dropped it again.
Restores the same three lines, so `src/locales/en/commands.json` is now
byte-identical (blob 412dbd0) to the tree #22130 merged. No product
behavior changes.
(cherry picked from commit a358582)
Summary
Part 8 of 10 in the Homestead Cloud backport stack. Supplies the contracts needed by the Start/Retry menu:
can_start, the deployment-status enum, thestarted_deployment_idlisting query, and the start endpoint response and schemas.This is a scoped backport of the deployment portions of #21701 and #22216, with the status-fixture preparation from #22211. It keeps the existing 1.59 billing/API content; it does not import the unrelated billing changes in those type updates. Existing deployment fixtures gain the required server field.
Verification