Repository navigation
[chore] Update Ingest API types from cloud@99f52fc1 - #21746
Conversation
Regenerate @comfyorg/ingest-types from Comfy-Org/cloud@99f52fc1, which adds the required period_charge_cents to each Team credit stop price in GET /api/billing/plans (cloud#15376). The billing SDK projection now reads period_charge_cents back from int64 like the other stop amounts, and the billing test fixtures carry the new field. No behavior change: nothing reads period_charge_cents yet.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
Hold: do not merge (or backport) until cloud#15376 is deployed to every backend this build talks to.
Back to ready for review once prod (and the 1.58 backends) return the field. Screenshots for #21748 are blocked on the same deploy. |
|
Hold lifted. As of 2026-10-23 04:25 UTC prod |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 7 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 24dc1cd | Docs | View more details | Give us feedback! |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T04:40:19.875Z",
"gitSha": "3b87f02359556c48c038e51a78177224033febfa",
"branch": "dante/ingest-types-period-charge",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.0190000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.272,
"layouts": 9,
"layoutDurationMs": 2.124,
"taskDurationMs": 533.4639999999999,
"heapDeltaBytes": 3614068,
"heapUsedBytes": 78190152,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.923999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.5269999999919,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.725999999999999,
"layouts": 9,
"layoutDurationMs": 2.8270000000000004,
"taskDurationMs": 536.787,
"heapDeltaBytes": 3506672,
"heapUsedBytes": 78417312,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 9.418000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1959.0900000000033,
"styleRecalcs": 83,
"styleRecalcDurationMs": 13.789000000000003,
"layouts": 9,
"layoutDurationMs": 2.5749999999999997,
"taskDurationMs": 1089.024,
"heapDeltaBytes": -4683420,
"heapUsedBytes": 70460392,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 163.062,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666949152542376,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.2920000000122,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.512,
"layouts": 10,
"layoutDurationMs": 2.611,
"taskDurationMs": 892.0089999999999,
"heapDeltaBytes": -4713448,
"heapUsedBytes": 70035764,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 163.89,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.3239999999814,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.9239999999999995,
"layouts": 10,
"layoutDurationMs": 3.4110000000000005,
"taskDurationMs": 472.11800000000005,
"heapDeltaBytes": -1912516,
"heapUsedBytes": 72582388,
"domNodes": 56,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 14.100999999999996,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.6610000000537,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.393999999999999,
"layouts": 10,
"layoutDurationMs": 2.3240000000000003,
"taskDurationMs": 409.27900000000005,
"heapDeltaBytes": -1926536,
"heapUsedBytes": 72913288,
"domNodes": 56,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.777000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 709.6049999999536,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.743,
"layouts": 9,
"layoutDurationMs": 2.4709999999999996,
"taskDurationMs": 497.932,
"heapDeltaBytes": 2352644,
"heapUsedBytes": 77009388,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 170.736,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 712.2789999999668,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.771,
"layouts": 6,
"layoutDurationMs": 1.572,
"taskDurationMs": 507.965,
"heapDeltaBytes": 3268852,
"heapUsedBytes": 77993300,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.60500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1188.9449999999897,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 878.562,
"heapDeltaBytes": 23364996,
"heapUsedBytes": 102417576,
"domNodes": 0,
"jsHeapTotalBytes": 19824640,
"scriptDurationMs": 75.597,
"eventListeners": 0,
"totalBlockingTimeMs": 541,
"frameDurationMs": 34.8,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1158.2189999999173,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 836.481,
"heapDeltaBytes": 23752504,
"heapUsedBytes": 102183120,
"domNodes": 0,
"jsHeapTotalBytes": 20348928,
"scriptDurationMs": 66.78099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 510,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 876.6069999999786,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.9310000000004,
"heapDeltaBytes": -4405368,
"heapUsedBytes": 86004740,
"domNodes": 0,
"jsHeapTotalBytes": 3674112,
"scriptDurationMs": 166.53699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 229,
"frameDurationMs": 25.240000000000016,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.7670000000626,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.4910000000003,
"heapDeltaBytes": -3983056,
"heapUsedBytes": 86139904,
"domNodes": 0,
"jsHeapTotalBytes": 3674112,
"scriptDurationMs": 158.43200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11868.19700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11051.911,
"heapDeltaBytes": 8669368,
"heapUsedBytes": 99705112,
"domNodes": -141,
"jsHeapTotalBytes": 12709888,
"scriptDurationMs": 9050.142000000002,
"eventListeners": -49,
"totalBlockingTimeMs": 1833,
"frameDurationMs": 33.33174157303372,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10098.217999999975,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.30100000000000005,
"layouts": 1,
"layoutDurationMs": 0.23900000000000007,
"taskDurationMs": 9294.222999999998,
"heapDeltaBytes": -3916532,
"heapUsedBytes": 86839244,
"domNodes": -141,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 7404.446,
"eventListeners": -53,
"totalBlockingTimeMs": 729,
"frameDurationMs": 31.171913580246915,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10893.089999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10034.47,
"heapDeltaBytes": -7074080,
"heapUsedBytes": 83696916,
"domNodes": -141,
"jsHeapTotalBytes": 12709888,
"scriptDurationMs": 8149.434000000001,
"eventListeners": -53,
"totalBlockingTimeMs": 1184,
"frameDurationMs": 30.87705382436261,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10767.987999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9964.451000000001,
"heapDeltaBytes": -14130748,
"heapUsedBytes": 76492036,
"domNodes": -141,
"jsHeapTotalBytes": 9564160,
"scriptDurationMs": 8099.463,
"eventListeners": -49,
"totalBlockingTimeMs": 999,
"frameDurationMs": 31.57243401759531,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 214.20599999999013,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.264000000000001,
"layouts": 11,
"layoutDurationMs": 3.2540000000000004,
"taskDurationMs": 167.027,
"heapDeltaBytes": 14554732,
"heapUsedBytes": 89026280,
"domNodes": 936,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.097,
"eventListeners": 205,
"totalBlockingTimeMs": 6,
"frameDurationMs": 27.075000000000045,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 256.48499999999785,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.668999999999999,
"layouts": 11,
"layoutDurationMs": 3.62,
"taskDurationMs": 197.99599999999998,
"heapDeltaBytes": 14545368,
"heapUsedBytes": 89879832,
"domNodes": 936,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 10.346,
"eventListeners": 205,
"totalBlockingTimeMs": 17,
"frameDurationMs": 27.77777777777778,
"p95FrameDurationMs": 116.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2019.0279999999916,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6749999999999994,
"layouts": 8,
"layoutDurationMs": 1.9140000000000001,
"taskDurationMs": 618.5670000000001,
"heapDeltaBytes": -7776784,
"heapUsedBytes": 84501088,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 31.491999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.9459999999472,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.078,
"layouts": 8,
"layoutDurationMs": 1.8069999999999997,
"taskDurationMs": 618.8410000000001,
"heapDeltaBytes": -7191012,
"heapUsedBytes": 85140252,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 33.577999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2454.98299999997,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.345,
"layouts": 7,
"layoutDurationMs": 1.85,
"taskDurationMs": 1699.18,
"heapDeltaBytes": -4892744,
"heapUsedBytes": 88488748,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 822.1480000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78013698630137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2614.021999999977,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.946999999999999,
"layouts": 5,
"layoutDurationMs": 1.2799999999999998,
"taskDurationMs": 1730.4840000000002,
"heapDeltaBytes": -5175600,
"heapUsedBytes": 88215940,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 836.524,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.773717948717948,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3929.230999999959,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.953,
"layouts": 64,
"layoutDurationMs": 10.575999999999999,
"taskDurationMs": 1800.2369999999999,
"heapDeltaBytes": 5459264,
"heapUsedBytes": 77755948,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 795.83,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73659574468085,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3885.032000000024,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.89,
"layouts": 64,
"layoutDurationMs": 10.657,
"taskDurationMs": 1790.594,
"heapDeltaBytes": 5788112,
"heapUsedBytes": 78849012,
"domNodes": 24,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 811.9,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.737931034482763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3025.1609999999687,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.868000000000001,
"layouts": 5,
"layoutDurationMs": 1.4989999999999999,
"taskDurationMs": 1986.2219999999998,
"heapDeltaBytes": 20411240,
"heapUsedBytes": 93399828,
"domNodes": 0,
"jsHeapTotalBytes": 4349952,
"scriptDurationMs": 963.546,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.946629213483146,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3153.709000000049,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.102,
"layouts": 4,
"layoutDurationMs": 1.0170000000000001,
"taskDurationMs": 2036.3289999999997,
"heapDeltaBytes": 22525920,
"heapUsedBytes": 95569444,
"domNodes": 0,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 998.751,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.93621621621622,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.7300000000141,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8770000000000002,
"layouts": 7,
"layoutDurationMs": 1.914,
"taskDurationMs": 603.5889999999999,
"heapDeltaBytes": -6522168,
"heapUsedBytes": 87313196,
"domNodes": 0,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 32.543,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.908000000034,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7309999999999999,
"layouts": 7,
"layoutDurationMs": 1.818,
"taskDurationMs": 595.583,
"heapDeltaBytes": 15671952,
"heapUsedBytes": 87760256,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 31.007999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 655.9570000000008,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.280999999999999,
"layouts": 9,
"layoutDurationMs": 2.232,
"taskDurationMs": 481.88599999999997,
"heapDeltaBytes": -3064840,
"heapUsedBytes": 73825176,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 146.93200000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 690.672999999947,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.576000000000001,
"layouts": 9,
"layoutDurationMs": 2.0359999999999996,
"taskDurationMs": 484.12699999999995,
"heapDeltaBytes": -1174884,
"heapUsedBytes": 76361672,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 144.80800000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.206999999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.015,
"layouts": 10,
"layoutDurationMs": 2.6510000000000007,
"taskDurationMs": 549.3950000000001,
"heapDeltaBytes": 3086040,
"heapUsedBytes": 79933352,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 8.886,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.3119999999562,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4949999999999997,
"layouts": 10,
"layoutDurationMs": 3.1170000000000004,
"taskDurationMs": 540.992,
"heapDeltaBytes": 3386924,
"heapUsedBytes": 80731244,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 7.397000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.928000000034,
"styleRecalcs": 87,
"styleRecalcDurationMs": 15.110000000000001,
"layouts": 11,
"layoutDurationMs": 3.1069999999999998,
"taskDurationMs": 1076.461,
"heapDeltaBytes": -8022908,
"heapUsedBytes": 68410104,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 110.752,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.1199999999708,
"styleRecalcs": 87,
"styleRecalcDurationMs": 12.842,
"layouts": 9,
"layoutDurationMs": 2.147,
"taskDurationMs": 1044.073,
"heapDeltaBytes": -8457776,
"heapUsedBytes": 68395964,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 102.87100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.7990000000036,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.543000000000003,
"layouts": 5,
"layoutDurationMs": 16.222000000000005,
"taskDurationMs": 1084.809,
"heapDeltaBytes": 8995708,
"heapUsedBytes": 109910044,
"domNodes": 16030,
"jsHeapTotalBytes": 16388096,
"scriptDurationMs": 32.37400000000001,
"eventListeners": 3246,
"totalBlockingTimeMs": 179,
"frameDurationMs": 20.090410958904116,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10213.974000000007,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.211,
"layouts": 6,
"layoutDurationMs": 1.503,
"taskDurationMs": 6297.314,
"heapDeltaBytes": -25177756,
"heapUsedBytes": 67797196,
"domNodes": -141,
"jsHeapTotalBytes": 8028160,
"scriptDurationMs": 2916.2180000000003,
"eventListeners": -51,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.720458265139115,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10164.055000000077,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.080999999999996,
"layouts": 7,
"layoutDurationMs": 1.8109999999999997,
"taskDurationMs": 6280.505000000001,
"heapDeltaBytes": 160388,
"heapUsedBytes": 92460748,
"domNodes": -141,
"jsHeapTotalBytes": 6385664,
"scriptDurationMs": 2869.946,
"eventListeners": -47,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.720922570016477,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22900.634999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22354.155,
"heapDeltaBytes": -12176472,
"heapUsedBytes": 272716404,
"domNodes": -3245,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 316.921,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.54922279792746,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22570.275000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21647.397999999997,
"heapDeltaBytes": -25542084,
"heapUsedBytes": 279051052,
"domNodes": -3245,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 307.33500000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.44241908006814,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28127.937999999973,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.86099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27667.082000000006,
"heapDeltaBytes": -282608,
"heapUsedBytes": 285183248,
"domNodes": -3245,
"jsHeapTotalBytes": 27525120,
"scriptDurationMs": 901.154,
"eventListeners": -651,
"totalBlockingTimeMs": 31,
"frameDurationMs": 51.056442831215975,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27789.91999999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.47299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27412.466999999997,
"heapDeltaBytes": -4346828,
"heapUsedBytes": 276538340,
"domNodes": -3245,
"jsHeapTotalBytes": 22020096,
"scriptDurationMs": 884.5939999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 30,
"frameDurationMs": 50.976513761467885,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8131.3069999999925,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.66700000000002,
"layouts": 20,
"layoutDurationMs": 22.962999999999983,
"taskDurationMs": 8034.283000000002,
"heapDeltaBytes": 10250748,
"heapUsedBytes": 294778104,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 121.42999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.94915254237287,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7845.425000000091,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.08599999999998,
"layouts": 20,
"layoutDurationMs": 21.438999999999986,
"taskDurationMs": 7739.797,
"heapDeltaBytes": 10198104,
"heapUsedBytes": 295817872,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 114.241,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.904678362573094,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11363.442000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10914.057999999999,
"heapDeltaBytes": -2316248,
"heapUsedBytes": 289175944,
"domNodes": -3245,
"jsHeapTotalBytes": 18350080,
"scriptDurationMs": 169.23299999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.660544217687075,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11373.219999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11064.216,
"heapDeltaBytes": -20050864,
"heapUsedBytes": 266865712,
"domNodes": -3245,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 174.35299999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.19379310344828,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 482.73600000004535,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.338999999999999,
"layouts": 11,
"layoutDurationMs": 3.8329999999999997,
"taskDurationMs": 136.772,
"heapDeltaBytes": 7361408,
"heapUsedBytes": 79800360,
"domNodes": 138,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.364,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 130.57600000001912,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.912,
"layouts": 8,
"layoutDurationMs": 2.888,
"taskDurationMs": 89.40100000000001,
"heapDeltaBytes": 4726592,
"heapUsedBytes": 77122332,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.133999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 500.3190000001041,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.674,
"layouts": 76,
"layoutDurationMs": 15.589,
"taskDurationMs": 449.181,
"heapDeltaBytes": -4220752,
"heapUsedBytes": 39185760,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 215.79999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 366.8400000000247,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.628,
"layouts": 76,
"layoutDurationMs": 13.074,
"taskDurationMs": 325.27099999999996,
"heapDeltaBytes": -5997544,
"heapUsedBytes": 39565928,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 150.99200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 590.4699999999821,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.896,
"layouts": 76,
"layoutDurationMs": 16.499,
"taskDurationMs": 562.3280000000001,
"heapDeltaBytes": 1142476,
"heapUsedBytes": 104683552,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 235.766,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777762,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 692.8799999999455,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.458,
"layouts": 76,
"layoutDurationMs": 16.398,
"taskDurationMs": 648.6390000000001,
"heapDeltaBytes": 2272444,
"heapUsedBytes": 94289212,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 271.675,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414634,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 3068 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7c705c8aad8007a6fefecc44826139ee353da34b
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (156)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21746 +/- ##
==========================================
- Coverage 86.65% 86.65% -0.01%
==========================================
Files 3906 3906
Lines 181968 181972 +4
Branches 47414 49555 +2141
==========================================
- Hits 157692 157686 -6
- Misses 21821 21831 +10
Partials 2455 2455
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved. The generated period_charge_cents contract, safe-number projection, and fixture updates match the billing amount served by Cloud PR 15376.
Tab-local workspace selection is unchanged.
Full context for agent readers
The production plans response now carries the required field on every Team stop. The projection rejects values outside JavaScript's safe integer range, and the uneven yearly fixture proves the server-owned charge survives decoding without being re-derived in the frontend.
The production plans response supplies this field before the frontend schema begins requiring it, so the pricing dialog does not lose its catalog during rollout.
|
@dante01yoon Successfully backported to #21780 |
|
@dante01yoon Successfully backported to #21781 |
Summary
Why
cloud#15376 (merged as Comfy-Org/cloud@99f52fc1) adds the required
period_charge_centsto each Team credit stop price inGET /api/billing/plans. FE-3587 needs it, and the bot sync (#21701) has not picked up that commit yet. Because the field is required, regenerating the types breaks the billing fixtures that build stop prices by hand, so this PR fixes that fallout too (the same thing the cloud PR description calls out).Root cause
period_charge_centsis not in@comfyorg/ingest-typesyet, so nothing on the frontend can read the charge the server bills.How
packages/ingest-typesfrom cloud@99f52fc1 with the same steps as the bot:openapi-project -fe→pnpm generate→oxfmt.billingPlansView.ts) readsperiod_charge_centsback from int64 like the other stop amounts, and refuses a stop whose charge does not fit a number.price_cents, yearly =price_cents × 12, so no existing test expectation changes.billingPlansView.test.tsuses an uneven yearly charge to prove the projection carries the server value.period_charge_cents: against a backend without cloud#15376 the billing SDK's plans read fails validation and the pricing dialog cannot load. Merge only after every backend this build talks to serves the field (see the hold comment). Nothing displays the field until FE-3587 (stacked on this PR).AS IS / TO BE
No UI change in this PR; the visible fix and its screenshots are in the stacked FE-3587 PR.
Verification
pnpm typecheck,pnpm typecheck:billing-web,pnpm typecheck:browser: 0 errors (11 files failed on the regenerated types before the fixture fix).checkoutRequest/CheckoutView(85 tests) pass.Where this sits in the plan