Repository navigation
[backport core/1.57] fix(agent): declare every node's widget form at the Agent boundary (#21479) - #21533
Conversation
…21479) ## Summary A human `add_node` for a class the doc host's pinned catalog lacks is refused (`uncatalogued_widget_write`) even when the frontend definition describes every widget. The minter decided whether to declare `widgets_values_form` by asking whether the frontend definition covered the widgets, and that check cannot see the host's catalog. `wireNodeSnapshot` now declares the form from the live widget order for every non-virtual node with value widgets. All of the change stays in the Agent minter. ```text wireNodeSnapshot(node) values = value widgets from widgets_values_named no form when the definition has a dynamic combo, dynamic group, or autogrow input no form when a widget name is empty or repeated otherwise form = { order: live widget names that have values } ``` - The dynamic-layout skip is needed only until a comfy-multi-player release that contains Comfy-Org/comfy-multi-player#288 is pinned. Removing it then means deleting one condition. - This is an alternative to #21329. It fixes the same add-node refusal without adding inference, validation, a policy seam, or a `widgets_values_form` field to core serialization. - Not in scope: the posted turn draft still carries no form, which is the separate client-seed recapture ticket. Because more nodes now carry a form, that recapture mismatch affects more documents than before. Linear: FE-3470 ## Verification - Unit: the minter's A24 tests cover declaring and declining the form, real widget constructors, a carried-in projection form, applier acceptance when the catalog lacks the class or lists no widgets, and a catalogued dynamic combo that stays writable after its selection changes. The described-class and closed-order cases fail against the old minter. Removing the dynamic skip, the closed-order check, or the live widget ordering each fails its own rows. - Browser (`--project=cloud`, local backend): the new widget-form round trip fails on `main` (the host refuses the node and it leaves the canvas) and passes here. The rejected-add case now adds an uncatalogued dynamic-combo class, which is still refused, and passes. A sweep of the human-add, tab-switch, ghost-flag, draft, dynamic-combo, overflow, undo and opaque-write Agent specs passed. - The full Agent extension Vitest suite passes. (cherry picked from commit c5b5521)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-21T07:29:33.409Z",
"gitSha": "ac8aa0af92fa3c60078bd5a24df7aa83f859f97f",
"branch": "backport-21479-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.6590000000228,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.797,
"layouts": 9,
"layoutDurationMs": 1.888,
"taskDurationMs": 412.215,
"heapDeltaBytes": -867268,
"heapUsedBytes": 74536692,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 8.41,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.2189999999732,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.9230000000000003,
"layouts": 10,
"layoutDurationMs": 1.721,
"taskDurationMs": 408.105,
"heapDeltaBytes": 2988352,
"heapUsedBytes": 78545980,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 8.603,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.8740000000134,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.862,
"layouts": 10,
"layoutDurationMs": 2.105,
"taskDurationMs": 678.2589999999999,
"heapDeltaBytes": 15629604,
"heapUsedBytes": 81785616,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 116.18599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.7320000000013,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.199,
"layouts": 9,
"layoutDurationMs": 1.572,
"taskDurationMs": 538.141,
"heapDeltaBytes": 15566372,
"heapUsedBytes": 82251588,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 109.123,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.4739999999629,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.39,
"layouts": 13,
"layoutDurationMs": 2.7269999999999994,
"taskDurationMs": 251.015,
"heapDeltaBytes": 18281116,
"heapUsedBytes": 84839196,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.176,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.4109999999846,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.153,
"layouts": 12,
"layoutDurationMs": 2.1310000000000002,
"taskDurationMs": 316.01500000000004,
"heapDeltaBytes": -325580,
"heapUsedBytes": 74655136,
"domNodes": 47,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 9.563,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 592.788999999982,
"styleRecalcs": 15,
"styleRecalcDurationMs": 1.9509999999999996,
"layouts": 10,
"layoutDurationMs": 1.8030000000000002,
"taskDurationMs": 425.879,
"heapDeltaBytes": 1982288,
"heapUsedBytes": 77248940,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 133.829,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669444444444455,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 564.8600000000101,
"styleRecalcs": 12,
"styleRecalcDurationMs": 1.5060000000000004,
"layouts": 8,
"layoutDurationMs": 1.5290000000000001,
"taskDurationMs": 393.87699999999995,
"heapDeltaBytes": -1031196,
"heapUsedBytes": 65179024,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 127.14200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696968,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1168.799999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 822.0079999999999,
"heapDeltaBytes": -4222824,
"heapUsedBytes": 81364536,
"domNodes": -192,
"jsHeapTotalBytes": 15474688,
"scriptDurationMs": 52.81899999999999,
"eventListeners": -105,
"totalBlockingTimeMs": 492,
"frameDurationMs": 32.405555555555566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1039.9899999999889,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.454,
"heapDeltaBytes": -11918312,
"heapUsedBytes": 81067956,
"domNodes": -192,
"jsHeapTotalBytes": 22028288,
"scriptDurationMs": 44.02199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 389,
"frameDurationMs": 29.163888888888906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 745.4780000000483,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.48700000000025,
"heapDeltaBytes": -5197844,
"heapUsedBytes": 75341104,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 110.65300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 130,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 749.2880000000355,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.4400000000003,
"heapDeltaBytes": -4957360,
"heapUsedBytes": 74788416,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 102.941,
"eventListeners": 0,
"totalBlockingTimeMs": 120,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6981.2099999999755,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6178.28,
"heapDeltaBytes": -14408724,
"heapUsedBytes": 85494320,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 4750.112,
"eventListeners": -68,
"totalBlockingTimeMs": 99,
"frameDurationMs": 25.177857142857142,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6250.637000000041,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.39099999999999985,
"layouts": 2,
"layoutDurationMs": 0.3930000000000001,
"taskDurationMs": 5448.161,
"heapDeltaBytes": -1180772,
"heapUsedBytes": 98749856,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 4400.3730000000005,
"eventListeners": -64,
"totalBlockingTimeMs": 29,
"frameDurationMs": 25.099598393574297,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6924.751999999955,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.7200000000000002,
"layouts": 4,
"layoutDurationMs": 0.8799999999999997,
"taskDurationMs": 6149.94,
"heapDeltaBytes": -2458444,
"heapUsedBytes": 91653224,
"domNodes": -278,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 4722.815,
"eventListeners": -68,
"totalBlockingTimeMs": 77,
"frameDurationMs": 25.210909090909087,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6880.417999999963,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.31500000000000017,
"layouts": 2,
"layoutDurationMs": 0.3910000000000003,
"taskDurationMs": 6234.934,
"heapDeltaBytes": -21441252,
"heapUsedBytes": 78182728,
"domNodes": -258,
"jsHeapTotalBytes": 9564160,
"scriptDurationMs": 4834.9800000000005,
"eventListeners": -67,
"totalBlockingTimeMs": 35,
"frameDurationMs": 24.848736462093864,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 181.17300000000114,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.762999999999998,
"layouts": 12,
"layoutDurationMs": 3.2449999999999997,
"taskDurationMs": 136.15399999999997,
"heapDeltaBytes": -7971852,
"heapUsedBytes": 80028656,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7.412999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.92500000000001,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 169.94200000004867,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.136000000000001,
"layouts": 10,
"layoutDurationMs": 2.479,
"taskDurationMs": 122.13499999999999,
"heapDeltaBytes": 13097912,
"heapUsedBytes": 92185092,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.713,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.825000000000045,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2042.4229999999852,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.497,
"layouts": 9,
"layoutDurationMs": 1.6010000000000002,
"taskDurationMs": 397.964,
"heapDeltaBytes": -1789024,
"heapUsedBytes": 77306392,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 27.818,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.637000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5770000000000002,
"layouts": 9,
"layoutDurationMs": 1.632,
"taskDurationMs": 503.6989999999999,
"heapDeltaBytes": -25072712,
"heapUsedBytes": 73124544,
"domNodes": -258,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 26.573999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2184.032000000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 4.415,
"layouts": 7,
"layoutDurationMs": 1.2609999999999997,
"taskDurationMs": 1297.641,
"heapDeltaBytes": -8348652,
"heapUsedBytes": 71419192,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 606.467,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564885496183,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2134.3950000000405,
"styleRecalcs": 69,
"styleRecalcDurationMs": 4.089,
"layouts": 8,
"layoutDurationMs": 1.388,
"taskDurationMs": 1234.587,
"heapDeltaBytes": -30240160,
"heapUsedBytes": 68084336,
"domNodes": -258,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 565.378,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666406249999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3236.8230000000153,
"styleRecalcs": 72,
"styleRecalcDurationMs": 6.9079999999999995,
"layouts": 65,
"layoutDurationMs": 10.501,
"taskDurationMs": 1366.021,
"heapDeltaBytes": 23122472,
"heapUsedBytes": 100609784,
"domNodes": 24,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 599.645,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752849740932643,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3158.1449999999904,
"styleRecalcs": 73,
"styleRecalcDurationMs": 6.217,
"layouts": 67,
"layoutDurationMs": 9.654,
"taskDurationMs": 1171.79,
"heapDeltaBytes": -4361508,
"heapUsedBytes": 78200028,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 542.124,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754787234042556,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2193.2290000000307,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.2579999999999996,
"layouts": 6,
"layoutDurationMs": 1.049,
"taskDurationMs": 1436.922,
"heapDeltaBytes": 3171780,
"heapUsedBytes": 81349732,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 674.4030000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.794615384615383,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2355.645000000095,
"styleRecalcs": 49,
"styleRecalcDurationMs": 3.5469999999999997,
"layouts": 7,
"layoutDurationMs": 1.3450000000000002,
"taskDurationMs": 1459.857,
"heapDeltaBytes": 958004,
"heapUsedBytes": 78878812,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 677.855,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.905035971223022,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.046000000023,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.3419999999999994,
"layouts": 7,
"layoutDurationMs": 1.486,
"taskDurationMs": 528.6119999999999,
"heapDeltaBytes": -2505452,
"heapUsedBytes": 79175168,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 34.07399999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.7039999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5390000000000004,
"layouts": 9,
"layoutDurationMs": 1.6959999999999997,
"taskDurationMs": 389.382,
"heapDeltaBytes": -5795304,
"heapUsedBytes": 76445184,
"domNodes": -278,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 26.011000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 430.59699999997747,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.326000000000001,
"layouts": 10,
"layoutDurationMs": 1.865,
"taskDurationMs": 288.40700000000004,
"heapDeltaBytes": 21641020,
"heapUsedBytes": 88865524,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 108.78699999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230772,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 432.337000000075,
"styleRecalcs": 48,
"styleRecalcDurationMs": 3.256000000000001,
"layouts": 10,
"layoutDurationMs": 1.776,
"taskDurationMs": 282.77000000000004,
"heapDeltaBytes": 21643516,
"heapUsedBytes": 88564624,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 101.76,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2020.1599999999758,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.3420000000000005,
"layouts": 10,
"layoutDurationMs": 2.085,
"taskDurationMs": 454.63599999999997,
"heapDeltaBytes": -19357104,
"heapUsedBytes": 57485900,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.9300000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.6960000000527,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.6539999999999992,
"layouts": 9,
"layoutDurationMs": 1.782,
"taskDurationMs": 295.128,
"heapDeltaBytes": 22349432,
"heapUsedBytes": 89409908,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.474000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1961.8919999999775,
"styleRecalcs": 86,
"styleRecalcDurationMs": 13.606000000000002,
"layouts": 9,
"layoutDurationMs": 1.727,
"taskDurationMs": 866.973,
"heapDeltaBytes": 11727588,
"heapUsedBytes": 78503476,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 80.139,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.0579999999645,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.719,
"layouts": 9,
"layoutDurationMs": 1.577,
"taskDurationMs": 498.908,
"heapDeltaBytes": 11248180,
"heapUsedBytes": 78754212,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 74.516,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1100.4469999999742,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.654,
"layouts": 5,
"layoutDurationMs": 11.257,
"taskDurationMs": 818.883,
"heapDeltaBytes": 7181284,
"heapUsedBytes": 103733800,
"domNodes": 15953,
"jsHeapTotalBytes": 17436672,
"scriptDurationMs": 21.538999999999994,
"eventListeners": 3244,
"totalBlockingTimeMs": 131,
"frameDurationMs": 19.939285714285706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8210.056000000008,
"styleRecalcs": 250,
"styleRecalcDurationMs": 14.804000000000002,
"layouts": 9,
"layoutDurationMs": 1.6969999999999996,
"taskDurationMs": 3979.9489999999996,
"heapDeltaBytes": 3971700,
"heapUsedBytes": 83037444,
"domNodes": -258,
"jsHeapTotalBytes": 2973696,
"scriptDurationMs": 1963.5259999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666125760649088,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8259.085999999912,
"styleRecalcs": 251,
"styleRecalcDurationMs": 11.347000000000001,
"layouts": 9,
"layoutDurationMs": 1.7069999999999999,
"taskDurationMs": 4311.769,
"heapDeltaBytes": -515932,
"heapUsedBytes": 79188528,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 1857.427,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17363.474999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16681.395,
"heapDeltaBytes": -8197860,
"heapUsedBytes": 274025196,
"domNodes": -3330,
"jsHeapTotalBytes": 6017024,
"scriptDurationMs": 254.85199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.362500000000004,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 16561.85199999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15637.783,
"heapDeltaBytes": -32709580,
"heapUsedBytes": 257725372,
"domNodes": -3330,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 251.021,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.03028764805414,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 20448.492999999984,
"styleRecalcs": 164,
"styleRecalcDurationMs": 14.382000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20047.176,
"heapDeltaBytes": 457860,
"heapUsedBytes": 276608856,
"domNodes": -3330,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 861.775,
"eventListeners": -651,
"totalBlockingTimeMs": 94,
"frameDurationMs": 37.97862453531598,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 20162.39100000007,
"styleRecalcs": 163,
"styleRecalcDurationMs": 13.779999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19793.616,
"heapDeltaBytes": -21354532,
"heapUsedBytes": 279033724,
"domNodes": -3330,
"jsHeapTotalBytes": 9883648,
"scriptDurationMs": 737.5390000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.40054151624549,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5728.61800000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.319,
"layouts": 20,
"layoutDurationMs": 20.058999999999994,
"taskDurationMs": 5565.441,
"heapDeltaBytes": 10855820,
"heapUsedBytes": 282691456,
"domNodes": -3330,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 104.142,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.47954545454546,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6214.519999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.14899999999997,
"layouts": 20,
"layoutDurationMs": 20.981000000000012,
"taskDurationMs": 6094.204000000001,
"heapDeltaBytes": -31413628,
"heapUsedBytes": 259557192,
"domNodes": -3330,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 121.103,
"eventListeners": -653,
"totalBlockingTimeMs": 7,
"frameDurationMs": 35.7264367816092,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8199.381000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7571.1889999999985,
"heapDeltaBytes": 18811252,
"heapUsedBytes": 277563792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.54999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.608754208754213,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6041.979999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5548.124,
"heapDeltaBytes": -18827468,
"heapUsedBytes": 251384024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 84.71400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.032450331125826,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 472.6400000000126,
"styleRecalcs": 19,
"styleRecalcDurationMs": 9.165,
"layouts": 10,
"layoutDurationMs": 2.8640000000000003,
"taskDurationMs": 109.50799999999998,
"heapDeltaBytes": 7021720,
"heapUsedBytes": 79762996,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.383999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 447.4390000000312,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.450000000000001,
"layouts": 12,
"layoutDurationMs": 2.869,
"taskDurationMs": 94.47,
"heapDeltaBytes": 6583804,
"heapUsedBytes": 79592928,
"domNodes": 95,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.544,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 309.0359999999919,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9859999999999999,
"layouts": 76,
"layoutDurationMs": 12.655,
"taskDurationMs": 264.123,
"heapDeltaBytes": -9760272,
"heapUsedBytes": 84420744,
"domNodes": 4,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 116.72200000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 342.08799999998973,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.972,
"layouts": 76,
"layoutDurationMs": 13.469,
"taskDurationMs": 295.046,
"heapDeltaBytes": -21263688,
"heapUsedBytes": 71893476,
"domNodes": 4,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 133.76,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 374.75799999992887,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.824,
"layouts": 76,
"layoutDurationMs": 12.584,
"taskDurationMs": 342.128,
"heapDeltaBytes": 9560832,
"heapUsedBytes": 163008100,
"domNodes": 4,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 124.565,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.672727272727283,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 334.1880000000401,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.739,
"layouts": 76,
"layoutDurationMs": 12.657,
"taskDurationMs": 299.197,
"heapDeltaBytes": -1281748,
"heapUsedBytes": 129361132,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.80599999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge. Fix the failing shards and re-run coverage before using these totals for comparison. Line coverage: 64.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2280 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1cec39f76532e00c6b3eab9f86b49cf4f6ca5af6
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21533 +/- ##
==========================================
Coverage 85.80% 85.80%
==========================================
Files 2701 2701
Lines 151833 151826 -7
Branches 40536 40532 -4
==========================================
- Hits 130280 130275 -5
+ Misses 21165 21163 -2
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: d27a1ed | Docs | View more details | Give us feedback! |
… the Agent boundary (#21479) (#21534) ## Summary Backport of #21479 to `cloud/1.57` (FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter now declares `widgets_values_form` from the live widget order. Clean `cherry-pick -x` of merge commit c5b5521, no conflict resolution. Patch is identical to the source (`git patch-id --stable` matches). Builds on #21338 (the PM-2003 backport of #21245), already on `cloud/1.57`. `@comfyorg/comfy-multi-player` is `0.3.10` on `main` at the source merge and on `cloud/1.57`, so no pin change is bundled. <details><summary>Full context for agent readers</summary> - Source: #21479 by @DrJKL, merged 2026-10-20T21:41:40Z. - Target tip at cherry-pick: `e0427c3a607552aa567c549330342300475b46d2`. The source merge commit was not an ancestor of `cloud/1.57`, and no carrier for #21479 targeted `cloud/1.57`. - Sibling carrier for `core/1.57`: #21533 (separate branch, separate lane). - Not carried: #21270 and #21335 (also PM-2003, touch the same minter file on `main`) are absent from `cloud/1.57`. The cherry-pick did not need them, and typecheck plus the minter and browser suites pass without them. - From the source PR's scope note: the posted turn draft still carries no form (separate client-seed recapture ticket), so that mismatch reaches more documents once more nodes carry a form. Also true on `main`; not specific to this backport. - Carried under the program's standing `cloud/1.57` Agent backport authority. </details> ## Verification Local backend (ComfyUI CI container), `DISTRIBUTION=cloud` dev server, `--project=cloud`, at this branch's head: - Red on parent: with only `docOpMinter.ts` reverted to the `cloud/1.57` version, `agentWidgetFormRoundTrip.spec.ts` fails at line 54. The host refuses the node and it leaves the canvas (`locator('[data-node-id=…]')` not found). - Green on fix: `agentWidgetFormRoundTrip.spec.ts` and `agentCrdtRejectedNodeAdd.spec.ts` pass. - Neighbouring Agent specs, 24 files and 39 tests (human add/delete/rename, tab switch, ghost flag, draft, dynamic combo, overflow, opaque write, widget minting, undo): 38 passed on the first run. `agentPlacedNodeGhostFlag` timed out once in fixture boot, before the app loaded and before any spec assertion ran, then passed when rerun alone. - Vitest: `docOpMinter.test.ts` 103/103. Full `src/workbench/extensions/agent` suite: 166 files, 3508 passed, 1 expected fail. - Normal hooks ran and passed: pre-commit (lint-staged, `typecheck:app`, `typecheck:browser`) and pre-push (knip, fallow audit). Co-authored-by: Alexander Brown <drjkl@comfy.org>
christian-byrne
left a comment
There was a problem hiding this comment.
Carrier reviewed. Diff identical to #21479. Required checks green; one known base flake.
Full context for agent readers
- Authority: Agent release-backport grant for the current
core/1.57train (author cannot approve own PR, so this is a COMMENT review, not an approval). - Source: #21479, merged as
c5b55212fdd8c618a6b3423a12d975e69348f75c. Not previously oncore/1.57; its predecessor #21245 is already there as #21337. - Diff: the added and removed lines are byte-identical to the source commit. The branch is based on the current
core/1.57tip1cec39f76532e00c6b3eab9f86b49cf4f6ca5af6. Conflict-freecherry-pick -x. - Black-box proof:
browser_tests/tests/agent/agentWidgetFormRoundTrip.spec.tsfails with onlydocOpMinter.tsreverted and passes at this head;agentCrdtRejectedNodeAdd.spec.tsplus 15 neighbouring Agent spec files pass (28/28), cloud project, local CI backend. - Hosted failure on attempt 1:
modelImportProgressDialog.spec.ts:35("keeps a panel reachable when expanded panels outgrow a short viewport") failed all 4 tries in chromium shard 3, ande2e-statusfailed only because it aggregates that shard. This carrier does not touch that spec or its component. The same test flaked (failed twice, passed on the third try) in thecore/1.57run for #21520, which is the current branch tip, andmainhas no stabilizing change for it. One rerun of the failed jobs: flaky, passed on retry, 141 passed. All required checks are now green atd27a1ed531. - Exact-head gate:
check-merge-ready.sh --target-branch core/1.57reports MERGE READY: 151 checks terminal, no unresolved threads, no reviewer objections.
… the Agent boundary (#21479) (#21544) ## Summary Backport of #21479 to `cloud/1.58` (FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter declares `widgets_values_form` from the live widget order. Why `cloud/1.58`: it is Cloud's `releaseBranch` and what staging and testcloud serve now, so the next production promotion ships it. It was cut from `main` on 2026-10-19, a day before #21479 merged, so promoting it as-is would ship without this fix even though `cloud/1.57` (#21534) has it. Clean `cherry-pick -x` of c5b5521, no conflict resolution, `git patch-id --stable` identical to the source. #21245 (PM-2003), which this rewrites, is already on `cloud/1.58`. `@comfyorg/comfy-multi-player` is `0.3.10` on the source and on `cloud/1.58`; no pin change is bundled. <details><summary>Full context for agent readers</summary> - Source: #21479 by @DrJKL, merged 2026-10-20T21:41:40Z as `c5b55212fd`. - Target tip at cherry-pick: `01fdaf0dd1b53c87b0dd7cc3022d99b71cd3f4ed`, which is also what stagingcloud and testcloud serve (`x-frontend-version`). `c5b55212fd` is not an ancestor of it, and no PR against `cloud/1.58` carried #21479. - Production serves `ba2c2c2269` (on `cloud/1.57`, before #21534), and Cloud `frontend-version.json` reads `releaseBranch: cloud/1.58`. So #21534 on `cloud/1.57` reaches production only through a `cloud/1.57` patch release. A routine staging→production promotion ships `cloud/1.58`. - Not carried: #21335 (PM-2003 follow-up on the same minter file, merged after the 1.58 cut). The cherry-pick does not need it, and the checks below pass without it, matching the `cloud/1.57` carrier. - Same shape as #21533 and #21534: the dynamic-combo/dynamic-group/autogrow skip stays in place. Removing it needs cmp 0.3.12 and a deployed 0.3.12 doc host; that is #21535 and is not part of this PR. - `cloud/1.58` is not yet named in the program's release-train authority (which still lists 1.56 and 1.57), so this PR is opened for review and is not being self-merged. </details> ## Verification Local ComfyUI CI container backend, `DISTRIBUTION=cloud` dev server, `--project=cloud --retries=0`, at this branch's head: - Red on parent: with only `docOpMinter.ts` reverted to `cloud/1.58`, `agentWidgetFormRoundTrip.spec.ts` fails at line 54. The host refuses the node and it leaves the canvas (`[data-node-id=…]` not found). - Green on fix: `agentWidgetFormRoundTrip.spec.ts` and `agentCrdtRejectedNodeAdd.spec.ts`, 2/2. - Adjacent Agent specs, 14 files and 28 tests (autogrow, draft, opaque write, dynamic combo, ghost flag, human add/reload/tab switch/delete/rename, overflow, placed-node ghost flag, remote undo, tab-switch catch-up, undo/redo): 28/28 on the first run. - Vitest: `docOpMinter.test.ts` 104/104. Full `src/workbench/extensions/agent`: 175 files, 3927 passed, 1 expected fail. - Hooks ran and passed: pre-commit (lint-staged, `typecheck:app`, `typecheck:browser`) and pre-push. The commit was re-created with `commit -C` so the hooks ran; the tree is unchanged. Co-authored-by: Alexander Brown <drjkl@comfy.org>
… the Agent boundary (#21479) (#21629) ## Summary Backport of #21479 to `cloud/1.56` (FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter declares `widgets_values_form` from the live widget order. - `cherry-pick -x` of c5b5521. Minter, minter unit tests and the new round-trip spec apply cleanly. - Two release resolutions, both test-only: - `agentCrdtRejectedNodeAdd.spec.ts` is not on `cloud/1.56` (it came with #20038, not carried here), so its edit is dropped. - The round-trip spec reads the host projection through `hostNode()`, which came with #18934. A second commit adds only that five-line reader. - Builds on #21336 (the PM-2003 backport of #21245), already on `cloud/1.56`. `@comfyorg/comfy-multi-player` is `0.3.10` here, as at the source merge, so no pin change is bundled. <details><summary>Full context for agent readers</summary> - Source: #21479 by @DrJKL, merged 2026-10-20T21:41:40Z. Sibling carriers already merged: #21533 (`core/1.57`), #21534 (`cloud/1.57`), #21544 (`cloud/1.58`). - Target tip at cherry-pick: `7c07d06f34`. No earlier carrier for #21479 targeted `cloud/1.56` (searched open and closed). - `core/1.56` is deliberately not carried: it pins comfy-multi-player 0.3.6, which has no `widgets_values_form` support (the A24 reader arrived in 0.3.9), and it never received the #21245 basis. - Moving the pin to 0.3.12 is #21535's job and stays gated on production Cloud serving cloud#14458. It is not part of this backport. - The posted turn draft still carries no form (separate client-seed recapture ticket), as on `main`. ### Verification on this head (local, `--project=cloud`, own ComfyUI container) - Red on the parent: with the new spec and fixture on `cloud/1.56` and the old minter, `agentWidgetFormRoundTrip.spec.ts` fails 2 of 2. The host refuses the add, the node leaves the canvas, and the panel shows "Your edit was rejected and was not saved." - Green on this head: the same spec passes. On repeats the final tab-return step fails about 1 run in 5. The same tab-switch helper also flakes in the unchanged `agentHumanAddTabSwitch.spec.ts` on the untouched `cloud/1.56` parent (1 of 21 there), so the flake is already on this branch, not caused by this change. - Sweep with one retry, covering draft-matches-canvas, opaque-write, dynamic-combo, human-add reload, human-add tab-switch, overflow, ghost-flag, remote-edit undo, undo/redo and widget-form round trip: 18 passed, 1 flaky (the ghost-flag tab switch, same helper). - Vitest `src/workbench/extensions/agent/`: 2958 passed. One unrelated timer test failed once and passed on rerun. `docOpMinter.test.ts` 87/87. - `typecheck`, `typecheck:browser`, eslint and the commit hooks pass. Carried under the program's standing Agent backport authority for the current `cloud/1.56` train. </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
Summary
Backport of #21479 to
core/1.57(FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter now declareswidgets_values_formfrom the live widget order.Clean
cherry-pick -xof merge commit c5b5521, no conflict resolution. Changed lines are identical to the source. Builds on #21337 (the PM-2003 backport of #21245), which is already oncore/1.57.@comfyorg/comfy-multi-playeris0.3.10on bothmainat the source merge andcore/1.57, so no pin change is bundled.Full context for agent readers
1cec39f76532e00c6b3eab9f86b49cf4f6ca5af6. Source merge commit was not an ancestor ofcore/1.57, and no existing carrier for fix(agent): declare every node's widget form at the Agent boundary #21479 targetedcore/1.57.maintoo; it is not specific to this backport.core/1.57backport authority.Verification
Local backend (ComfyUI CI container 0.0.27),
DISTRIBUTION=clouddev server,--project=cloud, at this branch's head:docOpMinter.tsreverted to thecore/1.57version,agentWidgetFormRoundTrip.spec.tsfails because the host refuses the node and it leaves the canvas (locator('[data-node-id=…]')not found).agentWidgetFormRoundTrip.spec.tsandagentCrdtRejectedNodeAdd.spec.tspass.docOpMinter.test.ts103/103. Fullsrc/workbench/extensions/agentsuite: 3507 passed, 1 failed (useAgentSessiong18, a 73 ms deadline test). That test passes 243/243 when run alone, so it is load-sensitive timing and unrelated to this diff.typecheck:app,typecheck:browser) and pre-push (knip, fallow audit) ran and passed.