Repository navigation
[backport cloud/1.57] fix(agent): declare every node's widget form at the Agent boundary (#21479) - #21534
Conversation
…21479) ## Summary A human `add_node` for a class the doc host's pinned catalog lacks is refused (`uncatalogued_widget_write`) even when the frontend definition describes every widget. The minter decided whether to declare `widgets_values_form` by asking whether the frontend definition covered the widgets, and that check cannot see the host's catalog. `wireNodeSnapshot` now declares the form from the live widget order for every non-virtual node with value widgets. All of the change stays in the Agent minter. ```text wireNodeSnapshot(node) values = value widgets from widgets_values_named no form when the definition has a dynamic combo, dynamic group, or autogrow input no form when a widget name is empty or repeated otherwise form = { order: live widget names that have values } ``` - The dynamic-layout skip is needed only until a comfy-multi-player release that contains Comfy-Org/comfy-multi-player#288 is pinned. Removing it then means deleting one condition. - This is an alternative to #21329. It fixes the same add-node refusal without adding inference, validation, a policy seam, or a `widgets_values_form` field to core serialization. - Not in scope: the posted turn draft still carries no form, which is the separate client-seed recapture ticket. Because more nodes now carry a form, that recapture mismatch affects more documents than before. Linear: FE-3470 ## Verification - Unit: the minter's A24 tests cover declaring and declining the form, real widget constructors, a carried-in projection form, applier acceptance when the catalog lacks the class or lists no widgets, and a catalogued dynamic combo that stays writable after its selection changes. The described-class and closed-order cases fail against the old minter. Removing the dynamic skip, the closed-order check, or the live widget ordering each fails its own rows. - Browser (`--project=cloud`, local backend): the new widget-form round trip fails on `main` (the host refuses the node and it leaves the canvas) and passes here. The rejected-add case now adds an uncatalogued dynamic-combo class, which is still refused, and passes. A sweep of the human-add, tab-switch, ghost-flag, draft, dynamic-combo, overflow, undo and opaque-write Agent specs passed. - The full Agent extension Vitest suite passes. (cherry picked from commit c5b5521)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-21T07:35:36.691Z",
"gitSha": "5dab7740efc6b136da0c14a7e41b26e8315d58eb",
"branch": "backport-21479-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.4810000000175,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.478,
"layouts": 9,
"layoutDurationMs": 2.2950000000000004,
"taskDurationMs": 397.58899999999994,
"heapDeltaBytes": 21741528,
"heapUsedBytes": 87862772,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.568999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.447999999954,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6700000000000004,
"layouts": 10,
"layoutDurationMs": 2.522,
"taskDurationMs": 424.823,
"heapDeltaBytes": -903652,
"heapUsedBytes": 74475804,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.445000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1703.2019999999761,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.160000000000002,
"layouts": 9,
"layoutDurationMs": 2.341,
"taskDurationMs": 684.921,
"heapDeltaBytes": 15665492,
"heapUsedBytes": 81107576,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 120.208,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1943.6319999999796,
"styleRecalcs": 81,
"styleRecalcDurationMs": 14.521999999999998,
"layouts": 10,
"layoutDurationMs": 2.4619999999999997,
"taskDurationMs": 887.23,
"heapDeltaBytes": -7279716,
"heapUsedBytes": 68132660,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 124.61,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581197,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.6699999999837,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.936999999999999,
"layouts": 12,
"layoutDurationMs": 2.895,
"taskDurationMs": 319.16700000000003,
"heapDeltaBytes": 18722352,
"heapUsedBytes": 84871300,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.675999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.552999999938,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.713,
"layouts": 12,
"layoutDurationMs": 3.1719999999999993,
"taskDurationMs": 312.196,
"heapDeltaBytes": 18389544,
"heapUsedBytes": 84585744,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.521,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 559.0130000000499,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.025,
"layouts": 9,
"layoutDurationMs": 2.1420000000000003,
"taskDurationMs": 405.159,
"heapDeltaBytes": 6544332,
"heapUsedBytes": 81518948,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 135.22299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.169696969696968,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 592.9380000000037,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.654,
"layouts": 10,
"layoutDurationMs": 2.2979999999999996,
"taskDurationMs": 421.025,
"heapDeltaBytes": -645804,
"heapUsedBytes": 65653356,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 137.283,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1051.6119999999773,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 702.0690000000001,
"heapDeltaBytes": 715760,
"heapUsedBytes": 81316344,
"domNodes": -192,
"jsHeapTotalBytes": 13115392,
"scriptDurationMs": 48.522999999999996,
"eventListeners": -106,
"totalBlockingTimeMs": 377,
"frameDurationMs": 29.16944444444444,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1070.532000000071,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.9159999999999,
"heapDeltaBytes": -11334420,
"heapUsedBytes": 81372684,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 51.50399999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 397,
"frameDurationMs": 29.627777777777776,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 798.3780000000138,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.641,
"heapDeltaBytes": -3941136,
"heapUsedBytes": 76646724,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 125.18799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 785.252000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.76100000000025,
"heapDeltaBytes": -4056048,
"heapUsedBytes": 75968004,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 120.942,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.035294117647055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7696.293000000025,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0510000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6763.641,
"heapDeltaBytes": -11013476,
"heapUsedBytes": 88557356,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 5309.654,
"eventListeners": -68,
"totalBlockingTimeMs": 100,
"frameDurationMs": 24.313291139240505,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7377.236000000039,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.66,
"layouts": 3,
"layoutDurationMs": 0.8340000000000001,
"taskDurationMs": 6565.533,
"heapDeltaBytes": -22958120,
"heapUsedBytes": 76858840,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 5132.744,
"eventListeners": -68,
"totalBlockingTimeMs": 64,
"frameDurationMs": 24.20688524590164,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7549.7139999999945,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5850000000000004,
"layouts": 2,
"layoutDurationMs": 0.6050000000000001,
"taskDurationMs": 6787.993,
"heapDeltaBytes": 3177284,
"heapUsedBytes": 97164208,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 5343.849,
"eventListeners": -68,
"totalBlockingTimeMs": 166,
"frameDurationMs": 25.166,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7140.722000000096,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7720000000000001,
"layouts": 3,
"layoutDurationMs": 0.6049999999999996,
"taskDurationMs": 6364.058,
"heapDeltaBytes": 7453092,
"heapUsedBytes": 103861400,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 5001.74,
"eventListeners": -68,
"totalBlockingTimeMs": 32,
"frameDurationMs": 24.097972972972972,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 173.17800000000716,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.492,
"layouts": 11,
"layoutDurationMs": 2.984,
"taskDurationMs": 132.72099999999998,
"heapDeltaBytes": -8103136,
"heapUsedBytes": 79043900,
"domNodes": 917,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.065999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.366666666666635,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 184.22899999995934,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.697,
"layouts": 12,
"layoutDurationMs": 3.3699999999999997,
"taskDurationMs": 137.12999999999997,
"heapDeltaBytes": -8118180,
"heapUsedBytes": 79668112,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.738999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.366666666666635,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2025.9090000000128,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.189,
"layouts": 8,
"layoutDurationMs": 2.1029999999999998,
"taskDurationMs": 518.66,
"heapDeltaBytes": -2852472,
"heapUsedBytes": 76355488,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 30.937000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.2250000000677,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9950000000000003,
"layouts": 8,
"layoutDurationMs": 1.724,
"taskDurationMs": 528.837,
"heapDeltaBytes": -2105900,
"heapUsedBytes": 76566652,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 31.693999999999992,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2224.9820000000113,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.249999999999999,
"layouts": 8,
"layoutDurationMs": 2.012,
"taskDurationMs": 1371.132,
"heapDeltaBytes": -29295480,
"heapUsedBytes": 69122848,
"domNodes": -258,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 678.812,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533836,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2208.0040000000736,
"styleRecalcs": 71,
"styleRecalcDurationMs": 6.5969999999999995,
"layouts": 9,
"layoutDurationMs": 2.306,
"taskDurationMs": 1204.8609999999996,
"heapDeltaBytes": -10917368,
"heapUsedBytes": 69808524,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 623.8320000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3215.8560000000307,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.683000000000001,
"layouts": 66,
"layoutDurationMs": 10.486,
"taskDurationMs": 1288.732,
"heapDeltaBytes": -8715188,
"heapUsedBytes": 72656808,
"domNodes": -234,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 621.504,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752604166666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3488.3389999999963,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.863,
"layouts": 66,
"layoutDurationMs": 10.408000000000001,
"taskDurationMs": 1512.125,
"heapDeltaBytes": 12206128,
"heapUsedBytes": 90308708,
"domNodes": -254,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 680.526,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.746153846153845,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2306.574000000012,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.594999999999999,
"layouts": 6,
"layoutDurationMs": 1.441,
"taskDurationMs": 1538.6660000000002,
"heapDeltaBytes": 1085736,
"heapUsedBytes": 78956696,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 759.2049999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78759124087591,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2313.3379999999306,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.877,
"layouts": 6,
"layoutDurationMs": 1.4010000000000002,
"taskDurationMs": 1499.544,
"heapDeltaBytes": 5750128,
"heapUsedBytes": 88995956,
"domNodes": 0,
"jsHeapTotalBytes": 8089600,
"scriptDurationMs": 741.15,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786956521739132,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2053.600000000017,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.387000000000001,
"layouts": 8,
"layoutDurationMs": 2.125,
"taskDurationMs": 551.0809999999999,
"heapDeltaBytes": -1915656,
"heapUsedBytes": 79579196,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 31.432000000000002,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2036.045999999942,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4350000000000005,
"layouts": 10,
"layoutDurationMs": 2.472,
"taskDurationMs": 498.982,
"heapDeltaBytes": -2218076,
"heapUsedBytes": 79454276,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.881000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.6659999999802,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.791,
"layouts": 10,
"layoutDurationMs": 2.37,
"taskDurationMs": 404.29200000000003,
"heapDeltaBytes": -1114396,
"heapUsedBytes": 75804408,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 119.10399999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.5830000000451,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.452,
"layouts": 9,
"layoutDurationMs": 2.058,
"taskDurationMs": 348.978,
"heapDeltaBytes": 19910056,
"heapUsedBytes": 86784740,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 121.32199999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.8449999999748,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9190000000000005,
"layouts": 10,
"layoutDurationMs": 2.4520000000000004,
"taskDurationMs": 410.09599999999995,
"heapDeltaBytes": -272536,
"heapUsedBytes": 76743492,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7.521999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.754999999951,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1260000000000003,
"layouts": 10,
"layoutDurationMs": 2.461,
"taskDurationMs": 408.71999999999997,
"heapDeltaBytes": 3849892,
"heapUsedBytes": 80768020,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 7.358,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.1669999999735,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.072999999999999,
"layouts": 10,
"layoutDurationMs": 2.4090000000000007,
"taskDurationMs": 650.975,
"heapDeltaBytes": -7340384,
"heapUsedBytes": 68807756,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 88.40400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.879000000009,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.81,
"layouts": 10,
"layoutDurationMs": 2.307,
"taskDurationMs": 645.0619999999999,
"heapDeltaBytes": -11419772,
"heapUsedBytes": 65558620,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 87.31099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1319.3240000000515,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.146000000000004,
"layouts": 5,
"layoutDurationMs": 12.007000000000001,
"taskDurationMs": 828.1820000000002,
"heapDeltaBytes": 7342404,
"heapUsedBytes": 102013920,
"domNodes": 15953,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 22.670999999999996,
"eventListeners": 3244,
"totalBlockingTimeMs": 110,
"frameDurationMs": 18.780281690140853,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8927.132000000029,
"styleRecalcs": 252,
"styleRecalcDurationMs": 20.985999999999997,
"layouts": 9,
"layoutDurationMs": 2.464,
"taskDurationMs": 4845.532999999999,
"heapDeltaBytes": -12894640,
"heapUsedBytes": 84142640,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 2218.975,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666044776119406,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8311.275000000023,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.458000000000002,
"layouts": 8,
"layoutDurationMs": 1.905,
"taskDurationMs": 4514.264,
"heapDeltaBytes": -18091608,
"heapUsedBytes": 79002540,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 2085.937,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66613226452906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20195.744999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19544.533000000003,
"heapDeltaBytes": -2452380,
"heapUsedBytes": 273997140,
"domNodes": -3330,
"jsHeapTotalBytes": 10739712,
"scriptDurationMs": 267.665,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.30591497227357,
"p95FrameDurationMs": 66.80000000000018
},
{
"name": "vue-large-graph-idle",
"durationMs": 19887.599999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19246.793999999998,
"heapDeltaBytes": -16689644,
"heapUsedBytes": 265471552,
"domNodes": -3330,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 265.074,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.789928057553965,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23616.714,
"styleRecalcs": 179,
"styleRecalcDurationMs": 19.241000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23401.737999999998,
"heapDeltaBytes": -21366352,
"heapUsedBytes": 279330400,
"domNodes": -3330,
"jsHeapTotalBytes": 14671872,
"scriptDurationMs": 761.5999999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.182191780821924,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 24048.698999999942,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.362000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23765.647,
"heapDeltaBytes": -24745404,
"heapUsedBytes": 266264252,
"domNodes": -3330,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 725.596,
"eventListeners": -651,
"totalBlockingTimeMs": 5,
"frameDurationMs": 47.15509803921569,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7038.621000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.068000000000005,
"layouts": 20,
"layoutDurationMs": 19.851000000000006,
"taskDurationMs": 6948.508,
"heapDeltaBytes": -18340044,
"heapUsedBytes": 258062184,
"domNodes": -3330,
"jsHeapTotalBytes": 26730496,
"scriptDurationMs": 105.02900000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.147239263803684,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6992.171999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.64099999999998,
"layouts": 20,
"layoutDurationMs": 25.92900000000001,
"taskDurationMs": 6888.3910000000005,
"heapDeltaBytes": 3113760,
"heapUsedBytes": 279521676,
"domNodes": -3330,
"jsHeapTotalBytes": 24895488,
"scriptDurationMs": 98.871,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.4189349112426,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10067.829000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9550.21,
"heapDeltaBytes": 4283316,
"heapUsedBytes": 284641860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 129.34099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.69609929078014,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9514.49500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9321.443000000001,
"heapDeltaBytes": -5049192,
"heapUsedBytes": 256605836,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.95,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.449295774647894,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 96.58799999999701,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.567,
"layouts": 6,
"layoutDurationMs": 2.346,
"taskDurationMs": 73.297,
"heapDeltaBytes": 4585364,
"heapUsedBytes": 77721952,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.966999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 90.38999999995667,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.958000000000002,
"layouts": 7,
"layoutDurationMs": 2.503,
"taskDurationMs": 64.917,
"heapDeltaBytes": 4457676,
"heapUsedBytes": 77106900,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.9110000000000005,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 288.9659999999594,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.196,
"layouts": 76,
"layoutDurationMs": 11.549999999999999,
"taskDurationMs": 245.01299999999998,
"heapDeltaBytes": 9634512,
"heapUsedBytes": 100841616,
"domNodes": 4,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 114.78399999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 303.6820000000944,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.862,
"layouts": 76,
"layoutDurationMs": 12.295,
"taskDurationMs": 266.517,
"heapDeltaBytes": -21345188,
"heapUsedBytes": 70743332,
"domNodes": 4,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 126.80899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 330.08300000005875,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.828,
"layouts": 76,
"layoutDurationMs": 10.866000000000001,
"taskDurationMs": 292.39300000000003,
"heapDeltaBytes": -1182392,
"heapUsedBytes": 121453712,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 107.676,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 370.0860000000148,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.494,
"layouts": 76,
"layoutDurationMs": 11.966,
"taskDurationMs": 330.401,
"heapDeltaBytes": 17961140,
"heapUsedBytes": 183354440,
"domNodes": 4,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 114.32999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.699999999999818
}
]
}🎭 Playwright: ✅ 2285 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e0427c3a607552aa567c549330342300475b46d2
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21534 +/- ##
=============================================
Coverage ? 85.84%
=============================================
Files ? 2715
Lines ? 152530
Branches ? 38127
=============================================
Hits ? 130939
Misses ? 21201
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Release-carrier review (author cannot self-approve; this is a COMMENT, not an approval).
- Grant: standing Agent backport review-and-merge authority for
cloud/1.57frontend carriers (programrelease-backport-authority.md/active-authority.md). - Diff reviewed: clean
cherry-pick -xof c5b5521;git patch-id --stableequals the source's. Same five files, no conflict resolution, no pin or lockfile change (comfy-multi-player0.3.10 on both sides).browser_tests/hunks carried in full. - Acceptance:
agentWidgetFormRoundTrip.spec.tsred with onlydocOpMinter.tsreverted tocloud/1.57, green at this head.agentCrdtRejectedNodeAdd.spec.tsgreen. 24-file adjacent Agent sweep green. - Gate at head 1ce09a1, base cloud/1.57@e0427c3a607552aa567c549330342300475b46d2:
lint-and-format,test,e2e-statussuccess; 173 checks terminal with success/neutral/skipped only; no unresolved threads or human objections.
… the Agent boundary (#21479) (#21544) ## Summary Backport of #21479 to `cloud/1.58` (FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter declares `widgets_values_form` from the live widget order. Why `cloud/1.58`: it is Cloud's `releaseBranch` and what staging and testcloud serve now, so the next production promotion ships it. It was cut from `main` on 2026-10-19, a day before #21479 merged, so promoting it as-is would ship without this fix even though `cloud/1.57` (#21534) has it. Clean `cherry-pick -x` of c5b5521, no conflict resolution, `git patch-id --stable` identical to the source. #21245 (PM-2003), which this rewrites, is already on `cloud/1.58`. `@comfyorg/comfy-multi-player` is `0.3.10` on the source and on `cloud/1.58`; no pin change is bundled. <details><summary>Full context for agent readers</summary> - Source: #21479 by @DrJKL, merged 2026-10-20T21:41:40Z as `c5b55212fd`. - Target tip at cherry-pick: `01fdaf0dd1b53c87b0dd7cc3022d99b71cd3f4ed`, which is also what stagingcloud and testcloud serve (`x-frontend-version`). `c5b55212fd` is not an ancestor of it, and no PR against `cloud/1.58` carried #21479. - Production serves `ba2c2c2269` (on `cloud/1.57`, before #21534), and Cloud `frontend-version.json` reads `releaseBranch: cloud/1.58`. So #21534 on `cloud/1.57` reaches production only through a `cloud/1.57` patch release. A routine staging→production promotion ships `cloud/1.58`. - Not carried: #21335 (PM-2003 follow-up on the same minter file, merged after the 1.58 cut). The cherry-pick does not need it, and the checks below pass without it, matching the `cloud/1.57` carrier. - Same shape as #21533 and #21534: the dynamic-combo/dynamic-group/autogrow skip stays in place. Removing it needs cmp 0.3.12 and a deployed 0.3.12 doc host; that is #21535 and is not part of this PR. - `cloud/1.58` is not yet named in the program's release-train authority (which still lists 1.56 and 1.57), so this PR is opened for review and is not being self-merged. </details> ## Verification Local ComfyUI CI container backend, `DISTRIBUTION=cloud` dev server, `--project=cloud --retries=0`, at this branch's head: - Red on parent: with only `docOpMinter.ts` reverted to `cloud/1.58`, `agentWidgetFormRoundTrip.spec.ts` fails at line 54. The host refuses the node and it leaves the canvas (`[data-node-id=…]` not found). - Green on fix: `agentWidgetFormRoundTrip.spec.ts` and `agentCrdtRejectedNodeAdd.spec.ts`, 2/2. - Adjacent Agent specs, 14 files and 28 tests (autogrow, draft, opaque write, dynamic combo, ghost flag, human add/reload/tab switch/delete/rename, overflow, placed-node ghost flag, remote undo, tab-switch catch-up, undo/redo): 28/28 on the first run. - Vitest: `docOpMinter.test.ts` 104/104. Full `src/workbench/extensions/agent`: 175 files, 3927 passed, 1 expected fail. - Hooks ran and passed: pre-commit (lint-staged, `typecheck:app`, `typecheck:browser`) and pre-push. The commit was re-created with `commit -C` so the hooks ran; the tree is unchanged. Co-authored-by: Alexander Brown <drjkl@comfy.org>
… the Agent boundary (#21479) (#21629) ## Summary Backport of #21479 to `cloud/1.56` (FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter declares `widgets_values_form` from the live widget order. - `cherry-pick -x` of c5b5521. Minter, minter unit tests and the new round-trip spec apply cleanly. - Two release resolutions, both test-only: - `agentCrdtRejectedNodeAdd.spec.ts` is not on `cloud/1.56` (it came with #20038, not carried here), so its edit is dropped. - The round-trip spec reads the host projection through `hostNode()`, which came with #18934. A second commit adds only that five-line reader. - Builds on #21336 (the PM-2003 backport of #21245), already on `cloud/1.56`. `@comfyorg/comfy-multi-player` is `0.3.10` here, as at the source merge, so no pin change is bundled. <details><summary>Full context for agent readers</summary> - Source: #21479 by @DrJKL, merged 2026-10-20T21:41:40Z. Sibling carriers already merged: #21533 (`core/1.57`), #21534 (`cloud/1.57`), #21544 (`cloud/1.58`). - Target tip at cherry-pick: `7c07d06f34`. No earlier carrier for #21479 targeted `cloud/1.56` (searched open and closed). - `core/1.56` is deliberately not carried: it pins comfy-multi-player 0.3.6, which has no `widgets_values_form` support (the A24 reader arrived in 0.3.9), and it never received the #21245 basis. - Moving the pin to 0.3.12 is #21535's job and stays gated on production Cloud serving cloud#14458. It is not part of this backport. - The posted turn draft still carries no form (separate client-seed recapture ticket), as on `main`. ### Verification on this head (local, `--project=cloud`, own ComfyUI container) - Red on the parent: with the new spec and fixture on `cloud/1.56` and the old minter, `agentWidgetFormRoundTrip.spec.ts` fails 2 of 2. The host refuses the add, the node leaves the canvas, and the panel shows "Your edit was rejected and was not saved." - Green on this head: the same spec passes. On repeats the final tab-return step fails about 1 run in 5. The same tab-switch helper also flakes in the unchanged `agentHumanAddTabSwitch.spec.ts` on the untouched `cloud/1.56` parent (1 of 21 there), so the flake is already on this branch, not caused by this change. - Sweep with one retry, covering draft-matches-canvas, opaque-write, dynamic-combo, human-add reload, human-add tab-switch, overflow, ghost-flag, remote-edit undo, undo/redo and widget-form round trip: 18 passed, 1 flaky (the ghost-flag tab switch, same helper). - Vitest `src/workbench/extensions/agent/`: 2958 passed. One unrelated timer test failed once and passed on rerun. `docOpMinter.test.ts` 87/87. - `typecheck`, `typecheck:browser`, eslint and the commit hooks pass. Carried under the program's standing Agent backport authority for the current `cloud/1.56` train. </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
Summary
Backport of #21479 to
cloud/1.57(FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter now declareswidgets_values_formfrom the live widget order.Clean
cherry-pick -xof merge commit c5b5521, no conflict resolution. Patch is identical to the source (git patch-id --stablematches). Builds on #21338 (the PM-2003 backport of #21245), already oncloud/1.57.@comfyorg/comfy-multi-playeris0.3.10onmainat the source merge and oncloud/1.57, so no pin change is bundled.Full context for agent readers
e0427c3a607552aa567c549330342300475b46d2. The source merge commit was not an ancestor ofcloud/1.57, and no carrier for fix(agent): declare every node's widget form at the Agent boundary #21479 targetedcloud/1.57.core/1.57: [backport core/1.57] fix(agent): declare every node's widget form at the Agent boundary (#21479) #21533 (separate branch, separate lane).main) are absent fromcloud/1.57. The cherry-pick did not need them, and typecheck plus the minter and browser suites pass without them.main; not specific to this backport.cloud/1.57Agent backport authority.Verification
Local backend (ComfyUI CI container),
DISTRIBUTION=clouddev server,--project=cloud, at this branch's head:docOpMinter.tsreverted to thecloud/1.57version,agentWidgetFormRoundTrip.spec.tsfails at line 54. The host refuses the node and it leaves the canvas (locator('[data-node-id=…]')not found).agentWidgetFormRoundTrip.spec.tsandagentCrdtRejectedNodeAdd.spec.tspass.agentPlacedNodeGhostFlagtimed out once in fixture boot, before the app loaded and before any spec assertion ran, then passed when rerun alone.docOpMinter.test.ts103/103. Fullsrc/workbench/extensions/agentsuite: 166 files, 3508 passed, 1 expected fail.typecheck:app,typecheck:browser) and pre-push (knip, fallow audit).