Skip to content

[backport cloud/1.58] fix(agent): declare every node's widget form at the Agent boundary (#21479) - #21544

Merged
comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-21479-to-cloud-1.58
Oct 21, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-21479-to-cloud-1.58

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backport of #21479 to cloud/1.58 (FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter declares widgets_values_form from the live widget order.

Why cloud/1.58: it is Cloud's releaseBranch and what staging and testcloud serve now, so the next production promotion ships it. It was cut from main on 2026-10-19, a day before #21479 merged, so promoting it as-is would ship without this fix even though cloud/1.57 (#21534) has it.

Clean cherry-pick -x of c5b5521, no conflict resolution, git patch-id --stable identical to the source. #21245 (PM-2003), which this rewrites, is already on cloud/1.58. @comfyorg/comfy-multi-player is 0.3.10 on the source and on cloud/1.58; no pin change is bundled.

Full context for agent readers

Verification

Local ComfyUI CI container backend, DISTRIBUTION=cloud dev server, --project=cloud --retries=0, at this branch's head:

  • Red on parent: with only docOpMinter.ts reverted to cloud/1.58, agentWidgetFormRoundTrip.spec.ts fails at line 54. The host refuses the node and it leaves the canvas ([data-node-id=…] not found).
  • Green on fix: agentWidgetFormRoundTrip.spec.ts and agentCrdtRejectedNodeAdd.spec.ts, 2/2.
  • Adjacent Agent specs, 14 files and 28 tests (autogrow, draft, opaque write, dynamic combo, ghost flag, human add/reload/tab switch/delete/rename, overflow, placed-node ghost flag, remote undo, tab-switch catch-up, undo/redo): 28/28 on the first run.
  • Vitest: docOpMinter.test.ts 104/104. Full src/workbench/extensions/agent: 175 files, 3927 passed, 1 expected fail.
  • Hooks ran and passed: pre-commit (lint-staged, typecheck:app, typecheck:browser) and pre-push. The commit was re-created with commit -C so the hooks ran; the tree is unchanged.

…21479)

## Summary

A human `add_node` for a class the doc host's pinned catalog lacks is
refused (`uncatalogued_widget_write`) even when the frontend definition
describes every widget. The minter decided whether to declare
`widgets_values_form` by asking whether the frontend definition covered
the widgets, and that check cannot see the host's catalog.

`wireNodeSnapshot` now declares the form from the live widget order for
every non-virtual node with value widgets. All of the change stays in
the Agent minter.

```text
wireNodeSnapshot(node)
  values = value widgets from widgets_values_named
  no form when the definition has a dynamic combo, dynamic group, or autogrow input
  no form when a widget name is empty or repeated
  otherwise form = { order: live widget names that have values }
```

- The dynamic-layout skip is needed only until a comfy-multi-player
release that contains Comfy-Org/comfy-multi-player#288 is pinned.
Removing it then means deleting one condition.
- This is an alternative to #21329. It fixes the same add-node refusal
without adding inference, validation, a policy seam, or a
`widgets_values_form` field to core serialization.
- Not in scope: the posted turn draft still carries no form, which is
the separate client-seed recapture ticket. Because more nodes now carry
a form, that recapture mismatch affects more documents than before.

Linear: FE-3470

## Verification

- Unit: the minter's A24 tests cover declaring and declining the form,
real widget constructors, a carried-in projection form, applier
acceptance when the catalog lacks the class or lists no widgets, and a
catalogued dynamic combo that stays writable after its selection
changes. The described-class and closed-order cases fail against the old
minter. Removing the dynamic skip, the closed-order check, or the live
widget ordering each fails its own rows.
- Browser (`--project=cloud`, local backend): the new widget-form round
trip fails on `main` (the host refuses the node and it leaves the
canvas) and passes here. The rejected-add case now adds an uncatalogued
dynamic-combo class, which is still refused, and passes. A sweep of the
human-add, tab-switch, ghost-flag, draft, dynamic-combo, overflow, undo
and opaque-write Agent specs passed.
- The full Agent extension Vitest suite passes.

(cherry picked from commit c5b5521)
@christian-byrne
christian-byrne requested review from a team as code owners October 21, 2026 14:21
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 954791a9-2a22-406c-b48e-af01369e522f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.7 MB heap
canvas-mouse-sweep: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 102.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.1 MB heap
dom-widget-order-dense-n200-w200-i120: · 29.0 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 579ms TBT · 97.4 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 41.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 185ms TBT · 90.2 MB heap
extension-clean-combined-draw: · 32.2 avg FPS · 17.2 P5 FPS ❌ (target: ≥52) · 557ms TBT · 135.9 MB heap
extension-rgthree-prototype-draw: · 33.1 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 272ms TBT · 133.5 MB heap
large-combo-open: · 45.5 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 2ms TBT · 113.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.0 MB heap
large-graph-pan: · 59.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.1 MB heap
legacy-node-drag: · 58.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 24ms TBT · 92.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 107.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.7 MB heap
subgraph-transition-enter: · 47.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 163ms TBT · 129.0 MB heap
viewport-pan-sweep: · 59.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.0 MB heap
vue-large-graph-idle: · 39.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 278.8 MB heap
vue-large-graph-pan: · 31.7 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 8ms TBT · 290.4 MB heap
vue-node-resize-workload: · 23.3 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 266.3 MB heap
vue-zoom-out-idle: · 26.9 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 391.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.1 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.5 MB heap
agent-composer-long-conversation-typing: · 59.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 118.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 9
canvas-idle: style recalc count 9
canvas-idle: task duration 563ms
canvas-idle: script duration 14ms
canvas-idle: TBT 0ms
canvas-idle: heap used 89.7 MB
canvas-idle: DOM nodes -190
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 16ms
canvas-mouse-sweep: layout count 11
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 992ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 91.2 MB
canvas-mouse-sweep: DOM nodes -90
canvas-mouse-sweep: event listeners -62
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 4ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 20
canvas-zoom-sweep: task duration 481ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 102.6 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 538ms
dom-widget-clipping: script duration 179ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 95.1 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 25ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 943ms
dom-widget-order-dense-n200-w200-i120: script duration 63ms
dom-widget-order-dense-n200-w200-i120: TBT 579ms
dom-widget-order-dense-n200-w200-i120: heap used 97.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -230
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 24ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 468ms
dom-widget-order-sparse-n1000-w20-i120: script duration 141ms
dom-widget-order-sparse-n1000-w20-i120: TBT 185ms
dom-widget-order-sparse-n1000-w20-i120: heap used 90.2 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 31ms
extension-clean-combined-draw: p95 frame time 58ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9136ms
extension-clean-combined-draw: script duration 7128ms
extension-clean-combined-draw: TBT 557ms
extension-clean-combined-draw: heap used 135.9 MB
extension-clean-combined-draw: DOM nodes -286
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 30ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 8404ms
extension-rgthree-prototype-draw: script duration 6685ms
extension-rgthree-prototype-draw: TBT 272ms
extension-rgthree-prototype-draw: heap used 133.5 MB
extension-rgthree-prototype-draw: DOM nodes -277
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 22ms
large-combo-open: p95 frame time 67ms
large-combo-open: layout duration 4ms
large-combo-open: style recalc duration 16ms
large-combo-open: layout count 12
large-combo-open: style recalc count 26
large-combo-open: task duration 195ms
large-combo-open: script duration 10ms
large-combo-open: TBT 2ms
large-combo-open: heap used 113.1 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 7
large-graph-idle: style recalc count 8
large-graph-idle: task duration 616ms
large-graph-idle: script duration 40ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 103.0 MB
large-graph-idle: DOM nodes -286
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1832ms
large-graph-pan: script duration 862ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 91.9 MB
large-graph-pan: DOM nodes -286
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 64
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1887ms
large-graph-zoom: script duration 814ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 88.1 MB
large-graph-zoom: DOM nodes -263
large-graph-zoom: event listeners -130
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 2ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 2055ms
legacy-node-drag: script duration 1064ms
legacy-node-drag: TBT 24ms
legacy-node-drag: heap used 92.6 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 7
minimap-idle: style recalc count 7
minimap-idle: task duration 587ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 107.8 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 463ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 103.8 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 11
subgraph-idle: task duration 711ms
subgraph-idle: script duration 13ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 90.9 MB
subgraph-idle: DOM nodes -209
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 17ms
subgraph-mouse-sweep: layout count 9
subgraph-mouse-sweep: style recalc count 84
subgraph-mouse-sweep: task duration 1137ms
subgraph-mouse-sweep: script duration 122ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 87.7 MB
subgraph-mouse-sweep: DOM nodes -95
subgraph-mouse-sweep: event listeners -84
subgraph-transition-enter: avg frame time 21ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 23ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 848ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 163ms
subgraph-transition-enter: heap used 129.0 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 31ms
viewport-pan-sweep: layout count 7
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5781ms
viewport-pan-sweep: script duration 2808ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 103.0 MB
viewport-pan-sweep: DOM nodes -286
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 25ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13556ms
vue-large-graph-idle: script duration 248ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 278.8 MB
vue-large-graph-idle: DOM nodes -3344
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 32ms
vue-large-graph-pan: p95 frame time 58ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 111
vue-large-graph-pan: task duration 16709ms
vue-large-graph-pan: script duration 812ms
vue-large-graph-pan: TBT 8ms
vue-large-graph-pan: heap used 290.4 MB
vue-large-graph-pan: DOM nodes -3344
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 43ms
vue-node-resize-workload: p95 frame time 83ms
vue-node-resize-workload: layout duration 34ms
vue-node-resize-workload: style recalc duration 77ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 7443ms
vue-node-resize-workload: script duration 122ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 266.3 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 37ms
vue-zoom-out-idle: p95 frame time 83ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 10180ms
vue-zoom-out-idle: script duration 143ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 391.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 5ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 11
workflow-execution: style recalc count 22
workflow-execution: task duration 164ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 86.1 MB
workflow-execution: DOM nodes 123
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 21ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 649ms
agent-composer-empty-conversation-typing: script duration 303ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 78.5 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 19ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 690ms
agent-composer-long-conversation-typing: script duration 287ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 118.9 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-21T14:34:05.617Z",
  "gitSha": "f8f10a2c8076c23d4fbf8cd34d9283948490b4b5",
  "branch": "backport-21479-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2042.0569999999998,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.8980000000000006,
      "layouts": 9,
      "layoutDurationMs": 2.766,
      "taskDurationMs": 555.447,
      "heapDeltaBytes": -7038996,
      "heapUsedBytes": 96675448,
      "domNodes": -180,
      "jsHeapTotalBytes": 2002944,
      "scriptDurationMs": 13.195999999999996,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2040.4560000000629,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.2200000000000006,
      "layouts": 9,
      "layoutDurationMs": 3.169,
      "taskDurationMs": 571.547,
      "heapDeltaBytes": -12761656,
      "heapUsedBytes": 91513576,
      "domNodes": -200,
      "jsHeapTotalBytes": 2265088,
      "scriptDurationMs": 14.637,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1907.256000000018,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 16.262,
      "layouts": 11,
      "layoutDurationMs": 3.7800000000000002,
      "taskDurationMs": 962.64,
      "heapDeltaBytes": -3709216,
      "heapUsedBytes": 94731228,
      "domNodes": -180,
      "jsHeapTotalBytes": 7770112,
      "scriptDurationMs": 170.46800000000002,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.812389380530973,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1836.9760000000497,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 15.920999999999998,
      "layouts": 10,
      "layoutDurationMs": 2.999,
      "taskDurationMs": 1020.7839999999999,
      "heapDeltaBytes": -3352912,
      "heapUsedBytes": 96471628,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 163.33,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66636363636363,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1714.8899999999685,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 6.4510000000000005,
      "layouts": 11,
      "layoutDurationMs": 3.941,
      "taskDurationMs": 507.7639999999999,
      "heapDeltaBytes": 21584356,
      "heapUsedBytes": 109047208,
      "domNodes": 47,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 16.356,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1741.6279999999915,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.3790000000000004,
      "layouts": 11,
      "layoutDurationMs": 3.1029999999999998,
      "taskDurationMs": 454.042,
      "heapDeltaBytes": 1869228,
      "heapUsedBytes": 106206776,
      "domNodes": 47,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 13.523999999999997,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 773.3409999999594,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.2279999999999998,
      "layouts": 8,
      "layoutDurationMs": 2.93,
      "taskDurationMs": 570.311,
      "heapDeltaBytes": 7239720,
      "heapUsedBytes": 111079792,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 173.65,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66304347826087,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 733.2239999999501,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.3419999999999996,
      "layouts": 9,
      "layoutDurationMs": 2.9569999999999994,
      "taskDurationMs": 506.29,
      "heapDeltaBytes": 702548,
      "heapUsedBytes": 88259756,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 184.43599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66818181818182,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1278.1980000000317,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 958.7150000000001,
      "heapDeltaBytes": -8450280,
      "heapUsedBytes": 102189404,
      "domNodes": -230,
      "jsHeapTotalBytes": 9875456,
      "scriptDurationMs": 63.27100000000001,
      "eventListeners": -168,
      "totalBlockingTimeMs": 582,
      "frameDurationMs": 34.68378378378379,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1260.575000000017,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 926.6270000000001,
      "heapDeltaBytes": -9043832,
      "heapUsedBytes": 101996452,
      "domNodes": -230,
      "jsHeapTotalBytes": 10661888,
      "scriptDurationMs": 62.4,
      "eventListeners": -168,
      "totalBlockingTimeMs": 575,
      "frameDurationMs": 34.23513513513513,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 818.416999999954,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.71300000000065,
      "heapDeltaBytes": -4404228,
      "heapUsedBytes": 92096228,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 142.59500000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 181,
      "frameDurationMs": 24.020588235294138,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 810.7049999999845,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.72799999999967,
      "heapDeltaBytes": -4197448,
      "heapUsedBytes": 97158100,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 139.222,
      "eventListeners": 0,
      "totalBlockingTimeMs": 189,
      "frameDurationMs": 24.017647058823542,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10812.872000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9907.658,
      "heapDeltaBytes": 15310464,
      "heapUsedBytes": 137554240,
      "domNodes": -276,
      "jsHeapTotalBytes": 40865792,
      "scriptDurationMs": 7615.95,
      "eventListeners": -130,
      "totalBlockingTimeMs": 854,
      "frameDurationMs": 31.626315789473686,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9196.820000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8364.936,
      "heapDeltaBytes": 33676232,
      "heapUsedBytes": 147467508,
      "domNodes": -296,
      "jsHeapTotalBytes": 23302144,
      "scriptDurationMs": 6639.771,
      "eventListeners": -130,
      "totalBlockingTimeMs": 260,
      "frameDurationMs": 30.563455149501657,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9108.464999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8288.521,
      "heapDeltaBytes": 18578948,
      "heapUsedBytes": 140645624,
      "domNodes": -276,
      "jsHeapTotalBytes": 31887360,
      "scriptDurationMs": 6611.634,
      "eventListeners": -130,
      "totalBlockingTimeMs": 269,
      "frameDurationMs": 29.83475409836066,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9349.38199999999,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.04900000000000043,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8520.453,
      "heapDeltaBytes": 17792876,
      "heapUsedBytes": 139304532,
      "domNodes": -277,
      "jsHeapTotalBytes": 31363072,
      "scriptDurationMs": 6758.116,
      "eventListeners": -130,
      "totalBlockingTimeMs": 275,
      "frameDurationMs": 30.554575163398695,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 245.45700000004445,
      "styleRecalcs": 26,
      "styleRecalcDurationMs": 15.584,
      "layouts": 11,
      "layoutDurationMs": 3.6729999999999996,
      "taskDurationMs": 183.373,
      "heapDeltaBytes": 13236872,
      "heapUsedBytes": 119504896,
      "domNodes": 917,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 10.165,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.218181818181787,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "large-combo-open",
      "durationMs": 261.0770000000002,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 15.504,
      "layouts": 12,
      "layoutDurationMs": 4.024,
      "taskDurationMs": 205.98399999999998,
      "heapDeltaBytes": 13285224,
      "heapUsedBytes": 117786128,
      "domNodes": 917,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 10.768,
      "eventListeners": 196,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 22.73636363636367,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.2559999999953,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.503,
      "layouts": 7,
      "layoutDurationMs": 2.228,
      "taskDurationMs": 594.258,
      "heapDeltaBytes": 772376,
      "heapUsedBytes": 103844696,
      "domNodes": -296,
      "jsHeapTotalBytes": -5599232,
      "scriptDurationMs": 38.703,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.60800000003,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.368000000000001,
      "layouts": 7,
      "layoutDurationMs": 2.2239999999999998,
      "taskDurationMs": 637.585,
      "heapDeltaBytes": 9752668,
      "heapUsedBytes": 112208808,
      "domNodes": -276,
      "jsHeapTotalBytes": -5074944,
      "scriptDurationMs": 41.711000000000006,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2798.6610000000383,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.584999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.8010000000000002,
      "taskDurationMs": 1856.3460000000002,
      "heapDeltaBytes": -16851860,
      "heapUsedBytes": 87751124,
      "domNodes": -296,
      "jsHeapTotalBytes": -1339392,
      "scriptDurationMs": 820.175,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.867878787878787,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3043.4099999999944,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 10.028000000000002,
      "layouts": 7,
      "layoutDurationMs": 2.029,
      "taskDurationMs": 1807.051,
      "heapDeltaBytes": 3231580,
      "heapUsedBytes": 104991152,
      "domNodes": -276,
      "jsHeapTotalBytes": -393216,
      "scriptDurationMs": 904.595,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4070.2320000000327,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.854999999999999,
      "layouts": 64,
      "layoutDurationMs": 11.873999999999999,
      "taskDurationMs": 2039.0359999999998,
      "heapDeltaBytes": -22364488,
      "heapUsedBytes": 92142812,
      "domNodes": -272,
      "jsHeapTotalBytes": -159744,
      "scriptDurationMs": 836.723,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3621.748999999909,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 10.277999999999999,
      "layouts": 64,
      "layoutDurationMs": 11.205,
      "taskDurationMs": 1734.4630000000002,
      "heapDeltaBytes": -10947296,
      "heapUsedBytes": 92582224,
      "domNodes": -253,
      "jsHeapTotalBytes": -1273856,
      "scriptDurationMs": 791.656,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66589861751152,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3217.759000000001,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.856,
      "layouts": 5,
      "layoutDurationMs": 1.5439999999999998,
      "taskDurationMs": 2088.8830000000003,
      "heapDeltaBytes": -9357836,
      "heapUsedBytes": 95370996,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 1094.212,
      "eventListeners": 182,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 17.01684210526316,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3236.8850000000293,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.978,
      "layouts": 5,
      "layoutDurationMs": 1.5290000000000004,
      "taskDurationMs": 2021.17,
      "heapDeltaBytes": -8036736,
      "heapUsedBytes": 98761584,
      "domNodes": 0,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 1032.858,
      "eventListeners": 182,
      "totalBlockingTimeMs": 30,
      "frameDurationMs": 17.104736842105265,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.53599999997,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.1790000000000003,
      "layouts": 6,
      "layoutDurationMs": 2.2220000000000004,
      "taskDurationMs": 598.453,
      "heapDeltaBytes": 9617508,
      "heapUsedBytes": 113258304,
      "domNodes": -276,
      "jsHeapTotalBytes": -5861376,
      "scriptDurationMs": 35.86500000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.7220000000216,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.4419999999999997,
      "layouts": 7,
      "layoutDurationMs": 2.4859999999999998,
      "taskDurationMs": 576.2199999999999,
      "heapDeltaBytes": 10117956,
      "heapUsedBytes": 112885360,
      "domNodes": -276,
      "jsHeapTotalBytes": -4550656,
      "scriptDurationMs": 37.346,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 757.362999999998,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.922999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.993,
      "taskDurationMs": 514.216,
      "heapDeltaBytes": 3120236,
      "heapUsedBytes": 108831400,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 148.63199999999998,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.0480000000571,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.066999999999999,
      "layouts": 10,
      "layoutDurationMs": 3.0010000000000003,
      "taskDurationMs": 411.998,
      "heapDeltaBytes": 2701804,
      "heapUsedBytes": 108911676,
      "domNodes": 0,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 143.588,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668571428571443,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2073.165999999958,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.449,
      "layouts": 10,
      "layoutDurationMs": 3.076,
      "taskDurationMs": 701.2239999999999,
      "heapDeltaBytes": -13370048,
      "heapUsedBytes": 92819136,
      "domNodes": -218,
      "jsHeapTotalBytes": 2789376,
      "scriptDurationMs": 13.225999999999997,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666129032258066,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2054.7490000000153,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.3810000000000002,
      "layouts": 10,
      "layoutDurationMs": 3.5320000000000005,
      "taskDurationMs": 720.468,
      "heapDeltaBytes": -7971224,
      "heapUsedBytes": 97790416,
      "domNodes": -199,
      "jsHeapTotalBytes": 3051520,
      "scriptDurationMs": 12.795000000000002,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1753.547000000026,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 15.25,
      "layouts": 9,
      "layoutDurationMs": 2.611,
      "taskDurationMs": 957.489,
      "heapDeltaBytes": -6326240,
      "heapUsedBytes": 94014204,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 116.25300000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 2086.022000000071,
      "styleRecalcs": 89,
      "styleRecalcDurationMs": 17.88,
      "layouts": 8,
      "layoutDurationMs": 2.869,
      "taskDurationMs": 1316.335,
      "heapDeltaBytes": -15380892,
      "heapUsedBytes": 90010576,
      "domNodes": -190,
      "jsHeapTotalBytes": 3313664,
      "scriptDurationMs": 127.057,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665600000000005,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1099.0639999999985,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 23.149000000000004,
      "layouts": 5,
      "layoutDurationMs": 14.121999999999996,
      "taskDurationMs": 848.4129999999999,
      "heapDeltaBytes": 35544988,
      "heapUsedBytes": 135265032,
      "domNodes": 16030,
      "jsHeapTotalBytes": 16916480,
      "scriptDurationMs": 28.731999999999992,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 163,
      "frameDurationMs": 21.153846153846153,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8569.491000000027,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 30.973,
      "layouts": 6,
      "layoutDurationMs": 1.6170000000000004,
      "taskDurationMs": 5972.7519999999995,
      "heapDeltaBytes": 6111396,
      "heapUsedBytes": 108235564,
      "domNodes": -276,
      "jsHeapTotalBytes": -3833856,
      "scriptDurationMs": 2898.796,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.731054687500002,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8395.128,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 30.633999999999997,
      "layouts": 8,
      "layoutDurationMs": 1.9309999999999996,
      "taskDurationMs": 5590.246999999999,
      "heapDeltaBytes": -4091992,
      "heapUsedBytes": 107733056,
      "domNodes": -296,
      "jsHeapTotalBytes": -1638400,
      "scriptDurationMs": 2717.3819999999996,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.69920477137177,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14227.57899999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13533.178,
      "heapDeltaBytes": -22371428,
      "heapUsedBytes": 287678488,
      "domNodes": -3344,
      "jsHeapTotalBytes": 18075648,
      "scriptDurationMs": 236.095,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.37040998217469,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14365.461000000096,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13579.359999999999,
      "heapDeltaBytes": -11096112,
      "heapUsedBytes": 296992588,
      "domNodes": -3344,
      "jsHeapTotalBytes": 20959232,
      "scriptDurationMs": 259.784,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.337037037037042,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17154.646999999954,
      "styleRecalcs": 112,
      "styleRecalcDurationMs": 15.621999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16886.115,
      "heapDeltaBytes": -21338848,
      "heapUsedBytes": 304367864,
      "domNodes": -3344,
      "jsHeapTotalBytes": 22269952,
      "scriptDurationMs": 824.3090000000001,
      "eventListeners": -651,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 32.23552631578947,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16947.284999999967,
      "styleRecalcs": 110,
      "styleRecalcDurationMs": 14.574000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16531.880999999998,
      "heapDeltaBytes": -5490880,
      "heapUsedBytes": 304716216,
      "domNodes": -3344,
      "jsHeapTotalBytes": 18862080,
      "scriptDurationMs": 799.064,
      "eventListeners": -651,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 30.903460837887067,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7608.000000000061,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.91900000000001,
      "layouts": 20,
      "layoutDurationMs": 32.36499999999999,
      "taskDurationMs": 7482.583,
      "heapDeltaBytes": -28401396,
      "heapUsedBytes": 282088844,
      "domNodes": -3344,
      "jsHeapTotalBytes": 2609152,
      "scriptDurationMs": 123.706,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 43.18068181818182,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7468.166999999994,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.238,
      "layouts": 20,
      "layoutDurationMs": 36.286999999999985,
      "taskDurationMs": 7403.526,
      "heapDeltaBytes": -43856252,
      "heapUsedBytes": 276423956,
      "domNodes": -3344,
      "jsHeapTotalBytes": 1298432,
      "scriptDurationMs": 120.17699999999999,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 42.665142857142854,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 10589.337,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10368.698,
      "heapDeltaBytes": -9417968,
      "heapUsedBytes": 532410412,
      "domNodes": 0,
      "jsHeapTotalBytes": -1572864,
      "scriptDurationMs": 146.43700000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 37.66156583629893,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 10234.21200000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9991.851,
      "heapDeltaBytes": 89916,
      "heapUsedBytes": 289471152,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 138.89000000000007,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.749280575539565,
      "p95FrameDurationMs": 83.20000000000073
    },
    {
      "name": "workflow-execution",
      "durationMs": 507.07999999997355,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 12.328000000000001,
      "layouts": 11,
      "layoutDurationMs": 4.474,
      "taskDurationMs": 172.212,
      "heapDeltaBytes": -12388552,
      "heapUsedBytes": 89420656,
      "domNodes": 124,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 13.620999999999999,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 513.6780000000272,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 12.885,
      "layouts": 11,
      "layoutDurationMs": 4.792,
      "taskDurationMs": 155.347,
      "heapDeltaBytes": -12637820,
      "heapUsedBytes": 91189660,
      "domNodes": 121,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 12.408,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483864,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 764.7549999999228,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.734,
      "layouts": 76,
      "layoutDurationMs": 21.644,
      "taskDurationMs": 731.6590000000001,
      "heapDeltaBytes": -11881352,
      "heapUsedBytes": 82236704,
      "domNodes": 4,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 349.085,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665957446808516,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 613.6249999999563,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.721,
      "layouts": 76,
      "layoutDurationMs": 20.346,
      "taskDurationMs": 566.7289999999999,
      "heapDeltaBytes": 13203508,
      "heapUsedBytes": 82292076,
      "domNodes": 4,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 255.96400000000003,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664864864864875,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 876.9640000000436,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.287,
      "layouts": 76,
      "layoutDurationMs": 21.285999999999998,
      "taskDurationMs": 843.9060000000001,
      "heapDeltaBytes": 4389140,
      "heapUsedBytes": 125208960,
      "domNodes": 4,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 362.355,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.9846153846154,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 581.470999999965,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.753,
      "layouts": 76,
      "layoutDurationMs": 15.978,
      "taskDurationMs": 535.812,
      "heapDeltaBytes": -820748,
      "heapUsedBytes": 124055844,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 211.72,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668571428571443,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Line coverage: 64.0%

Coverage totals
Metric Covered Total Pct
Lines 56910 88976 64.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.5% 1168
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 1.1% 280
src/LGraph.ts 78.9% 274
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.4% 255
src/platform/workspace/stores/teamWorkspaceStore.ts 46.8% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2951 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2273 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 649 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/21/2026, 02:23:48 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 01fdaf0dd1b53c87b0dd7cc3022d99b71cd3f4ed

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (114)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 64 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/crdt/docOpMinter.ts 92.85% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.58   #21544   +/-   ##
=============================================
  Coverage              ?   86.16%           
=============================================
  Files                 ?     2786           
  Lines                 ?   154641           
  Branches              ?    39206           
=============================================
  Hits                  ?   133248           
  Misses                ?    21004           
  Partials              ?      389           
Flag Coverage Δ
e2e 64.12% <16.66%> (?)
unit 85.73% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/crdt/docOpMinter.ts 90.62% <92.85%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 21, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 4 finding(s).

Severity Count
🟡 Medium 3
🟢 Low 1

Panel: 6/6 reviewers contributed findings.

@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 98 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@comfy-greenlight-bot comfy-greenlight-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request at head commit 883ad2a has been reviewed and approved by Swarmhost's agentic review process.

The detailed evaluation is available to employees in the internal Slack review thread.

@comfy-pr-bot
comfy-pr-bot merged commit 9982ad0 into cloud/1.58 Oct 21, 2026
195 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21479-to-cloud-1.58 branch October 21, 2026 15:46
christian-byrne added a commit that referenced this pull request Oct 22, 2026
… the Agent boundary (#21479) (#21629)

## Summary

Backport of #21479 to `cloud/1.56` (FE-3470). A human-added node whose
class the doc host's pinned catalog lacks is no longer refused; the
Agent minter declares `widgets_values_form` from the live widget order.

- `cherry-pick -x` of c5b5521. Minter,
minter unit tests and the new round-trip spec apply cleanly.
- Two release resolutions, both test-only:
- `agentCrdtRejectedNodeAdd.spec.ts` is not on `cloud/1.56` (it came
with #20038, not carried here), so its edit is dropped.
- The round-trip spec reads the host projection through `hostNode()`,
which came with #18934. A second commit adds only that five-line reader.
- Builds on #21336 (the PM-2003 backport of #21245), already on
`cloud/1.56`. `@comfyorg/comfy-multi-player` is `0.3.10` here, as at the
source merge, so no pin change is bundled.

<details><summary>Full context for agent readers</summary>

- Source: #21479 by @DrJKL, merged 2026-10-20T21:41:40Z. Sibling
carriers already merged: #21533 (`core/1.57`), #21534 (`cloud/1.57`),
#21544 (`cloud/1.58`).
- Target tip at cherry-pick: `7c07d06f34`. No earlier carrier for #21479
targeted `cloud/1.56` (searched open and closed).
- `core/1.56` is deliberately not carried: it pins comfy-multi-player
0.3.6, which has no `widgets_values_form` support (the A24 reader
arrived in 0.3.9), and it never received the #21245 basis.
- Moving the pin to 0.3.12 is #21535's job and stays gated on production
Cloud serving cloud#14458. It is not part of this backport.
- The posted turn draft still carries no form (separate client-seed
recapture ticket), as on `main`.

### Verification on this head (local, `--project=cloud`, own ComfyUI
container)

- Red on the parent: with the new spec and fixture on `cloud/1.56` and
the old minter, `agentWidgetFormRoundTrip.spec.ts` fails 2 of 2. The
host refuses the add, the node leaves the canvas, and the panel shows
"Your edit was rejected and was not saved."
- Green on this head: the same spec passes. On repeats the final
tab-return step fails about 1 run in 5. The same tab-switch helper also
flakes in the unchanged `agentHumanAddTabSwitch.spec.ts` on the
untouched `cloud/1.56` parent (1 of 21 there), so the flake is already
on this branch, not caused by this change.
- Sweep with one retry, covering draft-matches-canvas, opaque-write,
dynamic-combo, human-add reload, human-add tab-switch, overflow,
ghost-flag, remote-edit undo, undo/redo and widget-form round trip: 18
passed, 1 flaky (the ghost-flag tab switch, same helper).
- Vitest `src/workbench/extensions/agent/`: 2958 passed. One unrelated
timer test failed once and passed on rerun. `docOpMinter.test.ts` 87/87.
- `typecheck`, `typecheck:browser`, eslint and the commit hooks pass.

Carried under the program's standing Agent backport authority for the
current `cloud/1.56` train.

</details>

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants