Repository navigation
[backport cloud/1.58] fix(agent): declare every node's widget form at the Agent boundary (#21479) - #21544
Conversation
…21479) ## Summary A human `add_node` for a class the doc host's pinned catalog lacks is refused (`uncatalogued_widget_write`) even when the frontend definition describes every widget. The minter decided whether to declare `widgets_values_form` by asking whether the frontend definition covered the widgets, and that check cannot see the host's catalog. `wireNodeSnapshot` now declares the form from the live widget order for every non-virtual node with value widgets. All of the change stays in the Agent minter. ```text wireNodeSnapshot(node) values = value widgets from widgets_values_named no form when the definition has a dynamic combo, dynamic group, or autogrow input no form when a widget name is empty or repeated otherwise form = { order: live widget names that have values } ``` - The dynamic-layout skip is needed only until a comfy-multi-player release that contains Comfy-Org/comfy-multi-player#288 is pinned. Removing it then means deleting one condition. - This is an alternative to #21329. It fixes the same add-node refusal without adding inference, validation, a policy seam, or a `widgets_values_form` field to core serialization. - Not in scope: the posted turn draft still carries no form, which is the separate client-seed recapture ticket. Because more nodes now carry a form, that recapture mismatch affects more documents than before. Linear: FE-3470 ## Verification - Unit: the minter's A24 tests cover declaring and declining the form, real widget constructors, a carried-in projection form, applier acceptance when the catalog lacks the class or lists no widgets, and a catalogued dynamic combo that stays writable after its selection changes. The described-class and closed-order cases fail against the old minter. Removing the dynamic skip, the closed-order check, or the live widget ordering each fails its own rows. - Browser (`--project=cloud`, local backend): the new widget-form round trip fails on `main` (the host refuses the node and it leaves the canvas) and passes here. The rejected-add case now adds an uncatalogued dynamic-combo class, which is still refused, and passes. A sweep of the human-add, tab-switch, ghost-flag, draft, dynamic-combo, overflow, undo and opaque-write Agent specs passed. - The full Agent extension Vitest suite passes. (cherry picked from commit c5b5521)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-21T14:34:05.617Z",
"gitSha": "f8f10a2c8076c23d4fbf8cd34d9283948490b4b5",
"branch": "backport-21479-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2042.0569999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8980000000000006,
"layouts": 9,
"layoutDurationMs": 2.766,
"taskDurationMs": 555.447,
"heapDeltaBytes": -7038996,
"heapUsedBytes": 96675448,
"domNodes": -180,
"jsHeapTotalBytes": 2002944,
"scriptDurationMs": 13.195999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2040.4560000000629,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2200000000000006,
"layouts": 9,
"layoutDurationMs": 3.169,
"taskDurationMs": 571.547,
"heapDeltaBytes": -12761656,
"heapUsedBytes": 91513576,
"domNodes": -200,
"jsHeapTotalBytes": 2265088,
"scriptDurationMs": 14.637,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1907.256000000018,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.262,
"layouts": 11,
"layoutDurationMs": 3.7800000000000002,
"taskDurationMs": 962.64,
"heapDeltaBytes": -3709216,
"heapUsedBytes": 94731228,
"domNodes": -180,
"jsHeapTotalBytes": 7770112,
"scriptDurationMs": 170.46800000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.812389380530973,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.9760000000497,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.920999999999998,
"layouts": 10,
"layoutDurationMs": 2.999,
"taskDurationMs": 1020.7839999999999,
"heapDeltaBytes": -3352912,
"heapUsedBytes": 96471628,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 163.33,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66636363636363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.8899999999685,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.4510000000000005,
"layouts": 11,
"layoutDurationMs": 3.941,
"taskDurationMs": 507.7639999999999,
"heapDeltaBytes": 21584356,
"heapUsedBytes": 109047208,
"domNodes": 47,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 16.356,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.6279999999915,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.3790000000000004,
"layouts": 11,
"layoutDurationMs": 3.1029999999999998,
"taskDurationMs": 454.042,
"heapDeltaBytes": 1869228,
"heapUsedBytes": 106206776,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 13.523999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 773.3409999999594,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.2279999999999998,
"layouts": 8,
"layoutDurationMs": 2.93,
"taskDurationMs": 570.311,
"heapDeltaBytes": 7239720,
"heapUsedBytes": 111079792,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 173.65,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66304347826087,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 733.2239999999501,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3419999999999996,
"layouts": 9,
"layoutDurationMs": 2.9569999999999994,
"taskDurationMs": 506.29,
"heapDeltaBytes": 702548,
"heapUsedBytes": 88259756,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 184.43599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818182,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1278.1980000000317,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 958.7150000000001,
"heapDeltaBytes": -8450280,
"heapUsedBytes": 102189404,
"domNodes": -230,
"jsHeapTotalBytes": 9875456,
"scriptDurationMs": 63.27100000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 582,
"frameDurationMs": 34.68378378378379,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1260.575000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 926.6270000000001,
"heapDeltaBytes": -9043832,
"heapUsedBytes": 101996452,
"domNodes": -230,
"jsHeapTotalBytes": 10661888,
"scriptDurationMs": 62.4,
"eventListeners": -168,
"totalBlockingTimeMs": 575,
"frameDurationMs": 34.23513513513513,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 818.416999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.71300000000065,
"heapDeltaBytes": -4404228,
"heapUsedBytes": 92096228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.59500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 181,
"frameDurationMs": 24.020588235294138,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 810.7049999999845,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.72799999999967,
"heapDeltaBytes": -4197448,
"heapUsedBytes": 97158100,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 139.222,
"eventListeners": 0,
"totalBlockingTimeMs": 189,
"frameDurationMs": 24.017647058823542,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10812.872000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9907.658,
"heapDeltaBytes": 15310464,
"heapUsedBytes": 137554240,
"domNodes": -276,
"jsHeapTotalBytes": 40865792,
"scriptDurationMs": 7615.95,
"eventListeners": -130,
"totalBlockingTimeMs": 854,
"frameDurationMs": 31.626315789473686,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9196.820000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8364.936,
"heapDeltaBytes": 33676232,
"heapUsedBytes": 147467508,
"domNodes": -296,
"jsHeapTotalBytes": 23302144,
"scriptDurationMs": 6639.771,
"eventListeners": -130,
"totalBlockingTimeMs": 260,
"frameDurationMs": 30.563455149501657,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9108.464999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8288.521,
"heapDeltaBytes": 18578948,
"heapUsedBytes": 140645624,
"domNodes": -276,
"jsHeapTotalBytes": 31887360,
"scriptDurationMs": 6611.634,
"eventListeners": -130,
"totalBlockingTimeMs": 269,
"frameDurationMs": 29.83475409836066,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9349.38199999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04900000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8520.453,
"heapDeltaBytes": 17792876,
"heapUsedBytes": 139304532,
"domNodes": -277,
"jsHeapTotalBytes": 31363072,
"scriptDurationMs": 6758.116,
"eventListeners": -130,
"totalBlockingTimeMs": 275,
"frameDurationMs": 30.554575163398695,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 245.45700000004445,
"styleRecalcs": 26,
"styleRecalcDurationMs": 15.584,
"layouts": 11,
"layoutDurationMs": 3.6729999999999996,
"taskDurationMs": 183.373,
"heapDeltaBytes": 13236872,
"heapUsedBytes": 119504896,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.165,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 261.0770000000002,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.504,
"layouts": 12,
"layoutDurationMs": 4.024,
"taskDurationMs": 205.98399999999998,
"heapDeltaBytes": 13285224,
"heapUsedBytes": 117786128,
"domNodes": 917,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 10.768,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 22.73636363636367,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2057.2559999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.503,
"layouts": 7,
"layoutDurationMs": 2.228,
"taskDurationMs": 594.258,
"heapDeltaBytes": 772376,
"heapUsedBytes": 103844696,
"domNodes": -296,
"jsHeapTotalBytes": -5599232,
"scriptDurationMs": 38.703,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.60800000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.368000000000001,
"layouts": 7,
"layoutDurationMs": 2.2239999999999998,
"taskDurationMs": 637.585,
"heapDeltaBytes": 9752668,
"heapUsedBytes": 112208808,
"domNodes": -276,
"jsHeapTotalBytes": -5074944,
"scriptDurationMs": 41.711000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2798.6610000000383,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.584999999999999,
"layouts": 6,
"layoutDurationMs": 1.8010000000000002,
"taskDurationMs": 1856.3460000000002,
"heapDeltaBytes": -16851860,
"heapUsedBytes": 87751124,
"domNodes": -296,
"jsHeapTotalBytes": -1339392,
"scriptDurationMs": 820.175,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.867878787878787,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3043.4099999999944,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.028000000000002,
"layouts": 7,
"layoutDurationMs": 2.029,
"taskDurationMs": 1807.051,
"heapDeltaBytes": 3231580,
"heapUsedBytes": 104991152,
"domNodes": -276,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 904.595,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4070.2320000000327,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.854999999999999,
"layouts": 64,
"layoutDurationMs": 11.873999999999999,
"taskDurationMs": 2039.0359999999998,
"heapDeltaBytes": -22364488,
"heapUsedBytes": 92142812,
"domNodes": -272,
"jsHeapTotalBytes": -159744,
"scriptDurationMs": 836.723,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3621.748999999909,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.277999999999999,
"layouts": 64,
"layoutDurationMs": 11.205,
"taskDurationMs": 1734.4630000000002,
"heapDeltaBytes": -10947296,
"heapUsedBytes": 92582224,
"domNodes": -253,
"jsHeapTotalBytes": -1273856,
"scriptDurationMs": 791.656,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3217.759000000001,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.856,
"layouts": 5,
"layoutDurationMs": 1.5439999999999998,
"taskDurationMs": 2088.8830000000003,
"heapDeltaBytes": -9357836,
"heapUsedBytes": 95370996,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 1094.212,
"eventListeners": 182,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.01684210526316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3236.8850000000293,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.978,
"layouts": 5,
"layoutDurationMs": 1.5290000000000004,
"taskDurationMs": 2021.17,
"heapDeltaBytes": -8036736,
"heapUsedBytes": 98761584,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 1032.858,
"eventListeners": 182,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.104736842105265,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.53599999997,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.1790000000000003,
"layouts": 6,
"layoutDurationMs": 2.2220000000000004,
"taskDurationMs": 598.453,
"heapDeltaBytes": 9617508,
"heapUsedBytes": 113258304,
"domNodes": -276,
"jsHeapTotalBytes": -5861376,
"scriptDurationMs": 35.86500000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.7220000000216,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4419999999999997,
"layouts": 7,
"layoutDurationMs": 2.4859999999999998,
"taskDurationMs": 576.2199999999999,
"heapDeltaBytes": 10117956,
"heapUsedBytes": 112885360,
"domNodes": -276,
"jsHeapTotalBytes": -4550656,
"scriptDurationMs": 37.346,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 757.362999999998,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.922999999999999,
"layouts": 9,
"layoutDurationMs": 2.993,
"taskDurationMs": 514.216,
"heapDeltaBytes": 3120236,
"heapUsedBytes": 108831400,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 148.63199999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.0480000000571,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.066999999999999,
"layouts": 10,
"layoutDurationMs": 3.0010000000000003,
"taskDurationMs": 411.998,
"heapDeltaBytes": 2701804,
"heapUsedBytes": 108911676,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 143.588,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2073.165999999958,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.449,
"layouts": 10,
"layoutDurationMs": 3.076,
"taskDurationMs": 701.2239999999999,
"heapDeltaBytes": -13370048,
"heapUsedBytes": 92819136,
"domNodes": -218,
"jsHeapTotalBytes": 2789376,
"scriptDurationMs": 13.225999999999997,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2054.7490000000153,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3810000000000002,
"layouts": 10,
"layoutDurationMs": 3.5320000000000005,
"taskDurationMs": 720.468,
"heapDeltaBytes": -7971224,
"heapUsedBytes": 97790416,
"domNodes": -199,
"jsHeapTotalBytes": 3051520,
"scriptDurationMs": 12.795000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.547000000026,
"styleRecalcs": 79,
"styleRecalcDurationMs": 15.25,
"layouts": 9,
"layoutDurationMs": 2.611,
"taskDurationMs": 957.489,
"heapDeltaBytes": -6326240,
"heapUsedBytes": 94014204,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 116.25300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2086.022000000071,
"styleRecalcs": 89,
"styleRecalcDurationMs": 17.88,
"layouts": 8,
"layoutDurationMs": 2.869,
"taskDurationMs": 1316.335,
"heapDeltaBytes": -15380892,
"heapUsedBytes": 90010576,
"domNodes": -190,
"jsHeapTotalBytes": 3313664,
"scriptDurationMs": 127.057,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665600000000005,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1099.0639999999985,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.149000000000004,
"layouts": 5,
"layoutDurationMs": 14.121999999999996,
"taskDurationMs": 848.4129999999999,
"heapDeltaBytes": 35544988,
"heapUsedBytes": 135265032,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 28.731999999999992,
"eventListeners": 3244,
"totalBlockingTimeMs": 163,
"frameDurationMs": 21.153846153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8569.491000000027,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.973,
"layouts": 6,
"layoutDurationMs": 1.6170000000000004,
"taskDurationMs": 5972.7519999999995,
"heapDeltaBytes": 6111396,
"heapUsedBytes": 108235564,
"domNodes": -276,
"jsHeapTotalBytes": -3833856,
"scriptDurationMs": 2898.796,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.731054687500002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8395.128,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.633999999999997,
"layouts": 8,
"layoutDurationMs": 1.9309999999999996,
"taskDurationMs": 5590.246999999999,
"heapDeltaBytes": -4091992,
"heapUsedBytes": 107733056,
"domNodes": -296,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 2717.3819999999996,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69920477137177,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14227.57899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13533.178,
"heapDeltaBytes": -22371428,
"heapUsedBytes": 287678488,
"domNodes": -3344,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 236.095,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.37040998217469,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14365.461000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13579.359999999999,
"heapDeltaBytes": -11096112,
"heapUsedBytes": 296992588,
"domNodes": -3344,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 259.784,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.337037037037042,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 17154.646999999954,
"styleRecalcs": 112,
"styleRecalcDurationMs": 15.621999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16886.115,
"heapDeltaBytes": -21338848,
"heapUsedBytes": 304367864,
"domNodes": -3344,
"jsHeapTotalBytes": 22269952,
"scriptDurationMs": 824.3090000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 32.23552631578947,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 16947.284999999967,
"styleRecalcs": 110,
"styleRecalcDurationMs": 14.574000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16531.880999999998,
"heapDeltaBytes": -5490880,
"heapUsedBytes": 304716216,
"domNodes": -3344,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 799.064,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 30.903460837887067,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 7608.000000000061,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.91900000000001,
"layouts": 20,
"layoutDurationMs": 32.36499999999999,
"taskDurationMs": 7482.583,
"heapDeltaBytes": -28401396,
"heapUsedBytes": 282088844,
"domNodes": -3344,
"jsHeapTotalBytes": 2609152,
"scriptDurationMs": 123.706,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.18068181818182,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7468.166999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.238,
"layouts": 20,
"layoutDurationMs": 36.286999999999985,
"taskDurationMs": 7403.526,
"heapDeltaBytes": -43856252,
"heapUsedBytes": 276423956,
"domNodes": -3344,
"jsHeapTotalBytes": 1298432,
"scriptDurationMs": 120.17699999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.665142857142854,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10589.337,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10368.698,
"heapDeltaBytes": -9417968,
"heapUsedBytes": 532410412,
"domNodes": 0,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 146.43700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.66156583629893,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10234.21200000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9991.851,
"heapDeltaBytes": 89916,
"heapUsedBytes": 289471152,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.89000000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.749280575539565,
"p95FrameDurationMs": 83.20000000000073
},
{
"name": "workflow-execution",
"durationMs": 507.07999999997355,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.328000000000001,
"layouts": 11,
"layoutDurationMs": 4.474,
"taskDurationMs": 172.212,
"heapDeltaBytes": -12388552,
"heapUsedBytes": 89420656,
"domNodes": 124,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.620999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 513.6780000000272,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.885,
"layouts": 11,
"layoutDurationMs": 4.792,
"taskDurationMs": 155.347,
"heapDeltaBytes": -12637820,
"heapUsedBytes": 91189660,
"domNodes": 121,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.408,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 764.7549999999228,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.734,
"layouts": 76,
"layoutDurationMs": 21.644,
"taskDurationMs": 731.6590000000001,
"heapDeltaBytes": -11881352,
"heapUsedBytes": 82236704,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 349.085,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808516,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 613.6249999999563,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.721,
"layouts": 76,
"layoutDurationMs": 20.346,
"taskDurationMs": 566.7289999999999,
"heapDeltaBytes": 13203508,
"heapUsedBytes": 82292076,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 255.96400000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 876.9640000000436,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.287,
"layouts": 76,
"layoutDurationMs": 21.285999999999998,
"taskDurationMs": 843.9060000000001,
"heapDeltaBytes": 4389140,
"heapUsedBytes": 125208960,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 362.355,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.9846153846154,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 581.470999999965,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.753,
"layouts": 76,
"layoutDurationMs": 15.978,
"taskDurationMs": 535.812,
"heapDeltaBytes": -820748,
"heapUsedBytes": 124055844,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 211.72,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2951 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 01fdaf0dd1b53c87b0dd7cc3022d99b71cd3f4ed
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (114)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #21544 +/- ##
=============================================
Coverage ? 86.16%
=============================================
Files ? 2786
Lines ? 154641
Branches ? 39206
=============================================
Hits ? 133248
Misses ? 21004
Partials ? 389
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 1 |
Panel: 6/6 reviewers contributed findings.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 883ad2a has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
… the Agent boundary (#21479) (#21629) ## Summary Backport of #21479 to `cloud/1.56` (FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter declares `widgets_values_form` from the live widget order. - `cherry-pick -x` of c5b5521. Minter, minter unit tests and the new round-trip spec apply cleanly. - Two release resolutions, both test-only: - `agentCrdtRejectedNodeAdd.spec.ts` is not on `cloud/1.56` (it came with #20038, not carried here), so its edit is dropped. - The round-trip spec reads the host projection through `hostNode()`, which came with #18934. A second commit adds only that five-line reader. - Builds on #21336 (the PM-2003 backport of #21245), already on `cloud/1.56`. `@comfyorg/comfy-multi-player` is `0.3.10` here, as at the source merge, so no pin change is bundled. <details><summary>Full context for agent readers</summary> - Source: #21479 by @DrJKL, merged 2026-10-20T21:41:40Z. Sibling carriers already merged: #21533 (`core/1.57`), #21534 (`cloud/1.57`), #21544 (`cloud/1.58`). - Target tip at cherry-pick: `7c07d06f34`. No earlier carrier for #21479 targeted `cloud/1.56` (searched open and closed). - `core/1.56` is deliberately not carried: it pins comfy-multi-player 0.3.6, which has no `widgets_values_form` support (the A24 reader arrived in 0.3.9), and it never received the #21245 basis. - Moving the pin to 0.3.12 is #21535's job and stays gated on production Cloud serving cloud#14458. It is not part of this backport. - The posted turn draft still carries no form (separate client-seed recapture ticket), as on `main`. ### Verification on this head (local, `--project=cloud`, own ComfyUI container) - Red on the parent: with the new spec and fixture on `cloud/1.56` and the old minter, `agentWidgetFormRoundTrip.spec.ts` fails 2 of 2. The host refuses the add, the node leaves the canvas, and the panel shows "Your edit was rejected and was not saved." - Green on this head: the same spec passes. On repeats the final tab-return step fails about 1 run in 5. The same tab-switch helper also flakes in the unchanged `agentHumanAddTabSwitch.spec.ts` on the untouched `cloud/1.56` parent (1 of 21 there), so the flake is already on this branch, not caused by this change. - Sweep with one retry, covering draft-matches-canvas, opaque-write, dynamic-combo, human-add reload, human-add tab-switch, overflow, ghost-flag, remote-edit undo, undo/redo and widget-form round trip: 18 passed, 1 flaky (the ghost-flag tab switch, same helper). - Vitest `src/workbench/extensions/agent/`: 2958 passed. One unrelated timer test failed once and passed on rerun. `docOpMinter.test.ts` 87/87. - `typecheck`, `typecheck:browser`, eslint and the commit hooks pass. Carried under the program's standing Agent backport authority for the current `cloud/1.56` train. </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
Summary
Backport of #21479 to
cloud/1.58(FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter declareswidgets_values_formfrom the live widget order.Why
cloud/1.58: it is Cloud'sreleaseBranchand what staging and testcloud serve now, so the next production promotion ships it. It was cut frommainon 2026-10-19, a day before #21479 merged, so promoting it as-is would ship without this fix even thoughcloud/1.57(#21534) has it.Clean
cherry-pick -xof c5b5521, no conflict resolution,git patch-id --stableidentical to the source. #21245 (PM-2003), which this rewrites, is already oncloud/1.58.@comfyorg/comfy-multi-playeris0.3.10on the source and oncloud/1.58; no pin change is bundled.Full context for agent readers
c5b55212fd.01fdaf0dd1b53c87b0dd7cc3022d99b71cd3f4ed, which is also what stagingcloud and testcloud serve (x-frontend-version).c5b55212fdis not an ancestor of it, and no PR againstcloud/1.58carried fix(agent): declare every node's widget form at the Agent boundary #21479.ba2c2c2269(oncloud/1.57, before [backport cloud/1.57] fix(agent): declare every node's widget form at the Agent boundary (#21479) #21534), and Cloudfrontend-version.jsonreadsreleaseBranch: cloud/1.58. So [backport cloud/1.57] fix(agent): declare every node's widget form at the Agent boundary (#21479) #21534 oncloud/1.57reaches production only through acloud/1.57patch release. A routine staging→production promotion shipscloud/1.58.cloud/1.57carrier.cloud/1.58is not yet named in the program's release-train authority (which still lists 1.56 and 1.57), so this PR is opened for review and is not being self-merged.Verification
Local ComfyUI CI container backend,
DISTRIBUTION=clouddev server,--project=cloud --retries=0, at this branch's head:docOpMinter.tsreverted tocloud/1.58,agentWidgetFormRoundTrip.spec.tsfails at line 54. The host refuses the node and it leaves the canvas ([data-node-id=…]not found).agentWidgetFormRoundTrip.spec.tsandagentCrdtRejectedNodeAdd.spec.ts, 2/2.docOpMinter.test.ts104/104. Fullsrc/workbench/extensions/agent: 175 files, 3927 passed, 1 expected fail.typecheck:app,typecheck:browser) and pre-push. The commit was re-created withcommit -Cso the hooks ran; the tree is unchanged.