Repository navigation
[backport cloud/1.56] fix(agent): declare every node's widget form at the Agent boundary (#21479) - #21629
Conversation
…21479) A human `add_node` for a class the doc host's pinned catalog lacks is refused (`uncatalogued_widget_write`) even when the frontend definition describes every widget. The minter decided whether to declare `widgets_values_form` by asking whether the frontend definition covered the widgets, and that check cannot see the host's catalog. `wireNodeSnapshot` now declares the form from the live widget order for every non-virtual node with value widgets. All of the change stays in the Agent minter. ```text wireNodeSnapshot(node) values = value widgets from widgets_values_named no form when the definition has a dynamic combo, dynamic group, or autogrow input no form when a widget name is empty or repeated otherwise form = { order: live widget names that have values } ``` - The dynamic-layout skip is needed only until a comfy-multi-player release that contains Comfy-Org/comfy-multi-player#288 is pinned. Removing it then means deleting one condition. - This is an alternative to #21329. It fixes the same add-node refusal without adding inference, validation, a policy seam, or a `widgets_values_form` field to core serialization. - Not in scope: the posted turn draft still carries no form, which is the separate client-seed recapture ticket. Because more nodes now carry a form, that recapture mismatch affects more documents than before. Linear: FE-3470 - Unit: the minter's A24 tests cover declaring and declining the form, real widget constructors, a carried-in projection form, applier acceptance when the catalog lacks the class or lists no widgets, and a catalogued dynamic combo that stays writable after its selection changes. The described-class and closed-order cases fail against the old minter. Removing the dynamic skip, the closed-order check, or the live widget ordering each fails its own rows. - Browser (`--project=cloud`, local backend): the new widget-form round trip fails on `main` (the host refuses the node and it leaves the canvas) and passes here. The rejected-add case now adds an uncatalogued dynamic-combo class, which is still refused, and passes. A sweep of the human-add, tab-switch, ghost-flag, draft, dynamic-combo, overflow, undo and opaque-write Agent specs passed. - The full Agent extension Vitest suite passes. (cherry picked from commit c5b5521)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-22T01:40:42.700Z",
"gitSha": "3728383696dbebc59b098fc6391e38ee19d7c73c",
"branch": "backport-21479-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.595000000014,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.0669999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.552,
"heapDeltaBytes": 661980,
"heapUsedBytes": 68595812,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.836000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2010.7619999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.416000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.745,
"heapDeltaBytes": 571532,
"heapUsedBytes": 68544920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.056,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.6149999999793,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.31,
"layouts": 12,
"layoutDurationMs": 3.181,
"taskDurationMs": 576.8249999999999,
"heapDeltaBytes": -2495796,
"heapUsedBytes": 65003768,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 109.27900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.2410000000045,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.360999999999999,
"layouts": 12,
"layoutDurationMs": 2.6750000000000003,
"taskDurationMs": 546.783,
"heapDeltaBytes": 20136848,
"heapUsedBytes": 80425900,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.518,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.4080000000058,
"styleRecalcs": 31,
"styleRecalcDurationMs": 7.368,
"layouts": 6,
"layoutDurationMs": 1.0759999999999998,
"taskDurationMs": 253.568,
"heapDeltaBytes": -714256,
"heapUsedBytes": 59182564,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.471999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6459999999597,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.009,
"layouts": 6,
"layoutDurationMs": 1.175,
"taskDurationMs": 277.39900000000006,
"heapDeltaBytes": 4173620,
"heapUsedBytes": 72015612,
"domNodes": 53,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.114000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 523.2079999999542,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.1660000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.682,
"heapDeltaBytes": 14320528,
"heapUsedBytes": 69062584,
"domNodes": -231,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.79299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 534.7390000000019,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.5099999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.77099999999996,
"heapDeltaBytes": -6348076,
"heapUsedBytes": 61394460,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 111.81400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 981.2170000000151,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.6519999999999,
"heapDeltaBytes": 12682200,
"heapUsedBytes": 82228396,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 41.60299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 378,
"frameDurationMs": 29.796969696969704,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 981.6229999999564,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.6969999999999,
"heapDeltaBytes": 16082048,
"heapUsedBytes": 85045808,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 41.43799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 376,
"frameDurationMs": 29.796969696969704,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 732.7600000000416,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.8979999999998,
"heapDeltaBytes": -15425168,
"heapUsedBytes": 79573324,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 97.95300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 116,
"frameDurationMs": 21.567647058823535,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 732.9530000000091,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.8289999999998,
"heapDeltaBytes": 17497448,
"heapUsedBytes": 100612596,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 94.05799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 113,
"frameDurationMs": 21.570588235294107,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6650.08899999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0749999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5723.224,
"heapDeltaBytes": -11940440,
"heapUsedBytes": 72075312,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 4515.458,
"eventListeners": -74,
"totalBlockingTimeMs": 76,
"frameDurationMs": 25.317557251908397,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6171.241000000009,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8649999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5258.667,
"heapDeltaBytes": 15231904,
"heapUsedBytes": 93817620,
"domNodes": -172,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 4148.736000000001,
"eventListeners": -86,
"totalBlockingTimeMs": 42,
"frameDurationMs": 24.21181102362205,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6323.046999999974,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9709999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5522.195,
"heapDeltaBytes": -15397684,
"heapUsedBytes": 69471844,
"domNodes": -172,
"jsHeapTotalBytes": -2232320,
"scriptDurationMs": 4373.186,
"eventListeners": -86,
"totalBlockingTimeMs": 41,
"frameDurationMs": 25.43413654618474,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6276.960000000031,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6560000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5522.402,
"heapDeltaBytes": 16552784,
"heapUsedBytes": 94578820,
"domNodes": -142,
"jsHeapTotalBytes": -7737344,
"scriptDurationMs": 4377.317,
"eventListeners": -74,
"totalBlockingTimeMs": 43,
"frameDurationMs": 25.335080645161288,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2008.3999999999946,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1340000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.8499999999999,
"heapDeltaBytes": -10179796,
"heapUsedBytes": 77681916,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 24.322999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2011.197999999922,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6370000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.08200000000005,
"heapDeltaBytes": -9644296,
"heapUsedBytes": 78185960,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 21.337999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2115.608000000009,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.222,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1096.468,
"heapDeltaBytes": -20032120,
"heapUsedBytes": 68325400,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 554.408,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2135.701999999924,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.693,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1133.9139999999998,
"heapDeltaBytes": -19359568,
"heapUsedBytes": 70037644,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 583.672,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3082.1960000000104,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.386999999999999,
"layouts": 60,
"layoutDurationMs": 9.681000000000001,
"taskDurationMs": 1122.5339999999999,
"heapDeltaBytes": 1579196,
"heapUsedBytes": 70045292,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 512.591,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666486486486487,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3087.2659999999996,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.966000000000001,
"layouts": 60,
"layoutDurationMs": 10.045,
"taskDurationMs": 1144.3919999999998,
"heapDeltaBytes": -20821216,
"heapUsedBytes": 69898600,
"domNodes": 24,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 513.281,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2148.3649999999557,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.339,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1314.756,
"heapDeltaBytes": -13602828,
"heapUsedBytes": 68701880,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 658.879,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.796093749999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2141.6419999999334,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.594000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1292.782,
"heapDeltaBytes": 6227068,
"heapUsedBytes": 74831464,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 644.745,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.796093749999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.4919999999947,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.331999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.77400000000006,
"heapDeltaBytes": -9926976,
"heapUsedBytes": 79126052,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 21.544999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.1809999999841,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.236,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.02400000000006,
"heapDeltaBytes": -9907864,
"heapUsedBytes": 79495356,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.408999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 458.97600000000693,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.795,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.29800000000006,
"heapDeltaBytes": -12195956,
"heapUsedBytes": 57781872,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 91.98200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 483.0490000000509,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.24,
"heapDeltaBytes": 9902228,
"heapUsedBytes": 72382644,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.161,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66206896551725,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.6429999999732,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.908000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.01599999999996,
"heapDeltaBytes": 1146556,
"heapUsedBytes": 71403948,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.180000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.5270000000482,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.005999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.963,
"heapDeltaBytes": 1176200,
"heapUsedBytes": 71169520,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.548999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.7850000000049,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.068000000000001,
"layouts": 16,
"layoutDurationMs": 3.768,
"taskDurationMs": 537.4859999999999,
"heapDeltaBytes": -5859180,
"heapUsedBytes": 64155072,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 67.107,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1674.4350000000168,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.394,
"layouts": 16,
"layoutDurationMs": 3.235,
"taskDurationMs": 506.01300000000003,
"heapDeltaBytes": 17376128,
"heapUsedBytes": 81181048,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 65.267,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673267,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.4430000000525,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.705999999999996,
"layouts": 5,
"layoutDurationMs": 9.571,
"taskDurationMs": 704.259,
"heapDeltaBytes": -2588560,
"heapUsedBytes": 89908552,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.778,
"eventListeners": 2463,
"totalBlockingTimeMs": 106,
"frameDurationMs": 20.452272727272717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8166.513000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.744,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3964.7350000000006,
"heapDeltaBytes": 15179236,
"heapUsedBytes": 87986612,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 1893.5469999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.146000000022,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4191.682999999999,
"heapDeltaBytes": -18757036,
"heapUsedBytes": 69605896,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2015.2870000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11308.482000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10320.726,
"heapDeltaBytes": -39880396,
"heapUsedBytes": 186545552,
"domNodes": -3046,
"jsHeapTotalBytes": 16011264,
"scriptDurationMs": 138.048,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.022727272727277,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 12090.138999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11129.240000000002,
"heapDeltaBytes": -36240804,
"heapUsedBytes": 179806152,
"domNodes": -3045,
"jsHeapTotalBytes": 5197824,
"scriptDurationMs": 175.16799999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.507627118644066,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 13963.545000000011,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.47899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13369.739,
"heapDeltaBytes": -29328072,
"heapUsedBytes": 169396236,
"domNodes": -3045,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 613.799,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.103770197486536,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 14507.400999999958,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.587000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13839.562000000002,
"heapDeltaBytes": -29970496,
"heapUsedBytes": 183747004,
"domNodes": -3046,
"jsHeapTotalBytes": 7163904,
"scriptDurationMs": 675.2520000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.630864197530865,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-node-resize-workload",
"durationMs": 4110.643999999979,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.905999999999985,
"layouts": 20,
"layoutDurationMs": 19.26599999999999,
"taskDurationMs": 3932.047,
"heapDeltaBytes": 1236704,
"heapUsedBytes": 211964720,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 61.503,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.798192771084338,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4462.50699999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.88399999999999,
"layouts": 20,
"layoutDurationMs": 21.467,
"taskDurationMs": 4311.6089999999995,
"heapDeltaBytes": 1212932,
"heapUsedBytes": 216106632,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 74.79299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.09269662921348,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5718.596999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5308.482,
"heapDeltaBytes": -29403096,
"heapUsedBytes": 178949984,
"domNodes": -3045,
"jsHeapTotalBytes": 806912,
"scriptDurationMs": 106.08200000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.055,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6346.617999999921,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5804.267000000001,
"heapDeltaBytes": -50238056,
"heapUsedBytes": 166643516,
"domNodes": -3045,
"jsHeapTotalBytes": 5963776,
"scriptDurationMs": 94.51500000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.37946127946128,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 109.97199999997065,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.746999999999998,
"layouts": 4,
"layoutDurationMs": 1.5190000000000001,
"taskDurationMs": 71.99,
"heapDeltaBytes": 3938520,
"heapUsedBytes": 69175436,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.017999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 89.9979999999232,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.5,
"layouts": 3,
"layoutDurationMs": 1.254,
"taskDurationMs": 56.537000000000006,
"heapDeltaBytes": 3659996,
"heapUsedBytes": 69220176,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.936999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 417.3289999999952,
"styleRecalcs": 78,
"styleRecalcDurationMs": 70.177,
"layouts": 76,
"layoutDurationMs": 16.153000000000002,
"taskDurationMs": 383.819,
"heapDeltaBytes": -10642540,
"heapUsedBytes": 77690512,
"domNodes": 76,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 127.63,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 434.43600000000515,
"styleRecalcs": 78,
"styleRecalcDurationMs": 69.64099999999999,
"layouts": 76,
"layoutDurationMs": 15.661000000000001,
"taskDurationMs": 400.613,
"heapDeltaBytes": -10543788,
"heapUsedBytes": 78002336,
"domNodes": 76,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 140.184,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 687.8070000000207,
"styleRecalcs": 78,
"styleRecalcDurationMs": 168.743,
"layouts": 76,
"layoutDurationMs": 16.339,
"taskDurationMs": 651.6410000000001,
"heapDeltaBytes": 8207716,
"heapUsedBytes": 137802564,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.901,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.073170731707318,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 732.3300000000472,
"styleRecalcs": 78,
"styleRecalcDurationMs": 179.607,
"layouts": 76,
"layoutDurationMs": 16.07,
"taskDurationMs": 707.5780000000001,
"heapDeltaBytes": 3604908,
"heapUsedBytes": 110321884,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 199.244,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2203 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7c07d06f34480fdf8e1b381c26e0cd0a718002f5
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #21629 +/- ##
=============================================
Coverage ? 84.58%
=============================================
Files ? 2578
Lines ? 147258
Branches ? 39058
=============================================
Hits ? 124565
Misses ? 22307
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review (author-side; GitHub refuses self-approval, so this is a COMMENT).
- Diff matches #21479: clean cherry-pick of the minter, its tests and the new spec. The only differences are two test-only resolutions for files
cloud/1.56lacks. - Red on the parent (2/2: host refuses the add, node leaves the canvas). Green on this head.
- Exact-head CI green and merge-ready gate passed at
6aa9251a01oncloud/1.56@7c07d06f34.
Full context for agent readers
- Authority: standing Agent backport review/merge grant for the current
cloud/1.56train (program release-backport authority, Christian 2026-09-16, current-train corrections 2026-10-09/10). - Local harness,
--project=cloud: Agent sweep of 10 specs, 18 passed and 1 flaky. The flaky test is the tab-switch helper, which also flakes on the untouched parent. core/1.56intentionally not carried: it pins comfy-multi-player 0.3.6, which has nowidgets_values_formreader.- The pin move to 0.3.12 stays with #21535 and its production-first gate.
Summary
Backport of #21479 to
cloud/1.56(FE-3470). A human-added node whose class the doc host's pinned catalog lacks is no longer refused; the Agent minter declareswidgets_values_formfrom the live widget order.cherry-pick -xof c5b5521. Minter, minter unit tests and the new round-trip spec apply cleanly.agentCrdtRejectedNodeAdd.spec.tsis not oncloud/1.56(it came with test(agent): black-box case for a human node add the doc host refuses #20038, not carried here), so its edit is dropped.hostNode(), which came with test(agent): guard a ghosted placement flag out of a rebuilt node #18934. A second commit adds only that five-line reader.cloud/1.56.@comfyorg/comfy-multi-playeris0.3.10here, as at the source merge, so no pin change is bundled.Full context for agent readers
core/1.57), [backport cloud/1.57] fix(agent): declare every node's widget form at the Agent boundary (#21479) #21534 (cloud/1.57), [backport cloud/1.58] fix(agent): declare every node's widget form at the Agent boundary (#21479) #21544 (cloud/1.58).7c07d06f34. No earlier carrier for fix(agent): declare every node's widget form at the Agent boundary #21479 targetedcloud/1.56(searched open and closed).core/1.56is deliberately not carried: it pins comfy-multi-player 0.3.6, which has nowidgets_values_formsupport (the A24 reader arrived in 0.3.9), and it never received the fix(agent-crdt): declare a node's own widget form when its definition does not describe a widget (PM-2003) #21245 basis.main.Verification on this head (local,
--project=cloud, own ComfyUI container)cloud/1.56and the old minter,agentWidgetFormRoundTrip.spec.tsfails 2 of 2. The host refuses the add, the node leaves the canvas, and the panel shows "Your edit was rejected and was not saved."agentHumanAddTabSwitch.spec.tson the untouchedcloud/1.56parent (1 of 21 there), so the flake is already on this branch, not caused by this change.src/workbench/extensions/agent/: 2958 passed. One unrelated timer test failed once and passed on rerun.docOpMinter.test.ts87/87.typecheck,typecheck:browser, eslint and the commit hooks pass.Carried under the program's standing Agent backport authority for the current
cloud/1.56train.