Repository navigation
[backport cloud/1.58] fix: create restored above-max DynamicGroups on followers - #21523
Conversation
> Stacked on #21264. Keep as draft until that merges; the base will be retargeted to `main` then. ## Summary A DynamicGroup restored from a saved workflow can hold more rows than its `max`. When that node reaches another tab through the shared doc, the follower's create path configures it with only the widgets a fresh node has. The row values are dropped, `validateSavedRowCount` throws, and the follower records an apply failure and ends up with 0 rows. - Fixes #21279 - Part of #21094 (item 1: remote create now goes through the remote row-count path) On create, `createNode` now holds a DynamicGroup row count at its constructed value during `configure`, then applies it with the row values through the existing widget rounds. There the remote row-count guard from #21264 lets a real restored group through, because its limit counts the rows the document carries values for: `max(max, current rows, documented rows)`. A crafted doc with a huge count and no row values is still refused before any row is allocated. **Scope:** the count is only deferred when the document stores it by name on a node **without** a DynamicCombo input. On a DynamicCombo node, positional `_extra_N` aliases can address slots that the rows would shift, so those nodes keep the existing `configure` path exactly as before. That keeps this PR free of the alias edge cases Cursor kept finding. The DynamicCombo-node case is tracked in #21297, and a test asserts today's behavior there (0 rows, one failure). ## Red-Green Verification | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: cover creating a restored above-max DynamicGroup on a follower` (612c215) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39108094938) | Proves the test catches the bug | | `fix: create restored above-max DynamicGroups on followers` (4733ced) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39108847535) | Proves the fix resolves the bug | | `test: create a DynamicGroup whose row count is stored under an overflow alias` (c12b1cd) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39134067553) | Cursor: an alias-stored count was dropped on create | | `test: keep aliased DynamicGroup row values off a trailing widget on create` (04427b5) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39137999361) | Cursor: aliased row values landed on a trailing widget | | `test: cover a named DynamicGroup row count followed by aliased values on create` (4d85d35) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39141788205) | Cursor: a named count followed by aliases had the same shift | | `test: create a restored above-max DynamicGroup next to a stray overflow key` (c5c277b) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39145478948) | Cursor: a stray `_extra_9` brought back #21279 | | `test: cover a fully named catalog order on an overflow DynamicGroup node` (c48b631) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39149443794) | Cursor: a named trailing slot holding a row value | | `fix: defer DynamicGroup row counts only on nodes without overflow aliases` (6e9f43c) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39150420673) | Final behavior: every red case above passes | Each of the Cursor reds above also had its own fix commit in between (94daae4, 7a7f72d, 49aacc3, 9f67924), each with a green run. Those tried to handle aliases on DynamicCombo nodes, and 6e9f43c replaces all of them by keeping those nodes on the `configure` path. The test-only commits 6f438e8 and 7c3007f label the cases and pin today's #21297 behavior. The documented-rows part of the limit later moved into #21264 (bc77798) to fix a rollback regression there, and this branch picked it up through a merge. This PR's own diff is now just the create path. ## Test Plan - [x] CI red on each test-only commit, with only the new case failing - [x] CI green on the final fix commit - A restored 4-row group (`max: 3`) is created on a fresh follower with all 4 rows and no failure, also when a stray `_extra_9` sits in the doc. The stray key is still reported as a missing widget, which is existing behavior. - On a DynamicCombo node, alias-stored counts and row values restore exactly as before this PR, including with a widget after the group and a fully named catalog order. - Guard: a crafted doc with `rows = 1e9` and no row values is still refused on create (0 rows, one failure). - Known gap: a restored above-max group on a DynamicCombo node still ends with 0 rows and one failure (#21297). A test asserts that, so a change on this path shows up. - Reviewed beyond Cursor's 5-round cap with internal bug-hunter, regression-risk, architecture, christian-style and drjkl-style agents. Their actionable points are folded into 6e9f43c, 6f438e8 and 7c3007f; a second pass found no blocking issues.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-21T03:51:28.233Z",
"gitSha": "af9f4723771c0ad0c7e5b7ec484525048fafeb31",
"branch": "backport-21280-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.6489999999872,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.5589999999999997,
"layouts": 11,
"layoutDurationMs": 3.0309999999999997,
"taskDurationMs": 443.583,
"heapDeltaBytes": -22161740,
"heapUsedBytes": 81956012,
"domNodes": -200,
"jsHeapTotalBytes": 1458176,
"scriptDurationMs": 10.954,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.066999999959,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.313,
"layouts": 10,
"layoutDurationMs": 2.226,
"taskDurationMs": 326.346,
"heapDeltaBytes": 4769512,
"heapUsedBytes": 103082492,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 6.9369999999999985,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1961.5330000000313,
"styleRecalcs": 81,
"styleRecalcDurationMs": 14.422,
"layouts": 10,
"layoutDurationMs": 2.5370000000000004,
"taskDurationMs": 876.135,
"heapDeltaBytes": -24811508,
"heapUsedBytes": 79490780,
"domNodes": -200,
"jsHeapTotalBytes": 2338816,
"scriptDurationMs": 117.15199999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.8050000000267,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.161999999999999,
"layouts": 10,
"layoutDurationMs": 2.9139999999999997,
"taskDurationMs": 631.4660000000001,
"heapDeltaBytes": -13160428,
"heapUsedBytes": 91077668,
"domNodes": -200,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 121.639,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.0119999999965,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.446,
"layouts": 12,
"layoutDurationMs": 3.117,
"taskDurationMs": 304.62199999999996,
"heapDeltaBytes": 4537532,
"heapUsedBytes": 102941728,
"domNodes": 47,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 12.573,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.1600000000499,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.824999999999999,
"layouts": 12,
"layoutDurationMs": 3.259,
"taskDurationMs": 358.877,
"heapDeltaBytes": 1780356,
"heapUsedBytes": 105622568,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 15.469999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 532.3720000000094,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.087,
"layouts": 9,
"layoutDurationMs": 2.59,
"taskDurationMs": 353.68300000000005,
"heapDeltaBytes": 6924504,
"heapUsedBytes": 111048416,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 116.16600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 550.6839999999329,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.039,
"layouts": 9,
"layoutDurationMs": 2.3819999999999997,
"taskDurationMs": 369.272,
"heapDeltaBytes": 6903364,
"heapUsedBytes": 110702808,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 118.02099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 921.2180000000103,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.12,
"heapDeltaBytes": -8376448,
"heapUsedBytes": 102188288,
"domNodes": -230,
"jsHeapTotalBytes": 9330688,
"scriptDurationMs": 41.17199999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 279,
"frameDurationMs": 26.188571428571425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 923.383000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.5819999999999,
"heapDeltaBytes": -8337800,
"heapUsedBytes": 101994204,
"domNodes": -210,
"jsHeapTotalBytes": 9068544,
"scriptDurationMs": 39.11600000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 292,
"frameDurationMs": 26.665714285714277,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 699.8080000000186,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.97899999999976,
"heapDeltaBytes": -5385704,
"heapUsedBytes": 95152924,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.527,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 21.215151515151526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 703.9630000000443,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.50399999999996,
"heapDeltaBytes": -5126392,
"heapUsedBytes": 96744232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 91.95999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 88,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6689.963000000034,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.2070000000000005,
"layouts": 4,
"layoutDurationMs": 0.964,
"taskDurationMs": 5708.311,
"heapDeltaBytes": 23067332,
"heapUsedBytes": 127644792,
"domNodes": -276,
"jsHeapTotalBytes": 15343616,
"scriptDurationMs": 4179.11,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.678395061728395,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6686.947000000032,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1019999999999996,
"layouts": 4,
"layoutDurationMs": 0.9610000000000001,
"taskDurationMs": 5590.110000000001,
"heapDeltaBytes": 30917408,
"heapUsedBytes": 152443856,
"domNodes": -277,
"jsHeapTotalBytes": 30515200,
"scriptDurationMs": 4418.608,
"eventListeners": -130,
"totalBlockingTimeMs": 85,
"frameDurationMs": 21.28343949044586,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6503.555000000006,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.182,
"layouts": 4,
"layoutDurationMs": 1.0179999999999998,
"taskDurationMs": 5390.563,
"heapDeltaBytes": 18556868,
"heapUsedBytes": 140339256,
"domNodes": -296,
"jsHeapTotalBytes": 31039488,
"scriptDurationMs": 4219.455,
"eventListeners": -130,
"totalBlockingTimeMs": 27,
"frameDurationMs": 20.51582278481013,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6453.330000000051,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.13,
"layouts": 4,
"layoutDurationMs": 0.9299999999999998,
"taskDurationMs": 5289.345,
"heapDeltaBytes": 15471356,
"heapUsedBytes": 137190720,
"domNodes": -296,
"jsHeapTotalBytes": 28418048,
"scriptDurationMs": 4121.061,
"eventListeners": -130,
"totalBlockingTimeMs": 37,
"frameDurationMs": 20.487898089171974,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 154.4900000000098,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.516,
"layouts": 14,
"layoutDurationMs": 3.614,
"taskDurationMs": 109.049,
"heapDeltaBytes": 13265560,
"heapUsedBytes": 118209440,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.236,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.76249999999999,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 157.01500000000124,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.408000000000001,
"layouts": 11,
"layoutDurationMs": 2.8920000000000003,
"taskDurationMs": 112.70700000000001,
"heapDeltaBytes": 13281388,
"heapUsedBytes": 117907404,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.574,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.41428571428573,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2025.73000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.196,
"layouts": 9,
"layoutDurationMs": 2.5979999999999994,
"taskDurationMs": 478.21200000000005,
"heapDeltaBytes": 1763828,
"heapUsedBytes": 103639548,
"domNodes": -282,
"jsHeapTotalBytes": -4349952,
"scriptDurationMs": 30.718000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.6490000000067,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.190000000000001,
"layouts": 8,
"layoutDurationMs": 1.886,
"taskDurationMs": 450.3860000000001,
"heapDeltaBytes": 4403688,
"heapUsedBytes": 108167264,
"domNodes": -276,
"jsHeapTotalBytes": -1957888,
"scriptDurationMs": 26.828,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2514.7570000000314,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.946000000000002,
"layouts": 8,
"layoutDurationMs": 1.9340000000000002,
"taskDurationMs": 1221.3780000000002,
"heapDeltaBytes": -12910488,
"heapUsedBytes": 99324268,
"domNodes": -296,
"jsHeapTotalBytes": -684032,
"scriptDurationMs": 573.994,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66622516556291,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2433.8169999999764,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.966,
"layouts": 9,
"layoutDurationMs": 2.1330000000000005,
"taskDurationMs": 1219.8799999999999,
"heapDeltaBytes": 3730504,
"heapUsedBytes": 107252836,
"domNodes": -296,
"jsHeapTotalBytes": -1503232,
"scriptDurationMs": 555.448,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666438356164385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3736.6989999999873,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.621999999999998,
"layouts": 66,
"layoutDurationMs": 13.713,
"taskDurationMs": 1359.834,
"heapDeltaBytes": 6710312,
"heapUsedBytes": 112233872,
"domNodes": 24,
"jsHeapTotalBytes": 4460544,
"scriptDurationMs": 589.646,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3554.4570000000704,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.174,
"layouts": 68,
"layoutDurationMs": 12.246,
"taskDurationMs": 1331.609,
"heapDeltaBytes": -13841332,
"heapUsedBytes": 90950600,
"domNodes": -273,
"jsHeapTotalBytes": -1597440,
"scriptDurationMs": 565.018,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665727699530517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2989.4879999999944,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.697000000000001,
"layouts": 7,
"layoutDurationMs": 1.8580000000000003,
"taskDurationMs": 1491.306,
"heapDeltaBytes": 22135828,
"heapUsedBytes": 129239528,
"domNodes": 0,
"jsHeapTotalBytes": 5664768,
"scriptDurationMs": 739.22,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611111111111,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2450.078000000076,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.796999999999999,
"layouts": 7,
"layoutDurationMs": 1.7979999999999996,
"taskDurationMs": 1390.524,
"heapDeltaBytes": -12236000,
"heapUsedBytes": 104425592,
"domNodes": 0,
"jsHeapTotalBytes": 6033408,
"scriptDurationMs": 683.0580000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.4069999999538,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4410000000000003,
"layouts": 9,
"layoutDurationMs": 2.111,
"taskDurationMs": 358.396,
"heapDeltaBytes": 7964084,
"heapUsedBytes": 110891132,
"domNodes": -276,
"jsHeapTotalBytes": -6709248,
"scriptDurationMs": 29.582,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2052.1360000000186,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9630000000000005,
"layouts": 8,
"layoutDurationMs": 2.4459999999999997,
"taskDurationMs": 542.253,
"heapDeltaBytes": 4019232,
"heapUsedBytes": 106983408,
"domNodes": -276,
"jsHeapTotalBytes": -5492736,
"scriptDurationMs": 33.029999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.3669999999738,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.158000000000001,
"layouts": 11,
"layoutDurationMs": 2.9889999999999994,
"taskDurationMs": 325.21299999999997,
"heapDeltaBytes": 2759936,
"heapUsedBytes": 108948512,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 104.91300000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 529.7319999999672,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.512,
"layouts": 10,
"layoutDurationMs": 2.7610000000000006,
"taskDurationMs": 341.78200000000004,
"heapDeltaBytes": -852240,
"heapUsedBytes": 100026680,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 109.49400000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2005.0719999999842,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4250000000000003,
"layouts": 11,
"layoutDurationMs": 3.037,
"taskDurationMs": 365.99,
"heapDeltaBytes": 3482356,
"heapUsedBytes": 96080944,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.232,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2027.4560000000292,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9179999999999997,
"layouts": 9,
"layoutDurationMs": 2.3600000000000003,
"taskDurationMs": 402.891,
"heapDeltaBytes": -11169656,
"heapUsedBytes": 95118596,
"domNodes": -218,
"jsHeapTotalBytes": 2465792,
"scriptDurationMs": 11.022000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.542000000003,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.834,
"layouts": 9,
"layoutDurationMs": 2.267,
"taskDurationMs": 637.408,
"heapDeltaBytes": -4092384,
"heapUsedBytes": 104438956,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 95.107,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.5330000000022,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.788,
"layouts": 10,
"layoutDurationMs": 2.6279999999999997,
"taskDurationMs": 660.0429999999999,
"heapDeltaBytes": -18166996,
"heapUsedBytes": 87544124,
"domNodes": -190,
"jsHeapTotalBytes": 2244608,
"scriptDurationMs": 91.472,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 901.0990000000447,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.836000000000002,
"layouts": 5,
"layoutDurationMs": 10.156,
"taskDurationMs": 674.8070000000001,
"heapDeltaBytes": 6968284,
"heapUsedBytes": 124832648,
"domNodes": 16030,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 20.939,
"eventListeners": 3244,
"totalBlockingTimeMs": 95,
"frameDurationMs": 19.565217391304348,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9956.940999999972,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.611,
"layouts": 8,
"layoutDurationMs": 2.0610000000000004,
"taskDurationMs": 4596.304999999999,
"heapDeltaBytes": 9106632,
"heapUsedBytes": 112039108,
"domNodes": -296,
"jsHeapTotalBytes": -1011712,
"scriptDurationMs": 2114.447,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053511705687,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11352.065000000039,
"styleRecalcs": 252,
"styleRecalcDurationMs": 39.286,
"layouts": 9,
"layoutDurationMs": 2.572,
"taskDurationMs": 4979.599,
"heapDeltaBytes": 11596552,
"heapUsedBytes": 114799568,
"domNodes": -296,
"jsHeapTotalBytes": -319488,
"scriptDurationMs": 2252.455,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154187,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16354.337999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15510.627,
"heapDeltaBytes": -17464144,
"heapUsedBytes": 293841924,
"domNodes": -3344,
"jsHeapTotalBytes": 24629248,
"scriptDurationMs": 206.489,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.68298245614035,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16469.515,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15659.241999999998,
"heapDeltaBytes": -2676424,
"heapUsedBytes": 302260924,
"domNodes": -3344,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 221.68300000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.93866432337434,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 18785.33900000002,
"styleRecalcs": 146,
"styleRecalcDurationMs": 18.74500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18468.904,
"heapDeltaBytes": -1717860,
"heapUsedBytes": 309672056,
"domNodes": -3344,
"jsHeapTotalBytes": 15122432,
"scriptDurationMs": 665.6339999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.91171003717473,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18830.978000000072,
"styleRecalcs": 146,
"styleRecalcDurationMs": 19.12799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18458.887000000002,
"heapDeltaBytes": -29567708,
"heapUsedBytes": 281669292,
"domNodes": -3344,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 650.123,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.07001862197393,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4718.457,
"styleRecalcs": 20,
"styleRecalcDurationMs": 44.151999999999994,
"layouts": 20,
"layoutDurationMs": 22.28200000000001,
"taskDurationMs": 4577.718000000001,
"heapDeltaBytes": -19595208,
"heapUsedBytes": 305271908,
"domNodes": -3344,
"jsHeapTotalBytes": 31444992,
"scriptDurationMs": 76.84,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.59044943820225,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 6011.47299999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.57100000000002,
"layouts": 20,
"layoutDurationMs": 28.812000000000005,
"taskDurationMs": 5874.762000000001,
"heapDeltaBytes": -44238224,
"heapUsedBytes": 281015944,
"domNodes": -3344,
"jsHeapTotalBytes": 20172800,
"scriptDurationMs": 91.85100000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.18362573099416,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8077.319999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7551.113999999999,
"heapDeltaBytes": 10268228,
"heapUsedBytes": 294130520,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.61999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.361403508771925,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8305.090999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7939.211000000002,
"heapDeltaBytes": -9799144,
"heapUsedBytes": 281207828,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.13499999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.32662116040955,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 86.23199999999542,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.481,
"layouts": 6,
"layoutDurationMs": 2.147,
"taskDurationMs": 69.553,
"heapDeltaBytes": -10569180,
"heapUsedBytes": 93263992,
"domNodes": 118,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 6.522,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.680000000000017,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 449.5480000000498,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.866999999999999,
"layouts": 12,
"layoutDurationMs": 3.357,
"taskDurationMs": 101.334,
"heapDeltaBytes": -13145744,
"heapUsedBytes": 88738300,
"domNodes": 95,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.663999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 286.34199999999055,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6589999999999999,
"layouts": 76,
"layoutDurationMs": 14.27,
"taskDurationMs": 236.877,
"heapDeltaBytes": 10251296,
"heapUsedBytes": 97027948,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 105.14899999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294122,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 303.38800000004085,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6809999999999999,
"layouts": 76,
"layoutDurationMs": 15.695,
"taskDurationMs": 258.66700000000003,
"heapDeltaBytes": 10451016,
"heapUsedBytes": 99076748,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 116.798,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 372.1649999999954,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7910000000000001,
"layouts": 76,
"layoutDurationMs": 14.128,
"taskDurationMs": 332.88,
"heapDeltaBytes": -791828,
"heapUsedBytes": 115903920,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 123.446,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 331.957999999986,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.742,
"layouts": 76,
"layoutDurationMs": 13.726,
"taskDurationMs": 293.608,
"heapDeltaBytes": -5908824,
"heapUsedBytes": 109443748,
"domNodes": 4,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 104.511,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 2952 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e7493142ff96e6cfb03c3a0d604df797c9e2d1ee
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (114)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #21523 +/- ##
=============================================
Coverage ? 87.55%
=============================================
Files ? 2704
Lines ? 150335
Branches ? 39209
=============================================
Hits ? 131633
Misses ? 18313
Partials ? 389
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21280 to
cloud/1.58Automatically created by backport workflow.