Repository navigation
[backport cloud/1.57] fix: create restored above-max DynamicGroups on followers - #21521
Conversation
> Stacked on #21264. Keep as draft until that merges; the base will be retargeted to `main` then. ## Summary A DynamicGroup restored from a saved workflow can hold more rows than its `max`. When that node reaches another tab through the shared doc, the follower's create path configures it with only the widgets a fresh node has. The row values are dropped, `validateSavedRowCount` throws, and the follower records an apply failure and ends up with 0 rows. - Fixes #21279 - Part of #21094 (item 1: remote create now goes through the remote row-count path) On create, `createNode` now holds a DynamicGroup row count at its constructed value during `configure`, then applies it with the row values through the existing widget rounds. There the remote row-count guard from #21264 lets a real restored group through, because its limit counts the rows the document carries values for: `max(max, current rows, documented rows)`. A crafted doc with a huge count and no row values is still refused before any row is allocated. **Scope:** the count is only deferred when the document stores it by name on a node **without** a DynamicCombo input. On a DynamicCombo node, positional `_extra_N` aliases can address slots that the rows would shift, so those nodes keep the existing `configure` path exactly as before. That keeps this PR free of the alias edge cases Cursor kept finding. The DynamicCombo-node case is tracked in #21297, and a test asserts today's behavior there (0 rows, one failure). ## Red-Green Verification | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: cover creating a restored above-max DynamicGroup on a follower` (612c215) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39108094938) | Proves the test catches the bug | | `fix: create restored above-max DynamicGroups on followers` (4733ced) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39108847535) | Proves the fix resolves the bug | | `test: create a DynamicGroup whose row count is stored under an overflow alias` (c12b1cd) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39134067553) | Cursor: an alias-stored count was dropped on create | | `test: keep aliased DynamicGroup row values off a trailing widget on create` (04427b5) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39137999361) | Cursor: aliased row values landed on a trailing widget | | `test: cover a named DynamicGroup row count followed by aliased values on create` (4d85d35) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39141788205) | Cursor: a named count followed by aliases had the same shift | | `test: create a restored above-max DynamicGroup next to a stray overflow key` (c5c277b) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39145478948) | Cursor: a stray `_extra_9` brought back #21279 | | `test: cover a fully named catalog order on an overflow DynamicGroup node` (c48b631) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39149443794) | Cursor: a named trailing slot holding a row value | | `fix: defer DynamicGroup row counts only on nodes without overflow aliases` (6e9f43c) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39150420673) | Final behavior: every red case above passes | Each of the Cursor reds above also had its own fix commit in between (94daae4, 7a7f72d, 49aacc3, 9f67924), each with a green run. Those tried to handle aliases on DynamicCombo nodes, and 6e9f43c replaces all of them by keeping those nodes on the `configure` path. The test-only commits 6f438e8 and 7c3007f label the cases and pin today's #21297 behavior. The documented-rows part of the limit later moved into #21264 (bc77798) to fix a rollback regression there, and this branch picked it up through a merge. This PR's own diff is now just the create path. ## Test Plan - [x] CI red on each test-only commit, with only the new case failing - [x] CI green on the final fix commit - A restored 4-row group (`max: 3`) is created on a fresh follower with all 4 rows and no failure, also when a stray `_extra_9` sits in the doc. The stray key is still reported as a missing widget, which is existing behavior. - On a DynamicCombo node, alias-stored counts and row values restore exactly as before this PR, including with a widget after the group and a fully named catalog order. - Guard: a crafted doc with `rows = 1e9` and no row values is still refused on create (0 rows, one failure). - Known gap: a restored above-max group on a DynamicCombo node still ends with 0 rows and one failure (#21297). A test asserts that, so a change on this path shows up. - Reviewed beyond Cursor's 5-round cap with internal bug-hunter, regression-risk, architecture, christian-style and drjkl-style agents. Their actionable points are folded into 6e9f43c, 6f438e8 and 7c3007f; a second pass found no blocking issues.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-21T03:32:14.631Z",
"gitSha": "1f4d0b233d6c77d68e5c0935a10060db2626a719",
"branch": "backport-21280-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.6310000000467,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.124,
"layouts": 9,
"layoutDurationMs": 3.196,
"taskDurationMs": 583.995,
"heapDeltaBytes": -859396,
"heapUsedBytes": 73607356,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 12.786999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2013.2340000000113,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.595999999999999,
"layouts": 8,
"layoutDurationMs": 2.7089999999999996,
"taskDurationMs": 528.397,
"heapDeltaBytes": 22105508,
"heapUsedBytes": 88065896,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.834,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.0290000000055,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.611,
"layouts": 9,
"layoutDurationMs": 3.3569999999999998,
"taskDurationMs": 946.695,
"heapDeltaBytes": -8290144,
"heapUsedBytes": 66674260,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 173.62199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064217,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1787.7200000000357,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.25,
"layouts": 8,
"layoutDurationMs": 2.396,
"taskDurationMs": 885.6469999999999,
"heapDeltaBytes": 15661304,
"heapUsedBytes": 81543188,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 168.01,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.3770000000127,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.443,
"layouts": 10,
"layoutDurationMs": 3.008,
"taskDurationMs": 354.55,
"heapDeltaBytes": 18272168,
"heapUsedBytes": 85110792,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 16.272000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1822.9520000001003,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.433,
"layouts": 11,
"layoutDurationMs": 3.277,
"taskDurationMs": 453.80999999999995,
"heapDeltaBytes": 18335872,
"heapUsedBytes": 84214772,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 14.318000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678894,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 717.5020000000245,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.4669999999999996,
"layouts": 8,
"layoutDurationMs": 2.511,
"taskDurationMs": 507.633,
"heapDeltaBytes": 25686508,
"heapUsedBytes": 91452376,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 169.09799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 741.369000000077,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.166999999999999,
"layouts": 10,
"layoutDurationMs": 3.1470000000000007,
"taskDurationMs": 517.771,
"heapDeltaBytes": 6717084,
"heapUsedBytes": 82064248,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 171.58300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1240.366999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 938.355,
"heapDeltaBytes": -11405908,
"heapUsedBytes": 81181384,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 68.50399999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 540,
"frameDurationMs": 33.33243243243241,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1319.370000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1039.594,
"heapDeltaBytes": -10960256,
"heapUsedBytes": 81649352,
"domNodes": -192,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 81.77999999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 619,
"frameDurationMs": 35.58108108108108,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.2169999999819,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.64200000000017,
"heapDeltaBytes": -4328228,
"heapUsedBytes": 76575228,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 159.32599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25.00294117647057,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.2179999999889,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.0020000000005,
"heapDeltaBytes": -5548036,
"heapUsedBytes": 75148956,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.28300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12161.202000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11221.478,
"heapDeltaBytes": -18604680,
"heapUsedBytes": 75733956,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 9101.291,
"eventListeners": -68,
"totalBlockingTimeMs": 1988,
"frameDurationMs": 33.06032608695652,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11011.553999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10196.756,
"heapDeltaBytes": 1671568,
"heapUsedBytes": 95580148,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 8291.7,
"eventListeners": -68,
"totalBlockingTimeMs": 1183,
"frameDurationMs": 31.975290697674417,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11559.647999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10518.394,
"heapDeltaBytes": -1401468,
"heapUsedBytes": 97942560,
"domNodes": -258,
"jsHeapTotalBytes": 13496320,
"scriptDurationMs": 8975.520999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1983,
"frameDurationMs": 34.3735119047619,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10795.18500000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9984.178,
"heapDeltaBytes": 2063256,
"heapUsedBytes": 97040168,
"domNodes": -278,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 8069.063,
"eventListeners": -68,
"totalBlockingTimeMs": 1190,
"frameDurationMs": 31.34563953488372,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 242.62199999998302,
"styleRecalcs": 23,
"styleRecalcDurationMs": 17.619000000000003,
"layouts": 11,
"layoutDurationMs": 4.045,
"taskDurationMs": 193.56199999999998,
"heapDeltaBytes": -7465268,
"heapUsedBytes": 79609800,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.050999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 6,
"frameDurationMs": 24.989999999999963,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 219.9470000000474,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.04,
"layouts": 10,
"layoutDurationMs": 3.0540000000000003,
"taskDurationMs": 166.79099999999997,
"heapDeltaBytes": -8312024,
"heapUsedBytes": 79206420,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.781000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2057.5299999999856,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.691,
"layouts": 8,
"layoutDurationMs": 2.458,
"taskDurationMs": 748.773,
"heapDeltaBytes": -26719688,
"heapUsedBytes": 71436164,
"domNodes": -258,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 39.99399999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.10299999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.625999999999999,
"layouts": 8,
"layoutDurationMs": 2.4070000000000005,
"taskDurationMs": 710.2420000000001,
"heapDeltaBytes": -1792852,
"heapUsedBytes": 76931948,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 37.31399999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2727.821000000006,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.6240000000000006,
"layouts": 7,
"layoutDurationMs": 1.8079999999999998,
"taskDurationMs": 1825.313,
"heapDeltaBytes": -30850484,
"heapUsedBytes": 68301544,
"domNodes": -258,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 879.4499999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.769135802469137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2495.8420000000388,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.414999999999999,
"layouts": 6,
"layoutDurationMs": 1.7000000000000002,
"taskDurationMs": 1753.5189999999998,
"heapDeltaBytes": 22484688,
"heapUsedBytes": 100021016,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 837.0260000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.778523489932887,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3671.6109999999844,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.9940000000000015,
"layouts": 62,
"layoutDurationMs": 11.113999999999999,
"taskDurationMs": 1745.043,
"heapDeltaBytes": -9341036,
"heapUsedBytes": 72309760,
"domNodes": -234,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 848.1039999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3751.2899999999263,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.008000000000001,
"layouts": 64,
"layoutDurationMs": 11.06,
"taskDurationMs": 1873.4830000000002,
"heapDeltaBytes": -4524352,
"heapUsedBytes": 76921876,
"domNodes": -234,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 806.204,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.740178571428572,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3159.85500000005,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.964000000000001,
"layouts": 4,
"layoutDurationMs": 1.319,
"taskDurationMs": 2058.3549999999996,
"heapDeltaBytes": 15575536,
"heapUsedBytes": 99395960,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 1012.7649999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.022459893048126,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3072.488000000021,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.5409999999999995,
"layouts": 3,
"layoutDurationMs": 0.8959999999999997,
"taskDurationMs": 1967.6689999999999,
"heapDeltaBytes": 4841884,
"heapUsedBytes": 82895540,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 958.416,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84945054945055,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2055.0250000000005,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3300000000000005,
"layouts": 7,
"layoutDurationMs": 2.462,
"taskDurationMs": 726.1550000000001,
"heapDeltaBytes": -2411300,
"heapUsedBytes": 76047260,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 42.943999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.6410000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.468999999999999,
"layouts": 9,
"layoutDurationMs": 2.512,
"taskDurationMs": 666.1599999999999,
"heapDeltaBytes": -19806272,
"heapUsedBytes": 78286040,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 35.361000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 719.8369999999841,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.034,
"layouts": 8,
"layoutDurationMs": 2.3970000000000002,
"taskDurationMs": 510.2150000000001,
"heapDeltaBytes": -1125764,
"heapUsedBytes": 75861140,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 154.444,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.6709999999903,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.841,
"layouts": 8,
"layoutDurationMs": 2.514,
"taskDurationMs": 402.726,
"heapDeltaBytes": 19841072,
"heapUsedBytes": 86796808,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 156.726,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2073.8830000000235,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1319999999999992,
"layouts": 9,
"layoutDurationMs": 2.928,
"taskDurationMs": 627.295,
"heapDeltaBytes": 1034960,
"heapUsedBytes": 68228100,
"domNodes": -180,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.203000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.8779999999915,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3669999999999995,
"layouts": 10,
"layoutDurationMs": 3.5229999999999997,
"taskDurationMs": 574.225,
"heapDeltaBytes": 22071160,
"heapUsedBytes": 88958896,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.693999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.5139999999756,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.617,
"layouts": 10,
"layoutDurationMs": 3.227,
"taskDurationMs": 888.1380000000001,
"heapDeltaBytes": -7417408,
"heapUsedBytes": 68894072,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 119.175,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.4069999999183,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.733999999999998,
"layouts": 9,
"layoutDurationMs": 2.797,
"taskDurationMs": 914.8919999999999,
"heapDeltaBytes": 11553500,
"heapUsedBytes": 78979456,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 117.426,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.4500000000362,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.535999999999998,
"layouts": 5,
"layoutDurationMs": 16.869999999999997,
"taskDurationMs": 1117.2300000000002,
"heapDeltaBytes": 7486200,
"heapUsedBytes": 100031380,
"domNodes": 15953,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 30.48,
"eventListeners": 3244,
"totalBlockingTimeMs": 170,
"frameDurationMs": 19.863013698630137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8406.004000000052,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.288999999999998,
"layouts": 8,
"layoutDurationMs": 2.536,
"taskDurationMs": 5530.496,
"heapDeltaBytes": 8023344,
"heapUsedBytes": 86885216,
"domNodes": -258,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2828.8410000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9261.272999999961,
"styleRecalcs": 247,
"styleRecalcDurationMs": 19.161,
"layouts": 5,
"layoutDurationMs": 2.028,
"taskDurationMs": 6095.006,
"heapDeltaBytes": 12557640,
"heapUsedBytes": 92016120,
"domNodes": -258,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 2735.539,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786775362318842,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23308.997999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22812.829,
"heapDeltaBytes": -10296264,
"heapUsedBytes": 277257876,
"domNodes": -3330,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 337.51300000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.875614035087715,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 23188.147999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22692.965,
"heapDeltaBytes": -4874008,
"heapUsedBytes": 278978280,
"domNodes": -3330,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 321.47400000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.45776614310646,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 28987.73200000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.43499999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28634.421,
"heapDeltaBytes": 3896776,
"heapUsedBytes": 285665452,
"domNodes": -3330,
"jsHeapTotalBytes": 8568832,
"scriptDurationMs": 909.489,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 53.83191094619667,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 19952.124000000025,
"styleRecalcs": 151,
"styleRecalcDurationMs": 13.993000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19559.464000000004,
"heapDeltaBytes": -13942292,
"heapUsedBytes": 281584100,
"domNodes": -3330,
"jsHeapTotalBytes": 12832768,
"scriptDurationMs": 846.2510000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.367577413479054,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8638.899000000038,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.08200000000001,
"layouts": 20,
"layoutDurationMs": 25.103,
"taskDurationMs": 8521.369,
"heapDeltaBytes": -12117340,
"heapUsedBytes": 269486808,
"domNodes": -3330,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 139.62000000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.32234636871509,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8444.994999999948,
"styleRecalcs": 20,
"styleRecalcDurationMs": 94.81200000000001,
"layouts": 20,
"layoutDurationMs": 28.742000000000004,
"taskDurationMs": 8339.527,
"heapDeltaBytes": -29648852,
"heapUsedBytes": 252317140,
"domNodes": -3330,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 133.129,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.11117318435755,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11687.449000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11439.358999999999,
"heapDeltaBytes": -14162168,
"heapUsedBytes": 251622116,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.63799999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.623263888888886,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11673.506999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11424.483000000002,
"heapDeltaBytes": -27498180,
"heapUsedBytes": 247015108,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.709,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.93368421052632,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 481.6280000000006,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.475,
"layouts": 11,
"layoutDurationMs": 4.970000000000001,
"taskDurationMs": 133.32,
"heapDeltaBytes": 6787168,
"heapUsedBytes": 79396304,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.409,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 504.9099999999953,
"styleRecalcs": 21,
"styleRecalcDurationMs": 15.857,
"layouts": 11,
"layoutDurationMs": 4.392,
"taskDurationMs": 146.57500000000002,
"heapDeltaBytes": -13250716,
"heapUsedBytes": 70349616,
"domNodes": 121,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.429,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 396.0580000000391,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0690000000000002,
"layouts": 76,
"layoutDurationMs": 14.61,
"taskDurationMs": 356.004,
"heapDeltaBytes": 10471496,
"heapUsedBytes": 82868908,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 167.11100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 469.4240000000036,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.416,
"layouts": 76,
"layoutDurationMs": 15.772000000000002,
"taskDurationMs": 414.312,
"heapDeltaBytes": 11458904,
"heapUsedBytes": 82807936,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 198.657,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 564.2219999999725,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.276,
"layouts": 76,
"layoutDurationMs": 13.766,
"taskDurationMs": 514.747,
"heapDeltaBytes": 684144,
"heapUsedBytes": 119135644,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 213.381,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 579.855000000066,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.16,
"layouts": 76,
"layoutDurationMs": 16.209999999999997,
"taskDurationMs": 541.197,
"heapDeltaBytes": 509664,
"heapUsedBytes": 119349508,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 227.15600000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 2285 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fb5e1f3dddce86bf6f3092f19bf60c1787eb4589
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21521 +/- ##
=============================================
Coverage ? 85.15%
=============================================
Files ? 2518
Lines ? 132485
Branches ? 40554
=============================================
Hits ? 112812
Misses ? 19255
Partials ? 418
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21280 to
cloud/1.57Automatically created by backport workflow.