Repository navigation
[backport core/1.58] fix: create restored above-max DynamicGroups on followers - #21522
Conversation
> Stacked on #21264. Keep as draft until that merges; the base will be retargeted to `main` then. ## Summary A DynamicGroup restored from a saved workflow can hold more rows than its `max`. When that node reaches another tab through the shared doc, the follower's create path configures it with only the widgets a fresh node has. The row values are dropped, `validateSavedRowCount` throws, and the follower records an apply failure and ends up with 0 rows. - Fixes #21279 - Part of #21094 (item 1: remote create now goes through the remote row-count path) On create, `createNode` now holds a DynamicGroup row count at its constructed value during `configure`, then applies it with the row values through the existing widget rounds. There the remote row-count guard from #21264 lets a real restored group through, because its limit counts the rows the document carries values for: `max(max, current rows, documented rows)`. A crafted doc with a huge count and no row values is still refused before any row is allocated. **Scope:** the count is only deferred when the document stores it by name on a node **without** a DynamicCombo input. On a DynamicCombo node, positional `_extra_N` aliases can address slots that the rows would shift, so those nodes keep the existing `configure` path exactly as before. That keeps this PR free of the alias edge cases Cursor kept finding. The DynamicCombo-node case is tracked in #21297, and a test asserts today's behavior there (0 rows, one failure). ## Red-Green Verification | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: cover creating a restored above-max DynamicGroup on a follower` (612c215) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39108094938) | Proves the test catches the bug | | `fix: create restored above-max DynamicGroups on followers` (4733ced) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39108847535) | Proves the fix resolves the bug | | `test: create a DynamicGroup whose row count is stored under an overflow alias` (c12b1cd) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39134067553) | Cursor: an alias-stored count was dropped on create | | `test: keep aliased DynamicGroup row values off a trailing widget on create` (04427b5) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39137999361) | Cursor: aliased row values landed on a trailing widget | | `test: cover a named DynamicGroup row count followed by aliased values on create` (4d85d35) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39141788205) | Cursor: a named count followed by aliases had the same shift | | `test: create a restored above-max DynamicGroup next to a stray overflow key` (c5c277b) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39145478948) | Cursor: a stray `_extra_9` brought back #21279 | | `test: cover a fully named catalog order on an overflow DynamicGroup node` (c48b631) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39149443794) | Cursor: a named trailing slot holding a row value | | `fix: defer DynamicGroup row counts only on nodes without overflow aliases` (6e9f43c) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39150420673) | Final behavior: every red case above passes | Each of the Cursor reds above also had its own fix commit in between (94daae4, 7a7f72d, 49aacc3, 9f67924), each with a green run. Those tried to handle aliases on DynamicCombo nodes, and 6e9f43c replaces all of them by keeping those nodes on the `configure` path. The test-only commits 6f438e8 and 7c3007f label the cases and pin today's #21297 behavior. The documented-rows part of the limit later moved into #21264 (bc77798) to fix a rollback regression there, and this branch picked it up through a merge. This PR's own diff is now just the create path. ## Test Plan - [x] CI red on each test-only commit, with only the new case failing - [x] CI green on the final fix commit - A restored 4-row group (`max: 3`) is created on a fresh follower with all 4 rows and no failure, also when a stray `_extra_9` sits in the doc. The stray key is still reported as a missing widget, which is existing behavior. - On a DynamicCombo node, alias-stored counts and row values restore exactly as before this PR, including with a widget after the group and a fully named catalog order. - Guard: a crafted doc with `rows = 1e9` and no row values is still refused on create (0 rows, one failure). - Known gap: a restored above-max group on a DynamicCombo node still ends with 0 rows and one failure (#21297). A test asserts that, so a change on this path shows up. - Reviewed beyond Cursor's 5-round cap with internal bug-hunter, regression-risk, architecture, christian-style and drjkl-style agents. Their actionable points are folded into 6e9f43c, 6f438e8 and 7c3007f; a second pass found no blocking issues.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-21T03:53:39.556Z",
"gitSha": "d281b29fd63d67a1a6e79bd500fae5a260d26f30",
"branch": "backport-21280-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.8049999999953,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7250000000000005,
"layouts": 11,
"layoutDurationMs": 2.988,
"taskDurationMs": 447.35499999999996,
"heapDeltaBytes": -6964516,
"heapUsedBytes": 96770080,
"domNodes": -180,
"jsHeapTotalBytes": 1740800,
"scriptDurationMs": 10.334,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2041.8650000000298,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.5269999999999997,
"layouts": 10,
"layoutDurationMs": 2.3679999999999994,
"taskDurationMs": 598.4000000000001,
"heapDeltaBytes": -9027408,
"heapUsedBytes": 94766496,
"domNodes": -180,
"jsHeapTotalBytes": 2527232,
"scriptDurationMs": 12.344,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.9630000000257,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.361999999999998,
"layouts": 10,
"layoutDurationMs": 2.477,
"taskDurationMs": 782.685,
"heapDeltaBytes": 19108056,
"heapUsedBytes": 109617488,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 132.408,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1778.9680000000772,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.680000000000001,
"layouts": 9,
"layoutDurationMs": 2.385,
"taskDurationMs": 835.9029999999999,
"heapDeltaBytes": 23214380,
"heapUsedBytes": 114638264,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 137.57,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2560000000117,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.185,
"layouts": 12,
"layoutDurationMs": 3.1540000000000004,
"taskDurationMs": 311.961,
"heapDeltaBytes": 4821344,
"heapUsedBytes": 103813420,
"domNodes": 47,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 13.062999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1838.7069999999994,
"styleRecalcs": 19,
"styleRecalcDurationMs": 8.579,
"layouts": 11,
"layoutDurationMs": 3.994999999999999,
"taskDurationMs": 509.39599999999996,
"heapDeltaBytes": 1746212,
"heapUsedBytes": 105997152,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 17.116,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.818348623853208,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 595.7230000000209,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7269999999999994,
"layouts": 9,
"layoutDurationMs": 2.4149999999999996,
"taskDurationMs": 425.77700000000004,
"heapDeltaBytes": 4026708,
"heapUsedBytes": 102429100,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 159.303,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66944444444443,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 618.4950000000526,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.089,
"layouts": 10,
"layoutDurationMs": 2.457,
"taskDurationMs": 431.03099999999995,
"heapDeltaBytes": 6441712,
"heapUsedBytes": 110318824,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 155.57600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1127.0609999999692,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 830.339,
"heapDeltaBytes": -16932764,
"heapUsedBytes": 101679284,
"domNodes": -210,
"jsHeapTotalBytes": 15970304,
"scriptDurationMs": 53.90200000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 457,
"frameDurationMs": 30.629729729729736,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1181.0070000000223,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 854.8719999999998,
"heapDeltaBytes": -7459416,
"heapUsedBytes": 103216940,
"domNodes": -230,
"jsHeapTotalBytes": 9351168,
"scriptDurationMs": 53.20899999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 463,
"frameDurationMs": 30.341025641025645,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 776.7769999999814,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.43799999999965,
"heapDeltaBytes": -3737584,
"heapUsedBytes": 97454232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.49600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 143,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 761.4690000000337,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.75199999999995,
"heapDeltaBytes": -4266296,
"heapUsedBytes": 97605264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.033,
"eventListeners": 0,
"totalBlockingTimeMs": 143,
"frameDurationMs": 22.547058823529422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9805.599999999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.050000000000000565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8908.071,
"heapDeltaBytes": 6734788,
"heapUsedBytes": 128707088,
"domNodes": -276,
"jsHeapTotalBytes": 15896576,
"scriptDurationMs": 6994.419000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 256,
"frameDurationMs": 29.21488095238095,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7957.868000000019,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.28399999999999953,
"layouts": 2,
"layoutDurationMs": 0.6450000000000001,
"taskDurationMs": 7134.525,
"heapDeltaBytes": 14410860,
"heapUsedBytes": 136504652,
"domNodes": -276,
"jsHeapTotalBytes": 28479488,
"scriptDurationMs": 5418.307000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 104,
"frameDurationMs": 24.311009174311923,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8786.113000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7843.19,
"heapDeltaBytes": 27680076,
"heapUsedBytes": 133057500,
"domNodes": -296,
"jsHeapTotalBytes": 33525760,
"scriptDurationMs": 5963.756,
"eventListeners": -130,
"totalBlockingTimeMs": 112,
"frameDurationMs": 25.655102040816324,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7961.758999999973,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3309999999999997,
"layouts": 1,
"layoutDurationMs": 0.3249999999999998,
"taskDurationMs": 7151.2080000000005,
"heapDeltaBytes": 19020360,
"heapUsedBytes": 132918860,
"domNodes": -276,
"jsHeapTotalBytes": 20942848,
"scriptDurationMs": 5408.285,
"eventListeners": -130,
"totalBlockingTimeMs": 101,
"frameDurationMs": 24.587654320987653,
"p95FrameDurationMs": 33.5
},
{
"name": "large-combo-open",
"durationMs": 215.64499999999498,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.828999999999999,
"layouts": 12,
"layoutDurationMs": 3.43,
"taskDurationMs": 161.73299999999998,
"heapDeltaBytes": 13201172,
"heapUsedBytes": 118190588,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.606000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 204.99399999999923,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.315,
"layouts": 11,
"layoutDurationMs": 3.068,
"taskDurationMs": 153.10800000000003,
"heapDeltaBytes": 13229476,
"heapUsedBytes": 119869000,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.411000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2055.251999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7799999999999994,
"layouts": 9,
"layoutDurationMs": 2.738,
"taskDurationMs": 669.8129999999999,
"heapDeltaBytes": -555636,
"heapUsedBytes": 102661456,
"domNodes": -306,
"jsHeapTotalBytes": -1404928,
"scriptDurationMs": 36.596000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.649999999948,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4949999999999997,
"layouts": 8,
"layoutDurationMs": 2.3759999999999994,
"taskDurationMs": 638.34,
"heapDeltaBytes": -24520512,
"heapUsedBytes": 96686492,
"domNodes": -276,
"jsHeapTotalBytes": -1302528,
"scriptDurationMs": 34.400999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2170.455000000004,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.204,
"layouts": 7,
"layoutDurationMs": 1.932,
"taskDurationMs": 1438.9050000000002,
"heapDeltaBytes": 2494872,
"heapUsedBytes": 104004260,
"domNodes": -277,
"jsHeapTotalBytes": -4063232,
"scriptDurationMs": 727.622,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2284.546999999975,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.318000000000001,
"layouts": 5,
"layoutDurationMs": 1.6589999999999998,
"taskDurationMs": 1595.9979999999998,
"heapDeltaBytes": 2096760,
"heapUsedBytes": 106652740,
"domNodes": -296,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 827.723,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.038805970149255,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3508.8199999999574,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.790999999999999,
"layouts": 66,
"layoutDurationMs": 12.526,
"taskDurationMs": 1548.2939999999999,
"heapDeltaBytes": -18596628,
"heapUsedBytes": 86578736,
"domNodes": -272,
"jsHeapTotalBytes": -1011712,
"scriptDurationMs": 700.9459999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.745454545454546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3673.7299999999777,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.060999999999998,
"layouts": 65,
"layoutDurationMs": 12.738999999999999,
"taskDurationMs": 1789.8529999999998,
"heapDeltaBytes": -28328168,
"heapUsedBytes": 95419804,
"domNodes": -272,
"jsHeapTotalBytes": -385024,
"scriptDurationMs": 739.917,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74246575342466,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2775.314000000037,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.142,
"layouts": 5,
"layoutDurationMs": 1.3160000000000003,
"taskDurationMs": 1708.7220000000002,
"heapDeltaBytes": 22050364,
"heapUsedBytes": 128700624,
"domNodes": 0,
"jsHeapTotalBytes": 6713344,
"scriptDurationMs": 876.882,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.767272727272722,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3023.779999999988,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.388999999999999,
"layouts": 6,
"layoutDurationMs": 1.6940000000000002,
"taskDurationMs": 1919.0100000000002,
"heapDeltaBytes": 14973996,
"heapUsedBytes": 120121048,
"domNodes": 0,
"jsHeapTotalBytes": 7761920,
"scriptDurationMs": 912.2280000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.758659217877096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.6190000000115,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.28,
"layouts": 8,
"layoutDurationMs": 1.9030000000000002,
"taskDurationMs": 599.0360000000001,
"heapDeltaBytes": 1453824,
"heapUsedBytes": 105097112,
"domNodes": -296,
"jsHeapTotalBytes": -5074944,
"scriptDurationMs": 34.178,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.5490000000273,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5199999999999996,
"layouts": 7,
"layoutDurationMs": 2.426,
"taskDurationMs": 669.4490000000001,
"heapDeltaBytes": -202316,
"heapUsedBytes": 103145296,
"domNodes": -296,
"jsHeapTotalBytes": -2191360,
"scriptDurationMs": 37.888,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.7669999999875,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.760000000000002,
"layouts": 9,
"layoutDurationMs": 2.02,
"taskDurationMs": 440.428,
"heapDeltaBytes": 885496,
"heapUsedBytes": 102108780,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 128.316,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.0350000000335,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.047999999999999,
"layouts": 9,
"layoutDurationMs": 2.6530000000000005,
"taskDurationMs": 389.623,
"heapDeltaBytes": 22533400,
"heapUsedBytes": 112970364,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 138.609,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.5010000000143,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.9770000000000003,
"layouts": 11,
"layoutDurationMs": 2.9059999999999997,
"taskDurationMs": 448.84600000000006,
"heapDeltaBytes": -20552576,
"heapUsedBytes": 80320120,
"domNodes": -198,
"jsHeapTotalBytes": 1019904,
"scriptDurationMs": 9.268,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.914000000067,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0340000000000003,
"layouts": 9,
"layoutDurationMs": 3.0849999999999995,
"taskDurationMs": 577.175,
"heapDeltaBytes": 5116832,
"heapUsedBytes": 97554400,
"domNodes": -199,
"jsHeapTotalBytes": 1282048,
"scriptDurationMs": 11.334000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.5350000000176,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.705,
"layouts": 9,
"layoutDurationMs": 2.5070000000000006,
"taskDurationMs": 759.4000000000001,
"heapDeltaBytes": -15701348,
"heapUsedBytes": 89964448,
"domNodes": -210,
"jsHeapTotalBytes": 3837952,
"scriptDurationMs": 104.712,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.2659999998978,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.115,
"layouts": 9,
"layoutDurationMs": 2.5250000000000004,
"taskDurationMs": 887.6099999999999,
"heapDeltaBytes": -25839772,
"heapUsedBytes": 80333904,
"domNodes": -210,
"jsHeapTotalBytes": 2801664,
"scriptDurationMs": 104.457,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.3630000000467,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.023,
"layouts": 5,
"layoutDurationMs": 12.154,
"taskDurationMs": 697.346,
"heapDeltaBytes": 7114152,
"heapUsedBytes": 126183816,
"domNodes": 16030,
"jsHeapTotalBytes": 20586496,
"scriptDurationMs": 22.161,
"eventListeners": 3244,
"totalBlockingTimeMs": 141,
"frameDurationMs": 20.834090909090925,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8290.142000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.781,
"layouts": 9,
"layoutDurationMs": 2.5780000000000003,
"taskDurationMs": 5587.9039999999995,
"heapDeltaBytes": 2805964,
"heapUsedBytes": 114488280,
"domNodes": -277,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 2429.523,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699798387096774,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8512.63300000005,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.005,
"layouts": 6,
"layoutDurationMs": 2.006,
"taskDurationMs": 6071.508000000001,
"heapDeltaBytes": 2231592,
"heapUsedBytes": 105079928,
"domNodes": -276,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 2686.467,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698624754420432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12680.08199999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12187.244,
"heapDeltaBytes": -2654952,
"heapUsedBytes": 301813832,
"domNodes": -3344,
"jsHeapTotalBytes": 23056384,
"scriptDurationMs": 223.457,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.138,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 19185.15100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18689.183999999997,
"heapDeltaBytes": -14806024,
"heapUsedBytes": 290352820,
"domNodes": -3344,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 287.059,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.15882352941176,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 22805.498999999996,
"styleRecalcs": 169,
"styleRecalcDurationMs": 22.817000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22405.3,
"heapDeltaBytes": -33218820,
"heapUsedBytes": 286421092,
"domNodes": -3344,
"jsHeapTotalBytes": 8638464,
"scriptDurationMs": 862.6659999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 23,
"frameDurationMs": 42.06476014760148,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 24170.674000000075,
"styleRecalcs": 180,
"styleRecalcDurationMs": 28.378999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23850.304,
"heapDeltaBytes": -30031676,
"heapUsedBytes": 281440372,
"domNodes": -3344,
"jsHeapTotalBytes": 6541312,
"scriptDurationMs": 913.881,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 45.1385046728972,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6779.016000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.93399999999998,
"layouts": 20,
"layoutDurationMs": 22.049,
"taskDurationMs": 6642.824999999999,
"heapDeltaBytes": -16215532,
"heapUsedBytes": 288855200,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 128.59500000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.3225988700565,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5267.097000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.68700000000001,
"layouts": 20,
"layoutDurationMs": 23.335999999999995,
"taskDurationMs": 5115.691999999999,
"heapDeltaBytes": -11268488,
"heapUsedBytes": 293669736,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 92.422,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.094285714285714,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6223.867999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5900.296999999999,
"heapDeltaBytes": -23114184,
"heapUsedBytes": 283950088,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 91.00600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.721333333333337,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9488.875000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9291.433,
"heapDeltaBytes": 23431236,
"heapUsedBytes": 289308612,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.66999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.09358108108108,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 438.41199999997116,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.402999999999999,
"layouts": 12,
"layoutDurationMs": 3.7549999999999994,
"taskDurationMs": 125.13199999999999,
"heapDeltaBytes": -12565416,
"heapUsedBytes": 88820944,
"domNodes": 98,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.177000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 142.35999999993965,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.116,
"layouts": 10,
"layoutDurationMs": 3.858,
"taskDurationMs": 92.027,
"heapDeltaBytes": 4686492,
"heapUsedBytes": 105812452,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.660999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 442.4340000000484,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.857,
"layouts": 76,
"layoutDurationMs": 15.356,
"taskDurationMs": 395.65999999999997,
"heapDeltaBytes": -14953816,
"heapUsedBytes": 78228728,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 178.77700000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 416.97499999997945,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.707,
"layouts": 76,
"layoutDurationMs": 15.845999999999998,
"taskDurationMs": 363.82,
"heapDeltaBytes": -14834436,
"heapUsedBytes": 78102108,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 163.31400000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 571.1989999999787,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.851,
"layouts": 76,
"layoutDurationMs": 17.382,
"taskDurationMs": 537.556,
"heapDeltaBytes": -3597368,
"heapUsedBytes": 103449884,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 210.794,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 515.0380000000041,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8550000000000002,
"layouts": 76,
"layoutDurationMs": 15.462,
"taskDurationMs": 470.57000000000005,
"heapDeltaBytes": 407300,
"heapUsedBytes": 117534952,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 181.46499999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 2952 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ee0189906648854f8f08143bc0944104b62293ef
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (114)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21522 +/- ##
============================================
Coverage 86.16% 86.16%
============================================
Files 2786 2786
Lines 154586 154598 +12
Branches 41312 39185 -2127
============================================
+ Hits 133195 133206 +11
- Misses 21001 21002 +1
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #21280 to
core/1.58Automatically created by backport workflow.