Repository navigation
[backport cloud/1.56] FE-3355 test(workspace): orthogonality tests for members-panel server-fact gates - #20699
Conversation
…-fact gates (#20694) ## Why BE-19903 and BE-19904 shipped because members-panel gates recombined a server capability with plan state, seats and role. #19455 hid the derivation behind a helper and an `if`/`return`, so the lint rules (#20679) can't see it. The existing tests also didn't catch it: they mocked the capability at the composable, and one asserted the derivation as expected behaviour. ## Root cause No test asserted the property that matters: **a gate's output depends only on its server fact.** Each test pinned one combination of inputs, so a gate that also read `isPlanEnded` passed every test that didn't happen to flip it. ## How - **`describeServerFactGate`** (`src/utils/__tests__/serverFactGate.ts`, about 50 lines). Given a fact setter, a list of non-fact perturbations, `mount` and `read`, it generates `it.for` cases over both fact values and every perturbation: - Each perturbation must leave `read()` unchanged. - Flipping only the fact must change it. - The fact is set after the perturbation, so a perturbation can't override it. - **Applied to the Cloud members-panel gates** in `useMembersPanel.test.ts`: | Gate | Fact | Reads | |---|---|---| | Invite | `can_invite_members` | `showInviteButton`, `isInviteDisabled`, `permissions.canInviteMembers` | | Member management | `can_manage_members` | `canManageMembers`, `canViewPendingInvites`, `uiConfig.showPendingTab`, member menu non-empty | | Roster visibility | members response (`membersLoaded`) | `canViewOtherMembers`, `showMembersList` | Shared perturbations: - plan ended, Enterprise, ended Enterprise with `maxSeats` 1, `maxSeats` 1 - personal plan, cancel scheduled - not a billing manager, member role - `can_change_seats` flipped Each gate also flips the capabilities it must not depend on. Invite flips `can_manage_members`, management flips `can_invite_members`, and roster flips both, so one capability can't stand in for another. - **`CODEOWNERS`**: `/src/platform/workspace/` gets the billing owners. The incident lived there, and it was the only billing-adjacent path without owners. ## AS IS / TO BE There is no UI change. These are test outcomes on the two historical defects, each reintroduced by hand and not committed: | Mutation | AS IS (tests before this PR) | TO BE | |---|---|---| | #18662 disjunct back on Cloud `showInviteButton` (`canInviteMembers \|\| (isPlanEnded && canManageSubscription)`) | Existing suite still asserted it pre-#20674 | 4 failures, including "ignores an ended plan when the fact is false" and "ignores an ended Enterprise plan with one seat when the fact is false" | | #15675 substitution (`canManageMembers` ← `canChangeSeats`) | Not caught by an orthogonality case | 27 failures, including "ignores a flipped can_change_seats" (fact true and false) and "changes when the fact flips" | | After revert | — | 158 passed | ## Verification - `vitest run src/platform/workspace/composables/useMembersPanel.test.ts`: 158 passed. - oxlint `--type-aware` and oxfmt `--check` pass on touched files. The pre-commit hook ran `typecheck:app`. - No existing Cloud test still asserts a derivation (#20674 already flipped them), so none were rewritten. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3349. | Item | Ticket | PR | Status | |---|---|---|---| | S1 ADR + S2 lint gate + S3/S4 hooks (folded) | FE-3350..FE-3353 | #20679 | In review | | S5 `pendingServerFact` + expiry CI | FE-3354 | #20680 | Merged (backports #20692, #20693) | | **S6 orthogonality tests + CODEOWNERS** | **FE-3355** | **this PR** | **In review** | | S7 cloud agent instructions | FE-3356 | cloud#12741 | Merged | ```mermaid graph LR S1["S1-S4 ADR, lint gate, hooks (PR 20679)"] S5["S5 pendingServerFact (PR 20680, merged)"] -. "exempted by" .-> S1 P20674["PR 20674 member capabilities (merged)"] --> S6["S6 orthogonality tests (this PR)"]:::current S6 -. "covers what lint cannot" .-> S1 S7["S7 cloud AGENTS.md (merged)"] classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-10T23:31:45.223Z",
"gitSha": "93e868af4ed84381f46662ac7ee143f3cc8f14e4",
"branch": "backport-20694-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.6449999999732,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.409000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.49600000000004,
"heapDeltaBytes": 925532,
"heapUsedBytes": 68678408,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.106999999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.3299999998972,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.286999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.78400000000005,
"heapDeltaBytes": 508156,
"heapUsedBytes": 68400872,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.767,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1765.732000000014,
"styleRecalcs": 74,
"styleRecalcDurationMs": 19.073,
"layouts": 12,
"layoutDurationMs": 4.207,
"taskDurationMs": 779.0980000000001,
"heapDeltaBytes": -2102488,
"heapUsedBytes": 65443296,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 145.37800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.7180000000126,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.471,
"layouts": 12,
"layoutDurationMs": 4.7749999999999995,
"taskDurationMs": 771.1589999999999,
"heapDeltaBytes": -2088040,
"heapUsedBytes": 65719476,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 145.145,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.4750000000172,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.915,
"layouts": 6,
"layoutDurationMs": 1.514,
"taskDurationMs": 345.473,
"heapDeltaBytes": 4027576,
"heapUsedBytes": 72620536,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.459999999999992,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.3410000000422,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.283000000000001,
"layouts": 6,
"layoutDurationMs": 1.491,
"taskDurationMs": 379.608,
"heapDeltaBytes": 3797272,
"heapUsedBytes": 71359452,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.623999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 730.2700000000186,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.132000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.83400000000006,
"heapDeltaBytes": -7118304,
"heapUsedBytes": 60748356,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 157.879,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 713.3680000000595,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.8670000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.533,
"heapDeltaBytes": 14628664,
"heapUsedBytes": 76387308,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 157.04700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1082.5630000000501,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 719.139,
"heapDeltaBytes": 38525832,
"heapUsedBytes": 109319136,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 55.65200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 475,
"frameDurationMs": 32.82424242424242,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1075.9689999999864,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 747.24,
"heapDeltaBytes": 15478736,
"heapUsedBytes": 84708988,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 50.667,
"eventListeners": 0,
"totalBlockingTimeMs": 469,
"frameDurationMs": 32.827272727272735,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 793.2610000000295,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.91600000000005,
"heapDeltaBytes": 17666040,
"heapUsedBytes": 105436908,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 138.536,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 22.857142857142883,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 796.4759999999842,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.12100000000004,
"heapDeltaBytes": 17398656,
"heapUsedBytes": 104704280,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 127.93600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 147,
"frameDurationMs": 22.857142857142858,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8620.666000000028,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8800000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7680.198,
"heapDeltaBytes": -16591072,
"heapUsedBytes": 68254024,
"domNodes": -142,
"jsHeapTotalBytes": -10096640,
"scriptDurationMs": 6020.5199999999995,
"eventListeners": -74,
"totalBlockingTimeMs": 152,
"frameDurationMs": 30.387632508833917,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8131.547000000069,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6809999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7403.290999999999,
"heapDeltaBytes": 9962380,
"heapUsedBytes": 89270336,
"domNodes": -171,
"jsHeapTotalBytes": -3018752,
"scriptDurationMs": 5831.843,
"eventListeners": -78,
"totalBlockingTimeMs": 102,
"frameDurationMs": 30.172118959107806,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8172.2550000000065,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9650000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7526.563999999999,
"heapDeltaBytes": 4037116,
"heapUsedBytes": 89712064,
"domNodes": -142,
"jsHeapTotalBytes": -2494464,
"scriptDurationMs": 5891.582,
"eventListeners": -78,
"totalBlockingTimeMs": 151,
"frameDurationMs": 30.933333333333334,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7539.7930000000315,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.893999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6933.11,
"heapDeltaBytes": 8463544,
"heapUsedBytes": 93487500,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 5394.517,
"eventListeners": -74,
"totalBlockingTimeMs": 62,
"frameDurationMs": 29.085328185328187,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2007.4410000000285,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7760000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.20399999999995,
"heapDeltaBytes": -7556212,
"heapUsedBytes": 78330952,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.379999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.3619999999537,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.019000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.8400000000001,
"heapDeltaBytes": -9781368,
"heapUsedBytes": 78719912,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 36.047999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2446.534999999983,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.825999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1525.9300000000003,
"heapDeltaBytes": -19034884,
"heapUsedBytes": 70408560,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 780.979,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780689655172413,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3019.9199999999564,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.532999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1640.453,
"heapDeltaBytes": -18684296,
"heapUsedBytes": 70938280,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 831.164,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353592,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3757.111000000009,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.997000000000002,
"layouts": 60,
"layoutDurationMs": 16.173999999999996,
"taskDurationMs": 1632.9850000000001,
"heapDeltaBytes": 878992,
"heapUsedBytes": 69092284,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 735.783,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353983,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3872.863000000052,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.804,
"layouts": 60,
"layoutDurationMs": 16.788999999999998,
"taskDurationMs": 1683.5650000000003,
"heapDeltaBytes": 1678900,
"heapUsedBytes": 69583552,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 761.2529999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66609442060086,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3149.4430000000193,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1822.953,
"heapDeltaBytes": -14610492,
"heapUsedBytes": 69351168,
"domNodes": 0,
"jsHeapTotalBytes": 1609728,
"scriptDurationMs": 920.1320000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754545454545458,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3147.8499999999485,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.388999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1910.151,
"heapDeltaBytes": 17471788,
"heapUsedBytes": 85856100,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 948.4910000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903746,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.3779999999933,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.214999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.03200000000004,
"heapDeltaBytes": 14131752,
"heapUsedBytes": 82041348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 40.975,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2011.4129999999477,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7560000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.391,
"heapDeltaBytes": -8475860,
"heapUsedBytes": 81520364,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 38.498000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.9640000000181,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.139000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.46999999999997,
"heapDeltaBytes": -11677232,
"heapUsedBytes": 58131312,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 135.424,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 692.8009999999176,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.300000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.49899999999997,
"heapDeltaBytes": -11982932,
"heapUsedBytes": 57615620,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 141.614,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.3869999999806,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.012999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.668,
"heapDeltaBytes": -2698532,
"heapUsedBytes": 60882364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.543999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.4530000000314,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.708999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.7490000000001,
"heapDeltaBytes": 994152,
"heapUsedBytes": 71184304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.740999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.4209999999907,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.423,
"layouts": 16,
"layoutDurationMs": 6.308999999999999,
"taskDurationMs": 649.5869999999999,
"heapDeltaBytes": -6232012,
"heapUsedBytes": 63263632,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.89699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.8700000000572,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.640000000000004,
"layouts": 16,
"layoutDurationMs": 5.8180000000000005,
"taskDurationMs": 753.676,
"heapDeltaBytes": -5995192,
"heapUsedBytes": 63571220,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 106.92599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.0589999999556,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.165,
"layouts": 5,
"layoutDurationMs": 11.413,
"taskDurationMs": 878.238,
"heapDeltaBytes": 1289020,
"heapUsedBytes": 94050008,
"domNodes": 14227,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 31.673999999999992,
"eventListeners": 2463,
"totalBlockingTimeMs": 127,
"frameDurationMs": 19.444444444444457,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8746.929000000022,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.413999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5500.452,
"heapDeltaBytes": -18121064,
"heapUsedBytes": 70758324,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2627.487,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697709923664124,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9806.634000000031,
"styleRecalcs": 250,
"styleRecalcDurationMs": 44.105000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5751.641,
"heapDeltaBytes": -15191968,
"heapUsedBytes": 70068424,
"domNodes": 0,
"jsHeapTotalBytes": 1609728,
"scriptDurationMs": 2708.977,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598639455782,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15277.134999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14554.136,
"heapDeltaBytes": -42753432,
"heapUsedBytes": 178984240,
"domNodes": -3045,
"jsHeapTotalBytes": 892928,
"scriptDurationMs": 246.97800000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.00681431005111,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14549.343000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13946.491000000002,
"heapDeltaBytes": -36695524,
"heapUsedBytes": 180706612,
"domNodes": -3074,
"jsHeapTotalBytes": 5382144,
"scriptDurationMs": 258.339,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.585915492957746,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17945.420999999955,
"styleRecalcs": 151,
"styleRecalcDurationMs": 21.946999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17584.818,
"heapDeltaBytes": -23163048,
"heapUsedBytes": 192217804,
"domNodes": -3045,
"jsHeapTotalBytes": 4554752,
"scriptDurationMs": 905.462,
"eventListeners": -14915,
"totalBlockingTimeMs": 28,
"frameDurationMs": 32.63509090909091,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 14957.387000000039,
"styleRecalcs": 72,
"styleRecalcDurationMs": 16.397999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14352.520000000002,
"heapDeltaBytes": -26736364,
"heapUsedBytes": 187835392,
"domNodes": -3045,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 885.2260000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 99,
"frameDurationMs": 26.193706293706292,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 5538.138000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.59900000000002,
"layouts": 20,
"layoutDurationMs": 26.36300000000001,
"taskDurationMs": 5461.705999999999,
"heapDeltaBytes": 744828,
"heapUsedBytes": 223387120,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 98.80600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.63515151515152,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5949.192000000039,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.24999999999997,
"layouts": 20,
"layoutDurationMs": 26.727,
"taskDurationMs": 5539.128999999999,
"heapDeltaBytes": 3176056,
"heapUsedBytes": 225452328,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 108.88700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.817112299465247,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7642.997000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7365.682000000002,
"heapDeltaBytes": -26464060,
"heapUsedBytes": 179026584,
"domNodes": -3045,
"jsHeapTotalBytes": 4333568,
"scriptDurationMs": 167.96299999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.78716216216216,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7499.8749999999745,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7241.7339999999995,
"heapDeltaBytes": -34253344,
"heapUsedBytes": 179848476,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 130.01900000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.407746478873236,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 490.93299999992723,
"styleRecalcs": 20,
"styleRecalcDurationMs": 17.362,
"layouts": 5,
"layoutDurationMs": 2.286,
"taskDurationMs": 136.08499999999998,
"heapDeltaBytes": 6173732,
"heapUsedBytes": 71716236,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.708,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.260714285714293,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 494.9709999999641,
"styleRecalcs": 20,
"styleRecalcDurationMs": 17.846,
"layouts": 3,
"layoutDurationMs": 1.6949999999999998,
"taskDurationMs": 139.754,
"heapDeltaBytes": 5781876,
"heapUsedBytes": 71710380,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.438000000000004,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1178.4579999999778,
"styleRecalcs": 78,
"styleRecalcDurationMs": 123.74499999999999,
"layouts": 76,
"layoutDurationMs": 37.998999999999995,
"taskDurationMs": 1159.703,
"heapDeltaBytes": 20919728,
"heapUsedBytes": 88716764,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 476.51,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664788732394364,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1024.1610000000492,
"styleRecalcs": 78,
"styleRecalcDurationMs": 116.055,
"layouts": 76,
"layoutDurationMs": 32.30800000000001,
"taskDurationMs": 999.0459999999999,
"heapDeltaBytes": 19190628,
"heapUsedBytes": 84569952,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 393.171,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1478.7729999999328,
"styleRecalcs": 78,
"styleRecalcDurationMs": 282.125,
"layouts": 76,
"layoutDurationMs": 33.039,
"taskDurationMs": 1458.3,
"heapDeltaBytes": 8662484,
"heapUsedBytes": 115264020,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 451.807,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.541250000000012,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1504.4920000000275,
"styleRecalcs": 78,
"styleRecalcDurationMs": 289.744,
"layouts": 76,
"layoutDurationMs": 34.079,
"taskDurationMs": 1480.1339999999998,
"heapDeltaBytes": -19712504,
"heapUsedBytes": 114112144,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 456.312,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.92839506172838,
"p95FrameDurationMs": 33.30000000000109
}
]
}🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 12d979940fe2162612a54f88c604e11365ffa1ef
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff is identical to #20694.
|
Blocked on #20716, not on anything in this diff. All nine red checks here are the same Measured locally, both directions:
So this is an ordering inversion — the test carrier was opened ahead of its product dependency — rather than a defect to repair here. Worth flagging: adapting the test file to the current branch state would be counterproductive. #20716 rewrites that same test file and the same composable, so an adapted version would conflict with it, and it would pin the behaviour #20674 deliberately changes. The order is #20716 → this PR, then refresh this branch so the three required checks ( The approval here is not at risk from that refresh: |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20699 +/- ##
=============================================
Coverage ? 82.97%
=============================================
Files ? 2374
Lines ? 126309
Branches ? 38532
=============================================
Hits ? 104811
Misses ? 21090
Partials ? 408
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #20694 to
cloud/1.56Automatically created by backport workflow.