Repository navigation
FE-3355 test(workspace): orthogonality tests for members-panel server-fact gates - #20694
Conversation
Add describeServerFactGate, which checks that a gate renders one server fact: perturbing any non-fact input leaves the output unchanged for either fact value, and flipping the fact changes it. Apply it to the Cloud invite gate (can_invite_members), the member-management gate (can_manage_members) and roster visibility (members response).
📦 Bundle: 9.36 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 4.63 kB (baseline 4.63 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.16 MB (baseline 2.16 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 157 kB (baseline 157 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 19 unchanged Panels & Settings — 671 kB (baseline 671 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 30 unchanged User & Accounts — 54.3 kB (baseline 54.3 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 14 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 13 unchanged UI Components — 201 kB (baseline 201 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 3.06 MB (baseline 3.06 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 22 unchanged Utilities & Hooks — 821 kB (baseline 821 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 54 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.8 MB (baseline 18.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 346 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-10T00:25:45.987Z",
"gitSha": "73a3a26e2820e889ad9fdb121bec4f0ca1c31980",
"branch": "jaewon/fe-3355-server-fact-orthogonality",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.1539999999482,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.842999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.71,
"heapDeltaBytes": 5538060,
"heapUsedBytes": 61665416,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 11.059,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2016.4109999999482,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.6250000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.23799999999994,
"heapDeltaBytes": 5518476,
"heapUsedBytes": 62530736,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.619000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.82400000001,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.896,
"layouts": 12,
"layoutDurationMs": 3.743,
"taskDurationMs": 791.7449999999999,
"heapDeltaBytes": -49392560,
"heapUsedBytes": 57222784,
"domNodes": -237,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 174.01100000000002,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.5680000000511,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.027000000000001,
"layouts": 12,
"layoutDurationMs": 3.049,
"taskDurationMs": 669.327,
"heapDeltaBytes": 932188,
"heapUsedBytes": 57594540,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.659,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66633663366336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.7419999999915,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.4060000000000015,
"layouts": 3,
"layoutDurationMs": 0.531,
"taskDurationMs": 342.93300000000005,
"heapDeltaBytes": 6791116,
"heapUsedBytes": 63446108,
"domNodes": 47,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.066,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.4949999999608,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.984000000000001,
"layouts": 3,
"layoutDurationMs": 0.553,
"taskDurationMs": 367.421,
"heapDeltaBytes": 6799496,
"heapUsedBytes": 63467924,
"domNodes": -167,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 10.919000000000002,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 717.3670000000243,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.35,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.9300000000001,
"heapDeltaBytes": -34224944,
"heapUsedBytes": 71409552,
"domNodes": -237,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 187.847,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06428571428571,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 610.1350000000139,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.750999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.516,
"heapDeltaBytes": 17463532,
"heapUsedBytes": 74311156,
"domNodes": -215,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.672,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1257.74100000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 968.1590000000001,
"heapDeltaBytes": 14230976,
"heapUsedBytes": 97838512,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 69.059,
"eventListeners": 0,
"totalBlockingTimeMs": 609,
"frameDurationMs": 36.76176470588237,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1175.0930000000608,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 832.9559999999999,
"heapDeltaBytes": 13641292,
"heapUsedBytes": 97182240,
"domNodes": 0,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 65.68099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 537,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.649000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.0749999999998,
"heapDeltaBytes": 19103272,
"heapUsedBytes": 97331784,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 175.54800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.6849999999895,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.31900000000064,
"heapDeltaBytes": -4584428,
"heapUsedBytes": 96934800,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 174.08,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10862.788000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9974.565,
"heapDeltaBytes": 1652920,
"heapUsedBytes": 85346052,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 8528.893,
"eventListeners": 0,
"totalBlockingTimeMs": 1519,
"frameDurationMs": 33.74596273291925,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10935.909999999922,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05199999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10077.276000000002,
"heapDeltaBytes": 16085636,
"heapUsedBytes": 105724820,
"domNodes": -172,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 8417.092999999999,
"eventListeners": -77,
"totalBlockingTimeMs": 1413,
"frameDurationMs": 32.01608187134503,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11091.447000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10225.122000000001,
"heapDeltaBytes": -533480,
"heapUsedBytes": 82660212,
"domNodes": 0,
"jsHeapTotalBytes": -13893632,
"scriptDurationMs": 8385.265000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1446,
"frameDurationMs": 31.665428571428574,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9444.340000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8579.102,
"heapDeltaBytes": -9574664,
"heapUsedBytes": 73716108,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 6993.413,
"eventListeners": 0,
"totalBlockingTimeMs": 557,
"frameDurationMs": 31.710402684563753,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 230.41299999999865,
"styleRecalcs": 23,
"styleRecalcDurationMs": 19.593,
"layouts": 5,
"layoutDurationMs": 1.7730000000000001,
"taskDurationMs": 170.19799999999998,
"heapDeltaBytes": 12146792,
"heapUsedBytes": 80624924,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.69,
"eventListeners": 202,
"totalBlockingTimeMs": 11,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "large-combo-open",
"durationMs": 213.31900000006954,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.809,
"layouts": 5,
"layoutDurationMs": 1.6330000000000002,
"taskDurationMs": 149.50800000000004,
"heapDeltaBytes": -10965984,
"heapUsedBytes": 75405804,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.416,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2021.9270000000051,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.368,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.078,
"heapDeltaBytes": -1177428,
"heapUsedBytes": 81116132,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 40.06799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.346999999917,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.712999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.571,
"heapDeltaBytes": -39389804,
"heapUsedBytes": 85638052,
"domNodes": -313,
"jsHeapTotalBytes": -3768320,
"scriptDurationMs": 35.845,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2484.9890000000414,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.802,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1674.4689999999998,
"heapDeltaBytes": 20874884,
"heapUsedBytes": 86715988,
"domNodes": -172,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 871.031,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66510067114094,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2375.543999999991,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.786999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1650.5339999999999,
"heapDeltaBytes": 20699852,
"heapUsedBytes": 85639920,
"domNodes": -313,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 819.8969999999999,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78510638297872,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3556.156000000044,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.656000000000001,
"layouts": 60,
"layoutDurationMs": 9.026,
"taskDurationMs": 1636.5629999999999,
"heapDeltaBytes": 11951828,
"heapUsedBytes": 79515052,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 754.8829999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66619718309859,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3613.213000000087,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.338999999999999,
"layouts": 60,
"layoutDurationMs": 9.245,
"taskDurationMs": 1642.47,
"heapDeltaBytes": 7898272,
"heapUsedBytes": 75087928,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 755.289,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2917.9909999999722,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.128999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.027,
"heapDeltaBytes": 17770676,
"heapUsedBytes": 84744468,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 960.897,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761494252873565,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2940.663000000086,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.151,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1884.744,
"heapDeltaBytes": 21558352,
"heapUsedBytes": 89116704,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 958.887,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.95491329479769,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2050.5319999999756,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.3229999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.4990000000001,
"heapDeltaBytes": -40114936,
"heapUsedBytes": 86195216,
"domNodes": -313,
"jsHeapTotalBytes": -2719744,
"scriptDurationMs": 31.663000000000004,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.802459016393446,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.7580000000444,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.2830000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.6860000000001,
"heapDeltaBytes": -40715136,
"heapUsedBytes": 85333600,
"domNodes": -313,
"jsHeapTotalBytes": -3768320,
"scriptDurationMs": 35.717,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.8730000000205,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.871,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.83099999999996,
"heapDeltaBytes": 13220796,
"heapUsedBytes": 69496468,
"domNodes": -233,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.128,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.1519999999791,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.232,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.115,
"heapDeltaBytes": -7908192,
"heapUsedBytes": 64725492,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.41700000000003,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.3349999999741,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.237,
"heapDeltaBytes": 5521032,
"heapUsedBytes": 62205368,
"domNodes": -235,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 9.671,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.888000000018,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7939999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.2610000000001,
"heapDeltaBytes": 5581148,
"heapUsedBytes": 62081980,
"domNodes": -235,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.732000000000001,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1811.1439999999561,
"styleRecalcs": 57,
"styleRecalcDurationMs": 16.651,
"layouts": 16,
"layoutDurationMs": 4.299,
"taskDurationMs": 953.572,
"heapDeltaBytes": -22193972,
"heapUsedBytes": 79258232,
"domNodes": -235,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 115.505,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1963.3559999999761,
"styleRecalcs": 86,
"styleRecalcDurationMs": 18.394000000000002,
"layouts": 16,
"layoutDurationMs": 4.582,
"taskDurationMs": 1022.4790000000002,
"heapDeltaBytes": 23913148,
"heapUsedBytes": 80387340,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.45899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.909000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 29.87100000000001,
"layouts": 5,
"layoutDurationMs": 14.629999999999997,
"taskDurationMs": 962.4280000000001,
"heapDeltaBytes": 12054220,
"heapUsedBytes": 113106240,
"domNodes": 14650,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.041999999999998,
"eventListeners": 2456,
"totalBlockingTimeMs": 134,
"frameDurationMs": 19.4054794520548,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8501.03200000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.18,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5568.774,
"heapDeltaBytes": -43034684,
"heapUsedBytes": 82093452,
"domNodes": -313,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 2603.6800000000003,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698818897637796,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9043.785999999955,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.633000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5808.258000000001,
"heapDeltaBytes": -42464880,
"heapUsedBytes": 82416316,
"domNodes": -313,
"jsHeapTotalBytes": -4624384,
"scriptDurationMs": 2717.324,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666051660516604,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17749.661000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17111.071000000004,
"heapDeltaBytes": -46695472,
"heapUsedBytes": 184213776,
"domNodes": -3046,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 303.85499999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 30.134634974533107,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 13063.632999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12397.686,
"heapDeltaBytes": -32505040,
"heapUsedBytes": 187468040,
"domNodes": -3046,
"jsHeapTotalBytes": 11104256,
"scriptDurationMs": 212.90599999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.39262295081967,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 22382.349999999973,
"styleRecalcs": 177,
"styleRecalcDurationMs": 13.819999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21976.075999999997,
"heapDeltaBytes": -12421684,
"heapUsedBytes": 189416452,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 882.4499999999999,
"eventListeners": -14913,
"totalBlockingTimeMs": 17,
"frameDurationMs": 40.548007246376805,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 23128.217999999946,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.13200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22764.507999999998,
"heapDeltaBytes": -27434132,
"heapUsedBytes": 188843916,
"domNodes": -3046,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 856.412,
"eventListeners": -14913,
"totalBlockingTimeMs": 8,
"frameDurationMs": 42.8375925925926,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6297.7260000000115,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.207,
"layouts": 20,
"layoutDurationMs": 21.26,
"taskDurationMs": 6185.907,
"heapDeltaBytes": -13758740,
"heapUsedBytes": 215128952,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 94.692,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.88703703703703,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5000.5539999999655,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.185,
"layouts": 20,
"layoutDurationMs": 23.291000000000007,
"taskDurationMs": 4861.799999999999,
"heapDeltaBytes": -1675092,
"heapUsedBytes": 217797116,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 93.04100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.410588235294124,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9555.075999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9223.768,
"heapDeltaBytes": -30997744,
"heapUsedBytes": 183593976,
"domNodes": -3046,
"jsHeapTotalBytes": 10039296,
"scriptDurationMs": 194.88699999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.9296551724138,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9595.485000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9260.682,
"heapDeltaBytes": -37454524,
"heapUsedBytes": 183449660,
"domNodes": -3046,
"jsHeapTotalBytes": 4915200,
"scriptDurationMs": 143.90699999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.651700680272114,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 453.65800000001855,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.716,
"layouts": 4,
"layoutDurationMs": 1.497,
"taskDurationMs": 124.06,
"heapDeltaBytes": 6330168,
"heapUsedBytes": 63007900,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.135000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 123.94799999992756,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.752,
"layouts": 4,
"layoutDurationMs": 3.1119999999999997,
"taskDurationMs": 84.77299999999998,
"heapDeltaBytes": 4126720,
"heapUsedBytes": 60563972,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.101,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 806.8489999999429,
"styleRecalcs": 77,
"styleRecalcDurationMs": 86.931,
"layouts": 76,
"layoutDurationMs": 17.269,
"taskDurationMs": 769.854,
"heapDeltaBytes": 17006540,
"heapUsedBytes": 91445400,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 314.93,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664583333333344,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 798.6439999999675,
"styleRecalcs": 77,
"styleRecalcDurationMs": 87.73100000000001,
"layouts": 76,
"layoutDurationMs": 18.618,
"taskDurationMs": 765.1,
"heapDeltaBytes": 16899544,
"heapUsedBytes": 91296472,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 309.394,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664583333333344,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1388.8640000000123,
"styleRecalcs": 77,
"styleRecalcDurationMs": 241.08599999999998,
"layouts": 76,
"layoutDurationMs": 19.446,
"taskDurationMs": 1364.845,
"heapDeltaBytes": -19590436,
"heapUsedBytes": 120635276,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 477.73499999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.498749999999994,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1448.3210000000781,
"styleRecalcs": 77,
"styleRecalcDurationMs": 246.694,
"layouts": 76,
"layoutDurationMs": 19.735,
"taskDurationMs": 1420.3120000000001,
"heapDeltaBytes": -19362580,
"heapUsedBytes": 116879256,
"domNodes": 77,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 487.79699999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.899999999999995,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2248 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fde33bcd3d6b175ad067d96d02e08e53a49dce09
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20694 +/- ##
==========================================
+ Coverage 86.03% 86.81% +0.78%
==========================================
Files 3617 2569 -1048
Lines 173268 145079 -28189
Branches 47852 39816 -8036
==========================================
- Hits 149069 125950 -23119
+ Misses 22191 18741 -3450
+ Partials 2008 388 -1620
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1058 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
CI has settled since the last pass (CodeRabbit/typecheck/pr-risk all complete) — no change to content from the already-verified mechanism: a describeServerFactGate test helper asserting every non-fact perturbation leaves read() unchanged at a fixed fact value, and flipping the fact changes it, applied to the three Cloud members-panel gates, plus one CODEOWNERS line for /src/platform/workspace/. The PR's AS-IS/TO-BE table reproduces both historical defects (#18662 and #15675) by hand and shows the new tests catching both and passing clean after revert.
Zero open threads, CodeRabbit APPROVED, CI fully green. Approving.
|
@dante01yoon Successfully backported to #20698 |
|
@dante01yoon Successfully backported to #20699 |
…mbined gate fails to compile (Comfy-Org#20818) ## Why FE-3361 (L1, server-fact guardrails). The changed-line lint (Comfy-Org#20679, refined in Comfy-Org#20806) is syntactic. It loses a server fact once the fact crosses a function, file, prop or store boundary under another name (Comfy-Org#19455 hid its derivation behind a helper). A type travels with the value, so the rule ("a gate renders one server fact as received", ADR-API-SERVER-FACTS-0042) can hold across boundaries. ## How **Design, picked from three options.** A boolean with a phantom brand keyed by the API field: ```ts type ServerFact<Field extends string, T = boolean> = T & { readonly [serverFactKey]: Field } receiveServerFact(field, value) // the only constructor (one cast) narrowServerFact(fact, localAllows) // ADR rule 1: local UI state may withhold, never grant pendingServerFact(ticket, value) // now returns a ServerFact; call shape unchanged ``` A gate slot typed `ServerFact<'can_invite_members'>` rejects all of these at compile time: - `fact || local` - `fact && !isLoading` - `isCloud ? fact : x` - `!fact` - a plain boolean - another field's fact Reading a fact needs no unwrapping (`if (fact)`, `v-if`, a boolean prop), because its runtime value is the boolean. **Rejected options** (probed with `tsc --strict`; full table in the design note): - **An opaque `{ granted }` object read through `renderFact()`.** TypeScript accepts `obj || local`, so the Comfy-Org#18662 shape compiles. Worse, `v-if="fact"` on an object is always truthy and vue-tsc doesn't check `v-if`, so one forgotten unwrap silently grants access. - **A ref-shaped alias.** It adds a name, not a guarantee. **Prototype on one surface.** - `useBillingCapabilities` `canInviteMembers` / `canManageMembers` return facts. - `useMembersPanel` `permissions` declares its four gate slots as facts and reads them from `useBillingCapabilities` directly; its `isCloud ? fact : role` lines are gone. The members panel is only registered on Cloud (`useSettingUI`), so the off-Cloud branch was unreachable and is deleted rather than given a local provider. The desktop visibility table in `useMembersPanel.test.ts` only exercised that branch and goes with it. - ADR-API-SERVER-FACTS-0042 now lists `ServerFact<Field>` as adopted surface by surface instead of deferred. - `serverFact.test.ts` proves each forbidden form with `@ts-expect-error`. **Limits.** - The guarantee holds only at slots typed as the fact. A `boolean`-typed gate or an inline template expression still accepts anything. - `factA && factB` assigned to `factB`'s slot compiles, and no encoding closes it. The lint stays required for that case, and a test covers it. ## AS IS / TO BE No UI or behaviour change. | Reintroduce Comfy-Org#18662 (`canInviteMembers.value \|\| isPlanEnded.value`) into the gate | AS IS | TO BE | |---|---|---| | Typecheck | passes | `vue-tsc` TS2322 at the slot | | Orthogonality tests (Comfy-Org#20694) | fail at runtime | fail at runtime | ## Decisions Resolved since the draft: 1. **Desktop/OSS member facts.** No local provider is needed: the members panel never renders off Cloud, so the role-and-seat fallback was dead code and is deleted. No lint exemption is added. 2. **ADR update.** Revised in this PR (Enforcement list and Alternatives considered). Decided as recommended (reversible): - Names `receiveServerFact` / `narrowServerFact`, so grep and lint targets stay unambiguous. - `pendingServerFact` keeps `(ticket, value)`, so the expiry script is unchanged. - Boolean facts only for now. ## Verification - `vitest run src/platform/serverFacts src/platform/workspace/composables tools/oxlint-plugins/serverFacts.test.ts`: 1140 passed on current main. - Mutation: the Comfy-Org#18662 shape fails `vue-tsc` with TS2322 at the slot. - Found while prototyping: `receiveServerFact('x', true)` inferred the literal type `true`, which TypeScript treats as always truthy, so `fact || local` passed. Fixed by widening booleans in both constructors (`FactValue<T>`). The type test caught it. - `pnpm lint:server-facts --base <merge-base>`: no findings on changed lines. - `vitest run src/platform/workspace src/platform/serverFacts tools/oxlint-plugins`: 2950 passed. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L6 A1: render capability reads | FE-3366 | Comfy-Org#20805 | Merged | | L6 lint rule refinement | FE-3366 | Comfy-Org#20806 | Merged | | **L1 `ServerFact` type (members panel)** | **FE-3361** | **this PR** | **In review** | | L2 local providers | FE-3362 | — | Not started; the members panel needs none | | L1 migration of the remaining surfaces (seats, lifecycle, top-up, subscribe) | FE-3361 | — | After this lands | ```mermaid graph LR A1["L6 A1 (PR 20805, merged)"] --> L1["L1 ServerFact type (this PR)"]:::current R["L6 rules (PR 20806, merged)"] --> L1 L1 --> M["L1 migrate remaining surfaces"] classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ```
Why
BE-19903 and BE-19904 shipped because members-panel gates recombined a server capability with plan state, seats and role. #19455 hid the derivation behind a helper and an
if/return, so the lint rules (#20679) can't see it. The existing tests also didn't catch it: they mocked the capability at the composable, and one asserted the derivation as expected behaviour.Root cause
No test asserted the property that matters: a gate's output depends only on its server fact. Each test pinned one combination of inputs, so a gate that also read
isPlanEndedpassed every test that didn't happen to flip it.How
describeServerFactGate(src/utils/__tests__/serverFactGate.ts, about 50 lines). Given a fact setter, a list of non-fact perturbations,mountandread, it generatesit.forcases over both fact values and every perturbation:read()unchanged.Applied to the Cloud members-panel gates in
useMembersPanel.test.ts:can_invite_membersshowInviteButton,isInviteDisabled,permissions.canInviteMemberscan_manage_memberscanManageMembers,canViewPendingInvites,uiConfig.showPendingTab, member menu non-emptymembersLoaded)canViewOtherMembers,showMembersListShared perturbations:
maxSeats1,maxSeats1can_change_seatsflippedEach gate also flips the capabilities it must not depend on. Invite flips
can_manage_members, management flipscan_invite_members, and roster flips both, so one capability can't stand in for another.CODEOWNERS:/src/platform/workspace/gets the billing owners. The incident lived there, and it was the only billing-adjacent path without owners.AS IS / TO BE
There is no UI change. These are test outcomes on the two historical defects, each reintroduced by hand and not committed:
showInviteButton(canInviteMembers || (isPlanEnded && canManageSubscription))canManageMembers←canChangeSeats)Verification
vitest run src/platform/workspace/composables/useMembersPanel.test.ts: 158 passed.--type-awareand oxfmt--checkpass on touched files. The pre-commit hook rantypecheck:app.Plan position
TDD: Server-fact guardrails. Parent: FE-3349.
pendingServerFact+ expiry CI