Repository navigation
FE-3260 fix(dialog): centre a dialog on the viewport when it cannot fit beside the docked panel - #20328
Conversation
…s on the viewport
…e the docked panel
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fd430c2dd6159d164907ec85863baaa7b7383934
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2235 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10.3 MB gzip 🔴 +13.5 kBDetailsSummary
Category Glance App Entry Points — 4.17 kB (baseline 4.1 kB) • 🔴 +63 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • 🔴 +2 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 143 kB (baseline 136 kB) • 🔴 +7.84 kBTop-level views, pages, and routed surfaces
Status: 16 added / 16 removed / 2 unchanged Panels & Settings — 672 kB (baseline 672 kB) • 🔴 +147 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 18 unchanged User & Accounts — 54.4 kB (baseline 53.9 kB) • 🔴 +531 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 4 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed UI Components — 205 kB (baseline 205 kB) • 🔴 +2 BReusable component library chunks
Status: 20 added / 20 removed Data & Services — 4.18 MB (baseline 4.17 MB) • 🔴 +12.9 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 582 kB (baseline 580 kB) • 🔴 +1.67 kBHelpers, composables, and utility bundles
Status: 23 added / 23 removed / 15 unchanged Vendor & Third-Party — 17.3 MB (baseline 17.3 MB) • 🔴 +1.27 kBExternal libraries and shared vendor chunks
Status: 1 added / 1 removed / 17 unchanged Other — 18.6 MB (baseline 18.5 MB) • 🔴 +16.8 kBBundles that do not match a named category
Status: 129 added / 125 removed / 187 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-06T19:20:54.948Z",
"gitSha": "7b31c6cda349130546e328c51840df6cc84fcf82",
"branch": "fix/modal-dialog-center-viewport",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.9869999999905,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.333,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.771,
"heapDeltaBytes": 3484468,
"heapUsedBytes": 64933184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.929000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.1159999999727,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3080000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 240.901,
"heapDeltaBytes": 2562476,
"heapUsedBytes": 57385260,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.316999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.5829999999796,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.607999999999999,
"layouts": 12,
"layoutDurationMs": 4.725,
"taskDurationMs": 590.82,
"heapDeltaBytes": -1067408,
"heapUsedBytes": 59402188,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 117.547,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1702.3410000000467,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.391999999999998,
"layouts": 12,
"layoutDurationMs": 4.266000000000001,
"taskDurationMs": 498.16099999999994,
"heapDeltaBytes": 25546544,
"heapUsedBytes": 80477288,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.16,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.3579999999852,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.941,
"layouts": 3,
"layoutDurationMs": 1.024,
"taskDurationMs": 249.658,
"heapDeltaBytes": 4848620,
"heapUsedBytes": 64865936,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.142999999999999,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.7350000000515,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.949,
"layouts": 3,
"layoutDurationMs": 0.8730000000000001,
"taskDurationMs": 205.41600000000003,
"heapDeltaBytes": 9700552,
"heapUsedBytes": 77909540,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.418999999999999,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 528.521000000012,
"styleRecalcs": 17,
"styleRecalcDurationMs": 4.258,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.493,
"heapDeltaBytes": -5664820,
"heapUsedBytes": 61603612,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 113.36200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 454.79899999997997,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7619999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.0659999999999,
"heapDeltaBytes": 16393724,
"heapUsedBytes": 71373756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.595,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 923.2989999999859,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.4150000000001,
"heapDeltaBytes": 13524600,
"heapUsedBytes": 94551180,
"domNodes": 0,
"jsHeapTotalBytes": 1474560,
"scriptDurationMs": 42.491,
"eventListeners": 0,
"totalBlockingTimeMs": 302,
"frameDurationMs": 27.775757575757574,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 883.3319999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.494,
"heapDeltaBytes": 18208592,
"heapUsedBytes": 90143672,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 32.74100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 262,
"frameDurationMs": 25.979411764705873,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.5040000000236,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.16299999999984,
"heapDeltaBytes": -8583252,
"heapUsedBytes": 79979608,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 95.76599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.5660000000607,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 264.60599999999965,
"heapDeltaBytes": -12940148,
"heapUsedBytes": 109073292,
"domNodes": 0,
"jsHeapTotalBytes": 4722688,
"scriptDurationMs": 90.13000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 90,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6846.912999999972,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.952999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5623.706,
"heapDeltaBytes": 15826960,
"heapUsedBytes": 86846200,
"domNodes": -141,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 4385.817,
"eventListeners": -69,
"totalBlockingTimeMs": 63,
"frameDurationMs": 21.60788643533123,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5659.83,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1470000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4663.004000000001,
"heapDeltaBytes": 12478432,
"heapUsedBytes": 98904624,
"domNodes": -141,
"jsHeapTotalBytes": -1708032,
"scriptDurationMs": 3858.9500000000003,
"eventListeners": -73,
"totalBlockingTimeMs": 4,
"frameDurationMs": 20.832352941176474,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6642.898999999999,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3310000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5459.12,
"heapDeltaBytes": -2939252,
"heapUsedBytes": 82858832,
"domNodes": -141,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 4309.343,
"eventListeners": -73,
"totalBlockingTimeMs": 14,
"frameDurationMs": 20.793103448275865,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5979.249999999979,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9209999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4795.77,
"heapDeltaBytes": 23576736,
"heapUsedBytes": 94653792,
"domNodes": -141,
"jsHeapTotalBytes": -10096640,
"scriptDurationMs": 3839.753,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.238263665594854,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2013.2810000000063,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3609999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.32200000000006,
"heapDeltaBytes": -2896812,
"heapUsedBytes": 86693216,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.52100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.0799999999508,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7799999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.29099999999994,
"heapDeltaBytes": -49826824,
"heapUsedBytes": 80483728,
"domNodes": -308,
"jsHeapTotalBytes": -4554752,
"scriptDurationMs": 28.756,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2447.2279999999955,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.215000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1155.135,
"heapDeltaBytes": -6031852,
"heapUsedBytes": 84963032,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 592.561,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665986394557827,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2368.847999999957,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.086,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1139.223,
"heapDeltaBytes": -18048844,
"heapUsedBytes": 70852072,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 586.574,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3287.861000000021,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.092,
"layouts": 60,
"layoutDurationMs": 17.873,
"taskDurationMs": 1186.7939999999999,
"heapDeltaBytes": 8733468,
"heapUsedBytes": 85955880,
"domNodes": 24,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 543.916,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66598984771574,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3154.0959999999814,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.365,
"layouts": 60,
"layoutDurationMs": 16.814,
"taskDurationMs": 1105.174,
"heapDeltaBytes": 3906140,
"heapUsedBytes": 68985548,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 517.178,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137568,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2369.3440000000123,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.175999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1387.1370000000002,
"heapDeltaBytes": 4663060,
"heapUsedBytes": 73428524,
"domNodes": 0,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 728.1650000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 7,
"frameDurationMs": 16.90357142857143,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2562.5479999999925,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.7170000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1482.015,
"heapDeltaBytes": -9086828,
"heapUsedBytes": 75909592,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 811.268,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774509803921564,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2004.5929999999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3779999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.474,
"heapDeltaBytes": -4985832,
"heapUsedBytes": 77234220,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 30.917999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.1020000000462,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6569999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.673,
"heapDeltaBytes": 20760908,
"heapUsedBytes": 89802888,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 21.238,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 428.1480000000215,
"styleRecalcs": 50,
"styleRecalcDurationMs": 6.793000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.79,
"heapDeltaBytes": -9127700,
"heapUsedBytes": 61110208,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 100.954,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.94099999994614,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.999999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 256.271,
"heapDeltaBytes": 11811752,
"heapUsedBytes": 75900612,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 94.114,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000005,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.430000000009,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.555,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.076,
"heapDeltaBytes": 7959720,
"heapUsedBytes": 79400988,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.932,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.7050000000108,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1719999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 254.79599999999996,
"heapDeltaBytes": 7984768,
"heapUsedBytes": 79131292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.521999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.3289999999865,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.399,
"layouts": 16,
"layoutDurationMs": 6.263,
"taskDurationMs": 570.4520000000001,
"heapDeltaBytes": 21176792,
"heapUsedBytes": 76161068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.809,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.7489999999916,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.419,
"layouts": 16,
"layoutDurationMs": 5.607,
"taskDurationMs": 465.1170000000001,
"heapDeltaBytes": -4300048,
"heapUsedBytes": 59525024,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 73.27600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 818.0980000000204,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.873,
"layouts": 5,
"layoutDurationMs": 9.234,
"taskDurationMs": 589.1060000000001,
"heapDeltaBytes": 32530672,
"heapUsedBytes": 108297888,
"domNodes": 14570,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 19.272,
"eventListeners": 2458,
"totalBlockingTimeMs": 53,
"frameDurationMs": 18.559090909090898,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8656.863999999985,
"styleRecalcs": 249,
"styleRecalcDurationMs": 24.825999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4144.298,
"heapDeltaBytes": 7311716,
"heapUsedBytes": 87209692,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 2043.5639999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665961538461538,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8137.5209999999925,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.179000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3620.9829999999997,
"heapDeltaBytes": 1469572,
"heapUsedBytes": 74219356,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 1905.038,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618852459016,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13306.758000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12713.782,
"heapDeltaBytes": -40782380,
"heapUsedBytes": 183508736,
"domNodes": -3046,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 200.03900000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.77311643835617,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 12765.83100000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11859.246000000001,
"heapDeltaBytes": -42724500,
"heapUsedBytes": 182854924,
"domNodes": -3046,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 169.40099999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.793846153846157,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 15658.638999999994,
"styleRecalcs": 84,
"styleRecalcDurationMs": 11.631000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15311.394999999997,
"heapDeltaBytes": -10596828,
"heapUsedBytes": 202524900,
"domNodes": -3076,
"jsHeapTotalBytes": 9650176,
"scriptDurationMs": 675.284,
"eventListeners": -14915,
"totalBlockingTimeMs": 2,
"frameDurationMs": 28.942909760589316,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 15077.478999999927,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.287999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14656.134999999998,
"heapDeltaBytes": -9395628,
"heapUsedBytes": 191924228,
"domNodes": -3046,
"jsHeapTotalBytes": 7290880,
"scriptDurationMs": 606.1220000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 45,
"frameDurationMs": 27.403811252268607,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4819.373999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.18700000000001,
"layouts": 20,
"layoutDurationMs": 25.299000000000003,
"taskDurationMs": 4705.262,
"heapDeltaBytes": -13190360,
"heapUsedBytes": 216785240,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 81.09499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 10,
"frameDurationMs": 29.392727272727278,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4578.009999999949,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.932,
"layouts": 20,
"layoutDurationMs": 22.97700000000001,
"taskDurationMs": 4490.499,
"heapDeltaBytes": -7117388,
"heapUsedBytes": 208902396,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 74.415,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.46222222222222,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6647.448999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6439.9130000000005,
"heapDeltaBytes": -35741932,
"heapUsedBytes": 184706572,
"domNodes": -3046,
"jsHeapTotalBytes": 7217152,
"scriptDurationMs": 98.19999999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.872758620689662,
"p95FrameDurationMs": 33.5
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6431.284000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6063.652000000001,
"heapDeltaBytes": -33000776,
"heapUsedBytes": 183703308,
"domNodes": -3046,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 91.92700000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.571929824561405,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "workflow-execution",
"durationMs": 87.45799999996962,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.314000000000002,
"layouts": 4,
"layoutDurationMs": 1.8069999999999997,
"taskDurationMs": 66.001,
"heapDeltaBytes": 4365988,
"heapUsedBytes": 58957432,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.926999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 447.1000000000913,
"styleRecalcs": 17,
"styleRecalcDurationMs": 15.796999999999999,
"layouts": 3,
"layoutDurationMs": 1.35,
"taskDurationMs": 96.061,
"heapDeltaBytes": 6184444,
"heapUsedBytes": 64856700,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.607000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 557.4290000000701,
"styleRecalcs": 78,
"styleRecalcDurationMs": 87.547,
"layouts": 76,
"layoutDurationMs": 30.109,
"taskDurationMs": 527.223,
"heapDeltaBytes": 14921128,
"heapUsedBytes": 80581040,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 173.45499999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66764705882355,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 595.8480000000463,
"styleRecalcs": 78,
"styleRecalcDurationMs": 92.624,
"layouts": 76,
"layoutDurationMs": 32.236000000000004,
"taskDurationMs": 560.357,
"heapDeltaBytes": 15289772,
"heapUsedBytes": 80351352,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 184.363,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1084.2059999999947,
"styleRecalcs": 78,
"styleRecalcDurationMs": 315.021,
"layouts": 76,
"layoutDurationMs": 32.995,
"taskDurationMs": 1049.5639999999999,
"heapDeltaBytes": 8808020,
"heapUsedBytes": 119755028,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 284.79499999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615384615385,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1123.3119999999417,
"styleRecalcs": 78,
"styleRecalcDurationMs": 310.039,
"layouts": 76,
"layoutDurationMs": 31.431,
"taskDurationMs": 1096.3569999999997,
"heapDeltaBytes": 9341816,
"heapUsedBytes": 122563436,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 281.582,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588226,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe non-maximized dialog uses a revised horizontal translation. Browser tests expect viewport-centered dialog positions at 1440px and at the small breakpoint. ChangesDialog Viewport Centering
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Dialog placement behaves as intended for dialogs that fit beside the docked panel and those that must center on the viewport. No identified issue remains to block merging. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20328 +/- ##
==========================================
+ Coverage 85.46% 86.24% +0.77%
==========================================
Files 3523 2482 -1041
Lines 169083 141121 -27962
Branches 46302 36432 -9870
==========================================
- Hits 144505 121707 -22798
+ Misses 22593 19033 -3560
+ Partials 1985 381 -1604
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1055 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the exact head. The dialog-centering change is narrowly scoped, preserves the beside-panel case, and adds coverage for the viewport-centered cases. Required checks are settled green and there are no unresolved review threads.
|
@dante01yoon Successfully backported to #20352 |
|
@dante01yoon Successfully backported to #20353 |
Why
With the Agent panel docked, a modal too wide to fit beside the panel (Templates, Choose a Plan, …) sits pinned to the left edge while still covering the panel. It is neither centered nor clear of the panel. Found while verifying 1.56 QA fixes on testcloud. Reported in #bug-dump.
Root cause
dialogContentVariants(maximized: false) positions every modal withtranslate-x: max(calc(min(0.5rem,100vw-100%)-50vw), calc(-50%-inset/2))(#20002, PM-1865).max()falls back to the left-gutter floor, so the dialog stays shifted by up toinset/2and covers the panel anyway. At 1440px with a 420px panel, Templates (1296px wide) lands at x = 8 with 136px empty on the right.How
Apply the inset shift only when the dialog fits beside the panel. Otherwise center on the viewport:
50vw - 50% - inset/2 - 0.5remis the room left of a panel-centered dialog. When it's positive (fits), themin()picks the fullinset/2shift. When it's negative (doesn't fit), it picks0, so the dialog is viewport-centered. The+1pxkeeps a dialog sized exactly to the space beside the panel on the beside-the-panel branch: the 3D viewer caps itself at100vw - inset - 1rem, andload3dAgentUpdate.spec.tsasserts it stays clear of the panel. With no panel the inset is0and every dialog stays at-50%, so layout without a panel is unchanged. The offset stays ontranslate, for the reason in #20002: the zoom keyframes writetransform.mdconfirm, 1440px (fits)mdconfirm, 640px (doesn't fit)AS IS / TO BE
Local cloud app against testcloud, 1440×900, Agent panel docked:
main)Test plan
dialogAgentPanelInset.spec.ts: the 1440px Templates and 640px confirm rows now expect viewport-centered x (72 / 32). The 1920px "centres beside the panel" row is unchanged.Measured in the real app on this branch: Templates at 1440 → x = 72 (both sides 72); confirm at 1440 → x = 222 (beside the panel); confirm at 640 with a 420px inset → x = 32
Fixes FE-3260
Related: PM-1865, fix(dialog): keep modal size independent of the docked Agent panel #20002